[edk2] [PATCH 2/2] MdeModulePkg/DxePrintLibPrint2Protocol: Fix incomplete print output

This is caused by a previous patch which tried to fix string over-read. It's found that that patch for PrintLib in MdePkg will cause premature terminating of loop used to traversing format string and cause incomplete string output. Because this library uses similar code to do the same job, it has

[edk2] [PATCH 0/2] Fix incomplete print output

This is caused by previous patch tring to fix string over-read. The root cause is that the format string may be ascii or unicode but that patch assumes it just ascii string. Jian J Wang (2): MdePkg/BasePrintLib: Fix incomplete print output MdeModulePkg/DxePrintLibPrint2Protocol: Fix

[edk2] [PATCH 1/2] MdePkg/BasePrintLib: Fix incomplete print output

This is caused by previous patch which tried to fix string over-read, which breaks UEFI menu rendering: the following /--\ | Device Manager |

[edk2] [PATCH] MdeModulePkg/MdeModulePkg.dec: clarify Heap Guard usage

Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jian J Wang --- MdeModulePkg/MdeModulePkg.dec | 12 1 file changed, 12 insertions(+) diff --git

Re: [edk2] [PATCH 2/2] MdeModulePkg/DxePrintLibPrint2Protocol: Fix incomplete print output

Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Wang, Jian J Sent: Tuesday, January 2, 2018 4:20 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Yao, Jiewen ; Zeng, Star Subject: [PATCH

Re: [edk2] [PATCH 0/2] Fix incomplete print output

Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jian >J Wang >Sent: Tuesday, January 02, 2018 4:20 PM >To: edk2-devel@lists.01.org >Subject: [edk2] [PATCH 0/2] Fix incomplete print output > >This is

Re: [edk2] [PATCH] MdeModulePkg/MdeModulePkg.dec: clarify Heap Guard usage

Reviewed-by: Star Zeng after you also update the MdeModulePkg.uni accordingly. Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jian J Wang Sent: Tuesday, January 2, 2018 4:27 PM To: edk2-devel@lists.01.org Cc:

Re: [edk2] [PATCH] BaseTools/PcdValueCommon: Fix PcdDataTypeUint64 format string

On 29 December 2017 at 02:58, Alex James wrote: > Hi Liming, > > I was able to reproduce this, will send out the v2 patch shortly. > This is still broken in today's tree. Could we get a fix please? > > On Thu, Dec 28, 2017 at 7:46 PM Gao, Liming

Re: [edk2] [PATCH] BaseTools/PcdValueCommon: Fix PcdDataTypeUint64 format string

On 2 January 2018 at 09:25, Ard Biesheuvel wrote: > On 29 December 2017 at 02:58, Alex James wrote: >> Hi Liming, >> >> I was able to reproduce this, will send out the v2 patch shortly. >> > > This is still broken in today's tree. Could we get

Re: [edk2] [PATCH edk2-platforms v2 00/18] ARM: Update GOP

Hi Ard. Happy New Year! I have no idea what has caused that. I haven't changed the script I use to generate patches, so I'm off to consult our IT guys to find out what's up. I'll resume when I've done that. Sorry, Evan > -Original Message- > From: Ard Biesheuvel

[edk2] [Patch] BaseTools: Fix the regression bug of a74398 for SubFv Image

in version a74398 we use guid value and Fv name as ffs dir for FILE statement, this patch apply this rule on subFv image. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu --- BaseTools/Source/Python/GenFds/Fv.py | 4 ++-- 1 file

Re: [edk2] [Patch] BaseTools: Fix the regression bug of a74398 for SubFv Image

Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Tuesday, January 2, 2018 7:12 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch] BaseTools: Fix the regression bug

Re: [edk2] [PATCH] BaseTools/PcdValueCommon: Fix PcdDataTypeUint64 format string

Ard: The issue is related to UINT64 definition in the different ARCHs. In BaseTools X64 and IA32, typedef uint64_t UINT64. uint64_t doesn't work with %llx. To support all archs and tool chain, I propose to use below style to print X64 value. sprintf(PcdList[Index].Value, "0x%016llx",

Re: [edk2] [PATCH v2 2/3] MdePkg/BaseLib: add attribute 'RETURNS_TWICE' to SetJump

To align to longjump() declaration, could you update SetJump()? UINTN EFIAPI RETURNS_TWICE SetJump ( ); ==> RETURNS_TWICE UINTN EFIAPI SetJump ( ); Thanks Liming > -Original Message- > From: M1cha [mailto:sigmaepsilo...@gmail.com] > Sent: Saturday, December 23, 2017 3:14 AM > To:

Re: [edk2] [PATCH] BaseTools/DevicePath: fix GCC build error in print_mem(), and clean it up

Thanks. Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, January 03, 2018 1:17 AM To: edk2-devel-01 Cc: Gao, Liming ; Zhu,

Re: [edk2] [PATCH edk2-platforms 0/4] NXP:LS2088A RDB Board Support

Hi Ard, Thanks for your time. Below is the sequence in which we have sent the patches. 1. [PATCH edk2-platforms] [PATCH v3 0/9] Platform/NXP [27/11/2017] V3 This patch-set adds support for LS1043 platform, it includes patches for platform initialization and all necessary drivers to

Re: [edk2] [Patch] BaseTools CommonLib: Fix printf %llx issue on UINT64

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Wednesday, January 3, 2018 8:34 AM To: edk2-devel@lists.01.org Subject: [edk2] [Patch] BaseTools

Re: [edk2] [Patch] DSC Spec: Fix a typo error "enty" to "entry"

Reviewed-by: Liming Gao >-Original Message- >From: Zhu, Yonghong >Sent: Tuesday, January 02, 2018 10:17 AM >To: edk2-devel@lists.01.org >Cc: Gao, Liming ; Kinney, Michael D >; Shaw, Kevin W

Re: [edk2] [PATCH] ArmPlatformPkg/MemoryInitPeiLib: mark primary FV region as boot services data

Thanks Ard, This works for us as well Few comments inline Regards Udit > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Tuesday, January 02, 2018 9:21 PM > To: edk2-devel@lists.01.org > Cc: leif.lindh...@linaro.org;

Re: [edk2] [PATCH] MdePkg: resolve bug 741

I choose to disable this warning first, because there are other cases in edk2 project. One is PI S3SaveState protocol EFI_S3_SAVE_STATE_WRITE API. This case needs to update PI spec. It may take more time. typedef EFI_STATUS (EFIAPI *EFI_S3_SAVE_STATE_WRITE)( IN CONST

[edk2] [Patch 2/3] MdeModulePkg/DxeNetLib: Add parameter check and ASSERT handling.

From: Wang Fan * Library API should check the input parameters before use, or ASSERT to tell it has to meet some requirements. But in DxeNetLib, not all functions follows this rule. * ASSERT shouldn't be used as error handling, add some handling code for errors. * Add

[edk2] [Patch 3/3] MdeModulePkg/DxeNetLib: Fix an error in packet length counting.

From: Wang Fan * In old implementation, the operation len-- assumes AsciiSPrint() has counted NULL terminator, and it's not correct. This patch is to fix this issue. Cc: Fu Siyuan Cc: Ye Ting Cc: Jiaxin Wu

[edk2] [Patch 0/3] Fix a set of issues for DxeNetLib

From: Wang Fan See each patch file for details. Wang Fan (3): MdeModulePkg/DxeNetLib: Fix a potential issue in macro definition. MdeModulePkg/DxeNetLib: Add parameter check and ASSERT handling. MdeModulePkg/DxeNetLib: Fix an error in packet length counting.

[edk2] [Patch 1/3] MdeModulePkg/DxeNetLib: Fix a potential issue in macro definition.

From: Wang Fan The NIC_ITEM_CONFIG_SIZE macro in DxeNetLib is defined as: sizeof (NIC_IP4_CONFIG_INFO) + sizeof (EFI_IP4_ROUTE_TABLE) * MAX_IP4_CONFIG_IN_VARIABLE. This macro should be surrounded with parenthesis to avoid being incorrectly used. Cc: Fu Siyuan

[edk2] [Patch] BaseTools: Fix compile error on VS2010

VS2010 also defined RSIZE_MAX, so we undef it first. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu --- BaseTools/Source/C/Common/CommonLib.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

Re: [edk2] [Patch] BaseTools: Fix compile error on VS2010

Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Yonghong Zhu >Sent: Wednesday, January 03, 2018 1:48 PM >To: edk2-devel@lists.01.org >Subject: [edk2] [Patch] BaseTools: Fix compile error on VS2010

Re: [edk2] [Patch 2/3] MdeModulePkg/DxeNetLib: Add parameter check and ASSERT handling.

Reviewed-by: Jiaxin Wu > -Original Message- > From: Wang, Fan > Sent: Wednesday, January 3, 2018 10:32 AM > To: edk2-devel@lists.01.org > Cc: Wang, Fan ; Fu, Siyuan ; Ye, > Ting ; Wu, Jiaxin

Re: [edk2] [Patch 1/3] MdeModulePkg/DxeNetLib: Fix a potential issue in macro definition.

Reviewed-by: Jiaxin Wu > -Original Message- > From: Wang, Fan > Sent: Wednesday, January 3, 2018 10:32 AM > To: edk2-devel@lists.01.org > Cc: Wang, Fan ; Fu, Siyuan ; Ye, > Ting ; Wu, Jiaxin

Re: [edk2] [Patch 3/3] MdeModulePkg/DxeNetLib: Fix an error in packet length counting.

Reviewed-by: Jiaxin Wu > -Original Message- > From: Wang, Fan > Sent: Wednesday, January 3, 2018 10:32 AM > To: edk2-devel@lists.01.org > Cc: Wang, Fan ; Fu, Siyuan ; Ye, > Ting ; Wu, Jiaxin

Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: fix wrong base address set as Stack Guard

Jiewen, Please take a look at this patch. Regards, Jian > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jian J > Wang > Sent: Friday, December 29, 2017 4:37 PM > To: edk2-devel@lists.01.org > Cc: Laszlo Ersek ; Yao,

[edk2] [PATCH] ArmPlatformPkg/MemoryInitPeiLib: mark primary FV region as boot services data

Commit 8ae5fc182941 ("ArmPlatformPkg/MemoryInitPeiLib: don't reserve primary FV in memory") deleted the code that removes the memory covering the primary firmware volume from the memory map. The assumption was that this is no longer necessary now that we no longer expose compression and PE/COFF

[edk2] [PATCH] BaseTools/DevicePath: fix GCC build error in print_mem(), and clean it up

Currently "BaseTools/Source/C/DevicePath/DevicePath.c" fails to build with GCC48: > DevicePath.c: In function 'print_mem': > DevicePath.c:109:5: error: 'for' loop initial declarations are only > allowed in C99 mode > for (size_t i=0; i ^ > DevicePath.c:109:5: note: use

Re: [edk2] [PATCH edk2-platforms 0/4] NXP:LS2088A RDB Board Support

Hello Wasim, Udit, Meenakshi, I kind of lost track of all the patches you have been sending over the past month or so. Could one of you please send a quick summary of all the patches that are in flight at the moment, and for which platforms? Thanks, Ard. On 22 December 2017 at 10:51, Wasim

Re: [edk2] [PATCH] BaseTools/PcdValueCommon: Fix PcdDataTypeUint64 format string

On 2 January 2018 at 12:18, Gao, Liming wrote: > Ard: > The issue is related to UINT64 definition in the different ARCHs. In > BaseTools X64 and IA32, typedef uint64_t UINT64. uint64_t doesn't work with > %llx. To support all archs and tool chain, I propose to use

Re: [edk2] [RFC] MdeModulePkg/PciHostBridge: Add address translation support

On Tue, Jan 02, 2018 at 03:56:14PM +0800, Ni, Ruiyu wrote: > On 12/26/2017 2:50 PM, Guo Heyi wrote: > > Hi Ard, Ray, > > > > Have we come to the final conclusion? Or are we still waiting for more > > comments on this? > > Heyi, > I think you can send out a draft version of changes for better >

Re: [edk2] [PATCH v2 01/13] ArmPlatformPkg: Tidy Lcd code: Coding standard

(fix Leif's email address) On 2 January 2018 at 15:21, Ard Biesheuvel wrote: > On 2 January 2018 at 15:11, Evan Lloyd wrote: >> Hi Ard. >> One aim of these changes is to get those files we have to play with into a >> state where a beautifier like

Re: [edk2] [PATCH v2 01/13] ArmPlatformPkg: Tidy Lcd code: Coding standard

On 2 January 2018 at 15:11, Evan Lloyd wrote: > Hi Ard. > One aim of these changes is to get those files we have to play with into a > state where a beautifier like indent, astyle, or clang-format can be used to > help tidy our changes. (NOTE, we do not have that fully

[edk2] Fwd: FW: [tianocore/edk2] BaseTools: Barf on unknown HOST_ARCH in C Makefile (#122)

Sure. Thanks, -Chema -- Forwarded message -- From: Gao, Liming Date: Wed, Dec 27, 2017 at 5:48 PM Subject: FW: [tianocore/edk2] BaseTools: Barf on unknown HOST_ARCH in C Makefile (#122) To: "che...@gmail.com" Could you send patch to

[edk2] [Patch] BaseTools: Fix the error about loop initial declarations

From: Yunhua Feng We met compile error about loop initial declarations are only allowed in C99 or C11 mode on GCC48/GCC49. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yunhua Feng ---

Re: [edk2] [PATCH v2 01/13] ArmPlatformPkg: Tidy Lcd code: Coding standard

Hi Ard. One aim of these changes is to get those files we have to play with into a state where a beautifier like indent, astyle, or clang-format can be used to help tidy our changes. (NOTE, we do not have that fully working yet, but they do help.) In a world where we have to play with

Re: [edk2] [PATCH] ArmPlatformPkg/MemoryInitPeiLib: mark primary FV region as boot services data

On 3 January 2018 at 05:09, Udit Kumar wrote: > Thanks Ard, > This works for us as well > Few comments inline > > > Regards > Udit > >> -Original Message- >> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >> Sent: Tuesday, January 02, 2018 9:21 PM >> To:

[edk2] [Patch] BaseTools CommonLib: Fix printf %llx issue on UINT64

UINT64 is defined as the different type for the different ARCHs. To let it work for all archs and compilers, add (unsigned long long) for the input value together with %llx. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao ---

Re: [edk2] [PATCH] ArmPlatformPkg/MemoryInitPeiLib: mark primary FV region as boot services data

> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Tuesday, January 2, 2018 7:51 AM > To: edk2-devel@lists.01.org > Cc: leif.lindh...@linaro.org; vladimir.olovyanni...@broadcom.com; > udit.ku...@nxp.com; meenakshi.aggar...@nxp.com; Ard Biesheuvel >