Re: [edk2] help

2018-01-11 Thread Gao, Liming
Could you type build --version to get its build version? And, please let me know your build command and step. Thanks Liming > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of 赵彦峰 > Sent: Thursday, January 11, 2018 1:52 PM > To:

Re: [edk2] [PATCH] OvmfPkg/VirtioScsiDxe: Allocate all required vrings at VirtioScsiInit

2018-01-11 Thread Maxime Coquelin
Hi Xiang, On 12/14/2017 02:25 PM, zhengxiang (A) wrote: On 2017/12/14 17:06, Paolo Bonzini wrote: On 14/12/2017 07:55, zhengxiang (A) wrote: Hello Laszlo and Paolo, Thanks for your review! On 2017/12/13 19:16, Laszlo Ersek wrote: On 12/13/17 10:29, Paolo Bonzini wrote: On 13/12/2017

[edk2] [Patch v2] MdeModulePkg/DxeNetLib: Add array range check in NetIp6IsNetEqual().

2018-01-11 Thread Wang Fan
V2 * Added an ASSERT check for the case PrefixLength equals to IP6_PREFIX_MAX. * Synced some code descriptions to head file. Cc: Fu Siyuan Cc: Jiaxin Wu Cc: Hao Wu Contributed-under: TianoCore Contribution Agreement 1.0

Re: [edk2] [Patch] Edk2: Retire Edk2Setup.bat

2018-01-11 Thread Laszlo Ersek
On 01/11/18 09:21, Liming Gao wrote: > Edk2Setup.bat is out of maintain. It is a draft version batch file, and not > implement all features listed in its header file. To avoid the confuse, > drop it from edk2 project, and keep edksetup.bat only. > > Contributed-under: TianoCore Contribution

[edk2] [Patch] MdeModulePkg/Ip4Dxe: Add an independent timer for reconfig checking

2018-01-11 Thread Wang Fan
* Since wireless network can switch at very short time, the time interval of reconfig event checking is too long for this case. To achieve better performance and scalability, separate this task from Ip4 tick timer. Cc: Jiaxin Wu Cc: Ye Ting Cc: Fu

Re: [edk2] [PATCH v4 4/6] ArmPkg/Library/CompilerIntrinsicsLib: Enable VS2017/ARM builds

2018-01-11 Thread Ard Biesheuvel
On 10 January 2018 at 16:26, Pete Batard wrote: > Introduce CRT assembly replacements for __rt_sdiv, __rt_udiv, > __rt_udiv64, __rt_sdiv64, __rt_srsh (by reusing the RVCT code) > as well as memcpy and memset. > For MSFT compatibility, some of the code needs to be explicitly > forced

[edk2] help

2018-01-11 Thread 赵彦峰
build... : error C0DE: Unknown fatal error when processing [c:\edk2\Nt32Pkg\Nt32Pkg.dsc] (Please send email to edk2-devel@lists.01.org for help, attaching following call stack trace!) (Python 2.7.3 on win32) Traceback (most recent call last): File "build\build.py", line 2477, in Main

Re: [edk2] [Patch] MdeModulePkg/DxeNetLib: Add array range check in NetIp6IsNetEqual().

2018-01-11 Thread Wang, Fan
Thanks, Jiaxin, I will revise it. Best Regards Fan -Original Message- From: Wu, Jiaxin Sent: Thursday, January 11, 2018 3:48 PM To: Wang, Fan ; edk2-devel@lists.01.org Cc: Fu, Siyuan ; Wu, Hao A Subject: RE: [Patch]

[edk2] [Patch] Edk2: Retire Edk2Setup.bat

2018-01-11 Thread Liming Gao
Edk2Setup.bat is out of maintain. It is a draft version batch file, and not implement all features listed in its header file. To avoid the confuse, drop it from edk2 project, and keep edksetup.bat only. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao

Re: [edk2] [PATCH 2/2] ArmPkg/ArmArchTimerLib: Implement GetElapsedTime function of TimerLib

2018-01-11 Thread Laszlo Ersek
On 01/11/18 07:28, Pankaj Bansal wrote: > Hi Laszlo, > >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Wednesday, January 10, 2018 10:34 PM >> To: Pankaj Bansal ; edk2-devel@lists.01.org >> Cc: Leif Lindholm

Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: fix 32-bit build error

2018-01-11 Thread Laszlo Ersek
On 01/11/18 02:02, Jian J Wang wrote: > Cc: Dandan Bi > Cc: Eric Dong > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Jian J Wang > --- >

[edk2] [Patch] NetworkPkg: Fix incorrect parameter check in PXE.Mtftp() function.

2018-01-11 Thread Fu Siyuan
According to UEFI spec, the PXE.Mtftp() should return invalid parameter if the BufferPtr parameter was NULL and the DontUseBuffer parameter was FALSE. The DontUseBuffer is only used when perform MTFTP/TFTP read operation. Cc: Ye Ting Cc: Wu Jiaxin Cc:

Re: [edk2] [RFC] SATA : Implemented NXP errata A008402

2018-01-11 Thread Ard Biesheuvel
On 11 January 2018 at 02:25, Ni, Ruiyu wrote: > On 1/10/2018 5:52 PM, Ard Biesheuvel wrote: >> >> On 10 January 2018 at 09:43, Udit Kumar wrote: >>> >>> Hi Ruiyu, >>> -Original Message- > > > And this change will not impact any

Re: [edk2] [PATCH 1/2] BaseTools: Enable MAX_CONCURRENT_THREAD_NUMBER = 0 feature

2018-01-11 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Feng, YunhuaX Sent: Tuesday, January 09, 2018 6:38 PM To: edk2-devel@lists.01.org Cc: Feng, YunhuaX ; Zhu, Yonghong ; Gao, Liming

[edk2] [PATCH v2 5/7] UefiCpuPkg: Update SmmCpuFeatureLib pass XCODE5 tool chain

2018-01-11 Thread Liming Gao
In V2, use "mov rax, strict qword 0" to replace the hard code db. 1. Use lea instruction to get the address instead of mov instruction. 2. Use the dummy address as jmp destination, and add the logic to fix up the address to the absolute address at boot time. Contributed-under: TianoCore

[edk2] [PATCH v2 4/7] UefiCpuPkg: Update CpuExceptionHandlerLib pass XCODE5 tool chain

2018-01-11 Thread Liming Gao
In V2, use mov rax, strict qword 0 to replace the hard code db. Use the dummy address as jmp destination, and add the logic to fix up the address to the absolute address at boot time. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc:

[edk2] [PATCH v2 6/7] UefiCpuPkg: Update PiSmmCpuDxeSmm pass XCODE5 tool chain

2018-01-11 Thread Liming Gao
In V2, use "mov rax, strict qword 0" to replace the hard code db. 1. Use lea instruction to get the address instead of mov instruction. 2. Use the dummy address as jmp destination, and add the logic to fix up the address to the absolute address at boot time. 3. On MpFuncs.nasm, use ExchangeInfo

Re: [edk2] [Patch 0/7] EDK2: Enable XCODE5 tool chain with NASM source

2018-01-11 Thread Laszlo Ersek
On 01/11/18 10:54, Laszlo Ersek wrote: > Liming, > > On 01/10/18 16:24, Liming Gao wrote: >> 1. Use nasm source file for X86 tool chain, then ASM and S file can be >> removed. >> 2. Update Nasm source file to resolve the absolute addressing. >> 3. Verify OVMF IA32, IA32X64 and X64 boot to shell

Re: [edk2] [PATCH v4 4/6] ArmPkg/Library/CompilerIntrinsicsLib: Enable VS2017/ARM builds

2018-01-11 Thread Cohen, Eugene
> > Introduce CRT assembly replacements for __rt_sdiv, __rt_udiv, > > __rt_udiv64, __rt_sdiv64, __rt_srsh (by reusing the RVCT code) as well > > as memcpy and memset. > > For MSFT compatibility, some of the code needs to be explicitly forced > > to ARM, and the /oldit assembly flag needs to be

Re: [edk2] [PATCH] OvmfPkg/VirtioScsiDxe: Allocate all required vrings at VirtioScsiInit

2018-01-11 Thread Maxime Coquelin
On 01/11/2018 02:23 PM, Maxime Coquelin wrote: Hi Xiang, On 12/14/2017 02:25 PM, zhengxiang (A) wrote: On 2017/12/14 17:06, Paolo Bonzini wrote: On 14/12/2017 07:55, zhengxiang (A) wrote: Hello Laszlo and Paolo, Thanks for your review! On 2017/12/13 19:16, Laszlo Ersek wrote: On

Re: [edk2] [PATCH] MdeModulePkg/DebugLib: Print partial when format string is too long

2018-01-11 Thread Gao, Liming
Ray: Could you keep total size to point the real used size instead of full size? It can reduce the copy action in ReportStatusCodeLib. > -Original Message- > From: Ni, Ruiyu > Sent: Thursday, January 11, 2018 11:36 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming

Re: [edk2] [PATCH v2 13/13] ArmPlatformPkg: Introduce SCMI protocol

2018-01-11 Thread Evan Lloyd
> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: 23 December 2017 14:06 > To: Evan Lloyd > Cc: edk2-devel@lists.01.org; "ard.biesheu...@linaro.org"@arm.com; > "leif.lindh...@linaro.org"@arm.com; >

Re: [edk2] [PATCH v4 4/6] ArmPkg/Library/CompilerIntrinsicsLib: Enable VS2017/ARM builds

2018-01-11 Thread Cohen, Eugene
Pete, > How about I modify the patch to use "AREA s_" > instead of "AREA Math" as per the current proposal? That's how it used to work before the macro was introduced, per commit dcb2e4bb61931e2dee1739bb76aba315002f0a82 two years ago. I personally have no problem going back to the individual

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017 1/2] Add support for Sony camera imx219

2018-01-11 Thread Teemu Rytkonen
Adds support for two ACPI entries for imx219 as front and back camera of IPU. Both camera entries can be configured from the Front, Back camera of the BIOS menu settings. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Teemu Rytkonen ---

[edk2] [PATCH v2 1/1] OvmfPkg/BaseMemEncryptSevLib: Enable protection for newly added page table

2018-01-11 Thread Brijesh Singh
Commit 2ac1730bf2a5 (MdeModulePkg/DxeIpl: Mark page table as read-only) sets the memory pages used for page table as read-only after paging is setup and sets CR0.WP to protect CPU modifying the read-only pages. The commit causes #PF when MemEncryptSevClearPageEncMask() or

Re: [edk2] [Patch v2] MdeModulePkg/DxeNetLib: Add array range check in NetIp6IsNetEqual().

2018-01-11 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan > -Original Message- > From: Wang, Fan > Sent: Thursday, January 11, 2018 6:14 PM > To: edk2-devel@lists.01.org > Cc: Fu, Siyuan ; Wu, Jiaxin ; Wu, > Hao A > Subject: [Patch v2]

[edk2] [PATCH] UefiCpuPkg: Enhance feature dependency check

2018-01-11 Thread Song, BinX
Enhance MCA feature dependency check base on SDM pseudocode example 15-1. Cc: Eric Dong Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bell Song ---

Re: [edk2] [PATCH] OvmfPkg/VirtioScsiDxe: Allocate all required vrings at VirtioScsiInit

2018-01-11 Thread zhengxiang (A)
Hi Maxime, On 2018/1/11 22:46, Maxime Coquelin wrote: > > > On 01/11/2018 02:23 PM, Maxime Coquelin wrote: >> Hi Xiang, >> >> On 12/14/2017 02:25 PM, zhengxiang (A) wrote: >>> >>> >>> On 2017/12/14 17:06, Paolo Bonzini wrote: On 14/12/2017 07:55, zhengxiang (A) wrote: > Hello Laszlo

[edk2] [PATCH] CryptoPkg/OpensslLib: Suppress format warning with extra flag.

2018-01-11 Thread Long Qin
Under a certain [outdated] GCC482 compiler, the new-added "-Wno-format" flag will not take effect, and break the x86_64 build. This is one known issue in some Ubuntu/GCC-4.8.2 environment, which will overwrite "-Wno-format" with some default setting. see more information and discussion from:

Re: [edk2] [Patch v2] MdeModulePkg/DxeNetLib: Add array range check in NetIp6IsNetEqual().

2018-01-11 Thread Wu, Jiaxin
Reviewed-by: Jiaxin Wu > -Original Message- > From: Wang, Fan > Sent: Thursday, January 11, 2018 6:14 PM > To: edk2-devel@lists.01.org > Cc: Fu, Siyuan ; Wu, Jiaxin ; Wu, > Hao A > Subject: [Patch v2]

Re: [edk2] [PATCH 0/5] BaseTools/Common & DevicePath: Code refinements

2018-01-11 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Wu, Hao A > Sent: Monday, January 8, 2018 1:31 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Ni, Ruiyu ; Zhu, > Yonghong ; Gao, Liming >

Re: [edk2] [PATCH] CryptoPkg/OpensslLib: Suppress format warning with extra flag.

2018-01-11 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Long, Qin > Sent: Friday, January 12, 2018 11:20 AM > To: edk2-devel@lists.01.org > Cc: ard.biesheu...@linaro.org; Gao, Liming > Subject: [PATCH] CryptoPkg/OpensslLib: Suppress format

Re: [edk2] [Patch] MdeModulePkg/Ip4Dxe: Add an independent timer for reconfig checking

2018-01-11 Thread Wu, Jiaxin
Reviewed-by: Jiaxin Wu > -Original Message- > From: Wang, Fan > Sent: Thursday, January 11, 2018 6:20 PM > To: edk2-devel@lists.01.org > Cc: Wu, Jiaxin ; Ye, Ting ; Fu, > Siyuan > Subject: [Patch]

Re: [edk2] [Patch] NetworkPkg: Fix incorrect parameter check in PXE.Mtftp() function.

2018-01-11 Thread Wu, Jiaxin
Reviewed-by: Jiaxin Wu > -Original Message- > From: Fu, Siyuan > Sent: Thursday, January 11, 2018 5:19 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Wu, Jiaxin ; Wang, > Fan > Subject: [Patch]

Re: [edk2] [Patch] MdeModulePkg/Ip4Dxe: Add an independent timer for reconfig checking

2018-01-11 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Wang Fan > Sent: Thursday, January 11, 2018 6:20 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Fu, Siyuan

Re: [edk2] [Patch 0/7] EDK2: Enable XCODE5 tool chain with NASM source

2018-01-11 Thread Gao, Liming
Laszlo: Thanks for comments. I submit two bugs. One is for UefiCpuPkg, another is for BaseTools. https://bugzilla.tianocore.org/show_bug.cgi?id=849 https://bugzilla.tianocore.org/show_bug.cgi?id=850 > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On

[edk2] [PATCH] MdeModulePkg/FrameBufferBltLib: Fix a bug causing display corrupted

2018-01-11 Thread Ruiyu Ni
The Graphics Output Protocol's mode information specifies the PixelsPerScanLine property. Most of the time this is identical to HorizontalResolution. However, due to alignment requirements etc. it may be slightly larger. I.e. each scan line will have some "pixels" that are not visible on the

[edk2] [PATCH] UefiCpuPkg PiSmmCpuDxeSmm: Fixed #double fault on #page fault for IA32

2018-01-11 Thread Star Zeng
When StackGuard is enabled on IA32, the #double fault exception is reported instead of #page fault. This issue does not exist on X64, or IA32 without StackGuard. The fix at e4435f710cea2d2f10cd7343d545920867780086 was incomplete. It is because AllocateCodePages() is used to allocate buffer for