Re: [edk2] [RFC] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

2018-01-17 Thread Ard Biesheuvel
On 15 January 2018 at 14:46, Heyi Guo wrote: > This is the draft patch for the discussion posted in edk2-devel > mailing list: > https://lists.01.org/pipermail/edk2-devel/2017-December/019289.html > > As discussed in the mailing list, we'd like to add support for PCI >

Re: [edk2] Anyone got a good example of using acpica.org to execute AML code under EFI?

2018-01-17 Thread Laszlo Ersek
On 01/17/18 03:58, Andrew Fish wrote: > I was looking for some code to execute AML under ACPI. I see the > acpica github supports building acpidump... Does anyone know of an > example that supports executing AML from EFI? Yes, I have tested (called) AML methods using ACPICA from EFI. The BIOS

Re: [edk2] [ArmPlatformPkg][Patch] reset x11 before use

2018-01-17 Thread Ard Biesheuvel
On 16 January 2018 at 21:51, Udit Kumar wrote: > This patch reset x11 to zero before using it. > x11 is marked as caller saved register, therefore before using it > default (reset) value should be assigned. > > If ArmPlatformPeiBootAction function is using x11 then some of >

[edk2] [ArmPlatformPkg][Patch] reset x11 before use

2018-01-17 Thread Udit Kumar
This patch reset x11 to zero before using it. x11 is marked as caller saved register, therefore before using it default (reset) value should be assigned. If ArmPlatformPeiBootAction function is using x11 then some of calculation in this routine may go wrong. Contributed-under: TianoCore

Re: [edk2] AsciiPrint() in HttpBootDxe Corrupting the Setup screen

2018-01-17 Thread Karunakar P
[Patch] NetworkPkg\HttpBootDxe: AsciiPrint() in HttpBootDxe Corrupting the Setup screen NetworkPkg\HttpBootDxe\HttpBootSupport.c | 2 NetworkPkg\HttpBootDxe\HttpBootClient.c| 10 2 files changed, 10 insertions(+), 2 deletions(-) NetworkPkg\HttpBootDxe\HttpBootSupport.c

[edk2] [PATCH v4 2/2] ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver.

2018-01-17 Thread Supreeth Venkatesh
PI v1.5 Specification Volume 4 defines Management Mode Core Interface and defines EFI_MM_COMMUNICATION_PROTOCOL. This protocol provides a means of communicating between drivers outside of MM and MMI handlers inside of MM. This patch implements the EFI_MM_COMMUNICATION_PROTOCOL DXE runtime driver

[edk2] [PATCH v4 0/2] *** EFI_MM_COMMUNICATION_PROTOCOL ***

2018-01-17 Thread Supreeth Venkatesh
*** PI v1.5 Specification Volume 4 defines Management Mode Core Interface and defines EFI_MM_COMMUNICATION_PROTOCOL. This protocol provides a means of communicating between drivers outside of MM and MMI handlers inside of MM. EFI_MM_COMMUNICATION_PROTOCOL Summary This protocol provides a means

[edk2] [PATCH v4 1/2] ArmPkg: Add PCDs needed for MM communication driver.

2018-01-17 Thread Supreeth Venkatesh
This patch defines PCDs to describe the base address and size of communication buffer between normal world (uefi) and standalone MM environment in the secure world. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Achin Gupta Signed-off-by: Supreeth

Re: [edk2] [RFC v5 0/8] Stack trace support in X64 exception handling

2018-01-17 Thread Yao, Jiewen
Hi Paulo I have some more thought on #3 for your consideration. Given the situation that we are doing heap guard feature, a *valid* EIP address might not be enough to guarantee the address is inside of an *executable* page. I am thinking if we need check the non-executable bit (BIT63) as well

Re: [edk2] [PATCH 1/6] UefiCpuPkg/MpInitLib: split wake up buffer into two parts

2018-01-17 Thread Dong, Eric
Reviewed-by: Eric Dong -Original Message- From: Wang, Jian J Sent: Monday, January 15, 2018 4:54 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen ; Ni, Ruiyu ; Dong, Eric ; Laszlo Ersek

[edk2] [PATCH] MdeModulePkg/Core: fix a logic hole in page free

2018-01-17 Thread Jian J Wang
This hole will cause page fault randomly. The root cause is that Guard page, which is just freed back to page pool but not yet cleared not- present attribute, will be allocated right away by internal function CoreFreeMemoryMapStack(). The solution to this issue is to clear the not-present

[edk2] [PATCH] UefiCpuPkg/CpuDxe: fix bad boot performance

2018-01-17 Thread Jian J Wang
If features like memory profile, protection and heap guard are enabled, a lot of more memory page attributes update actions will happen than usual. An unnecessary sync of CR0.WP setting among APs will then cause worse performance in memory allocation action. Removing the calling of

[edk2] [Patch] MdePkg: Update DEC and DSC version from 1.07 to 1.08

2018-01-17 Thread Liming Gao
UEFI2.7/PI1.6 have been added in MdePkg. Update DEC and DSC version to reflect those changes in MdePkg. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- MdePkg/MdePkg.dec | 4 ++-- MdePkg/MdePkg.dsc | 4 ++-- 2 files changed, 4

[edk2] [Patch] BaseTools: enhance error handling for option --binary-source

2018-01-17 Thread Yonghong Zhu
Enhance error handling for option --binary-source to report invalid option value. --binary-destination use same rule. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu --- BaseTools/Source/Python/build/build.py | 6 ++ 1 file

Re: [edk2] [Patch] BaseTools: enhance error handling for option --binary-source

2018-01-17 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Yonghong Zhu >Sent: Thursday, January 18, 2018 1:25 PM >To: edk2-devel@lists.01.org >Subject: [edk2] [Patch] BaseTools: enhance error handling for

Re: [edk2] [PATCH] CryptoPkg: Adding OpenSSL as one submodule of EDKII repo

2018-01-17 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Long, Qin > Sent: Tuesday, January 16, 2018 3:22 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Gao, Liming ; Long, > Qin > Subject: [PATCH]

[edk2] [PATCH] MdePkg/DMAR: Add the definition for DMA_CTRL_PLATFORM_OPT_IN_FLAG bit

2018-01-17 Thread Hao Wu
For the support of VTd 2.5, add the BIT definition of DMA_CTRL_PLATFORM_OPT_IN_FLAG Cc: Star Zeng Cc: Jiewen Yao Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement

Re: [edk2] [PATCH] MdePkg/DMAR: Add the definition for DMA_CTRL_PLATFORM_OPT_IN_FLAG bit

2018-01-17 Thread Yao, Jiewen
Thanks. Would you please also update the file header on spec version and URL to the new spec? Reviewed-by: jiewen@intel.com > -Original Message- > From: Wu, Hao A > Sent: Thursday, January 18, 2018 10:03 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Zeng,

Re: [edk2] [PATCH] MdePkg/DMAR: Add the definition for DMA_CTRL_PLATFORM_OPT_IN_FLAG bit

2018-01-17 Thread Zeng, Star
Please also update the information according to 2.5 spec. - Intel(R) Virtualization Technology for Directed I/O (VT-D) Architecture Specification v2.4, Dated June 2016. Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Wu, Hao A Sent:

Re: [edk2] [PATCH] MdePkg/DMAR: Add the definition for DMA_CTRL_PLATFORM_OPT_IN_FLAG bit

2018-01-17 Thread Wu, Hao A
> -Original Message- > From: Zeng, Star > Sent: Thursday, January 18, 2018 10:36 AM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Yao, Jiewen; Kinney, Michael D; Gao, Liming; Zeng, Star > Subject: RE: [PATCH] MdePkg/DMAR: Add the definition for > DMA_CTRL_PLATFORM_OPT_IN_FLAG bit > >

Re: [edk2] [Patch] IntelFsp2WrapperPkg: Update BaseFspWrapperApiLib to pass XCODE5 build

2018-01-17 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Gao, Liming > Sent: Thursday, January 18, 2018 10:45 AM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen > Subject: [Patch] IntelFsp2WrapperPkg: Update BaseFspWrapperApiLib to pass > XCODE5 build > >

[edk2] [PATCH] UefiCpuPkg/MtrrLib: Add comments to recommend to use batch-set API

2018-01-17 Thread Ruiyu Ni
MtrrSetMemoryAttributesInMtrrSettings() is a batch-set API. When setting multiple ranges of memory attributes, the single-set API (MtrrSetMemoryAttributeInMtrrSettings and MtrrSetMemoryAttribute) may fail, but batch-set API may succeed. Add comments to recommend caller to use batch-set API when

[edk2] [PATCH] UefiCpuPkg/MtrrLib: Update the comments for RETURN_BUFFER_TOO_SMALL

2018-01-17 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Ming Shao --- UefiCpuPkg/Include/Library/MtrrLib.h | 10 +++--- UefiCpuPkg/Library/MtrrLib/MtrrLib.c | 8 ++-- 2 files changed, 13 insertions(+), 5 deletions(-)

Re: [edk2] [RFC] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

2018-01-17 Thread Guo Heyi
On Wed, Jan 17, 2018 at 02:08:06PM +, Ard Biesheuvel wrote: > On 15 January 2018 at 14:46, Heyi Guo wrote: > > This is the draft patch for the discussion posted in edk2-devel > > mailing list: > > https://lists.01.org/pipermail/edk2-devel/2017-December/019289.html > > > >

[edk2] [Patch] IntelFsp2WrapperPkg: Update BaseFspWrapperApiLib to pass XCODE5 build

2018-01-17 Thread Liming Gao
XCODE5 doesn't support absolute addressing in the assembly code. This change uses lea instruction to get the address. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Jiewen Yao ---

Re: [edk2] [RFC v5 0/8] Stack trace support in X64 exception handling

2018-01-17 Thread Yao, Jiewen
Thanks Paulo. The series looks really good. I give it thumb up. :-) The 8 patches keep updating 4 files, so I squash them when I review. The comment below is for the final code, not for a specific patch. 1) CpuExceptionCommon.c: IsLinearAddressRangeValid(). // // Check for valid input

[edk2] [PATCH] IntelSiliconPkg IntelVTdDxe: Fix DMA does not work issue

2018-01-17 Thread Star Zeng
Fix DMA does not work issue when system memory is not greater than 4G. Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- IntelSiliconPkg/Feature/VTd/IntelVTdDxe/TranslationTable.c | 11 +++ 1

Re: [edk2] [PATCH] IntelSiliconPkg IntelVTdDxe: Fix DMA does not work issue

2018-01-17 Thread Yao, Jiewen
Good catch. Reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Wednesday, January 17, 2018 7:57 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Yao, Jiewen > Subject: [PATCH] IntelSiliconPkg IntelVTdDxe: Fix