Re: [edk2] [PATCH 2/2] Hisilicon/D0x: Enable tftp command by default

Ping :) On Wed, Mar 07, 2018 at 04:02:30PM +, Ard Biesheuvel wrote: > On 7 March 2018 at 03:03, Heyi Guo wrote: > > Since D0x platforms always have network enabled, we would like to > > enable tftp command by default so that we can download something in > > EFI Shell. >

Re: [edk2] [Patch 1/3] MdePkg/Tls1.h: Add TLS record header length and max payload length.

Reviewed-by: Karunakar p -Original Message- From: Jiaxin Wu [mailto:jiaxin...@intel.com] Sent: Tuesday, March 20, 2018 6:07 AM To: edk2-devel@lists.01.org Cc: Karunakar P; Fu Siyuan; Ye Ting Subject: [Patch 1/3] MdePkg/Tls1.h: Add TLS record header length and

Re: [edk2] [Patch 3/3] NetworkPkg/HttpDxe: Handle the large data request via HTTPS channel.

Reviewed-by: Karunakar p -Original Message- From: Jiaxin Wu [mailto:jiaxin...@intel.com] Sent: Tuesday, March 20, 2018 6:07 AM To: edk2-devel@lists.01.org Cc: Karunakar P; Fu Siyuan; Ye Ting Subject: [Patch 3/3] NetworkPkg/HttpDxe: Handle the large data

Re: [edk2] [Patch] Build spec: Add DSC DEFAULT as optional line in Global PCD Section

Reviewed-by: Liming Gao > -Original Message- > From: Zhu, Yonghong > Sent: Monday, March 19, 2018 9:49 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Kinney, Michael D > ; Shaw, Kevin W

Re: [edk2] [Patch 2/3] NetworkPkg/TlsDxe: Handle the multiple TLS record messages encryption/decryption.

Reviewed-by: Karunakar p -Original Message- From: Jiaxin Wu [mailto:jiaxin...@intel.com] Sent: Tuesday, March 20, 2018 6:07 AM To: edk2-devel@lists.01.org Cc: Karunakar P; Fu Siyuan; Ye Ting Subject: [Patch 2/3] NetworkPkg/TlsDxe: Handle the multiple TLS

Re: [edk2] [PATCH v1 0/2] BaseTools: AutoGen code style compliance

Reviewed-by: Yonghong Zhu I will push this patch. Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jaben Carsey Sent: Thursday, March 15, 2018 8:20 AM To: edk2-devel@lists.01.org Subject:

Re: [edk2] [PATCH v1 0/5] BaseTools: improve reuse and remove dead code

Reviewed-by: Yonghong Zhu I will push this series patch. Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jaben Carsey Sent: Friday, March 16, 2018 5:39 AM To: edk2-devel@lists.01.org Subject:

[edk2] [Patch] SecurityPkg Tpm2CommandLib: Fix TPM2.0 response memory overflow

TPM2.0 command lib always assumes TPM device and transmission channel can respond correctly. But it is not true when communication channel is exploited and wrong data is spoofed. Add more logic to prohibit memory overflow attack. Cc: Long Qin Cc: Yao Jiewen

[edk2] [Patch V2] Build spec: update description for build handles PCDs for SKU support

Cc: Liming Gao Cc: Michael Kinney Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu --- 2_design_discussion/27_sku_support.md | 129

Re: [edk2] [PATCH 2/2] Hisilicon/D0x: Enable tftp command by default

I've no idea about how to use Driver; let me spend some time to learn first :) Regards, Heyi On Tue, Mar 20, 2018 at 09:51:32AM +, Leif Lindholm wrote: > Ah, apologies. > > I would be reluctant to add commands not covered by the UEFI Shell > Specification by default. > > Since it is

Re: [edk2] [Patch] BaseTools: Fix bug for --pcd VOID* type when no max size is specified

Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Tuesday, March 20, 2018 4:23 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch] BaseTools: Fix bug for --pcd VOID*

[edk2] [Patch] BaseTools: Add Feature Flag Pcd Type into Override list

when only define the PCD in the DEC file, and use --pcd feature, we also need cover this case for Feature Flag Type. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu --- BaseTools/Source/Python/Workspace/DscBuildData.py | 3 ++- 1 file

[edk2] [Patch] BaseTools: Fix bug for --pcd VOID* type when no max size is specified

when VOID* type non-structure pcd used in --pcd, and its max size is not specified in DSC or its value is hex value, build break due to the code int(Pcd.MaxDatumSize,10). Now this patch remove this code, because tool will calculate the size info in later phase. Contributed-under: TianoCore

[edk2] [Patch] Build spec: update description for build handles PCDs for SKU support

Cc: Liming Gao Cc: Michael Kinney Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu --- 2_design_discussion/27_sku_support.md | 132

Re: [edk2] [Patch] BaseTools: Add Feature Flag Pcd Type into Override list

Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Tuesday, March 20, 2018 4:23 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch] BaseTools: Add Feature Flag Pcd Type

Re: [edk2] [Patch 2/3] DscSpecification: Add DefaultStores section to describe the default setting

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Gao, Liming Sent: Friday, March 16, 2018 12:42 PM To: edk2-devel@lists.01.org Cc: Kinney, Michael D ; Zhu, Yonghong Subject:

Re: [edk2] [Patch 3/3] DscSpecification: Add structure PCD field value assignment syntax

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Gao, Liming Sent: Friday, March 16, 2018 12:42 PM To: edk2-devel@lists.01.org Cc: Kinney, Michael D ; Zhu, Yonghong Subject:

Re: [edk2] [Patch 1/3] DSCSpecification: Add syntax to support SKU ID inherit from another SKU ID

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Gao, Liming Sent: Friday, March 16, 2018 12:42 PM To: edk2-devel@lists.01.org Cc: Kinney, Michael D ; Zhu, Yonghong Subject:

Re: [edk2] [Patch] BuildSpecification: Clarify structure PCD field value assignment precedence

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Gao, Liming Sent: Friday, March 16, 2018 12:43 PM To: edk2-devel@lists.01.org Cc: Kinney, Michael D ; Zhu, Yonghong Subject:

Re: [edk2] [PATCH 2/2] Hisilicon/D0x: Enable tftp command by default

Ah, apologies. I would be reluctant to add commands not covered by the UEFI Shell Specification by default. Since it is now a dynamic command, is there any way of loading this dynamically (perhaps via DRIVER) where you feel the need for it? / Leif On Tue, Mar 20, 2018 at 03:54:46PM

[edk2] internal structure of EFI_TLS_CA_CERTIFICATE_VARIABLE

Hi Jiaxin, Siyuan, setting *multiple* CA certificates for HTTPS server verification looks possible, from the following call tree: TlsConfigCertificate() [NetworkPkg/HttpDxe/HttpsSupport.c] TlsConfigurationSetData() [NetworkPkg/TlsDxe/TlsConfigProtocol.c] TlsSetCaCertificate()

[edk2] [Patch] SecurityPkg Tpm12CommandLib: Fix TPM12 GetCapability response error

TPM12 command lib doesn't convert Response Size before using. Add logic to fix the issue. Cc: Long Qin Cc: Yao Jiewen Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chao Zhang Signed-off-by: Zhang, Chao B

[edk2] [PATCH v3 01/16] ArmPlatformPkg: Rectify line endings of LcdHwNullLib

This fix changes line endings of LcdHwNullLib.c to DOS style line endings from UNIX style line endings to meet the EDK2 coding standard. Note it also fixes an end of line whitespace. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Girish Pathak

[edk2] [PATCH v3 15/16] ArmPkg: MTL Library interface and Null library implementation

Upcoming new component ArmPkg/Drivers/ArmScmiDxe is dependent on platform specific ArmMtlLib library implementation, however in order to be able to build the ArmScmiDxe component outside of the context of a particular platform, this change adds Null implementation of the ArmMtlLib along with ARM

[edk2] [PATCH v3 16/16] ArmPkg: Introduce SCMI protocol

This change introduces a new SCMI protocol driver for Arm systems. The driver currently supports only clock and performance management protocols. Other protocols will be added as and when needed. Clock management protocol is used to configure various clocks available on the platform e.g. HDLCD

[edk2] [PATCH v3 13/16] ArmPlatformPkg: Reserving framebuffer at build

From: Girish Pathak Currently framebuffer memory is either reserved in special VRAM or dynamically allocated using boot services memory allocation functions. When allocated using boot services calls the memory has to be allocated as EfiBootServicesData. Unfortunately failures have been seen with

Re: [edk2] [PATCH] BaseTools/PosixLike: honor pre-set PYTHONPATH

Hello Liming, Yonghong, On 03/14/18 11:54, Laszlo Ersek wrote: > Utilities written in Python may depend on external (preinstalled) Python > packages; for example, Ecc depends on "antlr_python_runtime-3.0.1". Such > packages need not be installed system-wide, as long as they are reachable >

[edk2] [PATCH v3 04/16] ArmPlatformPkg: Tidy Lcd code: Updated comments

From: Girish Pathak There is no functional modification in this change some comments are modified and a few new comments are added. This is to prevent mixing formatting changes with functional changes. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Girish Pathak

[edk2] [PATCH v3 09/16] ArmPlatformPkg: Redefine LcdPlatformGetTimings function

From: Girish Pathak The LcdPlatformGetTimings interface function takes similar sets of multiple parameters for horizontal and vertical timings which can be aggregated in a common data type. This change defines a structure SCAN_TIMINGS for this which can be used to describe both horizontal and

[edk2] [PATCH v3 10/16] ArmPlatformPkg: Add PCD to select pixel format

From: Girish Pathak Current HDLCD and PL111 platform libraries do not support display modes with PixelBlueGreenRedReserved8BitPerColor format, i.e. because of historical confusion, they do not support the UEFI default PixelBlueGreenRedReserved8BitPerColor format In LcdPlatformLib for PL111,

[edk2] [PATCH v3 12/16] ArmPlatformPkg: Additional display modes

From: Girish Pathak Add definitions for new display modes such as HD 720. This has no effect on existing display drivers. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Girish Pathak Signed-off-by: Evan Lloyd Reviewed-by: Ard

[edk2] [PATCH v3 03/16] ArmPlatformPkg: Tidy Lcd code: Coding standard

From: Girish Pathak There is no functional modification in this change As preparation for further work, the formatting is corrected to meet the EDKII coding standard. Of specific note, some invalid include guards were fixed. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [PATCH v3 14/16] ArmPlatformPkg: New DP500/DP550/DP650 GOP driver

From: Girish Pathak This change adds support for the ARM Mali DP500/DP500/DP650 display processors using the GOP protocol. It has been tested on FVP base models + DP550 support. This change adds platform independant LcdHwLib library. A corresponding platform specific library will be submitted to

[edk2] [PATCH v3 11/16] ArmPlatformPkg: PCD to swap red/blue format for HDLCD

From: Girish Pathak This change adds a new PCD PcdArmHdlcdSwapBlueRedSelect to swap values for HDLCD RED_SELECT and BLUE_SELECT registers on platforms where blue and red hardware lines are swapped. If set to TRUE in the platform dsc, HDLCD library will swap the values while setting RED_SELECT

[edk2] [PATCH v3 02/16] ArmPlatformPkg: Rectify line endings of LcdPlatformNullLib

This fix changes line endings of LcdPlatformNullLib.c to DOS style line endings from UNIX style line endings to meet the EDK2 coding standard. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Girish Pathak Signed-off-by: Evan Lloyd

[edk2] [PATCH v3 00/16] Update GOP

This patch series addresses comments on the patch v2 (https://lists.01.org/pipermail/edk2-devel/2017-December/019389.html) reworking of the Graphics Output Protocol code in ArmPlatformPkg. It also contains updates for the new SCMI protocol. Corresponding edk2-platforms changes will follow

[edk2] [PATCH v3 08/16] ArmPlatformPkg: Implement LcdIdentify function for HDLCD GOP

From: Girish Pathak LcdIdentify function does not currently check presence of HDLCD controller. Implement this functionality by reading HDLCD_REG_VERSION and checking against the PRODUCT_ID field to detect presence of HDLCD controller. Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [PATCH v3 06/16] ArmPlatformPkg: PL111Lcd: Replace magic number with macro

From: Girish Pathak Minor code change, replaces magic number with macro in LCD disable. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Girish Pathak Signed-off-by: Evan Lloyd Reviewed-by: Ard Biesheuvel

[edk2] [PATCH v3 07/16] ArmPlatformPkg: PL111Lcd: Combine two writes to LCDControl

Currenty bit LcdPwr of the LCDControl register is enabled immediately after setting other bits of the LCDControl register. This two write sequence is unnecessary. This change removes this extra write by setting LcdPwr bit along with other bits of the LcdControl register. Contributed-under:

[edk2] [PATCH v3 05/16] ArmPlatformPkg: HDLCD and PL111: Update debug ASSERTS

From: Girish Pathak This change moves some ASSERTs in error handling code to improve efficiency in DEBUG build. This change also removes redundant error code returns. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Girish Pathak Signed-off-by: Evan

Re: [edk2] [staging/dynamictables PATCH 0/2] Dynamic Tables Framework core

Please don't use the name DynamicTableManagerDxe. What does it manage? DynamicTables? How does adding the word "Manager" provide any useful information for the reader? I recommend the name "DynamicAcpiTableDxe". It makes it clear this this code is specifically for generating ACPI tables at

Re: [edk2] [edk2 PATCH v2 1/1] Maintainers.txt: Add StandaloneMmPkg and maintainers

Reviewed-by: Leif Lindholm Pushed as 2b85beae0b. Please start bringing the code in via regular mailing list review by belowmentioned maintainerers/reviewer. On Thu, Feb 15, 2018 at 01:31:50PM +, achin.gu...@arm.com wrote: > From: Achin Gupta >

Re: [edk2] [Patch] NetworkPkg/UefiPxeBcDxe: Configure the ARP Instance/RouteTable with new address

Reviewed-by: Fu Siyuan > -Original Message- > From: Wu, Jiaxin > Sent: Tuesday, March 20, 2018 9:10 AM > To: edk2-devel@lists.01.org > Cc: Fu, Siyuan ; Ye, Ting > Subject: [Patch] NetworkPkg/UefiPxeBcDxe: Configure the ARP >

Re: [edk2] [PATCH] BaseTools/PosixLike: honor pre-set PYTHONPATH

The change is good. Reviewed-by: Liming Gao > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, March 14, 2018 6:54 PM > To: edk2-devel-01 > Cc: Gao, Liming ; Zhu, Yonghong

Re: [edk2] [staging/dynamictables PATCH 0/2] Dynamic Tables Framework core

Pushed with Evan's R-b as 1ff9bc214c..c47bc46170. On Mon, Mar 19, 2018 at 03:18:39PM +, Sami Mujawar wrote: > The Dynamic Tables Framework is a prototyped as a solution for > automatically generating the firmware tables based on hardware > description. > > This patchset is the Dynamic

[edk2] [Patch] BaseTools: Override Max size by build Option Pcd for HII type

Current code will generate maxsize for HII type PCD when parser DSC file, while this HII type PCD value maybe override in build command per --pcd option, so the max size need re-calculate. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu

Re: [edk2] [PATCH edk2-platforms v3 12/17] ARM/VExpressPkg: Allocate framebuffer using EfiRuntimeServicesData

On 21 March 2018 at 00:18, Girish Pathak wrote: > As per the UEFI specification(2.7) section 12.9, the GOP framebuffer > memory can be accessed in the pre-boot and the post boot phase (by OS) > Therefore the memory type EfiBootServicesData is incorrect for > the framebuffer

Re: [edk2] [Patch] SecurityPkg Tpm2CommandLib: Fix TPM2.0 response memory overflow

Thanks Qin, I will add more comments to explain the magic code -Original Message- From: Long, Qin Sent: Wednesday, March 21, 2018 10:58 AM To: Zhang, Chao B ; edk2-devel@lists.01.org Cc: Yao, Jiewen Subject: RE: [Patch] SecurityPkg

Re: [edk2] [Patch 0/3] Support HTTP large data request via TLS channel.

Serials Reviewed-by: Fu Siyuan > -Original Message- > From: Wu, Jiaxin > Sent: Tuesday, March 20, 2018 8:37 AM > To: edk2-devel@lists.01.org > Cc: Karunakar P ; Fu, Siyuan > ; Ye, Ting > Subject:

Re: [edk2] [Patch] SecurityPkg Tpm12CommandLib: Fix TPM12 GetCapability response error

Reviewed-by: Long Qin Best Regards & Thanks, LONG, Qin -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang, Chao B Sent: Tuesday, March 20, 2018 11:12 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen ;

Re: [edk2] [Patch] SecurityPkg Tpm2CommandLib: Fix TPM2.0 response memory overflow

Hi, Chao, One minor suggestion to add the comment to explain the following value "8": the number of digests in list is not greater than 8 per TPML_DIGEST definition. + if (PcrValues->count > 8) { +return EFI_DEVICE_ERROR; + } Other looks good to me. Reviewed-by: Long Qin

Re: [edk2] [PATCH 0/2] [platforms/dynamictables] Platform support for Dynamic Tables Framework

Note: the branch name (for the subject line) is platforms/devel-dynamictables, not platforms/dynamictables. With Evan's reviewed-by, series pushed as 345b8b2992..e28edfba42. On Mon, Mar 19, 2018 at 03:21:51PM +, Sami Mujawar wrote: > The Dynamic Tables Framework is a prototyped as a

[edk2] [PATCH edk2-platforms 08/12] Hisilicon: add PciCpuIo2Dxe

This is to prepare for switching to generic PciHostBridge, and CpuIo2Dxe is needed by generic PciHostBridge driver. The driver is copied from ArmPkg/Drivers/ArmPciCpuIo2Dxe and changed for D0x. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Heyi Guo

[edk2] [PATCH edk2-platforms 09/12] Hisilicon: add PciSegmentLib for Hi161x

This is to prepare for switching to generic PciHostBridge, and PciSegmentLib is needed by generic PciHostBridge driver. This module copied from edk2-platforms/Silicon/Socionext/SynQuacer/Library/SynQuacerPciSegmentLib. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Heyi

[edk2] [PATCH edk2-platforms 04/12] Hisilicon/Pci: Merge PciPlatform into PcieInit Driver

This is to prepare for switching to generic PciHostBridge driver, so we move all platform specific code to platform specific drivers, not in PciHostBridge driver. This patch is to prepare moving EnlargeAtuConfig0() out of PciHostBridge. Since the function was originally called in NotifyPhase() of

[edk2] [PATCH edk2-platforms 10/12] Hisilicon/D0x: Switch to generic PciHostBridge driver

Address translation support is added to generic PciHostBridge driver in edk2 by commit 74d0a33, so we can switch to it for Hisilicon D03 and D05 which are using address translation between device address and host address for resource BAR. Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [PATCH edk2-platforms 06/12] Hisilicon/PlatformPciLib: add segment for each root bridge

This is to prepare for switching to generic PciHostBridge driver. We are going to create a PciHostBridgeLib instance for D0x and fetch PCI root bridge informance from PlatformPciLib, so we add Segment to PCI_ROOT_BRIDGE_RESOURCE_APPETURE along with other PCI resource information. Segment numbers

[edk2] [PATCH edk2-platforms 05/12] Hisilicon/Pci: Move EnlargeAtuConfig0() to PcieInitDxe

This is to prepare for switching to generic PciHostBridge driver, so we move all platform specific code to platform specific drivers, not in PciHostBridge driver. This patch is to move EnlargeAtuConfig0() into PcieInitDxe, in PlatformNotify() of EFI_PCI_PLATFORM_PROTOCOL. Contributed-under:

[edk2] [PATCH edk2-platforms 03/12] Hisilicon/Pci: move ATU configuration to PcieInitDxe

This is to prepare for switching to generic PciHostBridge driver, so we move all platform specific code to platform specific drivers, not in PciHostBridge driver. This patch moves ATU initialization to PcieInitDxe driver. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

Re: [edk2] [edk2 PATCH v2 1/1] Maintainers.txt: Add StandaloneMmPkg and maintainers

Reviewed-by: jiewen@intel.com > -Original Message- > From: achin.gu...@arm.com [mailto:achin.gu...@arm.com] > Sent: Thursday, February 15, 2018 9:32 PM > To: edk2-devel@lists.01.org > Cc: af...@apple.com; Kinney, Michael D ; > leif.lindh...@linaro.org; Yao,

[edk2] [PATCH edk2-platforms 07/12] Hisilicon: add PciHostBridgeLib

This is to prepare for switching to generic PciHostBridge, and PciHostBridgeLib is needed by PciHostBridge driver. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Heyi Guo Cc: Ard Biesheuvel Cc: Leif Lindholm

[edk2] [PATCH edk2-platforms 00/12] Hisilicon/D0x: Switch to generic PciHostBridge

For BAR address translation support was added to edk2 generic PciHostBridge by commit 74d0a33, now we can also use it for D03/D05 platforms. This series of patches include 3 parts of change: - Preparation for the switch, moving platform specific code out of PciHostBridge driver. - Add depending

[edk2] [PATCH edk2-platforms 12/12] Hisilicon/PlatformPciLib: clear redundant felds in RESOURCE_APPETURE

In structure PCI_ROOT_BRIDGE_RESOURCE_APPETURE, MemBase is redundant with CpuMemRegionBase, and MemLimit can be calculated by CpuMemRegionBase + PciRegionLimit - PciRegionBase so it is also redundant. Remove these two fields to make things simple and clear. Contributed-under: TianoCore

[edk2] [PATCH edk2-platforms 01/12] Hisilicon: Enable WARN and INFO debug message

INFO and WARN messages are useful when we are debugging, something like PCI enumeration process, and more debug messages should not impact much for they will only be displayed in DEBUG version, not RELEASE one. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Heyi Guo

[edk2] [PATCH edk2-platforms 02/12] Hisilicon/D05/PlatformPciLib: fix misuse of macro

Each PCI root bridge has its own macro definitions for its resource aperture, so that one root bridge should not use macro definitions of other root bridges. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Heyi Guo Cc: Ard Biesheuvel

Re: [edk2] [PATCH v5] ShellPkg: Add acpiview tool to dump ACPI tables

On 9 March 2018 at 00:26, Sami Mujawar wrote: > This program is provided to allow examination of ACPI table contents > from the UEFI Shell. This can help with investigations, especially at > that stage where the tables are not enabling an OS to boot. > The program is not

Re: [edk2] [Patch] BaseTools: Override Max size by build Option Pcd for HII type

Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Wednesday, March 21, 2018 11:07 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch] BaseTools: Override Max size by

Re: [edk2] internal structure of EFI_TLS_CA_CERTIFICATE_VARIABLE

Hi, Laszlo The data structure of EFI_TLS_CA_CERTIFICATE_VARIABLE is EFI_SIGNATURE_LIST and we have documented this in HTTPs Boot wiki page: https://github.com/tianocore/tianocore.github.io/wiki/HTTPS-Boot You can refer section 31.4.1 "Signature Database" in UEFI 2.7 A for a detail description

Re: [edk2] [Patch] DecSpecification: Add structure PCD definition syntax

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Gao, Liming Sent: Friday, March 16, 2018 12:43 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong ; Kinney, Michael D Subject:

[edk2] [PATCH edk2-platforms v3 05/17] ARM/VExpressPkg: Add and update debug ASSERTS

From: Girish Pathak This change adds some debug assertions e.g to catch NULL pointer errors missing in PL11Lcd and HdLcd platform libraries. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Girish Pathak Signed-off-by: Evan Lloyd

[edk2] [PATCH edk2-platforms v3 02/17] ARM/VExpressPkg: Tidy HDLCD and PL11LCD platform Lib: Coding standard

From: Girish Pathak There is no functional modification in this change As preparation for further work, the formatting is corrected to meet the EDKII coding standard. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Girish Pathak Signed-off-by: Evan

[edk2] [PATCH edk2-platforms v3 00/17] Update GOP

This patch series addresses comments on the patch v2 (https://lists.01.org/pipermail/edk2-devel/2017-December/019406.html) reworking of the Graphics Output Protocol code in ArmPlatformPkg. It also contains updates for the new SCMI protocol (MTL Library). Code is available for examination at:

[edk2] [PATCH edk2-platforms v3 03/17] ARM/VExpressPkg: Tidy HdLcd/PL111Lcd code: Updated comments

From: Girish Pathak There is no functional modification in this change. In this change some comments in HDLCD and PL111LCD platform library code are modified and a few new comments are added. This is to prevent mixing formatting changes with functional changes. Contributed-under: TianoCore

[edk2] [PATCH edk2-platforms v3 01/17] ARM/VExpressPkg: Fix MODULE_TYPE of HDLCD/PL111 platform libraries

From: Ard Biesheuvel This change fixes incorrect MODULE_TYPE of HDLCD and PL111 LcdPlatformLibs. Currently set MODUL_TYPE DXE_DRIVER is incorrect for these platform libraries. Hence set this to type BASE. Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [PATCH edk2-platforms v3 12/17] ARM/VExpressPkg: Allocate framebuffer using EfiRuntimeServicesData

As per the UEFI specification(2.7) section 12.9, the GOP framebuffer memory can be accessed in the pre-boot and the post boot phase (by OS) Therefore the memory type EfiBootServicesData is incorrect for the framebuffer memory allocation. Change EfiBootServicesData with EfiRuntimeServicesData flag

[edk2] [PATCH edk2-platforms v3 06/17] ARM/VExpressPkg: PL111Lcd/HdLcd plaform libs: Minor code cleanup

From: Girish Pathak This minor change removes some unecessary initializations and variables in PL111LcdArmVExpress.c and redudant return status checks in HdLcdArmVExpress.c Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Girish Pathak

[edk2] [PATCH edk2-platforms v3 08/17] ARM/VExpressPkg: HdLcdArmVExpressLib: Remove status check EFI_TIMEOUT

From: Girish Pathak None of the ArmPlatformSys* functions returns EFI_TIMEOUT. Hence checking this in the do {} while loop in LcdPlatformSetMode is wrong. Therefore remove this comparision and as a result remove the do {} while loop. Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [PATCH edk2-platforms v3 04/17] ARM/VExpressPkg: Remove unused PcdPL111LcdMaxMode from HDLCD inf

PCD PcdPL111LcdMaxMode is not used in HDLCD platform library. Presence of this PCD in HDLCD is probably due to copy/paste code from PL111 Lcd platform library. This change removes it from the HdLcdArmVExpressLib.inf file. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by:

[edk2] [PATCH edk2-platforms v3 16/17] ARM/JunoPkg: Adding SCMI MTL library

This change adds a new Mailbox Transport Layer library for the Juno platform. This library is required for ArmScmiDxe driver communication with the SCP. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Girish Pathak --- Notes: v3: - Please

[edk2] [PATCH edk2-platforms v3 09/17] ARM/VExpressPkg: HdLcdArmVExpressLib: Remove redundant Bpp

From: EvanLloyd Because of copy/paste effects, HdLcdArmVExpress.c contained a table entry "LCD_BPP Bpp;" specifying the Bits per Pixel for each mode. However, all modes are LCD_BITS_PER_PIXEL_24. This change removes the table entry and related use of the field. Contributed-under: TianoCore

[edk2] [PATCH edk2-platforms v3 15/17] ARM/VExpressPkg: New DP500/DP550/DP650 platform library

From: Girish Pathak This change adds LcdPlatformLib implementation for Arm Mali DP500/DP500/DP650 display processors for models (with DP550 support). NOTE: Versions for actual hardware are liable to require extra handling for clock input changes, etc. Contributed-under: TianoCore Contribution

[edk2] [PATCH edk2-platforms v3 14/17] ARM/VExpressPkg: Set EFI_MEMORY_XP flag on GOP framebuffer

The framebuffer memory is set with flag EFI_MEMORY_WC (uncached, unbuffered) which causes framebuffer memory with eXecute bit set. Framebuffer memory having executable bit set is a security hazard. This fix adds EFI_MEMORY_XP flag to avoid this. Unfortunately function

[edk2] [PATCH edk2-platforms v3 13/17] ARM/VExpressPkg: Reserving framebuffer at build

From: Girish Pathak This change uses two PCDs, PcdArmLcdFrameBufferBase and PcdArmLcdFrameBufferSize introduced in correspondiong EDK2 patch to reserve framebuffer in DRAM if these values are defined in platform specific DSC file, avoiding the need to allocate dynamically. This allows the

[edk2] [PATCH edk2-platforms v3 17/17] ARM/JunoPkg: Add HDLCD platform library

This change adds the HDLCD platform lib for the Juno plaform. This library will be instantiated as a LcdPlatformLib to link with LcdGraphicsOutputDxe for the Juno platform. HDLCD platform library depends on the Arm SCMI DXE driver for communication with the SCP for clock setting. Therefore this

[edk2] [PATCH edk2-platforms v3 10/17] ARM/VExpressPkg: Redefine LcdPlatformGetTimings function

From: EvanLloyd The LcdPlatformGetTimings interface function takes similar sets of multiple parameters for horizontal and vertical timings which can be aggregated in a common data type. This change defines a structure SCAN_TIMINGS for this which can be used to describe both horizontal and

[edk2] [PATCH edk2-platforms v3 11/17] ARM/VExpressPkg: PL111 and HDLCD: Add PCD to select pixel format

From: Girish Pathak Current HDLCD and PL111 platform libraries do not support display modes with PixelBlueGreenRedReserved8BitPerColor format, i.e. because of historical confusion, they do not support the UEFI default PixelBlueGreenRedReserved8BitPerColor LcdPlatformLib for PL111,

[edk2] [PATCH edk2-platforms v3 07/17] ARM/VExpressPkg: PL111 and HDLCD: Use FixedPcdGet32

From: Girish Pathak This change replaces PcdGet32 with FixedPcdGet32 for the PCDs which are defined as fixed PCDs. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Girish Pathak Signed-off-by: Evan Lloyd Reviewed-by: Ard