On Fri, Apr 27, 2018 at 11:46:04AM +0200, Ard Biesheuvel wrote:
> On 1 March 2018 at 15:01, Ard Biesheuvel wrote:
> > Replace the PMU compatible string "arm,armv8-pmuv3" with the more
> > accurate "arm,cortex-a53-pmu", potentially making more event types
> > available.
On 1 March 2018 at 15:01, Ard Biesheuvel wrote:
> Replace the PMU compatible string "arm,armv8-pmuv3" with the more
> accurate "arm,cortex-a53-pmu", potentially making more event types
> available.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
>
Reviewed-by: Yonghong Zhu
Best Regards,
Zhu Yonghong
-Original Message-
From: Carsey, Jaben
Sent: Friday, April 27, 2018 12:58 AM
To: edk2-devel@lists.01.org
Cc: Gao, Liming ; Zhu, Yonghong
Subject: [PATCH v2
Reviewed-by: Yonghong Zhu
Best Regards,
Zhu Yonghong
-Original Message-
From: Carsey, Jaben
Sent: Friday, April 27, 2018 12:58 AM
To: edk2-devel@lists.01.org
Cc: Gao, Liming ; Zhu, Yonghong
Subject: [PATCH v2
Great comment.
Follow your suggestion, I just sent the V2 patch at
https://lists.01.org/pipermail/edk2-devel/2018-April/024270.html.
I created and verified some cases for the error path in
InitializeFitMicrocodeInfo().
Thanks,
Star
-Original Message-
From: Yao, Jiewen
Sent: Thursday,
On 27 April 2018 at 11:49, Leif Lindholm wrote:
> On Fri, Apr 27, 2018 at 11:46:04AM +0200, Ard Biesheuvel wrote:
>> On 1 March 2018 at 15:01, Ard Biesheuvel wrote:
>> > Replace the PMU compatible string "arm,armv8-pmuv3" with the more
>> >
It is the second step for
https://bugzilla.tianocore.org/show_bug.cgi?id=540.
V2: Use error handling instead of ASSERT for FIT table checking result.
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
---
Reviewed-by: Yonghong Zhu
Best Regards,
Zhu Yonghong
-Original Message-
From: Carsey, Jaben
Sent: Friday, April 27, 2018 12:58 AM
To: edk2-devel@lists.01.org
Cc: Gao, Liming ; Zhu, Yonghong
Subject: [PATCH v2
On Thu, Apr 26, 2018 at 8:38 PM, Leif Lindholm wrote:
> On Thu, Apr 26, 2018 at 02:01:21PM +0100, Sami Mujawar wrote:
>> Acpiview is a program that allows examination of ACPI table
>> contents from the UEFI Shell.
>>
>> Enable acpiview support as this can help with
In ArmPkg\Drivers\GenericWatchdogDxe\GenericWatchdogDxe.c
the following functions
WatchdogWriteOffsetRegister();
WatchdogWriteCompareRegister();
WatchdogEnable();
WatchdogDisable();
provide write access to ARM Generic Watchdog registers and
use the values returned by MmioWrite32() and
make defaultdict to avoid initialize inner items
to empty the dict, call clear instead of making a new object
v2 - to empty the dict, dont re-run constructor, just call .clear()
in post process API also.
Cc: Liming Gao
Cc: Yonghong Zhu
EDK_COMPONENT_TYPE_LIBRARY was 'LIBRARY'
EDK_COMPONENT_TYPE_SECURITY_CORE was 'SECURITY_CORE'
EDK_COMPONENT_TYPE_COMBINED_PEIM_DRIVER was 'COMBINED_PEIM_DRIVER'
EDK_COMPONENT_TYPE_PIC_PEIM was 'PIC_PEIM'
EDK_COMPONENT_TYPE_RELOCATABLE_PEIM was 'RELOCATABLE_PEIM'
EDK_COMPONENT_TYPE_BS_DRIVER was
On Thu, Mar 08, 2018 at 01:13:53PM +, Ard Biesheuvel wrote:
> Add a ACPI Processor Properties Topology Table (PPTT) to the SynQuacer
> builds. This information is used by the OS to tune the scheduler.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
To help diagnose ACPI related boot problems, include the 'acpiview'
builtin shell command to our build of the UEFI Shell.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
Platform/Socionext/DeveloperBox/DeveloperBox.dsc
Laszlo kindly implemented support for correctly sequencing the load
order of the various DXE drivers involved in persistent variable
support so that we can ensure that an empty or corrupted varstore
in NOR flash is reinitialized before the variable runtime driver
attempts to access it. So
SynQuacer's PlatformDxe uses HII style dynamic PCDs, and so it
implicitly depends on the PI variable protocol. This dependency is
not made explicit due to the fact that it is platform dependent
whether a certain variable is backed by such a dynamic PCD.
So add gEfiVariableArchProtocolGuid to
Even though the builtin NETSEC controller driver implements the Simple
Network Protocol (SNP) directly, other network controllers connected
via PCIe may be supported by a UNDI driver, which require the generic
SnpDxe driver in order to be usable.
Contributed-under: TianoCore Contribution
Some changes that have been queuing up over the past weeks.
Ard Biesheuvel (4):
Platform/Socionext/DeveloperBox: add SNP driver
Platform/SynQuacer: add 'acpiview' shell command to build
Silicon/SynQuacer/PlatformDxe: depex on gEfiVariableArchProtocolGuid
Silicon/SynQuacer: drop BEFORE
From: Masahisa KOJIMA
GMAC is a Gigabit Ethernet MAC implemented in NETSEC. When the physical
link is changed from DOWN to UP, GMAC should be reinitialized properly.
We add polling function to check the physical link status and
reinitialize GMAC:
- when the GMAC is
On 27 April 2018 at 12:58, Leif Lindholm wrote:
> On Thu, Mar 08, 2018 at 01:13:53PM +, Ard Biesheuvel wrote:
>> Add a ACPI Processor Properties Topology Table (PPTT) to the SynQuacer
>> builds. This information is used by the OS to tune the scheduler.
>>
>>
Add support for the EFI_FV_FILETYPE_MM_STANDALONE file type to VolInfo.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ezra Godfrey
---
BaseTools/Source/C/VolInfo/VolInfo.c | 4
1 file changed, 4 insertions(+)
diff --git
The ACPICA iASL compiler has been enhanced to support the
generation of an AML hex file which is required by the
Dynamic Tables Framework. The patch for this enhancement
has been integrated in the ACPICA repository. Therefore
the Prerequisites section in the Readme has been updated
accordingly.
Updated IORT structure definitions to conform to the IO Remapping
Table, Platform Design Document, Revision D, March 2018.
The following structures have been updated:
1. SMMUv3 - fix on proximity node.
2. PMCG - added page 1 support.
3. Root complex node - added DMA mask (memory address
This patchset contains the changes necessary for supporting the IORT
specification Revision D, March 2018 update.
The "MdePkg: IORT Specification Rev D updates" patch has already been
ACKed by Ard Biesheuve and Liming Gao; however has not yet been merged
in the tianorcore\edk2 repository. Since
Update IORT generator to conform to the IO Remapping
Table, Platform Design Document, Revision D, March 2018
The generator has been updated for:
1. SMMUv3 - fix on proximity node.
2. PMCG - added page 1 support.
3. Root complex node - added DMA mask (memory address
size limit).
Update Dsdt.asl file to match the implementation in upstream
edk2-platforms master for the FVP platform. Also updated the
DefinitionBlock to limit the length of the TableId to 8 chars.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Sami Mujawar
The iASL compiler's -tc option has been updated to generate
output that is suitable for including from a C file. The iASL
compiler uniquely names the C array containing the processed
table data as _aml_code. This update can be seen
in the ACPICA git repository at
The ACPICA iASL compiler has been enhanced to support the
generation of an AML hex file which is required by the
Dynamic Tables Framework. The patch for this enhancement
has been integrated in the ACPICA repository. Therefore
the Prerequisites section in the Readme has been updated
accordingly.
The iASL compiler's -tc option has been updated to generate
output that is suitable for including from a C file. The iASL
compiler uniquely names the C array containing the processed
table data as _aml_code. This update can be seen
in the ACPICA git repository at
The ACPICA iAsl compiler has recently been enhanced to support a
feature required by Dynamic Tables Framework for processing ASL
files. The compiler however generates slightly different symbol
names to what was previously referenced in the Configuration Manager.
This patchset adapts to the latest
the function is only used in one other function.
just move it there.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/AutoGen/GenPcdDb.py | 52 ++--
1 file changed, 26 insertions(+), 26
currently GUID packing and pack size determination is spread
throughout the code. This introduces a shared function and dict and
routes all code paths through them.
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement
add constants for dependency expression opcode strings
use these new opcode string constants
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
just assign correct value to member variable in __init__ or call
parent __init__
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/AutoGen/IdfClassObject.py | 89 +---
1 file changed, 40
No need to make a list from the set. just pop the item off.
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
we dont need to keep data we already have in different formats...
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
There is no need to make a list to make a set. remove lists
that are only used in constructing sets.
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/GenPatchPcdTable/GenPatchPcdTable.py | 2 +-
1 file changed, 1 insertion(+), 1
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/AutoGen/IdfClassObject.py | 1 -
1 file changed, 1 deletion(-)
diff --git
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/GenFds/Fv.py | 34 ++--
1 file changed, 17 insertions(+), 17
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/AutoGen/InfSectionParser.py | 9 -
1 file changed, 4 insertions(+), 5
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/Common/DataType.py | 1 -
1 file changed, 1 deletion(-)
diff --git
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/AutoGen/GenVar.py | 5 -
1 file changed, 5 deletions(-)
diff --git
looping over a list and recomputing the same value has no impact on final value
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
no need to construct 2 dictionaries.
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/Workspace/BuildClassObject.py | 10
Thanks.
Do you also want to update STTANDALONE MM CORE?
Thank you
Yao Jiewen
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ezra
> Godfrey
> Sent: Friday, April 27, 2018 12:57 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH]
add the API root in one class file.
delete the static API out of both classes.
share it in the single location.
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
remove unused lists, dicts, and duplicate variables
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/Eot/Eot.py | 5
make this function @staticmethod since self parameter is not used.
change valuelist to valuedict since it is a dictionary.
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
PCD size by type is shared so this change both removes duplication
and makes the function work for all numeric PCD types.
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
this serves no purpose since we dont change the global or assign to it.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/AutoGen/UniClassObject.py | 2 --
1 file changed, 2 deletions(-)
diff --git
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/Eot/EotGlobalData.py | 29
1 file changed, 29 deletions(-)
since we never access the values in the copied dict, just use a list instead.
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
change a dict to a set since we never examine the contents, just the keys.
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
this class was never instantiated. the static function was called.
save the function, remove the rest.
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
split them into 2 seperate lines.
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/Workspace/BuildClassObject.py | 15
change methods which do not use self to @staticmethod
change their calls to use class name instead of instance
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
move both GetPcdMaxSize and GetPcdSize to the PcdClassObject.
fix MAX_SIZE_TYPE to have int values
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
dont use dict.get() inside loops of dictionary contents. its not needed.
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
since instances are not added to cache, the factory does nothing.
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
it looks like a old POC of the concepts then used to make the classes
in the file.
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/AutoGen/ValidCheckingInfoObject.py | 16
+---
1 file changed, 1
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/AutoGen/GenPcdDb.py | 11 ---
1 file changed, 11 deletions(-)
diff
the lists were used in __init__ then converted to sets
instead just use the sets from the begining
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/AutoGen/GenPcdDb.py | 17 ++---
1 file changed, 2 insertions(+), 15
PCD size by type is shared. just use it.
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/AutoGen/ValidCheckingInfoObject.py |
minimize risk for exceptions.
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/AutoGen/ValidCheckingInfoObject.py | 5 +
functions (like join) can use the iterator just as easily.
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/AutoGen/AutoGen.py
this class has a fucntion to share between Exception and RangeExpression
change both classes to call this function init in their init
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
as we only do membership (in) testing for this, set is better
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
When BottomUp search is used the MaxAddress is incorrectly chosen to
be BaseAddress instead of EndAddress.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Roman Bacik
---
MdeModulePkg/Core/Dxe/Gcd/Gcd.c | 4 ++--
1 file changed, 2 insertions(+),
change methods which do not use self to @staticmethod
change their calls to use class name instead of instance
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
first goal in this series is reduction in meaningless memory allocation or
use. An example is creating lists from iterators for the sole purpose of
passing into anthoer function where the function would take the iterator.
Another example is making a list just to create a set.
second goal is
Create 4 boot options on HiKey960 platform. They're "Boot from SD",
"Grub", "Android Boot" and "Android Fastboot".
Cc: Laszlo Ersek
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Acked-by: Laszlo Ersek
Please also update the function comment " Do an AllocatePages () of type
AllocateMaxAddress for EfiBootServicesCode
memory."
With that, Reviewed-by: Star Zeng .
Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On
Send CMD12 to stop transimission for accessing multiple blocks. It's
required by SD Card protocol.
Cc: Star Zeng
Cc: Eric Dong
Cc: Ruiyu Ni
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Replace DwEmmcDxe driver by DwMmcHcDxe driver on HiKey platform. Since
the new driver could work on both eMMC and SD controller.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by:
Enable DwMmcHcDxe driver on HiKey960 platform.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Haojian Zhuang
---
Create 4 predefined boot options for HiKey. They're
"Boot from SD", "Grub", "Android Boot" and "Android Fastboot".
Cc: Laszlo Ersek
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Acked-by: Laszlo Ersek
Changelog:
v7:
* Fix memory leakage on DevicePath.
v6:
* Remove redundant definition -- "GRUB_FILE_NAME".
v5:
* Avoid to merge device path and grub's file path in driver.
Merge them directly in DSC file.
* Avoid duplicated code to create boot options.
* Use goto to handle error
Reviewed-by: Liming Gao
>-Original Message-
>From: Ni, Ruiyu
>Sent: Wednesday, April 25, 2018 2:05 PM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming
>Subject: [PATCH] MdePkg/DevicePathToText: Fix iSCSI.Lun byte order issue
>
>Contributed-under:
From: Yunhua Feng
Fix regression bug by 3378782691af that cause build failure
for platforms using hierarchical dsc.
Fixes:https://bugzilla.tianocore.org/show_bug.cgi?id=941
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under:
83 matches
Mail list logo