Re: [edk2] [PATCH v2 1/1] OvmfPkg/PlatformPei: clear CPU caches

2018-10-02 Thread Marc-André Lureau
Hi On Tue, Oct 2, 2018 at 3:55 PM Laszlo Ersek wrote: > > On 10/02/18 13:37, Marc-André Lureau wrote: > > On Tue, Oct 2, 2018 at 2:55 PM Laszlo Ersek wrote: > > >> Please fix your git settings for your local edk2 clone. Your patch > >> contains context lines with LF (not CRLF) line endings, and

Re: [edk2] [PATCH v3 1/1] OvmfPkg/PlatformPei: clear CPU caches

2018-10-02 Thread Laszlo Ersek
On 10/02/18 14:17, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > This is for conformance with the TCG "Platform Reset Attack Mitigation > Specification". Because clearing the CPU caches at boot doesn't impact > performance significantly, do it unconditionally, for simplicity's

[edk2] Problems with FDF for OptionROM when using GCC

2018-10-02 Thread Tomas Pilar (tpilar)
Hi, I am trying to move the OptionROM flash specification in my package to a FDF file. I use the following snippet to define the OptionROM: [Defines]   FDF_VERSION = 0x0100   FDF_SPECIFICATION = 0x0001001B   [OptionROM.SfcNicDriver]   INF USE = $(ARCH) SfcPkg/SfcNicDriver/SfcNicDriver.inf {

Re: [edk2] [PATCH v2 1/1] OvmfPkg/PlatformPei: clear CPU caches

2018-10-02 Thread Marc-André Lureau
Hi On Tue, Oct 2, 2018 at 2:55 PM Laszlo Ersek wrote: > > Hi Marc-André, > > On 10/02/18 10:36, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > This is for conformance with the TCG "Platform Reset Attack Mitigation > > Specification". Because clearing the CPU caches at

Re: [edk2] [PATCH v2 1/1] OvmfPkg/PlatformPei: clear CPU caches

2018-10-02 Thread Laszlo Ersek
Anthony, Julien, Gary, On 10/02/18 13:16, Laszlo Ersek wrote: > On 10/02/18 10:36, marcandre.lur...@redhat.com wrote: [...] > The rest looks good, thanks. I'll regression-test the patch (with SMP > and UP guests) once you post v3. can one of you guys please regression-test v3 as well, in a Xen

Re: [edk2] [PATCH v2 1/1] OvmfPkg/PlatformPei: clear CPU caches

2018-10-02 Thread Laszlo Ersek
On 10/02/18 13:55, Laszlo Ersek wrote: > On 10/02/18 13:37, Marc-André Lureau wrote: >> On Tue, Oct 2, 2018 at 2:55 PM Laszlo Ersek wrote: > >>> Please fix your git settings for your local edk2 clone. Your patch >>> contains context lines with LF (not CRLF) line endings, and that's not >>>

Re: [edk2] Problems with FDF for OptionROM when using GCC

2018-10-02 Thread Tomas Pilar (tpilar)
So the solution turns out to swap the Compress and Guided around, Compress apparently requires a LeafSection while Guided is happy to contain EncapSection. Odd. Anyway, I had to hack up GenFds to get a sensible python backtrace:   1 diff --git a/BaseTools/Source/Python/GenFds/GenFds.py

Re: [edk2] [PATCH v3 1/1] OvmfPkg/PlatformPei: clear CPU caches

2018-10-02 Thread Anthony PERARD
On Tue, Oct 02, 2018 at 04:17:25PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > This is for conformance with the TCG "Platform Reset Attack Mitigation > Specification". Because clearing the CPU caches at boot doesn't impact > performance significantly, do it

Re: [edk2] [PATCH v2 1/1] OvmfPkg/PlatformPei: clear CPU caches

2018-10-02 Thread Laszlo Ersek
On 10/02/18 13:37, Marc-André Lureau wrote: > On Tue, Oct 2, 2018 at 2:55 PM Laszlo Ersek wrote: >> Please fix your git settings for your local edk2 clone. Your patch >> contains context lines with LF (not CRLF) line endings, and that's not >> correct for edk2. > > Shouldn't it be catched by:

Re: [edk2] [PATCH v2 1/1] OvmfPkg/PlatformPei: clear CPU caches

2018-10-02 Thread Laszlo Ersek
On 10/02/18 14:10, Marc-André Lureau wrote: > Hi > > On Tue, Oct 2, 2018 at 3:55 PM Laszlo Ersek wrote: >> >> On 10/02/18 13:37, Marc-André Lureau wrote: >>> On Tue, Oct 2, 2018 at 2:55 PM Laszlo Ersek wrote: >> Please fix your git settings for your local edk2 clone. Your patch

Re: [edk2] [PATCH v3 1/1] OvmfPkg/PlatformPei: clear CPU caches

2018-10-02 Thread Laszlo Ersek
On 10/02/18 15:27, Anthony PERARD wrote: > On Tue, Oct 02, 2018 at 04:17:25PM +0400, marcandre.lur...@redhat.com wrote: >> From: Marc-André Lureau >> >> This is for conformance with the TCG "Platform Reset Attack Mitigation >> Specification". Because clearing the CPU caches at boot doesn't impact

[edk2] [PATCH] BaseTools: Allow multiple PciDeviceId in Fdf OptionROM override

2018-10-02 Thread Tomas Pilar (tpilar)
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Tomas Pilar --- BaseTools/Source/Python/GenFds/FdfParser.py | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/BaseTools/Source/Python/GenFds/FdfParser.py

Re: [edk2] [PATCH] BaseTools: Allow multiple PciDeviceId in Fdf OptionROM override

2018-10-02 Thread Laszlo Ersek
+Yonghong, +Liming On 10/02/18 16:46, Tomas Pilar (tpilar) wrote: > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Tomas Pilar > --- > BaseTools/Source/Python/GenFds/FdfParser.py | 11 --- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git

[edk2] [PATCH] Maintainers.txt: add DynamicTablesPkg

2018-10-02 Thread Leif Lindholm
DynamicTablesPkg has been in edk2-staging[1] for some time now, and it is time for it to move into the main tree. [1] https://github.com/tianocore/edk2-staging/tree/dynamictables Add Evan and Sami as maintainers of the new package, and let them bring it in themselves. Contributed-under:

Re: [edk2] [PATCH v3 1/1] OvmfPkg/PlatformPei: clear CPU caches

2018-10-02 Thread Laszlo Ersek
On 10/02/18 14:17, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > This is for conformance with the TCG "Platform Reset Attack Mitigation > Specification". Because clearing the CPU caches at boot doesn't impact > performance significantly, do it unconditionally, for simplicity's

Re: [edk2] [PATCH] Maintainers.txt: add DynamicTablesPkg

2018-10-02 Thread Laszlo Ersek
On 10/02/18 18:03, Leif Lindholm wrote: > DynamicTablesPkg has been in edk2-staging[1] for some time now, and it is > time for it to move into the main tree. > [1] https://github.com/tianocore/edk2-staging/tree/dynamictables > > Add Evan and Sami as maintainers of the new package, and let them

[edk2] How to correctly sign EFI Firmware Volume?

2018-10-02 Thread Petr Vandrovec
Hi, I've sent this ot fw_os_forum, and was redirected here. Sorry if you are receiving this twice. I'm looking at options how to sign our EFI firmware through some industry-standard embedded signature option, and signing whole firmware volume as described in Platform Initialization spec

[edk2] Changes to Intel contribution model

2018-10-02 Thread Doran, Mark
Hi Everyone: The way Intel's BIOS development community is organized has changed recently. This change presents opportunities to rethink some of the ways that we interact with the open source community around BIOS and this project in particular. In general, I believe Intel is interested in

[edk2] [PATCH v3 1/1] OvmfPkg/PlatformPei: clear CPU caches

2018-10-02 Thread marcandre . lureau
From: Marc-André Lureau This is for conformance with the TCG "Platform Reset Attack Mitigation Specification". Because clearing the CPU caches at boot doesn't impact performance significantly, do it unconditionally, for simplicity's sake. Flush the cache on all logical processors, thanks to

Re: [edk2] [PATCH v2 1/1] OvmfPkg/PlatformPei: clear CPU caches

2018-10-02 Thread Marc-André Lureau
Hi On Tue, Oct 2, 2018 at 4:19 PM Laszlo Ersek wrote: > > On 10/02/18 14:10, Marc-André Lureau wrote: > > Hi > > > > On Tue, Oct 2, 2018 at 3:55 PM Laszlo Ersek wrote: > >> > >> On 10/02/18 13:37, Marc-André Lureau wrote: > >>> On Tue, Oct 2, 2018 at 2:55 PM Laszlo Ersek wrote: > >> >

Re: [edk2] How to correctly sign EFI Firmware Volume?

2018-10-02 Thread Andrew Fish
Petr, Mike Kinney and I just had an interesting conversation that relates to your question. It has to do with the FV being a file system and not really the FLASH layout. In the UEFI PI Spec and edk2 lingo you produce and FD (Flash Device) that consists of a set of FVs. There is not a

[edk2] [PATCH v2 1/1] OvmfPkg/PlatformPei: clear CPU caches

2018-10-02 Thread marcandre . lureau
From: Marc-André Lureau This is for conformance with the TCG "Platform Reset Attack Mitigation Specification". Because clearing the CPU caches at boot doesn't impact performance significantly, do it unconditionally, for simplicity's sake. Flush the cache on all logical processors, thanks to

Re: [edk2] [PATCH v3 00/16] Removed unused PCDs

2018-10-02 Thread Laszlo Ersek
Ray, Chao, guys, you keep breaking the development process. Please fix your email clients *now*. On 08/28/18 05:42, shenglei wrote: > shenglei (16): > IntelFsp2Pkg FspSecCore: Remove unused PCDs > IntelFsp2Pkg/BaseFspCommonLib: Remove unused PCDs > IntelFsp2Pkg/BaseFspPlatformLib: Remove

Re: [edk2] [PATCH v2 1/1] OvmfPkg/PlatformPei: clear CPU caches

2018-10-02 Thread Laszlo Ersek
Hi Marc-André, On 10/02/18 10:36, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > This is for conformance with the TCG "Platform Reset Attack Mitigation > Specification". Because clearing the CPU caches at boot doesn't impact > performance significantly, do it unconditionally,

Re: [edk2] [PATCH v2 1/1] OvmfPkg/PlatformPei: clear CPU caches

2018-10-02 Thread Laszlo Ersek
On 10/02/18 10:36, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > This is for conformance with the TCG "Platform Reset Attack Mitigation > Specification". Because clearing the CPU caches at boot doesn't impact > performance significantly, do it unconditionally, for simplicity's