+Andrew, Laszlo, Mike.
On Thu, Jan 31, 2019 at 06:19:48PM +0100, Ard Biesheuvel wrote:
> On Thu, 31 Jan 2019 at 16:24, Leif Lindholm wrote:
> >
> > On Tue, Jan 29, 2019 at 04:26:33PM +, Pete Batard wrote:
> > > Contributed-under: TianoCore Contribution Agreement 1.1
> > > Signed-off-by: Pete
> On Jan 31, 2019, at 11:57 AM, Leif Lindholm wrote:
>
> +Andrew, Laszlo, Mike.
>
> On Thu, Jan 31, 2019 at 06:19:48PM +0100, Ard Biesheuvel wrote:
>> On Thu, 31 Jan 2019 at 16:24, Leif Lindholm wrote:
>>>
>>> On Tue, Jan 29, 2019 at 04:26:33PM +, Pete Batard wrote:
Hi Tzy Way,
Thank you for this contribution.
I do have some high-level comments.
First of all, my best guess is that you have used Lan9118Dxe for
reference when developing this driver. This is somewhat unfortunate.
I am reminded that
a) we badly need to migrate that driver (and Lan91xDxe) to
On Thu, Jan 31, 2019 at 06:14:45PM +0100, Ard Biesheuvel wrote:
> On Thu, 31 Jan 2019 at 16:05, Leif Lindholm wrote:
> >
> > On Wed, Jan 30, 2019 at 08:39:43PM +0100, Ard Biesheuvel wrote:
> > > Expose the SoC's RNG peripheral via the EFI_RNG_PROTOCOL.
> > > This is used by Linux to seed the
Defined 2 PCDs(Test4 & Test401) and 2 SKUs(DEFAULT & _),
then set "SKUID_Defines" to ALL, for FixedAtBuild
gEfiStructuredPcdPkgTokenSpaceGuid. Test401 in this case,
its value should get from "Default" SKU, not from "_" SKU,
but we does not set value in SKU "_" in dsc, so Test401
should only
To avoid potential NULL pointer dereference issue. Initialize them at
the beginning of the function.
Cc: Jian J Wang
Cc: Hao Wu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Chen A Chen
---
MdeModulePkg/Application/CapsuleApp/CapsuleApp.c| 5 +++--
Uninitialized pointer variable may randomly point to a block of memory.
In This case, FreePool function will free a block of memory that is not
belongs to this function.
Cc: Ruiyu Ni
Cc: Hao Wu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Chen A Chen
---
StructurePCD value display incorrect in "Not used" section,
that the value defined in structure does not show.
StructurePCD will not display in "Not Used" section if
main structure not define in dsc and pcd not in inf
Cc: Bob Feng
Cc: Liming Gao
Contributed-under: TianoCore Contribution
Hi Nikita,
I have one comment here, could you help to verify this patch series with VS
tool chain build before commit the patches?
Thanks,
Dandan
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Nikita Leshenko
> Sent: Thursday, January
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409
For the NvmExpressPei driver, this commit will update the driver to
consume the S3StorageDeviceInitList LockBox in S3 phase. The purpose is to
perform an on-demand (partial) NVM Express device
enumeration/initialization to benefit the S3
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409
For the NvmExpressPei driver, this commit will add codes to produce the
Storage Security Command PPI if the underlying NVM Express controller
supports the Security Send and Security Receive commands.
Cc: Jian J Wang
Cc: Ray Ni
Cc: Eric
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409
This commit will add the definitions for Storage Security Command (SSC)
PPI. This PPI will be be used to abstract mass storage devices to allow
code running in the PEI phase to send security protocol commands to mass
storage devices without
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409
This commit will add the GUID definitions for LockBox which is used to
save a list of storage devices that need to get initialized during the S3
resume.
The content of the LockBox will be a DevicePath structure that contains
zero or more
This commit is out of the scope for BZ-1409. The commit will remove the
call of RegisterForShadow() at the entry point of the driver. By doing so,
the driver is now possible to be executed without being re-loaded into
permanent memory.
Thus, this commit will update the NvmExpressPei driver to
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409
This commit will add the definitions for EDKII PEI ATA PassThru PPI. This
PPI will provide services that allow ATA commands to be sent to ATA
devices attached to an ATA controller in the PEI phase.
More specifically, the PPI will provide
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409
This commit will add the definitions for ATA AHCI host controller PPI. The
purpose of the PPI in to provide:
* MMIO base address
* Controller identification information (DevicePath)
for ATA host controllers working under AHCI mode.
Cc:
The series is also available at:
https://github.com/hwu25/edk2/tree/opal_remodel_v3
V3 changes:
For patch 2, reuse the definitions within AtaPassThru protocol header file
to reduce code duplication.
For patch 4, add detailed comments to illustrate the content that will be
stored in the newly
Update header file function name for FfsFindFileByName to match
implementation function name.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jeff Brasen
Cc: Leif Lindholm
Cc: Ard Biesheuvel
---
EmbeddedPkg/Include/Library/PrePiLib.h | 2 +-
1 file changed, 1
> -Original Message-
> From: Leif Lindholm
> Sent: Wednesday, December 19, 2018 12:11 AM
> To: Meenakshi Aggarwal
> Cc: ard.biesheu...@linaro.org; michael.d.kin...@intel.com; edk2-
> de...@lists.01.org; Udit Kumar ; Varun Sethi
>
> Subject: Re: [PATCH edk2-platforms 10/41] Readme :
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409
This commit will add the support to enlarge a LockBox when using the
LockBoxLib API UpdateLockBox().
Please note that the new support will ONLY work for LockBox with attribute
LOCK_BOX_ATTRIBUTE_RESTORE_IN_S3_ONLY set.
The functional
This commit is out of the scope for BZ-1409. It is a coding style
refinement for the SmmLockBoxLib.
More specifically, the commit will remove all the debug message display
level macros starting with 'EFI_D_' and replace them with macros starting
with 'DEBUG_'.
Cc: Jian J Wang
Cc: Star Zeng
This commit is out of the scope for BZ-1409. It is a refinement for the
PEI library instance within SmmLockBoxLib.
For the below ASSERT statement within function RestoreLockBox():
Status = SmmCommunicationPpi->Communicate (
SmmCommunicationPpi,
Reviewed-by: Ray Ni
--
Thanks,
Ray
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
CYGGCC is too old.There is no verification for it.
https://bugzilla.tianocore.org/show_bug.cgi?id=1377
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang
---
BaseTools/Conf/tools_def.template | 203
> -Original Message-
> From: Leif Lindholm
> Sent: Wednesday, December 19, 2018 12:16 AM
> To: Meenakshi Aggarwal
> Cc: ard.biesheu...@linaro.org; michael.d.kin...@intel.com; edk2-
> de...@lists.01.org; Udit Kumar ; Varun Sethi
>
> Subject: Re: [PATCH edk2-platforms 11/41] IFC : Add
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jeff
> Brasen
> Sent: Thursday, January 31, 2019 7:59 AM
> To: edk2-devel@lists.01.org
> Cc: Edgar Handal; Jeff Brasen
> Subject: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Use 16/32-bit IO
>
There is an CRC16 calculation implementation in
SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c
Does your implementation generate the same CRC16 as above one?
> -Original Message-
> From: edk2-devel On Behalf Of Ming
> Huang
> Sent: Friday, February 1, 2019 2:02 PM
> -Original Message-
> From: Leif Lindholm
> Sent: Wednesday, December 19, 2018 6:56 PM
> To: Meenakshi Aggarwal
> Cc: ard.biesheu...@linaro.org; michael.d.kin...@intel.com; edk2-
> de...@lists.01.org; Udit Kumar ; Varun Sethi
>
> Subject: Re: [PATCH edk2-platforms 13/41] Silicon/NXP
VS2003, VS2005, DDK3790, UNIXGCC, ELFGCC, CYGCC and MYTOOLS are
too old. There is no verification for them. So remove them from
edk2/master.
https://bugzilla.tianocore.org/show_bug.cgi?id=1377
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
Cc: Ray Ni
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard
Remove VS2005 in Build Validation.
https://bugzilla.tianocore.org/show_bug.cgi?id=1377
Cc: Ray Ni
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang
---
OptionRomPkg/ReadMe.txt | 1 -
1 file changed, 1 deletion(-)
diff --git a/OptionRomPkg/ReadMe.txt
VS2003 and VS2005 are too old.There is no verification
for them.
https://bugzilla.tianocore.org/show_bug.cgi?id=1377
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang
---
BaseTools/Conf/tools_def.template | 694
Remove UNIXGCC in OvmfPkgIa32.dsc, OvmfPkgIa32X64.dsc
and OvmfPkgX64.dsc.
https://bugzilla.tianocore.org/show_bug.cgi?id=1377
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Cc: Anthony Perard
Cc: Julien Grall
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by:
DDK3790 is too old.There is no verification for it.
https://bugzilla.tianocore.org/show_bug.cgi?id=1377
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang
---
BaseTools/Conf/tools_def.template | 350
Remove content related to UNIXGCC in README.
https://bugzilla.tianocore.org/show_bug.cgi?id=1377
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Cc: Anthony Perard
Cc: Julien Grall
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang
---
UNIXGCC is too old.There is no verification for it.
https://bugzilla.tianocore.org/show_bug.cgi?id=1377
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang
---
BaseTools/Conf/tools_def.template | 96
Remove MYTOOLS in tools_def.template and change
MYTOOLS to VS2015x86 in target.template.
https://bugzilla.tianocore.org/show_bug.cgi?id=1377
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang
---
ELFGCC is too old.There is no verification for it.
https://bugzilla.tianocore.org/show_bug.cgi?id=1377
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang
---
BaseTools/Conf/tools_def.template | 80
Remove CYGGCC in Build Validation.
https://bugzilla.tianocore.org/show_bug.cgi?id=1377
Cc: Ray Ni
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang
---
OptionRomPkg/ReadMe.txt | 1 -
1 file changed, 1 deletion(-)
diff --git a/OptionRomPkg/ReadMe.txt
Crc16 is used in some cases, so add it to BaseLib.
Ming Huang (1):
MdePkg BaseLib: Add new API CalculateCrc16()
MdePkg/Include/Library/BaseLib.h | 20 ++
MdePkg/Library/BaseLib/CheckSum.c | 73
2 files changed, 93 insertions(+)
--
2.9.5
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1478
Fix issues that reported by Edk2 coding style check tool(ECC) that:
in Comment, <@param SystemTable> does NOT consistent with parameter
name MmSystemTable.
Cc: Ard Biesheuvel
Cc: Liming Gao
Contributed-under: TianoCore Contribution
CalculateCrc16() bases on the initialized mCrcTable. When CalculateCrc16()
is used, mCrcTable16 will take 512Bytes size in the image. When
CalculateCrc16() is not used, mCrcTable16 will not be built in the image,
and no size impact.
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Ard Biesheuvel
Cc: Liming Gao
Cc: Jian J Wang
Cc: Hao Wu
Dandan Bi (2):
MdeModulePkg: Fix coding style issues
MdePkg: Fix coding style issues
.../FaultTolerantWriteSmmCommon.h| 4 ++--
.../FaultTolerantWriteStandaloneMm.c | 2 +-
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1479
Fix issues that reported by Edk2 coding style check tool(ECC) that:
Comment description should end with period '.'
Cc: Ard Biesheuvel
Cc: Jian J Wang
Cc: Hao Wu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by:
-Original Message-
From: Wu, Hao A
Sent: Thursday, January 31, 2019 10:56 PM
To: Jeff Brasen ; edk2-devel@lists.01.org
Cc: Edgar Handal
Subject: RE: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Use 16/32-bit IO widths
> -Original Message-
> From: edk2-devel
On 2/1/2019 2:37 PM, Ni, Ray wrote:
> There is an CRC16 calculation implementation in
> SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c
>
> Does your implementation generate the same CRC16 as above one?
It is not the same with above one.
>
>> -Original Message-
Defined 2 PCDs(Test4 & Test401) and 2 SKUs(DEFAULT & _),
then set "SKUID_Defines" to ALL, for FixedAtBuild
gEfiStructuredPcdPkgTokenSpaceGuid. Test401 in this case,
its value should get from "Default" SKU, not from "_" SKU,
but we does not set value in SKU "_" in dsc, so Test401
should only
> -Original Message-
> From: Jeff Brasen [mailto:jbra...@nvidia.com]
> Sent: Friday, February 01, 2019 3:12 PM
> To: Wu, Hao A; edk2-devel@lists.01.org
> Cc: Edgar Handal
> Subject: RE: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Use 16/32-bit IO
> widths
>
>
>
> -Original
I have pushed py3 patch set to edk2 master.
Thanks,
Bob
-Original Message-
From: Gao, Liming
Sent: Thursday, January 31, 2019 4:24 PM
To: Feng, Bob C ; Laszlo Ersek
Cc: edk2-devel@lists.01.org
Subject: RE: [edk2] [Patch v2 00/33] BaseTools python3 migration patch set
Bob:
I have no
> -Original Message-
> From: Bi, Dandan
> Sent: Friday, February 01, 2019 2:02 PM
> To: edk2-devel@lists.01.org
> Cc: Ard Biesheuvel; Wang, Jian J; Wu, Hao A
> Subject: [patch 1/2] MdeModulePkg: Fix coding style issues
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1479
>
> Fix
The controller supports up to 8 targets (Not reported by the
controller, but based on the implementation of the virtual device),
report them in GetNextTarget and GetNextTargetLun. The firmware will
then try to communicate with them and create a block device for each
one that responds.
Support for
Reset and send the IO controller initialization request. The reply is
read back to complete the doorbell function but it isn't useful to us
because it doesn't contain relevant data or status codes.
See "LSI53C1030 PCI-X to Dual Channel Ultra320 SCSI Multifunction
Controller" technical manual for
Machines should be able to boot after this commit. Tested with different Linux
distributions (Ubuntu, CentOS) and different Windows versions (Windows 7,
Windows 10, Server 2016).
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Nikita Leshenko
Reviewed-by: Aaron Young
The MptScsiControllerSupported function is called for every handle
that appears on the system and if the handle is the lsi53c1030
controller the function would return success. A successful return
value will attach our driver to the device.
Contributed-under: TianoCore Contribution Agreement 1.1
Install Component Name protocols to have a nice display name for the
driver in places such as UEFI shell.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Nikita Leshenko
Reviewed-by: Konrad Rzeszutek Wilk
Reviewed-by: Aaron Young
Reviewed-by: Liran Alon
---
Support dynamic insertion and removal of the protocol
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Nikita Leshenko
Reviewed-by: Konrad Rzeszutek Wilk
Reviewed-by: Aaron Young
Reviewed-by: Liran Alon
---
OvmfPkg/MptScsiDxe/MptScsi.c | 204
Users of this device might pass data pointers which are above 4G, in which case
we can't pass the pointers directly to the controller because the descriptors
contain 32-bit pointers.
Instead of failing the request, use below-4G memory to support the request.
Contributed-under: TianoCore
In order to probe and connect to the MptScsi device we need this
protocol. Currently it does nothing.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Nikita Leshenko
Reviewed-by: Konrad Rzeszutek Wilk
Reviewed-by: Aaron Young
Reviewed-by: Liran Alon
---
Enable the IO Space and Bus Mastering and restore the original values
when the device is stopped. This is a standard procedure in PCI
drivers.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Nikita Leshenko
Reviewed-by: Konrad Rzeszutek Wilk
Reviewed-by: Aaron Young
Used to identify the individual disks in the hardware tree
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Nikita Leshenko
Reviewed-by: Konrad Rzeszutek Wilk
Reviewed-by: Aaron Young
Reviewed-by: Liran Alon
---
OvmfPkg/MptScsiDxe/MptScsi.c | 18 +-
1
Reviewed-by: Chaganty, Rangasai V
-Original Message-
From: Solanki, Digant H
Sent: Thursday, January 31, 2019 12:01 AM
To: edk2-devel@lists.01.org
Cc: Ni, Ray ; Gao, Liming ; Chaganty,
Rangasai V
Subject: [PATCH 5/5] IntelSiliconPkg\Include\IndustryStandard: Update
From: "Ooi, Tzy Way"
Contributed-under: TianCore Contribution Agreement 1.1
Signed-off-by: Ooi, Tzy Way
---
.../Drivers/DwEmacSnpDxe/DwEmacSnpDxe.c | 1368 +
.../Drivers/DwEmacSnpDxe/DwEmacSnpDxe.h | 236 +++
.../Drivers/DwEmacSnpDxe/DwEmacSnpDxe.inf | 69 +
On Thu, Jan 31, 2019 at 08:01:08AM +0100, Marcin Wojtas wrote:
> Hi Leif,
>
> Thanks a lot. While at it - do you think ArmPkg/Include/Library/ArmLib.h
> / ArmPkg/Library/ArmLib/ArmLib.c would be a proper place for it?
As good a place as any. While not ARM-architecture specific, I feel
it's
This series adds driver support for:
- LSI53C1030
- SAS1068
- SAS1068E
These controllers are widely supported by QEMU, VirtualBox and VMWare. This work
is part of the more general agenda of enhancing OVMF boot device support to have
feature parity with SeaBIOS.
We have also developed support for
In preparation for implementing LSI Fusion MPT SCSI devices, create a
basic scaffolding for a driver.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Nikita Leshenko
Reviewed-by: Konrad Rzeszutek Wilk
Reviewed-by: Aaron Young
Reviewed-by: Liran Alon
---
Support for multiple targets will be implemented in a later commit in
this series.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Nikita Leshenko
Reviewed-by: Konrad Rzeszutek Wilk
Reviewed-by: Aaron Young
Reviewed-by: Liran Alon
---
OvmfPkg/MptScsiDxe/MptScsi.c | 34
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Nikita Leshenko
Reviewed-by: Konrad Rzeszutek Wilk
Reviewed-by: Aaron Young
Reviewed-by: Liran Alon
---
OvmfPkg/MptScsiDxe/MptScsi.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git
This will give us an exclusive access to the PciIo of this device
after it was started and until is will be stopped.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Nikita Leshenko
Reviewed-by: Konrad Rzeszutek Wilk
Reviewed-by: Aaron Young
Reviewed-by: Liran Alon
---
Bob:
I have no other comments on this patch set. Reviewed-by: Liming Gao
Thanks
Liming
> -Original Message-
> From: Feng, Bob C
> Sent: Wednesday, January 30, 2019 1:25 PM
> To: Gao, Liming ; Laszlo Ersek
> Cc: edk2-devel@lists.01.org
> Subject: RE: [edk2] [Patch v2 00/33] BaseTools
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1454
Based on latest IGD OpRegion Spec, IGD_OPREGION_MBOX3 needs to be updated with
two new members : Physical Address of Raw VBT Data (RVDA) and Size of Raw VBT
Data (RVDS)
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by:
Reviewed-by: Liming Gao
> -Original Message-
> From: Zhang, Shenglei
> Sent: Thursday, January 31, 2019 3:37 PM
> To: edk2-devel@lists.01.org
> Cc: Mike Turner ; Kinney, Michael D
> ; Gao, Liming
> Subject: [PATCH v5] MdePkg/BaseLib: Add Base64Encode() and Base64Decode()
>
> From:
One comment on the title. This is Patch V5, not Patch 5/5. You don't need to
send new patch.
Thanks
Liming
> -Original Message-
> From: Solanki, Digant H
> Sent: Thursday, January 31, 2019 4:01 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ray ; Gao, Liming ; Chaganty,
> Rangasai V
>
On 1/31/2019 3:51 PM, Ard Biesheuvel wrote:
The POC code is inhttps://github.com/jyao1/edk2/tree/ReOrg.
It basically split the EDKII common code to three directories:
Core/, Device/, and Feature/.
I'm not sure I like the 'Device' name, but that's not that important
at this stage - I like that
Reviewed-by: Ray Ni
> -Original Message-
> From: Solanki, Digant H
> Sent: Thursday, January 31, 2019 4:01 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ray ; Gao, Liming ;
> Chaganty, Rangasai V
> Subject: [PATCH 5/5] IntelSiliconPkg\Include\IndustryStandard: Update
> IGD_OPREGION_MBOX3
https://bugzilla.tianocore.org/show_bug.cgi?id=1503
A pointer variable should be checked if it is NULL or Valid before using it.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Maggie Chu
Cc: Chao Zhang
Cc: Jiewen Yao
Cc: Eric Dong
---
czw., 31 sty 2019 o 11:28 Leif Lindholm napisał(a):
>
> On Thu, Jan 31, 2019 at 08:01:08AM +0100, Marcin Wojtas wrote:
> > Hi Leif,
> >
> > Thanks a lot. While at it - do you think ArmPkg/Include/Library/ArmLib.h
> > / ArmPkg/Library/ArmLib/ArmLib.c would be a proper place for it?
>
> As good a
On Thu, Jan 31, 2019 at 01:06:15PM +0100, Marcin Wojtas wrote:
> czw., 31 sty 2019 o 11:28 Leif Lindholm napisał(a):
> >
> > On Thu, Jan 31, 2019 at 08:01:08AM +0100, Marcin Wojtas wrote:
> > > Hi Leif,
> > >
> > > Thanks a lot. While at it - do you think ArmPkg/Include/Library/ArmLib.h
> > > /
On 2019.01.30 22:22, Leif Lindholm wrote:
First of all - this is something I would like to see contributed
directly to edk2 EmbeddedPkg. It's something me and Ard have discussed
adding at some point, but never getting around to.
I would also like to look into whether we could replace
Hi Leif. Thanks for reviewing this patchset.
On 2019.01.30 21:50, Leif Lindholm wrote:
Hi Pete,
I will only have minor comments on this set, but I'll start with this
documentation.
On Tue, Jan 29, 2019 at 04:26:52PM +, Pete Batard wrote:
Contributed-under: TianoCore Contribution
> On Jan 28, 2019, at 9:59 PM, Ni, Ray wrote:
>
> Hello,
> I'd like to propose to split today's BIG packages in following ways:
>
> ==Overview =
>
> 1. Separate Industry standard definitions from UEFI and PI interfaces.
Ray,
>From a big picture point of view
Removed conditional pre-compiling for ARM CPUs because function
ValidateCacheAttributes(..) is based on ACPI PPTT specification.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Krzysztof Koch
Reported-by: Zhichao Gao
---
The code can be found at:
On 2019.01.30 21:59, Leif Lindholm wrote:
Hi Pete,
I have two annoying pieces of feedback that apply to the whole set.
Firstly, I would really appreciate if we could have some sort of
commit messages rather than just subject lines.
I can work on that.
So, for ACPI, mention the provenance
On Thu, 31 Jan 2019 at 15:13, Leif Lindholm wrote:
>
> On Thu, Jan 31, 2019 at 12:30:22PM +, Pete Batard wrote:
> > Hi Leif. Thanks for reviewing this patchset.
> >
> > On 2019.01.30 21:50, Leif Lindholm wrote:
> > > Hi Pete,
> > >
> > > I will only have minor comments on this set, but I'll
On Thu, 31 Jan 2019 at 15:36, Ard Biesheuvel wrote:
>
> On Thu, 31 Jan 2019 at 15:13, Leif Lindholm wrote:
> >
> > On Thu, Jan 31, 2019 at 12:30:22PM +, Pete Batard wrote:
> > > Hi Leif. Thanks for reviewing this patchset.
> > >
> > > On 2019.01.30 21:50, Leif Lindholm wrote:
> > > > Hi
On Wed, Jan 30, 2019 at 08:39:43PM +0100, Ard Biesheuvel wrote:
> Expose the SoC's RNG peripheral via the EFI_RNG_PROTOCOL.
> This is used by Linux to seed the KASLR routines.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
Not tested, but looks fine.
On Thu, Jan 31, 2019 at 12:30:22PM +, Pete Batard wrote:
> Hi Leif. Thanks for reviewing this patchset.
>
> On 2019.01.30 21:50, Leif Lindholm wrote:
> > Hi Pete,
> >
> > I will only have minor comments on this set, but I'll start with this
> > documentation.
> >
> > On Tue, Jan 29, 2019 at
We will be holding our February Community Meeting on the *2nd* Thursday
of February to accommodate holiday schedules. Details are posted here:
https://www.tianocore.org/community-meeting/
Please contact me or post to the list anything you'd like to see discussed.
Cheers,
Stephano
On Thu, 31 Jan 2019 at 16:05, Leif Lindholm wrote:
>
> On Wed, Jan 30, 2019 at 08:39:43PM +0100, Ard Biesheuvel wrote:
> > Expose the SoC's RNG peripheral via the EFI_RNG_PROTOCOL.
> > This is used by Linux to seed the KASLR routines.
> >
> > Contributed-under: TianoCore Contribution Agreement
On Tue, Jan 29, 2019 at 04:26:33PM +, Pete Batard wrote:
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Pete Batard
>
> Reviewed-by: Ard Biesheuvel
> ---
> Silicon/Broadcom/Bcm283x/Bcm283x.dec | 23 ++
>
On 1/30/2019 10:56 PM, Gao, Liming wrote:
Karunakar:
There is one BZ https://bugzilla.tianocore.org/show_bug.cgi?id=1446 on
Feature Flag expression in INF. INF spec has listed the syntax for it. But,
BaseTools doesn't support it now. If you have the similar request, please add
the
On Thu, 31 Jan 2019 at 16:24, Leif Lindholm wrote:
>
> On Tue, Jan 29, 2019 at 04:26:33PM +, Pete Batard wrote:
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Pete Batard
> >
> > Reviewed-by: Ard Biesheuvel
> > ---
> > Silicon/Broadcom/Bcm283x/Bcm283x.dec
On 2019.01.31 14:44, Ard Biesheuvel wrote:
On Thu, 31 Jan 2019 at 15:36, Ard Biesheuvel wrote:
On Thu, 31 Jan 2019 at 15:13, Leif Lindholm wrote:
On Thu, Jan 31, 2019 at 12:30:22PM +, Pete Batard wrote:
Hi Leif. Thanks for reviewing this patchset.
On 2019.01.30 21:50, Leif Lindholm
91 matches
Mail list logo
