Re: [edk2] [PATCH v1 0/6] DynamicTablesPkg: Framework updates and fixes

2019-02-25 Thread Laszlo Ersek
On 02/21/19 19:14, Sami Mujawar wrote: > This patch series updates the Dynamic Tables Framework to > incorporate the following changes: > * Fix DEPEX to load modules in correct order. > * Add options for OEMs to provide OEM Table ID and revision. > * Update DBG2_DEBUG_PORT_DDI macro to

Re: [edk2] [PATCH edk2-platforms v1 0/4] Platform/ARM: Updates corresponding to Dynamic Tables Framework changes

2019-02-25 Thread Sami Mujawar
Hi Leif, Ard, I have pushed the Dynamic Tables Framework changes to tianocore\edk2. You should now be able to build the edk2-platform patches for dynamic tables with latest edk2 master. Regards, Sami Mujawar -Original Message- From: Sami Mujawar Sent: 21 February 2019 06:15 PM To:

Re: [edk2] [PATCH 0/2] DynamicTablesPkg Updates

2019-02-25 Thread Laszlo Ersek
On 02/21/19 19:38, Ashish Singhal wrote: > DynamicTablesPkg/DynamicTableManagerDxe: Update DEPEX > > This patch adds appropriate dependencies to DynamicTableManagerDxe. > The initialization function fails if gEdkiiDynamicTableFactoryProtocolGuid > and gEdkiiConfigurationManagerProtocolGuid are

Re: [edk2] [PATCH] StdLib: Update resolv.conf to use Google's public DNS servers

2019-02-25 Thread Carsey, Jaben
> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Monday, February 25, 2019 11:41 AM > To: Rebecca Cran ; edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Daryl McDaniel li...@mc2research.org> > Subject: Re: [edk2] [PATCH] StdLib: Update resolv.conf to use Google's

Re: [edk2] [PATCH] StdLib: Update resolv.conf to use Google's public DNS servers

2019-02-25 Thread Laszlo Ersek
On 02/25/19 19:36, Rebecca Cran via edk2-devel wrote: > The current servers listed appear to be unusable. I suspect most > people will get correct DNS servers via DHCP, but the defaults > should work for anyone. > > Change the entries to be Google's public DNS servers. > Also, change the domain

[edk2] [PATCH] StdLib: Update resolv.conf to use Google's public DNS servers

2019-02-25 Thread Rebecca Cran via edk2-devel
The current servers listed appear to be unusable. I suspect most people will get correct DNS servers via DHCP, but the defaults should work for anyone. Change the entries to be Google's public DNS servers. Also, change the domain name to be example.com, to be more applicable to consumers outside

Re: [edk2] [PATCH] MdePkg/UefiLib: Simplify protocol un/installation abstraction

2019-02-25 Thread Ashish Singhal
Mike, Do you have any update on this change yet? Thanks Ashish -Original Message- From: Kinney, Michael D Sent: Tuesday, February 19, 2019 12:56 PM To: Ashish Singhal ; edk2-devel@lists.01.org; Kinney, Michael D Cc: Gao, Liming Subject: RE: [PATCH] MdePkg/UefiLib: Simplify protocol

Re: [edk2] [PATCH] Fix links in Maintainers.txt and remove slow, outdated sourceforge git mirror

2019-02-25 Thread Laszlo Ersek
On 02/25/19 14:36, Gao, Liming wrote: > I can't clone edk2 code from http://git.code.sf.net/p/tianocore/edk2. Seemly, > it doesn't work. So, I agree to remove it. > > Reviewed-by: Liming Gao Do we consider this a bugfix, suitable to be pushed during the soft feature freeze? I suggest that we

[edk2] [PATCH 0/1] EmbeddedPkg: Fix multiple Virtual RTC issues

2019-02-25 Thread Pete Batard
This patch fixes multiple issues in VirtualRealTimeClockLib.c: 1. Use of two separate variables (ElapsedSeconds and EpochSeconds) in LibGetTime(), where only a single one should have been used. 2. Possible underflow while sustracting TZ/DST offsets in LibSetTime() if the user sets a date

[edk2] [Patch] BaseTools: Add python3-distutils Ubuntu package checking

2019-02-25 Thread Feng, Bob C
https://bugzilla.tianocore.org/show_bug.cgi?id=1509 Add python3-distutils Ubuntu package checking. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Tests/RunTests.py | 14 ++ 1 file changed, 14 insertions(+) diff --git

Re: [edk2] [PATCH] BaseTools:PackageDocumentTools import lib error occurs.

2019-02-25 Thread Feng, Bob C
Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Friday, February 22, 2019 2:14 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Feng, Bob C Subject: [edk2][PATCH] BaseTools:PackageDocumentTools import lib error occurs. Steps: 1. Download edk2 tree 2. Build

Re: [edk2] [PATCH] ShellPkg: Correct a parameter's name

2019-02-25 Thread Zhang, Shenglei
Hi Jaben, Do you have any opinion on "fs-path" rename to "file-full-path-name"? Thanks, Shenglei From: krishnaLee [mailto:sssky...@163.com] Sent: Thursday, February 21, 2019 10:00 AM To: Zhang, Shenglei Cc: edk2-devel@lists.01.org Subject: Re:[edk2] [PATCH] ShellPkg: Correct a parameter's name

[edk2] Hang when calling ExitBootServices on IA32 firmware v1.0 on MinnowBoard Turbot

2019-02-25 Thread Rebecca Cran via edk2-devel
I've been trying to test a boot loader on my MinnowBoard Turbot board. It's running the latest 1.0 firmware from firmware.intel.com, and I'm seeing a hang at the point when gBS->ExitBootServices is called. The last debug output is: ConfigSccBootableDevicesAtExitBootService() End

Re: [edk2] [PATCH] Fix links in Maintainers.txt and remove slow, outdated sourceforge git mirror

2019-02-25 Thread Gao, Liming
Yes. This is a bug fix. I agree to push it for Q1 release. >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Laszlo Ersek >Sent: Tuesday, February 26, 2019 3:36 AM >To: Gao, Liming ; Rebecca Cran >; edk2-devel@lists.01.org >Cc: Kinney, Michael D

[edk2] [PATCH 1/1] EmbeddedPkg: Fix multiple Virtual RTC issues

2019-02-25 Thread Pete Batard
LibGetTime(): - Two variables were used for the epoch, where only one should have been. - Also harmonize variable name to match the one used in LibSetTime. LiBSetTime(): - Address possible underflows if time is set to start of epoch. - Ensure that time being read does actually match time that was

Re: [edk2] [PATCH] Convert PosixLike scripts to sh, reduce duplication and fix some bugs

2019-02-25 Thread Feng, Bob C
Hi Rebecca, I like the change of moving duplicated code into common files and the bug fix looks good. I tested this patch on our CI system, it break the build on MacOS. There is no realpath command on MacOs shell. For the patch itself, it need to pass the check of

[edk2] [PATCH v2 2/2] MdeModulePkg/RamDiskDxe: Ramdisk size be multiple of BlkSize (CVE FIX)

2019-02-25 Thread Hao Wu
Fix CVE-2018-12180 https://bugzilla.tianocore.org/show_bug.cgi?id=1134 Originally, the block size of created Ram disks is hard-coded to 512 bytes. However, if the total size of the Ram disk is not a multiple of 512 bytes, there will be potential memory access issues when dealing with the last

Re: [edk2] [PATCH] Convert PosixLike scripts to sh, reduce duplication and fix some bugs

2019-02-25 Thread Rebecca Cran via edk2-devel
Thanks for the review. I have a macOS system, so I'll verify future changes work there too. The problem I'm trying to solve is to make it easier to get started building EDK2 under FreeBSD. Currently it needs symlinks in BaseTools/Bin/FreeBSD-amd64 for gcc, ld, make, objcopy and python, and

[edk2] [PATCH] BaseTools:The BOM character is processed when python reads a file

2019-02-25 Thread Fan, ZhijuX
When python3 reads an XML file it will parse the file in error if the file has a BOM Cc: Bob Feng Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhiju.Fan --- BaseTools/Source/Python/Ecc/Xml/XmlRoutines.py | 3 ++- 1 file changed, 2 insertions(+), 1

[edk2] [PATCH v1 1/2] MdeModulePkg/PartitionDxe: Ensure blocksize can hold MBR (CVE FIX)

2019-02-25 Thread Hao Wu
Fix CVE-2018-12180 https://bugzilla.tianocore.org/show_bug.cgi?id=1134 The commit adds checks for detecting GPT and MBR partitions. These checks will ensure that the device block size is big enough to hold an MBR (512 bytes). Cc: Jian J Wang Cc: Ruiyu Ni Cc: Star Zeng Contributed-under:

[edk2] [PATCH v1 2/2] MdeModulePkg/RamDiskDxe: Ramdisk size be multiple of BlkSize (CVE FIX)

2019-02-25 Thread Hao Wu
Fix CVE-2018-12180 https://bugzilla.tianocore.org/show_bug.cgi?id=1134 Originally, the block size of created Ram disks is hard-coded to 512 bytes. However, if the total size of the Ram disk is not a multiple of 512 bytes, there will be potential memory access issues when dealing with the last

[edk2] [PATCH v1 0/2] MdeModulePkg: Resolve buffer cross boundary access in Ramdisk

2019-02-25 Thread Hao Wu
The series will resolve a buffer cross boundary access issue during the use of RAM disks. It is the mitigation for issue CVE-2018-12180. Cc: Jian J Wang Cc: Ruiyu Ni Cc: Star Zeng Hao Wu (2): MdeModulePkg/PartitionDxe: Ensure blocksize can hold MBR (CVE FIX) MdeModulePkg/RamDiskDxe:

[edk2] [PATCH v2 0/2] MdeModulePkg: Resolve buffer cross boundary access in Ramdisk

2019-02-25 Thread Hao Wu
V2 changes: Correct CC list information. V1 history: The series will resolve a buffer cross boundary access issue during the use of RAM disks. It is the mitigation for issue CVE-2018-12180. Cc: Jian J Wang Cc: Ray Ni Cc: Star Zeng Hao Wu (2): MdeModulePkg/PartitionDxe: Ensure blocksize

[edk2] [PATCH v2 1/2] MdeModulePkg/PartitionDxe: Ensure blocksize can hold MBR (CVE FIX)

2019-02-25 Thread Hao Wu
Fix CVE-2018-12180 https://bugzilla.tianocore.org/show_bug.cgi?id=1134 The commit adds checks for detecting GPT and MBR partitions. These checks will ensure that the device block size is big enough to hold an MBR (512 bytes). Cc: Jian J Wang Cc: Ray Ni Cc: Star Zeng Contributed-under:

Re: [edk2] [PATCH 1/1] EmbeddedPkg: Fix multiple Virtual RTC issues

2019-02-25 Thread Ard Biesheuvel
On Tue, 26 Feb 2019 at 00:52, Pete Batard wrote: > > LibGetTime(): > - Two variables were used for the epoch, where only one should have been. > - Also harmonize variable name to match the one used in LibSetTime. > LiBSetTime(): > - Address possible underflows if time is set to start of epoch. >

Re: [edk2] [edk2-announce] Soft Feature Freeze starts today for edk2-stable201903

2019-02-25 Thread Gao, Liming
Hi, all Two features (Add SMM CET support and Add WiFi Connection Manager) get Acked-By or Reviewed-by near the soft feature freeze date. CET is X86 specific feature. WiFi connection manager is the standalone feature. Their impact should be small. So, I suggest to include them in this stable

Re: [edk2] [PATCH v1 1/1] ArmPkg: Fix writes to GICv3 GICD_IROUTER reg

2019-02-25 Thread Ard Biesheuvel
On Fri, 22 Feb 2019 at 20:43, Sami Mujawar wrote: > > According to ARM Generic Interrupt Controller Architecture > Specification, GIC architecture version 3.0 and version 4.0, > GICD_IROUTER is a 64-bit register. > > Fixed code to use 64 bit MMIO write operations so that the > Aff3 value (bits

Re: [edk2] [PATCH] Fix links in Maintainers.txt and remove slow, outdated sourceforge git mirror

2019-02-25 Thread Laszlo Ersek
On 02/23/19 06:18, Rebecca Cran via edk2-devel wrote: > --- > Maintainers.txt | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/Maintainers.txt b/Maintainers.txt > index 7f1061d6c1..d9d3d840c5 100644 > --- a/Maintainers.txt > +++ b/Maintainers.txt > @@ -31,11 +31,10

Re: [edk2] [PATCH] StdLib: Update resolv.conf to use Google's DNS servers.

2019-02-25 Thread Laszlo Ersek
On 02/23/19 04:41, Rebecca Cran via edk2-devel wrote: > Sorry, I've fixed the subject line and added maintainers to the Cc list. > > This patch also changes the domain from intel.com to example.com, to be > more applicable to consumers outside Intel. > > > -- > > Rebecca Cran > > > On

Re: [edk2] [PATCH v3 1/5] MdeModulePkg/UefiBootManagerLib: fix LoadImage/StartImage status code rep.

2019-02-25 Thread Laszlo Ersek
On 02/25/19 09:27, Ni, Ray wrote: > On 2/23/2019 1:16 AM, Laszlo Ersek wrote: >> Yes, I was fully aware of that. >> >> However: >> >> The issue is that, in the BmReportLoadFailure() function, we do some >> work*before*  we call REPORT_STATUS_CODE_EX(). We have an ASSERT(), a >> ZeroMem(), and a

[edk2] [PATCH 1/2] Vlv2TbltDevicePkg: ECP Cleanup.

2019-02-25 Thread Zailiang Sun
From: zwei4 Remove modules of EdkCompatibilityPkg from DSC/FDF of Vlv2TbltDevicePkg to make this platform ECP free. Test: Boot to 64-bit Windows 10. Cc: Zailiang Sun Cc: Yi Qian Cc: Michael Kinney Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: David Wei ---

Re: [edk2] [edk2-announce] Soft Feature Freeze starts today for edk2-stable201903

2019-02-25 Thread Laszlo Ersek
On 02/23/19 15:46, Gao, Liming wrote: > Lazlo: > I agree. I don't think there is the rule break for the patch set of boot > progress reporting. I also prefer to push them early next week. Thank you, I just pushed the series. https://lists.01.org/pipermail/edk2-devel/2019-February/037212.html

[edk2] [PATCH 2/2] Vlv2TbltDevicePkg: Fix build failure issue after ECP cleanup

2019-02-25 Thread Zailiang Sun
Moved stuff in the three old packages IA32FamilyCpuPkg, Vlv2BinaryPkg and Vlv2MiscBinariesPkg into a new package Vlv2SocBinPkg. Updated the build scripts and added build instructions in Readme.md. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: David Wei Cc: Zailiang Sun

Re: [edk2] [PATCH v3 0/5] MdeModulePkg, OvmfPkg, ArmVirtPkg: more visible boot progress reporting

2019-02-25 Thread Laszlo Ersek
On 02/21/19 11:41, Laszlo Ersek wrote: > Repo: https://github.com/lersek/edk2.git > Branch: boot_diags_v3 > > Addressing feedback for v2, which was posted at: > > https://lists.01.org/pipermail/edk2-devel/2019-February/036965.html >

[edk2] [Patch 1/2] BaseTools: Eot failed when enable python3

2019-02-25 Thread Feng, Bob C
The Eot will report error when python3 enabled. We replaced sdict with collections.OrderedDict in python3 patch set, but the sdict implement "append" method which is not implemented in collections.OrderedDict. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc:

[edk2] [Patch 2/2] BaseTools: Fix a Eot issue.

2019-02-25 Thread Feng, Bob C
FirmwareVolume.UnDispatchedFfsDict is mutated during iteration, convert the FirmwareVolume.UnDispatchedFfsDict.keys() to a new list to resolve this problem. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao ---

Re: [edk2] [PATCH] MdeModulePkg/VariableSmmRuntimeDxe: Refactor locating Variable Arch Protocol

2019-02-25 Thread Jagadeesh Ujja
Hi Ard/Star On Thu, Feb 21, 2019 at 3:15 PM Ard Biesheuvel wrote: > > On Thu, 21 Feb 2019 at 10:33, Zeng, Star wrote: > > > > On 2019/2/21 17:11, Ard Biesheuvel wrote: > > > On Thu, 21 Feb 2019 at 10:04, Laszlo Ersek wrote: > > >> > > >> On 02/20/19 13:23, Ard Biesheuvel wrote: > > >>> On Wed,

Re: [edk2] [PATCH v3 1/5] MdeModulePkg/UefiBootManagerLib: fix LoadImage/StartImage status code rep.

2019-02-25 Thread Ni, Ray
On 2/23/2019 1:16 AM, Laszlo Ersek wrote: Yes, I was fully aware of that. However: The issue is that, in the BmReportLoadFailure() function, we do some work*before* we call REPORT_STATUS_CODE_EX(). We have an ASSERT(), a ZeroMem(), and a field assignment. If status code reporting is disabled

[edk2] [MdeModulePkg/Library v1 0/1] Fix exception issue while UsbMass block io uninstalled

2019-02-25 Thread Ming Huang
Another exception issue while UsbMass block io uninstalled when boot to grub: The system environment: virtual-CDROM(USB interface) via BMC, insert a iso file to virtual-CDROM, like ubuntu-18.04.1-server-arm64.iso, change virtaul-CDROM to first boot option. Disconnecting virtual-CDROM when boot to

[edk2] [MdeModulePkg/Library v1 1/1] MdeModulePkg/UefiBootManangerLib: Fix exception issue

2019-02-25 Thread Ming Huang
The system environment: virtual-CDROM(USB interface) via BMC, insert a iso file to CDROM, like ubuntu-18.04.1-server-arm64.iso, change CDROM to first boot option. With release version bios, disconnecting CDROM when boot to "1 seconds left, Press Esc or F2 to enter Setup" then system will get a

Re: [edk2] [PATCH v1] MdeModulePkg/UfsBlockIoPei: Correct use of 'DeviceIndex' in BlkIO PPI

2019-02-25 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: edk2-devel On Behalf Of Hao Wu > Sent: Friday, February 15, 2019 10:55 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A > Subject: [edk2] [PATCH v1] MdeModulePkg/UfsBlockIoPei: Correct use of > 'DeviceIndex' in BlkIO PPI > >

Re: [edk2] [Patch 1/2] BaseTools: Eot failed when enable python3

2019-02-25 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Feng, Bob C > Sent: Monday, February 25, 2019 5:22 PM > To: edk2-devel@lists.01.org > Cc: Feng, Bob C ; Gao, Liming > Subject: [Patch 1/2] BaseTools: Eot failed when enable python3 > > The Eot will report error when python3 enabled.

Re: [edk2] [Patch 2/2] BaseTools: Fix a Eot issue.

2019-02-25 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Feng, > Bob C > Sent: Monday, February 25, 2019 5:23 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [Patch 2/2] BaseTools: Fix a Eot issue. > >

Re: [edk2] [PATCH] StdLib: Update resolv.conf to use Google's DNS servers.

2019-02-25 Thread Rebecca Cran via edk2-devel
On February 25, 2019 at 3:11:16 AM, Laszlo Ersek (ler...@redhat.com(mailto:ler...@redhat.com)) wrote: > > Can you please repost the patch with an updated subject line / commit > message? That way we can apply it with git-am without tweaking on the > maintainer side. Sure! Rebecca

Re: [edk2] [PATCH 0/2] DynamicTablesPkg Updates

2019-02-25 Thread Alexei Fedorov
Reviewed-by: Alexei Fedorov Alexei From: Sami Mujawar Sent: 25 February 2019 13:38:17 To: Ashish Singhal; edk2-devel@lists.01.org Cc: Alexei Fedorov; nd Subject: RE: [PATCH 0/2] DynamicTablesPkg Updates Reviewed-by: Sami Mujawar -Original Message-

Re: [edk2] [PATCH] Fix links in Maintainers.txt and remove slow, outdated sourceforge git mirror

2019-02-25 Thread Gao, Liming
I can't clone edk2 code from http://git.code.sf.net/p/tianocore/edk2. Seemly, it doesn't work. So, I agree to remove it. Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Monday, February 25,

Re: [edk2] [PATCH 0/2] DynamicTablesPkg Updates

2019-02-25 Thread Sami Mujawar
Reviewed-by: Sami Mujawar -Original Message- From: Ashish Singhal Sent: 21 February 2019 06:39 PM To: edk2-devel@lists.01.org Cc: Sami Mujawar ; Alexei Fedorov ; Ashish Singhal Subject: [PATCH 0/2] DynamicTablesPkg Updates DynamicTablesPkg/DynamicTableManagerDxe: Update DEPEX This

Re: [edk2] [PATCH v1 0/6] DynamicTablesPkg: Framework updates and fixes

2019-02-25 Thread Alexei Fedorov
Reviewed-by:Alexei Fedorov Alexei From: Sami Mujawar Sent: 21 February 2019 18:14 To: edk2-devel@lists.01.org Cc: Alexei Fedorov; leif.lindh...@linaro.org; Matteo Carlini; Stephanie Hughes-Fitt; nd Subject: [PATCH v1 0/6] DynamicTablesPkg: Framework updates

Re: [edk2] [PATCH] StdLib: Update resolv.conf to use Google's DNS servers.

2019-02-25 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Monday, February 25, 2019 2:11 AM > To: Rebecca Cran ; edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Daryl McDaniel li...@mc2research.org> > Subject: Re: [edk2] [PATCH] StdLib: Update