Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems

Ard, > So before these changes, we were in the exact same situation, but since PC > platforms never enable DMA above 4 GB in the first place, nobody ever > noticed until we started running this code on arm64 platforms that have no > 32-bit addressable DRAM to begin with. Interesting - I did not

Re: [edk2] [PATCH v2] MdePkg/Library: Install dummy variable arch protocol

On Fri, 1 Mar 2019 at 12:14, Jagadeesh Ujja wrote: > > In a system implementing the variable store in MM, there are no variable > arch protocol and variable write arch protocol installed into the > DXE_SMM protocol database. On such systems, it is not required to > locate these protocols by the

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems

On Fri, 1 Mar 2019 at 11:54, Cohen, Eugene wrote: > > Ard, > > > So before these changes, we were in the exact same situation, but since PC > > platforms never enable DMA above 4 GB in the first place, nobody ever > > noticed until we started running this code on arm64 platforms that have no > >

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems

On Fri, 1 Mar 2019 at 11:32, Ard Biesheuvel wrote: > > On Fri, 1 Mar 2019 at 01:19, Ashish Singhal wrote: > > > > Eugene, > > > > Small question. Did the issue appear after the V4 patch went in? Looking at > > the code before that patch, we were enabling 64b dma in pci based on > > capability

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems

Ashish, Yes this issue existed before V4 support came in. The previous code would test the (V3) SysBus64 bit: https://github.com/tianocore/edk2/blob/7f3b0bad4bbb3cb24014d2e6216615896ea09dbf/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c#L652 And then return an error building the ADMA

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems

On Fri, 1 Mar 2019 at 01:19, Ashish Singhal wrote: > > Eugene, > > Small question. Did the issue appear after the V4 patch went in? Looking at > the code before that patch, we were enabling 64b dma in pci based on > capability register already despite of driver supporting only 32b dma. > I

[edk2] [PATCH v2] MdePkg/Library: Install dummy variable arch protocol

In a system implementing the variable store in MM, there are no variable arch protocol and variable write arch protocol installed into the DXE_SMM protocol database. On such systems, it is not required to locate these protocols by the DXE runtime variable drivers because it can be assumed that

[edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Add V3 64b DMA Support

Driver was supporting only 32b DMA support for V3 controllers. Add support for 64b DMA as well for completeness. For V4.0 64b support, driver was looking at incorrect capability register bit. Fix for that is present as well. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

Re: [edk2] [PATCH V2] BaseTools:Run packagedoc_cli.py to generate doc failed

Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Fan, ZhijuX > Sent: Thursday, February 28, 2019 6:52 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [PATCH V2] BaseTools:Run packagedoc_cli.py

Re: [edk2] [RFC 0/3] Enable runtime serial debug for ArmVirtQemu

On 03/01/19 16:09, Peter Maydell wrote: > On Fri, 1 Mar 2019 at 14:59, Laszlo Ersek wrote: >> >> +Peter >> >> On 03/01/19 13:24, Heyi Guo wrote: >>> On 2019/2/28 21:39, Laszlo Ersek wrote: >> (4) What's most worrying is that this change would lead to an unexpected sharing of the PL011

Re: [edk2] [edk2-announce] March Community Meeting

Hi Stephano Could you please add at the https://www.tianocore.org/monthly-meeting page the South America TZ (São Paulo if possible ) , in case these calendar items are still being used? Thanks and Regards Rafael Em qui, 28 de fev de 2019 às 17:08, stephano < stephano.cet...@linux.intel.com>

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems

Eugene, I have submitted a patch for supporting 64b DMA on V3 controllers. Can you please validate it at your end as well? Thanks Ashish From: Ashish Singhal Sent: Friday, March 1, 2019 5:31 AM To: Ard Biesheuvel ; Cohen, Eugene Cc: Wu, Hao A ; edk2-devel@lists.01.org; Kim, Sangwoo (김상우

[edk2] [edk2-announce] Hard Feature Freeze starts from 2019-03-01(00:00:00 UTC-8) for edk2-stable201903

Hi, all Today, we enter into Hard Feature Freeze phase until edk2-stable201903 tag is created at 2019-03-08. In this phase, there is no feature to be pushed. The bug fix is still allowed. Thanks Liming >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On

Re: [edk2] [PATCH v2] MdePkg/Library: Install dummy variable arch protocol

Agree with Ard's feedbacks. And it seems only needed for VariableSmmRuntimeDxe to co-work with VariableStandaloneMm. So is it more suitable to be in StandaloneMmPkg? Thanks, Star -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Friday, March 1, 2019

Re: [edk2] [RFC 0/3] Enable runtime serial debug for ArmVirtQemu

On 2019/2/28 21:39, Laszlo Ersek wrote: Hello Heyi, On 02/28/19 09:05, Heyi Guo wrote: Serial port output is useful when debugging UEFI runtime services in OS runtime. The patches are trying to provide a handy method to enable runtime serial port debug for ArmVirtQemu. Cc: Jian J Wang Cc:

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems

I've already started refactoring the driver to support V3 64b ADMA2. Meanwhile, I'm OK with the proposed patch. Thanks Ashish Get Outlook for iOS From: Ard Biesheuvel Sent: Friday, March 1, 2019 4:40 AM To: Cohen, Eugene Cc: Ashish

Re: [edk2] [RFC 0/3] Enable runtime serial debug for ArmVirtQemu

On Fri, 1 Mar 2019 at 15:59, Laszlo Ersek wrote: > > +Peter > > On 03/01/19 13:24, Heyi Guo wrote: > > On 2019/2/28 21:39, Laszlo Ersek wrote: > > >> (4) What's most worrying is that this change would lead to an unexpected > >> sharing of the PL011 device between the OS and the firmware. I don't

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems

Acked-by: Ashish Singhal -Original Message- From: Ard Biesheuvel Sent: Friday, March 1, 2019 4:39 AM To: Cohen, Eugene Cc: Ashish Singhal ; Wu, Hao A ; edk2-devel@lists.01.org; Kim, Sangwoo (김상우 SW1Lab.) Subject: Re: [PATCH] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit

Re: [edk2] [RFC 0/3] Enable runtime serial debug for ArmVirtQemu

+Peter, for the last few paragraphs On 02/28/19 13:10, Ard Biesheuvel wrote: > On Thu, 28 Feb 2019 at 09:06, Heyi Guo wrote: >> >> Serial port output is useful when debugging UEFI runtime services in OS >> runtime. >> The patches are trying to provide a handy method to enable runtime serial >>

Re: [edk2] [Patch v2 0/4] Simplify CPU Features solution.

Hi Eric, On 03/01/19 06:39, Eric Dong wrote: > V2 Changes include: > 1. Add ASSERT to make sure PcdCpuFeaturesSetting and >PcdCpuFeaturesCapability have equal size. > 2. Correct comment block on IsCpuFeatureSetInCpuPcd() references >"PcdCpuFeaturesSupport". It should reference

Re: [edk2] [Patch v2 4/4] UefiCpuPkg/RegisterCpuFeaturesLib: Correct comments.

On 03/01/19 06:39, Eric Dong wrote: > Cc: Ray Ni > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Eric Dong > --- > UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >

Re: [edk2] [PATCH 2] UefiCpuPkg: restore strict page attributes via #DB in nonstop mode only

On 03/01/19 04:26, Wang, Jian J wrote: > Thanks. To catch cold freeze, pushed earlier > (2a9324cfca12c66f13a41d52fb0a82fb924e) This is definitely a bugfix, so it is eligible for pushing. Thanks Laszlo >> -Original Message- >> From: Dong, Eric >> Sent: Friday, March 01, 2019 9:55 AM

Re: [edk2] [RFC 0/3] Enable runtime serial debug for ArmVirtQemu

+Peter On 03/01/19 13:24, Heyi Guo wrote: > On 2019/2/28 21:39, Laszlo Ersek wrote: >> (4) What's most worrying is that this change would lead to an unexpected >> sharing of the PL011 device between the OS and the firmware. I don't >> think that's a great idea, especially if QEMU's ACPI payload

Re: [edk2] [edk2-announce] Soft Feature Freeze starts today for edk2-stable201903

On 03/01/19 02:15, Gao, Liming wrote: > OK. To be clear, I take your suggestion. wiki page has been updated. Looks great, thank you! Laszlo > >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Thursday, February 28, 2019 7:58 PM >> To: Gao, Liming >> Cc: