Re: [edk2] [PATCH v3] StandaloneMmPkg/Library: Install Variable Arch Protocol

2019-03-04 Thread Ard Biesheuvel
(add StandaloneMmPkg maintainers) On Mon, 4 Mar 2019 at 09:54, Jagadeesh Ujja wrote: > > In a system implementing the variable store in MM, there are no variable > arch protocol and variable write arch protocol installed into the > DXE_SMM protocol database. On such systems, it is not required

[edk2] [PATCH edk2-platforms 3/3] Platform/ARM/SgiPkg: add MM based UEFI secure boot support

2019-03-04 Thread Jagadeesh Ujja
This implements support for UEFI secure boot on SGI platforms using the standalone MM framework. This moves all of the software handling of the UEFI authenticated variable store into the standalone MM context residing in a secure partition. Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [PATCH edk2-platforms 2/3] Platform/ARM/Sgi: allow MM_STANDALONE modules to use NorFlashPlatformLib

2019-03-04 Thread Jagadeesh Ujja
“NorFlashPlatformLib” library can be used by MM_STANDALONE drivers as well. When used in MM mode, the third instance of the NOR flash is used as the non-volatile storage. This NOR flash instance is partitioned into two regions - first 4MB space is used for secure boot and next 3MB for secure

[edk2] [PATCH edk2-platforms 0/3] Platform/ARM/SgiPkg: Implement StandaloneMm based secure boot

2019-03-04 Thread Jagadeesh Ujja
Integrating various pieces together so that the authenticated variable store runs entirely in standalone MM context residing in a secure partition. This primarily involves adding all required library and drivers to platform specific .DSC and .FDF files. This creates separate Nor flash region which

[edk2] [PATCH edk2-platforms 1/3] Platform/ARM/Sgi: define nor2 flash controller memory map

2019-03-04 Thread Jagadeesh Ujja
Add the definitions of NOR2 flash controller memory map. The NO2 flash can be used as an additional non-volatile storage by non-secure code or used as a non-volatile storage for secure variables by the StandaloneMM. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jagadeesh

[edk2] [PATCH v3] StandaloneMmPkg/Library: Install Variable Arch Protocol

2019-03-04 Thread Jagadeesh Ujja
In a system implementing the variable store in MM, there are no variable arch protocol and variable write arch protocol installed into the DXE_SMM protocol database. On such systems, it is not required to locate these protocols by the DXE runtime variable drivers because it can be assumed that

[edk2] [Patch] Document: Update Inf spec to remove EDK related contents

2019-03-04 Thread Feng, Bob C
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1453 Remove EDK related contents Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao Cc: Jaben Carsey --- 1_introduction/11_overview.md | 2 +- 2_inf_overview/210_[ppis]_section.md

Re: [edk2] [RFC 0/3] Enable runtime serial debug for ArmVirtQemu

2019-03-04 Thread Heyi Guo
On 2019/3/1 23:27, Laszlo Ersek wrote: +Peter, for the last few paragraphs On 02/28/19 13:10, Ard Biesheuvel wrote: On Thu, 28 Feb 2019 at 09:06, Heyi Guo wrote: Serial port output is useful when debugging UEFI runtime services in OS runtime. The patches are trying to provide a handy

[edk2] [Patch] Document: Update FDF spec to remove EDK related contents

2019-03-04 Thread Feng, Bob C
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1453 Remove EDK related contents inf Fdf spec. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao Cc: Jaben Carsey --- 1_introduction/11_overview.md | 22 +-

[edk2] [PATCH 2/3] OvmfPkg/XenSupport: use a correct PCI host bridge aperture for BAR64

2019-03-04 Thread Igor Druzhinin
In case BAR64 is placed below 4G choose the correct aperture. This fixes a failed assertion down the code path. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Igor Druzhinin --- OvmfPkg/Library/PciHostBridgeLib/XenSupport.c | 6 +- 1 file changed, 5 insertions(+), 1

[edk2] [Patch] Document: Update DEC spec to remove EDK related contents

2019-03-04 Thread Feng, Bob C
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1453 Remove EDK related contents from DEC spec. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao Cc: Jaben Carsey --- 2_dec_file_overview/210_pcd_usage.md | 4 +---

[edk2] [PATCH 3/3] OvmfPkg/XenSupport: turn off address decoding before BAR sizing

2019-03-04 Thread Igor Druzhinin
On Xen, hvmloader firmware leaves address decoding enabled for enumerated PCI device before jumping into OVMF. OVMF seems to expect it to be disabled and tries to size PCI BARs in several places without disabling it which causes BAR64, for example, being incorrectly placed by QEMU. Fix it by

Re: [edk2] [PATCH edk2-platforms 3/3] Platform/ARM/SgiPkg: add MM based UEFI secure boot support

2019-03-04 Thread Ard Biesheuvel
On Mon, 4 Mar 2019 at 11:12, Jagadeesh Ujja wrote: > > This implements support for UEFI secure boot on SGI platforms using > the standalone MM framework. This moves all of the software handling > of the UEFI authenticated variable store into the standalone MM > context residing in a secure

Re: [edk2] [PATCH edk2-platforms 2/3] Platform/ARM/Sgi: allow MM_STANDALONE modules to use NorFlashPlatformLib

2019-03-04 Thread Ard Biesheuvel
On Mon, 4 Mar 2019 at 11:12, Jagadeesh Ujja wrote: > > “NorFlashPlatformLib” library can be used by MM_STANDALONE drivers as > well. When used in MM mode, the third instance of the NOR flash is used as > the non-volatile storage. This NOR flash instance is partitioned into > two regions - first

Re: [edk2] [PATCH edk2-platforms 1/3] Platform/ARM/Sgi: define nor2 flash controller memory map

2019-03-04 Thread Ard Biesheuvel
On Mon, 4 Mar 2019 at 11:12, Jagadeesh Ujja wrote: > > Add the definitions of NOR2 flash controller memory map. The NO2 flash > can be used as an additional non-volatile storage by non-secure code or > used as a non-volatile storage for secure variables by the StandaloneMM. > > Contributed-under:

[edk2] [PATCH 0/3] Xen PCI passthrough fixes

2019-03-04 Thread Igor Druzhinin
Igor Druzhinin (3): OvmfPkg/XenSupport: remove usage of prefetchable PCI host bridge aperture OvmfPkg/XenSupport: use a correct PCI host bridge aperture for BAR64 OvmfPkg/XenSupport: turn off address decoding before BAR sizing OvmfPkg/Library/PciHostBridgeLib/XenSupport.c | 44

[edk2] [PATCH 1/3] OvmfPkg/XenSupport: remove usage of prefetchable PCI host bridge aperture

2019-03-04 Thread Igor Druzhinin
This aperture doesn't exist in OVMF and trying to use it causes failing assertions later in cases there are prefetchable and non-prefetchable BARs following each other. This configuration is quite likely with some PCI passthrough devices. Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [PATCH edk2-platforms 0/2] Platforms/ARM/SgiPkg: apply product names for sgiclarka and sgiclarkh platforms

2019-03-04 Thread Jagadeesh Ujja
This patchset updates the product names for SGI-Clark.Ares and SGI-Clark.Helios platforms. The first patch replaces all uses of sgiclarka with rdn1edge. The second patch replaces all use of sgiclarkh with rde1edge. Jagadeesh Ujja (2): Platforms/ARM/SgiPkg: Rename SgiClarkAres to RdN1Edge

[edk2] [PATCH edk2-platforms 2/2] Platforms/ARM/SgiPkg: Rename SgiClarkHelios to RdE1Edge

2019-03-04 Thread Jagadeesh Ujja
Replace all usage of 'SgiClark' with 'RdN1E1Edge' and 'SgiClarkHelios with 'RdE1Edge' as per the updated product names. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jagadeesh Ujja --- Platform/ARM/SgiPkg/AcpiTables/{SgiClarkHelios => RdE1Edge}/Dsdt.asl

Re: [edk2] [PATCH V2] BaseTools:Run packagedoc_cli.py to generate doc failed

2019-03-04 Thread Feng, Bob C
Hi, This patch is to fix the a regression issue introduced by python3 patch set. I'd like to push this patch for Q1 stable tag. Would you approve it? Thanks, Bob -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Feng, Bob C Sent: Monday, March

[edk2] [Patch] UefiCpuPkg/MpInitLib: Direct allocate buffer for Wake up Buffer.

2019-03-04 Thread Eric Dong
https://bugzilla.tianocore.org/show_bug.cgi?id=1538 Current CpuDxe driver "borrows" Wakeup Buffer (through Allocate & free to get the buffer pointer, backup the buffer data before using it and restore it after using). Now this logic met a problem described in the above BZ because the test tool

[edk2] [Patch] MdeModulePkg/PiSmmCore: Control S3 related functionality with flag.

2019-03-04 Thread Eric Dong
https://bugzilla.tianocore.org/show_bug.cgi?id=1590 Use PcdAcpiS3Enable to control whether need to enable S3 related functionality in Pi SMM Core. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong --- MdeModulePkg/Core/PiSmmCore/PiSmmCore.c | 70

[edk2] [PATCH] ShellPkg: Correct a parameter's name

2019-03-04 Thread Shenglei Zhang
The parameter FilePath of ShellOpenFileByName defined in ShellLib.h is incorrect. It should be FileName. https://bugzilla.tianocore.org/show_bug.cgi?id=1221 Cc: Jaben Carsey Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang ---

Re: [edk2] [PATCH V2] BaseTools:Run packagedoc_cli.py to generate doc failed

2019-03-04 Thread Gao, Liming
This is a bug. I agree to fix it for Q1 stable tag. > -Original Message- > From: Feng, Bob C > Sent: Monday, March 4, 2019 5:02 PM > To: Gao, Liming ; Fan, ZhijuX ; > edk2-devel@lists.01.org > Cc: Feng, Bob C > Subject: RE: [edk2] [PATCH V2] BaseTools:Run packagedoc_cli.py to generate

[edk2] [Patch] Document: Update DSC spec to remove EDK related contents

2019-03-04 Thread Feng, Bob C
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1453 Remove EDK related contents inf Dsc spec. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao Cc: Jaben Carsey --- 1_introduction/11_overview.md | 14 +-- ...=>

Re: [edk2] [PATCH v2 0/1] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems

2019-03-04 Thread Wu, Hao A
> -Original Message- > From: Wu, Hao A > Sent: Tuesday, March 05, 2019 9:14 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A; Eugene Cohen; Ard Biesheuvel; Ashish Singhal > Subject: [PATCH v2 0/1] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC > v3 64-bit systems Since Ashish already posted

[edk2] [PATCH v2 1/1] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems

2019-03-04 Thread Hao Wu
From: "Cohen, Eugene" REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1583 The SdMmcPciHcDriverBindingStart function was checking two different capability bits in determining whether 64-bit DMA modes were supported, one mode is defined in the SDHC version 3 specification (using 96-bit

[edk2] [PATCH v2 0/1] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems

2019-03-04 Thread Hao Wu
V2 changes: On behalf of Eugene, V2 patch does not have functional changes compared with V1, only the reference Bugzilla tracker link is added in the commit log message. I added the previous 'Ack' tag from Ard and Ashish, I added my 'Reviewed-by' as well. Cc: Eugene Cohen Cc: Ard Biesheuvel

[edk2] [PATCH 1/3] MdePkg/BaseCpuLib: Remove inline X86 assembly code

2019-03-04 Thread Shenglei Zhang
MdePkg BaseCpuLib still uses the inline X86 assembly code in C code files.It should be updated to consume nasm only. https://bugzilla.tianocore.org/show_bug.cgi?id=1163 Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang ---

[edk2] [PATCH 2/3] MdePkg/BaseLib: Remove inline X86 assembly code

2019-03-04 Thread Shenglei Zhang
MdePkg BaseLib still uses the inline X86 assembly code in C code files.It should be updated to consume nasm only. https://bugzilla.tianocore.org/show_bug.cgi?id=1163 Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang ---

[edk2] [PATCH 3/3] MdePkg/BaseSynchronizationLib: Remove inline X86 assembly code

2019-03-04 Thread Shenglei Zhang
MdePkg BaseSynchronizationLib still uses the inline X86 assembly code in C code files.It should be updated to consume nasm only. https://bugzilla.tianocore.org/show_bug.cgi?id=1163 Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [PATCH 0/3] MdePkg: Remove inline X86 assembly code

2019-03-04 Thread Shenglei Zhang
MdePkg BaseLib, BaseCpuLib and BaseSynchronizationLib still use the inline X86 assembly code in C code files. They should be updated to consume nasm only. https://bugzilla.tianocore.org/show_bug.cgi?id=1163 Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement

[edk2] [PATCH] UefiCpuPkg/Microcode.c: Add verification before calculate CheckSum32

2019-03-04 Thread Chen A Chen
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1020 Should make sure the TotalSize of Microcode is aligned with 4 bytes before calling CalculateSum32 function. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chen A Chen Cc: Ray Ni Cc: Eric Dong ---

Re: [edk2] [PATCH] EmulatorPkg/Sec: Don't install TemporaryRamSupport PPI

2019-03-04 Thread Ni, Ray
> -Original Message- > From: edk2-devel On Behalf Of Jordan > Justen > Sent: Sunday, March 3, 2019 5:45 AM > To: Ni, Ray ; edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH] EmulatorPkg/Sec: Don't install > TemporaryRamSupport PPI > > On 2019-03-02 04:11:11, Ray Ni wrote: > > > > So

[edk2] [PATCH edk2-platforms 1/2] Platforms/ARM/SgiPkg: Rename SgiClarkAres to RdN1Edge

2019-03-04 Thread Jagadeesh Ujja
Replace all usage of 'SgiClark' with 'RdN1E1Edge' and 'SgiClarkAres' with 'RdN1Edge' as per the updated product names. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jagadeesh Ujja --- Platform/ARM/SgiPkg/AcpiTables/{SgiClarkAres => RdN1Edge}/Dsdt.asl

Re: [edk2] [PATCH 0/3] MdePkg: Remove inline X86 assembly code

2019-03-04 Thread Gao, Liming
Shenglei: The request is for X86, IA32 and X64. Please don't change ARM or AARCH64. Thanks Liming > -Original Message- > From: Zhang, Shenglei > Sent: Monday, March 4, 2019 5:41 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Gao, Liming > > Subject: [PATCH 0/3] MdePkg:

[edk2] [Patch] Document: Update Build spec to remove EDK related contents

2019-03-04 Thread Feng, Bob C
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1453 Remove EDK related contents from Build spec. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao Cc: Jaben Carsey --- .../103_build_intermediate_images.md | 3 +-

Re: [edk2] [Patch] UefiCpuPkg/MpInitLib: Direct allocate buffer for Wake up Buffer.

2019-03-04 Thread Zeng, Star
Just an idea to avoid hard code value 0x88000. Before EndOfDxe: Allocate buffer in AllocateResetVector(), and free buffer in FreeResetVector(). At EndOfDxe (it is after LegacyBiosDxe driver entry point) callback: Allocate buffer and record it to CpuMpData->WakeupBuffer, and always occupy the