[edk2] [PATCH v2 3/3] UefiCpuPkg/UefiCpuPkg.uni: Add the prompt and help information

2019-03-11 Thread Shenglei Zhang
The prompt and help information are missing in UefiPkg.uni. https://bugzilla.tianocore.org/show_bug.cgi?id=1600 Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang Reviewed-by: Eric Dong ---

Re: [edk2] [PATCH v2 1/3] MdePkg/MdePkg.uni: Add the prompt and help information

2019-03-11 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Shenglei Zhang > Sent: Tuesday, March 12, 2019 10:05 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Gao, Liming > > Subject: [edk2] [PATCH v2 1/3]

[edk2] [PATCH v2 0/3] Add the prompt and help information in .uni files

2019-03-11 Thread Shenglei Zhang
The prompt and help information are missing in MdePkg/UefiPkg/SecurityPkg.uni Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Cc: Chao Zhang Cc: Jiewen Yao Cc: Jian Wang Cc: Michael D Kinney Cc: Liming Gao Shenglei Zhang (3): MdePkg/MdePkg.uni: Add the prompt and help information

[edk2] [PATCH v2 1/3] MdePkg/MdePkg.uni: Add the prompt and help information

2019-03-11 Thread Shenglei Zhang
The prompt and help information are missing in MdePkg.uni. https://bugzilla.tianocore.org/show_bug.cgi?id=1600 v2:Fix the error message of help and prompt information. Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang ---

[edk2] [PATCH v2 2/3] SecurityPkg/SecurityPkg.uni: Add the prompt and help information

2019-03-11 Thread Shenglei Zhang
The prompt and help information are missing in SecurityPkg.uni. https://bugzilla.tianocore.org/show_bug.cgi?id=1600 Cc: Chao Zhang Cc: Jiewen Yao Cc: Jian Wang Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang --- SecurityPkg/SecurityPkg.uni | 6 ++ 1

[edk2] Legacy VBIOS and GOP driver

2019-03-11 Thread galla rao
Hi All, This query is specific to Display Panel types for LCD interface *CSM+Legacy VBIOS* LCD display panel with HDMI interface - No Display in BIOS but in Windows Display is seen *Non-CSM+GOP Driver* Both Display in BIOS and in Windows shows up EDID which is complaint for 1.3 is enabled,

[edk2] [patch 2/2] Vlv2TbltDevicePkg: Remove duplicated BSD license

2019-03-11 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1612 Cc: Zailiang Sun Cc: Yi Qian Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi --- Vlv2TbltDevicePkg/Library/I2CLib/I2CLibNull.inf | 10 +- 1 file changed, 1

[edk2] [patch 1/2] SecurityPkg: Remove duplicated BSD license

2019-03-11 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1612 Cc: Chao Zhang Cc: Jian Wang Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi --- .../Ppi/FirmwareVolumeInfoPrehashedFV.h | 26 --- 1 file

[edk2] [patch 0/2] Remove duplicated BSD license

2019-03-11 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1612 Cc: Michael D Kinney Cc: Liming Gao Dandan Bi (2): SecurityPkg: Remove the duplicated BSD license Vlv2TbltDevicePkg: Remove the duplicated BSD license .../Ppi/FirmwareVolumeInfoPrehashedFV.h | 26 ---

Re: [edk2] [patch 2/2] Vlv2TbltDevicePkg: Remove duplicated BSD license

2019-03-11 Thread Sun, Zailiang
Reviewed-by: Zailiang Sun > -Original Message- > From: Bi, Dandan > Sent: Monday, March 11, 2019 2:23 PM > To: edk2-devel@lists.01.org > Cc: Sun, Zailiang ; Qian, Yi ; > Kinney, Michael D ; Gao, Liming > > Subject: [patch 2/2] Vlv2TbltDevicePkg: Remove duplicated BSD license > > REF:

[edk2] [edk2-test][Patch 1/1] uefi-sct:SctPkg:Fix underflow in EraseBlocks test

2019-03-11 Thread Eric Jin
The test case does not handle properly when the 'EraseLengthGranularity' field of an Erase Block Protocol instance is 1(SD device). The Size parameter will underflow and become a very large value, cause to exceed the last LBA. The fix considers this case. Cc: Supreeth Venkatesh

Re: [edk2] [PATCH 00/10] StandaloneMmPkg, ArmPkg: cleanups and improvements

2019-03-11 Thread Ard Biesheuvel
On Mon, 11 Mar 2019 at 12:54, Ard Biesheuvel wrote: > > On Tue, 5 Mar 2019 at 14:32, Ard Biesheuvel wrote: > > > > This series is a further cleanup of the StandaloneMmPkg infrastructure > > used to implement UEFI secure boot on ARM systems. > > > > The first 5 patches are simple cleanups. > > >

Re: [edk2] [PATCH edk2-platforms 1/2] Platform/ARM/SgiPkg: align with upstream StandaloneMmPkg changes

2019-03-11 Thread Thomas Abraham
On Fri, Mar 8, 2019 at 9:01 PM Ard Biesheuvel wrote: > > Bring SgiPkg in line with EDK2 core changes to StandaloneMmPkg: > - add a resolution for ExtractGuidedSectionLib > - remove reference to gStandaloneMmPkgTokenSpaceGuid.PcdStandaloneMmEnable > - update the resolution of

Re: [edk2] [PATCH edk2-platforms 1/2] Platform/ARM/SgiPkg: align with upstream StandaloneMmPkg changes

2019-03-11 Thread Ard Biesheuvel
On Mon, 11 Mar 2019 at 14:31, Thomas Abraham wrote: > > On Fri, Mar 8, 2019 at 9:01 PM Ard Biesheuvel > wrote: > > > > Bring SgiPkg in line with EDK2 core changes to StandaloneMmPkg: > > - add a resolution for ExtractGuidedSectionLib > > - remove reference to

Re: [edk2] [PATCH edk2-platforms 1/2] Platform/ARM/SgiPkg: align with upstream StandaloneMmPkg changes

2019-03-11 Thread Thomas Abraham
On Mon, Mar 11, 2019 at 7:09 PM Ard Biesheuvel wrote: > > On Mon, 11 Mar 2019 at 14:31, Thomas Abraham wrote: > > > > On Fri, Mar 8, 2019 at 9:01 PM Ard Biesheuvel > > wrote: > > > > > > Bring SgiPkg in line with EDK2 core changes to StandaloneMmPkg: > > > - add a resolution for

Re: [edk2] [PATCH v3] StandaloneMmPkg/Library: Install Variable Arch Protocol

2019-03-11 Thread Ard Biesheuvel
On Tue, 5 Mar 2019 at 17:16, Ard Biesheuvel wrote: > > On Tue, 5 Mar 2019 at 17:15, Yao, Jiewen wrote: > > > > I look at the patch. I don’t have concern. > > > > Please go ahead. > > > > Thank you Jiewen, > > I will take that as a reviewed-by and proceed with merging the patch > once the hard

Re: [edk2] [PATCH edk2-platforms 1/2] Platform/ARM/SgiPkg: align with upstream StandaloneMmPkg changes

2019-03-11 Thread Ard Biesheuvel
On Fri, 8 Mar 2019 at 16:31, Ard Biesheuvel wrote: > > Bring SgiPkg in line with EDK2 core changes to StandaloneMmPkg: > - add a resolution for ExtractGuidedSectionLib > - remove reference to gStandaloneMmPkgTokenSpaceGuid.PcdStandaloneMmEnable > - update the resolution of

Re: [edk2] [PATCH 00/10] StandaloneMmPkg, ArmPkg: cleanups and improvements

2019-03-11 Thread Ard Biesheuvel
On Tue, 5 Mar 2019 at 14:32, Ard Biesheuvel wrote: > > This series is a further cleanup of the StandaloneMmPkg infrastructure > used to implement UEFI secure boot on ARM systems. > > The first 5 patches are simple cleanups. > > Patch #6 adds support for dispatching a compressed firmware volume in

Re: [edk2] UefiCpuPkg CpuDxe GDT init question?

2019-03-11 Thread Andrew Fish via edk2-devel
> On Mar 11, 2019, at 9:04 AM, Yao, Jiewen wrote: > > Thanks Andrew. > + More CPU people in our team. > > Do you want to post your patch there for reference? :-) > > BTW: Would you please share how to trigger such case at your side? > Did you report above 4GB memory to be tested? Jiewen,

[edk2] [PATCH 3/4] StandaloneMmPkg: add implementation of MmCommunicateLib

2019-03-11 Thread Ard Biesheuvel
Add an implementation of MmCommunicateLib based on standalone MM. This version passes the virtual address of the communication buffer into the MM communicate protocol method. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel ---

[edk2] [PATCH 4/4] MdeModulePkg/VariableSmmRuntimeDxe: switch to MmCommunicateLib library

2019-03-11 Thread Ard Biesheuvel
Replace direct calls to the EFI_SMM_COMMUNICATE protocol with calls to the MmCommunicateLib library, which abstracts differences between traditional MM and standalone MM. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- MdeModulePkg/MdeModulePkg.dsc

Re: [edk2] [patch 1/2] SecurityPkg: Remove duplicated BSD license

2019-03-11 Thread Kinney, Michael D
Hi Dandan, The copyright line should be preserved and put with the other copyright line. Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] > On Behalf Of Dandan Bi > Sent: Sunday, March 10, 2019 11:23 PM > To: edk2-devel@lists.01.org > Cc: Kinney,

Re: [edk2] UefiCpuPkg CpuDxe GDT init question?

2019-03-11 Thread Yao, Jiewen
Thanks Andrew. + More CPU people in our team. Do you want to post your patch there for reference? :-) BTW: Would you please share how to trigger such case at your side? Did you report above 4GB memory to be tested? As such all drivers are loaded to above 4GB? Do you also allocate BIN to above

Re: [edk2] [PATCH edk2-platforms 1/2] Platform/ARM/SgiPkg: align with upstream StandaloneMmPkg changes

2019-03-11 Thread Ard Biesheuvel
On Mon, 11 Mar 2019 at 14:56, Thomas Abraham wrote: > > On Mon, Mar 11, 2019 at 7:09 PM Ard Biesheuvel > wrote: > > > > On Mon, 11 Mar 2019 at 14:31, Thomas Abraham wrote: > > > > > > On Fri, Mar 8, 2019 at 9:01 PM Ard Biesheuvel > > > wrote: > > > > > > > > Bring SgiPkg in line with EDK2

[edk2] [edk2-announce] March Community Meeting Minutes

2019-03-11 Thread stephano
An HTML version is available here: https://www.tianocore.org/minutes/Community-2019-03.html License Review -- The draft of the RFC is out, comments welcome. See details here: https://lists.01.org/pipermail/edk2-devel/2019-March/037500.html And V2 is here:

[edk2] [PATCH 2/4] MdeModulePkg: add implementation of MmCommunicateLib

2019-03-11 Thread Ard Biesheuvel
Add an implementation of MmCommunicateLib based on traditional SMM. This version passes the physical address of the communication buffer into the MM communicate protocol method. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel ---

[edk2] [PATCH 0/4] MdeModulePkg, StandaloneMmPkg: work around VA vs PA ambiguity

2019-03-11 Thread Ard Biesheuvel
This series proposes one possible approach to work around the issue that the traditional MM and standalone MM implement versions of the communicate protocol that are fundamentally incompatible from the point of view of the caller. In traditional MM, the MM communicate protocol takes a physical

[edk2] [PATCH 1/4] MdeModulePkg: introduce MmCommunicationLib library class

2019-03-11 Thread Ard Biesheuvel
In order to abstract away the difference between traditional and standalone MM implementations of the MM communicate protocol, which have different requirements when it comes to the way the address of the communication buffer is passed, introduce a library class that can encapsulate calls to the

Re: [edk2] UefiCpuPkg CpuDxe GDT init question?

2019-03-11 Thread Andrew Fish via edk2-devel
Jiewen, These three fixes got me past the CpuDxe driver: https://bugzilla.tianocore.org/show_bug.cgi?id=1613 Now I getting page faults loading SMM Thanks, Andrew Fish > On Mar 8, 2019, at 7:10 PM, Andrew Fish wrote: > > > >> On Mar 8, 2019, at 7:08 AM, Laszlo Ersek >

[edk2] [patch v2 2/2] Vlv2TbltDevicePkg: Remove duplicated BSD license

2019-03-11 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1612 V2 is the same with V1. Cc: Zailiang Sun Cc: Yi Qian Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi Reviewed-by: Zailiang Sun ---

[edk2] [patch v2 1/2] SecurityPkg: Remove duplicated BSD license

2019-03-11 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1612 V2: Keep Microsoft copyright, which is deleted by mistake in V1. Cc: Chao Zhang Cc: Jian Wang Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi ---

[edk2] [patch v2 0/2] Remove duplicated BSD license

2019-03-11 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1612 V2: Keep Microsoft copyright in patch 0001, which is deleted by mistake in V1. Cc: Michael D Kinney Cc: Liming Gao Dandan Bi (2): SecurityPkg: Remove duplicated BSD license Vlv2TbltDevicePkg: Remove duplicated BSD license

Re: [edk2] [edk2-announce] March Community Meeting Minutes

2019-03-11 Thread Rebecca Cran via edk2-devel
On 3/11/19 10:33 AM, stephano wrote: Stephano has taken an action item to work with the Kubernetes community to see what trade-offs and benefits they experience using GitHub. Kubernetes is one of the largest open source projects currently using GitHub for patch reviews. It is notable that a

Re: [edk2] UefiCpuPkg CpuDxe GDT init question?

2019-03-11 Thread Yao, Jiewen
Understood. Cool. Thanks for the info. If you have some clue on the SMM, please let us know. Thank you Yao Jiewen > -Original Message- > From: af...@apple.com [mailto:af...@apple.com] > Sent: Tuesday, March 12, 2019 12:30 AM > To: Yao, Jiewen > Cc: Laszlo Ersek ;

Re: [edk2] [edk2-announce] March Community Meeting Minutes

2019-03-11 Thread stephano
On 3/11/2019 1:55 PM, Rebecca Cran wrote: You can't see without following the pull request *who* committed the change.  There are almost 1000 open pull requests, which is something we probably want to try and avoid. They also seem to have _lots_ of labels. I wonder if there's a cleaner way of

Re: [edk2] [edk2-announce] March Community Meeting Minutes

2019-03-11 Thread stephano
On 3/11/2019 9:33 AM, stephano wrote: Stephano has taken an action item to work with the Kubernetes community to see what trade-offs and benefits they experience using GitHub. I realized earlier today that rust-lang also uses GitHub style pull requests:

Re: [edk2] [edk2-announce] March Community Meeting Minutes

2019-03-11 Thread Rebecca Cran via edk2-devel
On 3/11/19 4:20 PM, stephano wrote: On 3/11/2019 1:55 PM, Rebecca Cran wrote: You can't see without following the pull request *who* committed the change.  There are almost 1000 open pull requests, which is something we probably want to try and avoid. They also seem to have _lots_ of