Re: [edk2] [PATCH] BaseTools/header.makefile: revert gcc-8 "-Wno-xxx" options on OSX

2018-03-07 Thread Laszlo Ersek
On 03/07/18 21:42, Ard Biesheuvel wrote: > On 7 March 2018 at 20:28, Laszlo Ersek wrote: >> On 03/07/18 12:51, Gao, Liming wrote: >>> Reviewed-by: Liming Gao >> >> Thank you, Liming. >> >> Ard, are you OK with this patch as well? >> > > Sure > > Acked-by: Ard Biesheuvel Thank you both; commit

Re: [edk2] [PATCH] BaseTools/header.makefile: revert gcc-8 "-Wno-xxx" options on OSX

2018-03-07 Thread Ard Biesheuvel
On 7 March 2018 at 20:28, Laszlo Ersek wrote: > On 03/07/18 12:51, Gao, Liming wrote: >> Reviewed-by: Liming Gao > > Thank you, Liming. > > Ard, are you OK with this patch as well? > Sure Acked-by: Ard Biesheuvel >>> -Original Message- >>> From: Laszlo Ersek [mailto:ler...@redhat.com]

Re: [edk2] [PATCH] BaseTools/header.makefile: revert gcc-8 "-Wno-xxx" options on OSX

2018-03-07 Thread Laszlo Ersek
On 03/07/18 12:51, Gao, Liming wrote: > Reviewed-by: Liming Gao Thank you, Liming. Ard, are you OK with this patch as well? Thanks Laszlo >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Wednesday, March 7, 2018 5:33 PM >> To: edk2-devel-01 >> Cc: Gao,

Re: [edk2] [PATCH] BaseTools/header.makefile: revert gcc-8 "-Wno-xxx" options on OSX

2018-03-07 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, March 7, 2018 5:33 PM > To: edk2-devel-01 > Cc: Gao, Liming ; Zhu, Yonghong > Subject: [PATCH] BaseTools/header.makefile: revert gcc-8 "-Wno-xxx" options > on OSX > > I rece

[edk2] [PATCH] BaseTools/header.makefile: revert gcc-8 "-Wno-xxx" options on OSX

2018-03-07 Thread Laszlo Ersek
I recently added the gcc-8 specific "-Wno-stringop-truncation" and "-Wno-restrict" options to BUILD_CFLAGS, both for "Darwin" (XCODE5 / clang, OSX) and otherwise (gcc, Linux / Cygwin). I also regression-tested the change with gcc-4.8 on Linux -- gcc-4.8 does not know either of the (gcc-8 specific)