Re: [edk2] Question about SecurityPkg/DxeTcg2PhysicalPresenceLib

2018-08-14 Thread Laszlo Ersek
Hello Heyi, (+ Marc-André and Stefan) On 08/14/18 08:18, heyi@linaro.org wrote: > Hi Jiewen, > > I searched the code in EDK2, and found there is another implementation > of DxeTcg2PhysicalPresenceLib for OVMF: the function > Tcg2PhysicalPresenceLibProcessRequest() is called in >

Re: [edk2] Question about SecurityPkg/DxeTcg2PhysicalPresenceLib

2018-08-14 Thread heyi . guo
Hi Jiewen, I searched the code in EDK2, and found there is another implementation of DxeTcg2PhysicalPresenceLib for OVMF: the function Tcg2PhysicalPresenceLibProcessRequest() is called in PlatformBootManagerAfterConsole() on OVMF, and it doesn't invoke VariableLockProtocol->RequestToLock() in

Re: [edk2] Question about SecurityPkg/DxeTcg2PhysicalPresenceLib

2018-08-12 Thread Yao, Jiewen
The code in SecurityPkg\Library\DxeTcg2PhysicalPresenceLib can be treated as the example for the platform with trusted console. If a platform does not have a trusted graphic console, the platform may implement another DxeTcg2PhysicalPresenceLib instance to get user confirmation. For example,

Re: [edk2] Question about SecurityPkg/DxeTcg2PhysicalPresenceLib

2018-08-12 Thread heyi . guo
Is there any work around if we don't have such trusted console on available hardware platforms? Is there any example implementation which we can refer to? Thanks, Heyi On Fri, Aug 10, 2018 at 09:12:46AM +, Yao, Jiewen wrote: > by design a platform need define a trusted console and only

Re: [edk2] Question about SecurityPkg/DxeTcg2PhysicalPresenceLib

2018-08-10 Thread Yao, Jiewen
by design a platform need define a trusted console and only connect this trusted console before endofdxe thank you! Yao, Jiewen > 在 2018年8月10日,下午4:50,"heyi@linaro.org" 写道: > > Hi folks, > > The function Tcg2PhysicalPresenceLibProcessRequest in > DxeTcg2PhysicalPresenceLib > requires

[edk2] Question about SecurityPkg/DxeTcg2PhysicalPresenceLib

2018-08-10 Thread heyi . guo
Hi folks, The function Tcg2PhysicalPresenceLibProcessRequest in DxeTcg2PhysicalPresenceLib requires to be invoked after console is ready, and in the function it will call VariableLockProtocol->RequestToLock(), while variable RequestToLock() requires to be called before "End Of Dxe" event, or else