Re: [edk2] [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add gEfiVariableArchProtocolGuid dependency

2016-09-01 Thread Fan, Jeff
, Jordan L; Tian, Feng Subject: Re: [edk2] [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add gEfiVariableArchProtocolGuid dependency On 09/01/16 03:11, Fan, Jeff wrote: > Laszlo, > > UefiCpuPkg/PiSmmCpuDxeSmm driver and > UefiCpuPkg/Library/SmmCpuFeatuersLib have no such

Re: [edk2] [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add gEfiVariableArchProtocolGuid dependency

2016-09-01 Thread Laszlo Ersek
On 09/01/16 03:11, Fan, Jeff wrote: > Laszlo, > > UefiCpuPkg/PiSmmCpuDxeSmm driver and > UefiCpuPkg/Library/SmmCpuFeatuersLib have no such requirement on > gEfiVariableArchProtocolGuid to access HII type PCD. In fact, our > platform SmmCpuFeaturesLib instance (linked by PiSmmCpuDxeSmm) is >

Re: [edk2] [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add gEfiVariableArchProtocolGuid dependency

2016-08-31 Thread Fan, Jeff
- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, August 30, 2016 9:46 PM To: Fan, Jeff; Zeng, Star; edk2-de...@ml01.01.org Cc: Kinney, Michael D; Justen, Jordan L; Tian, Feng Subject: Re: [edk2] [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add gEfiVariableArchProtocolGuid dependency

Re: [edk2] [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add gEfiVariableArchProtocolGuid dependency

2016-08-30 Thread Laszlo Ersek
On 08/25/16 10:00, Fan, Jeff wrote: > Laszlo, > > After discussed with Star, I understood OVMF's circle dependency on Variable > Arch protocol and SMM CPU driver. > > I will defer to check-in this patch till found the better solution. Thank you! > Before the proper fix adopted, our platforms

Re: [edk2] [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add gEfiVariableArchProtocolGuid dependency

2016-08-25 Thread Fan, Jeff
by PiSmmCpuDxeSmm driver. Thanks! Jeff -Original Message- From: Zeng, Star Sent: Wednesday, August 24, 2016 9:42 PM To: Laszlo Ersek; Fan, Jeff; edk2-de...@ml01.01.org Cc: Kinney, Michael D; Justen, Jordan L; Tian, Feng Subject: Re: [edk2] [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add

Re: [edk2] [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add gEfiVariableArchProtocolGuid dependency

2016-08-24 Thread Zeng, Star
[Snipped] I am not so clear about "the pristine "OVMF_VARS.fd" varstore template that falls right out of the OVMF build". Variable driver depends on PcdFlashNvStorageVariableBase(64) be set correctly to produce gEfiVariableArchProtocolGuid protocol. After PiSmmCpuDxeSmm adds

Re: [edk2] [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add gEfiVariableArchProtocolGuid dependency

2016-08-24 Thread Laszlo Ersek
On 08/24/16 01:22, Zeng, Star wrote: > On 2016/8/24 11:27, Laszlo Ersek wrote: >> On 08/23/16 22:39, Zeng, Star wrote: >>> On 2016/8/23 23:33, Laszlo Ersek wrote: On 08/18/16 22:57, Zeng, Star wrote: > On 2016/8/19 10:45, Zeng, Star wrote: >> On 2016/8/19 10:26, Laszlo Ersek wrote:

Re: [edk2] [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add gEfiVariableArchProtocolGuid dependency

2016-08-24 Thread Zeng, Star
On 2016/8/24 13:22, Zeng, Star wrote: On 2016/8/24 11:27, Laszlo Ersek wrote: On 08/23/16 22:39, Zeng, Star wrote: On 2016/8/23 23:33, Laszlo Ersek wrote: On 08/18/16 22:57, Zeng, Star wrote: On 2016/8/19 10:45, Zeng, Star wrote: On 2016/8/19 10:26, Laszlo Ersek wrote: On 08/19/16 04:00,

Re: [edk2] [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add gEfiVariableArchProtocolGuid dependency

2016-08-23 Thread Zeng, Star
On 2016/8/24 11:27, Laszlo Ersek wrote: On 08/23/16 22:39, Zeng, Star wrote: On 2016/8/23 23:33, Laszlo Ersek wrote: On 08/18/16 22:57, Zeng, Star wrote: On 2016/8/19 10:45, Zeng, Star wrote: On 2016/8/19 10:26, Laszlo Ersek wrote: On 08/19/16 04:00, Fan, Jeff wrote: Laszlo, I could

Re: [edk2] [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add gEfiVariableArchProtocolGuid dependency

2016-08-23 Thread Laszlo Ersek
On 08/23/16 22:39, Zeng, Star wrote: > On 2016/8/23 23:33, Laszlo Ersek wrote: >> On 08/18/16 22:57, Zeng, Star wrote: >>> On 2016/8/19 10:45, Zeng, Star wrote: On 2016/8/19 10:26, Laszlo Ersek wrote: > On 08/19/16 04:00, Fan, Jeff wrote: >> Laszlo, >> >> I could revert this

Re: [edk2] [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add gEfiVariableArchProtocolGuid dependency

2016-08-23 Thread Zeng, Star
On 2016/8/23 23:33, Laszlo Ersek wrote: On 08/18/16 22:57, Zeng, Star wrote: On 2016/8/19 10:45, Zeng, Star wrote: On 2016/8/19 10:26, Laszlo Ersek wrote: On 08/19/16 04:00, Fan, Jeff wrote: Laszlo, I could revert this patch firstly. Thank you, that would be very kind. Could you please

Re: [edk2] [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add gEfiVariableArchProtocolGuid dependency

2016-08-23 Thread Laszlo Ersek
iable/RuntimeDxe/Variable.c] However, the variable store is definitely not corrupted; this failure reproduces with the pristine "OVMF_VARS.fd" varstore template that falls right out of the OVMF build. Thanks! Laszlo >> Thanks, >> Star >> >>> >>> Anyway, if you c

Re: [edk2] [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add gEfiVariableArchProtocolGuid dependency

2016-08-19 Thread Laszlo Ersek
On 08/19/16 04:57, Zeng, Star wrote: > On 2016/8/19 10:45, Zeng, Star wrote: >> On 2016/8/19 10:26, Laszlo Ersek wrote: >>> On 08/19/16 04:00, Fan, Jeff wrote: Laszlo, I could revert this patch firstly. >>> >>> Thank you, that would be very kind. >>> Could you please dig out

Re: [edk2] [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add gEfiVariableArchProtocolGuid dependency

2016-08-18 Thread Zeng, Star
edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Friday, August 19, 2016 9:19 AM To: Fan, Jeff; edk2-de...@ml01.01.org Cc: Kinney, Michael D; Tian, Feng Subject: Re: [edk2] [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add gEfiVariableArchProtocolGuid dependency On 08/0

Re: [edk2] [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add gEfiVariableArchProtocolGuid dependency

2016-08-18 Thread Zeng, Star
Re: [edk2] [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add gEfiVariableArchProtocolGuid dependency On 08/02/16 10:59, Jeff Fan wrote: PiSmmCpuDxeSmm driver's entry point will get some PCDs supported dynamic type. In case those PCDs are set as DynamicHii type in platform DSC File, it implies that EF

Re: [edk2] [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add gEfiVariableArchProtocolGuid dependency

2016-08-18 Thread Laszlo Ersek
n something else. Thanks! Laszlo > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Friday, August 19, 2016 9:19 AM > To: Fan, Jeff; edk2-de...@ml01.01.org > Cc: Kinney, Michael D; Tian, Feng > S

Re: [edk2] [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add gEfiVariableArchProtocolGuid dependency

2016-08-18 Thread Fan, Jeff
Ersek Sent: Friday, August 19, 2016 9:19 AM To: Fan, Jeff; edk2-de...@ml01.01.org Cc: Kinney, Michael D; Tian, Feng Subject: Re: [edk2] [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add gEfiVariableArchProtocolGuid dependency On 08/02/16 10:59, Jeff Fan wrote: > PiSmmCpuDxeSmm driver's entry po

Re: [edk2] [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add gEfiVariableArchProtocolGuid dependency

2016-08-18 Thread Laszlo Ersek
On 08/02/16 10:59, Jeff Fan wrote: > PiSmmCpuDxeSmm driver's entry point will get some PCDs supported dynamic type. > In case those PCDs are set as DynamicHii type in platform DSC File, it implies > that EFI Variable Arch protocol is required. > > This fix is to add gEfiVariableArchProtocolGuid