Re: [O] [RFC] Rewrite indentation functions

2014-05-07 Thread Nicolas Goaziou
Hello, Bastien writes: > Please go ahead, that's the easiest way to get more feedback and Eric > did half the job already, so we must be good. Applied. Regards, -- Nicolas Goaziou

Re: [O] [RFC] Rewrite indentation functions

2014-05-06 Thread Eric Abrahamsen
Bastien writes: > Hi Nicolas, > > Nicolas Goaziou writes: > >> I would like to install the following patches on master. > > Please go ahead, that's the easiest way to get more feedback and Eric > did half the job already, so we must be good. > > Thanks for working on this, I've been running all

Re: [O] [RFC] Rewrite indentation functions

2014-05-06 Thread Bastien
Hi Nicolas, Nicolas Goaziou writes: > I would like to install the following patches on master. Please go ahead, that's the easiest way to get more feedback and Eric did half the job already, so we must be good. Thanks for working on this, -- Bastien

Re: [O] [RFC] Rewrite indentation functions

2014-05-05 Thread Nicolas Goaziou
Hello, Eric Abrahamsen writes: > One last thing! In the course of this I also noticed that, in a buffer > that contains a broken property drawer, you can't set properties on > *any* other heading. When `org-buffer-property-keys' goes looking for > valid keys used elsewhere in the current buffer,

Re: [O] [RFC] Rewrite indentation functions

2014-05-04 Thread Nicolas Goaziou
Eric Abrahamsen writes: > Perhaps we need a new version of patch 3? Here it is. Regards, -- Nicolas Goaziou >From 66d0ab7d1025969e5fd383b93ffe1fb1b05a83a8 Mon Sep 17 00:00:00 2001 From: Nicolas Goaziou Date: Mon, 28 Apr 2014 18:38:31 +0200 Subject: [PATCH 3/3] Rewrite `org-indent-drawer' an

Re: [O] [RFC] Rewrite indentation functions

2014-05-03 Thread Eric Abrahamsen
Nicolas Goaziou writes: > Hello, > > Eric Abrahamsen writes: > >>> Right now I'm seeing breakage with `org-set-property' -- this only >>> happens on the indentation patches branch. Adding an EXPORT_AUTHOR >>> property with that command, value of "asdfadsf", gives me this: >>> >>> * Test Heading

Re: [O] [RFC] Rewrite indentation functions

2014-05-03 Thread Eric Abrahamsen
Nicolas Goaziou writes: > Hello, > > Eric Abrahamsen writes: > >>> Right now I'm seeing breakage with `org-set-property' -- this only >>> happens on the indentation patches branch. Adding an EXPORT_AUTHOR >>> property with that command, value of "asdfadsf", gives me this: >>> >>> * Test Heading

Re: [O] [RFC] Rewrite indentation functions

2014-05-03 Thread Eric Abrahamsen
Nicolas Goaziou writes: > Hello, > > Eric Abrahamsen writes: > >>> Right now I'm seeing breakage with `org-set-property' -- this only >>> happens on the indentation patches branch. Adding an EXPORT_AUTHOR >>> property with that command, value of "asdfadsf", gives me this: >>> >>> * Test Heading

Re: [O] [RFC] Rewrite indentation functions

2014-05-03 Thread Nicolas Goaziou
Hello, Eric Abrahamsen writes: >> Right now I'm seeing breakage with `org-set-property' -- this only >> happens on the indentation patches branch. Adding an EXPORT_AUTHOR >> property with that command, value of "asdfadsf", gives me this: >> >> * Test Heading >> :PROPERTIES: >> >> :EXPORT_AUT

Re: [O] [RFC] Rewrite indentation functions

2014-05-03 Thread Eric Abrahamsen
Eric Abrahamsen writes: > Nicolas Goaziou writes: > >> Hello, >> >> Eric Abrahamsen writes: >> >>> Wish I was competent to actually review this, but... In lieu of that, >>> I'd be happy to run it and report errors. If you think a separate >>> testing branch is warranted, that might be an idea.

Re: [O] [RFC] Rewrite indentation functions

2014-05-03 Thread Eric Abrahamsen
Nicolas Goaziou writes: > Hello, > > Eric Abrahamsen writes: > >> Wish I was competent to actually review this, but... In lieu of that, >> I'd be happy to run it and report errors. If you think a separate >> testing branch is warranted, that might be an idea. Otherwise I'd say >> let it drop and

Re: [O] [RFC] Rewrite indentation functions

2014-05-02 Thread Eric Abrahamsen
Nicolas Goaziou writes: > Hello, > > Eric Abrahamsen writes: > >> Wish I was competent to actually review this, but... In lieu of that, >> I'd be happy to run it and report errors. If you think a separate >> testing branch is warranted, that might be an idea. Otherwise I'd say >> let it drop and

Re: [O] [RFC] Rewrite indentation functions

2014-05-02 Thread Nicolas Goaziou
Hello, Eric Abrahamsen writes: > Wish I was competent to actually review this, but... In lieu of that, > I'd be happy to run it and report errors. If you think a separate > testing branch is warranted, that might be an idea. Otherwise I'd say > let it drop and we'll pick up the pieces :) You ca

Re: [O] [RFC] Rewrite indentation functions

2014-05-01 Thread Eric Abrahamsen
Nicolas Goaziou writes: > Hello, > > I would like to install the following patches on master. Basically, they > consist of a full rewrite of all indentation related functions, with > explicit rules in docstrings, comprehensive test suites, and backed-up > by the parser. Wish I was competent to a

Re: [O] [RFC] Rewrite indentation functions

2014-05-01 Thread Nicolas Goaziou
Nicolas Goaziou writes: > I would like to install the following patches on master. Basically, they > consist of a full rewrite of all indentation related functions, with > explicit rules in docstrings, comprehensive test suites, and backed-up > by the parser. Here's an update for the first patch

Re: [O] [RFC] Rewrite indentation functions

2014-04-30 Thread Sebastien Vauban
Vikas Rawal wrote: >> >> 1. Indentation of the first line of an element should be, when >> applicable, relative to the /first line/ of the element before. >> Therefore, in the following example >> >> Some long paragraph >> with multiple line >> >> XAnother paragraph

Re: [O] [RFC] Rewrite indentation functions

2014-04-30 Thread Vikas Rawal
> > 1. Indentation of the first line of an element should be, when > applicable, relative to the /first line/ of the element before. > Therefore, in the following example > > Some long paragraph > with multiple line > > XAnother paragraph > It is almost surely some