Re: [O] [PATCH] Fix alphabetic sorting for headlines, tags

2018-02-12 Thread Nicolas Goaziou
Sebastian Reuße writes: > Nicolas Goaziou writes: > >> Sebastian Reuße writes: > >>> The test will error out if the data for the chosen locale isn’t >>> actually present on the system. I chose the «en_US» locale in the >>> hopes that this will frequently be installed. I’ll leave it up to you >>

Re: [O] [PATCH] Fix alphabetic sorting for headlines, tags

2018-02-12 Thread Sebastian Reuße
Nicolas Goaziou writes: > Sebastian Reuße writes: >> The test will error out if the data for the chosen locale isn’t >> actually present on the system. I chose the «en_US» locale in the >> hopes that this will frequently be installed. I’ll leave it up to you >> to decide whether that is accept

Re: [O] [PATCH] Fix alphabetic sorting for headlines, tags

2018-02-12 Thread Nicolas Goaziou
Sebastian Reuße writes: > The test will error out if the data for the chosen locale isn’t actually > present on the system. I chose the «en_US» locale in the hopes that this > will frequently be installed. I’ll leave it up to you to decide whether > that is acceptable. I used "C" locale instead.

Re: [O] [PATCH] Fix alphabetic sorting for headlines, tags

2018-02-12 Thread Nicolas Goaziou
Hello, Sebastian Reuße writes: > * org.el (org-sort-entries): Use collated sorting. > (org-tags-sort-function): Use collated sorting. > (org-string-collate-greaterp): Add helper-function to use as defcustom > option, since there is no ‘string-collate-greaterp’ in Emacs. > > * org-compat.el (org-

[O] [PATCH] Fix alphabetic sorting for headlines, tags

2018-02-12 Thread Sebastian Reuße
* org.el (org-sort-entries): Use collated sorting. (org-tags-sort-function): Use collated sorting. (org-string-collate-greaterp): Add helper-function to use as defcustom option, since there is no ‘string-collate-greaterp’ in Emacs. * org-compat.el (org-string-collate-lessp): Add proxy to fall-back

Re: [O] [PATCH] Fix alphabetic sorting for headlines, tags

2018-02-12 Thread Sebastian Reuße
Nicolas Goaziou writes: > Sebastian Reuße writes: > >> I also considered adding a regression test for non-ASCII chars to >> «test-org/sort-entries», but for stable results, one would have to >> enforce some canonical locale. Unfortunately, it’s not possible to >> change the locale at Emacs run-

Re: [O] [PATCH] Fix alphabetic sorting for headlines, tags

2018-02-11 Thread Nicolas Goaziou
Sebastian Reuße writes: > I also considered adding a regression test for non-ASCII chars to > «test-org/sort-entries», but for stable results, one would have to > enforce some canonical locale. Unfortunately, it’s not possible to > change the locale at Emacs run-time; Emacs only seems to call > «

[O] [PATCH] Fix alphabetic sorting for headlines, tags

2018-02-11 Thread Sebastian Reuße
* org.el (org-sort-entries): Use collated sorting. (org-tags-sort-function): Use collated sorting. (org-string-collate-greaterp): Add helper-function to use as defcustom option, since there is no ‘string-collate-greaterp’ in Emacs. * org-compat.el (org-string-collate-lessp): Add proxy to fall-back

Re: [O] [PATCH] Fix alphabetic sorting for headlines, tags

2018-02-11 Thread Sebastian Reuße
Hello Nicolas, Nicolas Goaziou writes: > However, Org 9.X still supports Emacs 24, so we cannot use > `string-collate-lessp without degrading gracefully to `string-lessp' > in these Emacsen. > We could add `org-string-collate-lessp' to "org-compat.el", which > would be an alias for `string-coll

Re: [O] [PATCH] Fix alphabetic sorting for headlines, tags

2018-02-10 Thread Nicolas Goaziou
Hello, Sebastian Reuße writes: > * org.el (org-sort-entries): Use collated sorting. > (org-tags-sort-function): Use collated sorting. > (org-string-collate-greaterp): Add helper-function to use as defcustom > option, since there is no ‘string-collate-greaterp’ in Emacs. Thank you. However, Org

[O] [PATCH] Fix alphabetic sorting for headlines, tags

2018-02-06 Thread Sebastian Reuße
* org.el (org-sort-entries): Use collated sorting. (org-tags-sort-function): Use collated sorting. (org-string-collate-greaterp): Add helper-function to use as defcustom option, since there is no ‘string-collate-greaterp’ in Emacs. ‘org-sort-entries’ and ‘org-tags-sort-function’ advertise alphabet

[O] [PATCH] Fix alphabetic sorting for headlines, tags

2018-02-06 Thread Sebastian Reuße
* org.el (org-sort-entries): Use collated sorting. (org-tags-sort-function): Use collated sorting. (org-string-collate-greaterp): Add helper-function to use as defcustom option, since there is no ‘string-collate-greaterp’ in Emacs. ‘org-sort-entries’ and ‘org-tags-sort-function’ advertise alphabet