Re: [Emc-developers] TYPO in export hal parameter name in ppmc driver

2018-09-07 Thread andy pugh
On Fri, 7 Sep 2018 at 02:55, Jon Elson wrote: > Since it is so RARELY used, I think it makes sense to fix > the code in 2.8, ONLY, and maybe fix the docs in 2.7 2.8 already has a config conversion script. It is trivial to add the ppmc pins to the script if the name does change. https://github.co

Re: [Emc-developers] TYPO in export hal parameter name in ppmc driver

2018-09-06 Thread Jon Elson
On 09/06/2018 04:13 PM, Gene Heskett wrote: So IMO, the hyphen s/b a legal pin description. It IS a legal definition, and it WORKS! BUT, it is inconsistent. The same function on the PPMC DIO board has a dot separating the output from the invert, but for the USC and UPC, it has a hyphen. Descr

Re: [Emc-developers] TYPO in export hal parameter name in ppmc driver

2018-09-06 Thread Jon Elson
On 09/06/2018 11:13 AM, Les Newell wrote: An option would be to have both ppmc.0.dout.03-invert and ppmc.0.dout.03.invert with a note in the docs that ppmc.0.dout.03-invert is deprecated and will be removed in the future. Code wise it's ugly but you won't end up breaking anyone's configs.

Re: [Emc-developers] TYPO in export hal parameter name in ppmc driver

2018-09-06 Thread Gene Heskett
On Thursday 06 September 2018 11:48:34 Jon Elson wrote: > OUCH, I just found a typo in the hal_ppmc.c driver, most > likely it has been there since John Kasunich wrote it in > 2005. Now, I have to decide how to fix it. > > So, for the PPMC DIO (the specific analog interface) and for > the Univers

Re: [Emc-developers] TYPO in export hal parameter name in ppmc driver

2018-09-06 Thread Sebastian Kuzminsky
On Thu, Sep 6, 2018 at 9:50 AM Jon Elson wrote: > So, for the PPMC DIO (the specific analog interface) and for > the Universal Stepper and PWM controller extra digital > outputs, the invert output parameter is like : > ppmc.0.dout.03.invert > > But, due to the typo, the main digital outputs on th

Re: [Emc-developers] TYPO in export hal parameter name in ppmc driver

2018-09-06 Thread Chris Morley
I believe mesa uses alias to the same effect. Fix the pin name, Add an alias pin name for the wrong name and add a warning in the docs? Chris M Original message From: Jon Elson Date: 2018-09-06 8:50 AM (GMT-08:00) To: EMC developers Subject: [Emc-developers] TYPO in export

Re: [Emc-developers] TYPO in export hal parameter name in ppmc driver

2018-09-06 Thread Les Newell
An option would be to have both ppmc.0.dout.03-invert and ppmc.0.dout.03.invert with a note in the docs that ppmc.0.dout.03-invert is deprecated and will be removed in the future. Code wise it's ugly but you won't end up breaking anyone's configs. Les On 06/09/2018 16:48, Jon Elson wrote: OU