Re: [Emc-developers] putting some mods to gs2_vfd.c into mainline

2015-10-11 Thread Sebastian Kuzminsky
On 10/11/2015 10:05 AM, Sebastian Kuzminsky wrote: > On 10/10/2015 09:31 PM, Tom Easterday wrote: >> Sorry, there was a mix of tabs and spaces in indentation in the file so we >> cleaned it all up- didn't think about larger implications . Also sorry >> about various oddly named patches, don't us

Re: [Emc-developers] putting some mods to gs2_vfd.c into mainline

2015-10-11 Thread Sebastian Kuzminsky
On 10/10/2015 09:31 PM, Tom Easterday wrote: > Sorry, there was a mix of tabs and spaces in indentation in the file so we > cleaned it all up- didn't think about larger implications . Also sorry about > various oddly named patches, don't use git often enough to keep straight. No problem, Tom.

Re: [Emc-developers] putting some mods to gs2_vfd.c into mainline

2015-10-10 Thread Tom Easterday
Sorry, there was a mix of tabs and spaces in indentation in the file so we cleaned it all up- didn't think about larger implications . Also sorry about various oddly named patches, don't use git often enough to keep straight. -Tom > On Oct 10, 2015, at 5:24 PM, Sebastian Kuzminsky wrote: > >

Re: [Emc-developers] putting some mods to gs2_vfd.c into mainline

2015-10-10 Thread John Thornton
Tom, The only thing I set was stop type and accel and decel so I don't know about other settings. Thanks JT On 10/10/2015 9:26 AM, Tom Easterday wrote: > Ok ,hang on… There was one instance when I was testing the initialization > mod where I found the acceleration/ deceleration parameters wh

Re: [Emc-developers] putting some mods to gs2_vfd.c into mainline

2015-10-10 Thread Sebastian Kuzminsky
On 10/09/2015 08:23 AM, Tom Easterday wrote: > Ok, I think we have cleaned up the indentation. Let me know if anything is > amiss… > >> On Oct 5, 2015, at 11:06 PM, Sebastian Kuzminsky wrote: >> >> My only nitpick is that the indentation in the new "while (done==0) {" >> main loop is inconsiste

Re: [Emc-developers] putting some mods to gs2_vfd.c into mainline

2015-10-10 Thread Tom Easterday
Well, I’m at the shop and my VFD is configured as it has been for weeks. So, other than the one time, which certainly could have been an anomaly due to having been actively messing with it for testing, I haven’t had it reset parameters… -Tom > On Oct 10, 2015, at 10:26 AM, Tom Easterday wro

Re: [Emc-developers] putting some mods to gs2_vfd.c into mainline

2015-10-10 Thread Tom Easterday
Ok ,hang on… There was one instance when I was testing the initialization mod where I found the acceleration/ deceleration parameters where reset. I had been turning the vfd on/off and playing with various parameters so I just kind of ignored it but was a little surprised. Yesterday I was do

Re: [Emc-developers] putting some mods to gs2_vfd.c into mainline

2015-10-10 Thread John Thornton
It happens quite often for me, I only set the stop type to ramp and the accl and decel times to 0.5 seconds. I can tell they have been reset when the spindle takes 10 seconds to spool up. If yours never get reset then I suspect a bad GS2. Sometimes after shutting down the LCNC computer and some

Re: [Emc-developers] putting some mods to gs2_vfd.c into mainline

2015-10-09 Thread Tom Easterday
Funny you asked because I was about to send a message asking what this was about. I haven’t EVER seen my parameters get reset to factory settings, I don’t think, anyway…. When does this happen? How often? What parameters get reset (all)? If they all got reset I would definitely notice this

Re: [Emc-developers] putting some mods to gs2_vfd.c into mainline

2015-10-09 Thread John Thornton
Tom, Do you have any idea why a GS2 parameters get reset to factory settings with the gs2 component. AD says that modbus is writing over the settings. JT On 10/9/2015 9:23 AM, Tom Easterday wrote: > Ok, I think we have cleaned up the indentation. Let me know if anything is > amiss… > Thanks,

Re: [Emc-developers] putting some mods to gs2_vfd.c into mainline

2015-10-09 Thread Tom Easterday
Ok, I think we have cleaned up the indentation. Let me know if anything is amiss… Thanks, -Tom Added-initialize-option-to-gs2_vfd.c.patch Description: Binary data > On Oct 5, 2015, at 11:06 PM, Sebastian Kuzminsky wrote: > > I looked at what I think is the latest version of your patch: 2.7,

Re: [Emc-developers] putting some mods to gs2_vfd.c into mainline

2015-10-06 Thread Sebastian Kuzminsky
On 10/06/2015 04:52 AM, John Thornton wrote: > My GS2 will lose the parameter settings from time to time and Automation > Direct says it is because modbus is changing them. Is this a fix for that? This should not affect that, unfortunately. This just adds a .enable pin to the gs2_vfd, and a risi

Re: [Emc-developers] putting some mods to gs2_vfd.c into mainline

2015-10-06 Thread John Thornton
My GS2 will lose the parameter settings from time to time and Automation Direct says it is because modbus is changing them. Is this a fix for that? JT On 10/5/2015 10:06 PM, Sebastian Kuzminsky wrote: > I looked at what I think is the latest version of your patch: 2.7, > patched with > 0003-Adde

Re: [Emc-developers] putting some mods to gs2_vfd.c into mainline

2015-10-05 Thread Sebastian Kuzminsky
I looked at what I think is the latest version of your patch: 2.7, patched with 0003-Added-an-initialize-option-to-gs2_vfd.c-so-it-can-be.patch, patched with Added-an-initialize-option-to-gs2_vfd.patch. The logic looks good to me. I like that you clear isInitialized when disabling the GS2, so tha

Re: [Emc-developers] putting some mods to gs2_vfd.c into mainline

2015-05-27 Thread Tom Easterday
Hi Seb, responses inline below. On May 24, 2015, at 3:28 PM, Sebastian Kuzminsky wrote: > The patch file you attached claims to be the third patch in a series of > 3, but numbers 1 and 2 were not attached. Was that intentional? > > It applies cleanly to origin/2.7 and builds, so maybe everythi

Re: [Emc-developers] putting some mods to gs2_vfd.c into mainline

2015-05-24 Thread Sebastian Kuzminsky
On 05/15/2015 11:17 AM, Tom Easterday wrote: > >> On May 14, 2015, at 3:25 PM, Sebastian Kuzminsky wrote: >> The preferred ways to submit patches are described in the Contributing >> to LinuxCNC document, feel free to ask questions if you run into any >> problems. >> >> http://linuxcnc.org/doc

Re: [Emc-developers] putting some mods to gs2_vfd.c into mainline

2015-05-20 Thread Tom Easterday
Didn’t hear back on this so I am assuming it is the correct format and that the change was unanimously accepted with no fanfare :-) Actually, no wait, this me Championing my patch. Yeah, that’s it! -Tom > On May 15, 2015, at 1:17 PM, Tom Easterday wrote: > > >> On May 14, 2015, at 3:25 PM, S

Re: [Emc-developers] putting some mods to gs2_vfd.c into mainline

2015-05-15 Thread Tom Easterday
> On May 14, 2015, at 3:25 PM, Sebastian Kuzminsky wrote: > The preferred ways to submit patches are described in the Contributing > to LinuxCNC document, feel free to ask questions if you run into any > problems. > > http://linuxcnc.org/docs/2.7/html/code/Contributing-to-LinuxCNC.html#_overvi

Re: [Emc-developers] putting some mods to gs2_vfd.c into mainline

2015-05-14 Thread Tom Easterday
Heh heh, I see a religious argument ensuing. Either you believe that powering the machine down is the only guarantee of safety, or you believe that your electronics are unquestionably reliable and you are a statistician. If the vfd has power and rather than power it down you command it to brak

Re: [Emc-developers] putting some mods to gs2_vfd.c into mainline

2015-05-14 Thread Dave Caroline
To bring a vfd to stationary fastest the vfd has to have control to use the deceleration curve/braking resistors if fitted and used. Therefore keeping the vfd powered is safer in the initial stop, only then should it be powered down. Dave Caroline On 14/05/2015, John Kasunich wrote: > > > On Thu

Re: [Emc-developers] putting some mods to gs2_vfd.c into mainline

2015-05-14 Thread John Kasunich
On Thu, May 14, 2015, at 03:25 PM, Sebastian Kuzminsky wrote: > > It seems fairly common for people to build machines where the spindle > VFD power goes on and off along with the servo amp power (F1 in Axis), > which (as you point out) means something like this feature is required. > > I thin

Re: [Emc-developers] putting some mods to gs2_vfd.c into mainline

2015-05-14 Thread Sebastian Kuzminsky
On 5/14/15 1:18 PM, Tom Easterday wrote: > I am not a developer (and I don’t play one on TV). But I do know a little > bit, enough to be dangerous. I had some help modifying the gs2_vfd.c > component in 2.7~pre6 in order to add a new option that allows one to disable > and enable the component.