[E-devel] [patch] elm_genlist - add item_class management functions

2012-02-15 Thread Hyoyoung Chang
yeah, it's right. added free and ref to examples. On Tue, Feb 14, 2012 at 2:47 PM, Carsten Haitzler ras...@rasterman.com wrote: On Mon, 13 Feb 2012 19:07:07 +0900 Hyoyoung Chang hyoyo...@gmail.com said: ooh something i didn't realize - you should free item class in test examples after u are

Re: [E-devel] E SVN: jihoon IN trunk/ecore: . src/lib/ecore_imf src/modules/immodules/scim src/modules/immodules/xim

2012-02-15 Thread Vincent Torri
On Wed, Feb 15, 2012 at 2:22 AM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: ecore_imf: Add ecore_imf APIs to set return key type, disable return key. Author:       jihoon Date:         2012-02-14 17:22:28 -0800 (Tue, 14 Feb 2012) New Revision: 67946 Trac:        

Re: [E-devel] E SVN: jihoon IN trunk/edje: . src/lib

2012-02-15 Thread Vincent Torri
On Wed, Feb 15, 2012 at 9:21 AM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: edje/edje_entry:  add edje_object_part_text_input_panel_language_set/get      edje_object_part_text_input_panel_imdata_set/get      edje_object_part_text_input_panel_return_key_type_set/get      

Re: [E-devel] E SVN: hermet IN trunk/elementary: data/themes/widgets src/lib

2012-02-15 Thread Davide Andreoli
2012/2/15 ChunEon Park her...@naver.com IMHO, we should not break compatibility of theme as possible. But actually, edj is a program. it works so much things. We can't regard it just as a ui layout theme. It could break compatibility of widget theme always. (like this case) Someday, it may

Re: [E-devel] E SVN: hermet IN trunk/elementary: data/themes/widgets src/lib

2012-02-15 Thread The Rasterman
On Wed, 15 Feb 2012 21:01:48 +0100 Davide Andreoli d...@gurumeditation.it said: 2012/2/15 ChunEon Park her...@naver.com IMHO, we should not break compatibility of theme as possible. But actually, edj is a program. it works so much things. We can't regard it just as a ui layout theme.

Re: [E-devel] E SVN: jihoon IN trunk/edje: . src/lib

2012-02-15 Thread Jihoon Kim
I've updated in Ecore_IMF.h and Edje.h in svn. Thanks, Vincent. On Wednesday, February 15, 2012, Vincent Torri wrote: On Wed, Feb 15, 2012 at 9:21 AM, Enlightenment SVN no-re...@enlightenment.org javascript:; wrote: Log: edje/edje_entry: add

[E-devel] [Patch][elementary_test] test_actionslider, test_bg, test_box

2012-02-15 Thread cnook
Dear All, Hello~ As you guess, the patch is for the elementary_test. Please review the patch and give any feedbacks. The test_actionslider patch is mainly for elm_actionslider_xxx_get() APIs. It would not be a good idea to add test code for such APIs. So I have planed to add test code except

Re: [E-devel] [Patch][elementary_test] test_actionslider, test_bg, test_box

2012-02-15 Thread Daniel Juyung Seo
Thank you very much cnook. I have some brief comments here. 1. actionslider 'switch-case' indentation is wrong. Please check below e-coding style page. http://trac.enlightenment.org/e/wiki/ECoding And for elm_actionslider_enabled_pos_get, how about printing it like below? actionslider enabled

Re: [E-devel] E SVN: hermet IN trunk/elementary: data/themes/widgets src/lib

2012-02-15 Thread ChunEon Park
I think theme should not broken the compatibility neither. It means we don't need to check the versions in minor changes. but when major version of elm is updated, then it allows the breaking of the theme compatibility. So I though just collection need to check the version.

Re: [E-devel] [patch] elm_genlist - add item_class management functions

2012-02-15 Thread Daniel Juyung Seo
Great! But add NULL check for itc. Thanks. Daniel Juyung Seo (SeoZ) On Wed, Feb 15, 2012 at 7:09 PM, Hyoyoung Chang hyoyo...@gmail.com wrote: yeah, it's right. added free and ref to examples. On Tue, Feb 14, 2012 at 2:47 PM, Carsten Haitzler ras...@rasterman.com wrote: On Mon, 13 Feb

Re: [E-devel] E SVN: raster trunk/elementary/src/lib

2012-02-15 Thread Daniel Juyung Seo
No marks for deprecation? Daniel Juyung Seo (SeoZ) On Thu, Feb 16, 2012 at 2:58 PM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: elm_thumb_ethumb_client_connected - elm_thumb_ethumb_client_connected_get() more consistent name. Author: raster Date:

Re: [E-devel] [patch] elm_genlist - add item_class management functions

2012-02-15 Thread Hyoyoung Chang
oops i miss that. thanks. attaching improved version On Thu, Feb 16, 2012 at 2:59 PM, Daniel Juyung Seo seojuyu...@gmail.com wrote: Great! But add NULL check for itc. Thanks. Daniel Juyung Seo (SeoZ) On Wed, Feb 15, 2012 at 7:09 PM, Hyoyoung Chang hyoyo...@gmail.com wrote: yeah, it's

Re: [E-devel] [Patch][elementary_test] test_actionslider, test_bg, test_box

2012-02-15 Thread Kim Shinwoo
Dear Daniel, Thanks! I have attached patch based on your comment. And more.. elm_win_title_set(win, 0); makes CRASH. The last patch is for this. Please review this also and give any feedbacks. Sincerely, Shinwoo Kim. 2012/2/16 Daniel Juyung Seo seojuyu...@gmail.com Thank you very much cnook.

Re: [E-devel] E SVN: raster trunk/elementary/src/lib

2012-02-15 Thread The Rasterman
On Thu, 16 Feb 2012 14:59:58 +0900 Daniel Juyung Seo seojuyu...@gmail.com said: no - doing this in a hurry and no one uses this... :) No marks for deprecation? Daniel Juyung Seo (SeoZ) On Thu, Feb 16, 2012 at 2:58 PM, Enlightenment SVN no-re...@enlightenment.org wrote: Log:

Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2012-02-15 Thread Daniel Juyung Seo
ihyoyoung, can you please add some comments on elm_cnp documentation? I have no knowledge about copy and paste, and it's hard to understand with current description. Thanks in advance. Daniel Juyung Seo (SeoZ) On Thu, Feb 16, 2012 at 4:06 PM, Enlightenment SVN no-re...@enlightenment.org wrote:

Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2012-02-15 Thread Hyoyoung Chang
frankly speaking, i didn't care of cnp apis. some are too much coupled with ecore_x. and other things are not updated. After reviewing i'll make two patches first patch is updating docs and infos. and other patch will contain decoupling with elm_entry and ecore_x. On Thu, Feb 16, 2012 at 4:10