Re: [E-devel] [Patch] E: randr: Don't match DP as LID

2014-12-15 Thread Bruno Prémont
> Commit 074779b460ccb5ef529b2504c54e2ab4778685ca > > On my intel laptop DP are my DisplayPort connections, not LID. > > diff --git a/src/bin/e_randr.c b/src/bin/e_randr.c > index 6ca78b6..c2042fe 100644 > --- a/src/bin/e_randr.c > +++ b/src/bin/e_randr.c > @@ -1209,8 +1209,10 @@ _e_randr_is_lid(E_

Re: [E-devel] [PATCH] [E-MODULES-EXTRA] fix build with trunk

2013-01-14 Thread Lucas De Marchi
On Tue, Jan 15, 2013 at 12:07 AM, Doug Newgard wrote: > Unfortunately, I only have enough knowledge in C to be dangerous, and know > nothing about the e_dbus or edbus APIs. Doing that would also make them > unusable in e17 now that edbus (v2) isn't a separate package that can just be e17 doesn't

Re: [E-devel] [PATCH] [E-MODULES-EXTRA] fix build with trunk

2013-01-14 Thread Doug Newgard
n.mobi > To: [email protected] > Subject: Re: [E-devel] [PATCH] [E-MODULES-EXTRA] fix build with trunk > > Should rather port them to edbus (v2) > > On Monday, January 14, 2013, Doug Newgard wrote: > > > e.h isn't pulling in E_DBus.h anymore. Adding it

Re: [E-devel] [PATCH] [E-MODULES-EXTRA] fix build with trunk

2013-01-14 Thread Gustavo Sverzut Barbieri
Should rather port them to edbus (v2) On Monday, January 14, 2013, Doug Newgard wrote: > e.h isn't pulling in E_DBus.h anymore. Adding it to modules that don't > build without it. -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: ba

[E-devel] [PATCH] [E-MODULES-EXTRA] fix build with trunk

2013-01-14 Thread Doug Newgard
e.h isn't pulling in E_DBus.h anymore. Adding it to modules that don't build without it. empris-e_dbus.patch Description: Binary data everything_mpris-e_dbus.patch Description: Binary data everything_pidgin-e_dbus.patch Description: Binary data ever

Re: [E-devel] [PATCH][E] Patch for minor bugs again

2013-01-03 Thread The Rasterman
il_strcmp instead of strcmp - done > Thank you for letting me know the e_util_strcmp, it is very useful. :) > > Could you check this patch again? > > Thanks & Regards, > Gwanglim > > --- Original Message ------- > Sender : Michael Blumenkrantz > Date : 2012

Re: [E-devel] [PATCH][E] Patch for minor bugs again

2013-01-03 Thread The Rasterman
On Wed, 5 Dec 2012 11:13:36 + Michael Blumenkrantz said: did you actually apply this (well the good bits)? > Hi, > > #2 was incorrect, the conditional should simply be changed from && to || > #3 could be (and was) changed to simply modify the loop conditional > > Instead of testing if (x &

[E-devel] [PATCH][E, E-MODULES-EXTRA] Make some more messages translatable

2012-12-20 Thread Igor Murzov
Two patches make 5 more messages translatable, 3 of them are already present in their pots. One additional patch fixes mismatching parameters for e_action_predef_name_{set,del}() in extra modules. -- Igor >From 810137601226a88be3d35f8c911872bfd8fd40db Mon Sep 17 00:00:00 2001 From: Igor Murzov

Re: [E-devel] [PATCH][E] Some gettext usage corrections

2012-12-18 Thread The Rasterman
On Sun, 16 Dec 2012 17:34:06 +0400 Igor Murzov said: it would appear mixe put these in already... tho no ack on this list.. so 'ack' :) > Hi list > > Here are four patches: > > * Fix mismatching parameters for e_action_predef_name_{set,del}(). >This patch fixes mismatching parameters for

Re: [E-devel] [PATCH][E] Fix mismatching parameters for e_action_predef_name_{set, del}().

2012-12-16 Thread Massimo Maiurana
Igor Murzov, il 16/12/2012 12:06, ha scritto: > This patch fixes mismatching parameters for e_action_predef_name_set() > and e_action_predef_name_del(). These mismatches are mostly regressions > introduced by developers changing parameter for one of these functions and > forgetting to do the same

[E-devel] [PATCH][E] Translate one more label

2012-12-16 Thread Igor Murzov
One more trivial patch: Translate the "Shelf " message. I did it the same way as in src/modules/conf_shelves/e_int_config_shelf.c:189 so there will be no new message in the pot. -- Igor >From fff1f1d92b15140f1805e3bb8f44da5e0ebf614e Mon Sep 17 00:00:00 2001 From: Igor Murzov Date: Sun, 16 Dec

[E-devel] [PATCH][E] Some gettext usage corrections

2012-12-16 Thread Igor Murzov
Hi list Here are four patches: * Fix mismatching parameters for e_action_predef_name_{set,del}(). This patch fixes mismatching parameters for e_action_predef_name_set() and e_action_predef_name_del(). These mismatches are mostly regressions introduced by developers changing parameter

[E-devel] [PATCH][E] Fix mismatching parameters for e_action_predef_name_{set, del}().

2012-12-16 Thread Igor Murzov
This patch fixes mismatching parameters for e_action_predef_name_set() and e_action_predef_name_del(). These mismatches are mostly regressions introduced by developers changing parameter for one of these functions and forgetting to do the same for another one like in r79720. -- Igor >From ecce86

Re: [E-devel] [PATCH] e: Return EINA_FALSE if icon path was not found

2012-12-09 Thread The Rasterman
On Fri, 7 Dec 2012 21:04:11 -0200 José Roberto de Souza said: oh good catch! trivial yet bad! in! tnx! :) > --- > src/bin/e_icon.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/bin/e_icon.c b/src/bin/e_icon.c > index 4252f88..3c0bc40 100644 > --- a/src/bi

[E-devel] [PATCH][E] Assorted small fixes for Enlightenment's messages

2012-12-09 Thread Igor Murzov
Summary for this patchset: * Translate some more labels. * Get rid of the "Folder" term. There is only one "folder" occurence in the pot. Use "directory" instead to be consistent. * Fix dialog title. (It's a follow-up to r7) * Enlarge a translation buffer a bit to prevent truncati

[E-devel] [PATCH] e: Return EINA_FALSE if icon path was not found

2012-12-07 Thread José Roberto de Souza
--- src/bin/e_icon.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bin/e_icon.c b/src/bin/e_icon.c index 4252f88..3c0bc40 100644 --- a/src/bin/e_icon.c +++ b/src/bin/e_icon.c @@ -444,7 +444,7 @@ e_icon_fdo_icon_set(Evas_Object *obj, const char *icon) if (!sd->fdo)

Re: [E-devel] [PATCH][E] Patch for minor bugs again

2012-12-05 Thread Gwanglim Lee
ll free(class) without null check - done #12. e_util_strcmp instead of strcmp - done Thank you for letting me know the e_util_strcmp, it is very useful. :) Could you check this patch again? Thanks & Regards, Gwanglim --- Original Message --- Sender : Michael Blumenkrantz Date : 20

Re: [E-devel] [PATCH][E] Patch for minor bugs again

2012-12-05 Thread Michael Blumenkrantz
Hi, #2 was incorrect, the conditional should simply be changed from && to || #3 could be (and was) changed to simply modify the loop conditional Instead of testing if (x && (!strcmp(X, "string"))), E17 provides the function e_util_strcmp which can take NULL. Also it is not necessary to test if (X

[E-devel] [PATCH][E] Patch for minor bugs again

2012-12-05 Thread Gwanglim Lee
Dear all, As I've said before, I'm attached a patch for minor bugs in the e17 again. Please take a look at attached patch. 01. missing E_FREE(wev) if zone is null File: src/bin/e_actions.c: 1467 Function: ACT_FN_GO_EDGE macro function null check of zone and wev, it would be better to

Re: [E-devel] [PATCH][E] Patch for some minor bugs

2012-12-03 Thread Daniel Juyung Seo
Great job. Thanks! Daniel Juyung Seo (SeoZ) On Mon, Dec 3, 2012 at 8:20 PM, Gwanglim Lee wrote: > Thank you. :) > I'm preparing a similar patch for the e17 again. > I'm going to send it soon. > > Thanks. > Gwanglim > > On Mon, Dec 3, 2012 at 4:52 PM, Michael Blumenkrantz > wrote: > > these are

Re: [E-devel] [PATCH][E] Patch for some minor bugs

2012-12-03 Thread Michael Blumenkrantz
I look forward to it! On Mon, Dec 3, 2012 at 11:20 AM, Gwanglim Lee wrote: > Thank you. :) > I'm preparing a similar patch for the e17 again. > I'm going to send it soon. > > Thanks. > Gwanglim > > On Mon, Dec 3, 2012 at 4:52 PM, Michael Blumenkrantz > wrote: > > these are gold, thanks > > > >

Re: [E-devel] [PATCH][E] Patch for some minor bugs

2012-12-03 Thread Gwanglim Lee
Thank you. :) I'm preparing a similar patch for the e17 again. I'm going to send it soon. Thanks. Gwanglim On Mon, Dec 3, 2012 at 4:52 PM, Michael Blumenkrantz wrote: > these are gold, thanks > > On Fri, Nov 30, 2012 at 6:13 PM, Gwanglim Lee wrote: > >> Dear all, >> >> I'm attaching a patch for

Re: [E-devel] [PATCH][E] Patch for some minor bugs

2012-12-02 Thread Michael Blumenkrantz
these are gold, thanks On Fri, Nov 30, 2012 at 6:13 PM, Gwanglim Lee wrote: > Dear all, > > I'm attaching a patch for some minor bugs in the e17. > Please take a look at attached patch. > > 01. missing E_FREE(inst) > File: src/bin/e_exec.c: 347 > Function: _e_exec_cb_exec > > 02. missing

Re: [E-devel] [PATCH][E] Patch for some minor bugs

2012-11-30 Thread Christopher Michael
Gwanglim Lee wrote: >Dear all, > >I'm attaching a patch for some minor bugs in the e17. >Please take a look at attached patch. > >01. missing E_FREE(inst) >File: src/bin/e_exec.c: 347 >Function: _e_exec_cb_exec > >02. missing null check >File: src/bin/e_fm.c: 10173 >Function: _e_f

[E-devel] [PATCH][E] Patch for some minor bugs

2012-11-30 Thread Gwanglim Lee
Dear all, I'm attaching a patch for some minor bugs in the e17. Please take a look at attached patch. 01. missing E_FREE(inst) File: src/bin/e_exec.c: 347 Function: _e_exec_cb_exec 02. missing null check File: src/bin/e_fm.c: 10173 Function: _e_fm_error_dialog I'm not sure, b

Re: [E-devel] [PATCH][E] Make Everything's plugin and action names translatable. - request for comments from gettext experts

2012-11-25 Thread Massimo Maiurana
[email protected], il 22/11/2012 12:58, ha scritto: > I have to admit that I didn't test if translation works yet. I guess > it should work if gettext runs after preprocessor > ok, since nobody has commented against this patch, and since it would be better to be able to translate as much

Re: [E-devel] [PATCH][E] Make Everything's plugin and action names translatable. - request for comments from gettext experts

2012-11-22 Thread [email protected]
I have to admit that I didn't test if translation works yet. I guess it should work if gettext runs after preprocessor On Wed, Nov 21, 2012 at 10:26 PM, Igor Murzov wrote: > Here is a patch that makes Everything's plugin and action names > translatable. > > I think i should explain why this patc

[E-devel] [PATCH][E] Make Everything's plugin and action names translatable.

2012-11-21 Thread Igor Murzov
Here is a patch that makes Everything's plugin and action names translatable. I think i should explain why this patch actually works :) Some macros used this way: p = EVRY_PLUGIN_BASE("Settings", "configure", E_SETTINGS, _begin, _finish, _fetch); and the macro is defined like this: /* cre

Re: [E-devel] [patch][e] font, size list are not enabled even though custom font is checked.

2012-11-14 Thread Hyojin Kim
hi :) Sanjeev guided me as you can see. So I sent the patch again as new mail according to Guidelines. Thanks for guiding me again. I'll follow Guidelines always. Thanks :) 2012/11/15 Carsten Haitzler > On Sat, 20 Oct 2012 11:54:23 +0900 Sanjeev BA said: > > thanks man. spot-on. :) > > > Sho

Re: [E-devel] [patch][e] font, size list are not enabled even though custom font is checked.

2012-11-14 Thread The Rasterman
On Sat, 20 Oct 2012 11:54:23 +0900 Sanjeev BA said: thanks man. spot-on. :) > Short Answer : Patches and not zip. > > Longer Answer. > > Welcome! > > Read the following links. > http://trac.enlightenment.org/e/wiki/ECoding > http://enlightenment.org/p.php?p=contribute&l=en > > zip files make

Re: [E-devel] [PATCH] e: Do not use recursive makefiles for modules

2012-11-07 Thread michael . blumenkrantz
Gustavo Sverzut Barbieri wrote: >Ahahahah > >On Tuesday, November 6, 2012, Lucas De Marchi wrote: > >> On Tue, Nov 6, 2012 at 4:45 AM, Vincent Torri >> >> wrote: >> > On Tue, Nov 6, 2012 at 4:22 AM, Lucas De Marchi >> > > wrote: >> >> On Mon, Nov 5, 2012 at 9:14 PM, David Seikel >> >> wrote: >> >

Re: [E-devel] [PATCH] e: Do not use recursive makefiles for modules

2012-11-07 Thread Gustavo Sverzut Barbieri
Ahahahah On Tuesday, November 6, 2012, Lucas De Marchi wrote: > On Tue, Nov 6, 2012 at 4:45 AM, Vincent Torri > > > wrote: > > On Tue, Nov 6, 2012 at 4:22 AM, Lucas De Marchi > > > wrote: > >> On Mon, Nov 5, 2012 at 9:14 PM, David Seikel > >> > > wrote: > >>> On Mon, 5 Nov 2012 17:06:11 -0200

Re: [E-devel] [PATCH] e: Do not use recursive makefiles for modules

2012-11-06 Thread Lucas De Marchi
On Tue, Nov 6, 2012 at 4:45 AM, Vincent Torri wrote: > On Tue, Nov 6, 2012 at 4:22 AM, Lucas De Marchi > wrote: >> On Mon, Nov 5, 2012 at 9:14 PM, David Seikel wrote: >>> On Mon, 5 Nov 2012 17:06:11 -0200 Lucas De Marchi >>> wrote: >>> --- aka "add support for speed in our build

Re: [E-devel] [PATCH] e: Do not use recursive makefiles for modules

2012-11-05 Thread Vincent Torri
On Tue, Nov 6, 2012 at 4:22 AM, Lucas De Marchi wrote: > On Mon, Nov 5, 2012 at 9:14 PM, David Seikel wrote: >> On Mon, 5 Nov 2012 17:06:11 -0200 Lucas De Marchi >> wrote: >> >>> --- >>> >>> aka "add support for speed in our build system". >>> >>> I've always been very sad about the amount of t

Re: [E-devel] [PATCH] e: Do not use recursive makefiles for modules

2012-11-05 Thread Lucas De Marchi
On Mon, Nov 5, 2012 at 9:14 PM, David Seikel wrote: > On Mon, 5 Nov 2012 17:06:11 -0200 Lucas De Marchi > wrote: > >> --- >> >> aka "add support for speed in our build system". >> >> I've always been very sad about the amount of time E17 takes to >> build. And upgrading my CPU doesn't solve the

Re: [E-devel] [PATCH] e: Do not use recursive makefiles for modules

2012-11-05 Thread David Seikel
On Mon, 5 Nov 2012 17:06:11 -0200 Lucas De Marchi wrote: > --- > > aka "add support for speed in our build system". > > I've always been very sad about the amount of time E17 takes to > build. And upgrading my CPU doesn't solve the problem neither. Using > SSD would help for sure but I don't h

Re: [E-devel] [Patch][e][e_border] Fix memory leak

2012-11-04 Thread ChunEon Park
looks good. in. 78910 thank you. -Regards, Hermet- -Original Message- From: "Doyoun Kang"<[email protected]> To: <[email protected]>; Cc: Sent: 2012-11-05 (월) 16:00:25 Subject: [E-devel] [P

[E-devel] [Patch][e][e_border] Fix memory leak

2012-11-04 Thread Doyoun Kang
Dear all. I found that there is code to occur memory leak in e_border.c and I fixed it. Please review this patch. Thanks. -- Doyoun Kang e_border.diff Description: Binary data -- LogMeIn Central: Instant, anywhere, Remo

Re: [E-devel] [Patch][e] [gadman] Fix widget position

2012-10-30 Thread Michael Blumenkrantz
in On Tue, Oct 30, 2012 at 7:37 AM, Doyoun Kang wrote: > Dear all. > > I found that there is no consider zone's x,y position while gadman module > is calculating the specified gadget's position in _apply_widget_position(). > I added code to fix gadget's position correctly in gadman module. > Plea

[E-devel] [Patch][e] [gadman] Fix widget position

2012-10-30 Thread Doyoun Kang
Dear all. I found that there is no consider zone's x,y position while gadman module is calculating the specified gadget's position in _apply_widget_position(). I added code to fix gadget's position correctly in gadman module. Please review this patch. Thanks. -- Doyoun Kang e_mod_gadman.diff D

Re: [E-devel] [PATCH][E, E-MODULES-EXTRA] Some translations related fixes

2012-10-29 Thread Michael Blumenkrantz
imo check your E patches, they introduce some grammar errors On Mon, Oct 29, 2012 at 12:16 PM, Igor Murzov wrote: > Some patches to fix translations related issues + > some terminology unification: > > * Use "directory" term everywhere, don't use "folder". > * Remove stray semicolon from a con

[E-devel] [PATCH][E, E-MODULES-EXTRA] Some translations related fixes

2012-10-29 Thread Igor Murzov
Some patches to fix translations related issues + some terminology unification: * Use "directory" term everywhere, don't use "folder". * Remove stray semicolon from a control label in mpdule gadget. * Fix handling plural forms in EFM. * Gettextize MPDule and prepare it for translation. -- I

[E-devel] [PATCH][E-MODULES-EXTRA] Fix crash in news module + two minor changes

2012-10-29 Thread Igor Murzov
These patches add .gitignore to news and mpdule modules, fix crash in the news module and simplify a code a bit in the news module. -- Igor >From ada035899474107a6c83d78bcd412eba50ac5e5d Mon Sep 17 00:00:00 2001 From: Igor Murzov Date: Sun, 28 Oct 2012 18:22:10 +0400 Subject: [PATCH 3/8] news: C

Re: [E-devel] [PATCH][E] Unbreak getting Nth element from boxes.

2012-10-29 Thread Michael Blumenkrantz
this was already fixed upstream On Mon, Oct 29, 2012 at 11:43 AM, Igor Murzov wrote: > Unbreak getting Nth element from boxes. > > Fixes crashes in Places gadget. > > > -- Igor > > > -- > The Windows 8 Center - In partne

[E-devel] [PATCH][E] Unbreak getting Nth element from boxes.

2012-10-29 Thread Igor Murzov
Unbreak getting Nth element from boxes. Fixes crashes in Places gadget. -- Igor >From db253fa711e80724a4b9237ea02fa5c6e597921c Mon Sep 17 00:00:00 2001 From: Igor Murzov Date: Sun, 28 Oct 2012 16:22:15 +0400 Subject: [PATCH 2/6] Unbreak getting Nth element from boxes. Nice try zmike, but you w

Re: [E-devel] [patch][e] font and size list are not enabled even though custom font is checked

2012-10-28 Thread Hyojin Kim
Hi, I attached a wrong patch in previous mail. Please check new attached patch. Sorry for making you confuse. Hyojin Kim 2012/10/29 Hyojin Kim > Hi all, > > I resend mail with patch following guides. (thanks to Sanjeev BA) > > * Bug > In font settings, I checked "Enable Custom Font Classes"

[E-devel] [patch][e] font and size list are not enabled even though custom font is checked

2012-10-28 Thread Hyojin Kim
Hi all, I resend mail with patch following guides. (thanks to Sanjeev BA) * Bug In font settings, I checked "Enable Custom Font Classes" and set a font and size. then, when I enter font settings again, font and size list are disabled. * Causes cfdata->cur_enabled is always 0 in _basic_create_wid

Re: [E-devel] [patch][e] font, size list are not enabled even though custom font is checked.

2012-10-19 Thread Sanjeev BA
Short Answer : Patches and not zip. Longer Answer. Welcome! Read the following links. http://trac.enlightenment.org/e/wiki/ECoding http://enlightenment.org/p.php?p=contribute&l=en zip files makes it hard to see what has changed (and makes developers grumpy :) ) The common (and accepted) method

Re: [E-devel] [Patch][e] add code to handle the floating mode

2012-09-18 Thread The Rasterman
On Tue, 18 Sep 2012 05:02:54 + (GMT) Doyoun Kang said: > Dear all, > > I added code to handles the floating mode in e. > I added the structure for floating mode in E_Border structure. If an > application sets the floating mode using elm_win_floating_mode_set(), e gets > this event - ECORE_X

[E-devel] [Patch][e] add code to handle the floating mode

2012-09-17 Thread Doyoun Kang
Dear all, I added code to handles the floating mode in e. I added the structure for floating mode in E_Border structure. If an application sets the floating mode using elm_win_floating_mode_set(), e gets this event - ECORE_X_EVENT_WINDOW_PROPERTY (atom: ECORE_X_ATOM_E_ILLUME_WINDOW_STATE) - an

Re: [E-devel] [PATCH] e/modules/battery: fix double stringshare free

2012-09-10 Thread Michael Blumenkrantz
in On Sat, Sep 8, 2012 at 10:28 PM, Basil Gor wrote: > Hi, > > GET_NUM macro contained two statements, and caused double stringshare free > when used in "if" statement without brackets and condition evaluated as > false. > > e/src/modules/battery/e_mod_udev.c: > 222 if (!bat->design_char

[E-devel] [PATCH] e/modules/battery: fix double stringshare free

2012-09-08 Thread Basil Gor
Hi, GET_NUM macro contained two statements, and caused double stringshare free when used in "if" statement without brackets and condition evaluated as false. e/src/modules/battery/e_mod_udev.c: 222 if (!bat->design_charge) <-- here 223 GET_NUM(bat, design_charge, POWER_SUPPLY_CH

Re: [E-devel] [Patch][e] access module - add gesture

2012-09-02 Thread Kim Shinwoo
thanks for your response and sorry for the formatting. i will be more careful to keep the formatting. 2012/9/3 Carsten Haitzler > On Tue, 14 Aug 2012 20:48:10 +0900 Kim Shinwoo > said: > > i don't get the warning you do. no warning. it's happy. so i have no idea > why > you get your line 468 th

Re: [E-devel] [Patch][e] access module - add gesture

2012-09-02 Thread The Rasterman
On Tue, 14 Aug 2012 20:48:10 +0900 Kim Shinwoo said: i don't get the warning you do. no warning. it's happy. so i have no idea why you get your line 468 thing. but this is in svn... WITH fixes to formatting. shinwoo! you should know better! you've done better before. things like: if (a == 1 && b

Re: [E-devel] [Patch][e] access module - add gesture

2012-08-14 Thread Leif Middelschulte
2012/8/14 Tom Hacohen : > Grr, I so hate it that we don't use Elm in e (not really anyway...), > this could have done so easily with Gesture-Layer. Waiting for e18 for playing with it :) > > -- > Tom. > > On 14/08/12 14:48, Kim Shinwoo wrote: >> dear all hello, >> >> i have revised the access modul

Re: [E-devel] [Patch][e] access module - add gesture

2012-08-14 Thread Tom Hacohen
Grr, I so hate it that we don't use Elm in e (not really anyway...), this could have done so easily with Gesture-Layer. -- Tom. On 14/08/12 14:48, Kim Shinwoo wrote: > dear all hello, > > i have revised the access module and attached. you can find the following > in the patch. > >- mouse dou

[E-devel] [Patch][e] access module - add gesture

2012-08-14 Thread Kim Shinwoo
dear all hello, i have revised the access module and attached. you can find the following in the patch. - mouse double tap and move gesture for each direction - two finger flicking for each direction - two finger panning anyway would you please let me know why i got the following warring m

Re: [E-devel] [Patch][e] Bug fix for crashing enlightenment in e_gadcon.c

2012-08-09 Thread Michael Blumenkrantz
in On Thu, Aug 9, 2012 at 9:13 AM, Doyoun Kang wrote: > Dear all. > > I found the bug which may occurs enlightenment crash. > There is code to insert E_Gadcon pointer to custom_populate_requests list > in e_gadcon_custom_new(). However, there is no code to remove deleted > E_Gadcon pointer from

[E-devel] [Patch][e] Bug fix for crashing enlightenment in e_gadcon.c

2012-08-09 Thread Doyoun Kang
Dear all. I found the bug which may occurs enlightenment crash. There is code to insert E_Gadcon pointer to custom_populate_requests list in e_gadcon_custom_new(). However, there is no code to remove deleted E_Gadcon pointer from custom_populate_requests list in e_gadcon_custom_del(). So, if the

[E-devel] [PATCH] e/src/bin/e_fm_prop.c

2012-07-18 Thread rustyBSD
(re)Hi, I added time of last access in file properties. Here is a patch. It works for me, but i'm not familiar with the API, so if someone could review it... Thanks, Maxime --- e_fm_prop.c.orig 2012-07-18 15:13:42.0 +0200 +++ e_fm_prop.c 2012-07-18 15:53:28.080852267 +0200 @@ -49,7 +49,7

Re: [E-devel] [Patch][e][ibar] Add a configuration for locking icon movement

2012-07-15 Thread Michael Blumenkrantz
Hi, Is there a reason why you've set lock_move to be an int and not a bool? On Mon, Jul 16, 2012 at 7:24 AM, Doyoun Kang wrote: > Dear all. > > I added a configuration value which (un)locks icon movement in ibar > module. This will be usefull if the user doesn't want to move an icon in > iBar on

[E-devel] [Patch][e][ibar] Add a configuration for locking icon movement

2012-07-15 Thread Doyoun Kang
Dear all. I added a configuration value which (un)locks icon movement in ibar module. This will be usefull if the user doesn't want to move an icon in iBar on the Shelf. You can (un)set this value "iBar -> Settings -> Icon Movement field -> Lock Icon Move checkbox". Please review this patch.

Re: [E-devel] [Patch][e] add code to check e_config->geometry_auto_move before moving a window in e_border.c

2012-07-02 Thread The Rasterman
On Mon, 02 Jul 2012 11:49:24 + (GMT) Doyoun Kang said: yup. you're right. it should use the config val there. in svn. thanks! > Dear all. > > In e, there is a configuration value - geometry_auto_move - which determines > whether e moves the window to useful geometry automatically or not. In

[E-devel] [Patch][e] add code to check e_config->geometry_auto_move before moving a window in e_border.c

2012-07-02 Thread Doyoun Kang
Dear all. In e, there is a configuration value - geometry_auto_move - which determines whether e moves the window to useful geometry automatically or not. In my opinion, if this is 0, then e doesn't move the window automatically. However, e always moves the window automatically because there is

Re: [E-devel] patch : e desklock on sleep

2009-11-23 Thread Gustavo Sverzut Barbieri
On Sun, Nov 22, 2009 at 9:19 PM, Laurent Ghigonis wrote: > hello, > > here is a patch that adds the ability to lock the screen (via desklock) > when suspending or hibernating using e17 system controls. checkbox in > conf_desklock. > > what do you think about it ? Make e_config things unsigned cha

[E-devel] patch : e desklock on sleep

2009-11-22 Thread Laurent Ghigonis
hello, here is a patch that adds the ability to lock the screen (via desklock) when suspending or hibernating using e17 system controls. checkbox in conf_desklock. what do you think about it ? laurent Index: src/bin/e_config.c === -

Re: [E-devel] [PATCH] E: hide eina_list internals

2009-08-21 Thread Cedric BAIL
On Fri, Aug 21, 2009 at 4:22 PM, Peter van de Werken wrote: > Attached is are two patches that hides the eina_list (struct) > internals by using the eina_list methods and macros. > > The reason for two patches, is because in a couple of cases (6) I > reduced e_object_del(E_OBJECT( )) to just the e_

Re: [E-devel] [PATCH] E Button Widget

2007-10-04 Thread The Rasterman
On Tue, 18 Sep 2007 03:11:31 +0200 lok <[EMAIL PROTECTED]> babbled: > Hi, > > I've got a small problem recently on a theme. If the theme use a min > size for > it's buttons, way larger than the default theme's. It's impossible to > have the icon centered on a button with no text. (For exemple in

[E-devel] [PATCH] E Button Widget

2007-09-17 Thread lok
Hi, I've got a small problem recently on a theme. If the theme use a min size for it's buttons, way larger than the default theme's. It's impossible to have the icon centered on a button with no text. (For exemple into the File Properties dialog in EFM). Currently the button theme only know wh

Re: [E-devel] [PATCH] e ilist fix

2007-05-11 Thread The Rasterman
On Fri, 11 May 2007 19:01:32 +0200 Laurent Ghigonis <[EMAIL PROTECTED]> babbled: > Hi > > Here is a patch to fix some wrong behavior of E_Ilist and > E_Widget_Ilist. > > Each E_Wiget_Ilist has an E_Widget_Callback list, wich contains > callbacks for each item of the list. It must have the same o

[E-devel] [PATCH] e ilist fix

2007-05-11 Thread Laurent Ghigonis
Hi Here is a patch to fix some wrong behavior of E_Ilist and E_Widget_Ilist. Each E_Wiget_Ilist has an E_Widget_Callback list, wich contains callbacks for each item of the list. It must have the same order / same number of items than the real items list. And that was not the case before : now we

[E-devel] [PATCH] e-modules missing autopoint

2007-04-15 Thread Christian Wiese
Hi, as shortly discussed on the channel I was not able to build the emu, language, moon and taskbar module. The problem is the missing call of autopoint within autogen.sh. Attached is a trivial patch that solves that problem. Cheers --Chris diff -ruN e_modules.orig/emu/autogen.sh e_modules/emu/a

Re: [E-devel] [PATCH] E Protected File Registry

2006-10-16 Thread Metrics
> On Tue, Oct 10, 2006 at 07:21:14PM +1000, Metrics wrote: > > Hi all, > > > > I've attached some patches and additional files that add a protected > > file registry to E. Basically, the point of this is to protect files > > that are in use from being deleted by fm2 in its various guises. > > The

Re: [E-devel] [PATCH] E Protected File Registry

2006-10-15 Thread Metrics
Modified version of the file registry, changed a hash for a list and basically simplified it all so it now operates with ref counts. Had to make some changes to setting and unsetting default desktops, but it's for the best as it is now all in e_bg.c and consistent. Any comments...you know where to

[E-devel] [PATCH] E Protected File Registry

2006-10-10 Thread Metrics
Hi all, I've attached some patches and additional files that add a protected file registry to E. Basically, the point of this is to protect files that are in use from being deleted by fm2 in its various guises. The patch adds file protection for themes and desktops at the moment, and works reliabl

Re: [E-devel] [patch] e e_gadman.c

2005-03-13 Thread The Rasterman
On Sun, 13 Mar 2005 23:11:13 -0500 Craig Hurley <[EMAIL PROTECTED]> babbled: (B (B> I got these warnings thru -Wall (B (Booh all bad (btw - can u attach patches, not paste them inline in the mail? then (Bmailers wont do things like linewrap the patch... :) fixed anyway :) (B (B> e_gadman.c:

[E-devel] [patch] e e_gadman.c

2005-03-13 Thread Craig Hurley
I got these warnings thru -Wall e_gadman.c: In function `_e_gadman_client_overlap_deny': e_gadman.c:721: warning: `gmc2' might be used uninitialized in this function e_gadman.c:780: warning: `gmc2' might be used uninitialized in this function e_gadman.c:838: warning: `gmc2' might be used uninitial

Re: [E-devel] [PATCH] E

2005-02-18 Thread Sebastian Dransfeld
Carsten Haitzler (The Rasterman) wrote: On Thu, 17 Feb 2005 21:58:17 +0100 Tilman Sauerbeck <[EMAIL PROTECTED]> babbled: Sebastian Dransfeld <[EMAIL PROTECTED]> [2005-02-17 18:54]: Implemented desktops as a list, instead of an array. Moved e_desk_current_get, e_desk_at_xy_get to e_zone_desk_curre

Re: [E-devel] [PATCH] E

2005-02-17 Thread The Rasterman
On Thu, 17 Feb 2005 21:58:17 +0100 Tilman Sauerbeck <[EMAIL PROTECTED]> (Bbabbled: (B (B> Sebastian Dransfeld <[EMAIL PROTECTED]> [2005-02-17 18:54]: (B> > Implemented desktops as a list, instead of an array. Moved (B> > e_desk_current_get, e_desk_at_xy_get to e_zone_desk_current_get and (B

Re: [E-devel] [PATCH] E

2005-02-17 Thread Andrew Elcock
ahem!!! Sebastian Dransfeld wrote: Implemented desktops as a list, instead of an array. Moved e_desk_current_get, e_desk_at_xy_get to e_zone_desk_current_get and e_zone_desk_at_xy_get. Anyone against? YES!!! It is an array for efficiency - was decided by raster when I implemented it - we talked

Re: [E-devel] [PATCH] E

2005-02-17 Thread Tilman Sauerbeck
Sebastian Dransfeld <[EMAIL PROTECTED]> [2005-02-17 18:54]: > Implemented desktops as a list, instead of an array. Moved > e_desk_current_get, e_desk_at_xy_get to e_zone_desk_current_get and > e_zone_desk_at_xy_get. > > Anyone against? You should wait for raster and Andy to comment on this, IIR

Re: [E-devel] [PATCH] E

2005-02-17 Thread D. Hageman
I could be wrong, but I can't think of any major benefits of having it as a list. The array keeps it small in size and simple. What can a list do for it? On Thu, 17 Feb 2005, robotron:2084 wrote: On Thu, 17 Feb 2005 18:54:19 +0100, Sebastian Dransfeld <[EMAIL PROTECTED]> wrote: Implemented desk

Re: [E-devel] [PATCH] E

2005-02-17 Thread robotron:2084
On Thu, 17 Feb 2005 18:54:19 +0100, Sebastian Dransfeld <[EMAIL PROTECTED]> wrote: > Implemented desktops as a list, instead of an array. Moved > e_desk_current_get, e_desk_at_xy_get to e_zone_desk_current_get and > e_zone_desk_at_xy_get. > > Anyone against? > i am not necessarily against this mov

[E-devel] [PATCH] E

2005-02-17 Thread Sebastian Dransfeld
Implemented desktops as a list, instead of an array. Moved e_desk_current_get, e_desk_at_xy_get to e_zone_desk_current_get and e_zone_desk_at_xy_get. Anyone against? Sebastian Index: e/src/bin/e_border.c === RCS file: /cvsroot/enlig

[E-devel] [PATCH] e

2005-02-11 Thread Sebastian Dransfeld
Makes windows rember zones. If none objects I'll commit it. Sebastian Index: e_atoms.c === RCS file: /cvsroot/enlightenment/e17/apps/e/src/bin/e_atoms.c,v retrieving revision 1.6 diff -u -r1.6 e_atoms.c --- e_atoms.c 7 Feb 2005 13:51

[E-devel] [PATCH] e battery

2005-02-09 Thread Sebastian Dransfeld
Hi! Move action from Battery_Face to Battery (We only need to check the battery once, even if there are multiple faces). Clean up battery check. If nobody objects, I'll commit. Sebastian Index: e_mod_main.c === RCS file: /cvsroot/enl

[E-devel] [PATCH] e pager

2005-02-09 Thread Sebastian Dransfeld
Hi! 1. Don't return a list of pagers from the module, return a Pager. 2. Pager -> Pager_Face (like in clock and battery). 3. Config for Pager and Pager_Face 4. Menustuff 5. Added possibilities of what to do when the number of desktops change. If nobody objects, I'll commit it. Sebastian Index: e_mo

[E-devel] [PATCH] e

2005-02-09 Thread Sebastian Dransfeld
Proposal, anyone against? Remove duplicate code in e_resist.c and fixes a bug in e_module.c Sebastian Index: e/src/bin/e_module.c === RCS file: /cvsroot/enlightenment/e17/apps/e/src/bin/e_module.c,v retrieving revision 1.15 diff -u -r1

Re: [E-devel] [PATCH] e

2005-02-08 Thread The Rasterman
On Tue, 08 Feb 2005 12:38:00 +0100 Sebastian Dransfeld <[EMAIL PROTECTED]> (Bbabbled: (B (B> Hi! (B> (B> Read that e_object_del should be used instead of e_object_unref. These (B> fixes should be right. The objects are created in the .c file, and (B> deleted there. (B (Bin many, but not

[E-devel] [PATCH] e

2005-02-08 Thread Sebastian Dransfeld
Hi! Read that e_object_del should be used instead of e_object_unref. These fixes should be right. The objects are created in the .c file, and deleted there. Sebastian Index: e/src/bin/e_module.c === RCS file: /cvsroot/enlightenment/

Re: [E-devel] [PATCH] e

2005-02-07 Thread Sebastian Dransfeld
Andrew Elcock wrote: hmm - couple of comments: Sebastian Dransfeld wrote: Hi! 5. Remember sticky, shaded and maximized state. should this not be done in the same way as remembering the desktop, and managed flags? (just asking, I may be wrong) 8. When a desktop is removed, borders on that desktop

[E-devel] [PATCH] e pager

2005-02-01 Thread Sebastian Dransfeld
Hi! Fixed the pager to be one for each zone. What lacks is that e_zone_desk_count_set() should send a E_EVENT_BORDER_ADD event when a window is moved from one desk to another when a desk is removed. The second patch is some compile fixes. Sebastian Index: e/src/modules/battery/e_mod_main.c =

[E-devel] [PATCH] e

2005-01-26 Thread Sebastian Dransfeld
Hi! Just a typo. Sebastian Index: src/modules/battery/e_mod_main.c === RCS file: /cvsroot/enlightenment/e17/apps/e/src/modules/battery/e_mod_main.c,v retrieving revision 1.12 diff -u -r1.12 e_mod_main.c --- src/modules/battery/e_mod_ma

[E-devel] PATCH: E theme split

2005-01-09 Thread Arlo
I've split up the default.edc theme so people can work on components without getting in each other's way. Raster approved this scheme. (This is current and includes HandyAndE's latest pager/window update) Also, I figured out jed and was able to indent things nicely. Extract in apps/e/data/themes A