Re: [E-devel] E SVN: tasn trunk/edje/src/lib

2012-06-12 Thread Tom Hacohen
On 12/06/12 02:54, Cedric BAIL wrote: On Sun, Jun 10, 2012 at 8:14 PM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: Edje load: Although we don't use them that much, we have refcounts in evas. Don't assume an evas_object_del has to delete the object. Woot ? Why would the sub

Re: [E-devel] E SVN: tasn trunk/edje/src/lib

2012-06-12 Thread Cedric BAIL
On Tue, Jun 12, 2012 at 3:28 PM, Tom Hacohen tom.haco...@samsung.com wrote: On 12/06/12 02:54, Cedric BAIL wrote: On Sun, Jun 10, 2012 at 8:14 PM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: Edje load: Although we don't use them that much, we have refcounts in evas.  Don't

Re: [E-devel] E SVN: tasn trunk/edje/src/lib

2012-06-12 Thread Tom Hacohen
On 12/06/12 10:00, Cedric BAIL wrote: Why would he ? Seriously, nobody should refcount the child of Edje. If someone does that bad things are going to happen, like this child could be an external and trigger event in a dead parent for example. So refcounting the Edje object is fine,

Re: [E-devel] E SVN: tasn trunk/edje/src/lib

2012-06-11 Thread Cedric BAIL
On Sun, Jun 10, 2012 at 8:14 PM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: Edje load: Although we don't use them that much, we have refcounts in evas.  Don't assume an evas_object_del has to delete the object. Woot ? Why would the sub object of Edje object be refcounted ? Only

Re: [E-devel] E SVN: tasn trunk/edje/src/lib

2012-01-19 Thread Tom Hacohen
On 19/01/12 12:29, David Seikel wrote: You just broke API. Those %y1 and friends in the strings used by the _elua_scan_params() and _elua_ret() functions are the names of Lua arguments and return values. The Lua scripts expect to have these names as table fields when calling these functions.

Re: [E-devel] E SVN: tasn trunk/edje/src/lib

2012-01-19 Thread David Seikel
On Thu, 19 Jan 2012 13:30:31 +0200 Tom Hacohen tom.haco...@partner.samsung.com wrote: On 19/01/12 12:29, David Seikel wrote: You just broke API. Those %y1 and friends in the strings used by the _elua_scan_params() and _elua_ret() functions are the names of Lua arguments and return values.

Re: [E-devel] E SVN: tasn trunk/edje/src/lib

2012-01-19 Thread Tom Hacohen
On 19/01/12 14:30, David Seikel wrote: Well, the API names don't clash at all, since on the C side they only appear inside strings. The Lua side does not have posix, and the API names are namespaced in tables anyway, so no clash there either. Though there is a posix library for Lua, we

Re: [E-devel] E SVN: tasn trunk/edje/src/lib

2012-01-19 Thread David Seikel
On Thu, 19 Jan 2012 14:43:00 +0200 Tom Hacohen tom.haco...@partner.samsung.com wrote: There's another big reason for using shadow warnings and that's removing variables, I almost dismissed this reason myself, but luckily Gustavo set me straight. For example, lets assume you wrote a piece of

Re: [E-devel] E SVN: tasn trunk/edje/src/lib

2012-01-19 Thread Tom Hacohen
On 19/01/12 14:56, David Seikel wrote: In the case of y1, the difference between a function and a variable will be noticed by the compiler. It will complain anyway. Without actually looking things up, I suspect the same will apply to index. True, but that's not the point. The point is

Re: [E-devel] E SVN: tasn trunk/edje/src/lib

2012-01-19 Thread David Seikel
On Thu, 19 Jan 2012 15:01:27 +0200 Tom Hacohen tom.haco...@partner.samsung.com wrote: On 19/01/12 14:56, David Seikel wrote: In the case of y1, the difference between a function and a variable will be noticed by the compiler. It will complain anyway. Without actually looking things

Re: [E-devel] E SVN: tasn trunk/edje/src/lib

2012-01-19 Thread Tom Hacohen
On 19/01/12 15:12, David Seikel wrote: I wonder what other ultra paranoid warnings we will have to fix in the future? Is there a -Wyou-spelled-edge-wrong-you-dimwit in gcc? I've been hit by shadow bugs myself, that's why I like the warning, and others agree. Actually it was failing at the

Re: [E-devel] E SVN: tasn trunk/edje/src/lib

2012-01-19 Thread David Seikel
On Thu, 19 Jan 2012 15:19:29 +0200 Tom Hacohen tom.haco...@partner.samsung.com wrote: On 19/01/12 15:12, David Seikel wrote: I wonder what other ultra paranoid warnings we will have to fix in the future? Is there a -Wyou-spelled-edge-wrong-you-dimwit in gcc? I've been hit by shadow bugs

Re: [E-devel] E SVN: tasn trunk/edje/src/lib

2012-01-19 Thread Tom Hacohen
On 19/01/12 15:29, David Seikel wrote: Actually, I was only gonna revert the edje_lua2 part, leaving your edje_util changes as is. That file is someone elses worry, but I don't think your changes caused any problem there. Nope, no problem there. I'll re-apply that part once we decide what to

Re: [E-devel] E SVN: tasn trunk/edje/src/lib

2012-01-19 Thread David Seikel
On Thu, 19 Jan 2012 23:29:03 +1000 David Seikel onef...@gmail.com wrote: On Thu, 19 Jan 2012 15:19:29 +0200 Tom Hacohen tom.haco...@partner.samsung.com wrote: On 19/01/12 15:12, David Seikel wrote: I wonder what other ultra paranoid warnings we will have to fix in the future? Is

Re: [E-devel] E SVN: tasn trunk/edje/src/lib

2012-01-03 Thread Vincent Torri
funny that you still forget the ChangeLog updates Vincent On Tue, Jan 3, 2012 at 10:55 AM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: Edje entry: Fix undo/redo with imf.  Many thanks to Jihoon Kim and SeoZ for reporting this issue. Author:       tasn Date:         2012-01-03

Re: [E-devel] E SVN: tasn trunk/edje/src/lib

2012-01-03 Thread Tom Hacohen
On 03/01/12 11:58, Vincent Torri wrote: funny that you still forget the ChangeLog updates Ah yeah, my bad. I dunno why, I usually remember. In svn, thanks. -- Tom. -- Write once. Port to many. Get the SDK and tools

Re: [E-devel] E SVN: tasn trunk/edje/src/lib

2011-03-14 Thread Jihoon Kim
Thank you very much :) 2011. 3. 14. 오후 6:19에 Enlightenment SVN no-re...@enlightenment.org님이 작성: Log: Edje part-text: Updated docs. Author: tasn Date: 2011-03-14 02:19:05 -0700 (Mon, 14 Mar 2011) New Revision: 57733 Trac: http://trac.enlightenment.org/e/changeset/57733

Re: [E-devel] E SVN: tasn trunk/edje/src/lib

2011-03-14 Thread Tom Hacohen
Thank you for letting me know about those :) (Luckily I was bored at the airport). -- Tom. On Mon, 2011-03-14 at 18:25 +0900, Jihoon Kim wrote: Thank you very much :) -- Colocation vs. Managed Hosting A question and

Re: [E-devel] E SVN: tasn trunk/edje/src/lib

2010-09-05 Thread Vincent Torri
// need one for markup and format too - how to do it? extra type param? - static void +static void __UNUSED__ _text_filter_prepend(Entry *en, const char *text) what does that use of __UNUSED__ mean ? Vincent --

Re: [E-devel] E SVN: tasn trunk/edje/src/lib

2010-09-05 Thread Tom Hacohen
unused function. On Sun, 2010-09-05 at 09:37 +0200, Vincent Torri wrote: // need one for markup and format too - how to do it? extra type param? - static void +static void __UNUSED__ _text_filter_prepend(Entry *en, const char *text) what does that use of __UNUSED__ mean ?

Re: [E-devel] E SVN: tasn trunk/edje/src/lib

2010-09-05 Thread Vincent Torri
On Sun, 5 Sep 2010, Tom Hacohen wrote: unused function. On Sun, 2010-09-05 at 09:37 +0200, Vincent Torri wrote: // need one for markup and format too - how to do it? extra type param? - static void +static void __UNUSED__ _text_filter_prepend(Entry *en, const char *text) what does

Re: [E-devel] E SVN: tasn trunk/edje/src/lib

2010-08-10 Thread Brian Wang
Thanks! It works! On Tue, Aug 10, 2010 at 3:16 PM, Enlightenment SVN no-re...@enlightenment.org wrote: Log:  Edje: Fixed edje_object_part_text_cursor_content_get to handle non-english.  Thanks to Brian Wang for reporting. Author:       tasn Date:         2010-08-10 00:16:45 -0700 (Tue, 10

Re: [E-devel] E SVN: tasn trunk/edje/src/lib

2010-08-10 Thread Tom Hacohen
NP, and sorry for the bug :) On Tue, 2010-08-10 at 16:30 +0800, Brian Wang wrote: Thanks! It works! On Tue, Aug 10, 2010 at 3:16 PM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: Edje: Fixed edje_object_part_text_cursor_content_get to handle non-english. Thanks to Brian