[EGIT] [core/efl] master 01/01: Eina: Change from to for header inclusion
stefan pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=8f30d8a94956f7a18e4c79ea834137157adaa927
commit 8f30d8a94956f7a18e4c79ea834137157adaa927
Author: bluezery the81@samsung.com
Date: Sat Aug 2 21:09:57 2014 +0200
Eina: Change from to for header inclusion
Summary:
All eina_xxx.h are expored headers.
Using system path to search eina headers seems to be better.
Reviewers: raster, stefan_schmidt, stefan, cedric
Subscribers: stefan_schmidt, cedric
Differential Revision: https://phab.enlightenment.org/D1079
---
src/lib/eina/Eina.h | 100 ++--
1 file changed, 50 insertions(+), 50 deletions(-)
diff --git a/src/lib/eina/Eina.h b/src/lib/eina/Eina.h
index ccde5c1..bb2681e 100644
--- a/src/lib/eina/Eina.h
+++ b/src/lib/eina/Eina.h
@@ -214,56 +214,56 @@
extern C {
#endif
-#include eina_config.h
-#include eina_types.h
-#include eina_alloca.h
-#include eina_main.h
-#include eina_fp.h
-#include eina_rectangle.h
-#include eina_clist.h
-#include eina_inlist.h
-#include eina_file.h
-#include eina_list.h
-#include eina_hash.h
-#include eina_trash.h
-#include eina_lalloc.h
-#include eina_module.h
-#include eina_mempool.h
-#include eina_error.h
-#include eina_log.h
-#include eina_inarray.h
-#include eina_array.h
-#include eina_binshare.h
-#include eina_stringshare.h
-#include eina_ustringshare.h
-#include eina_magic.h
-#include eina_counter.h
-#include eina_rbtree.h
-#include eina_accessor.h
-#include eina_iterator.h
-#include eina_benchmark.h
-#include eina_convert.h
-#include eina_cpu.h
-#include eina_sched.h
-#include eina_tiler.h
-#include eina_thread.h
-#include eina_hamster.h
-#include eina_matrixsparse.h
-#include eina_str.h
-#include eina_strbuf.h
-#include eina_binbuf.h
-#include eina_ustrbuf.h
-#include eina_unicode.h
-#include eina_quadtree.h
-#include eina_simple_xml_parser.h
-#include eina_lock.h
-#include eina_prefix.h
-#include eina_refcount.h
-#include eina_mmap.h
-#include eina_xattr.h
-#include eina_value.h
-#include eina_cow.h
-#include eina_thread_queue.h
+#include eina_config.h
+#include eina_types.h
+#include eina_alloca.h
+#include eina_main.h
+#include eina_fp.h
+#include eina_rectangle.h
+#include eina_clist.h
+#include eina_inlist.h
+#include eina_file.h
+#include eina_list.h
+#include eina_hash.h
+#include eina_trash.h
+#include eina_lalloc.h
+#include eina_module.h
+#include eina_mempool.h
+#include eina_error.h
+#include eina_log.h
+#include eina_inarray.h
+#include eina_array.h
+#include eina_binshare.h
+#include eina_stringshare.h
+#include eina_ustringshare.h
+#include eina_magic.h
+#include eina_counter.h
+#include eina_rbtree.h
+#include eina_accessor.h
+#include eina_iterator.h
+#include eina_benchmark.h
+#include eina_convert.h
+#include eina_cpu.h
+#include eina_sched.h
+#include eina_tiler.h
+#include eina_thread.h
+#include eina_hamster.h
+#include eina_matrixsparse.h
+#include eina_str.h
+#include eina_strbuf.h
+#include eina_binbuf.h
+#include eina_ustrbuf.h
+#include eina_unicode.h
+#include eina_quadtree.h
+#include eina_simple_xml_parser.h
+#include eina_lock.h
+#include eina_prefix.h
+#include eina_refcount.h
+#include eina_mmap.h
+#include eina_xattr.h
+#include eina_value.h
+#include eina_cow.h
+#include eina_thread_queue.h
#ifdef __cplusplus
}
--
Re: [E-devel] [EGIT] [core/elementary] master 01/01: map: Add missing legacy API into legacy header
OK, it's temporary fix. I will add it into EO class ASAP. :) 2014-07-22 17:14 GMT+09:00 Carsten Haitzler ras...@rasterman.com: On Tue, 22 Jul 2014 09:14:15 +0300 Daniel Zaoui daniel.za...@samsung.com said: Hi Tae-Hwan, I don't think it is the good fix. The .eo file should describe this function, so Eolian could generate the legacy header for free. Well, I have to admit I may have forgot this function during the porting :-) for now this will do.. until it goes into the eo file. :) D2, alias me. On 07/22/2014 08:35 AM, Tae-Hwan Kim wrote: raster pushed a commit to branch master. http://git.enlightenment.org/core/elementary.git/commit/?id=cfdaffb8cf65ab0a934de2efb513e66989b4bad6 commit cfdaffb8cf65ab0a934de2efb513e66989b4bad6 Author: Tae-Hwan Kim the81@samsung.com Date: Tue Jul 22 14:14:34 2014 +0900 map: Add missing legacy API into legacy header Summary: @fix Reviewers: raster Reviewed By: raster Differential Revision: https://phab.enlightenment.org/D1164 --- src/lib/elm_map_legacy.h | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/src/lib/elm_map_legacy.h b/src/lib/elm_map_legacy.h index ca34589..4c7aff2 100644 --- a/src/lib/elm_map_legacy.h +++ b/src/lib/elm_map_legacy.h @@ -10,4 +10,22 @@ */ EAPI Evas_Object *elm_map_add(Evas_Object *parent); -#include elm_map.eo.legacy.h \ No newline at end of file +/** + * @internal + * + * @brief Requests a list of addresses corresponding to a given name. + * + * @since 1.8 + * + * @remarks This is used if you want to search the address from a name. + * + * @param obj The map object + * @param address The address + * @param name_cb The callback function + * @param data The user callback data + * + * @ingroup Map + */ +EAPI void elm_map_name_search(const Evas_Object *obj, const char *address, Elm_Map_Name_List_Cb name_cb, void *data); + +#include elm_map.eo.legacy.h -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- BRs, Kim. -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[EGIT] [core/efl] master 01/01: configure.ac: Remove obsolete macros
raster pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=368058cdc71e6f8f042f6326d01e0b3327c6e744
commit 368058cdc71e6f8f042f6326d01e0b3327c6e744
Author: bluezery ohpo...@gmail.com
Date: Thu Jul 3 17:32:10 2014 +0900
configure.ac: Remove obsolete macros
Summary:
AC_HELP_STRING -- AS_HELP_STRING
AC_TRY_COMPILE -- AC_COMPILE_IFELSE + AC_LAGN_PROGRAM
those are deprecated for almost 10 years
autoupdate tool do this automatcally.
@fix
Reviewers: raster, cedric, stefan_schmidt
CC: cedric
Differential Revision: https://phab.enlightenment.org/D1088
---
configure.ac | 178 +--
1 file changed, 63 insertions(+), 115 deletions(-)
diff --git a/configure.ac b/configure.ac
index 9ca05dc..69cd418 100644
--- a/configure.ac
+++ b/configure.ac
@@ -32,7 +32,7 @@ EFL_ENABLE_EO_API_SUPPORT
EFL_ENABLE_BETA_API_SUPPORT
AC_ARG_WITH([api],
- [AC_HELP_STRING([--with-api=@:@eo/legacy/both@:@], [Select the EFL API
Model @:@default=both@:@])],
+ [AS_HELP_STRING([--with-api=@:@eo/legacy/both@:@],[Select the EFL API
Model @:@default=both@:@])],
[efl_api=${withval}],
[efl_api=both])
@@ -59,8 +59,7 @@ AC_SUBST(EFL_API_EO_DEF)
# string to identify the build
AC_ARG_WITH([id],
- [AC_HELP_STRING([--with-id=BUILD_ID],
- [Specify a string to identify the build (vendor,
maintainer, etc).
+ [AS_HELP_STRING([--with-id=BUILD_ID],[Specify a string to identify the
build (vendor, maintainer, etc).
@:@default=none@:@])],
[EFL_BUILD_ID=${withval}],
[EFL_BUILD_ID=none])
@@ -68,8 +67,7 @@ AC_SUBST(EFL_BUILD_ID)
# profile
AC_ARG_WITH([profile],
- [AC_HELP_STRING([--with-profile=PROFILE],
- [use the predefined build profile, one of: dev, debug and
release.
+ [AS_HELP_STRING([--with-profile=PROFILE],[use the predefined build profile,
one of: dev, debug and release.
@:@default=dev@:@])],
[build_profile=${withval}],
[build_profile=def_build_profile])
@@ -92,8 +90,7 @@ esac
# TODO: add some build profile (server, full, etc...)
AC_ARG_WITH([crypto],
- [AC_HELP_STRING([--with-crypto=CRYPTO],
- [use the predefined build crypto, one of:
+ [AS_HELP_STRING([--with-crypto=CRYPTO],[use the predefined build crypto,
one of:
openssl, gnutls or none.
@:@default=openssl@:@])],
[build_crypto=${withval}],
@@ -108,8 +105,7 @@ case ${build_crypto} in
esac
AC_ARG_WITH([tests],
- [AC_HELP_STRING([--with-tests=none|regular|coverage],
- [choose testing method: regular, coverage or none.
+ [AS_HELP_STRING([--with-tests=none|regular|coverage],[choose testing
method: regular, coverage or none.
@:@default=none@:@])],
[build_tests=${withval}],
[build_tests=auto])
@@ -138,8 +134,7 @@ esac
dbusservicedir=${datadir}/dbus-1/services
AC_ARG_WITH([dbus-services],
- [AC_HELP_STRING([--with-dbus-services=DBUS_SERVICES],
- [specify a directory to store dbus service files.])],
+ [AS_HELP_STRING([--with-dbus-services=DBUS_SERVICES],[specify a directory
to store dbus service files.])],
[dbusservicedir=$withval])
AC_SUBST(dbusservicedir)
@@ -366,8 +361,7 @@ AM_CONDITIONAL([HAVE_CRYPTO_OPENSSL], [test
${build_crypto} = openssl])
# check for lua old
want_lua_old=no
AC_ARG_ENABLE([lua-old],
- [AC_HELP_STRING([--enable-lua-old],
- [Enable interpreted Lua support (5.1 or 5.2).
@:@default=disabled@:@])],
+ [AS_HELP_STRING([--enable-lua-old],[Enable interpreted Lua support (5.1 or
5.2). @:@default=disabled@:@])],
[
if test x${enableval} = xyes ; then
want_lua_old=yes
@@ -448,10 +442,8 @@ case ${build_profile} in
AC_MSG_CHECKING([whether -Wshadow generates spurious warnings])
CFLAGS_save=${CFLAGS}
CFLAGS=${CFLAGS} -Werror -Wshadow
- AC_TRY_COMPILE([int x;], [int x = 0; (void)x;],
- [AC_MSG_RESULT([no])
-EFL_CHECK_COMPILER_FLAGS([EFL], [-Wshadow])],
- [AC_MSG_RESULT([yes])])
+ AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[int x;]], [[int x = 0;
(void)x;]])],[AC_MSG_RESULT([no])
+EFL_CHECK_COMPILER_FLAGS([EFL], [-Wshadow])],[AC_MSG_RESULT([yes])])
CFLAGS=${CFLAGS_save}
;;
@@ -477,7 +469,7 @@ build_cpu_neon=no
want_neon=yes
AC_ARG_ENABLE([neon],
- [AC_HELP_STRING([--disable-neon], [disable neon support
@:@default=enable@:@])],
+ [AS_HELP_STRING([--disable-neon],[disable neon support
@:@default=enable@:@])],
[
if test x${enableval} = xyes; then
want_neon=yes
@@ -555,15 +547,12 @@ case $host_cpu in
AC_MSG_CHECKING([whether to use NEON instructions])
CFLAGS_save=${CFLAGS}
CFLAGS=${CFLAGS} -mfpu=neon -ftree-vectorize
- AC_TRY_COMPILE([#include arm_neon.h],
- [asm volatile (vqadd.u8 d0, d1, d0\n
[EGIT] [core/elementary] master 01/01: elm_map: Add new elm_map_region_zoom_bring_in() API
raster pushed a commit to branch master.
http://git.enlightenment.org/core/elementary.git/commit/?id=84c2351bc339eca22acb79c86acbee7a1322f8c0
commit 84c2351bc339eca22acb79c86acbee7a1322f8c0
Author: bluezery ohpo...@gmail.com
Date: Wed May 28 17:08:00 2014 +0900
elm_map: Add new elm_map_region_zoom_bring_in() API
Summary:
By using this API, we can do region show bring in concurrently.
This needs some tuning more because some main layouting logic in map
needs to be modified to support more smooth animation.
I will spare my time to do that later.
@feature
Reviewers: Hermet, raster, stefan_schmidt
Reviewed By: raster
CC: Jaehyun
Differential Revision: https://phab.enlightenment.org/D887
---
src/bin/test_map.c | 7
src/lib/elm_map.c| 88 +---
src/lib/elm_map.eo | 20 +++
src/lib/elm_widget_map.h | 7 ++--
4 files changed, 115 insertions(+), 7 deletions(-)
diff --git a/src/bin/test_map.c b/src/bin/test_map.c
index 07da09a..108eb7a 100644
--- a/src/bin/test_map.c
+++ b/src/bin/test_map.c
@@ -488,6 +488,12 @@ _bring_seoul(void *data, Evas_Object *obj EINA_UNUSED,
void *event_info EINA_UNU
}
static void
+_bring_zoom_suwon(void *data, Evas_Object *obj EINA_UNUSED, void *event_info
EINA_UNUSED)
+{
+ elm_map_region_zoom_bring_in(data, 16, 126.977969, 37.566535);
+}
+
+static void
_paused_set(void *data, Evas_Object *obj EINA_UNUSED, void *event_info
EINA_UNUSED)
{
elm_map_paused_set(data, EINA_TRUE);
@@ -770,6 +776,7 @@ _submenu_move_add(void *data, Elm_Object_Item *parent)
if ((!data) || (!parent)) return;
elm_menu_item_add(menu, parent, NULL, Show Urmatt, _show_urmatt, data);
elm_menu_item_add(menu, parent, NULL, Bring Seoul, _bring_seoul, data);
+ elm_menu_item_add(menu, parent, NULL, Zoom Bring Suwon,
_bring_zoom_suwon, data);
}
diff --git a/src/lib/elm_map.c b/src/lib/elm_map.c
index 393ba8d..d660874 100644
--- a/src/lib/elm_map.c
+++ b/src/lib/elm_map.c
@@ -26,6 +26,8 @@
#define DEFAULT_TILE_SIZE 256
#define MARER_MAX_NUMBER 30
#define OVERLAY_GROUPING_SCALE 2
+#define ZOOM_ANIM_CNT 75
+#define ZOOM_BRING_CNT 80
#define CACHE_ROOT /elm_map
#define CACHE_TILE_ROOTCACHE_ROOT /%d/%d/%d
@@ -1135,7 +1137,7 @@ _zoom_anim_cb(void *data)
{
ELM_MAP_DATA_GET(data, sd);
- if (sd-ani.cnt = 0)
+ if (sd-ani.zoom_cnt = 0)
{
sd-zoom_animator = NULL;
evas_object_smart_changed(sd-pan_obj);
@@ -1145,8 +1147,8 @@ _zoom_anim_cb(void *data)
}
else
{
-sd-ani.zoom += sd-ani.diff;
-sd-ani.cnt--;
+sd-ani.zoom += sd-ani.zoom_diff;
+sd-ani.zoom_cnt--;
_zoom_do(sd, sd-ani.zoom);
return ECORE_CALLBACK_RENEW;
@@ -1160,13 +1162,83 @@ _zoom_with_animation(Elm_Map_Data *sd,
{
if (cnt == 0) return;
- sd-ani.cnt = cnt;
+ sd-ani.zoom_cnt = cnt;
sd-ani.zoom = sd-zoom;
- sd-ani.diff = (double)(zoom - sd-zoom) / cnt;
+ sd-ani.zoom_diff = (double)(zoom - sd-zoom) / cnt;
ecore_animator_del(sd-zoom_animator);
sd-zoom_animator = ecore_animator_add(_zoom_anim_cb, sd-obj);
}
+static Eina_Bool
+_zoom_bring_anim_cb(void *data)
+{
+ ELM_MAP_DATA_GET(data, sd);
+
+ if ((sd-ani.zoom_cnt = 0) (sd-ani.region_cnt = 0))
+ {
+sd-zoom_animator = NULL;
+
+evas_object_smart_changed(sd-pan_obj);
+_calc_job(sd);
+
+return ECORE_CALLBACK_CANCEL;
+ }
+ else
+ {
+Evas_Coord x, y, w, h;
+if (sd-ani.zoom_cnt 0)
+ {
+ sd-ani.zoom += sd-ani.zoom_diff;
+ _zoom_do(sd, sd-ani.zoom);
+ sd-ani.zoom_cnt--;
+ }
+if (sd-ani.region_cnt 0)
+ {
+ sd-ani.lon += sd-ani.lon_diff;
+ sd-ani.lat += sd-ani.lat_diff;
+
+ _region_to_coord_convert
+(sd, sd-ani.lon, sd-ani.lat, sd-size.w, x, y);
+ _viewport_coord_get(sd, NULL, NULL, w, h);
+ x = x - (w / 2);
+ y = y - (h / 2);
+ eo_do(sd-obj, elm_interface_scrollable_content_region_show(x, y,
w, h));
+ sd-ani.region_cnt--;
+ }
+
+return ECORE_CALLBACK_RENEW;
+ }
+}
+
+static void
+_zoom_bring_with_animation(Elm_Map_Data *sd,
+ double zoom,
+ double lon,
+ double lat,
+ int zoom_cnt,
+ int region_cnt)
+{
+ double tlon, tlat;
+ Evas_Coord vx, vy, vw, vh;
+ if ((zoom_cnt == 0) (region_cnt == 0)) return;
+
+ sd-ani.zoom_cnt = zoom_cnt;
+ sd-ani.zoom = sd-zoom;
+ sd-ani.zoom_diff = (double)(zoom - sd-zoom) / zoom_cnt;
+
+ sd-ani.region_cnt = region_cnt;
+ _viewport_coord_get(sd, vx, vy, vw, vh);
+ _coord_to_region_convert
+ (sd, vx + vw / 2, vy + vh / 2, sd
Re: [E-devel] Elm window resize
2014. 5. 21. 오전 9:05에 David Seikel onef...@gmail.com님이 작성: On Wed, 21 May 2014 08:50:04 +0900 (KST) ChunEon Park her...@naver.com wrote: naviframe set the min size with the top item content min size. Ah so it's something else that is setting it's min size wrong then. I should make some test code and lodge a proper bug report. -Regards, Hermet- -Original Message- From: David Seikelonef...@gmail.com To: enlightenment-devel@lists.sourceforge.net; Cc: Sent: 2014-05-20 (화) 16:11:59 Subject: Re: [E-devel] Elm window resize On Tue, 20 May 2014 15:50:54 +0900 Carsten Haitzler (The Rasterman) raster@rasterman.com wrote: On Mon, 19 May 2014 23:40:13 +0100 Andrew Williams andy@andywilliams.me said: Hi guys, After opening this task about indow sizes in elm not respecting the scale set: https://phab.enlightenment.org/T1263 I realised that these are all set through evas_object_resize which clearly cannot know about elm scaling. Would there be any objection to creating an elm_win_resize or elm_win_size_set method that were to apply the scaling to the values beffore passing back to evas resize? Let me know equally if I've missed something but the elm_test code is all this way too. not so simple. as daniel mentioned.. this is doable with a resize multipling by scale... what we are currently missign in elm is 2 things. 1. a nice simple way to add extra minimum sizing to a widget. currently the ADVICE it so make a table, put an invisible rect in the 0,0 1x1 cell ANd your real widget in the same cell. set a min size hint on the rect and presto - it acts as an extra control on the table and thus your widget (set widget to fill/expand). you can set the min size and multiple by scaling if you want. it'd be likely useful if this trick were formalised into a widget and/or some utility func. a simple elc_ thing to wrap this up would work - then if it scales the min size by scale factor or also put in finger size. and 2. more your focus - though #1 often is related. you want a *PREFERRED* size for an object - an initial size that is possibly bigger than min size and less than max - somewhere in between. believe it or not we have a request size which is kind of intended for exactly this. what we DON'T have is logic in elm that... * watches for changes in preferred size and if 0x0, just like min size, propagates preferred size to a parent widget. * that takes preferred size once it propagates to the window and on first show actually resizes to that size * code that might set preferred size AND account for scaling reality is that you have a window where some widget (or widgets) - eg the text entry, is what you want to have at a preferred size on start... not the window as a whole, so you really want this propagation. it requires the same calcs as min - but providing preferred size as if it were min, then passing onto parent etc. ... this is what we really want. problem is - we haven't done it yet. this is the solution we want... not elm_win_reisze (that uses scaling) which is just as much a workaround as evas_object_resize on the window itself :) Yes, I agree with that, Elm handling of minimum sizes seems to be almost entirely lacking or broken. In particular I've stumbled on entrys and naviframes seem to set their minimum width to what ever you set the original width to, but their minimum height to zero. evas object size hint min set is there. but almost elm widget (e.g. container) does not respect it for their own. some container can respect their children's min size and change their min size coincidently. but so instead of adding new API, how about add size hints set evas eo class function so elm widget including elm_win can inherit and override it for their purpose? -- A big old stinking pile of genius that no one wants coz there are too many silver coated monkeys in the world. -- Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled scalability from the best Selenium testing platform available Simple to use. Nothing to install. Get started now for free. http://p.sf.net/sfu/SauceLabs ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled scalability from the best Selenium testing platform available
Re: [E-devel] Elm_Widget_Item on_deletion property
2014. 5. 13. 오후 6:56에 Yossi Kantor yossi.kan...@samsung.com님이 작성: With pleasure ! (Muahahah.) Thanks! On 05/13/2014 11:58 AM, ChunEon Park wrote: remove it! -Regards, Hermet- -Original Message- From: Yossi Kantoryossi.kan...@samsung.com To: Enlightenment developer list enlightenment-devel@lists.sourceforge.net; Cc: Sent: 2014-05-13 (화) 17:26:22 Subject: [E-devel] Elm_Widget_Item on_deletion property Hello, Elm_Widget_Item struct has a property boolean on_deletion. It is set to TRUE only once when item is deleted and freed. Its checked for not TRUE(OR_RETURN) on (almost) each modifying function. I looked around the code and found no other references for it. Since the item is freed right after setting this value in the same function, this property and it checks look redundant even for thread safety. So unless I am missing something I'd like to remove it (In a new eo interface). yes that is a workaround code. Eo can replace it. Tnx, Yossi. -- Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled scalability from the best Selenium testing platform available Simple to use. Nothing to install. Get started now for free. http://p.sf.net/sfu/SauceLabs ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled scalability from the best Selenium testing platform available Simple to use. Nothing to install. Get started now for free. http://p.sf.net/sfu/SauceLabs ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled scalability from the best Selenium testing platform available Simple to use. Nothing to install. Get started now for free. http://p.sf.net/sfu/SauceLabs ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled scalability from the best Selenium testing platform available Simple to use. Nothing to install. Get started now for free. http://p.sf.net/sfu/SauceLabs ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[EGIT] [core/efl] master 01/01: edje: Remove build warnning by clang
seoz pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=785cdcf689c29f8ec64544c729b981c931bc5ed3
commit 785cdcf689c29f8ec64544c729b981c931bc5ed3
Author: bluezery ohpo...@gmail.com
Date: Fri Apr 25 14:27:15 2014 +0900
edje: Remove build warnning by clang
Summary:
This can fix below warning:
bin/edje/edje_cc_handlers.c:9839:42: warning: equality comparison with
extraneous parentheses [-Wparentheses-equality]
Reviewers: raster, cedric, seoz
Reviewed By: seoz
CC: cedric
Differential Revision: https://phab.enlightenment.org/D792
---
src/bin/edje/edje_cc_handlers.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/bin/edje/edje_cc_handlers.c b/src/bin/edje/edje_cc_handlers.c
index 829c465..b285029 100644
--- a/src/bin/edje/edje_cc_handlers.c
+++ b/src/bin/edje/edje_cc_handlers.c
@@ -9836,7 +9836,7 @@ st_collections_group_programs_program_transition(void)
current_program-tween.v1 = FROM_DOUBLE(parse_float_range(2, 0.0,
9.0));
current_program-tween.v2 = FROM_DOUBLE(parse_float_range(3, 0.0,
9.0));
}
- else if ((current_program-tween.mode == EDJE_TWEEN_MODE_CUBIC_BEZIER))
+ else if (current_program-tween.mode == EDJE_TWEEN_MODE_CUBIC_BEZIER)
{
if ((get_arg_count() == 7) (!strcmp(parse_str(4), CURRENT)))
current_program-tween.mode |= EDJE_TWEEN_MODE_OPT_FROM_CURRENT;
--
Re: [E-devel] Korea e dinner
I got an another appointment next Saturday :-( 2014-04-04 9:27 GMT+09:00 ChunEon Park her...@naver.com: next saturday? 6:00 Itaewon good. -Regards, Hermet- -Original Message- From: Carsten Haitzlerras...@rasterman.com To: Cedric BAILcedric.b...@free.fr; Cc: E Usersenlightenment-us...@lists.sourceforge.net; e-devel enlightenment-devel@lists.sourceforge.net; Sent: 2014-04-03 (목) 16:58:11 Subject: Re: [E-devel] Korea e dinner On Thu, 3 Apr 2014 16:42:29 +0900 Cedric BAIL cedric.bail@free.fr said: Cedric Bail On Apr 3, 2014 4:24 PM, Carsten Haitzler raster@rasterman.com wrote: On Thu, 3 Apr 2014 11:47:30 +0900 Cedric BAIL cedric.bail@free.fr said: Hello, As most of you know by now, I will move to France for some time in a little bit more than a week or so. So let's have a farewell Korea e dinner on Saturday 12 ! So what time (late afternoon? Dinner? ) and where? 7. itaewon of course! :) So unexpected! Maybe a little bit earlier? 6:07. itaewon! :) -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- BRs, Kim. -- ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/efl] master 01/01: Add new PLUGIN_RUN action type and new plugins.plugin handlers 1. If external library is commerical source and not opensource, we cannot include/build the
I should use arc diff --edit --update D588 to update git commit message
instead of git commit --amend arc diff --update D643 :-(
I updated documentation:
https://phab.enlightenment.org/w/arcanist/
2014-03-20 13:42 GMT+09:00 Daniel Juyung Seo seojuyu...@gmail.com:
Wow this is the longest commit summary line among all the commits I have
seen these days.
Daniel Juyung Seo (SeoZ)
On Thu, Mar 20, 2014 at 1:01 PM, Tae-Hwan Kim the81@samsung.com
wrote:
raster pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=3061a706c4ca02eb876799da07dae72c24cf4507
commit 3061a706c4ca02eb876799da07dae72c24cf4507
Author: Tae-Hwan Kim the81@samsung.com
Date: Thu Mar 20 13:00:20 2014 +0900
Add new PLUGIN_RUN action type and new plugins.plugin handlers 1. If
external library is commerical source and not opensource, we cannot
include/build the library within edje. 2. If external library does not
use
general encodable sources, we...
Summary:
...cannot encode those things into edje.
In our case, we need vibration when longpressed. But those files are
not
audio or image and cannot be encoded into edje. Also, this library is
not
opensource so should not be linked directly with edje.
So we should call vibration API by using this plug-in.
Reviewers: raster, cedric, seoz, Hermet
CC: cedric
Differential Revision: https://phab.enlightenment.org/D588
---
data/edje/include/edje.inc | 1 +
src/bin/edje/edje_cc.c | 7 ++
src/bin/edje/edje_cc.h | 1 +
src/bin/edje/edje_cc_handlers.c | 158
+++-
src/bin/edje/edje_cc_out.c | 101 +
src/bin/edje/edje_decc.c| 43 +++
src/bin/edje/edje_pick.c| 103 +-
src/lib/edje/Edje_Common.h | 3 +-
src/lib/edje/edje_data.c| 21 ++
src/lib/edje/edje_embryo.c | 22 ++
src/lib/edje/edje_load.c| 16
src/lib/edje/edje_multisense.c | 13
src/lib/edje/edje_private.h | 19 +
src/lib/edje/edje_program.c | 5 ++
14 files changed, 509 insertions(+), 4 deletions(-)
diff --git a/data/edje/include/edje.inc b/data/edje/include/edje.inc
index 828380b..0d29c0b 100644
--- a/data/edje/include/edje.inc
+++ b/data/edje/include/edje.inc
@@ -237,6 +237,7 @@ native get_state_val(part_id, State_Param:p, ...);
/* Multisense */
native play_sample (sample_name[], Float:speed, ...);
native play_tone(tone_name[], Float:duration, ...);
+native play_vibration (sample_name[], ...);
/***/
/* Edje physics calls. */
diff --git a/src/bin/edje/edje_cc.c b/src/bin/edje/edje_cc.c
index 422ff67..5f36270 100644
--- a/src/bin/edje/edje_cc.c
+++ b/src/bin/edje/edje_cc.c
@@ -13,6 +13,7 @@ static void main_help(void);
Eina_Prefix *pfx = NULL;
Eina_List *snd_dirs = NULL;
+Eina_List *vibration_dirs = NULL;
Eina_List *img_dirs = NULL;
Eina_List *fnt_dirs = NULL;
Eina_List *data_dirs = NULL;
@@ -91,6 +92,7 @@ main_help(void)
-id image/directory Add a directory to look in for relative
path images\n
-fd font/directory Add a directory to look in for relative
path fonts\n
-sd sound/directory Add a directory to look in for relative
path sounds samples\n
+ -vd vbiration/directory Add a directory to look in for relative
path vibration samples\n
-dd data/directory Add a directory to look in for relative
path data.file entries\n
-td temp/directory Directory to store temporary files\n
-l license Specify the license of a theme\n
@@ -188,6 +190,11 @@ main(int argc, char **argv)
i++;
snd_dirs = eina_list_append(snd_dirs, argv[i]);
}
+else if ((!strcmp(argv[i], -vd) || !strcmp(argv[i],
--vibration_dir)) (i (argc - 1)))
+ {
+ i++;
+ vibration_dirs = eina_list_append(vibration_dirs, argv[i]);
+ }
else if ((!strcmp(argv[i], -dd) || !strcmp(argv[i],
--data_dir)) (i (argc - 1)))
{
i++;
diff --git a/src/bin/edje/edje_cc.h b/src/bin/edje/edje_cc.h
index 48bb023..226c455 100644
--- a/src/bin/edje/edje_cc.h
+++ b/src/bin/edje/edje_cc.h
@@ -222,6 +222,7 @@ extern Eina_List *ext_dirs;
extern Eina_List *img_dirs;
extern Eina_List *fnt_dirs;
extern Eina_List *snd_dirs;
+extern Eina_List *vibration_dirs;
extern Eina_List *data_dirs;
extern char *file_in;
extern char *tmp_dir;
diff --git
Re: [E-devel] [EGIT] [core/elementary] master 01/01: elementary/widget - introduce elm_object_item_object_get().
Actually I want to discuss about this kinds of APIs for long time ago.
http://sourceforge.net/mailarchive/message.php?msg_id=31297258
But nobody is interested in this. ;-(
This API is dangerous but the root cause was from App. developers.
For the genlist/gengrid cases, App can use realized/unrealized callback for
checking evas object of the object item.
2013/9/2 ChunEon Park her...@naver.com
I think figuring out the items geometry can be one of the common scenarios
in app side.
This is already raised before but nobody answered solution properly as far
as I remember.
My conclusion is, this is a fight between flexibilty and stable
For stable, we don't provide that api.
But i don't think this gurantee application stable and developers satisfy.
Maybe this may cause them painful to find out proper solutions and they
may try more dangerous and difficult method in worse case.
This causes app go around too much.
And we don't need to make app developers hard to make it.
-Regards, Hermet-
-Original Message-
From: Tom Hacohentom.haco...@samsung.com
To: Enlightenment developer list
enlightenment-devel@lists.sourceforge.net;
Cc:
Sent: 2013-09-02 (월) 18:20:35
Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01:
elementary/widget - introduce elm_object_item_object_get().
I have to side with Mike here. Both the decision process and the
solution smell badly. Worse than Mike's tuna breakfasts.
--
Tom.
On 02/09/13 09:48, ChunEon Park wrote:
If they know what they are doing exactly, then it won' t be problem.
This gives the applications a chance to decorate their appilcation
easily.
-Regards, Hermet-
-Original Message-
From: Michael Blumenkrantzmichael.blumenkrantz@gmail.com
To: Enlightenment developer listenlightenment-devel@
lists.sourceforge.net;
Cc:
Sent: 2013-09-02 (월) 17:29:41
Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01:
elementary/widget - introduce elm_object_item_object_get().
so wait a minute...everyone fights against this for literally over a
year,
and now it gets in without further discussion because applications
require
it seriously?
On Mon, Sep 2, 2013 at 9:25 AM, ChunEon Park - Enlightenment Git
no-re...@enlightenment.org wrote:
hermet pushed a commit to branch master.
commit ddc3cf80ce0a50a9161fcb212d3414f5d7b5898c
Author: ChunEon Park hermet@hermet.pe.kr
Date: Mon Sep 2 17:19:36 2013 +0900
elementary/widget - introduce elm_object_item_object_get().
We've countered application's requirements multiple times to they
have
the object handle from the elm_object_item.
Now we introduce it for their convenient but they should use it
carefully.
---
ChangeLog 6 +-
NEWS1 +
src/lib/elm_main.c 6 ++
src/lib/elm_object_item.h 19 +++
src/lib/elm_removed.h 15 +--
src/lib/elm_widget.c7 +++
src/lib/elm_widget.h1 +
7 files changed, 40 insertions(+), 15 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 4c59fdc..1695f01 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1578,6 +1578,10 @@
* Gengrid: implement selectraise feature.
-2013-08-28 DAniel Juyung Seo (SeoZ)
+2013-08-28 Daniel Juyung Seo (SeoZ)
* Bg: Add bg reset feature.
+
+2013-09-02 ChunEon Park (Hermet)
+
+* Widget: Introduce elm_object_item_object_get() API.
diff --git a/NEWS b/NEWS
index c2056f3..c6046bd 100644
--- a/NEWS
+++ b/NEWS
@@ -85,6 +85,7 @@ Additions:
* Add elm_win_focus_highlight_animate_set/get().
* Add selectraise feature to gengrid.
* Add bg reset feature.
+ * Add elm_object_item_object_get().
Improvements:
diff --git a/src/lib/elm_main.c b/src/lib/elm_main.c
index 2fa2ea0..9f138b2 100644
--- a/src/lib/elm_main.c
+++ b/src/lib/elm_main.c
@@ -1859,3 +1859,9 @@ elm_object_item_cursor_engine_only_get(const
Elm_Object_Item *it)
{
return elm_widget_item_cursor_engine_only_get(it);
}
+
+EAPI const Evas_Object *
+elm_object_item_object_get(const Elm_Object_Item *it)
+{
+ return _elm_widget_item_object_get((Elm_Widget_Item*)it);
+}
diff --git a/src/lib/elm_object_item.h b/src/lib/elm_object_item.h
index 8a0ccde..f256a63 100644
--- a/src/lib/elm_object_item.h
+++ b/src/lib/elm_object_item.h
@@ -34,6 +34,25 @@ typedef void
(*Elm_Object_Item_Signal_Cb)(void *data, Elm_Objec
EAPI Evas_Object *elm_object_item_widget_get(const
Elm_Object_Item *it);
/**
+ * Get the object item's internal object handle.
+ *
+ * @param it The Elementary object item
+ * @return The Internal object of the object item.
+ *
+ * @note This function should only be used if you really need to refer
the
Re: [E-devel] [EGIT] [core/elementary] master 02/02: genlist: implement list position signals.
Hello,
Are there any performance issue to adding signals?
odd/even already seems to has performance/memory consumption issue.
Adding more group name or alias into theme can increase memory when edje is
loaded even though that group is not used.
Eventhough performance issue is not signicant by emitting signals, it
decrease performance somewhat anyway.
Below features can be implemented on the theme itself actually and
application can emit signals on realized callback. Application have to do
more things but this has no performance/memory issues.
And those are implemented already and will be submitted to Tizen 3.0
Brs,
Kim.
=
barbieri pushed a commit to branch master.
commit b40a6eb85bf44acf8757507bf02e4110ca22e2a0
Author: Gustavo Sverzut Barbieri barbieri@...
Date: Thu Aug 22 17:00:26 2013 -0300
genlist: implement list position signals.
Genlist will now emit the following signals to item view related to
their position in the whole list:
- elm,state,list,first: first item of the whole list
- elm,state,list,last: last item of the whole list
- elm,state,list,middle: any item that is not first or last.
- elm,state,list,single: when the item is the only element of
list.
And the following related to a group (considering its given 'parent'):
- elm,state,group,first: first item of the group
- elm,state,group,last: last item of the group
- elm,state,group,middle: any item that is not first or last.
- elm,state,group,single: when the item is the only element of
group.
Unlike odd/even the signals have an extra namespace list or group
to avoid conflicts with applications that may have declared these
signals themselves for other purposes.
With this patch one can implement easily something like this:
https://developer.apple.com/library/ios/documentation/userexperience/conceptual/tableview_iphone/Art/tv_grouped_style.jpg
---
src/lib/elm_genlist.c | 75
+--
1 file changed, 73 insertions(+), 2 deletions(-)
diff --git a/src/lib/elm_genlist.c b/src/lib/elm_genlist.c
index d76a1c6..904b502 100644
--- a/src/lib/elm_genlist.c
+++ b/src/lib/elm_genlist.c
@@ -792,11 +792,13 @@ _item_tree_effect_finish(Elm_Genlist_Smart_Data *sd)
static void
_elm_genlist_item_position_state_update(Elm_Gen_Item *it)
{
+ unsigned idx = it-item-order_num_in;
+
ELM_GENLIST_DATA_GET_FROM_ITEM(it, sd);
if (!it-item-nostacking)
{
-if ((it-item-order_num_in 0x1) ^ it-item-stacking_even)
+if ((idx 0x1) ^ it-item-stacking_even)
{
if (it-deco_all_view)
evas_object_stack_below(it-deco_all_view, sd-stack[0]);
else evas_object_stack_below(VIEW(it), sd-stack[0]);
@@ -808,7 +810,7 @@ _elm_genlist_item_position_state_update(Elm_Gen_Item
*it)
}
}
- if (it-item-order_num_in 0x1)
+ if (idx 0x1)
{
edje_object_signal_emit(VIEW(it), elm,state,odd, elm);
if (it-deco_all_view)
@@ -820,6 +822,62 @@ _elm_genlist_item_position_state_update(Elm_Gen_Item
*it)
if (it-deco_all_view)
edje_object_signal_emit(it-deco_all_view, elm,state,even,
elm);
}
+
+ if (sd-item_count == 1)
+ {
+edje_object_signal_emit(VIEW(it), elm,state,list,single, elm);
+if (it-deco_all_view)
+ edje_object_signal_emit(it-deco_all_view,
elm,state,list,single, elm);
+ }
+ else if (idx == 0)
+ {
+edje_object_signal_emit(VIEW(it), elm,state,list,first, elm);
+if (it-deco_all_view)
+ edje_object_signal_emit(it-deco_all_view,
elm,state,list,first, elm);
+ }
+ else if (idx == sd-item_count - 1)
+ {
+edje_object_signal_emit(VIEW(it), elm,state,list,last, elm);
+if (it-deco_all_view)
+ edje_object_signal_emit(it-deco_all_view,
elm,state,list,last, elm);
+ }
+ else if (idx 0)
+ {
+edje_object_signal_emit(VIEW(it), elm,state,list,middle, elm);
+if (it-deco_all_view)
+ edje_object_signal_emit(it-deco_all_view,
elm,state,list,middle, elm);
+ }
+
+ if (it-parent)
+ {
+unsigned first_idx = it-parent-item-order_num_in + 1;
+unsigned count = eina_list_count(it-parent-item-items);
+
+if (count == 1)
+ {
+ edje_object_signal_emit(VIEW(it), elm,state,group,single,
elm);
+ if (it-deco_all_view)
+ edje_object_signal_emit(it-deco_all_view,
elm,state,group,single, elm);
+ }
+else if (idx == first_idx)
+ {
+ edje_object_signal_emit(VIEW(it), elm,state,group,first,
elm);
+ if (it-deco_all_view)
+ edje_object_signal_emit(it-deco_all_view,
elm,state,group,first, elm);
+ }
+else if (it ==
eina_list_data_get(eina_list_last(it-parent-item-items)))
Re: [E-devel] [Question] About depcreated elm_object_item_object_get API
Hello, I re-raised this mail thread :) I want to discuss about exporting internal edje object inside elementary widget or elm_object_item. There was an elm_object_item_object_get which is deprecated currently. This is harmful because application can manipulate it but this can give more flexibility to App. developer. There are pros and cons to export internal information. Cons: 1. App. can change the property of edje object. -- If we return the edje object as *const*, it can give warning to App. developer and prevent the problem somehow. 2. App. can rely on the value (geometry or part name, etc.) of edje object. -- This value should be used instantly and discard it after use. This should be documented. 3. If edje object usage is changed, App. should be changed also. -- That can be problem. But normal app (who does not use above API) does not need to be changed. Also using Evas Object property (geometry or size hint, etc.) of the edje object is not highly problematic, Only edje property of the edje object can be problematic. This is almost same problem as theme break if app customize their theme. And this problem should be documented. 4. If edje object is not used and other smart object is used in the future. -- If this will happen, I disagree about exporting internal edje object. Instead, other wrapping APIs (wrapping Evas or Edje property which are needed actually) can be added such as elm_object_item_geometry_get(). I made an patch for this: https://phab.enlightenment.org/D208 Pros: 1. Edje Evas API can be used directly. -- App should rely on these properties instantly. Also, to prevent from modifying the properties, the object should be returned as const. 2. App. can reuse the widget features. -- App. can just need a little edje/C codes and reuse almost feature in their. If not, app should make their own edje theme and move the codes (signals or something) from the widget side to their code. Anyway, If edje inheritance/override can be possible on the runtime, it will be my pleasure :). PS. I heard that Cedric will make ULTRA GREAT FANTASTIC new smart object to substitute old edje object. If so, how about adding new APIs which are needed for flexibility( refer Cons: 4) Actual purpose of this mail is: https://phab.enlightenment.org/D208 :D 2013/4/16 Bluezery ohpo...@gmail.com 2013/4/16 Daniel Juyung Seo seojuyu...@gmail.com On Tue, Apr 16, 2013 at 8:02 PM, Bluezery ohpo...@gmail.com wrote: 2013/4/16 Daniel Juyung Seo seojuyu...@gmail.com Hello, I don't want to export the internal object any more. That depends on point of views. Think about 3 mans Designer / Frame developer / Application Developer Edje is designed for designer. Designer makes edje. It can be compiled and distributed itself. Frame developer makes elementary widget. It can be also distributed itself. Application developer uses elementary and edje. Designer / \ Frame Developer - Application Developer They depends on each others like above. True. If application cannot access the edje. Above can be changed like below. Well you are talking about general edje object. THE EDJE OBJECT we were talking about was an edje object which was created inside the widget. Exposing this internal object is same as exposing class' private members to public. edje object is created on widget side initilally. But elm_object_style_set or elm_theme_extension_add can load edje fo application. If you create your own edje object and you handle it, I don't care. Framework Designer (widget theme) - Frame Developer - Application Developer - Applicaiton Designer So the problem is that edje is designed from Framework Designer can not be reused for application developer. Application designer overwrites (cannot override) it. Are you talking about theme by edje is designed from Framework Designer? Of course you can use it by elm_layout_theme_set. There is no limitation for reusing the any styles in theme. You are just not allowed to hook the other's edje object which is instanciated version of styles/themes whatsoever. Yes. But this edje cannot interact with frameworks. So framework functionality cannot be reused. I don't know the policy of the elementary widget. But I want to find better way. :) It looks like this discussion is headed to the wrong direction :( Thanks. Daniel Juyung Seo (SeoZ) Anyway there is room to discuss as always. Well.. history repeats itself. This was already discussed before. Please refer the following thread. http://www.mail-archive.com/enlightenment-devel@lists.sourceforge.net/msg48240.html On Tue, Apr 16, 2013 at 3:29 PM, ChunEon Park her...@naver.com wrote: Does somebody agree on it? -Regards, Hermet- -Original Message- From: Bluezeryohpo...@gmail.com
[E-devel] Question about elm_genlist_item_class_new/free/class_unref
Hello, I have query abount elm_genlist_item_class_new/free/unref. Elm_Genlist_Item_Class is user created memory and referred by genlist object. But sometimes application want to do not use it anymore. So there is just one option to do this, it is to call elm_genlist_item_class_free. Evenghough, Item Class callbacks can be called because genlist refer the Item Class yet. Moreover, if application is module, application can crash after module is unloaded. There is two options: 1.I can add new API to do this.elm_genlist_item_class_free2 or something. This is easy way but should be deprecaed later. 2. In elm_genlist_item_class_free(), all calbacks can be NULL because the name is too intuitive for application. But this will break ABI and also genlist example in elementary should be changed. 3. All application fix their own to set all callbacks as NULL before unloaded. But this seems to be workaround for application. I like option 2. So I suggest how about above fix be added at the time when 1.8 is released. I think that this weired API usage should be fixed ASAP. Or after 2.0? Thanks -- BRs, Kim. -- Learn Graph Databases - Download FREE O'Reilly Book Graph Databases is the definitive new guide to graph databases and their applications. This 200-page book is written by three acclaimed leaders in the field. The early access version is available now. Download your free book today! http://p.sf.net/sfu/neotech_d2d_may ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Question about elm_genlist_item_class_new/free/class_unref
2013/5/7 Carsten Haitzler ras...@rasterman.com On Tue, 7 May 2013 17:32:05 +0900 Bluezery ohpo...@gmail.com said: Hello, I have query abount elm_genlist_item_class_new/free/unref. Elm_Genlist_Item_Class is user created memory and referred by genlist object. But sometimes application want to do not use it anymore. So there is just one option to do this, it is to call elm_genlist_item_class_free. Evenghough, Item Class callbacks can be called because genlist refer the Item Class yet. Moreover, if application is module, application can crash after module is unloaded. There is two options: 1.I can add new API to do this.elm_genlist_item_class_free2 or something. This is easy way but should be deprecaed later. 2. In elm_genlist_item_class_free(), all calbacks can be NULL because the name is too intuitive for application. But this will break ABI and also genlist example in elementary should be changed. 3. All application fix their own to set all callbacks as NULL before unloaded. But this seems to be workaround for application. I like option 2. So I suggest how about above fix be added at the time when 1.8 is released. I think that this weired API usage should be fixed ASAP. Or after 2.0? #3. free frees, but the class is refcounted.. so it stays around and alive as long as items need it. they all point to it. Okay, I see. If app. use class longer, app. should decide timing to call item_free function. Also for the case such as module, app. can set the callbacks as NULL before unloaded. Thanks -- BRs, Kim. -- Learn Graph Databases - Download FREE O'Reilly Book Graph Databases is the definitive new guide to graph databases and their applications. This 200-page book is written by three acclaimed leaders in the field. The early access version is available now. Download your free book today! http://p.sf.net/sfu/neotech_d2d_may ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- BRs, Kim. -- Learn Graph Databases - Download FREE O'Reilly Book Graph Databases is the definitive new guide to graph databases and their applications. This 200-page book is written by three acclaimed leaders in the field. The early access version is available now. Download your free book today! http://p.sf.net/sfu/neotech_d2d_may ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Question about elm_genlist_item_class_new/free/class_unref
2013/5/7 Daniel Juyung Seo seojuyu...@gmail.com Hello, On Tue, May 7, 2013 at 6:47 PM, Carsten Haitzler ras...@rasterman.com wrote: On Tue, 7 May 2013 17:32:05 +0900 Bluezery ohpo...@gmail.com said: Hello, I have query abount elm_genlist_item_class_new/free/unref. Elm_Genlist_Item_Class is user created memory and referred by genlist object. Well, no. When we use elm_genlist_item_class_new(), item class is created by genlist and managed by genlist even though application call the API. That was the whole point of that API or application could mis-manage item class life cycle. But sometimes application want to do not use it anymore. So there is just one option to do this, it is to call elm_genlist_item_class_free. Evenghough, Item Class callbacks can be called because genlist refer the Item Class yet. Moreover, if application is module, application can crash after module is unloaded. There is two options: 1.I can add new API to do this.elm_genlist_item_class_free2 or something. This is easy way but should be deprecaed later. If you really want, this can be elm_genlist_item_class_del() or something not like free2. 2. In elm_genlist_item_class_free(), all calbacks can be NULL because the name is too intuitive for application. But this will break ABI and also genlist example in elementary should be changed. Yes ABI break. So vetoed! 3. All application fix their own to set all callbacks as NULL before unloaded. But this seems to be workaround for application. This looks weird to me. Why apps change the callbacks on a run-time? They can set a flag and just return from the callbacks. I like option 2. So I suggest how about above fix be added at the time when 1.8 is released. I think that this weired API usage should be fixed ASAP. Or after 2.0? Well API/ABI/Theme break will not happen before 2.0. 2.0 will happen around 2016-2017. You can update the EFL 2.0 TODO document beforehand. https://phab.enlightenment.org/w/efl_2.0_todo/ #3. free frees, but the class is refcounted.. so it stays around and alive as long as items need it. they all point to it. Well yeah. #3 can be done from the application side. But I prefer #1 to #2 and #3. The new API should be used only when it's needed. okay, adding new API can be workaround so I guided #3 to whole apllications. #3 seems to be no harmful after API usage is changed later (after 2.0). Thanks. Thank. Daniel Juyung Seo (SeoZ) Thanks -- BRs, Kim. -- Learn Graph Databases - Download FREE O'Reilly Book Graph Databases is the definitive new guide to graph databases and their applications. This 200-page book is written by three acclaimed leaders in the field. The early access version is available now. Download your free book today! http://p.sf.net/sfu/neotech_d2d_may ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Learn Graph Databases - Download FREE O'Reilly Book Graph Databases is the definitive new guide to graph databases and their applications. This 200-page book is written by three acclaimed leaders in the field. The early access version is available now. Download your free book today! http://p.sf.net/sfu/neotech_d2d_may ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Learn Graph Databases - Download FREE O'Reilly Book Graph Databases is the definitive new guide to graph databases and their applications. This 200-page book is written by three acclaimed leaders in the field. The early access version is available now. Download your free book today! http://p.sf.net/sfu/neotech_d2d_may ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- BRs, Kim. -- Learn Graph Databases - Download FREE O'Reilly Book Graph Databases is the definitive new guide to graph databases and their applications. This 200-page book is written by three acclaimed leaders in the field. The early access version is available now. Download your free book today! http://p.sf.net/sfu/neotech_d2d_may ___ enlightenment
Re: [E-devel] [Question] About depcreated elm_object_item_object_get API
2013/4/16 Daniel Juyung Seo seojuyu...@gmail.com Hello, I don't want to export the internal object any more. That depends on point of views. Think about 3 mans Designer / Frame developer / Application Developer Edje is designed for designer. Designer makes edje. It can be compiled and distributed itself. Frame developer makes elementary widget. It can be also distributed itself. Application developer uses elementary and edje. Designer / \ Frame Developer - Application Developer They depends on each others like above. If application cannot access the edje. Above can be changed like below. Framework Designer (widget theme) - Frame Developer - Application Developer - Applicaiton Designer So the problem is that edje is designed from Framework Designer can not be reused for application developer. Application designer overwrites (cannot override) it. Anyway there is room to discuss as always. Well.. history repeats itself. This was already discussed before. Please refer the following thread. http://www.mail-archive.com/enlightenment-devel@lists.sourceforge.net/msg48240.html On Tue, Apr 16, 2013 at 3:29 PM, ChunEon Park her...@naver.com wrote: Does somebody agree on it? -Regards, Hermet- -Original Message- From: Bluezeryohpo...@gmail.com To: Enlightenment developer list enlightenment-devel@lists.sourceforge.net; Cc: Sent: 2013-04-12 (금) 20:16:20 Subject: Re: [E-devel] [Question] About depcreated elm_object_item_object_get API Yes, theme dependency can be the problem. But there eixst pros and cons. Yes there exists pros and cons. But *MY* policy is not to export the internal objects as much as possible. Managing one objects in the two different places deosn't look good. Once we export the internal objects, people will abuse it with the very high possibility. If application make customized winset theme, application can add programs or parts or something for their own purpose and do more things on theme and do not need to make their own customized winset. In this situation, there is no need to change the elementary and default theme. Application install their app just with their extension theme. In this case, application should know the edje/evas APIs (or elementary should wrap it but this is almost impossible, I think). But I think that application should know those and use those for making perferctly there own purpose. Otherwise, application should make their own edje and add code for manupulate it (make own winset). In this case, application also know edje/evas APIs. Yes this is what I recommend as of now. If you want to handle/manage something, you create it. Do not take other's possessions. There must be a conflict. Genlist supports full item style for this kind of use cases. Theme is already exported for applications. So application can make their own theme. And I requested to export theme (edje), currently it is hidden. 2013/4/4 ChunEon Park hermet@naver.com Maybe it can be... but i don't like those kinds of apis since it will result in the increase of the theme compatibility break. Agreed. For your information, Users even can't decide the ctxpopup size. Conceptually, the ctxpopup itself decides the size and position by itself. -Regards, Hermet- -Original Message- From: Bluezeryohpowel@gmail.com To: Enlightenment developer list enlightenment-devel@lists.sourceforge.net; Cc: Sent: 2013-04-04 (목) 16:31:02 Subject: [E-devel] [Question] About depcreated elm_object_item_object_get API Dear EFL developers, I have question about getting geometry of edje part on elemenatry object or elm object item. If ctx popup or date time widget want to be placed on the text part, I cannot find the way. Actually application should depend on edje theme part on some cases. Applications should know the name of the swallowed part on the edje theme. So, How about elm_object_item_part_geomtry_get API? Or I think that NO!! We don't wrap all the evas/edje apis from elm side. elm_object_item_object_get or elm_object_object_get seems to be needed. If applications can get the edje object from elementary widget or elementary object item, they can use edje APIs directly. But elm_object_item_object_get API was depecated and removed. The reason to remove this API seems to prevent abuse of application developers. But, for the flexibility, this API can be needed. Previously, this API returns Evas_Object *.How about retunring *const*Evas_Object *. ? I can prevent chaning Object property. BRs, Kim. -- BRs, Kim. Thanks. Daniel Juyung Seo (SeoZ)
Re: [E-devel] [Question] About depcreated elm_object_item_object_get API
2013/4/16 Daniel Juyung Seo seojuyu...@gmail.com On Tue, Apr 16, 2013 at 8:02 PM, Bluezery ohpo...@gmail.com wrote: 2013/4/16 Daniel Juyung Seo seojuyu...@gmail.com Hello, I don't want to export the internal object any more. That depends on point of views. Think about 3 mans Designer / Frame developer / Application Developer Edje is designed for designer. Designer makes edje. It can be compiled and distributed itself. Frame developer makes elementary widget. It can be also distributed itself. Application developer uses elementary and edje. Designer / \ Frame Developer - Application Developer They depends on each others like above. True. If application cannot access the edje. Above can be changed like below. Well you are talking about general edje object. THE EDJE OBJECT we were talking about was an edje object which was created inside the widget. Exposing this internal object is same as exposing class' private members to public. edje object is created on widget side initilally. But elm_object_style_set or elm_theme_extension_add can load edje fo application. If you create your own edje object and you handle it, I don't care. Framework Designer (widget theme) - Frame Developer - Application Developer - Applicaiton Designer So the problem is that edje is designed from Framework Designer can not be reused for application developer. Application designer overwrites (cannot override) it. Are you talking about theme by edje is designed from Framework Designer? Of course you can use it by elm_layout_theme_set. There is no limitation for reusing the any styles in theme. You are just not allowed to hook the other's edje object which is instanciated version of styles/themes whatsoever. Yes. But this edje cannot interact with frameworks. So framework functionality cannot be reused. I don't know the policy of the elementary widget. But I want to find better way. :) It looks like this discussion is headed to the wrong direction :( Thanks. Daniel Juyung Seo (SeoZ) Anyway there is room to discuss as always. Well.. history repeats itself. This was already discussed before. Please refer the following thread. http://www.mail-archive.com/enlightenment-devel@lists.sourceforge.net/msg48240.html On Tue, Apr 16, 2013 at 3:29 PM, ChunEon Park her...@naver.com wrote: Does somebody agree on it? -Regards, Hermet- -Original Message- From: Bluezeryohpo...@gmail.com To: Enlightenment developer list enlightenment-devel@lists.sourceforge.net; Cc: Sent: 2013-04-12 (금) 20:16:20 Subject: Re: [E-devel] [Question] About depcreated elm_object_item_object_get API Yes, theme dependency can be the problem. But there eixst pros and cons. Yes there exists pros and cons. But *MY* policy is not to export the internal objects as much as possible. Managing one objects in the two different places deosn't look good. Once we export the internal objects, people will abuse it with the very high possibility. If application make customized winset theme, application can add programs or parts or something for their own purpose and do more things on theme and do not need to make their own customized winset. In this situation, there is no need to change the elementary and default theme. Application install their app just with their extension theme. In this case, application should know the edje/evas APIs (or elementary should wrap it but this is almost impossible, I think). But I think that application should know those and use those for making perferctly there own purpose. Otherwise, application should make their own edje and add code for manupulate it (make own winset). In this case, application also know edje/evas APIs. Yes this is what I recommend as of now. If you want to handle/manage something, you create it. Do not take other's possessions. There must be a conflict. Genlist supports full item style for this kind of use cases. Theme is already exported for applications. So application can make their own theme. And I requested to export theme (edje), currently it is hidden. 2013/4/4 ChunEon Park hermet@naver.com Maybe it can be... but i don't like those kinds of apis since it will result in the increase of the theme compatibility break. Agreed. For your information, Users even can't decide the ctxpopup size. Conceptually, the ctxpopup itself decides the size and position by itself. -Regards, Hermet- -Original Message- From: Bluezeryohpowel@gmail.com
Re: [E-devel] [Question] About depcreated elm_object_item_object_get API
Yes, theme dependency can be the problem. But there eixst pros and cons. If application make customized winset theme, application can add programs or parts or something for their own purpose and do more things on theme and do not need to make their own customized winset. In this situation, there is no need to change the elementary and default theme. Application install their app just with their extension theme. In this case, application should know the edje/evas APIs (or elementary should wrap it but this is almost impossible, I think). But I think that application should know those and use those for making perferctly there own purpose. Otherwise, application should make their own edje and add code for manupulate it (make own winset). In this case, application also know edje/evas APIs. Theme is already exported for applications. So application can make their own theme. And I requested to export theme (edje), currently it is hidden. 2013/4/4 ChunEon Park her...@naver.com Maybe it can be... but i don't like those kinds of apis since it will result in the increase of the theme compatibility break. For your information, Users even can't decide the ctxpopup size. Conceptually, the ctxpopup itself decides the size and position by itself. -Regards, Hermet- -Original Message- From: Bluezeryohpo...@gmail.com To: Enlightenment developer list enlightenment-devel@lists.sourceforge.net; Cc: Sent: 2013-04-04 (목) 16:31:02 Subject: [E-devel] [Question] About depcreated elm_object_item_object_get API Dear EFL developers, I have question about getting geometry of edje part on elemenatry object or elm object item. If ctx popup or date time widget want to be placed on the text part, I cannot find the way. Actually application should depend on edje theme part on some cases. Applications should know the name of the swallowed part on the edje theme. So, How about elm_object_item_part_geomtry_get API? Or I think that elm_object_item_object_get or elm_object_object_get seems to be needed. If applications can get the edje object from elementary widget or elementary object item, they can use edje APIs directly. But elm_object_item_object_get API was depecated and removed. The reason to remove this API seems to prevent abuse of application developers. But, for the flexibility, this API can be needed. Previously, this API returns Evas_Object *.How about retunring *const*Evas_Object *. ? I can prevent chaning Object property. BRs, Kim. -- BRs, Kim. -- Minimize network downtime and maximize team effectiveness. Reduce network management and security costs.Learn how to hire the most talented Cisco Certified professionals. Visit the Employer Resources Portal http://www.cisco.com/web/learning/employer_resources/index.html ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Minimize network downtime and maximize team effectiveness. Reduce network management and security costs.Learn how to hire the most talented Cisco Certified professionals. Visit the Employer Resources Portal http://www.cisco.com/web/learning/employer_resources/index.html ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- BRs, Kim. -- Precog is a next-generation analytics platform capable of advanced analytics on semi-structured data. The platform includes APIs for building apps and a phenomenal toolset for data science. Developers can use our toolset for easy data analysis visualization. Get a free account! http://www2.precog.com/precogplatform/slashdotnewsletter ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [Question] About depcreated elm_object_item_object_get API
Dear EFL developers, I have question about getting geometry of edje part on elemenatry object or elm object item. If ctx popup or date time widget want to be placed on the text part, I cannot find the way. Actually application should depend on edje theme part on some cases. Applications should know the name of the swallowed part on the edje theme. So, How about elm_object_item_part_geomtry_get API? Or I think that elm_object_item_object_get or elm_object_object_get seems to be needed. If applications can get the edje object from elementary widget or elementary object item, they can use edje APIs directly. But elm_object_item_object_get API was depecated and removed. The reason to remove this API seems to prevent abuse of application developers. But, for the flexibility, this API can be needed. Previously, this API returns Evas_Object *.How about retunring *const*Evas_Object *. ? I can prevent chaning Object property. BRs, Kim. -- BRs, Kim. -- Minimize network downtime and maximize team effectiveness. Reduce network management and security costs.Learn how to hire the most talented Cisco Certified professionals. Visit the Employer Resources Portal http://www.cisco.com/web/learning/employer_resources/index.html ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [Question] About propagate events on edc script.
Dear EFL developers, In edc script, there does not exist propagate_events so the each part always propagate their events to their parents if I add a evas event callback to layout or edje. Is this intentional or not? Of course, I can use the elm_layout_signal_callback_add or edje_object_signal_callback_add to any part to receive events just for the part. But Is this possible to block the event propagation just on edc script file? -- BRs, Kim. -- Own the Future-Intelreg; Level Up Game Demo Contest 2013 Rise to greatness in Intel's independent game demo contest. Compete for recognition, cash, and the chance to get your game on Steam. $5K grand prize plus 10 genre and skill prizes. Submit your demo by 6/6/13. http://p.sf.net/sfu/intel_levelupd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Question] About propagate events on edc script.
2013/3/29 Iván Briano sachi...@gmail.com: On Thu, Mar 28, 2013 at 4:47 PM, Davide Andreoli d...@gurumeditation.it wrote: 2013/3/28 Bluezery ohpo...@gmail.com Dear EFL developers, In edc script, there does not exist propagate_events so the each part always propagate their events to their parents if I add a evas event callback to layout or edje. Is this intentional or not? Of course, I can use the elm_layout_signal_callback_add or edje_object_signal_callback_add to any part to receive events just for the part. But Is this possible to block the event propagation just on edc script file? If I understand correctly you are searching for repeat_events in edc parts to block or propagate the events I don't think so. At least on Evas, repeat_events will make events be repeated to objects stacked below the one taking them. Propagate events is used to make the parent object, in case of smart objects, receive the events from their children. When I tested, only way to block the event propagation from each edje part to their parent (edje object) is to set mouse_event: 0 for each part. But It makes each part can not receive all events eventhough they want events and dont want propagate those. Swllowed part can block event progation by setting propagate_events as 0 on the C code for the swallowed evas object. -- Own the Future-Intelreg; Level Up Game Demo Contest 2013 Rise to greatness in Intel's independent game demo contest. Compete for recognition, cash, and the chance to get your game on Steam. $5K grand prize plus 10 genre and skill prizes. Submit your demo by 6/6/13. http://p.sf.net/sfu/intel_levelupd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Own the Future-Intel(R) Level Up Game Demo Contest 2013 Rise to greatness in Intel's independent game demo contest. Compete for recognition, cash, and the chance to get your game on Steam. $5K grand prize plus 10 genre and skill prizes. Submit your demo by 6/6/13. http://altfarm.mediaplex.com/ad/ck/12124-176961-30367-2 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Own the Future-Intel(R) Level Up Game Demo Contest 2013 Rise to greatness in Intel's independent game demo contest. Compete for recognition, cash, and the chance to get your game on Steam. $5K grand prize plus 10 genre and skill prizes. Submit your demo by 6/6/13. http://altfarm.mediaplex.com/ad/ck/12124-176961-30367-2 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- BRs, Kim. -- Own the Future-Intel(R) Level Up Game Demo Contest 2013 Rise to greatness in Intel's independent game demo contest. Compete for recognition, cash, and the chance to get your game on Steam. $5K grand prize plus 10 genre and skill prizes. Submit your demo by 6/6/13. http://altfarm.mediaplex.com/ad/ck/12124-176961-30367-2 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [elementary]map: Fix 1byte invalid read
2013/2/23 Carsten Haitzler ras...@rasterman.com: On Sat, 23 Feb 2013 21:03:02 +0900 Bluezery ohpo...@gmail.com said: 2013/2/23 Carsten Haitzler ras...@rasterman.com: On Thu, 21 Feb 2013 18:48:42 +0900 Bluezery ohpo...@gmail.com said: Hello, This patch fix 1byte invalid read error for char * string. Readed bytes needs one more bytes for NULL terminated char. could you try our new phab tool for submitting patches? see my comments here: https://phab.enlightenment.org/D2 i want to try nut out phab with respect to review and actual patches (and generating of them). I made it! arc is a good tool :) I think this can be better than gerrit. https://phab.enlightenment.org/D3 PS. It's better to add the .arcconfig file to .gitignore hmm it seems without a .arcconfig things are all bad. if i add one i cant make things work as master has it but somenow patch branch doesnt as it is based on an olkder rev. if i add one it conflicts etc. can u re-submit the same patch again please? really testing and trying to make phab work for us... sorry about the pain... its initial. once i know how this works it should be smoother and i'll document it. I made a patch again. https://phab.enlightenment.org/D10 I want to make a patchset on D3. I can't becauseD3 is already abandoned or arc doesn't support it. Patchset feature is important to log the review history. -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- BRs, Kim. -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- BRs, Kim. -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [elementary]map: Fix 1byte invalid read
2013/2/25 Bluezery ohpo...@gmail.com: 2013/2/23 Carsten Haitzler ras...@rasterman.com: On Sat, 23 Feb 2013 21:03:02 +0900 Bluezery ohpo...@gmail.com said: 2013/2/23 Carsten Haitzler ras...@rasterman.com: On Thu, 21 Feb 2013 18:48:42 +0900 Bluezery ohpo...@gmail.com said: Hello, This patch fix 1byte invalid read error for char * string. Readed bytes needs one more bytes for NULL terminated char. could you try our new phab tool for submitting patches? see my comments here: https://phab.enlightenment.org/D2 i want to try nut out phab with respect to review and actual patches (and generating of them). I made it! arc is a good tool :) I think this can be better than gerrit. https://phab.enlightenment.org/D3 PS. It's better to add the .arcconfig file to .gitignore hmm it seems without a .arcconfig things are all bad. if i add one i cant make things work as master has it but somenow patch branch doesnt as it is based on an olkder rev. if i add one it conflicts etc. can u re-submit the same patch again please? really testing and trying to make phab work for us... sorry about the pain... its initial. once i know how this works it should be smoother and i'll document it. I made a patch again. https://phab.enlightenment.org/D10 I want to make a patchset on D3. I can't becauseD3 is already abandoned or arc doesn't support it. Patchset feature is important to log the review history. OK, I found that patchset feature is supported by phap. You can see it on Revision Update History section in D10. So if reviewer can leave inline commnet for my patch by clicking line. And I will update revision again by youre comment. :) -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- BRs, Kim. -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- BRs, Kim. -- BRs, Kim. -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [elementary]map: Fix 1byte invalid read
2013/2/23 Carsten Haitzler ras...@rasterman.com: On Thu, 21 Feb 2013 18:48:42 +0900 Bluezery ohpo...@gmail.com said: Hello, This patch fix 1byte invalid read error for char * string. Readed bytes needs one more bytes for NULL terminated char. could you try our new phab tool for submitting patches? see my comments here: https://phab.enlightenment.org/D2 i want to try nut out phab with respect to review and actual patches (and generating of them). I made it! arc is a good tool :) I think this can be better than gerrit. https://phab.enlightenment.org/D3 PS. It's better to add the .arcconfig file to .gitignore -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- BRs, Kim. -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/efl] master 02/02: Merge branch 'master' of ssh://git.enlightenment.org/core/efl
Before make commit, git pull should be done to prevent this useless commit. If conflict occurred, git stash git pull git stash pop is good solution. Otherwise, solve the conflict manually to make commit on top of the origin/master's HEAD. 2013/2/23 Daniel Juyung Seo seojuyu...@gmail.com: Hello, this must be the first merge branch commit. So what's our policy? merge or rebase? I think we didn't clear this up. Daniel Juyung Seo (SeoZ) On Sat, Feb 23, 2013 at 7:52 PM, ChunEon Park - Enlightenment Git no-re...@enlightenment.org wrote: hermet pushed a commit to branch master. commit 029d539a85306019608e27a611ace500b313dd71 Merge: 9c950e4 161a784 Author: ChunEon Park chuneon.p...@samsung.com Date: Sat Feb 23 19:52:57 2013 +0900 Merge branch 'master' of ssh://git.enlightenment.org/core/efl src/examples/ecore/ecore_imf_example.c | 44 +++--- 1 file changed, 36 insertions(+), 8 deletions(-) -- -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- BRs, Kim. -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [elementary]map: Fix 1byte invalid read
Hello, This patch fix 1byte invalid read error for char * string. Readed bytes needs one more bytes for NULL terminated char. Thanks -- BRs, Kim. map@fix_1byte_error.patch Description: Binary data -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [elementary]map: Fix 1byte invalid read
Why not happens?? 1. because eina_simple_xml_parse uses char *, buf should be null terminated. So I use memset. 2. Because NULL is needed at the end, I add one more byte. fread read exact bytes and has no NULL. 3. If buf is failed to alloc (very rarely case), it is not need to be rewinded. PS. I found more cases in the map code and I fixed patch again. 2013/2/21 Tom Hacohen tom.haco...@samsung.com: On 21/02/13 09:48, Bluezery wrote: Hello, This patch fix 1byte invalid read error for char * string. Readed bytes needs one more bytes for NULL terminated char. It's not really something that will ever happen so we'll never encounter it in real life, but still: You've included unrelated changes in this patch. You've changed fseek to rewind and moved it inside the if, which means it'll get called under different circumstances now. -- Tom. -- BRs, Kim. map@fix_1byte_error.patch Description: Binary data -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Fwd: [elementary]map: Fix 1byte invalid read
I forgot to add EFL mailing list. :( -- Forwarded message -- From: Bluezery ohpo...@gmail.com Date: 2013/2/21 Subject: Re: [E-devel] [elementary]map: Fix 1byte invalid read To: Tom Hacohen tom.haco...@samsung.com OK, it's from my bad english :) I splited the patch. fix 1byte error more !! fix_more.patch does nothing when buf allocation failed. 2013/2/21 Tom Hacohen tom.haco...@samsung.com: On 21/02/13 11:44, Bluezery wrote: Why not happens?? 1. because eina_simple_xml_parse uses char *, buf should be null terminated. So I use memset. 2. Because NULL is needed at the end, I add one more byte. fread read exact bytes and has no NULL. 3. If buf is failed to alloc (very rarely case), it is not need to be rewinded. PS. I found more cases in the map code and I fixed patch again. You didn't understand me correctly. Your patch fixes a valid problem, I was just explaining what you've mentioned in point #3. I'm saying that you've changed more things than what you've claimed in the log. The rest is a good patch. -- Tom. -- BRs, Kim. -- BRs, Kim. map@fix_1byte_error.patch Description: Binary data map@fix_more.patch Description: Binary data -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] to all you curlers
If easy hadle is not removed from multi-handle, Is it possible to stop easy handle's transfer? while other easy handles are active. But it seems to be bug that APIs do not work after timeout.. 2013/1/7 Michael Blumenkrantz michael.blumenkra...@gmail.com: I've located a bug that I encountered over the weekend in ecore_con_url.c. In _ecore_con_url_timeout_cb(), the curl object is unhooked from the multi handle, and the url object is removed from the list. I think this is wrong since it prevents that url object from being reused like other objects. Thoughts? -- Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122412 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- BRs, Kim. -- Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122412 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [elementary]elm_widget: elm widget
It's final fix. :) Previsouly, I do not considerthe case which is in the scroller in the scroller. Current logic is that: Find scroller in parent objects. And calculate region to focus in the scroller. And show focused object. That's all. 2013/1/7 Bluezery ohpo...@gmail.com: I have changed patch a little. Region show should be performed only for the objects which implement elm_wdg_focus_region_get(), such as entry. Otherwise, do not show region the object when it is focused. 2013/1/5 Bluezery ohpo...@gmail.com: Hello, I have made a patch for fixing region show of widget focus in scroller. Previously, region show is not correct if focused object is not in the viewport of ther scroller Because region show calculation is done only by evas object geometry. But scroller object can know the viewport region in the scroller. It is different from evas object geometry. In my patch, if focused object is requested to be shown, focused object calculates it itself (by elm_widget_focus_region_get) or evas geometry is gained. If parent is not scroller, geometry is changed by this parent for showing this parent in the scroller if grand parent is scroller. If parent is scroller, it find out whether the object is in the viewport of the scroller object (parent) and region to be shown is calculated. Please review this patch. -- BRs, Kim. -- BRs, Kim. -- BRs, Kim. elm_widget_focus.patch Description: Binary data -- Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122412___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [elementary]elm_widget: elm widget
I have changed patch a little. Region show should be performed only for the objects which implement elm_wdg_focus_region_get(), such as entry. Otherwise, do not show region the object when it is focused. 2013/1/5 Bluezery ohpo...@gmail.com: Hello, I have made a patch for fixing region show of widget focus in scroller. Previously, region show is not correct if focused object is not in the viewport of ther scroller Because region show calculation is done only by evas object geometry. But scroller object can know the viewport region in the scroller. It is different from evas object geometry. In my patch, if focused object is requested to be shown, focused object calculates it itself (by elm_widget_focus_region_get) or evas geometry is gained. If parent is not scroller, geometry is changed by this parent for showing this parent in the scroller if grand parent is scroller. If parent is scroller, it find out whether the object is in the viewport of the scroller object (parent) and region to be shown is calculated. Please review this patch. -- BRs, Kim. -- BRs, Kim. elm_widget_focus.patch Description: Binary data -- Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122412___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [elementary]elm_widget: elm widget
Hello, I have made a patch for fixing region show of widget focus in scroller. Previously, region show is not correct if focused object is not in the viewport of ther scroller Because region show calculation is done only by evas object geometry. But scroller object can know the viewport region in the scroller. It is different from evas object geometry. In my patch, if focused object is requested to be shown, focused object calculates it itself (by elm_widget_focus_region_get) or evas geometry is gained. If parent is not scroller, geometry is changed by this parent for showing this parent in the scroller if grand parent is scroller. If parent is scroller, it find out whether the object is in the viewport of the scroller object (parent) and region to be shown is calculated. Please review this patch. -- BRs, Kim. elm_widget_focus.patch Description: Binary data -- Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122912___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch][edje] Prevent duplicated inherition of after
Please review this patch. When inheriting group, program.after can be duplicated currently. But I think that duplicated program.after is not needed when inherting. If user want that after can be called twice, it's better to add one more after intentionally 2012/11/8 Bluezery ohpo...@gmail.com: Oops, actually I removed automated whitespace removal by editor. Something is remained.. sorry :( I attached patch again. In the orianal code, tab spaces are mixed. But I uses only space. 2012/11/8 Daniel Juyung Seo seojuyu...@gmail.com: Dear taehwan, thanks for the patch. But can you please separate formatting fix(including white space removal) and feature change/bug fix next time? Thanks. Daniel Juyung Seo (SeoZ) On Thu, Nov 8, 2012 at 5:42 PM, Bluezery ohpo...@gmail.com wrote: Dear EFL developers, When inherting group, after of program section is also inherited. But duplicated name of after can be also inherited. I think that multiple after can be used but duplicated should be not. because this seems to be useless. Is there case that duplicated after usage is used? Duplicated target is prevented. I just copy those codes. Please review this patch. -- BRs, Kim. -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_nov ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_nov ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- BRs, Kim. -- BRs, Kim. -- Keep yourself connected to Go Parallel: TUNE You got it built. Now make it sing. Tune shows you how. http://goparallel.sourceforge.net ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [Question] Some missing packages in contribute page
Dear EFL developers, I changed my linux desktop and build new efl sources. I followed the guide in building section of contribute page(http://www.enlightenment.org/p.php?p=contributel=en) But I think that openssl, g++ packages seems to be missing because openssl is default module for eet in configure.ac and __cplusplus is used for eet, embryo, etc. If g++ package does not exist, below errors occure libtool: link: unsupported hardcode properties libtool: link: See the libtool documentation for more information. libtool: link: Fatal configuration error. gcc can do build c++ but I think that they predict sources just by file extension. -- BRs, Kim. -- Monitor your physical, virtual and cloud infrastructure from a single web console. Get in-depth insight into apps, servers, databases, vmware, SAP, cloud infrastructure, etc. Download 30-day Free Trial. Pricing starts from $795 for 25 servers or applications! http://p.sf.net/sfu/zoho_dev2dev_nov ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Evas event handling - void *event_info?
2012년 11월 18일 일요일에 Andreas Volz님이 작성:
Hello,
I've just some problem to understand that event_info parameter in Evas
callbacks. e.g.:
http://docs.enlightenment.org/auto/elementary/fileselector_example_c.html
...
/* 'selected' cb */
static void
_fs_selected(void*data,
Evas_Object *obj,
void*event_info)
{
const char *selected = event_info;
/* event_info contains the full path of the selected file */
printf(There's been a selection: %s\n, selected);
}
...
/* the 'done' cb is called when the user presses ok/cancel */
evas_object_smart_callback_add(fs, done, _fs_done, win);
...
In this example the event_info* is casted in sime magic way to a char*.
My problem is that event_info* could always be anything and I don't
know it without looking into the sources (here e.g. elm_fileselector).
It's not written anywhere in the documentation that event_info* is a
char*. (Or I didn't find it...)
So is there any way to find out as API user the type of event_info*
which I should cast?
In my special case (Eflxx C++ wrapper) have the problem to design a
type safe interface. I've really no idea to do it. But even using the C
interface I don't like it. Or did I miss understood the API?
I would really prefer that event_info* would be some structure with a
data pointer and some magic identifiers. Then it would be possible to
find out the type of an event.
What do you think? Am I alone with this problem? Any ideas for a better
event_info interface?
if event_info has a structure with magic number or type, magic number
could be conflicted after widget customization by end user if widget
customization is allowed. but I don't know customization is allowed or not
now or for the future.
regards
Andreas
--
Technical Blog http://andreasvolz.wordpress.com/
--
Monitor your physical, virtual and cloud infrastructure from a single
web console. Get in-depth insight into apps, servers, databases, vmware,
SAP, cloud infrastructure, etc. Download 30-day Free Trial.
Pricing starts from $795 for 25 servers or applications!
http://p.sf.net/sfu/zoho_dev2dev_nov
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net javascript:;
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
BRs,
Kim.
--
Monitor your physical, virtual and cloud infrastructure from a single
web console. Get in-depth insight into apps, servers, databases, vmware,
SAP, cloud infrastructure, etc. Download 30-day Free Trial.
Pricing starts from $795 for 25 servers or applications!
http://p.sf.net/sfu/zoho_dev2dev_nov
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch][Elementary]Genlist: Fix anchor item to prevent scroller movement
2012/11/15 Carsten Haitzler ras...@rasterman.com: On Wed, 17 Oct 2012 22:08:52 +0900 Bluezery ohpo...@gmail.com said: Dear all, When you prepend or insert_before items into genlist, scroller is moved. This bugs was somewhat fixed in case of insert_before but still occurred when insert items before first item. This patch fix this. When item is inserted before, make this item as anchor item and later this item is used for scroller's position fixing. Please review this patch. this seems to make things worse. tried genlist 2 test and ad a bunch of items, scroll down maybe 90% of the way - select something, then hit + before ? :) selected item actually disappears and we have items floating about int he wrong places... Thanks for review. I fixed again !! The difference from previous patch is to check anchor item's position in the _calc_job. When anchor item's position is above the viewport's bottom line, position fix is perfomed. Please review this again. -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- BRs, Kim. genlist@fix_anchor_item.patch Description: Binary data -- Monitor your physical, virtual and cloud infrastructure from a single web console. Get in-depth insight into apps, servers, databases, vmware, SAP, cloud infrastructure, etc. Download 30-day Free Trial. Pricing starts from $795 for 25 servers or applications! http://p.sf.net/sfu/zoho_dev2dev_nov___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch][edje] Prevent duplicated inherition of after
2012/11/9 Daniel Juyung Seo seojuyu...@gmail.com: thanks for the quick fix. btw how can i reproduce/check the bug? I don't know this is a bug or intended. if duplicated after usage is wrong case, it's a bug. Daniel Juyung Seo (SeoZ) On Nov 8, 2012 6:37 PM, Bluezery ohpo...@gmail.com wrote: Oops, actually I removed automated whitespace removal by editor. Something is remained.. sorry :( I attached patch again. In the orianal code, tab spaces are mixed. But I uses only space. 2012/11/8 Daniel Juyung Seo seojuyu...@gmail.com: Dear taehwan, thanks for the patch. But can you please separate formatting fix(including white space removal) and feature change/bug fix next time? Thanks. Daniel Juyung Seo (SeoZ) On Thu, Nov 8, 2012 at 5:42 PM, Bluezery ohpo...@gmail.com wrote: Dear EFL developers, When inherting group, after of program section is also inherited. But duplicated name of after can be also inherited. I think that multiple after can be used but duplicated should be not. because this seems to be useless. Is there case that duplicated after usage is used? Duplicated target is prevented. I just copy those codes. Please review this patch. -- BRs, Kim. -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_nov ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_nov ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- BRs, Kim. -- BRs, Kim. -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_nov ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [Patch][edje] Prevent duplicated inherition of after
Dear EFL developers, When inherting group, after of program section is also inherited. But duplicated name of after can be also inherited. I think that multiple after can be used but duplicated should be not. because this seems to be useless. Is there case that duplicated after usage is used? Duplicated target is prevented. I just copy those codes. Please review this patch. -- BRs, Kim. edje_cc@fix_inherit_after.patch Description: Binary data -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_nov___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch][edje] Prevent duplicated inherition of after
Oops, actually I removed automated whitespace removal by editor. Something is remained.. sorry :( I attached patch again. In the orianal code, tab spaces are mixed. But I uses only space. 2012/11/8 Daniel Juyung Seo seojuyu...@gmail.com: Dear taehwan, thanks for the patch. But can you please separate formatting fix(including white space removal) and feature change/bug fix next time? Thanks. Daniel Juyung Seo (SeoZ) On Thu, Nov 8, 2012 at 5:42 PM, Bluezery ohpo...@gmail.com wrote: Dear EFL developers, When inherting group, after of program section is also inherited. But duplicated name of after can be also inherited. I think that multiple after can be used but duplicated should be not. because this seems to be useless. Is there case that duplicated after usage is used? Duplicated target is prevented. I just copy those codes. Please review this patch. -- BRs, Kim. -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_nov ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_nov ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- BRs, Kim. edje_cc@fix_inherit_after.patch Description: Binary data -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_nov___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] I reverted a broken patch to genlist (77944)
Hum... I don't know why evas object is not correct when item is realizedunrealized after genlist is cleared.. Anyway, it's my fault :( Later, I will resend fixed patch. 2012/10/23 Daniel Juyung Seo seojuyu...@gmail.com: Thanks for the test/revert. I should look at the patch. Daniel Juyung Seo (SeoZ) On Mon, Oct 22, 2012 at 11:36 PM, Tom Hacohen tom.haco...@samsung.com wrote: Hey, I reverted commit 77944 that was committed by raster (a patch from Bluezery). That commit broke genlist and clouseau. How to reproduce: Open Genlist 2 test, click on the X button, and then click on the + button. Cheers, Tom. -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_sfd2d_oct ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_sfd2d_oct ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- BRs, Kim. -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_sfd2d_oct ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [E-Devel][Patch][Elementary] Gengrid: Bug fix
Dear all, There is a bug, invalid data assign into ecore_job. Trivial whilte space removal is included also. it's automated in my editor :D. Please review this patch. -- BRs, Kim. gengrid@fix_bug.patch Description: Binary data -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_sfd2d_oct___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [Patch][Elementary]Genlist: Fix anchor item to prevent scroller movement
Dear all, When you prepend or insert_before items into genlist, scroller is moved. This bugs was somewhat fixed in case of insert_before but still occurred when insert items before first item. This patch fix this. When item is inserted before, make this item as anchor item and later this item is used for scroller's position fixing. Please review this patch. BRs, Kim. -- BRs, Kim. genlist@fix_anchor_item.patch Description: Binary data -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_sfd2d_oct___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [E-Devel][Patch][Elementary]Genlist - Edje Item Cache Refactoring
2012/10/13 Carsten Haitzler ras...@rasterman.com:
On Fri, 5 Oct 2012 11:09:12 +0900 Bluezery ohpo...@gmail.com said:
that's a pretty big patch for a much smaller set of actual work. reading the
patch took time because of this (i keep having to compere your new functions
to
the old which have like 90% of the same stuff - but they are moved around in
the file thus unchanged bits becoming part of the patch).
question: why do you not clear (all_free) the cache when block count is set?
if
someone sets block count to 4 the item cache will at that point be much bigger
still.. ?
Previously _item_cache_clean() do not free all caches. it just remove
some caches if current cache size exceeds max cache size.
In my patch, because cache size check is done when cache is pushed and
cache size is always below max size, I just remove that.
question: item_cache_push seems to want to do more now.. so if nocache_once or
nocache are set you del the vie obj and spacer THEN you go to item clean which
now tries to delete signal callbacks from a deleted edje object. this isn't
very
nice. :) it should at least check if (VIEW(it)) { ..
edje_object_signal_del... } there and SET it to NULL on deletion... the only
thing saving you here is evas's deferred deletion (gcing) of deleted objects
and magic number checking. this is not something you should depend on. it may
change in future, and then this code would fall apart nicely :)
Yeah, your're right. NULL check of VIEW(it) is needed.
I currently concentrate on code optimization because I think that
genlist's codes are scattered and hard to be modified.
i fixed the above for you and put in the patch. :) thanks! :)
Thanks very much.
I am fixing map currently and will fix genlist again.
This can be done step by step or big patch. ;)
I resolved conflicts with recent svn.
2012/10/2 Bluezery ohpo...@gmail.com:
Dear EFL developers,
This is patch for reconstructing genlist's item cache.
Each item cache functions do harsh jobs so just push,pop by Elm_Gen_Item *
now. Before, cache is disabled by comments. But I enabled item cache again
(even for the case which tree_effect_enabled is on).
I changed some functions:
_item_cache_find() -- _item_cache_pop()
_item_cache_add() -- _item_cache_push()
_item_cache_zero() --_item_cache_all_free()
And I removed _item_cache_clean() function because I made
_item_cache_push() to don't exceed the item_cache_max. So clean-up of
cache is not needed anymore.
I will do more re-factoring jobs for genlist.
Please review this patch.
--
BRs,
Kim.
--
BRs,
Kim.
--
- Codito, ergo sum - I code, therefore I am --
The Rasterman (Carsten Haitzler)ras...@rasterman.com
--
BRs,
Kim.
--
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/ecore/src/lib/ecore_con
2012/10/5 Enlightenment SVN no-re...@enlightenment.org: Log: ecore: let's try another approach thanks to Guillaume Friloux. Author: cedric Date: 2012-10-05 06:07:14 -0700 (Fri, 05 Oct 2012) New Revision: 77533 Trac: http://trac.enlightenment.org/e/changeset/77533 Modified: trunk/ecore/src/lib/ecore_con/ecore_con_url.c Modified: trunk/ecore/src/lib/ecore_con/ecore_con_url.c === --- trunk/ecore/src/lib/ecore_con/ecore_con_url.c 2012-10-05 12:18:51 UTC (rev 77532) +++ trunk/ecore/src/lib/ecore_con/ecore_con_url.c 2012-10-05 13:07:14 UTC (rev 77533) @@ -56,7 +56,7 @@ static int _init_count = 0; static Ecore_Timer *_curl_timer = NULL; static Eina_Bool pipelining = EINA_FALSE; - +Ecore_Idler *_curl_idler; #endif /** @@ -91,6 +91,7 @@ _curl_timer = ecore_timer_add((double)ms / 1000, _ecore_con_url_timer, NULL); ecore_timer_freeze(_curl_timer); + _curl_idler = NULL; return _init_count; #else @@ -114,6 +115,9 @@ _curl_timer = NULL; } + if (_curl_idler) ecore_idler_del(_curl_idler); + _curl_idler = NULL; + EINA_LIST_FREE(_url_con_list, url_con) ecore_con_url_free(url_con); EINA_LIST_FREE(_fd_hd_list, fd_handler) @@ -1335,7 +1339,7 @@ e-status = status; e-url_con = url_con; - + url_con-event_count++; ecore_event_add(ECORE_CON_EVENT_URL_COMPLETE, e, (Ecore_End_Cb)_ecore_con_event_url_free, url_con); } @@ -1549,6 +1553,9 @@ ecore_timer_interval_set(_curl_timer, (double)ms / 1000); + if (!_curl_timer) + _curl_idler = ecore_idler_add(_ecore_con_url_timer, NULL); + return ECORE_CALLBACK_CANCEL; } Which case can _curl_timer can be NULL in? After ecore_con_url_shutdown(), can _ecore_con_url_timer be called? @@ -1611,6 +1618,8 @@ ERR(curl_multi_perform() failed: %s, curl_multi_strerror(ret)); _ecore_con_url_curl_clear(); ecore_timer_freeze(_curl_timer); +if (_curl_idler) ecore_idler_del(_curl_idler); +_curl_idler = NULL; } if (still_running) @@ -1628,6 +1637,8 @@ _ecore_con_url_info_read(); _ecore_con_url_curl_clear(); ecore_timer_freeze(_curl_timer); +if (_curl_idler) ecore_idler_del(_curl_idler); +_curl_idler = NULL; } return ECORE_CALLBACK_RENEW; -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ enlightenment-svn mailing list enlightenment-...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-svn -- BRs, Kim. -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [E-Devel][Patch][Elementary]Genlist - Edje Item Cache Refactoring
I resolved conflicts with recent svn. 2012/10/2 Bluezery ohpo...@gmail.com: Dear EFL developers, This is patch for reconstructing genlist's item cache. Each item cache functions do harsh jobs so just push,pop by Elm_Gen_Item * now. Before, cache is disabled by comments. But I enabled item cache again (even for the case which tree_effect_enabled is on). I changed some functions: _item_cache_find() -- _item_cache_pop() _item_cache_add() -- _item_cache_push() _item_cache_zero() --_item_cache_all_free() And I removed _item_cache_clean() function because I made _item_cache_push() to don't exceed the item_cache_max. So clean-up of cache is not needed anymore. I will do more re-factoring jobs for genlist. Please review this patch. -- BRs, Kim. -- BRs, Kim. genlist@cache_refactoring.patch Description: Binary data -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [E-Devel][Patch][Elementary]Genlist - Edje Item Cache Refactoring
Dear EFL developers, This is patch for reconstructing genlist's item cache. Each item cache functions do harsh jobs so just push,pop by Elm_Gen_Item * now. Before, cache is disabled by comments. But I enabled item cache again (even for the case which tree_effect_enabled is on). I changed some functions: _item_cache_find() -- _item_cache_pop() _item_cache_add() -- _item_cache_push() _item_cache_zero() --_item_cache_all_free() And I removed _item_cache_clean() function because I made _item_cache_push() to don't exceed the item_cache_max. So clean-up of cache is not needed anymore. I will do more re-factoring jobs for genlist. Please review this patch. -- BRs, Kim. genlist@cache_refactoring.patch Description: Binary data -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [patch][elementary] add reorder fast mode for mobile case
Sorry, test code was in there :( I removed them. 2012/10/1 Daniel Juyung Seo seojuyu...@gmail.com: It looks like there are unnecessary codes in your patch. Can you please resend the patch? Daniel Juyung Seo (SeoZ) On Fri, Sep 28, 2012 at 10:04 PM, Bluezery ohpo...@gmail.com wrote: Dear EFL developers, In current genlist reorder mode, reordering is not moved when reordering item is on top or in bottom of within genlist objec because of scroller's hold mode. After mouse point is moved out of genlist object, then reordering item can be moved. But in mobile, mouse point can not be moved out of window (if genlist item is expanded in window). So I add some tweaks to reordering item can be moved when reordering item is moved on top item or bottom item. Please review this patch. BRs Kim. -- BRs, Kim. -- Got visibility? Most devs has no idea what their production app looks like. Find out how fast your code is with AppDynamics Lite. http://ad.doubleclick.net/clk;262219671;13503038;y? http://info.appdynamics.com/FreeJavaPerformanceDownload.html ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Got visibility? Most devs has no idea what their production app looks like. Find out how fast your code is with AppDynamics Lite. http://ad.doubleclick.net/clk;262219671;13503038;y? http://info.appdynamics.com/FreeJavaPerformanceDownload.html ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- BRs, Kim. genlist@add_fast_reorder.patch Description: Binary data -- Got visibility? Most devs has no idea what their production app looks like. Find out how fast your code is with AppDynamics Lite. http://ad.doubleclick.net/clk;262219671;13503038;y? http://info.appdynamics.com/FreeJavaPerformanceDownload.html___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Add Null Chekcing Routine in eet_lib
2012/9/6 Tom Hacohen tom.haco...@samsung.com: Raster and I completely agree here, so you can see most of my response in his email in his words. :) But there's one more thing I wanted to add: I love error-free and defensive coding, I think it's good and needed. I'm not arguing here whether we should write safe code or not, I'm arguing about the extent. For example, you want to have a safety switch on a gun, but you don't want one that prevents you from shooting fast and efficiently. So yeah, sometimes you have misfires, but that's the price you sometimes pay for performance, costs, and efficiency. I think we need checks, for example the magic checks in evas (and everywhere) are great. Why? Because the error cases we test there are actually plausible, we print an error and they can be disabled. We already agreed that the fact that the patch as is doesn't print any errors is bad, I guess you agree that such checks need to be possible to disable, so I only have to convince you about whether they needed in general or not, so I'll focus on that. I'm arguing that NULL checks everywhere are not really needed and they don't cover common cases. Yeah, in some cases they make sense, but in others, they do not. It's highly implausible that an eet file will be NULL, as those are usually handled locally in one context in which the values are known (I hope it's a good enough example). Following the same safe coding logic we should add magic checks everywhere, i.e to every struct we ever allocate, just because a user could pass an already freed pointer (for example). Again, the main point, is that we can only protect people from their mistakes to some extent, and I'm not sure the 0.083% increase of stability (if you call a completely misbehaving but not crashing app a stable one) is worth the extra effort, bloat and etc. Side note: are you sure people that write that crashing code actually look at the stdout/err prints and bother with fixing them? As I'd expect that type of people to just ignore the errors and say something like: ah, that's a library bug, not me, that print is not important. Yeah, most of them ignore. :( Anyway, I need to know whether there exist consistent policy for input parameter check in exported function entrance. or we can think on a case by case basis. I usually used EINA_SAFETY_ON_NULL_XX. -- Tom. On 05/09/12 19:14, Daniel Juyung Seo wrote: On Wed, Sep 5, 2012 at 11:31 PM, Tom Hacohen tom.haco...@samsung.com wrote: On 05/09/12 17:18, Daniel Juyung Seo wrote: On Wed, Sep 5, 2012 at 10:12 PM, Tom Hacohen tom.haco...@samsung.com wrote: Why should we? It makes really no sense. And if you want to rely on past experience i.e what people do, instead of sense, take a look at libc: free, strlen and strcpy are just a few of the many examples that don't accept NULL. Having sanity checks everywhere is not safer, it just hides bugs at best, slows everything down, bloats the code and makes me want to hate myself. I didn't say hide bugs. We should warn it by using error message. I didn't say slow things down. If we don't check NULL, all apps also have to check NULL for all EFL APIs anyway. No, apps can check in a centralized manner, i.e 1 check for multiple calls, and not check in many cases. It's not even slightly the same. Wrt hiding: you said you support the patch, and the patch doesn't print or do anything, it's just hiding bugs. No, I didn't say I support the patch, I just said we should check null at least for public apis. I didn't even read the patch. My email was against your email not the patch itself. I repeat. I don't want to hide bugs. I want my product to be stable in terms of crash and just warn it with error message for dumb users. Also, these tests in specific are not good enough. Such tests should be wrapped in macros that print a warning about the error case so users will avoid doing them in the future (if applicable), let you disable them, and are generally consistent. Yes, this is what I want. At least we should avoid crashing and warn them with error message. That's the least we should do if we decide to do checks. Also, there's a very limited list of reasons why to do sanity checks: 1. If only we can do and the user can't. 2. If the checks are a lot easier for us to do than the user. 3. Very common checks that should be everywhere and we'll be saving a ton of code by doing them ourselves, and no, this doesn't apply here. Two more things, 1. I don't trust users. 2. If EFL is used in your hobby project, I don't care. But if EFL is used in a real product, I will not allow apps to crash so easily only by calling EFL APIs with NULL. You use glibc, don't you? Why do you use it and strlen and not my_null_checking_strlen? Saying one thing is professional without backing it up is hardly an argument. Yeah, defensive programming is good, but only to some extent, some mistakes are just too
[E-devel] Questions about text min/max in edje
Dear all, I have a question about text part's min max in edje. If setting text part's min as 1, min value of this part is same as text string length. But I cannot stop to increase this part. If the text string is infinite, the part increases infinitely. I just want to increase the text part with certain maximum and if text is long, I want to use ellipsis. I used description.max but It cannot be used for this purpose. I attached an example program. In example, text part's length is same as text length (text's min is 1) and it grows from left. And red rectangle stick to right side of the text. I want to restrict the X or Y axis length of the text part. It will be my pleasure if someone help me. :) -- BRs, Kim. text_max.tar.gz Description: GNU Zip compressed data -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Questions about text min/max in edje
So the conclusion is ... text.min: 1 increase the text infinitely even though relative is specified. text.max: 1 limit the text for relative which is specified. In my case, text.min: 0 1; text.max: 1 0; text.align: 0 0.5; So the text is stretched from it's left relative to right relative. Thanks very much. :D 2012/9/4 Daniel Juyung Seo seojuyu...@gmail.com: One more thing to advice. You don't need to create c file to test edc. Use edje_watch + edje_viewer. That'll help you a lot and reduce your time. Daniel Juyung Seo (SeoZ) On Tue, Sep 4, 2012 at 3:59 AM, Daniel Juyung Seo seojuyu...@gmail.com wrote: Hello, Bluezery. This is easy to solve. Do not set text.min to 1. It will refuse ellipsis. What you need here is to restrict text part's area by using another rect part. Find text.limit part in my attachment. You can easily change my code to fit your needs. Thanks. Daniel Juyung Seo (SeoZ) On Mon, Sep 3, 2012 at 10:47 PM, Bluezery ohpo...@gmail.com wrote: Dear all, I have a question about text part's min max in edje. If setting text part's min as 1, min value of this part is same as text string length. But I cannot stop to increase this part. If the text string is infinite, the part increases infinitely. I just want to increase the text part with certain maximum and if text is long, I want to use ellipsis. I used description.max but It cannot be used for this purpose. I attached an example program. In example, text part's length is same as text length (text's min is 1) and it grows from left. And red rectangle stick to right side of the text. I want to restrict the X or Y axis length of the text part. It will be my pleasure if someone help me. :) -- BRs, Kim. -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- BRs, Kim. -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [E-Devel] Evas Textblock Bug
Hello, I have a problem when using TEXTBLOCK part in edje. Some tags are not seems to be applied when textblock style is chaned. I attach a simple test edc file for testing debugging. When mouse is over on text, text color is changed except letters which use match tag. One strange thing is that all letters' color is correctly changed if \n tag is used before match tag. I think that Tom can be helpful for find fix this problem. :) -- BRs, Kim. edje_example.edc Description: Binary data -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [patch] change plug-in loading behavior in elm_map
Hello, Elm_map have 3 modules (Tile, Route, Name) for plug-in loading When elm_map is added, each 3 modules search plug-ins (elm_map does use eina_module, not elm_module because elm_map loads several modules. ) Previously, Each modules in elm_map search modules separately. So module init /shutdown function in each plug-in is called 3times. This can cause problems. I fixed that module init is called at one time and module never be unloaded (in process life-cycle). Please review this patch. Thanks. -- BRs, Kim. elm_map@plug-in.patch Description: Binary data -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [patch] Fix minor documentation fix in genlist
Hello, This is minor fix (typo, nuance) for genlist documentation. Please review this patch Thanks. -- BRs, Kim. elm_genlist@fix_doc.patch Description: Binary data -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [patch]Fix reorder animator in genlist
Hello, Sometimes reorder animation ended incorrectly You can test see the problem when background color is black and genlist item color is white. I made the added value for animation as difference between old item position and new item position if difference is below predefined dy. (y = diff, if diff dy) So item position can be finally new item position at last. Please review this patch. Thanks -- BRs, Kim. elm_genlist@fix_reorder_anim.patch Description: Binary data -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch][elm_genlist] Free text parts when each item is unrealized
2012/7/27 Carsten Haitzler ras...@rasterman.com: On Thu, 26 Jul 2012 17:07:18 +0300 Tom Hacohen tom.haco...@samsung.com said: On 26/07/12 11:36, Carsten Haitzler (The Rasterman) wrote: but u recalc an empty text field as opposed to 500 chars of stuff to find the ellipsis point... :) Sure, I understand the benefits and I understand what's going on there, I'm just thinking that maybe we need a better solution than that. What I said above was just to verify what's going on there, what I think is needed to be done is what I said below. If a genlist item is unrealized, recalc is not needed anymore because all parts are not needed. So if you implement some features for this, it is better to use your APIs than my way in genlist. :) Anyway, this is the best way now. and It not only prevents recalc, but also removes unneeded memory. well it does save memory too - ie gets rid of text edje has to keep hold of that isnt used anymore :) i was just thinking that... I'm really starting to believe you have an eavesdropping device inside my head... :) MUHAHAHAHAHHAHA! -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- BRs, Kim. -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [Patch][elm_genlist] Free text parts when each item is unrealized
Hello, This patch make genlist free their text parts when each item is unrealized. Before this patch, the item is just cached when an item is unrealized and the text part is freed and set by other text when the cached item is realized. This improves scrolling performance with very long text because this can reduce needless edje size recalculation time. Please review this patch. -- BRs, Kim. genlist@free_text_part.patch Description: Binary data -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [Patch][Elementary]genlist - Fix vertical bounce enable value
Hello, Vertical bounce enable value can be changed by elementary configuration environment. But currently It was always EINA_FALSE. I fix that this value can be got from elm_config value. Please review this patch. Thanks -- BRs, Kim. fix_bounce_enable.patch Description: Binary data -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch][Elementary]genlist - Fix vertical bounce enable value
2012/7/12 Daniel Juyung Seo seojuyu...@gmail.com: What about h_bounce? And ChangeLog for bug fix? Backport is not needed at the moment though. I fixed Changelog also. Because h_bounce is EINA_FALSE when genlist is added, the value is correct currently. Daniel Juyung Seo (SeoZ) On Thu, Jul 12, 2012 at 1:00 AM, Bluezery ohpo...@gmail.com wrote: Hello, Vertical bounce enable value can be changed by elementary configuration environment. But currently It was always EINA_FALSE. I fix that this value can be got from elm_config value. Please review this patch. Thanks -- BRs, Kim. -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- BRs, Kim. fix_bounce_enable.patch Description: Binary data -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [Patch][Ecore] ecore_shutdown never return below zero
Dear EFL developers, This patch checks the internal value of ecore_shutdown() as Gustavo Sverzut Barbieri suggested in http://www.mail-archive.com/enlightenment-devel@lists.sourceforge.net/msg41829.html. If ecore_shtudown() makes internal values below zero, error message will be shown and internal value never be below zero. I have raised this issue previously also in http://www.mail-archive.com/enlightenment-devel@lists.sourceforge.net/msg41502.html Please review this patch. If this patch is OK, I will make patches for elementary or other modules. Thanks, -- BRs, Kim. ecore_shtudown.patch Description: Binary data -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] About ecore_pipe_add/del pair
2012/5/26 Vincent Torri vincent.to...@gmail.com: On Sat, May 26, 2012 at 4:03 AM, Bluezery ohpo...@gmail.com wrote: Hum.. I also do not want to guarantee that code :) I only want to discussed about int/shutdown. These can be called mixed because we can use many libraries (EFL or not) which use libraries (EFL or not) which use libraries (EFL or not), and so on i'm wondering if you have read what i previously said. Look at elm_init() : elm_init calls (i give only some of them) : eina_init ecore_init ecore_file_init evas_init edje_init ecore_con_init ecore_evas_init ecore_evas_init calls evas_init ecore_init and ecore_evas_sdl_new calls SDL_Init ecore_init calls eina_init evas_init calls eina_init eet_init eet_init call eina_init the initialisation function of libgcrypt look also edje_init, ecore_con_init, etc.. and you'll see that they also call ecore_init and eina_init and other ones. so what you described above is exactly what we are doing. Is there a problem ? No. Why ? Because we use correctly the init functions of the EFL and of other libs Vincent Yes, I have read :) Anyway, We have different point of view. I do not want to point out bugs or problems in EFL. I just want to say about something like conceptual points. I agreed with that EFL developers use correctly and also EFL libraries do. But I just say about OTHERS (MANY good bad developers in the world). If the EFL became more and more prosperous, I cannot predict how others use EFL. Even though I can use correctly, I cannot assert underlying libraries. (not of the EFL, but these libraries can use EFL somewhere). I want to find out places where we can improve without performance cost, conformable to general way. This is just my humble suggestion. I'm sorry to disturb you. I would better to end these discussion. :) -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- BRs, Kim. -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] About enlightenment contribution page
2012/5/26 Vincent Torri vincent.to...@gmail.com: On Sat, May 26, 2012 at 4:15 AM, Bluezery ohpo...@gmail.com wrote: Dear EFL developers, Contribution page(http://web.enlightenment.org/p.php?p=contributel=en???) have Building section to show how EFL source is built. But some required packages seems to be missing recently. Those are autopoint, libudev, xcb, xcb-shape. ecore need autopoint. eeze need libudev e need xcb and xcb-shape (libxcb-shape0-dev) I think that above packages are better to be shown in building section. libudev is listed (in optional packages just below) Note that autopoint comes with gettext, which is listed xcb-shape comes with xcb (if we compile xcb from sources). Btw, there are more X extensions than just xcb-shape which are used (in ecore, for ecore_x). XCB is optional, btw. But, without xcb, I cannot build E at all. Is this better to move from optional packages to required packages in doc? And I have found below in gettext debian change log. These are related to debian and it's offspring. + Drop autopoint recommends of gettext. It pulls in git and other sizable packages which make the CDs explode. + Bump Replaces on gettext and Conflicts on autopoint to ( 0.18-1) rather than (= 0.17-11), to accommodate previous Ubuntu versions. Vincent -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- BRs, Kim. -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] About ecore_pipe_add/del pair
2012/5/24 Carsten Haitzler ras...@rasterman.com:
On Thu, 24 May 2012 00:25:09 -0300 Gustavo Sverzut Barbieri
barbi...@profusion.mobi said:
You cannot cover all libraries as supposedly there will always be third party
libs following that pattern. So far we can do many, but it's impossible to
guarantee all.
sure - and for those libraries - you need to follow their setup/shutdown
mechanisms. for efl we have covered it all for the user - as of elementary we
have.
The underyling assumption is that init/shutdown is properly used for all cases.
But in some cases, it does not. :( There can exist so many
libraries/applications/bugs/people to use EFL. We can not control all
those things and people. Furthermore, in top level application
developers's point of view, they should inspect all static/dynamic
libraries they use and find bugs and send patches and wait those are
fixed, and so on. This may be the best way theoretically. ;)
So I want that EFL init/shutdown functions can manage these problems
nicely. I mentioned this as previous mail
(http://www.mail-archive.com/enlightenment-devel@lists.sourceforge.net/msg41502.html).
I do not know exactly where return value of init/shutdown is used for.
Actually current counter value does not check whether init/shutdown
is called or not if init/shutdown is not used properly/correctly as we
expected. Also almost documentations do not warn or remark users about
this.
So IMHO, I suggest that init/shutdown are better to be changed to
support disordered usage.
Or at least documentation should warn/remark about that.
--Gustavo
Sent from my iPhone
On 24/05/2012, at 00:20, Carsten Haitzler (The Rasterman)
ras...@rasterman.com wrote:
On Wed, 23 May 2012 22:50:10 -0300 Gustavo Sverzut Barbieri
barbi...@profusion.mobi said:
As I tried to explain you save lines of code, adds inconsistencies since
elementary will not be able to cover everything. Unfortunately we disagree
on the best approach.
it already covers all of core efl. when there is a single efl tree it'll
cover everything in that tree. it wont be inconsistent. it's already pretty
consistent.
--Gustavo
Sent from my iPhone
On 23/05/2012, at 21:04, Carsten Haitzler (The Rasterman)
ras...@rasterman.com wrote:
On Wed, 23 May 2012 13:03:42 -0300 Gustavo Sverzut Barbieri
barbi...@profusion.mobi said:
On Wed, May 23, 2012 at 7:49 AM, Carsten Haitzler ras...@rasterman.com
wrote:
On Mon, 7 May 2012 19:09:45 +0900 (KST) Jiyoun Park
jijib...@naver.com
said:
hmm realistically ecore_init and shutdown (same really with almost any
efl api) is intended to be run ONCE per process and the shutdown once
at
process termination. not multiple times. it's a lot harder to make this
always work in the repeated init/shutdown case and frankly was never
intended for this or tested and implemented for it. my suggestion: only
init once and shut down once. :)
I know you wrote this based on an application writer point of view.
But given this is a generic mail list, please make the following
remark visible:
- always init and shutdown ONCE per your CALL SITE usage.
That means: if you write an app that uses ecore_* symbols, always call
ecore_init() and ecore_shutdown() from your app. Even if you get that
ecore_* from elementary_init()[1]. This consistency will save you
headaches in the future. And this rule easily applies to library,
being consistent everywhere. Actually it is the case to solve DSO
problems in linkage, pkg-config problems and so on.
[1] I know many of us don't do ecore_init(), evas_init(),
eina_init()... and so on when using elementary_init(). Saves typing,
but is bad for consistency. If you explicitly use these symbols, as we
often do, then it's better to explicitly call them and avoid issues.
If you're experienced enough to skip them, do it but do not RECOMMEND
it to people :-) [if you don't call any ecore_evas_*, then there is
no need to ecore_evas_init()...]
this isn't sustainable. then evewry app begins with a ridiculous list of
inits:
eina_init();
ecore_init();
evas_init();
edje_init();
elementary_init();
at a minimum.; if you have config of your own, need to deal with
thumbnails, do some dbus and freedesktop stuff add:
eet_init();
ethumb_init();
e_dbus_init();
efreet_init();
...
no - the POINT of elementary is to cut this out and bring down the
barrier
of entry to writing an app. you SHOULD use elm's main setup:
#include Elementary.h
EAPI_MAIN int elm_main(int argc, char **argv)
{
// if you want efl to handle finding your bin/lib/data dirs for u, you
must // do this below.
elm_app_info_set(elm_main, datadir, some-data-file);
elm_app_compile_bin_dir_set(PACKAGE_BIN_DIR);
elm_app_compile_data_dir_set(PACKAGE_DATA_DIR);
// do your setup code here - create window etc. no init/shutdown
needed
if // its a lib supported by elm,
Re: [E-devel] Ecore : Strange delay with timers and main loop
Multiple init/shutdown may be not related to this issue. I removed duplicated init/shutdown but problem still exist. When ecore_con_url init, one timer is created and freezed. and this timer is thawed when ecore_con_url_get() is called. This timer is not called until exactly same seconds of sleep when second ecore_main_loop_begin() starts. Multiple call of ecore_main_loop_begin() might affect these ecore_timer I guess. 2012/5/25 Carsten Haitzler ras...@rasterman.com: On Thu, 24 May 2012 18:01:29 +0200 Pierre-Olivier Huguet pierre-olivier.hug...@asp64.com said: is there any reason u cant just init ecore once for the process and shut it down once? not continually init/shut down both ecore and ecore-con etc. etc. remember all these efl init/shutdowns were designed for and tested for being done ONCE per app - ie init at start and shutdown to clean up at end. u can run the mainloop multiple times tho... tho unusual, this should work. Hello, I'm working on old programs that we can't migrate in *full EFL* right now. Causing sometimes stranges behaviours... In this case, I have several functions with ecore_main_loop_begin(), and a complete_cb with ecore_main_loop_quit(). The issue I'm facing happens when instructions - not related to ecore - are executed between 2 main_loop functions. I made a small sample program, (see attached) with : - ecore main loop begin, ecor con url get, callback complete : ecore main loop quit - other instructions (here, just 3 sleep of 10s each) - ecore main loop begin, ecor con url get, callback complete : ecore main loop quit The first call takes 1s max, the sleep 30s, the last call takes 30s too... Am I missing something ? I know we should use the main loop once, but that's impossible right now. That's why I need your help ! Thx -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler) ras...@rasterman.com -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- BRs, Kim. -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] About ecore_pipe_add/del pair
2012/5/25 Vincent Torri vincent.to...@gmail.com:
On Fri, May 25, 2012 at 9:41 AM, Bluezery ohpo...@gmail.com wrote:
2012/5/24 Carsten Haitzler ras...@rasterman.com:
On Thu, 24 May 2012 00:25:09 -0300 Gustavo Sverzut Barbieri
barbi...@profusion.mobi said:
You cannot cover all libraries as supposedly there will always be third
party
libs following that pattern. So far we can do many, but it's impossible to
guarantee all.
sure - and for those libraries - you need to follow their setup/shutdown
mechanisms. for efl we have covered it all for the user - as of elementary
we
have.
The underyling assumption is that init/shutdown is properly used for all
cases.
But in some cases, it does not. :( There can exist so many
libraries/applications/bugs/people to use EFL. We can not control all
those things and people. Furthermore, in top level application
developers's point of view, they should inspect all static/dynamic
libraries they use and find bugs and send patches and wait those are
fixed, and so on. This may be the best way theoretically. ;)
So I want that EFL init/shutdown functions can manage these problems
nicely. I mentioned this as previous mail
(http://www.mail-archive.com/enlightenment-devel@lists.sourceforge.net/msg41502.html).
we CAN NOT predict how a lib is used by people. But we CAN
say/document how it must be used. If it's documented and the user does
not follow the rules, then it's his problem, not ours. In addition,
that kind of _init()/_shutdown() is so much used in the same maner in
libraries that it's useless to add more checks. There is one rule :
_init() at the beginning of the program, _shutdown() at its end. End
of discussion.
I do not know exactly where return value of init/shutdown is used for.
usually, the returned value of _init is checked. If 0, it failed. I've
never used the returned value of _shutdown, but you can :
int main()
{
if (!ecore_init())
return -1;
// your code
if (ecore_shutdown() != 0)
{
printf(error during shutdown\n);
return -1;
}
return 0;
}
This code assumes that users use init/shutdown CORRECTLY. But
init/shutdown can return non-zero even though init/shutdown actually
do nothing because init/shutdown is not correctly used in other places
What about the below cases?? those seems to be ridiculous but I do
not guarantee below does not happen even though I do correctly :(
because others can do not.
* ecore_shutdown (-1) -- ecore_shutdown (-2) -- ecore_init (-1)
If ecore_shutdown is called twice, ecore_init() should be called 3
times. So user should check return value in this case.
Also elm_init/shutdown are somewhat different from ecore_init/shtudown
in the code.
* elm_init ( 1) -- elm_shutdown (0) -- elm_shutdown(-1)
success! -- success! -- fail? (but last shutdown() do duplicated
finalization jobs.)
I think that this may be bug if guarantee.
So I have questions:
(1) EFL do not guarantee this incorrect/disordered usage? Actually I
want to guarantee :)
(2) If guarantee, init should be called 3 times if shutdown() is
called twice? I want once. :)
Above are just humble opinions.
Actually current counter value does not check whether init/shutdown
is called or not if init/shutdown is not used properly/correctly as we
expected. Also almost documentations do not warn or remark users about
this.
the counter is used for indirect calls, like:
ecore_init();
ecore_evas_init(); // ecore_evas_init() calls ecore_init(); so
ecore_init() code is not called a second time
same for _shutdown()
If so, Is Eina_Bool just enough? :)
So IMHO, I suggest that init/shutdown are better to be changed to
support disordered usage.
Or at least documentation should warn/remark about that.
it should (must) be in the doc and tutorials. If it's not let's add it
Vincent
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
BRs,
Kim.
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net
Re: [E-devel] About ecore_pipe_add/del pair
2012/5/25 Iván Briano sachi...@gmail.com:
2012/5/25 Bluezery ohpo...@gmail.com:
2012/5/25 Vincent Torri vincent.to...@gmail.com:
On Fri, May 25, 2012 at 9:41 AM, Bluezery ohpo...@gmail.com wrote:
2012/5/24 Carsten Haitzler ras...@rasterman.com:
On Thu, 24 May 2012 00:25:09 -0300 Gustavo Sverzut Barbieri
barbi...@profusion.mobi said:
You cannot cover all libraries as supposedly there will always be third
party
libs following that pattern. So far we can do many, but it's impossible
to
guarantee all.
sure - and for those libraries - you need to follow their setup/shutdown
mechanisms. for efl we have covered it all for the user - as of
elementary we
have.
The underyling assumption is that init/shutdown is properly used for all
cases.
But in some cases, it does not. :( There can exist so many
libraries/applications/bugs/people to use EFL. We can not control all
those things and people. Furthermore, in top level application
developers's point of view, they should inspect all static/dynamic
libraries they use and find bugs and send patches and wait those are
fixed, and so on. This may be the best way theoretically. ;)
So I want that EFL init/shutdown functions can manage these problems
nicely. I mentioned this as previous mail
(http://www.mail-archive.com/enlightenment-devel@lists.sourceforge.net/msg41502.html).
we CAN NOT predict how a lib is used by people. But we CAN
say/document how it must be used. If it's documented and the user does
not follow the rules, then it's his problem, not ours. In addition,
that kind of _init()/_shutdown() is so much used in the same maner in
libraries that it's useless to add more checks. There is one rule :
_init() at the beginning of the program, _shutdown() at its end. End
of discussion.
I do not know exactly where return value of init/shutdown is used for.
usually, the returned value of _init is checked. If 0, it failed. I've
never used the returned value of _shutdown, but you can :
int main()
{
if (!ecore_init())
return -1;
// your code
if (ecore_shutdown() != 0)
{
printf(error during shutdown\n);
return -1;
}
return 0;
}
This code assumes that users use init/shutdown CORRECTLY. But
init/shutdown can return non-zero even though init/shutdown actually
do nothing because init/shutdown is not correctly used in other places
What about the below cases?? those seems to be ridiculous but I do
not guarantee below does not happen even though I do correctly :(
because others can do not.
* ecore_shutdown (-1) -- ecore_shutdown (-2) -- ecore_init (-1)
If ecore_shutdown is called twice, ecore_init() should be called 3
times. So user should check return value in this case.
Also elm_init/shutdown are somewhat different from ecore_init/shtudown
in the code.
* elm_init ( 1) -- elm_shutdown (0) -- elm_shutdown(-1)
success! -- success! -- fail? (but last shutdown() do duplicated
finalization jobs.)
I think that this may be bug if guarantee.
void some_function()
{
Evas_Object *obj;
evas_object_move(obj, 0, 0);
}
That code is wrong, but users may write something like that,
should we try to avoid crashing when an invalid pointer is received?
It can be done with a lot of awful and hackish code, or we can say
Write proper code or your shit won't work
Hum.. I also do not want to guarantee that code :)
I only want to discussed about int/shutdown. These can be called
mixed because we can use many libraries (EFL or not) which use
libraries (EFL or not) which use libraries (EFL or not), and so on
Preventing this seems to be not so hard.
Anyway, if core EFL developers do not want this, End Of Discussion
Thanks. :)
So I have questions:
(1) EFL do not guarantee this incorrect/disordered usage? Actually I
want to guarantee :)
(2) If guarantee, init should be called 3 times if shutdown() is
called twice? I want once. :)
Above are just humble opinions.
Actually current counter value does not check whether init/shutdown
is called or not if init/shutdown is not used properly/correctly as we
expected. Also almost documentations do not warn or remark users about
this.
the counter is used for indirect calls, like:
ecore_init();
ecore_evas_init(); // ecore_evas_init() calls ecore_init(); so
ecore_init() code is not called a second time
same for _shutdown()
If so, Is Eina_Bool just enough? :)
So IMHO, I suggest that init/shutdown are better to be changed to
support disordered usage.
Or at least documentation should warn/remark about that.
it should (must) be in the doc and tutorials. If it's not let's add it
Vincent
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http
[E-devel] About enlightenment contribution page
Dear EFL developers, Contribution page(http://web.enlightenment.org/p.php?p=contributel=en???) have Building section to show how EFL source is built. But some required packages seems to be missing recently. Those are autopoint, libudev, xcb, xcb-shape. ecore need autopoint. eeze need libudev e need xcb and xcb-shape (libxcb-shape0-dev) I think that above packages are better to be shown in building section. Thanks. -- BRs, Kim. -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch][Efreet] Add parameter checking to exported API (efreet_desktop)
2012/5/22 Christopher Michael cpmicha...@comcast.net: On 05/21/12 16:34, Sebastian Dransfeld wrote: On 05/21/2012 08:24 AM, Bluezery wrote: Hello, Some efreet APIs do not check input parameters. So I add checking by using EINA_SAFETY_ON_XXX(). ISO/IEC statndards says that If an argument to a function has an invalid value, behavior is undefined . But this is just for the primitive functions such as libc. I think that parameter checking is needed in at least EFL exported APIs This I 150% support (Not the use of Eina, but rather the checking) !! Exported APIs need to be clean EFL needs lots of param checking. Has been missing for a bit of time now. I try to add it as I go, but not everyone is supportive. Some do see it as a wasted variable check ... but I would rather KNOW that the stuff I am working with IS valid first, before I start to work with it ;) ... If not, then what's left ? A Guess that the variable is valid ??? No thanks ;) to prevent run-time abnormal behavior. Bail out nicely if you can ... ;) EINA_SAFTETY_ON_XXX are better than if (xxx) return because it gives error message and can be maintainable. But adds some overhead for the logging. 'if (xxx) return' is easier to read then chasing down (in a bunch of source code) some obscure macros that nobody knowsand printf is cheap (afaik), easily removed... Yes, if is easier and cheaper than EINA_SAFETY_XXX. But I prefer EINA_SAFETY_XXX. :) because it can prevent NORMAL user(like me)'s wrong usage by finding bugs more easily (by logging overhead). and logging overhead can be reduced by using disable eina safety check flags when eina is built. Anyway, It's a matter of taste. :D and Thank you for your comments. Actually these may be needed for some static internal functions. But I did not add. If this patches would be acceptable, I will add these checking into other efreet files (efreet_menu, efreet_base, etc.) Patch is fine. Just add to other efreet files and I will commit. Finally I made a patch. please review this patch again. If this patch is in, we should fix applications by seeing error messages originated from this changes such as elementary_config. :) S. Seb, as long as you approve it then no worries ;) Never got into efreet...least not much past the initial fdo support but I trust Seb. He's been here for a long long LONG time... Cheers, dh -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- BRs, Kim. efreet@add_param_check.diff Description: Binary data -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib
2012/5/23 Hyoyoung Chang hyoyo...@gmail.com:
Maybe it's best time to talk about sizeof(char)
Do we need to sizeof(char)? I just that is problem of coding convention.
such as (a == 0) and (!a).
Is there any predefined convention about this case?
sizeof(char) may be larger (in the future if we use unicode :p) than
1. but I haven't seen yet. :)
On Wed, May 23, 2012 at 10:52 AM, ChunEon Park her...@naver.com wrote:
FYI, sizeof will be computed at the compile time.
-Original Message-
From: ChunEon Parklt;her...@naver.comgt;
To: lt;enlightenment-devel@lists.sourceforge.netgt;;
lt;enlightenment-...@lists.sourceforge.netgt;;
Cc:
Sent: 2012-05-23 (수) 10:49:24
Subject: Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib
The most I prefer is to use sizeof( variable );
No harmful for performance and would be better if the buffer type is changed.
-Original Message-
From: Enlightenment SVNlt;no-replygt;@enlightenment.orggt;
To: lt;enlightenment-svngt;@lists.sourceforge.netgt;;
Cc:
Sent: 2012-05-23 (수) 09:53:08
Subject: E SVN: hyoyoung trunk/elementary/src/lib
Log:
elementary/cnp: don't calc sizeof char at buffer malloc
Author: hyoyoung
Date: 2012-05-22 17:53:07 -0700 (Tue, 22 May 2012)
New Revision: 71337
Trac: http://trac.enlightenment.org/e/changeset/71337
Modified:
trunk/elementary/src/lib/elm_cnp.c
Modified: trunk/elementary/src/lib/elm_cnp.c
===
--- trunk/elementary/src/lib/elm_cnp.c2012-05-23 00:51:11 UTC (rev 71336)
+++ trunk/elementary/src/lib/elm_cnp.c2012-05-23 00:53:07 UTC (rev 71337)
@@ -785,7 +785,7 @@
char *mkupstr;
data = notify-gt;data;
- str = malloc(sizeof(char) * (data-gt;length + 1));
+ str = malloc((data-gt;length + 1));
if (!str) return 0;
strncpy(str, (char *)data-gt;data, data-gt;length);
str[data-gt;length] = '\0';
@@ -840,7 +840,7 @@
}
else
{
- stripstr = p = malloc(data-gt;length * sizeof(char) + 1);
+ stripstr = p = malloc(data-gt;length + 1);
if (!stripstr) return 0;
memcpy(stripstr, data-gt;data, data-gt;length);
stripstr[data-gt;length] = 0;
@@ -985,7 +985,7 @@
cnp_debug(Got some HTML: Checking encoding is useful\n);
data = notify-gt;data;
- char *stripstr = malloc(sizeof(char) * (data-gt;length + 1));
+ char *stripstr = malloc(data-gt;length + 1);
if (!stripstr) return 0;
strncpy(stripstr, (char *)data-gt;data, data-gt;length);
stripstr[data-gt;length] = '\0';
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-svn mailing list
enlightenment-...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
BRs,
Kim.
Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib
2012/5/23 Joerg Sonnenberger jo...@britannica.bec.de: On Wed, May 23, 2012 at 05:56:10PM +0900, Bluezery wrote: 2012/5/23 Hyoyoung Chang hyoyo...@gmail.com: Maybe it's best time to talk about sizeof(char) Do we need to sizeof(char)? I just that is problem of coding convention. such as (a == 0) and (!a). Is there any predefined convention about this case? sizeof(char) may be larger (in the future if we use unicode :p) than 1. but I haven't seen yet. :) The C standard explicitly defines it as one. Are you thinking about wchar_t? Joerg How about c++?? -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- BRs, Kim. -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib
2012/5/23 Vincent Torri vincent.to...@gmail.com: On Wed, May 23, 2012 at 12:50 PM, Bluezery ohpo...@gmail.com wrote: 2012/5/23 Joerg Sonnenberger jo...@britannica.bec.de: On Wed, May 23, 2012 at 05:56:10PM +0900, Bluezery wrote: 2012/5/23 Hyoyoung Chang hyoyo...@gmail.com: Maybe it's best time to talk about sizeof(char) Do we need to sizeof(char)? I just that is problem of coding convention. such as (a == 0) and (!a). Is there any predefined convention about this case? sizeof(char) may be larger (in the future if we use unicode :p) than 1. but I haven't seen yet. :) The C standard explicitly defines it as one. Are you thinking about wchar_t? Joerg How about c++?? same (of course), as any C prog must be run without differences when compiled with a c++ compiler. Nevertheless, look at this: http://www.parashift.com/c++-faq-lite/new/sizeof-char.html Vincent Thank you for the link. I have to study harder !!! Anyway, c standard also says it's 1. :p http://www.open-std.org/JTC1/SC22/WG21/docs/papers/2011/n3242.pdf -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- BRs, Kim. -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch][elm_config]check if input value, cache_flush_poll_interval is greater than zero
2012/5/24 Carsten Haitzler ras...@rasterman.com: On Mon, 21 May 2012 16:12:16 +0900 Bluezery ohpo...@gmail.com said: Hello, _elm_config-cache_flush_poll_interval is used for flushing cache by ecore poller. If this value is not greater than 0, poller is disabled. But, I think that this value should be greater than 0 because there already exists cache_flush_enable for enable/disable cache poller. Please review this patch. Thanks. this is testing for sanity. remember these config values come from on-disk files or properties that could be corrupted. a poll interval of 0 makes no sense. :/ so... what is this fixing? :) I overlooked the config value. Anyway, this patch is not in and just documentation was fixed. B-) IMHO, if below zero makes no sense, the input parameter type could be better to be changed from int to unsigned int and from EET_T_INT to EET_T_UINT at next release. -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler) ras...@rasterman.com -- BRs, Kim. -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [Patch][Efreet] Add parameter checking to exported API (efreet_desktop)
Hello, Some efreet APIs do not check input parameters. So I add checking by using EINA_SAFETY_ON_XXX(). ISO/IEC statndards says that If an argument to a function has an invalid value, behavior is undefined . But this is just for the primitive functions such as libc. I think that parameter checking is needed in at least EFL exported APIs to prevent run-time abnormal behavior. EINA_SAFTETY_ON_XXX are better than if (xxx) return because it gives error message and can be maintainable. Actually these may be needed for some static internal functions. But I did not add. If this patches would be acceptable, I will add these checking into other efreet files (efreet_menu, efreet_base, etc.) -- BRs, Kim. efreet@add_param_check.diff Description: Binary data -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [Patch][elm_datetime] Fix documentation
Hello, I fixed documentation typos. elm_datetime_value_get() returns EINA_BOOL, not integer. -- BRs, Kim. elm_datetime@fix_doc.patch Description: Binary data -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [Patch][elm_config]check if input value, cache_flush_poll_interval is greater than zero
Hello, _elm_config-cache_flush_poll_interval is used for flushing cache by ecore poller. If this value is not greater than 0, poller is disabled. But, I think that this value should be greater than 0 because there already exists cache_flush_enable for enable/disable cache poller. Please review this patch. Thanks. -- BRs, Kim. elm_config@check_input_size.patch Description: Binary data -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [Patch][elc_ctxpopup] Remove
Hello, When ctx_popup is deleted, it calls elm_widget_sub_object_del(parent, popup) so that ctx_popup's parent can delete it's sub_ojbect, ctx_popup. But this is not needed because parent already deletes it's sub-object in elm_widget.c Thanks -- BRs, Kim. ctxpopup@remove_unnecessary_code.patch Description: Binary data -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch][elc_ctxpopup] Remove
2012/5/21 Daniel Juyung Seo seojuyu...@gmail.com: Yes, Hermet is right. Btw, bluezery, is there any problem with this code? Daniel Juyung Seo (SeoZ) No problem actually :) But elm_win holds NULL sub-object after ctx_popup is deleted. This is a potential problem. And error message is unpleasant to me :( On Mon, May 21, 2012 at 7:13 PM, ChunEon Park her...@naver.com wrote: No. It should be called when parent is changed with elm_ctxpopup_hover_parent_set. In this case, parent wouldn't be deleted. Yes, you're right. I fixed my patch. elm_widget_sub_object_del() is called in elm_ctxpopup_hover_parent_set(), not in _parent_cut_off(). But in this patch, _parent_cut_off() function do not cut off all parent things. There may need to change the function name. -Regards, Hermet- -Original Message- From: Bluezerylt;ohpo...@gmail.comgt; To: Enlightenment developer listlt;enlightenment-devel@lists.sourceforge.netgt;; Cc: Sent: 2012-05-21 (월) 17:32:15 Subject: [E-devel] [Patch][elc_ctxpopup] Remove Hello, When ctx_popup is deleted, it calls elm_widget_sub_object_del(parent, popup) so that ctx_popup's parent can delete it's sub_ojbect, ctx_popup. But this is not needed because parent already deletes it's sub-object in elm_widget.c Thanks -- BRs, Kim. -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- BRs, Kim. ctxpopup@remove_unnecessary_code.patch Description: Binary data -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch][elm_map] Add elm_map_overlays_get elm_map_overlay_visible_get
2012/5/15 Bluezery ohpo...@gmail.com: 2012/5/14 Hyoyoung Chang hyoyo...@gmail.com: It works well, and pretty nice feature. diffs are good to me. In _overlay_show(Elm_Map_Overlay *overlay), there's many if statements. how about to change switch/case? Thank you for your comments :) Yes, switch looks better than if in this case. I fixed that. And Merged NEWS, Changelog also. Please review again. On Fri, May 4, 2012 at 2:29 PM, Bluezery ohpo...@gmail.com wrote: Dear EFL developers, I want to add 2 new APIs (elm_map_overlays_get elm_map_overlay_visible_get). There are no way to get the group overlays because group overlay, something like virtual overlay, is created and deleted dynamically. So elm_map_overlays_get returns total overlay's list and user can get any type of overlays including group overlays. Overlays which is grouped can not be visible. Because overlay grouping is performed by elm_map, user do not know whether overlays are visible or not. So elm_map_overlay_visible_get is added for this reason. Thanks -- BRs, Kim. -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- BRs, Kim. Bump up :D Changelog and NEWS are Merged. -- BRs, Kim. map@add_overlay_api.diff Description: Binary data -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Questions about initilization functions such as elm_init() and ecore_init(), etc.
Dear EFL developers, I have questions about initialization/unintialization functions in EFL such as elm_init(), ecore_init(), elm_shutdown(), etc. Those functions have interval static counter variables such as _ecore_init_count. And If xxx_init() is called, a counter variable increases by 1 and if xxx_shutdown() is called, it decreases. However, I think that those confuse users (application developers) somewhat. For example, if ecore_shutdown() is called twice and ecore_init() is called once after that, nothing is initialized. Because after _ecore_init_count variable become 1, ecore_init() do evil_init() or eina_init(), etc. It seems that ecore_init() should be called 3 times after ecore_shutdown() is called twice. All other xxx_init, xxx_shutdown() pairs in EFL do same behavior. IMHO, After ecore_shutdown() is called many times, calling ecore_init() once should do initialization. Of course, If ecore_init() is called 10 times, ecore_shutdown() should do unintialization at the moment ecore_shutdown() is called 11 time. Also return value is somewhat confusing. In documentation of ecore_init() and ecore_shutdown(), It succeed if return value is 1 and it fail if it is 0. But it returns static counter variable. This may need documentation modification in ecore. And other xxx_init() and xxx_shutdown() are better to have same pattern. Please solve my curiosity :) Thanks. -- BRs, Kim. -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Questions about initilization functions such as elm_init() and ecore_init(), etc.
2012/5/18 Vincent Torri vincent.to...@gmail.com: On Thu, May 17, 2012 at 4:51 PM, Bluezery ohpo...@gmail.com wrote: Dear EFL developers, I have questions about initialization/unintialization functions in EFL such as elm_init(), ecore_init(), elm_shutdown(), etc. Those functions have interval static counter variables such as _ecore_init_count. And If xxx_init() is called, a counter variable increases by 1 and if xxx_shutdown() is called, it decreases. However, I think that those confuse users (application developers) somewhat. For example, if ecore_shutdown() is called twice and ecore_init() is called once after that, nothing is initialized. Because after _ecore_init_count variable become 1, ecore_init() do evil_init() or eina_init(), etc. It seems that ecore_init() should be called 3 times after ecore_shutdown() is called twice. All other xxx_init, xxx_shutdown() pairs in EFL do same behavior. IMHO, After ecore_shutdown() is called many times, calling ecore_init() once should do initialization. Of course, If ecore_init() is called 10 times, ecore_shutdown() should do unintialization at the moment ecore_shutdown() is called 11 time. Also return value is somewhat confusing. In documentation of ecore_init() and ecore_shutdown(), It succeed if return value is 1 and it fail if it is 0. But it returns static counter variable. This may need documentation modification in ecore. And other xxx_init() and xxx_shutdown() are better to have same pattern. It's up to te user to call once the _init function at the beginning of the program and the _shutdown() function at the end of the program. Any other use is not our problem. The counter is there for indirect calls of the init/sutdown functions (like ecore_evas_init that calls ecore_init and evas_init for example) Vincent Yes, actually it's a user fault. But I hope that EFL can handle this user's mistake more user friendly :D -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- BRs, Kim. -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch][elm_map] Add elm_map_overlays_get elm_map_overlay_visible_get
2012/5/14 Hyoyoung Chang hyoyo...@gmail.com: It works well, and pretty nice feature. diffs are good to me. In _overlay_show(Elm_Map_Overlay *overlay), there's many if statements. how about to change switch/case? Thank you for your comments :) Yes, switch looks better than if in this case. I fixed that. And Merged NEWS, Changelog also. Please review again. On Fri, May 4, 2012 at 2:29 PM, Bluezery ohpo...@gmail.com wrote: Dear EFL developers, I want to add 2 new APIs (elm_map_overlays_get elm_map_overlay_visible_get). There are no way to get the group overlays because group overlay, something like virtual overlay, is created and deleted dynamically. So elm_map_overlays_get returns total overlay's list and user can get any type of overlays including group overlays. Overlays which is grouped can not be visible. Because overlay grouping is performed by elm_map, user do not know whether overlays are visible or not. So elm_map_overlay_visible_get is added for this reason. Thanks -- BRs, Kim. -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- BRs, Kim. map@overlay_api_2.diff Description: Binary data -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [Patch][elm_map] Add elm_map_overlays_get elm_map_overlay_visible_get
Dear EFL developers, I want to add 2 new APIs (elm_map_overlays_get elm_map_overlay_visible_get). There are no way to get the group overlays because group overlay, something like virtual overlay, is created and deleted dynamically. So elm_map_overlays_get returns total overlay's list and user can get any type of overlays including group overlays. Overlays which is grouped can not be visible. Because overlay grouping is performed by elm_map, user do not know whether overlays are visible or not. So elm_map_overlay_visible_get is added for this reason. Thanks -- BRs, Kim. map@overlay_api.patch Description: Binary data -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] map issue
2012년 4월 26일 오후 12:34, Carsten Haitzler ras...@rasterman.com님의 말: On Thu, 26 Apr 2012 01:43:56 +0200 Michaël Bouchaud y...@efl.so said: flkoat thing should be fixed now - but scroller in scroller... THAT is an issue always. it's nasty to make it work - there is code to try. right now i just suggest dont do it and if u do limit scrollers to dimensions - ie 1 vertical, 1 horizontal only. Hi About elementary release, one of mine dev notice me some problem about map widget. Localization about atof... french separator is , (comma) but common is .(dot) in float string :) maybee, we could use eina_convert_atod here. secondly if you use one scroller with the map widget, you could encounter some problems. I explain me, zoom the map widget, move to some point... now drag the second scoller, you have the issue :P. Don't know where is the problem... maybee some events race. If you click somewhere after dragging, everything goes well. See attached file. Both outer scroller map scroller can get both mouse wheel events when your mouse pointer is on the map widget. |In map widget, mouse wheel event can be blocked by elm_map_wheel_disabled_set(). But, there might be no way to block the outer scroller's wheel event. -- Michaël Bouchaud (yoz) y...@efl.so -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler) ras...@rasterman.com -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- BRs, Kim. -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [Patch] elm_widget_sub_object_add() need to check if obj == sobj
Hello, Currently, elm_widget_sub_object_add() does not check if obj and sobj are same object. Actually it is a user problem if user add object itself as it's sub object. But I think that this checking is needed and it is better to give error logs to users. Because it causes infinite loop and it is hart to debugging. :( Thanks. -- BRs, Kim. elm_widget@check_same_obj.patch Description: Binary data -- Better than sec? Nothing is better than sec when it comes to monitoring Big Data applications. Try Boundary one-second resolution app monitoring today. Free. http://p.sf.net/sfu/Boundary-dev2dev___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch][eina] Add -ldl to eina.pc
2012/4/4 Vincent Torri vincent.to...@gmail.com: should be good, now Thanks. :) Anyway, can I know the differences between EFL_DLOPEN_LIBS and EFL_DLOPEN_LIBS ?? Those return same variable, -ldl. So eina.pc has duplicated -ldl in Libs.private field. I think that if EFL_CHECK_DLOPEN() and EFL_CHECK_DLADDR() can share the same variable something like EFL_DLL_LIBS for -ldl. Vincent On Mon, Apr 2, 2012 at 11:07 AM, Vincent Torri vincent.to...@gmail.com wrote: please, do not apply there is another problem with dlopen (because of autoconf cache). I'll fix that this evening. Vincent On Mon, Apr 2, 2012 at 10:31 AM, Bluezery ohpo...@gmail.com wrote: Hello, This patch adds -ldl to Libs.private in eina.pc If libraries are internally used and not recognized by pkg-config, those should be added to Libs.private. It can be used when static linking. Thanks. -- BRs, Kim. -- This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Better than sec? Nothing is better than sec when it comes to monitoring Big Data applications. Try Boundary one-second resolution app monitoring today. Free. http://p.sf.net/sfu/Boundary-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- BRs, Kim. -- Better than sec? Nothing is better than sec when it comes to monitoring Big Data applications. Try Boundary one-second resolution app monitoring today. Free. http://p.sf.net/sfu/Boundary-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [Patch][eina] Add -ldl to eina.pc
Hello, This patch adds -ldl to Libs.private in eina.pc If libraries are internally used and not recognized by pkg-config, those should be added to Libs.private. It can be used when static linking. Thanks. -- BRs, Kim. eina@fix_pc.patch Description: Binary data -- This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch][eina_module] Add eina_module_resident() API
2012/4/2 Carsten Haitzler ras...@rasterman.com: On Sat, 31 Mar 2012 21:33:50 +0900 Bluezery ohpo...@gmail.com said: 2012/3/30 Gustavo Sverzut Barbieri barbi...@profusion.mobi: On Fri, Mar 30, 2012 at 3:43 AM, Bluezery ohpo...@gmail.com wrote: Hello, I want to add new eina_module_resident() API in eina_modules. This function makes the module never be unloaded before process is closed. This is needed in which case a module should not be closed. For example, if a module uses static GObject, closing and reopening it cause crashes. Because a module can be made by other opensource or proprietary code, this API is needed. Wasn't a common sense that dynamically loaded modules should be never unload? I recall raster disabling the actual dlclose(), if not in Eina, something in e_modules... It's too dangerous, and is it worth? You mean that forbidding module unload is a common sense?? (Sorry for my understanding English.) correct. the core problem is that modules often create objects. these objects are held by tings like evas - or other subsystems. these objects often refer to callbacks from a module. if you unload a module, even *IF* it deletes objects, reference counting may mean they have to stay around for a while. they now have functions pointing off into memory that no longer exists (unmapped) and all sorts of un-fun things happen. from segvs to randomly jumping into code that isn't a function at all (unload module, load new one, recycles same memory space. new code at same address. BOOM!). with GREAT care can you avoid this by removing all function pointers/callbacks (nulling them out - assuming the code handles them being null at all and doesn't assume they are minimum basic requirements). even if you can do this t most, some funcs are basic parts of object infra and thus you cant unload until all objects cease referring to the funcs from a module. in general you are just better off not unloading and relying on the next time you start the process simply meaning you wont load the module you disabled last time. I agree with that. It's too dangerous to dlclose(). But, dlclose() is not disabled in eina_module currently. So I want to add API for giving rights to disable this for end-users. no - it's there as it leaves it up the the user of eina_module as to if its safe to close a module. 98% of the time it is not. but it *IS* possible to do so, if you wish. You think that it's better to do not unload the module than adding new API such as eina_module_resident. Actually, I want to use this new API in elementary map widget. If not use this API, loaded module list may be remained as static variables even if elm_map is deleted, also module is not unloaded. Next time, when map is added again, static variables (previously loaded modules) are checked and used again so as to do not load the module (if loaded, it can be memory leaks). Is this correct usage?? I think that eina_module can support this so as to other libraries do not care about static variables. Maybe, I am so lazy man. :) I looked around the e_module. And I found that e_module does not eina_module and use dlopen() directly. Also it do not use dlclose() except error. e modules predate eina_module by several years. thus its still the old code it has always had. As a note, kernel developers condemn module unloading, saying it's just a module developer feature and should never be used by end-users (although we all do to work around buggy kernel modules such as broadcom's proprietary wifi). -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- BRs, Kim. -- This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler) ras...@rasterman.com -- BRs, Kim. -- Better than sec? Nothing is better than sec when it comes to monitoring Big Data applications. Try Boundary one-second resolution app monitoring today. Free. http://p.sf.net/sfu
Re: [E-devel] [Patch][eina_module] Add eina_module_resident() API
2012/3/30 Gustavo Sverzut Barbieri barbi...@profusion.mobi: On Fri, Mar 30, 2012 at 3:43 AM, Bluezery ohpo...@gmail.com wrote: Hello, I want to add new eina_module_resident() API in eina_modules. This function makes the module never be unloaded before process is closed. This is needed in which case a module should not be closed. For example, if a module uses static GObject, closing and reopening it cause crashes. Because a module can be made by other opensource or proprietary code, this API is needed. Wasn't a common sense that dynamically loaded modules should be never unload? I recall raster disabling the actual dlclose(), if not in Eina, something in e_modules... It's too dangerous, and is it worth? You mean that forbidding module unload is a common sense?? (Sorry for my understanding English.) I agree with that. It's too dangerous to dlclose(). But, dlclose() is not disabled in eina_module currently. So I want to add API for giving rights to disable this for end-users. I looked around the e_module. And I found that e_module does not eina_module and use dlopen() directly. Also it do not use dlclose() except error. As a note, kernel developers condemn module unloading, saying it's just a module developer feature and should never be used by end-users (although we all do to work around buggy kernel modules such as broadcom's proprietary wifi). -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- BRs, Kim. -- This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [Patch][eina_module] Add eina_module_resident() API
Hello, I want to add new eina_module_resident() API in eina_modules. This function makes the module never be unloaded before process is closed. This is needed in which case a module should not be closed. For example, if a module uses static GObject, closing and reopening it cause crashes. Because a module can be made by other opensource or proprietary code, this API is needed. Thanks. -- BRs, Kim. eina_module@eina_module_resident.patch Description: Binary data -- This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] ecrire:cfg.c,main.c malloc return checks
2012/3/27 Vikram Narayanan vikram...@gmail.com: On 3/27/2012 12:37 AM, Michael Blumenkrantz wrote: On Tue, 27 Mar 2012 00:21:19 +0530 Vikram Narayananvikram...@gmail.com wrote: In ecrire, Check return values of *alloc functions, though its unlikely to fail. There are chances though! Comments please. Thanks, Vikram efl applications typically don't bother checking return values on these functions because you're fucked no matter what if they fail I don't understand your language. Even if its not necessary, it's a good programming practice to do it atleast for memory allocation functions. Yeah, It's good practice to check return value of functions. But malloc() is optimized in linux. So it is not guaranteed to return non-NULL even though it's availabe. And discomfitor said that EFL typically do not check it. I thinks that it is because malloc() fail, whole things fail. -- This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- BRs, Kim. -- This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [Patch][elm_map] Fix related zoom
Hello,
This is patch for zoom behavior in elm_map.
1) wd-zoom_max is defined by user. wd-src_tile-zoom_max is defined
by source map provider.
Therefore, I decide to do not touch those things. Just check these
while zooming ( zoom_do() )
2) When pan being re-sized, I changed from zoom with animation to
zoom with NO animation because too many animation is occurred while
window size is changing.
3) When argument is invalid for
elm_map_zoom_min_get/elm_map_zoom_max_get, those return -1.
Please review this patch
Thanks.
--
BRs,
Kim.
Index: src/lib/elm_map.c
===
--- src/lib/elm_map.c (리비전 69583)
+++ src/lib/elm_map.c (작업 사본)
@@ -1151,6 +1151,8 @@ static void
zoom_do(Widget_Data *wd, double zoom)
{
EINA_SAFETY_ON_NULL_RETURN(wd);
+ if (zoom wd-src_tile-zoom_max) zoom = wd-src_tile-zoom_max;
+ else if (zoom wd-src_tile-zoom_min) zoom = wd-src_tile-zoom_min;
if (zoom wd-zoom_max) zoom = wd-zoom_max;
else if (zoom wd-zoom_min) zoom = wd-zoom_min;
@@ -2506,7 +2508,7 @@ _overlays_show(void *data)
EINA_SAFETY_ON_NULL_RETURN(data);
Delayed_Data *dd = data;
- int zoom;
+ int zoom, zoom_max;
double max_lon, min_lon, max_lat, min_lat;
Evas_Coord vw, vh;
@@ -2516,7 +2518,10 @@ _overlays_show(void *data)
zoom = dd-wd-src_tile-zoom_min;
_viewport_coord_get(dd-wd, NULL, NULL, vw, vh);
- while (zoom = dd-wd-src_tile-zoom_max)
+ if (dd-wd-src_tile-zoom_max dd-wd-zoom_max)
+ zoom_max = dd-wd-src_tile-zoom_max;
+ else zoom_max = dd-wd-zoom_max;
+ while (zoom = zoom_max)
{
Evas_Coord size, max_x, max_y, min_x, min_y;
size = pow(2.0, zoom) * dd-wd-tsize;
@@ -3528,7 +3533,7 @@ _zoom_mode_set(void *data)
}
}
}
- zoom_with_animation(dd-wd, zoom, 10);
+zoom_do(dd-wd, zoom);
}
}
@@ -3987,9 +3992,6 @@ elm_map_zoom_set(Evas_Object *obj, int z
if (wd-mode != ELM_MAP_ZOOM_MODE_MANUAL) return;
if (zoom 0) zoom = 0;
if (wd-zoom == zoom) return;
- if (zoom wd-src_tile-zoom_max) zoom = wd-src_tile-zoom_max;
- if (zoom wd-src_tile-zoom_min) zoom = wd-src_tile-zoom_min;
-
Delayed_Data *data = ELM_NEW(Delayed_Data);
data-func = _zoom_set;
data-wd = wd;
@@ -4063,8 +4065,6 @@ elm_map_zoom_max_set(Evas_Object *obj, i
EINA_SAFETY_ON_NULL_RETURN(wd);
EINA_SAFETY_ON_NULL_RETURN(wd-src_tile);
- if ((zoom wd-src_tile-zoom_max) || (zoom wd-src_tile-zoom_min))
- return;
wd-zoom_max = zoom;
#else
(void) obj;
@@ -4076,7 +4076,7 @@ EAPI int
elm_map_zoom_max_get(const Evas_Object *obj)
{
#ifdef HAVE_ELEMENTARY_ECORE_CON
- ELM_CHECK_WIDTYPE(obj, widtype) 18;
+ ELM_CHECK_WIDTYPE(obj, widtype) -1;
Widget_Data *wd = elm_widget_data_get(obj);
EINA_SAFETY_ON_NULL_RETURN_VAL(wd, -1);
EINA_SAFETY_ON_NULL_RETURN_VAL(wd-src_tile, -1);
@@ -4084,7 +4084,7 @@ elm_map_zoom_max_get(const Evas_Object *
return wd-zoom_max;
#else
(void) obj;
- return 18;
+ return -1;
#endif
}
@@ -4097,8 +4097,6 @@ elm_map_zoom_min_set(Evas_Object *obj, i
EINA_SAFETY_ON_NULL_RETURN(wd);
EINA_SAFETY_ON_NULL_RETURN(wd-src_tile);
- if ((zoom wd-src_tile-zoom_max) || (zoom wd-src_tile-zoom_min))
- return;
wd-zoom_min = zoom;
#else
(void) obj;
@@ -4110,7 +4108,7 @@ EAPI int
elm_map_zoom_min_get(const Evas_Object *obj)
{
#ifdef HAVE_ELEMENTARY_ECORE_CON
- ELM_CHECK_WIDTYPE(obj, widtype) 0;
+ ELM_CHECK_WIDTYPE(obj, widtype) -1;
Widget_Data *wd = elm_widget_data_get(obj);
EINA_SAFETY_ON_NULL_RETURN_VAL(wd, -1);
EINA_SAFETY_ON_NULL_RETURN_VAL(wd-src_tile, -1);
@@ -4118,11 +4116,10 @@ elm_map_zoom_min_get(const Evas_Object *
return wd-zoom_min;
#else
(void) obj;
- return 0;
+ return -1;
#endif
}
-
EAPI void
elm_map_region_bring_in(Evas_Object *obj, double lon, double lat)
{
--
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here
http://p.sf.net/sfu/sfd2d-msazure___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch][elm_map] Fix related zoom
2012/3/23 Sanjeev BA eflel...@gmail.com: Why is zoom with animation changed to zoom_do ? Because too many animations occurred while window size is changing. :) Zoom with animation can be used by elm_map_zoom_set(). On Fri, Mar 23, 2012 at 7:36 PM, Bluezery ohpo...@gmail.com wrote: Hello, This is patch for zoom behavior in elm_map. 1) wd-zoom_max is defined by user. wd-src_tile-zoom_max is defined by source map provider. Therefore, I decide to do not touch those things. Just check these while zooming ( zoom_do() ) 2) When pan being re-sized, I changed from zoom with animation to zoom with NO animation because too many animation is occurred while window size is changing. 3) When argument is invalid for elm_map_zoom_min_get/elm_map_zoom_max_get, those return -1. Please review this patch Thanks. -- BRs, Kim. -- This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- BRs, Kim. -- This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [Patch][elm_map] Remove unused codes
Hello,
Now, Elm_Map_Marker, Elm_Map_Marker_Class, Elm_Map_Group_Class,
Marker_Bubble are not used anymore. So I removed all things related
those in elm_map.
Please review this patch.
Thanks
--
BRs,
Kim.
Index: src/lib/elm_map.c
===
--- src/lib/elm_map.c (리비전 69564)
+++ src/lib/elm_map.c (작업 사본)
@@ -26,8 +26,6 @@ typedef struct _Overlay_Line Overlay_Lin
typedef struct _Overlay_Polygon Overlay_Polygon;
typedef struct _Overlay_Circle Overlay_Circle;
typedef struct _Overlay_Scale Overlay_Scale;
-typedef struct _Marker_Group Marker_Group;
-typedef struct _Marker_Bubble Marker_Bubble;
typedef struct _Path_Node Path_Node;
typedef struct _Path_Waypoint Path_Waypoint;
typedef struct _Route_Dump Route_Dump;
@@ -116,11 +114,9 @@ struct _Delayed_Data
Elm_Map_Zoom_Mode mode;
int zoom;
double lon, lat;
- Eina_List *markers;
Eina_List *overlays;
};
-// Map Tile source
// FIXME: Currently tile size must be 256*256
// and the map size is pow(2.0, z) * (tile size)
struct _Source_Tile
@@ -134,14 +130,12 @@ struct _Source_Tile
Elm_Map_Module_Tile_Scale_Func scale_cb;
};
-// Map Route Source
struct _Source_Route
{
const char *name;
Elm_Map_Module_Route_Url_Func url_cb;
};
-// Map Name Source
struct _Source_Name
{
const char *name;
@@ -261,73 +255,6 @@ struct _Elm_Map_Overlay
Overlay_Group *grp;
};
-struct _Elm_Map_Marker_Class
-{
- const char *style;
- struct _Elm_Map_Marker_Class_Func
- {
-Elm_Map_Marker_Get_Func get;
-Elm_Map_Marker_Del_Func del; //if NULL the object will be destroyed with evas_object_del()
-Elm_Map_Marker_Icon_Get_Func icon_get;
- } func;
-};
-
-struct _Elm_Map_Group_Class
-{
- Widget_Data *wd;
-
- Eina_List *markers;
- int zoom_displayed; // display the group if the zoom is = to zoom_display
- int zoom_grouped; // group the markers only if the zoom is = to zoom_groups
- const char *style;
- void *data;
- struct
- {
-Elm_Map_Group_Icon_Get_Func icon_get;
- } func;
-
- Eina_Bool hide : 1;
-};
-
-struct _Marker_Bubble
-{
- Widget_Data *wd;
- Evas_Object *pobj;
- Evas_Object *obj, *sc, *bx;
-};
-
-struct _Elm_Map_Marker
-{
- Widget_Data *wd;
- Elm_Map_Marker_Class *clas;
- Elm_Map_Group_Class *group_clas;
- double longitude, latitude;
- Evas_Coord w, h;
- Evas_Object *obj;
-
- Evas_Coord x, y;
- Eina_Bool grouped : 1;
- Eina_Bool leader : 1; // if marker is group leader
- Marker_Group *group;
-
- Marker_Bubble *bubble;
- Evas_Object *content;
- void *data;
-};
-
-struct _Marker_Group
-{
- Widget_Data *wd;
- Elm_Map_Group_Class *clas;
- Evas_Coord w, h;
- Evas_Object *obj;
-
- Evas_Coord x, y;
- Eina_List *markers;
-
- Marker_Bubble *bubble;
-};
-
struct _Elm_Map_Route
{
Widget_Data *wd;
@@ -440,7 +367,7 @@ struct _Widget_Data
Evas_Object *scr;
Evas_Object *ges;
Evas_Object *pan_smart;
- Evas_Object *sep_maps_markers; // Tiles are below this and overlays are on top
+ Evas_Object *sep_maps_overlays; // Tiles are below this and overlays are on top
Evas_Map *map;
Eina_Array *src_tile_mods;
@@ -466,8 +393,6 @@ struct _Widget_Data
int zoom;
double zoom_detail;
- double prev_lon, prev_lat;
- Evas_Coord ox, oy;
struct
{
int w, h; // Current pixel width, heigth of a grid
@@ -509,12 +434,6 @@ struct _Widget_Data
Eina_Bool wheel_disabled : 1;
- unsigned int markers_max_num;
- Eina_Bool paused_markers : 1;
- Eina_List *group_classes;
- Eina_List *marker_classes;
- Eina_List *markers;
-
Eina_List *routes;
Eina_List *track;
Eina_List *names;
@@ -627,7 +546,7 @@ static const Evas_Smart_Cb_Description _
};
static void
-_edj_marker_size_get(Widget_Data *wd, Evas_Coord *w, Evas_Coord *h)
+_edj_overlay_size_get(Widget_Data *wd, Evas_Coord *w, Evas_Coord *h)
{
EINA_SAFETY_ON_NULL_RETURN(wd);
EINA_SAFETY_ON_NULL_RETURN(w);
@@ -789,419 +708,6 @@ _region_show(void *data)
}
static void
-_bubble_update(Marker_Bubble *bubble, Eina_List *contents)
-{
- EINA_SAFETY_ON_NULL_RETURN(bubble);
- EINA_SAFETY_ON_NULL_RETURN(contents);
-
- Eina_List *l;
- Evas_Object *c;
-
- elm_box_clear(bubble-bx);
- EINA_LIST_FOREACH(contents, l, c) elm_box_pack_end(bubble-bx, c);
-}
-
-static void
-_bubble_place(Marker_Bubble *bubble)
-{
- EINA_SAFETY_ON_NULL_RETURN(bubble);
-
- Evas_Coord x, y, w, h;
- Evas_Coord xx, yy, ww, hh;
- const char *s;
-
- if ((!bubble-obj) || (!bubble-pobj)) return;
- evas_object_geometry_get(bubble-pobj, x, y, w, NULL);
-
- s = edje_object_data_get(bubble-obj, size_w);
- if (s) ww = atoi(s);
- else ww = 0;
-
- edje_object_size_min_calc(bubble-obj, NULL, hh);
- s = edje_object_data_get(bubble-obj, size_h);
- if (s) h = atoi(s);
- else h = 0;
- if (hh h) hh = h;
-
- xx = x + (w / 2) - (ww / 2);
- yy = y - hh;
-
-
[E-devel] [Patch][elm_map] Bug fix
Hello, This is simple bug fix patch Callback parameter should be Widget_Data, not Evas_Object. Thanks. -- BRs, Kim. Index: src/lib/elm_map.c === --- src/lib/elm_map.c (리비전 69574) +++ src/lib/elm_map.c (작업 사본) @@ -4284,9 +4284,9 @@ elm_map_wheel_disabled_set(Evas_Object * EINA_SAFETY_ON_NULL_RETURN(wd); if ((!wd-wheel_disabled) (disabled)) - evas_object_event_callback_del_full(obj, EVAS_CALLBACK_MOUSE_WHEEL, _mouse_wheel_cb, obj); + evas_object_event_callback_del_full(obj, EVAS_CALLBACK_MOUSE_WHEEL, _mouse_wheel_cb, wd); else if ((wd-wheel_disabled) (!disabled)) - evas_object_event_callback_add(obj, EVAS_CALLBACK_MOUSE_WHEEL, _mouse_wheel_cb, obj); + evas_object_event_callback_add(obj, EVAS_CALLBACK_MOUSE_WHEEL, _mouse_wheel_cb, wd); wd-wheel_disabled = !!disabled; #else (void) obj; -- This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch][elm_map] Map overlay color grouping route Fix
On Wed, 21 Mar 2012 15:59:32 +0900 Daniel Juyung Seo seojuyu...@gmail.com said: Actually slow review is a bad thing happening in EFL. I need more reviewers. But big patch makes review even slower and you won't get correct review for your big patch. Just separate your job. Do not split the patch after you created a big patch. While you work, consider separating patches and commits. Thank you. Yes, I should get consideration for reviewers. :D 2012/3/22 Carsten Haitzler ras...@rasterman.com: actually realistically, review here in efl is pretty fast. you should try lots of other open source projects where patches get lost/ignored for YEARS :) Right, I need to practice mind control. :) -- This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [patch] elm_map - Bug fix
2012/3/19 Bluezery ohpo...@gmail.com: 2012/3/19 Sanjeev BA eflel...@gmail.com: I am looking into it. In removed/deprecated header, some APIs are removed. So those are not need to be patched. I resend modified patch. Thanks. Dear Sanjeeve, I am waiting for you. :) On Sun, Mar 18, 2012 at 12:08 PM, Bluezery ohpo...@gmail.com wrote: 2012/3/10 Bluezery ohpo...@gmail.com: Hello, This patch fixes two elm map bugs 1) Geometry calculation error Calculation of canvas geometry is not correct If other evas objects take up some space in the canvas. This patch fix this by calculating smart pan geometry values. 2) Map moves southeastward when zooming When repeating zoom in/out, map moves southeastward. ceil() function fixes this bug. Thanks. -- BRs, Kim. Could you review this patch, please?? :) -- BRs, Kim. -- This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- BRs, Kim. -- BRs, Kim. -- This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [patch] elm_map - Bug fix
I resend map patch!
Thanks for your comments! !
2012/3/20 Bluezery ohpo...@gmail.com:
2012/3/19 Bluezery ohpo...@gmail.com:
2012/3/19 Sanjeev BA eflel...@gmail.com:
I am looking into it.
In removed/deprecated header, some APIs are removed.
So those are not need to be patched.
I resend modified patch.
Thanks.
Dear Sanjeeve,
I am waiting for you. :)
On Sun, Mar 18, 2012 at 12:08 PM, Bluezery ohpo...@gmail.com wrote:
2012/3/10 Bluezery ohpo...@gmail.com:
Hello,
This patch fixes two elm map bugs
1) Geometry calculation error
Calculation of canvas geometry is not correct If other evas objects
take up some space in the canvas.
This patch fix this by calculating smart pan geometry values.
2) Map moves southeastward when zooming
When repeating zoom in/out, map moves southeastward.
ceil() function fixes this bug.
Thanks.
--
BRs,
Kim.
Could you review this patch, please?? :)
--
BRs,
Kim.
--
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here
http://p.sf.net/sfu/sfd2d-msazure
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here
http://p.sf.net/sfu/sfd2d-msazure
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
BRs,
Kim.
--
BRs,
Kim.
--
BRs,
Kim.
Index: src/bin/test_map.c
===
--- src/bin/test_map.c (리비전 69518)
+++ src/bin/test_map.c (작업 사본)
@@ -90,7 +90,7 @@
{
printf(clicked,double\n);
double lon, lat;
- Evas_Event_Mouse_Down *down = (Evas_Event_Mouse_Down *)event_info;
+ Evas_Event_Mouse_Down *down = event_info;
if (!down) return;
if (elm_map_zoom_get(obj) 5) return;
@@ -108,6 +108,7 @@
{
elm_map_overlay_del(route_start);
elm_map_overlay_del(route_end);
+elm_map_route_del(route);
route_start = NULL;
route_end = NULL;
route = NULL;
@@ -298,17 +299,16 @@
static void
map_show_urmatt(void *data, Evas_Object *obj __UNUSED__, void *event_info __UNUSED__)
{
- Eina_Bool b = elm_map_paused_get(data);
- elm_map_paused_set(data, EINA_TRUE);
elm_map_zoom_mode_set(data, ELM_MAP_ZOOM_MODE_MANUAL);
+ if (elm_map_zoom_get(data) 12) elm_map_zoom_set(data, 12);
elm_map_region_show(data,7.325201, 48.526813);
- elm_map_zoom_set(data, 12);
- elm_map_paused_set(data, b);
}
static void
map_bring_seoul(void *data, Evas_Object *obj __UNUSED__, void *event_info __UNUSED__)
{
+ elm_map_zoom_mode_set(data, ELM_MAP_ZOOM_MODE_MANUAL);
+ if (elm_map_zoom_get(data) 12) elm_map_zoom_set(data, 12);
elm_map_region_bring_in(data, 126.977969, 37.566535);
}
@@ -543,7 +543,7 @@
{
const char *s = elm_scrolled_entry_entry_get(obj);
char *addr = strdup(s);
- name = elm_map_name_geo_request(data, addr);
+ name = elm_map_name_add(data, addr, 0, 0, NULL, NULL);
if (addr) free (addr);
}
*/
Index: src/lib/elm_map.c
===
--- src/lib/elm_map.c (리비전 69518)
+++ src/lib/elm_map.c (작업 사본)
@@ -599,13 +599,9 @@
}
static void
-_coord_rotate(Evas_Coord x, Evas_Coord y, Evas_Coord cx, Evas_Coord cy, double degree, Evas_Coord *xx, Evas_Coord *yy)
+_rotate(Evas_Coord x, Evas_Coord y, Evas_Coord cx, Evas_Coord cy, double degree, Evas_Coord *xx, Evas_Coord *yy)
{
- EINA_SAFETY_ON_NULL_RETURN(xx);
- EINA_SAFETY_ON_NULL_RETURN(yy);
-
double r = (degree * M_PI) / 180.0;
-
if (xx) *xx = ((x - cx) * cos(r)) + ((y - cy) * cos(r + M_PI_2)) + cx;
if (yy) *yy = ((x - cx) * sin(r)) + ((y - cy) * sin(r + M_PI_2)) + cy;
}
@@ -645,7 +641,6 @@
_coord_to_region_convert(Widget_Data *wd, Evas_Coord x, Evas_Coord y, Evas_Coord size, double *lon, double *lat)
{
EINA_SAFETY_ON_NULL_RETURN(wd);
-
int zoom = floor(log(size / wd-size.tile) / log(2));
if ((wd-src_tile) (wd-src_tile-coord_to_geo))
{
@@ -679,33 +674,54 @@
}
static void
-_viewport_size_get(Widget_Data *wd, Evas_Coord *vw, Evas_Coord *vh)
+_viewport_coord_get(Widget_Data *wd, Evas_Coord *vx, Evas_Coord *vy, Evas_Coord *vw, Evas_Coord *vh)
{
EINA_SAFETY_ON_NULL_RETURN(wd);
Evas_Coord x, y, w, h;
- evas_object_geometry_get(wd-pan_smart, x, y, w, h);
- if (vw) *vw = (x * 2) + w;
- if (vh) *vh = (y * 2) + h;
+ elm_smart_scroller_child_pos_get(wd-scr, x, y);
+ elm_smart_scroller_child_viewport_size_get(wd-scr, w, h);
+ if (w wd-size.w) x -= ((w - wd-size.w) / 2);
+ if (h wd-size.h) y
Re: [E-devel] [patch] elm_map - Bug fix
2012/3/19 Sanjeev BA eflel...@gmail.com:
I am looking into it.
In removed/deprecated header, some APIs are removed.
So those are not need to be patched.
I resend modified patch.
Thanks.
On Sun, Mar 18, 2012 at 12:08 PM, Bluezery ohpo...@gmail.com wrote:
2012/3/10 Bluezery ohpo...@gmail.com:
Hello,
This patch fixes two elm map bugs
1) Geometry calculation error
Calculation of canvas geometry is not correct If other evas objects
take up some space in the canvas.
This patch fix this by calculating smart pan geometry values.
2) Map moves southeastward when zooming
When repeating zoom in/out, map moves southeastward.
ceil() function fixes this bug.
Thanks.
--
BRs,
Kim.
Could you review this patch, please?? :)
--
BRs,
Kim.
--
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here
http://p.sf.net/sfu/sfd2d-msazure
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here
http://p.sf.net/sfu/sfd2d-msazure
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
BRs,
Kim.
Index: src/lib/elm_map.c
===
--- src/lib/elm_map.c (리비전 69169)
+++ src/lib/elm_map.c (작업 사본)
@@ -599,13 +599,9 @@ _edj_marker_size_get(Widget_Data *wd, Ev
}
static void
-_coord_rotate(Evas_Coord x, Evas_Coord y, Evas_Coord cx, Evas_Coord cy, double degree, Evas_Coord *xx, Evas_Coord *yy)
+_rotate(Evas_Coord x, Evas_Coord y, Evas_Coord cx, Evas_Coord cy, double degree, Evas_Coord *xx, Evas_Coord *yy)
{
- EINA_SAFETY_ON_NULL_RETURN(xx);
- EINA_SAFETY_ON_NULL_RETURN(yy);
-
double r = (degree * M_PI) / 180.0;
-
if (xx) *xx = ((x - cx) * cos(r)) + ((y - cy) * cos(r + M_PI_2)) + cx;
if (yy) *yy = ((x - cx) * sin(r)) + ((y - cy) * sin(r + M_PI_2)) + cy;
}
@@ -645,7 +641,6 @@ static void
_coord_to_region_convert(Widget_Data *wd, Evas_Coord x, Evas_Coord y, Evas_Coord size, double *lon, double *lat)
{
EINA_SAFETY_ON_NULL_RETURN(wd);
-
int zoom = floor(log(size / wd-size.tile) / log(2));
if ((wd-src_tile) (wd-src_tile-coord_to_geo))
{
@@ -679,33 +674,54 @@ _region_to_coord_convert(Widget_Data *wd
}
static void
-_viewport_size_get(Widget_Data *wd, Evas_Coord *vw, Evas_Coord *vh)
+_viewport_coord_get(Widget_Data *wd, Evas_Coord *vx, Evas_Coord *vy, Evas_Coord *vw, Evas_Coord *vh)
{
EINA_SAFETY_ON_NULL_RETURN(wd);
Evas_Coord x, y, w, h;
- evas_object_geometry_get(wd-pan_smart, x, y, w, h);
- if (vw) *vw = (x * 2) + w;
- if (vh) *vh = (y * 2) + h;
+ elm_smart_scroller_child_pos_get(wd-scr, x, y);
+ elm_smart_scroller_child_viewport_size_get(wd-scr, w, h);
+ if (w wd-size.w) x -= ((w - wd-size.w) / 2);
+ if (h wd-size.h) y -= ((h - wd-size.h) / 2);
+ if (vx) *vx = x;
+ if (vy) *vy = y;
+ if (vw) *vw = w;
+ if (vh) *vh = h;
}
+// Map coordinates to canvas geometry without rotate
static void
-_pan_geometry_get(Widget_Data *wd, Evas_Coord *px, Evas_Coord *py)
+_coord_to_canvas_no_rotate(Widget_Data *wd, Evas_Coord x, Evas_Coord y, Evas_Coord *xx, Evas_Coord *yy)
{
- EINA_SAFETY_ON_NULL_RETURN(wd);
+ Evas_Coord vx, vy, sx, sy;
+ _viewport_coord_get(wd, vx, vy, NULL, NULL);
+ evas_object_geometry_get(wd-pan_smart, sx, sy, NULL, NULL);
+ if (xx) *xx = x - vx + sx;
+ if (yy) *yy = y - vy + sy;
+}
- Evas_Coord x, y, vx, vy, vw, vh;
- elm_smart_scroller_child_pos_get(wd-scr, x, y);
- evas_object_geometry_get(wd-pan_smart, vx, vy, vw, vh);
- x = -x;
- y = -y;
- if (vw wd-size.w) x += (((vw - wd-size.w) / 2) + vx);
- else x -= vx;
- if (vh wd-size.h) y += (((vh - wd-size.h) / 2) + vy);
- else y -= vy;
- if (px) *px = x;
- if (py) *py = y;
- }
+// Map coordinates to canvas geometry
+static void
+_coord_to_canvas(Widget_Data *wd, Evas_Coord x, Evas_Coord y, Evas_Coord *xx, Evas_Coord *yy)
+{
+ _coord_to_canvas_no_rotate(wd, x, y, x, y);
+ _rotate(x, y, wd-rotate.cx, wd-rotate.cy, wd-rotate.d, x, y);
+ if (xx) *xx = x;
+ if (yy) *yy = y;
+}
+
+// Canvas geometry to map coordinates
+static void
+_canvas_to_coord(Widget_Data *wd, Evas_Coord x, Evas_Coord y, Evas_Coord *xx, Evas_Coord *yy)
+{
+ Evas_Coord vx, vy, sx, sy;
+ _viewport_coord_get(wd, vx, vy, NULL, NULL);
+ evas_object_geometry_get(wd-pan_smart, sx, sy, NULL, NULL);
+ _rotate(x - sx + vx, y - sy + vy, wd-rotate.cx - sx + vx,
+ wd-rotate.cy - sy + vy, -wd-rotate.d, x, y);
+ if (xx) *xx = x;
+ if (yy) *yy = y
Re: [E-devel] [patch] elm_map - Bug fix
2012/3/10 Bluezery ohpo...@gmail.com: Hello, This patch fixes two elm map bugs 1) Geometry calculation error Calculation of canvas geometry is not correct If other evas objects take up some space in the canvas. This patch fix this by calculating smart pan geometry values. 2) Map moves southeastward when zooming When repeating zoom in/out, map moves southeastward. ceil() function fixes this bug. Thanks. -- BRs, Kim. Could you review this patch, please?? :) -- BRs, Kim. -- This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [Patch][enki] Fix build breaks related elm_map
Hello, enki cannot be built because of map API changes. I fixed those build warnings breaks related with elm_map. I know that J.H. Park currently doing this jobs. This patch can help her :D. Please review this patch. Thanks. -- BRs, Kim. enki@fix_map@patch Description: Binary data -- Try before you buy = See our experts in action! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-dev2___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch][enki] Fix build breaks related elm_map
Although it (clas) 's name from elm_map_overlay_class_add(), It
looks something like c++ class. :) I changed clas -- grp.
And elm_map_marker_update() is not needed anymore. Overlay always
update itself now.
I checked the segfaults But It looks like not from this patch (for
related almost only elm_map).
To fix it, I need to study gengrids and enki more. :p. I am not
familiar with those yet.
I will check those bugs ASAP to enable enki.
2012/3/12 Sanjeev BA eflel...@gmail.com:
Patched version of enki segfaults with the following backtrace.
--
On Mon, Mar 12, 2012 at 7:29 PM, Sanjeev BA eflel...@gmail.com wrote:
Fixes the build breaks.
But I have the following comments.
rename variable from clas to something more helpful. It sounds like a
way to escape C++ compilation issues.
Also I observe some API calls being removed.
For ex.,
elm_map_marker_update(photo_data-marker);
and some else if branches removed.
I hope you have verified your changes.
Kindly confirm, make the required changes and resubmit.
Regards,
Sanjeev
On Mon, Mar 12, 2012 at 7:09 PM, Bluezery ohpo...@gmail.com wrote:
Hello,
enki cannot be built because of map API changes.
I fixed those build warnings breaks related with elm_map.
I know that J.H. Park currently doing this jobs. This patch can help her
:D.
Please review this patch.
Thanks.
--
BRs,
Kim.
--
Try before you buy = See our experts in action!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-dev2
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
Try before you buy = See our experts in action!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-dev2
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
BRs,
Kim.
Index: src/bin/enlil_data.h
===
--- src/bin/enlil_data.h (리비전 69251)
+++ src/bin/enlil_data.h (작업 사본)
@@ -150,7 +150,7 @@ struct enlil_photo_data
Enlil_IPTC_Job *iptc_job;
Eina_Bool clear_iptc_data;
- Elm_Map_Marker *marker;
+ Elm_Map_Overlay *marker;
int cant_create_thumb;
@@ -188,7 +188,7 @@ struct geocaching_data
{
Enlil_Geocaching *gp;
- Elm_Map_Marker *marker;
+ Elm_Map_Overlay *marker;
Panel_Geocaching *panel_geocaching;
};
Index: src/bin/main_slideshow.c
===
--- src/bin/main_slideshow.c (리비전 69251)
+++ src/bin/main_slideshow.c (작업 사본)
@@ -62,7 +62,7 @@ elm_main(int argc, char **argv)
if (exit_option) return 0;
//
- elm_finger_size_set(1);
+ elm_config_finger_size_set(1);
//
library = enlil_library_new(NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
Index: src/bin/objects.h
===
--- src/bin/objects.h (리비전 69251)
+++ src/bin/objects.h (작업 사본)
@@ -77,10 +77,9 @@ struct panel_geocaching
Evas_Object *map;
Enlil_Geocaching *geocaching;
- Elm_Map_Marker *marker;
+ Elm_Map_Overlay *marker;
- Elm_Map_Marker_Class *itc;
- Elm_Map_Group_Class *itc_group;
+ Elm_Map_Overlay *itc;
};
struct panel_image
Index: src/bin/panel_image.c
===
--- src/bin/panel_image.c (리비전 69251)
+++ src/bin/panel_image.c (작업 사본)
@@ -908,8 +908,6 @@ _panel_select_cb(void *data, Tabpanel *t
Panel_Image *panel_image = (Panel_Image *) data;
Enlil_Photo_Data *photo_data = enlil_photo_user_data_get(panel_image-photo);
_update_undo_redo(photo_data-panel_image);
-
- elm_map_bubbles_close(enlil_data-map-map);
}
static void
Index: src/bin/evas_object/tabpanel.c
===
--- src/bin/evas_object/tabpanel.c (리비전 69251)
+++ src/bin/evas_object/tabpanel.c (작업 사본)
@@ -174,8 +174,7 @@ tabpanel_item_del(Tabpanel_Item *item)
if (item-tab-items) tabpanel_item_select(
eina_list_data_get(
item-tab-items));
-
- elm_toolbar_item_del(item-item_tb);
+ elm_object_item_del(item-item_tb);
if (item-tab-from_edje
