Re: [E-devel] about removing trailing whitespaces

2011-10-23 Thread Youness Alaoui
@Mike: I ran indent and it didn't seem to screw up things, I told it I want 3 spaces indent and 2 spaces inside { } or something, I tried it on a few elm_*.c files and it changed some stuff but not the indentation spacing as far as I remember. @Carsten: spaces in blank lines are the same as

Re: [E-devel] about removing trailing whitespaces

2011-10-23 Thread Mike Blumenkrantz
On Sun, 23 Oct 2011 04:24:14 -0400 Youness Alaoui kakar...@kakaroto.homelinux.net wrote: @Mike: I ran indent and it didn't seem to screw up things, I told it I want 3 spaces indent and 2 spaces inside { } or something, I tried it on a few elm_*.c files and it changed some stuff but not the

Re: [E-devel] about removing trailing whitespaces

2011-10-22 Thread David Seikel
On Sat, 22 Oct 2011 01:38:35 -0400 Youness Alaoui kakar...@kakaroto.homelinux.net wrote: Also I believe using a tested and used GNU app is better than using a custom made one that might have bugs, Since when is GNU the be all and end all of high quality coding? I'd trust something written by

Re: [E-devel] about removing trailing whitespaces

2011-10-22 Thread Youness Alaoui
I never said GNU is the reference for high quality, and we're not here to talk about whether or not we like GNU, the FSF or Stallman. Your point is that it would be easier to debug of your own app, my point is that why do hell would you need to debug that? Set your arguments to what style you

Re: [E-devel] about removing trailing whitespaces

2011-10-22 Thread Mike Blumenkrantz
On Sat, 22 Oct 2011 11:57:15 -0400 Youness Alaoui kakar...@kakaroto.homelinux.net wrote: I never said GNU is the reference for high quality, and we're not here to talk about whether or not we like GNU, the FSF or Stallman. Your point is that it would be easier to debug of your own app, my

Re: [E-devel] about removing trailing whitespaces

2011-10-21 Thread Youness Alaoui
Ha! I was about to start a thread about this specific issue! I don't know if you noticed but I added a 'efl-indent' script in FORMATTING which uses GNU's indent. That works very good, and is used by GStreamer to do their code formatting. GStreamer uses git and when you try to commit something that

Re: [E-devel] about removing trailing whitespaces

2011-10-21 Thread The Rasterman
On Fri, 21 Oct 2011 14:44:31 -0400 Youness Alaoui kakar...@kakaroto.homelinux.net said: Ha! I was about to start a thread about this specific issue! I don't know if you noticed but I added a 'efl-indent' script in FORMATTING which uses GNU's indent. That works very good, and is used by

Re: [E-devel] about removing trailing whitespaces

2011-10-21 Thread Youness Alaoui
Yeah, I've seen ecrustify but I think when testing it, it didn't give good results and from what I could perceive, other devs don't seem to trust it to work reliably which is why I put efl-indent in there. Also I believe using a tested and used GNU app is better than using a custom made one that

Re: [E-devel] about removing trailing whitespaces

2011-10-21 Thread The Rasterman
On Sat, 22 Oct 2011 01:38:35 -0400 Youness Alaoui kakar...@kakaroto.homelinux.net said: Yeah, I've seen ecrustify but I think when testing it, it didn't give good results and from what I could perceive, other devs don't seem to trust it to work reliably which is why I put efl-indent in there.

Re: [E-devel] about removing trailing whitespaces

2011-10-20 Thread Daniel Juyung Seo
I raise this issue again. We need pre/post-commit hook for formatting, whitespaces, and whatever. webkit already does this job. Daniel Juyung Seo (SeoZ) On Tue, Jun 21, 2011 at 10:00 PM, David Seikel onef...@gmail.com wrote: On Tue, 21 Jun 2011 13:43:13 +0200 Thomas Gstädtner

Re: [E-devel] about removing trailing whitespaces

2011-10-20 Thread The Rasterman
On Fri, 21 Oct 2011 09:34:25 +0900 Daniel Juyung Seo seojuyu...@gmail.com said: I raise this issue again. We need pre/post-commit hook for formatting, whitespaces, and whatever. webkit already does this job. that assumes you have something that can either 1. enforce formatting rules properly

Re: [E-devel] about removing trailing whitespaces

2011-10-20 Thread Mike Blumenkrantz
On Fri, 21 Oct 2011 11:58:33 +0900 Carsten Haitzler (The Rasterman) ras...@rasterman.com wrote: On Fri, 21 Oct 2011 09:34:25 +0900 Daniel Juyung Seo seojuyu...@gmail.com said: I raise this issue again. We need pre/post-commit hook for formatting, whitespaces, and whatever. webkit

Re: [E-devel] about removing trailing whitespaces - and, er, CCs

2011-10-20 Thread David Seikel
No idea why I'm getting CCed this entire thread, but could people be a bit more careful with their email headers and make sure the CC to me is not propagated forever? I only need one copy, thanks. Oh, and I'm gonna say nasty words to the first person that replies to this email AND CC's ME

Re: [E-devel] about removing trailing whitespaces - and, er, CCs

2011-10-20 Thread Mike Blumenkrantz
On Fri, 21 Oct 2011 13:23:44 +1000 David Seikel onef...@gmail.com wrote: No idea why I'm getting CCed this entire thread, but could people be a bit more careful with their email headers and make sure the CC to me is not propagated forever? I only need one copy, thanks. Oh, and I'm gonna

Re: [E-devel] about removing trailing whitespaces

2011-10-20 Thread The Rasterman
On Thu, 20 Oct 2011 23:08:11 -0400 Mike Blumenkrantz m...@zentific.com said: On Fri, 21 Oct 2011 11:58:33 +0900 Carsten Haitzler (The Rasterman) ras...@rasterman.com wrote: On Fri, 21 Oct 2011 09:34:25 +0900 Daniel Juyung Seo seojuyu...@gmail.com said: I raise this issue again.

Re: [E-devel] about removing trailing whitespaces - and, er, CCs

2011-10-20 Thread David Seikel
On Thu, 20 Oct 2011 23:27:24 -0400 Mike Blumenkrantz m...@zentific.com wrote: On Fri, 21 Oct 2011 13:23:44 +1000 David Seikel onef...@gmail.com wrote: No idea why I'm getting CCed this entire thread, but could people be a bit more careful with their email headers and make sure the CC to

Re: [E-devel] about removing trailing whitespaces - and, er, CCs

2011-10-20 Thread Mike Blumenkrantz
On Fri, 21 Oct 2011 13:52:44 +1000 David Seikel onef...@gmail.com wrote: On Thu, 20 Oct 2011 23:27:24 -0400 Mike Blumenkrantz m...@zentific.com wrote: On Fri, 21 Oct 2011 13:23:44 +1000 David Seikel onef...@gmail.com wrote: No idea why I'm getting CCed this entire thread, but could

Re: [E-devel] about removing trailing whitespaces

2011-10-20 Thread Vincent Torri
On Fri, 21 Oct 2011, Daniel Juyung Seo wrote: I raise this issue again. We need pre/post-commit hook for formatting, whitespaces, and whatever. unfortunately, these hook will imply a lot of conflicts Vincent webkit already does this job. Daniel Juyung Seo (SeoZ) On Tue, Jun 21, 2011 at

Re: [E-devel] about removing trailing whitespaces

2011-06-21 Thread Thomas Gstädtner
On Sun, Jun 19, 2011 at 12:50, Albin Tonnerre albin.tonne...@gmail.com wrote: On Sun, 19 Jun 2011 12:38 +0200, Vincent Torri wrote : Hey another idea about trailing whitespaces : what about adding a rule in the toplevel Makefile.am, named for example remove-ws, that call find with a sed

Re: [E-devel] about removing trailing whitespaces

2011-06-21 Thread Vincent Torri
On Tue, 21 Jun 2011, Thomas Gstädtner wrote: On Sun, Jun 19, 2011 at 12:50, Albin Tonnerre albin.tonne...@gmail.com wrote: On Sun, 19 Jun 2011 12:38 +0200, Vincent Torri wrote : Hey another idea about trailing whitespaces : what about adding a rule in the toplevel Makefile.am, named for

Re: [E-devel] about removing trailing whitespaces

2011-06-21 Thread Thomas Gstädtner
On Tue, Jun 21, 2011 at 11:56, Vincent Torri vto...@univ-evry.fr wrote: On Tue, 21 Jun 2011, Thomas Gstädtner wrote: On Sun, Jun 19, 2011 at 12:50, Albin Tonnerre albin.tonne...@gmail.com wrote: On Sun, 19 Jun 2011 12:38 +0200, Vincent Torri wrote : Hey another idea about trailing

Re: [E-devel] about removing trailing whitespaces

2011-06-21 Thread David Seikel
On Tue, 21 Jun 2011 13:43:13 +0200 Thomas Gstädtner tho...@gstaedtner.net wrote: That is true, but the Don't do that, nasty programmer. SPANK SPANK SPANK mail tells you that the hook triggered and also it hurts the programmer who did produce the trailing whitespaces. People learn best when it

[E-devel] about removing trailing whitespaces

2011-06-19 Thread Vincent Torri
Hey another idea about trailing whitespaces : what about adding a rule in the toplevel Makefile.am, named for example remove-ws, that call find with a sed expression. I've found this: sed 's/[ \t]*$//' in that webpage :

Re: [E-devel] about removing trailing whitespaces

2011-06-19 Thread Albin Tonnerre
On Sun, 19 Jun 2011 12:38 +0200, Vincent Torri wrote : Hey another idea about trailing whitespaces : what about adding a rule in the toplevel Makefile.am, named for example remove-ws, that call find with a sed expression. I'll add it to Evil and test it a bit, and if nobody complains,

Re: [E-devel] about removing trailing whitespaces

2011-06-19 Thread Vincent Torri
On Sun, 19 Jun 2011, Albin Tonnerre wrote: On Sun, 19 Jun 2011 12:38 +0200, Vincent Torri wrote : Hey another idea about trailing whitespaces : what about adding a rule in the toplevel Makefile.am, named for example remove-ws, that call find with a sed expression. I'll add it to Evil