[Bug 199632] Review Request: ClanLib06 - Version 0.6 of this Cross platform C++ game library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ClanLib06 - Version 0.6 of this Cross platform C++ game library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199632 --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 03:31 EST --- I can't get this application to compile. When it runs through the configure script, it reports that it needs Hermes-1.3.0 or newer. You'll need to find and submit Hermes-1.3.0 (or newer) and add that (and tolua++-devel) to the BRs -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199632] Review Request: ClanLib06 - Version 0.6 of this Cross platform C++ game library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ClanLib06 - Version 0.6 of this Cross platform C++ game library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199632 --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 04:00 EST --- ??? I could have sworn I added Hermes to the BuildRequires. But appearantly I forgot that one I'll add it (and tolua++) together with other needed fixes once a full review has been done. To get it for the review just do yum install Hermes-devel, its already in Fe with a capatial H -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198878] Review Request: python-mutagen - Python module to handle audio metadata
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-mutagen - Python module to handle audio metadata https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198878 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 04:41 EST --- Package built successfully, so I can close this ticket -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 189400] Review Request: em8300(-kmod) - Hollywood+/DXR3 hardware MPEG decoder drivers and tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: em8300(-kmod) - Hollywood+/DXR3 hardware MPEG decoder drivers and tools https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189400 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE OtherBugsDependingO|163778 |163779 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 05:46 EST --- Was approved in the last FESCO meeting, and has been now imported and built for FC-5. Thanks. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 189400] Review Request: em8300(-kmod) - Hollywood+/DXR3 hardware MPEG decoder drivers and tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: em8300(-kmod) - Hollywood+/DXR3 hardware MPEG decoder drivers and tools https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189400 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED], ||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 05:54 EST --- If the kernel module has a suitable licence for FC5, then it presumably has a suitable licence for being included directly in the kernel. Thus, the correct approach would be to get the support into the upstream kernel and therefore into our base kernel package, rather than having a separate kmod package for it. I strongly believe we should veto _all_ kmod packages in Core and Extras. The only reason for kernel support not being upstream is because it's not acceptable there which means it probably shouldn't be acceptable to us either. And if it _is_ acceptable to us but isn't upstream for some reason, then we can consider adding it to the kernel package properly. In certain exceptional cases. You should file a separate bug (with patch) for that. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199679] Review Request: pgpool - Connection pooling/replication server for PostgreSQL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pgpool - Connection pooling/replication server for PostgreSQL https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199679 --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 06:05 EST --- I'll comment on this after we release pgpool 3.1.1 RSN. Regards. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199630] Review Request: ClanLib - Cross platform C++ game library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ClanLib - Cross platform C++ game library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199630 --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 06:27 EST --- Fair enough. The package builds happily in mock on x86_64 and i386. rpmlint throws nothing of any real concern pingus (at least) links and runs happily against it I'm happy for this to be released into the wild. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199747] Review Request: pingus - Guide the penguins safely home before they drop of the cliff
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pingus - Guide the penguins safely home before they drop of the cliff https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199747 --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 06:33 EST --- Once I add the BR for get-text, everything is happy under mock and rpmlint comes up clean. The icon installs correctly under games. One concern is that the website only has version 0.6.0 as the stable release and not 0.7.0 as available here. I couldn't find it in the development area either. If you can make the BR and version number changes, this is good to go. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199747] Review Request: pingus - Guide the penguins safely home before they drop of the cliff
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pingus - Guide the penguins safely home before they drop of the cliff https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199747 --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 06:40 EST --- If you look at the first screen when you start pingus it will welcome you to pingus 0.7.0 . As you can see in the spec this is a svn snapshot, which is also reflected in the release: 0.1.20060721 . The current svn trunk is destined to become 0.7.0 some day (hopefully soon), so calling it 0.6.x is wrong, since it is not 0.6.x. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199632] Review Request: ClanLib06 - Version 0.6 of this Cross platform C++ game library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: ClanLib06 - Version 0.6 of this Cross platform C++
game library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199632
--- Additional Comments From [EMAIL PROTECTED] 2006-07-23 06:47 EST ---
It'll now build and rpmlint is happy with all of the packages created.
I've made the alterations to the spec file so both tolua++-devel and
Hermes-devel are in the BRs and will get back to you on how it works under mock.
Can you also make the BR alteration changes and upload the new spec file?
One other thing. You have provides: clanlib06 = {version}-{release}. That's
okay, but why is it clanlib06 and not ClanLib06 as the spec file and other
references inside the spec file call it?
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199747] Review Request: pingus - Guide the penguins safely home before they drop of the cliff
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pingus - Guide the penguins safely home before they drop of the cliff https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199747 --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 06:52 EST --- Not a problem, it's just the BR and out the door it can go! -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199402] Review Request: chrpath - Modify rpath of compiled programs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: chrpath - Modify rpath of compiled programs https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199402 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 06:59 EST --- Thanks, packages for FC4-FC6 have been built and will appear soon. I saw you got sponsored on the second bug, so I can look into the first one. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199405] Review Request: vtk - The Visualization Toolkit - A high level 3D visualization library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: vtk - The Visualization Toolkit - A high level 3D visualization library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199405 Bug 199405 depends on bug 199402, which changed state. Bug 199402 Summary: Review Request: chrpath - Modify rpath of compiled programs https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199402 What|Old Value |New Value Resolution||NEXTRELEASE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199192] Review Request: kadu - Gadu-Gadu client for online messaging
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kadu - Gadu-Gadu client for online messaging https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199192 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] OtherBugsDependingO|163776 |163778 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 07:08 EST --- Manus manum lavat, reviewing the bug in the next comments. :) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192420] Review Request: Bonfire - CD/DVD burning app for gnome
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Bonfire - CD/DVD burning app for gnome https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192420 --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 07:18 EST --- (In reply to comment #8) Vedran: As I understand it, when the binary RPM is built, it find the dependencies on the shared libraries that this package would link to. Hence, it would depend on things like libtotem-plparser.so.1 (or whatever the exact SO name is). Thus, simply replacing totem with totem-xine should be fine on the user's end, as they both (to my knowledge) provide the same shared libraries. The reason it actually depends on 'totem' when you attempt to install it after building it is that totem is the only RPM available in the default repositories which contains these libraries. Hope that helps. I actually noticed that some time later, but simple yum install totem-xine after bonfire has been installed complains about unsatisfied dependancy, and yum remove totem triest to remove bonfire as well. But that's not an issue on bonfire side, since it can be made to work the way you mentioned. Thanks for clarification. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199192] Review Request: kadu - Gadu-Gadu client for online messaging
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: kadu - Gadu-Gadu client for online messaging
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199192
--- Additional Comments From [EMAIL PROTECTED] 2006-07-23 08:16 EST ---
MUST items
==
- rpmlint output (see below): not OK
+ package name: OK
- (latest) spec file name (0.5.0-0.1.20060716svn.spec): not OK, please use
kadu.spec again
+ license is open source: OK
+ license in sources (GPL2) and license in specfile (GPL) match: OK
- license (COPYING) included, but not in %doc: not OK (?)
o American English: OK (but there is a trivial typo: s/Develpoments/Development/
in %description devel and missing by at some made by in other
descriptions)
+ specfile legible: OK (but see comments below)
- sources match upstream: not OK
http://www.kadu.net/download/snapshots/kadu-20060716.tar.bz2 doesn't exist
anymore
+ compiles and build into binary rpms: OK on i386
+ sane BRs: OK
+ locales: OK (doesn't use locale folder directly, installs in private
location)
+ ldconfig usage: OK (none neccessary, no shared libs under %{_libdir})
+ owns its directories: OK
+ %files duplicate: OK (none reported)
- permissions: not OK (see below)
+ %clean section: OK
+ system macros: OK (used)
+ contains code: OK
+ doc subpackage: OK (not needed)
+ %doc contents do not influence runtime: OK
+ devel package (contents): OK
+ devel package (dependencies): OK
+ %{name}.desktop/desktop-file-install: OK
rpmlint:
errors:
E: kadu-debuginfo empty-debuginfo-package
E: kadu explicit-lib-dependency libsndfile
warnings:
W: kadu-alsa_sound no-documentation
W: kadu-alsa_sound unstripped-binary-or-object
/usr/lib64/kadu/modules/alsa_sound.so
W: kadu-amarok no-documentation
W: kadu-amarok unstripped-binary-or-object /usr/lib64/kadu/modules/amarok.so
W: kadu-arts_sound no-documentation
W: kadu-arts_sound unstripped-binary-or-object
/usr/lib64/kadu/modules/arts_sound.so
W: kadu-dcopexport no-documentation
W: kadu-dcopexport unstripped-binary-or-object
/usr/lib64/kadu/modules/dcopexport.so
W: kadu-devel no-documentation
W: kadu-esd_sound no-documentation
W: kadu-esd_sound unstripped-binary-or-object
/usr/lib64/kadu/modules/esd_sound.so
W: kadu-exec_notify no-documentation
W: kadu-exec_notify unstripped-binary-or-object
/usr/lib64/kadu/modules/exec_notify.so
W: kadu-ext_info no-documentation
W: kadu-ext_info unstripped-binary-or-object /usr/lib64/kadu/modules/ext_info.so
W: kadu-filedesc no-documentation
W: kadu-filedesc unstripped-binary-or-object /usr/lib64/kadu/modules/filedesc.so
W: kadu-iwait4u no-documentation
W: kadu-iwait4u unstripped-binary-or-object /usr/lib64/kadu/modules/iwait4u.so
W: kadu-led_notify no-documentation
W: kadu-led_notify unstripped-binary-or-object
/usr/lib64/kadu/modules/led_notify.so
W: kadu-miastoplusa_sms no-documentation
W: kadu-miastoplusa_sms unstripped-binary-or-object
/usr/lib64/kadu/modules/miastoplusa_sms.so
W: kadu mixed-use-of-spaces-and-tabs
W: kadu no-documentation
W: kadu setup-not-quiet
W: kadu-spellchecker no-documentation
W: kadu-spellchecker unstripped-binary-or-object
/usr/lib64/kadu/modules/spellchecker.so
W: kadu-tabs no-documentation
W: kadu-tabs unstripped-binary-or-object /usr/lib64/kadu/modules/tabs.so
W: kadu-theme-crystal16 no-documentation
W: kadu-theme-crystal22 no-documentation
W: kadu-theme-gg6_compatible no-documentation
W: kadu-theme-glass16 no-documentation
W: kadu-theme-glass22 no-documentation
W: kadu-theme-nuvola16 no-documentation
W: kadu-theme-nuvola22 no-documentation
W: kadu unstripped-binary-or-object
/usr/lib64/kadu/modules/account_management.so
W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/arts_sound.so
W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/autoaway.so
W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/autoresponder.so
W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/config_wizard.so
W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/dcc.so
W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/default_sms.so
W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/dsp_sound.so
W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/encryption.so
W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/ext_sound.so
W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/hints.so
W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/migration.so
W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/sms.so
W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/voice.so
W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/window_notify.so
W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/x11_docking.so
W: kadu-weather no-documentation
W: kadu-weather unstripped-binary-or-object /usr/lib64/kadu/modules/weather.so
W: kadu-xmms no-documentation
W: kadu-xmms
[Bug 199679] Review Request: pgpool - Connection pooling/replication server for PostgreSQL
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: pgpool - Connection pooling/replication server for
PostgreSQL
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199679
--- Additional Comments From [EMAIL PROTECTED] 2006-07-23 08:23 EST ---
H(In reply to comment #1)
I have done quick reviewi,
and I noticed a few things you have to do:
* add %{?dist} tag to release number.
Done.
* Source0 have to be URL, actually it is unable to check if archive in
src.rpm and archive on .net checksums is matching.
Done.
* you should use %configure macro instead of hardcoding it
Done.
* Packaging Guidelines suggest to use make %{?_smp_flags} instead of 'make'
alone
Done.
* in %install section you forgot to write $RPM_BUILD_ROOT before %{_mandir}
* man file has wrong permissions (0744), you have to change it to 644 typing:
%attr(0644, root, root) %{_mandir}/man8/* in %section
I solved this during %install.
I'll post the URLs as another comment. Thanks a lot.
Regards, Devrim
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 165957] Review Request: esmtp. Relay only MTA.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: esmtp. Relay only MTA. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165957 [EMAIL PROTECTED] changed: What|Removed |Added Status|CLOSED |NEW Keywords||Reopened Resolution|NEXTRELEASE | -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199679] Review Request: pgpool - Connection pooling/replication server for PostgreSQL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pgpool - Connection pooling/replication server for PostgreSQL https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199679 --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 08:55 EST --- New spec file for 3.1.1: http://pgfoundry.org/frs/download.php/984/pgpool.spec New SRPM for 3.1.1: http://pgfoundry.org/frs/download.php/983/pgpool-3.1.1-1.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199192] Review Request: kadu - Gadu-Gadu client for online messaging
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: kadu - Gadu-Gadu client for online messaging
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199192
--- Additional Comments From [EMAIL PROTECTED] 2006-07-23 09:08 EST ---
First, thank for review!
o American English: OK (but there is a trivial typo: s/Develpoments/
Development/
in %description devel and missing by at some made by in other
descriptions)
Fixed.
- sources match upstream: not OK
http://www.kadu.net/download/snapshots/kadu-20060716.tar.bz2 doesn't exist
anymore
Fixed; the address was changed.
comments:
=
- build should include debugging symbols, e.g. the buildlog has:
Compile with debug symbols: no
Please compile with debug symbols and let rpm automagically extract them out
into the debuginfo package.
Fixed.
- permissions of shared libs should be executable to allow for debuginfo
extraction
Fixed.
- Requires: libsndfile is not neccessary (unless it needs something from
%{_bindir}/sndfile-* at runtime
Require deleted.
- mixed-use-of-spaces-and-tabs: Use emacs to tabbify/untabbify the specfile
Now, it's OK.
- %setup -D -T -n kadu is missing -q
Fixed.
- unstripped-binary-or-object: Fix by making the modules executable either
with chmod at the end of %install of with %attr/%defattr
Fixed.
- self-defined macros: In general I'm not against self-defined macros to make
packages more flexible or legible. In this case some macros make the
specfile
harder to read than neccessary for example _kadudir being %{_datadir}/kadu.
I wouldn't call this a blocker, but I would recommend to unwrap most of
these
macros to increase legibility.
No, I won't unwrap these macros. This is still SVN pre-release, some things
may change in future and macros make me easier to change path.
Please install rpmlint on your system and use it on the packages while
developing the specfile.
I've already installed it, but most of your errors wasn't showed for me by
rpmlint, do you use any arguments to it?
I'll give new addresses for SRPM and SPEC in next comment.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199192] Review Request: kadu - Gadu-Gadu client for online messaging
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kadu - Gadu-Gadu client for online messaging https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199192 --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 09:09 EST --- New files: Spec URL: http://ecik.zspswidwin.pl/kadu/kadu.spec SRPM URL: http://ecik.zspswidwin.pl/kadu/kadu-0.5.0-0.2.20060716svn.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199679] Review Request: pgpool - Connection pooling/replication server for PostgreSQL
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: pgpool - Connection pooling/replication server for
PostgreSQL
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199679
--- Additional Comments From [EMAIL PROTECTED] 2006-07-23 09:27 EST ---
* You got an error in changelog entry. It starts with asterisk instead
of hyphen.
* The %{?smp_flags} should be after make in %build section, not in
make install.
* You should use %{_sysconfdir} macro in %configure instead of /etc
hard-coding.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199732] Review Request: clanbomber - Bomberman-like multiplayer game that uses ClanLib
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: clanbomber - Bomberman-like multiplayer game that uses ClanLib https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199732 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199632] Review Request: ClanLib06 - Version 0.6 of this Cross platform C++ game library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ClanLib06 - Version 0.6 of this Cross platform C++ game library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199632 --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 09:36 EST --- mock build fails : line 45 autoconf : command cannot be found -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 178901] Review Request: gtksourceview-sharp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gtksourceview-sharp https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=178901 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199679] Review Request: pgpool - Connection pooling/replication server for PostgreSQL
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: pgpool - Connection pooling/replication server for
PostgreSQL
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199679
--- Additional Comments From [EMAIL PROTECTED] 2006-07-23 09:54 EST ---
Hi,
(In reply to comment #6)
* You got an error in changelog entry. It starts with asterisk instead
of hyphen.
* The %{?smp_flags} should be after make in %build section, not in
make install.
* You should use %{_sysconfdir} macro in %configure instead of /etc
hard-coding.
All done. Thanks for the contribution.
Regards, Devrim
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199679] Review Request: pgpool - Connection pooling/replication server for PostgreSQL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pgpool - Connection pooling/replication server for PostgreSQL https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199679 --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 09:55 EST --- New spec: http://pgfoundry.org/frs/download.php/986/pgpool.spec New srpm: http://pgfoundry.org/frs/download.php/987/pgpool-3.1.1-2.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 189400] Review Request: em8300(-kmod) - Hollywood+/DXR3 hardware MPEG decoder drivers and tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: em8300(-kmod) - Hollywood+/DXR3 hardware MPEG decoder drivers and tools https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189400 --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 10:46 EST --- (In reply to comment #9) If the kernel module has a suitable licence for FC5, then it presumably has a suitable licence for being included directly in the kernel. Agreed. Thus, the correct approach would be to get the support into the upstream kernel and therefore into our base kernel package, rather than having a separate kmod package for it. Also agreed, and that's why we we plan to try our best to tell upstream maintainers get your stuff merged. That why we require a statement when people plan to get their stuff merged (see comment #4). I strongly believe we should veto _all_ kmod packages in Core and Extras. This was discussed before when we started the development of the kmod-standard for Extras -- several people from Red Hat were involved in that discussion and we agreed to work on it nevertheless the political problems. Anyway, I can really understand your point. That why I suggested in the beginning that all kmods are only allowed for X months (X=12 or 18) in Extras before they get dropped again and that upstream shall work on getting its suff into the kernel in that timeframe. But that idea was not accepted by other involved in the discussion. Anyway, I don't think we should discuss this further here and probably won't reply again in this bug. fedora-devel-list probably is the better place for this sort of political discussions. Site note: It's IMHO more a kernel vs. distributions problem: I'm sure all those people currently listed in the CC of this bug agree that it's important and best to get all drivers into the kernel as fast as possible (as long as they are clean and even if they are far from feature complete ) and that external drivers have many pitfalls and should be avoided as much as possible. But it seems some open-source-driver-developers don't feel that way and prefer to maintain their drivers outside of the upstream kernel. They probably fear (for no good reason) getting Christophed. That's a pity, but it's life in 2006. But some distributions include these external drivers. That creates pressure on those distributions that don't include external drivers because people run away. E.g.: I like Fedora. But it doesn't include the external driver foo -- distribution bar has it already and thus is far easier to use for me because I need that driver. That's why I switched over to bar. So IMHO kernel developers and the kernel-maintainers of the most important distributions need to work together closely and create policies like every distribution may only contain 10 kernel-drivers that are not yet merged into the upstream kernel. The pressure on driver developers to get their drivers merged into linus kernel would be a lot bigger then. Just my 2 cent. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 178904] Review Request: Monodevelop
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: Monodevelop
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=178904
--- Additional Comments From [EMAIL PROTECTED] 2006-07-23 10:55 EST ---
Looks like it's the ol' needs to be in %{_prefix}/lib problem again. I've fixed
the which problem and will fix the other problem shortly.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199192] Review Request: kadu - Gadu-Gadu client for online messaging
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kadu - Gadu-Gadu client for online messaging https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199192 --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 11:04 EST --- - build should include debugging symbols, e.g. the buildlog has: Compile with debug symbols: no Please compile with debug symbols and let rpm automagically extract them out into the debuginfo package. note that --enable-debug compiles in very noisy console output (binary is ~8-10% bigger) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 178904] Review Request: Monodevelop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Monodevelop https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=178904 --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 11:39 EST --- Spec Name or Url: http://www.knox.net.nz/~nodoid/monodevelop.spec SRPM Name or Url: http://www.knox.net.nz/~nodoid/monodevelop-0.11-12.src.rpm Sorts out the lib problem and which problem -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 182320] Review Request: gnome-build
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-build https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=182320 --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 11:42 EST --- Spec Name or Url: http://www.knox.net.nz/~nodoid/gnome-build.spec SRPM Name or Url: http://www.knox.net.nz/~nodoid/gnome-build-0.1.3-5.src.rpm It still lacks the smp flags as my system doesn't always like smp flags. No idea why and have never been able to trace the fault (it won't, for example compile anjuta2 with smp flags on) libtool now fixed as is the perl issue. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199867] New: Review Request: fedora-release-notes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199867 Summary: Review Request: fedora-release-notes Product: Fedora Core Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com Spec URL: http://people.redhat.com/jkeating/fedora-release-notes.spec SRPM URL: http://people.redhat.com/jkeating/fedora-release-notes-5.91-2.src.rpm Description: These are the official Release Notes for Fedora Core 5.91, written and edited by the Fedora community. For more information on the Release Notes process or how you can contribute, refer to the Release Notes HOWTO located at http://fedoraproject.org/wiki/Docs/Beats/HowTo. This is a splitoff from the fedora-release package to be a standalone package. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 197353] Review Request: man-pages-fr - French man pages from the Linux Documentation Project
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: man-pages-fr - French man pages from the Linux Documentation Project https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197353 --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 13:39 EST --- Spec URL: http://linuxelectronique.free.fr/download/fedora/5/SPECS/man-pages-fr.spec SRPM URL: http://linuxelectronique.free.fr/download/fedora/5/SRPMS/man-pages-fr-2.24.0-1.src.rpm %changelog * Sun Jul 23 2006 Alain Portal aportal AT univ-montp2 DOT fr 2.25.0-1 - Update to 2.25.0 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 197445] Review Request: fuse-convmvfs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: fuse-convmvfs https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197445 --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 13:43 EST --- Hi ZC! A couple quick notes: * Are you sponsored? If not, you need to block the bug FE-NEEDSPONSOR as well. * It's customary to post direct links to the srpm and spec file you're asking to be reviewed, not entries in CVS or tarball downloads. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199747] Review Request: pingus - Guide the penguins safely home before they drop of the cliff
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pingus - Guide the penguins safely home before they drop of the cliff https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199747 --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 13:46 EST --- New spec with fixed BR here: Spec URL: http://people.atrpms.net/~hdegoede/pingus.spec Notice I didn't upload a new SRPM as its huge and my uplink is quite slow. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196945] Review Request: python-smbpasswd - Python SMB Password Hash Generator Module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-smbpasswd - Python SMB Password Hash Generator Module https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196945 --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 13:47 EST --- Next release: Spec URL: http://www.herr-schmitt.de/pub/python-smbpasswd/python-smbpasswd.spec SRPM URL: http://www.herr-schmitt.de/pub/python-smbpasswd/python-smbpasswd-1.0.1-2.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 190956] Review Request: php-pear-Auth-SASL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-pear-Auth-SASL Alias: php-pear-Auth-SASL https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190956 --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 13:52 EST --- SPEC : http://remi.collet.free.fr/rpms/extras/php-pear-Auth-SASL.spec SRPM : http://remi.collet.free.fr/rpms/extras/php-pear-Auth-SASL-1.0.2-2.fc5.src.rpm Mock : http://remi.collet.free.fr/rpms/extras/php-pear-Auth-SASL-build.log Changes : - use new macros from /etc/rpm/macros.pear - own /usr/share/pear/Auth -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199632] Review Request: ClanLib06 - Version 0.6 of this Cross platform C++ game library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: ClanLib06 - Version 0.6 of this Cross platform C++
game library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199632
--- Additional Comments From [EMAIL PROTECTED] 2006-07-23 13:55 EST ---
(In reply to comment #7)
One other thing. You have provides: clanlib06 = {version}-{release}. That's
okay, but why is it clanlib06 and not ClanLib06 as the spec file and other
references inside the spec file call it?
Since it _is_ ClanLib06 it will automaticly provide CLanLib06, the lowercase
provide is there exactly for what it is to provide a lowercase alternative to
people who prefer all lowercase names. The guidelines have recently been updated
saying that its ok to have names containing uppercase when upstream uses
uppercase consistenly, but that a full lowercase provides should be present. The
reasoning behind this was to stop problems like you where having with _H_ermes.
About autoconf, missing BR. Sorry about all these missing BR's if I had a better
internet conenction myself I would try things in mock myself :|
Anyways here is a new version which hopefully will build in mock:
Spec URL: http://people.atrpms.net/~hdegoede/ClanLib06.spec
SRPM URL: http://people.atrpms.net/~hdegoede/ClanLib06-0.6.5-2.src.rpm
Changes:
* Sun Jul 23 2006 Hans de Goede [EMAIL PROTECTED] 0.6.5-2
- Add missing BRs: tolua++-devel, Hermes-devel and autoconf
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196945] Review Request: python-smbpasswd - Python SMB Password Hash Generator Module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-smbpasswd - Python SMB Password Hash Generator Module https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196945 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] OtherBugsDependingO|163776 |163778 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 14:25 EST --- Ok, I'll review your package. MUST items: * rpmlint message: E: python-smbpasswd-debuginfo script-without-shellbang /usr/src/debug/py- smbpasswd-1.0.1/smbpasswd.c - you should change permissions of this file to 644 in %prep section * the package is named well * spec file is named well * License field in package spec file match the actual license (GPL) * spec is written in American English and is legible * md5sums of source used to build the package and of upstream source are matching (0eab2c29588e32e77ce6e5d2faea7874) * package successfully compile on i386 * all build dependencies is good listed (mock builds successful) * there is no any locales * package doesn't contain shared library files * there is no duplicate files in %files listing * permissions aren't set properly (rpmlint error) * package has a good %clean section * there is no .la files * there is no GUI applications Thus, everything is good except for bad permissions of smbpasswd.c file. If you fix it, I'll approve this package. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199630] Review Request: ClanLib - Cross platform C++ game library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ClanLib - Cross platform C++ game library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199630 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE OtherBugsDependingO|163778 |163779 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 14:33 EST --- Thanks for the review! Imported and build, closing. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199747] Review Request: pingus - Guide the penguins safely home before they drop of the cliff
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pingus - Guide the penguins safely home before they drop of the cliff https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199747 Bug 199747 depends on bug 199630, which changed state. Bug 199630 Summary: Review Request: ClanLib - Cross platform C++ game library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199630 What|Old Value |New Value Resolution||NEXTRELEASE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199192] Review Request: kadu - Gadu-Gadu client for online messaging
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: kadu - Gadu-Gadu client for online messaging
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199192
--- Additional Comments From [EMAIL PROTECTED] 2006-07-23 14:56 EST ---
Please install rpmlint on your system and use it on the packages while
developing the specfile.
I've already installed it, but most of your errors wasn't showed for me by
rpmlint, do you use any arguments to it?
No, just use it on the src.rpm as well as on the binary rpm. Maybe you only used
it on the src.rpm?
note that --enable-debug compiles in very noisy console output (binary is
~8-10% bigger)
Isn't this removed when stripping off the symbols? rpm does that automatically
and generates debuginfo packages with these symbols. So usually one installs the
stripped binary w/o the extra space and when an issue comes up one can install
the matching debuginfo rpm and run gdb on it.
I wrote:
- unstripped-binary-or-object: Fix by making the modules executable either
with chmod at the end of %install of with %attr/%defattr
That was wrong. I rebuilt the latest src.rpm and the unstripped binaries are
still around. You need to chmod then, %attr alone doesn't help as it is taken
into account *after* the debuginfo creation. Sorry for the misleading
information.
Can you fix that and also %exclude
%{_kadudir}/AUTHORS
%{_kadudir}/ChangeLog
%{_kadudir}/COPYING
%{_kadudir}/HISTORY
%{_kadudir}/README
%{_kadudir}/THANKS
and instead add them with %doc?
All other points were checked and are OK. For reference:
+ spec file name: OK
+ sources match upstream: OK
+ American English: OK
+ permissions: OK (on manifest level)
- license (COPYING) included, but not in %doc: not OK
- rpmlint output:
$ rpmlint *rpm | grep -v kadu-.*no-documentation
W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/voice.so
W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/autoaway.so
W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/config_wizard.so
W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/migration.so
W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/window_notify.so
W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/dcc.so
W: kadu unstripped-binary-or-object
/usr/lib64/kadu/modules/account_management.so
W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/autoresponder.so
W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/arts_sound.so
W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/sms.so
W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/hints.so
W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/dsp_sound.so
W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/x11_docking.so
W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/default_sms.so
W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/ext_sound.so
W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/encryption.so
W: kadu no-documentation
W: kadu-alsa_sound unstripped-binary-or-object
/usr/lib64/kadu/modules/alsa_sound.so
W: kadu-amarok unstripped-binary-or-object /usr/lib64/kadu/modules/amarok.so
W: kadu-arts_sound unstripped-binary-or-object
/usr/lib64/kadu/modules/arts_sound.so
W: kadu-dcopexport unstripped-binary-or-object
/usr/lib64/kadu/modules/dcopexport.so
W: kadu-esd_sound unstripped-binary-or-object
/usr/lib64/kadu/modules/esd_sound.so
W: kadu-exec_notify unstripped-binary-or-object
/usr/lib64/kadu/modules/exec_notify.so
W: kadu-ext_info unstripped-binary-or-object /usr/lib64/kadu/modules/ext_info.so
W: kadu-filedesc unstripped-binary-or-object /usr/lib64/kadu/modules/filedesc.so
W: kadu-iwait4u unstripped-binary-or-object /usr/lib64/kadu/modules/iwait4u.so
W: kadu-led_notify unstripped-binary-or-object
/usr/lib64/kadu/modules/led_notify.so
W: kadu-miastoplusa_sms unstripped-binary-or-object
/usr/lib64/kadu/modules/miastoplusa_sms.so
W: kadu-spellchecker unstripped-binary-or-object
/usr/lib64/kadu/modules/spellchecker.so
W: kadu-tabs unstripped-binary-or-object /usr/lib64/kadu/modules/tabs.so
W: kadu-weather unstripped-binary-or-object /usr/lib64/kadu/modules/weather.so
W: kadu-xmms unstripped-binary-or-object /usr/lib64/kadu/modules/xmms.so
If you fix the above two issues this output will vanish and the package
approved :)
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199192] Review Request: kadu - Gadu-Gadu client for online messaging
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: kadu - Gadu-Gadu client for online messaging
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199192
--- Additional Comments From [EMAIL PROTECTED] 2006-07-23 15:26 EST ---
(In reply to comment #14)
I wrote:
- unstripped-binary-or-object: Fix by making the modules executable
either
with chmod at the end of %install of with %attr/%defattr
That was wrong. I rebuilt the latest src.rpm and the unstripped binaries are
still around. You need to chmod then, %attr alone doesn't help as it is taken
into account *after* the debuginfo creation. Sorry for the misleading
information.
I hope them is stripped good, now :-)
Can you fix that and also %exclude
%{_kadudir}/AUTHORS
%{_kadudir}/ChangeLog
%{_kadudir}/COPYING
%{_kadudir}/HISTORY
%{_kadudir}/README
%{_kadudir}/THANKS
and instead add them with %doc?
As I write in my first post I cannot do it, because Kadu uses these files
in About window so they must be in proper directory.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199867] Review Request: fedora-release-notes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: fedora-release-notes https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199867 --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 15:26 EST --- From a quick look, seems sane. Although didn't we decide to just have fedora-release require the release-notes and not the loop? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 174021] Review Request: aplus-fsf - Advanced APL Interpreter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: aplus-fsf - Advanced APL Interpreter https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=174021 --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 15:29 EST --- Next release for review: Spec: http://www.herr-schmitt.de/pub/aplus-fsf/aplus-fsf.spec SRPM: http://www.herr-schmitt.de/pub/aplus-sfs/aplus-fsf-4.20.2-5.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199573] Review Request: BackupPC - high-performance backup system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: BackupPC - high-performance backup system https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199573 --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 15:54 EST --- Spec: http://mmcgrath.net/~mmcgrath/BackupPC/BackupPC.spec SRPM: http://mmcgrath.net/~mmcgrath/BackupPC/BackupPC-2.1.2-3.src.rpm - Changes to defaults in config.pl - Added Requires: rsync -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199834] Review Request: nip2 - interactive image processing system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nip2 - interactive image processing system https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199834 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 16:15 EST --- Good: + Tar ball match with upstream source. Bad: - Can't find vips-devel as BR. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199632] Review Request: ClanLib06 - Version 0.6 of this Cross platform C++ game library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ClanLib06 - Version 0.6 of this Cross platform C++ game library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199632 --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 16:39 EST --- I've found a problem when running on i386-devel with default SELinux settings. Here is a new release which fixes this (in combination with a soon to be pushed new Hermes): Spec URL: http://people.atrpms.net/~hdegoede/ClanLib06.spec SRPM URL: http://people.atrpms.net/~hdegoede/ClanLib06-0.6.5-3.src.rpm Changes: * Sun Jul 23 2006 Hans de Goede [EMAIL PROTECTED] 0.6.5-3 - Mark asm files as NOT needing execstack, making us OK with new default SELinux targeted policy settings. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199192] Review Request: kadu - Gadu-Gadu client for online messaging
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kadu - Gadu-Gadu client for online messaging https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199192 --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 17:27 EST --- (In reply to comment #15) As I write in my first post I cannot do it, because Kadu uses these files in About window so they must be in proper directory. Maybe adding a small patch? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199192] Review Request: kadu - Gadu-Gadu client for online messaging
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kadu - Gadu-Gadu client for online messaging https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199192 --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 17:36 EST --- (In reply to comment #19) Maybe adding a small patch? I'm not convinced to it. Files in %doc should be unicode coded, but kadu doc files is iso8859-2 coded and if we change it, in About window characters could be wrong. The most reasonable solution to me is include in %doc only COPYING file. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 189662] Review Request: transconnect -- A function imposter to allow transparent connection over HTTPS proxies
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: transconnect -- A function imposter to allow transparent connection over HTTPS proxies https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189662 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 17:47 EST --- You should follow the naming guidelines, even if there is never a l.3, there is no reason to use 1.3. Also I think you should drop the %release_func stuff and do things more simply. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199632] Review Request: ClanLib06 - Version 0.6 of this Cross platform C++ game library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ClanLib06 - Version 0.6 of this Cross platform C++ game library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199632 --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 17:51 EST --- rpmlint is warning me the src.rpm is mod 0666 instead of 0664 for the spec file One thing I did notice during the build and that is debugging is turned off while building, yet a debuginfo package is available. Surely this should not occur. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 188461] Review Request: xmms-musepack - Mpegplus (mpc) playback plugin for XMMS
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: xmms-musepack - Mpegplus (mpc) playback plugin for XMMS
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188461
[EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
--- Additional Comments From [EMAIL PROTECTED] 2006-07-23 18:03 EST ---
Some remarks:
* the buildroot is not the right one
* although the %define xmms_inputdir with xmms-config isn't clearly
wrong I think it should not be done that way, since xmms-config
must then be present at spec file generation time. Simply having
%define xmms_inputdir %{_libdir}/xmms/Input
or even replacing %xmms_inputdir with %{_libdir}/xmms/Input would
seem simpler and cleaner to me
* %setup is missing a -q
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199834] Review Request: nip2 - interactive image processing system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nip2 - interactive image processing system https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199834 --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 18:06 EST --- Check out bug #199833 for vips. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199867] Review Request: fedora-release-notes
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: fedora-release-notes
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199867
--- Additional Comments From [EMAIL PROTECTED] 2006-07-23 18:14 EST ---
* Is the license on the relnotes really distibutable or is OPL?
* It'd probably be better to see if scrollkeeper/desktop-file-utils exists in
the scriptlet and continue anyway. This will be part of the minimal package set
and we don't really want to bloat that
* The %{dist} tag is probably overkill since the version is the dist
Otherwise, looks good to go
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192606] Review Request: yafc: yet another ftp client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: yafc: yet another ftp client https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192606 --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 18:24 EST --- spec: http://rpm.forevermore.net/yafc/yafc.spec srpm: http://rpm.forevermore.net/yafc/yafc-1.1.1-3.src.rpm ok, patch, etc applied. Builds in mock, too. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199611] Review Request: monsterz - Puzzle game, similar to Bejeweled or Zookeeper
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: monsterz - Puzzle game, similar to Bejeweled or Zookeeper https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199611 --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 18:40 EST --- Spec URL: http://dribble.org.uk/reviews/monsterz.spec SRPM URL: http://dribble.org.uk/reviews/monsterz-0.7.0-5.src.rpm Thanks, this should fix those issues. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199173] Review Request: clusterssh
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: clusterssh https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199173 --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 18:48 EST --- Ok, it builds cleanly in mock. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 180092] Review Request: NRPE - Monitoring agent for Nagios
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: NRPE - Monitoring agent for Nagios https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=180092 --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 18:55 EST --- No more rpmlint errors: SPEC: http://mmcgrath.net/~mmcgrath/nrpe/nrpe.spec SRPM: http://mmcgrath.net/~mmcgrath/nrpe/nrpe-2.5.2-2.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199192] Review Request: kadu - Gadu-Gadu client for online messaging
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kadu - Gadu-Gadu client for online messaging https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199192 --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 19:25 EST --- note that --enable-debug compiles in very noisy console output (binary is ~8-10% bigger) Isn't this removed when stripping off the symbols? no rpm does that automatically and generates debuginfo packages with these symbols. how would rpm know which (used in code) symbols to strip? how would it remove _kdebug_with_mask calls? how would it remove code between #ifdef DEBUG_ENABLED and #endif? you need to disable debug or make a patch for Kadu sources -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 188461] Review Request: xmms-musepack - Mpegplus (mpc) playback plugin for XMMS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xmms-musepack - Mpegplus (mpc) playback plugin for XMMS https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188461 --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 19:37 EST --- although the %define xmms_inputdir with xmms-config isn't clearly wrong I think it should not be done that way, since xmms-config must then be present at spec file generation time. No, it need not be present at src.rpm build-time. It must be present when building the binaries. Also notice the || echo ... which ensures that all this still works when xmms-config is not found. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199867] Review Request: fedora-release-notes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: fedora-release-notes https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199867 --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 19:43 EST --- Ok, changes made, spec is the same url: http://people.redhat.com/jkeating/fedora-release-notes-5.91-3.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 189662] Review Request: transconnect -- A function imposter to allow transparent connection over HTTPS proxies
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: transconnect -- A function imposter to allow transparent connection over HTTPS proxies https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189662 --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 19:52 EST --- * Mon Jul 24 2006 Enrico Scholz [EMAIL PROTECTED] - 1:1.3-0.1.Beta - follow Fedora naming guidelines strictly; increased epoch http://ensc.de/fedora/transconnect/ Also I think you should drop the %release_func stuff and do things more simply. no; I like it this way -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 189662] Review Request: transconnect -- A function imposter to allow transparent connection over HTTPS proxies
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: transconnect -- A function imposter to allow transparent connection over HTTPS proxies https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189662 --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 20:08 EST --- * Mon Jul 24 2006 Enrico Scholz [EMAIL PROTECTED] - 1:1.3-0.2.Beta - enhanced -fixup patch to put a optimization barrier after cleaning password data http://ensc.de/fedora/transconnect/ -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199573] Review Request: BackupPC - high-performance backup system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: BackupPC - high-performance backup system https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199573 --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 20:21 EST --- FWIW, a few comments: - The latest spec is for Release 4. The download area seems to contain a binary rpm for this release, but not a src rpm. - In order to set up ssh keys, the admin must (I think) change the backuppc user to have a shell, set up ssh, and then change back to /sbin/nologin. Not sure if there's a way around this, but you might want to document this. - You might want to include upstream patch BackupPC-2.1.2pl2.diff (which is needed to work with the latest versions of rsync). It also fixes other bugs. - perl-File-RsyncP-0.62-1.src.rpm wouldn't compile for me on an up-to-date x86_64 FC5. 0.52 is OK. HTH -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199573] Review Request: BackupPC - high-performance backup system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: BackupPC - high-performance backup system https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199573 --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 22:29 EST --- Spec: http://mmcgrath.net/~mmcgrath/BackupPC/BackupPC.spec SRPM: http://mmcgrath.net/~mmcgrath/BackupPC/BackupPC-2.1.2-4.src.rpm - Added upstream patch try using http://mmcgrath.net/~mmcgrath/perl-File-RsyncP/perl-File-RsyncP-0.62-2.src.rpm Its actually been approved and built. You should be able to yum it soon. SSH keys - I find it best not to tell admins how their security should be done. Especially since BackupPC supports so many different methods for backup. Having said that it might not be a bad idea to at least point them to the BackupPC documentation for setting up ssh keys. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199867] Review Request: fedora-release-notes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: fedora-release-notes https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199867 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEEDINFO|CLOSED Resolution||RAWHIDE Flag||needinfo? --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 22:35 EST --- Built into rawhide. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199573] Review Request: BackupPC - high-performance backup system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: BackupPC - high-performance backup system https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199573 --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 22:46 EST --- (In reply to comment #7) Spec: http://mmcgrath.net/~mmcgrath/BackupPC/BackupPC.spec SRPM: http://mmcgrath.net/~mmcgrath/BackupPC/BackupPC-2.1.2-4.src.rpm Do you mean 2.1.2-5? - Added upstream patch Thanks :) try using http://mmcgrath.net/~mmcgrath/perl-File-RsyncP/perl-File-RsyncP-0.62-2.src.rpm Its actually been approved and built. You should be able to yum it soon. Builds for me :) SSH keys - I find it best not to tell admins how their security should be done. Especially since BackupPC supports so many different methods for backup. Having said that it might not be a bad idea to at least point them to the BackupPC documentation for setting up ssh keys. Agreed. I guess my point is: - The package defaults to rsync over ssh. - The official BackupPC docs describe a procedure for setting up ssh that won't work if the backuppc user does not have a shell. Again, not really sure if you should do anything about this... Hopefully most users will figure it out. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 194320] Review Request: im-chooser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: im-chooser https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194320 --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 23:36 EST --- BTW there is no component for im-chooser in bugzilla (I mean for Fedora Core). can you add it? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198882] Review Request: perl-POE-Component-IRC
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-POE-Component-IRC https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198882 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2006-07-23 23:42 EST --- At last, but not least... closure for this review :) +Import to CVS +Add to owners.list +Bump release, build for devel +devel build succeeds +Request branching +Close bug Thanks again! -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
