[Bug 256521] Review Request: php-pear-Creole - A database abstraction layer for PHP5
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-pear-Creole - A database abstraction layer for PHP5 https://bugzilla.redhat.com/show_bug.cgi?id=256521 [EMAIL PROTECTED] changed: What|Removed |Added BugsThisDependsOn||283401 --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 02:24 EST --- It seems there is a bug in PEAR. Build ok with F7 pear 1.5.0 Build hangs with newer version (1.5.4, 1.6.1). This issue also affects php-pear-PHPUnit. See Bug #283401 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 278481] Review Request: linuxdcpp - Client for the direct connect protocol
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: linuxdcpp - Client for the direct connect protocol
https://bugzilla.redhat.com/show_bug.cgi?id=278481
--- Additional Comments From [EMAIL PROTECTED] 2007-09-08 02:25 EST ---
- rpmlint: NEEDSWORK
W: linuxdcpp rpm-buildroot-usage %build scons PREFIX=%{_prefix}
FAKE_ROOT=$RPM_BUILD_ROOT release=0
It seems you can skip FAKE_ROOT=$RPM_BUILD_ROOT in %build, than rpmlint will be
silent. I do not know scons, but SConstruct uses FAKE_ROOT only in its install
section.
- licenses: NEEDSWORK
You used GPLv2 in License, but when I look in the source, nearly every file hast
a GPLv2+ header.
- naming: ok
- license in %doc: ok
- spec legible: ok
- compiling:builds for all supported architectures:ok
- BuildRequires: ok
- locales: not used: ok
- ldconfig: not needed: ok
- directory ownage: ok, todo
Please use %{_datadir}/linuxdcpp/ in %files to make it visible, that it is a
directory
- %clean, %install rm -rf: ok
- BuildRoot: ok
- no -devel or -static subpackage: ok
TODO (by me):
- Verify .desktop file
I do not yet know, how to verify whether or not StartupNotify and/or
StartupWMClass should be used. I have to do some research here.
- Verify tarball creation
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 239279] Review Request: libssh2 - A library implementing the SSH2 protocol
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: libssh2 - A library implementing the SSH2 protocol
Alias: libssh2
https://bugzilla.redhat.com/show_bug.cgi?id=239279
[EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
--- Additional Comments From [EMAIL PROTECTED] 2007-09-08 02:29 EST ---
Use download.sourceforge.net here:
Source0:
http://dl.sourceforge.net/libssh2/%{name}-%{version}-%{checkoutdate}.tar.gz
See:
http://fedoraproject.org/wiki/Packaging/SourceURL#head-e27982f18a3bfd26b5b6ecbee113d2d8f3f006f2
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 242416] Review Request: texlive - Binaries for the TeX formatting system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: texlive - Binaries for the TeX formatting system https://bugzilla.redhat.com/show_bug.cgi?id=242416 --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 02:37 EST --- 0.12 is now out. The major changes are the legal fixes suggested by Karl Berry, file shuffling between texlive and texlive-fonts package and handful of other fixes. ChangeLog is here: * Thu Aug 30 2007 Jindrich Novy [EMAIL PROTECTED] - 2007-0.12 - update description - BR ruby, don't obsolete tetex-tex4ht - remove license problematic/useless stuff, based on email from Karl Berry - move vfont.sample to doc - preserve timestamps - shuffle binaries between texlive and texlive-fonts, update scriptlets -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 187318] Review Request: mondo
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mondo https://bugzilla.redhat.com/show_bug.cgi?id=187318 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163776 | nThis|| --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 02:40 EST --- FE-NEW does not need to be blocked anymore. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 187828] Review Request: log4net - A tool to output log statements to a variety of output targets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: log4net - A tool to output log statements to a variety of output targets https://bugzilla.redhat.com/show_bug.cgi?id=187828 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 02:39 EST --- Chirs, you cannot review you own package, so you should not assign this package to you and set fedora-review to , otherwise no reviewer will find this review request. I did by accident, because I used the wrong query. ;-) Also I guess the FE-DEADREVIEW blocker should be removed and you should add yourself to CC. Or maybe you should open a new review request, to make you reporter of the review request, I am not sure. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 187317] Review Request: mindi
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mindi https://bugzilla.redhat.com/show_bug.cgi?id=187317 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] OtherBugsDependingO|163778 |177841 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 02:48 EST --- For afio and buffer I can also provide packages for fedora if there is a need indeed to provide them (I thought they were already part of the distro and didn't check that indeed). Please do this. Also I did some changes in Bug 187317 blocks: FE-NEEDSPONSOR was missing, FE-REVIEW is not needed anymore. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 281281] Review Request: netpipe - A network performance measurement tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: netpipe - A network performance measurement tool https://bugzilla.redhat.com/show_bug.cgi?id=281281 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Status|NEW |ASSIGNED Flag||fedora-review? --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 03:21 EST --- - naming: ok (debian also uses a lowercase name) - rpmlint: ok (silent) - source: ok cc458a9154f6b8c6da9fae16627beec4 NetPIPE-3.7.1.tar.gz cc458a9154f6b8c6da9fae16627beec4 NetPIPE-3.7.1.tar.gz.1 - BuildRoot: ok - Package compiles in koji for all supported archs - License: NEEDSWORK You use GPLv2+, but I cannot find any information on the version of the license, the header in some source files only mention GPL, but no version and so does README. Also no license text is included. These files do not contain any license header, but some contain an author: shmem.c MP_memcpy.c mpi2.c gpshmem.c gm.c armci.c Would you please ask upstream to update the license header (and the manpage and README) to a specific GPL Version, add a license header to the mentioned files and include the license text in the tarball? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 229098] Review Request: openjpeg - JPEG 2000 codec library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openjpeg - JPEG 2000 codec library Alias: openjpeg https://bugzilla.redhat.com/show_bug.cgi?id=229098 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 03:38 EST --- (In reply to comment #31) @Callum About the snapshoot, it is often recommanded to use a bash script to retrieve the sources (and remove CVS or .svn ), so you can have a method to compare The Guidelines demand a documented way how to create a snapshot tarball: http://fedoraproject.org/wiki/Packaging/SourceURL#head-615f6271efb394ab340a93a6cf030f2d08cf0d49 And a hint for svn: You can use svn export instead of svn co to avoid the creation of .svn directories. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 234753] Review Request: accerciser - An interactive Python accessibility explorer for the GNOME desktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: accerciser - An interactive Python accessibility explorer for the GNOME desktop https://bugzilla.redhat.com/show_bug.cgi?id=234753 [EMAIL PROTECTED] changed: What|Removed |Added Product|Fedora Extras |Fedora [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 03:44 EST --- - You should explain why you disable the debug package in the spec. - GPL is not a valid value for License: anymore: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#head-f21ae23bf2f278444e2c385463cfa74a502396b8 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 245561] Review Request: ht - File editor/viewer/analyzer for executables
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: ht - File editor/viewer/analyzer for executables
https://bugzilla.redhat.com/show_bug.cgi?id=245561
[EMAIL PROTECTED] changed:
What|Removed |Added
AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
Status|NEW |ASSIGNED
Flag||fedora-review?
--- Additional Comments From [EMAIL PROTECTED] 2007-09-08 04:00 EST ---
- version 2.0.10 is now released
- License should be GPLv2 not GPL
- Source0: should be http://download.sourceforge.net/hte/ht-%{version}.tar.bz2
TexLive seems not to obolete tetex-tex4ht
| - BR ruby, don't obsolete tetex-tex4ht
Source: http://people.redhat.com/jnovy/files/texlive/SPECS/texlive.spec
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 271661] Review Request: radeontool - Backlight and video output configuration tool for radeon cards
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: radeontool - Backlight and video output configuration tool for radeon cards Alias: radeontool https://bugzilla.redhat.com/show_bug.cgi?id=271661 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 04:36 EST --- -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 OK: rpmlint is silent OK: package naming OK: spec name OK: zlib license OK: license field matches license OK: spec files English OK: spec is legible OK: source matches upstream: 8065eebe5a2b163e43b40461bfe49a56 radeontool-1.5.tar.gz 8065eebe5a2b163e43b40461bfe49a56 rpmbuild/SOURCES/radeontool-1.5.tar.gz OK: build checked and worked fine on f7/i386 OK: BR are fine OK: no duplicate files OK: file permissions are correct OK: clean section OK: macro usage OK: content is ok OK: %doc does not affect runtime OK: %install section The package 2dad2d98dcb108a82a95b9201f80daf9 radeontool-1.5-2.fc7.src.rpm is hereby approved. -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.7 (GNU/Linux) iD8DBQFG4l5aQEQyPsWM8csRAialAKC8nogyYGA1BRykwi77+OjjZEfJegCeIpmL f1xzDptULMJVaWUPz2vLKBs= =9NQm -END PGP SIGNATURE- It would be nice that before building it you add the '-p' flag to the install argument to preserve the timestamps. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 271861] Review Request: vbetool - Run real-mode video BIOS code to alter hardware state
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: vbetool - Run real-mode video BIOS code to alter hardware state Alias: vbetool https://bugzilla.redhat.com/show_bug.cgi?id=271861 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 04:48 EST --- -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 OK: rpmlint is silent OK: package name OK: spec name OK: package OK: license GPLv2 OK: license field matches license OK: license is included in %doc OK: spec file English OK: spec is legible OK: sources match upstream sources 1756f2e71ceaef217220e8e482fce835 vbetool_0.7-1.tar.gz 1756f2e71ceaef217220e8e482fce835 rpmbuild/SOURCES/vbetool_0.7-1.tar.gz OK: builds fine on f7/i386 OK: exclude arche OK: BR OK: no duplicate files in %files OK: permissions OK: %clean section OK: macros OK: content OK: %doc does not affect runtime OK: %install section The package 0f88a30ed64ab5fcdf399021626f7933 vbetool-0.7-2.fc7.src.rpm is hereby approved. -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.7 (GNU/Linux) iD8DBQFG4mG5QEQyPsWM8csRAlB0AKCFGx7/OhU9jHYFUVS03xdzlBSVvgCcDi6P 5RR/GduSQHVpxbJxZlQjZUc= =/A80 -END PGP SIGNATURE- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 283441] New: Review Request: sdljava - Java binding to the SDL API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=283441 Summary: Review Request: sdljava - Java binding to the SDL API Product: Fedora Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://people.atrpms.net/~hdegoede/sdljava.spec SRPM URL: http://people.atrpms.net/~hdegoede/sdljava-0.9.1-1.fc8.src.rpm Description: sdljava is a Java binding to the SDL API being developed by Ivan Ganza. sdljava provides the ability to write games and other applications from the java programming language. sdljava is designed to be fast, efficient and easy to use. Finally we can start to write games in java without needing to learn yet another slow complicated API. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 271861] Review Request: vbetool - Run real-mode video BIOS code to alter hardware state
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: vbetool - Run real-mode video BIOS code to alter hardware state Alias: vbetool https://bugzilla.redhat.com/show_bug.cgi?id=271861 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 06:01 EST --- New Package CVS Request === Package Name: vbetool Short Description: Run real-mode video BIOS code to alter hardware state Owners: till,pknirsch Branches: F-7 Cvsextras Commits: no If it is possible for you, please also add ajax to watchcommits and commit for devel. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 283441] Review Request: sdljava - Java binding to the SDL API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: sdljava - Java binding to the SDL API https://bugzilla.redhat.com/show_bug.cgi?id=283441 --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 06:00 EST --- I don't think the last sentence of %description (Finally ...) adds any value in the package. On the contrary, actually. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226302] Merge Review: pm-utils
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: pm-utils https://bugzilla.redhat.com/show_bug.cgi?id=226302 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 06:03 EST --- Package Change Request == Package Name: pm-utils Updated Description: Power management utilities and scripts for Fedora -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 271661] Review Request: radeontool - Backlight and video output configuration tool for radeon cards
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: radeontool - Backlight and video output configuration tool for radeon cards Alias: radeontool https://bugzilla.redhat.com/show_bug.cgi?id=271661 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 06:08 EST --- New Package CVS Request === Package Name: radeontool Short Description: Backlight and video output configuration tool for radeon cards Owners: till,pknirsch Branches: F-7 Cvsextras Commits: no If it is possible for you, please also add ajax to watchcommits and commit for devel. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 283441] Review Request: sdljava - Java binding to the SDL API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: sdljava - Java binding to the SDL API https://bugzilla.redhat.com/show_bug.cgi?id=283441 --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 06:18 EST --- (In reply to comment #1) I don't think the last sentence of %description (Finally ...) adds any value in the package. On the contrary, actually. That comes from the packman (suse addon repo) specfile I based my work on and I guess they took it from an upstream description, I agree with you and I'll remove it in the next iteration or before import. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 233070] gnome-web-photo: HTML pages thumbnailer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: gnome-web-photo: HTML pages thumbnailer https://bugzilla.redhat.com/show_bug.cgi?id=233070 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 06:51 EST --- New Package CVS Request === Package Name: gnome-web-photo Short Description: HTML pages thumbnailer Owners: hadess Branches: InitialCC: Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 269941] Review Request: gmyth - MythTV remote access libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gmyth - MythTV remote access libraries https://bugzilla.redhat.com/show_bug.cgi?id=269941 --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 06:53 EST --- (In reply to comment #6) rpmlint output: [EMAIL PROTECTED] Desktop]$ rpmlint /var/lib/mock/fedora-development-i386/result/gmyth-*.rpm gmyth.i386: E: zero-length /usr/share/doc/gmyth-0.4/NEWS gmyth.i386: E: zero-length /usr/share/doc/gmyth-0.4/README should just remove those Done. gmyth-debuginfo.i386: W: spurious-executable-perm /usr/src/debug/gmyth/src/gmyth_monitor_handler.h snip these should probably be fixed Done. (In reply to comment #7) snip license: COPYING is GPL, sources say LGPL - what gives ? should seek upstream clarification It's LGPL, the sources and the project page say LGPL. I filed a bug upstream: http://sourceforge.net/tracker/index.php?func=detailaid=1790620group_id=177106atid=879914 and mentioned it in the package upstream sources: not verified, see above Fixed, thanks Till. http://people.redhat.com/bnocera/gmyth/gmyth.spec http://people.redhat.com/bnocera/gmyth/gmyth-0.4-3.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 283461] New: Review Request: qpxtool - CD/DVD Quality check tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=283461 Summary: Review Request: qpxtool - CD/DVD Quality check tool Product: Fedora Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://tgmweb.at/gadllah/qpxtool.spec SRPM URL: http://tgmweb.at/gadllah/qpxtool-0.6.1-1.fc7.src.rpm Description: QPxTool is the linux way to get full control over your CD/DVD drives. It is the Open Source Solution which intends to give you access to all available Quality Checks (Q-Checks) on written and blank media, that are available for your drive. This will help you to find the right media and the optimized writing speed for your hardware, which will increase the chance for a long data lifetime. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 283471] New: Review Request: umbrello - Unified Modelling Language (UML) diagrams modeller
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=283471 Summary: Review Request: umbrello - Unified Modelling Language (UML) diagrams modeller Product: Fedora Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://people.atrpms.net/~hdegoede/umbrello.spec SRPM URL: http://people.atrpms.net/~hdegoede/umbrello-1.5.71-1.fc8.src.rpm Description: Umbrello UML Modeller is a Unified Modelling Language diagram programm for KDE. UML allows you to create diagrams of software and other systems in a standard format. --- rpmlint says: W: umbrello dangling-relative-symlink /usr/share/doc/HTML/en/umbrello/common ../common The target is in kdelibs (which umbrello requires) W: umbrello devel-file-in-non-devel-package /usr/share/apps/umbrello/headings/heading.h E: umbrello non-executable-script /usr/share/apps/umbrello/headings/heading.rb 0644 E: umbrello non-executable-script /usr/share/apps/umbrello/headings/heading.py 0644 These 3 files are used for the diagram to code convertor, so the rpmlint warnings / errors are bogus in this case. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 281601] Review Request: xsc - A clone of the old vector graphics video game Star Castle
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xsc - A clone of the old vector graphics video game Star Castle https://bugzilla.redhat.com/show_bug.cgi?id=281601 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Flag||fedora-review? --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 08:04 EST --- I'll review this, Jon could you review umbrello in return please? The umbrello review is bug 283471. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 283471] Review Request: umbrello - Unified Modelling Language (UML) diagrams modeller
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: umbrello - Unified Modelling Language (UML) diagrams modeller https://bugzilla.redhat.com/show_bug.cgi?id=283471 --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 08:20 EST --- umbrello is already in kdesdk. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 247984] Review Request: Etoys - Squeak-based learning environment for OLPC
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: Etoys - Squeak-based learning environment for OLPC
https://bugzilla.redhat.com/show_bug.cgi?id=247984
[EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
--- Additional Comments From [EMAIL PROTECTED] 2007-09-08 08:30 EST ---
Another issues:
- provide a full URL in Source0 to get the tarball or include a comment how to
generate the tarball
- do not use /usr but %{_prefix}
- %files needs a defattr line
- use %{_libdir} and %{_datadir} in %files
- is ROOT=%{buildroot} in %build really needed?
- consider using disttag
Please read: http://fedoraproject.org/wiki/Packaging/Guidelines
http://fedoraproject.org/wiki/Packaging/RPMMacros (it's about %{_libdir} and
other macros)
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines (defattr)
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#head-beca3bf84972f19a384cc2e5091ed47c2b3cebc7
(disttag)
http://fedoraproject.org/wiki/Packaging/SourceURL (about the URL in Source0)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 247984] Review Request: Etoys - Squeak-based learning environment for OLPC
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Etoys - Squeak-based learning environment for OLPC https://bugzilla.redhat.com/show_bug.cgi?id=247984 [EMAIL PROTECTED] changed: What|Removed |Added BugsThisDependsOn||177841 --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 08:38 EST --- Bert, you are not yet sponsored according to the Fedora Account System, please read: http://fedoraproject.org/wiki/PackageMaintainers/Join http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored In case that OLPC packge maintainers do not need to be sponsored, please tell me. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 247983] Review Request: squeak-vm - Squeak virtual machine for OLPC
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: squeak-vm - Squeak virtual machine for OLPC https://bugzilla.redhat.com/show_bug.cgi?id=247983 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] OtherBugsDependingO||177841 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 08:37 EST --- Bert, you are not yet sponsored according to the Fedora Account System, please read: http://fedoraproject.org/wiki/PackageMaintainers/Join http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored In case there OLPC contributors do not need to be sponsored, please tell me. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 252125] Review Request: flpsed - WYSIWYG pseudo PostScript editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: flpsed - WYSIWYG pseudo PostScript editor https://bugzilla.redhat.com/show_bug.cgi?id=252125 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 08:43 EST --- Okay. * This package is okay (can be rebuilt, installed, and seem to work well) * Your pre-review looks good (for a brief check) === This package (flpsed) is APPROVED by me === Please follow the procedure according to: http://fedoraproject.org/wiki/PackageMaintainers/Join from Get a Fedora Account. At a point a mail should be sent to sponsor members which notifies that you need a sponsor (at the stage, please also write on this bug for confirmation that you requested for sponsorship) Then I will sponsor you. If you want to import this package into Fedora 7, you also have to look at http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT (after once you rebuilt this package on Fedora rebuilding system). If you have questions, please ask me. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 281601] Review Request: xsc - A clone of the old vector graphics video game Star Castle
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xsc - A clone of the old vector graphics video game Star Castle https://bugzilla.redhat.com/show_bug.cgi?id=281601 --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 08:45 EST --- Fully reviewed. Must Fix: - * Add Requires: hicolor-icon-theme for dir ownership Should Fix: --- * run convert xsc.png -transparent white out.png and then replace xsc.png with out.png to make the icon transparent (much nicer). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 186632] Review Request: svn2cl - Create a ChangeLog from a Subversion log
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: svn2cl - Create a ChangeLog from a Subversion log https://bugzilla.redhat.com/show_bug.cgi?id=186632 [EMAIL PROTECTED] changed: What|Removed |Added QAContact|fedora-extras- |fedora-package- |[EMAIL PROTECTED] |[EMAIL PROTECTED] Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 08:49 EST --- Package Change Request == Package Name: svn2cl New Branches: EL-5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 228159] Review Request: new-stuff-manager - program that runs in the background and downloads/installs plugins
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: new-stuff-manager - program that runs in the background and downloads/installs plugins https://bugzilla.redhat.com/show_bug.cgi?id=228159 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] OtherBugsDependingO||177841 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 08:49 EST --- Sebastian, the Fedora Account System does not know your e-mail address, therefore I assume you are not already a package maintainer in Fedora and therefore need to be sponsored. Please read: http://fedoraproject.org/wiki/PackageMaintainers/Join http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 283471] Review Request: umbrello - Unified Modelling Language (UML) diagrams modeller
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: umbrello - Unified Modelling Language (UML) diagrams modeller https://bugzilla.redhat.com/show_bug.cgi?id=283471 --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 09:00 EST --- (In reply to comment #1) umbrello is already in kdesdk. What? Ah yes that makes perfect sense very logical place for it to be, especially as its in its own subpackage with umbrello in the name, or atleast has a provides umbrello so that yum install umbrello works, oh wait it doesn't have either of those, G. See bug 283521 for me ranting some more about this. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 237422] Review Request: bluedj - An online game centre
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: bluedj - An online game centre https://bugzilla.redhat.com/show_bug.cgi?id=237422 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 09:05 EST --- - You use spaces and tabs in the spec, please only use one of them. It seems to be easier to substitute the tabs with spaces, because there are less tab than space charachters. - When you do not build a -data package, then please remove the comments about it from the spec - Can you maybe provide a patch to create an install target with qmake to simplify the %install section - GPL is not a valid license tag value anymore: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#head-f21ae23bf2f278444e2c385463cfa74a502396b8 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 246387] Review Request: libibcommon - OpenFabrics Alliance InfiniBand management common library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: libibcommon - OpenFabrics Alliance InfiniBand
management common library
https://bugzilla.redhat.com/show_bug.cgi?id=246387
[EMAIL PROTECTED] changed:
What|Removed |Added
AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
Status|NEW |ASSIGNED
Flag||fedora-review?
--- Additional Comments From [EMAIL PROTECTED] 2007-09-08 09:22 EST ---
This is not a valid value for the License Tag:
License: GPL/BSD
See:
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#head-f21ae23bf2f278444e2c385463cfa74a502396b8
This is afaik not needed:
Requires(post): /sbin/ldconfig
Requires(postun): /sbin/ldconfig
Because this already creates the Requires:
%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig
I am not sure, is the -static subpackage useful without the -devel package? If
not, then the -static package should depend on the -devel package and not on the
main package.
%install must begin with rm -rf $RPM_BUILD_ROOT
This
%{_includedir}/infiniband/*.h
should be
%{_includedir}/infiniband/
to include the directory.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 246388] Review Request: libibmad
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libibmad https://bugzilla.redhat.com/show_bug.cgi?id=246388 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Status|NEW |ASSIGNED Flag||fedora-review? --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 09:30 EST --- Same issues as in https://bugzilla.redhat.com/show_bug.cgi?id=246387#c10 (the last issue can be ignored here) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 246390] Review Request: opensm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: opensm https://bugzilla.redhat.com/show_bug.cgi?id=246390 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 09:36 EST --- There is no spec/srpm for this at http://www.xsintricity.com/dledford/Package_Review/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 246388] Review Request: libibmad
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libibmad https://bugzilla.redhat.com/show_bug.cgi?id=246388 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|246389 | nThis|| BugsThisDependsOn||246389 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 246387] Review Request: libibcommon - OpenFabrics Alliance InfiniBand management common library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libibcommon - OpenFabrics Alliance InfiniBand management common library https://bugzilla.redhat.com/show_bug.cgi?id=246387 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||246389 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 246389] Review Request: libibumad
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libibumad https://bugzilla.redhat.com/show_bug.cgi?id=246389 [EMAIL PROTECTED] changed: What|Removed |Added BugsThisDependsOn|246388 |246387 OtherBugsDependingO||246388 nThis|| AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Status|NEW |ASSIGNED Flag||fedora-review? --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 09:34 EST --- Same issues as in https://bugzilla.redhat.com/show_bug.cgi?id=246387#c10 (the last issue can be ignored here) also fixing part of the dependency tree, according to the spec the dependencies are libibcommon - libibumad - libibmad -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 246391] Review Request: infiniband-diags
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: infiniband-diags https://bugzilla.redhat.com/show_bug.cgi?id=246391 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 09:37 EST --- There is no spec or rpm available at http://www.xsintricity.com/dledford/Package_Review/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 246388] Review Request: libibmad
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libibmad https://bugzilla.redhat.com/show_bug.cgi?id=246388 [EMAIL PROTECTED] changed: What|Removed |Added BugsThisDependsOn|246387 | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 246387] Review Request: libibcommon - OpenFabrics Alliance InfiniBand management common library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libibcommon - OpenFabrics Alliance InfiniBand management common library https://bugzilla.redhat.com/show_bug.cgi?id=246387 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|246388 | nThis|| -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 261881] Review Request: écolier-f onts - Ãcolier court fonts
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: écolier-fonts - Écolier court fonts
https://bugzilla.redhat.com/show_bug.cgi?id=261881
[EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
--- Additional Comments From [EMAIL PROTECTED] 2007-09-08 09:53 EST ---
These files should be prefixed with the package name:
Source2: OFL.txt
Source3: OFL-fr.txt
Imho you should add a
Provides: ecolier-fonts = %{version}-%{releae}
to make it easier to install the fonts.
The %changelog entry uses strange characters instead of -.
The License Page uses http://scripts.sil.org/OFL_web as a reference to the OFL
License.
(http://fedoraproject.org/wiki/Licensing#head-19fc3ef10add085a28cb06784dc34ef8b05a9bd6-4)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 283571] New: Review Request: homebank - Free easy personal accounting for all
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=283571 Summary: Review Request: homebank - Free easy personal accounting for all Product: Fedora Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://odysseus.x-tnd.be/fedora/homebank/homebank.spec SRPM URL: http://odysseus.x-tnd.be/fedora/homebank/homebank-3.5-1.fc7.src.rpm Description: HomeBank is the free software you have always wanted to manage your personal accounts at home. The main concept is to be light, simple and very easy to use. It brings you many features that allows you to analyze your finances in a detailed way instantly and dynamically with powerful report tools based on filtering and graphical charts. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 281601] Review Request: xsc - A clone of the old vector graphics video game Star Castle
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xsc - A clone of the old vector graphics video game Star Castle https://bugzilla.redhat.com/show_bug.cgi?id=281601 --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 10:25 EST --- Addressed. I'll get on ubrello very, very, soon. :) Spec URL: http://zanoni.jcomserv.net/fedora/xsc/xsc.spec SRPM URL: http://zanoni.jcomserv.net/fedora/xsc/xsc-1.5-2.fc7.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 252125] Review Request: flpsed - WYSIWYG pseudo PostScript editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: flpsed - WYSIWYG pseudo PostScript editor https://bugzilla.redhat.com/show_bug.cgi?id=252125 --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 10:43 EST --- New Package CVS Request === Package Name: flpsed Short Description: WYSIWYG pseudo PostScript editor Owners: nboyle Branches: FC-6 F-7 InitialCC: Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 281601] Review Request: xsc - A clone of the old vector graphics video game Star Castle
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xsc - A clone of the old vector graphics video game Star Castle https://bugzilla.redhat.com/show_bug.cgi?id=281601 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 10:39 EST --- Approved! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 243501] Review Request: qtiplot-doc - Documentation of qtiplot
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: qtiplot-doc - Documentation of qtiplot
https://bugzilla.redhat.com/show_bug.cgi?id=243501
[EMAIL PROTECTED] changed:
What|Removed |Added
Product|Fedora Extras |Fedora
[EMAIL PROTECTED] changed:
What|Removed |Added
AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
Status|NEW |ASSIGNED
Flag||fedora-review?
--- Additional Comments From [EMAIL PROTECTED] 2007-09-08 10:43 EST ---
License should be GFDL according to
http://fedoraproject.org/wiki/Licensing#head-19fc3ef10add085a28cb06784dc34ef8b05a9bd6-2
and index.html
You use tabs and spaces in the spec, e.g. in Group you align with spaces but in
URL you align with tabs. Please use either tabs or spaces.
I did not try it but I guess you can simplify the spec when you use in %prep
%setup -q -n manual-en
dos2unix qtiplot.adp
and in %files
%doc *
Then you can remove
mkdir -p $RPM_BUILD_ROOT/%{_docdir}/%{name}
tar -xjf %{SOURCE0} -C $RPM_BUILD_ROOT/%{_docdir}/%{name}
dos2unix $RPM_BUILD_ROOT/%{_docdir}/%{name}/manual-en/qtiplot.adp
from %install.
In %files a %defattr(-,root,root,-) before the %doc is missing.
According to http://soft.proindependent.com/manuals.html the documentation is
version 0.8.9
Imho you should skip the %{?dist} tag in Release and ask rel-eng everytime you
built a package to sync it to all Fedora releases, this will also avoid updating
the manual everytime one updrades the system.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 243501] Review Request: qtiplot-doc - Documentation of qtiplot
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: qtiplot-doc - Documentation of qtiplot https://bugzilla.redhat.com/show_bug.cgi?id=243501 --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 10:47 EST --- I forgot: run dos2unix with --keepdate -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 281601] Review Request: xsc - A clone of the old vector graphics video game Star Castle
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xsc - A clone of the old vector graphics video game Star Castle https://bugzilla.redhat.com/show_bug.cgi?id=281601 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 10:54 EST --- Many thanks! New Package CVS Request === Package Name: xsc Short Description: A clone of the old vector graphics video game Star Castle Owners: [EMAIL PROTECTED] Branches: FC-6 F-7 InitialCC: Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 281281] Review Request: netpipe - A network performance measurement tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: netpipe - A network performance measurement tool https://bugzilla.redhat.com/show_bug.cgi?id=281281 --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 12:06 EST --- (In reply to comment #1) Would you please ask upstream to update the license header (and the manpage and README) to a specific GPL Version, Upstream does not have to change the license to version specific. If no specific version is provided, the license is simply GPL+ (GPL any version). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 243501] Review Request: qtiplot-doc - Documentation of qtiplot
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: qtiplot-doc - Documentation of qtiplot https://bugzilla.redhat.com/show_bug.cgi?id=243501 --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 12:24 EST --- The simple setup will not work.:( So I must use complex one. So here the next try.(I have correct the version number of the doc) SRPM: http://downloads.sourceforge.net/qsmartcard/qtiplot-doc-0.8.9-1.fc8.src.rpm?use_mirror=osdn SPEC: http://downloads.sourceforge.net/qsmartcard/qtiplot-doc.spec?use_mirror=osdn -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 251020] Review Request: libflaim - Flaim Database Engine
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: libflaim - Flaim Database Engine
https://bugzilla.redhat.com/show_bug.cgi?id=251020
--- Additional Comments From [EMAIL PROTECTED] 2007-09-08 12:26 EST ---
libflaim.pc contains the line:
Libs: -lpthread -lrt -lstdc++ -ldl -lncurses -lflaim -L${libdir}
-lncurses means that libflaim-devel should have Requires: ncurses-devel.
But make check if -lncurses is really needed. For libflaim.so
the linkage against libncurses.so MUST be done in advance and
-lncurses is usually not needed.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 253910] Review Request: ksirk - Turnbased multiplayer board strategy game (conquer the world!)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ksirk - Turnbased multiplayer board strategy game (conquer the world!) https://bugzilla.redhat.com/show_bug.cgi?id=253910 --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 12:26 EST --- Ok, that makes sense. My mock build revealed a missing BR, gettext. Add that and you're set. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 252125] Review Request: flpsed - WYSIWYG pseudo PostScript editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: flpsed - WYSIWYG pseudo PostScript editor https://bugzilla.redhat.com/show_bug.cgi?id=252125 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|177841 | nThis|| Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 245561] Review Request: ht - File editor/viewer/analyzer for executables
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: ht - File editor/viewer/analyzer for executables
https://bugzilla.redhat.com/show_bug.cgi?id=245561
[EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
--- Additional Comments From [EMAIL PROTECTED] 2007-09-08 12:57 EST ---
I am the tetex-tex4ht maintainer, and indeed using ht as a program
name is not a good idea. tetex-tex4ht in fact contains many
executables, some with trivial names, I'll try to talk to
upstream. In the mean time I don't know exactly what could be
done. In debian tex4ht there are much less programs, but
still ht.
This is also true for ht, upstream should try to find
a more descriptive name. The %{_bindir} namespace has to be shared
among all the applications, more care should be taken.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 253691] Review Request: java-1.7.0-icedtea - IcedTea runtime and development environments
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: java-1.7.0-icedtea - IcedTea runtime and development environments https://bugzilla.redhat.com/show_bug.cgi?id=253691 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 13:03 EST --- Hey, I noticed these were branched for F7, I gave it a whirl and compiled your SRPM for F7 and it seems to work. Are there plans to build this for FC-6/F7? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 261881] Review Request: écolier-c ourt-fonts - Ãcolier court fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: écolier-court-fonts - Écolier court fonts https://bugzilla.redhat.com/show_bug.cgi?id=261881 --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 13:06 EST --- (In reply to comment #9) I also note that the .ttf files are just named ec*.ttf and it is hard for many people in the world to type é without changing xkb layout, installing a input method, or having to cut and paste the letter (like I just did). I've added a provides for accented-less name If you browse the website you'll see the actual project name takes an accent The font filenames are infortunate and could use a refresh -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 261881] Review Request: écolier-c ourt-fonts - Ãcolier court fonts
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: écolier-court-fonts - Écolier court fonts
https://bugzilla.redhat.com/show_bug.cgi?id=261881
[EMAIL PROTECTED] changed:
What|Removed |Added
Summary|Review Request: écolier- |Review Request: écolier-
|fonts - Écolier court fonts|court-fonts - Écolier court
||fonts
--- Additional Comments From [EMAIL PROTECTED] 2007-09-08 13:04 EST ---
(In reply to comment #10)
These files should be prefixed with the package name:
Source2: OFL.txt
This is SIL's filename, won't touch it we do not rename downloadable sources
Source3: OFL-fr.txt
OK
Imho you should add a
Provides: ecolier-fonts = %{version}-%{releae}
to make it easier to install the fonts.
This is a nice idea - done
The %changelog entry uses strange characters instead of -.
Changelog is freeform, changelog parsers need to grok utf-8 to get author names
right, and other fedora packages do it too so I don't see the problem. It made
the infra team laugh the first time
The License Page uses http://scripts.sil.org/OFL_web as a reference to the OFL
License.
And on this page you have a link to the FAQ that includes the download link to
the standalone text version. (with an unfortunate URL - SIL's site sucks a bit)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 253749] Review Request: php-pear-HTML-QuickForm-advmultiselect - Element for HTML_QuickForm that emulate a multi-select
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-pear-HTML-QuickForm-advmultiselect - Element for HTML_QuickForm that emulate a multi-select https://bugzilla.redhat.com/show_bug.cgi?id=253749 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Status|NEW |ASSIGNED Flag||fedora-review? --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 13:37 EST --- will start review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 253910] Review Request: ksirk - Turnbased multiplayer board strategy game (conquer the world!)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ksirk - Turnbased multiplayer board strategy game (conquer the world!) https://bugzilla.redhat.com/show_bug.cgi?id=253910 --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 13:53 EST --- (In reply to comment #3) Ok, that makes sense. My mock build revealed a missing BR, gettext. Add that and you're set. Thanks! Here is a new version with the missing BR added: Spec URL: http://people.atrpms.net/~hdegoede/ksirk.spec SRPM URL: http://people.atrpms.net/~hdegoede/ksirk-1.7-2.fc8.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 261881] Review Request: écolier-c ourt-fonts - Ãcolier court fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: écolier-court-fonts - Écolier court fonts https://bugzilla.redhat.com/show_bug.cgi?id=261881 --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 14:04 EST --- I think using the 'é' in the actual package name is just asking for trouble, and that it would be better to use plain 'e' there and 'é' in the Provides if you insist. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 253910] Review Request: ksirk - Turnbased multiplayer board strategy game (conquer the world!)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ksirk - Turnbased multiplayer board strategy game (conquer the world!) https://bugzilla.redhat.com/show_bug.cgi?id=253910 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 14:20 EST --- Superlative. Approved! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 276961] Review Request: straw - Desktop news aggregator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: straw - Desktop news aggregator https://bugzilla.redhat.com/show_bug.cgi?id=276961 --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 14:50 EST --- I am also a fedora ambassador [http://fedoraproject.org/wiki/SubhodipBiswas] please see here for ambassador list.I represent India /West Bengal/Durgapur [http://fedoraproject.org/wiki/Ambassadors/CountryList#head-593f83e9f2d1329dd3e42c3350d837ace96ad052] -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 253910] Review Request: ksirk - Turnbased multiplayer board strategy game (conquer the world!)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ksirk - Turnbased multiplayer board strategy game (conquer the world!) https://bugzilla.redhat.com/show_bug.cgi?id=253910 --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 15:03 EST --- New Package CVS Request === Package Name: ksirk Short Description: Turnbased multiplayer board strategy game (conquer the world!) Owners:jwrdegoede Branches: F-7 devel InitialCC: empty Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 253910] Review Request: ksirk - Turnbased multiplayer board strategy game (conquer the world!)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ksirk - Turnbased multiplayer board strategy game (conquer the world!) https://bugzilla.redhat.com/show_bug.cgi?id=253910 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 249831] Review Request: gromacs - Molecular dynamics package
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gromacs - Molecular dynamics package
https://bugzilla.redhat.com/show_bug.cgi?id=249831
[EMAIL PROTECTED] changed:
What|Removed |Added
AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
Status|NEW |ASSIGNED
--- Additional Comments From [EMAIL PROTECTED] 2007-09-08 15:14 EST ---
Let's roll...
MUST items:
* rpmlint must be run on every package FAILL
$ rpmlint gromacs-3.3.1-2.fc7.src.rpm
W: gromacs invalid-license GPL
$ rpmlint gromacs-3.3.1-2.fc7.x86_64.rpm
E: gromacs script-without-shebang /usr/bin/GMXRC.csh
E: gromacs script-without-shebang /usr/bin/GMXRC.bash
E: gromacs script-without-shebang /usr/bin/GMXRC
E: gromacs script-without-shebang /usr/bin/completion.bash
E: gromacs script-without-shebang /usr/bin/completion.csh
E: gromacs script-without-shebang /usr/bin/GMXRC.zsh
E: gromacs script-without-shebang /usr/bin/completion.zsh
W: gromacs invalid-license GPL
$ rpmlint gromacs-debuginfo-3.3.1-2.fc7.x86_64.rpm
W: gromacs-debuginfo invalid-license GPL
$ rpmlint gromacs-devel-3.3.1-2.fc7.x86_64.rpm
W: gromacs-devel no-documentation
W: gromacs-devel invalid-license GPL
$ rpmlint gromacs-mpi-3.3.1-2.fc7.x86_64.rpm
W: gromacs-mpi no-documentation
W: gromacs-mpi invalid-license GPL
$ rpmlint gromacs-mpi-devel-3.3.1-2.fc7.x86_64.rpm
W: gromacs-mpi-devel no-documentation
W: gromacs-mpi-devel invalid-license GPL
E: gromacs-mpi-devel no-ldconfig-symlink /usr/lib64/libgmxana_mpi.so
E: gromacs-mpi-devel no-ldconfig-symlink /usr/lib64/libmd_mpi.so
E: gromacs-mpi-devel no-ldconfig-symlink /usr/lib64/libgmx_mpi.so
There are several problems here. First, GPL is no a valid tag anymore, please
read http://fedoraproject.org/wiki/Packaging/LicensingGuidelines to find your
appropriated license tag.
Files like /usr/bin/GMXRC.csh seems to me initialization scripts. A better place
for them is perhaps /etc/profile.d
completion.* is too generic. Could you rename to something like
gromacs-completion.* or something like that?
And /usr/lib64/libmd_mpi.so and the others are binary files instead of symlinks.
Try using cp -a instead of cp -p
* The package must be named according to the Package Naming Guidelines. OK
* The spec file name must match the base package %{name}... OK
* The package must meet the Packaging Guidelines OK
* The package must be licensed with a Fedora approved license... FAIL (See
above)
* The License field in the package spec file must match the actual license.
SKIPPED
First fix previous point
* Include license if the license text is included OK
* The spec file must be written in American English OK
* The spec file for the package MUST be legible FAIL
Please add some comments on the specfile detailing the compilation with/without
MPI enabled. In the description of the mpi packages it would be polite to
explain the acronym to those who might come across the package. Something like
Build of the GROMACS package with MPI (Message Passing Interface) enabled.
* The sources used to build the package must match the upstream source FAIL
The url of the source doesn't exit, please fix the SOURCE tag in the specfile
* The package must successfully compile and build into binary rpms OK
* All build dependencies must be listed in BuildRequires OK
* The spec file must handle locales properly. OK (no locales)
* Package with shared library files must call ldconfig in %post and %postun OK
* If the package is designed to be relocatable... OK (not relocatable)
* A package must own all directories that it creates OK
* A package must not contain any duplicate files in the %files listing. OK
* Permissions on files must be set properly. OK
* Each package must have a %clean section OK
* Each package must consistently use macros OK
* The package must contain code, or permissible content OK
* Large documentation files should go in a -doc subpackage. OK
The html files are only 1.9 M
* Files in %doc do not affect the runtime of the application. OK
The bulk of your docs is in /usr/share/gromacs/html. Is there any reason
to put the files here and not in /usr/share/doc (marking the files in html as
%doc)?
* Header files in -devel OK
* Static libraries must be in a -static OK
(no static libs)
* Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' OK
(no pkconfig)
* Library files that end in .so (if a link to sufixed lib) must go in a -devel
package. OK
* Devel packages must require the base package using a fully versioned
dependency OK
* Packages must NOT contain any .la libtool archives OK
* Packages containing GUI applications must include a %{name}.desktop file FAIL
Your package contains GUI applications (e.g highway). If you feel that your
packaged GUI application does not need a
[Bug 249831] Review Request: gromacs - Molecular dynamics package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gromacs - Molecular dynamics package https://bugzilla.redhat.com/show_bug.cgi?id=249831 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 281601] Review Request: xsc - A clone of the old vector graphics video game Star Castle
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xsc - A clone of the old vector graphics video game Star Castle https://bugzilla.redhat.com/show_bug.cgi?id=281601 --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 15:32 EST --- Whoops: New Package CVS Request === Package Name: xsc Short Description: A clone of the old vector graphics video game Star Castle Owners: limb Branches: FC-6 F-7 InitialCC: Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 283701] New: Review Request: vecmath1.2 - Free version of vecmath from the Java3D 1.2 specification
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=283701 Summary: Review Request: vecmath1.2 - Free version of vecmath from the Java3D 1.2 specification Product: Fedora Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://people.atrpms.net/~hdegoede/vecmath1.2.spec SRPM URL: http://people.atrpms.net/~hdegoede/vecmath1.2-1.14-1.fc8.src.rpm Description: This is an unofficial implementation (java source code) of the javax.vecmath package specified in the Java(TM) 3D API 1.2 . The package includes classes for 3-space vector/point, 4-space vector, 4x4, 3x3 matrix, quaternion, axis-angle combination and etc. which are often utilized for computer graphics mathematics. Most of the classes have single and double precision versions. Generic matrices' LU and SV decomposition are also there. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 283711] New: Review Request: bolzplatz2006-data - Datafiles for bolzplatz2006
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=283711 Summary: Review Request: bolzplatz2006-data - Datafiles for bolzplatz2006 Product: Fedora Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://people.atrpms.net/~hdegoede/bolzplatz2006-data.spec SRPM URL: http://people.atrpms.net/~hdegoede/bolzplatz2006-data-1.0.3-1.fc8.src.rpm Description: Datafiles for bolzplatz2006. --- Note these files as is are licensed CC By-Nc-Sa, IOW they are not acceptable for inclusion into Fedora. I've contacted upstream and the project lead is willing to drop the Nc clause. He is currently contacting the other (data creating) project members to ask there permission for the license change. He expects this to be no problem, but this takes a bit of time. I'm already submitting this as its needed for bolzplatz2006 itself (which is GPLv2+), and that is going to be a long review I think. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 283721] New: Review Request: bolzplatz2006 - Slam Soccer 2006 is a funny football game in 3D-comic-style
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=283721 Summary: Review Request: bolzplatz2006 - Slam Soccer 2006 is a funny football game in 3D-comic-style Product: Fedora Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://people.atrpms.net/~hdegoede/bolzplatz2006.spec SRPM URL: http://people.atrpms.net/~hdegoede/bolzplatz2006-1.0.3-1.fc8.src.rpm Description: Slam Soccer 2006 is a funny football game in 3D-comic-style - and it's for free! * Freeware and open source * Funny 3d-comic-style * Enthralling stadium atmosphere * Keyboard and gamepad control * 2-player mode * Career and world cup * Register in the online hall of fame * Build your own stadium * 80 teams * 20 stadiums * 10 weather conditions * 50 adboards * 10 referees * 9 commentators (5 German, 2 English, 2 French) * 3 languages: German, English, French --- Notice this packages only works with icedtea, and thus only works on devel/rawhide ! It needs the following packages which are still under review: sdljava - bug 283441 vecmath - bug 283701 bolzplatz2006-data - bug 283711 --- Note the datafiles as is are licensed CC By-Nc-Sa, IOW they are not acceptable for inclusion into Fedora as is. I've contacted upstream and the project lead is willing to drop the Nc clause. He is currently contacting the other (data creating) project members to ask there permission for the license change. He expects this to be no problem, but this takes a bit of time. I'm already submitting bolzplatz2006 itself (which is GPLv2+) as this might be a long review I think (it took me almost a week to package it). And in order to be able to test bolzplatz itself I've also made the datafiles package available already, see bug 283711. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 283711] Review Request: bolzplatz2006-data - Datafiles for bolzplatz2006
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: bolzplatz2006-data - Datafiles for bolzplatz2006 https://bugzilla.redhat.com/show_bug.cgi?id=283711 --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 16:22 EST --- Note bolzplatz2006's review is bug 283721. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 261881] Review Request: écolier-c ourt-fonts - Ãcolier court fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: écolier-court-fonts - Écolier court fonts https://bugzilla.redhat.com/show_bug.cgi?id=261881 --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 17:31 EST --- (In reply to comment #13) I think using the 'é' in the actual package name is just asking for trouble, 1. It is somewhat asking for trouble but our infrastructure needs to get utf-8 proof and I'd rather it was done with a small package like this than in an urgent way when a bigger package lands. There is really an astonishing few problems revealed by this package, and it's a pity to stop just this close to full support 2. your know how we French are, we care about our language Anyway here's the updated srpm http://nim.fedorapeople.org/%c3%a9colier-court-fonts-1.00-0.2.20070628.fc8.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 261881] Review Request: écolier-c ourt-fonts - Ãcolier court fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: écolier-court-fonts - Écolier court fonts https://bugzilla.redhat.com/show_bug.cgi?id=261881 --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 17:48 EST --- (In reply to comment #11) The %changelog entry uses strange characters instead of -. Changelog is freeform, changelog parsers need to grok utf-8 to get author names right, and other fedora packages do it too so I don't see the problem. It made the infra team laugh the first time The Guidelines demand the -: http://fedoraproject.org/wiki/Packaging/Guidelines#head-b7d622f4bb245300199c6a33128acce5fb453213 | You must use one of the following formats: I do not know enough about rpm to decide, whether your format will cause trouble or not. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 283471] Review Request: umbrello - Unified Modelling Language (UML) diagrams modeller
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: umbrello - Unified Modelling Language (UML) diagrams modeller https://bugzilla.redhat.com/show_bug.cgi?id=283471 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |CLOSED Resolution||DUPLICATE --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 18:43 EST --- *** This bug has been marked as a duplicate of 283521 *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 241553] Review Request: safekeep - simple, centralized configuration for rdiff-backup
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: safekeep - simple, centralized configuration for rdiff-backup https://bugzilla.redhat.com/show_bug.cgi?id=241553 --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 19:19 EST --- Okay, updated urls for the spec and srpm being submitted for review. Essentially the same as Dimi's upstream spec from comment 15. Spec: http://jspaleta.thecodergeek.com/Fedora%20SRPMS/safekeep/1.0.2-1/safekeep.spec SRPM: http://jspaleta.thecodergeek.com/Fedora%20SRPMS/safekeep/1.0.2-1/safekeep-1.0.2-1.fc7.src.rpm F-7 noarch RPMS: http://jspaleta.thecodergeek.com/Fedora%20SRPMS/safekeep/1.0.2-1/F7/ All remaining rpmlint errors are the result of using the /var/lib/safekeep directory as the home directory for the safekeep user and including a .ssh sub-directory for ssh keys. As previously discussed in earlier comments, these errors are erroneous for this atypical but appropriate usage of /var/lib/safekeep as a home directory. The client package is still essentially a metapackage due to the difference in the server and client dependency chain. Though as upstream has mentioned, there are plans to add additional client package payload so keeping it as a separate sub-package package now keeps from having to complicate things later as more client-side development is added. -jef -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 283461] Review Request: qpxtool - CD/DVD Quality check tool
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: qpxtool - CD/DVD Quality check tool
https://bugzilla.redhat.com/show_bug.cgi?id=283461
[EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
Summary|Review Request: qpxtool - |Review Request: qpxtool -
|CD/DVD Quality check tool |CD/DVD Quality check tool
--- Additional Comments From [EMAIL PROTECTED] 2007-09-08 19:27 EST ---
Use:
Source0: http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.bz2
See:
http://fedoraproject.org/wiki/Packaging/SourceURL#head-e27982f18a3bfd26b5b6ecbee113d2d8f3f006f2
for -devel subpackge:
Requires: %{name} = %{version}
should be
Requires: %{name} = %{version}-%{release}
%files devel is missing a %defattr(-,root,root,-)
the cp invocations should be used with -p to preserve the timestamp.
The Makefile also defines INCDIR (%{_includedir}), which you do not adjust with
sed.
the manpage is not installed with a preserved timestamp, missing -p in the
install invocation in man/Makefile (line 10), maybe upstream would change this.
In case you did not know:
you should be able to use make install PREFIX=%{_prefix} LIBDIR=%{_libdir} ...
instead of the sed magic.
Also you can use all sed expressions at once:
sed -i -e 's!/usr/local!%{_prefix}!g' \
-e 's!\$(PREFIX)/bin!%{_sbindir}!g' \
-e 's!\$(PREFIX)/lib!%{_libdir}!g' \
-e 's!\$(PREFIX)/man!%{_mandir}!g' Makefile
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 282261] Review Request: isync - Tool to synchronize IMAP4 and Maildir mailboxes
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: isync - Tool to synchronize IMAP4 and Maildir mailboxes
Alias: isync-review
https://bugzilla.redhat.com/show_bug.cgi?id=282261
[EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
--- Additional Comments From [EMAIL PROTECTED] 2007-09-08 19:37 EST ---
Please use:
Source0: http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz
See:
http://fedoraproject.org/wiki/Packaging/SourceURL#head-e27982f18a3bfd26b5b6ecbee113d2d8f3f006f2
Unuseful comments should be removed:
#Requires:
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226800] Review Request: emacs-bbdb - email database for Emacs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: emacs-bbdb - email database for Emacs https://bugzilla.redhat.com/show_bug.cgi?id=226800 --- Additional Comments From [EMAIL PROTECTED] 2007-09-08 20:08 EST --- spec file: http://jgu.fedorapeople.org/emacs-bbdb.spec SRPM: http://jgu.fedorapeople.org/emacs-bbdb-2.35-6.fc7.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226800] Review Request: emacs-bbdb - email database for Emacs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: emacs-bbdb - email database for Emacs https://bugzilla.redhat.com/show_bug.cgi?id=226800 --- Additional Comments From [EMAIL PROTECTED] 2007-09-09 01:21 EST --- Hi. Sorry I've been ignoring this once again :( I think it would be fine for Jonathan to be the primary packager. I looked at the newest spec file and I read through the Emacs packaging draft. Looking good! Going back to the bbdb-autoloads.el question -- I think the reason that this is in site-start.d is so that the autoloads will be evaluated at Emacs startup (see site-lisp/site-start.el). This means that the user doesn't have to add an explicit require or anything to their .emacs to start using BBDB. I was wrong about this back in comment #10. (FWIW this is mentioned in the packaging guidelines.) In my copy of the latest RPM, bbdb-autoloads.el ends up in site-lisp/bbdb/. So, I think it should be moved again. BTW ... BBDB and VM requiring each other seems pretty ugly! Perhaps one or the other could be fixed upstream. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
