Re: [FFmpeg-devel] [PATCH] configure: Check linking against CoreGraphics or, ApplicationServices framework for avfoundation input device.

2015-02-04 Thread Michael Niedermayer
On Wed, Feb 04, 2015 at 01:53:20PM +0100, Thilo Borgmann wrote: Am 04.02.15 um 13:48 schrieb Thilo Borgmann: [PATCH] configure: Check linking against CoreGraphics or ApplicationServices framework for avfoundation input device. Fixes ticket #4238. Updated patch without blank line.

Re: [FFmpeg-devel] [PATCH] avcodec/alsdec: use init_get_bits8()

2015-02-04 Thread Thilo Borgmann
Am 04.02.15 um 14:45 schrieb Paul B Mahol: Signed-off-by: Paul B Mahol one...@gmail.com --- libavcodec/alsdec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) ok -Thilo ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] Revert Autodetect libxcb.

2015-02-04 Thread Clément Bœsch
On Wed, Feb 04, 2015 at 09:11:34PM +0100, Clément Bœsch wrote: This reverts commit 23ec8db8a07467a1fbef0c79f16b33040ca63c24. There is no reason to enable libxcb by default. This is inconsistent with all the other libs (we don't do it for x11, opengl, ...) and drag many unwanted dependencies

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: De-compensate aspect ratio compensation of DVD-like content.

2015-02-04 Thread Timo Rothenpieler
Could I get a proper review on this? I'd like to believe that we have a consensus that, independent of whether we think there's merit in this compensation logic, it shouldn't exist in a single encoder, out of step with all the other encoders in ffmpeg. Thanks, It looks good to merge for

[FFmpeg-devel] [PATCH] Revert Autodetect libxcb.

2015-02-04 Thread Clément Bœsch
This reverts commit 23ec8db8a07467a1fbef0c79f16b33040ca63c24. There is no reason to enable libxcb by default. This is inconsistent with all the other libs (we don't do it for x11, opengl, ...) and drag many unwanted dependencies by default. We'll get cursed by packagers pretty soon because of

Re: [FFmpeg-devel] [PATCH 5/6] x86/hevcdsp: add ff_hevc_sao_edge_filter_8_{ssse3, avx2}

2015-02-04 Thread Mickaël Raulet
LGTM Mickael 2015-02-04 13:39 GMT+01:00 Christophe Gisquet christophe.gisq...@gmail.com : Hi, 2015-02-04 4:55 GMT+01:00 James Almer jamr...@gmail.com: Original x86 intrinsics code and initial yasm port by Pierre-Edouard Lepere. Refactoring and optimizations by James Almer. Add your

Re: [FFmpeg-devel] [PATCH 6/6] x86/hevcdsp: add ff_hevc_sao_edge_filter_{10, 12}_{sse2, avx2}

2015-02-04 Thread Mickaël Raulet
LGTM. Mickael 2015-02-04 13:51 GMT+01:00 Christophe Gisquet christophe.gisq...@gmail.com : Hi, 2015-02-04 4:55 GMT+01:00 James Almer jamr...@gmail.com: -DECLARE_ALIGNED(16, const xmm_reg, ff_pw_1)= { 0x0001000100010001ULL, 0x0001000100010001ULL }; -DECLARE_ALIGNED(16, const

Re: [FFmpeg-devel] [PATCH 5/6] x86/hevcdsp: add ff_hevc_sao_edge_filter_8_{ssse3, avx2}

2015-02-04 Thread James Almer
On 04/02/15 9:39 AM, Christophe Gisquet wrote: Are the first number for each case from before you split out the restore part? Otherwise, that's gruesome. The benchmarks were done with every patch up to this one applied, so yes, after the split. The file i used to bench went from ~36fps to

Re: [FFmpeg-devel] [PATCH 5/6] x86/hevcdsp: add ff_hevc_sao_edge_filter_8_{ssse3, avx2}

2015-02-04 Thread Christophe Gisquet
Hi, 2015-02-04 21:14 GMT+01:00 James Almer jamr...@gmail.com: On 04/02/15 9:39 AM, Christophe Gisquet wrote: Are the first number for each case from before you split out the restore part? Otherwise, that's gruesome. The benchmarks were done with every patch up to this one applied, so yes,

Re: [FFmpeg-devel] [PATCH 1/6] hevcdsp: separated sao edge filter and pixel restore funcs

2015-02-04 Thread James Almer
On 04/02/15 4:21 AM, Mickaël Raulet wrote: Ok too. 2015-02-04 8:09 GMT+01:00 Christophe Gisquet christophe.gisq...@gmail.com: Hi, 2015-02-04 6:13 GMT+01:00 Michael Niedermayer michae...@gmx.at: On Wed, Feb 04, 2015 at 12:55:48AM -0300, James Almer wrote: From: Seppo Tomperi

Re: [FFmpeg-devel] [PATCH] Revert Autodetect libxcb.

2015-02-04 Thread Clément Bœsch
On Wed, Feb 04, 2015 at 09:30:15PM +, Carl Eugen Hoyos wrote: Clément Bœsch u at pkh.me writes: drag many unwanted dependencies by default. The only additional dependency I see here is libxcb itself: I cannot remove this library from my system (my package manager then

Re: [FFmpeg-devel] [PATCH 4/6] hevcdsp: replace the SAOParams struct parameter from sao_edge_filter

2015-02-04 Thread James Almer
On 04/02/15 4:23 AM, Mickaël Raulet wrote: lgtm. Mickael Applied. Thanks. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Revert Autodetect libxcb.

2015-02-04 Thread Clément Bœsch
On Wed, Feb 04, 2015 at 08:51:00PM +, Carl Eugen Hoyos wrote: Clément Bœsch u at pkh.me writes: This reverts commit 23ec8db8a07467a1fbef0c79f16b33040ca63c24. There is no reason to enable libxcb by default. This is inconsistent with all the other libs (we don't do it for x11,

[FFmpeg-devel] [PATCH]Check mlv streams more completely

2015-02-04 Thread Carl Eugen Hoyos
Hi! Attached patch fixes the crash from ticket #4296 for me. Please review, Carl Eugen diff --git a/libavformat/mlvdec.c b/libavformat/mlvdec.c index d0c51ae..9d821bb 100644 --- a/libavformat/mlvdec.c +++ b/libavformat/mlvdec.c @@ -242,6 +242,7 @@ static int read_header(AVFormatContext *avctx)

Re: [FFmpeg-devel] [PATCH] Revert Autodetect libxcb.

2015-02-04 Thread Carl Eugen Hoyos
Clément Bœsch u at pkh.me writes: drag many unwanted dependencies by default. The only additional dependency I see here is libxcb itself: I cannot remove this library from my system (my package manager then wants to remove another 450 packets) - does it work for you? It's

Re: [FFmpeg-devel] [PATCH 2/2] new option for drawtext (boxborderw = set box border width)

2015-02-04 Thread Clément Bœsch
On Tue, Feb 03, 2015 at 09:01:30AM -0800, Liviu Oniciuc wrote: at this time the drawtext box extends only for the width and height of the text. for a better visual appearance a new option was added (boxboderw) to set how much the box should extend outside of the boxborderw text area

Re: [FFmpeg-devel] [PATCH] dxva2_hevc: properly fill the scaling list structure

2015-02-04 Thread Michael Niedermayer
On Tue, Feb 03, 2015 at 10:41:19PM +0100, Hendrik Leppkes wrote: The scaling list can be specified in either the SPS or PPS. Additionally, compensate for the diagonal scan permutation applied in the decoder. --- libavcodec/dxva2_hevc.c | 22 ++ 1 file changed, 14

Re: [FFmpeg-devel] [PATCH] avcodec/hevc: reduce memory used by the SAO

2015-02-04 Thread Christophe Gisquet
Hi, 2015-02-04 2:05 GMT+01:00 Michael Niedermayer michae...@gmx.at: applied the cherry picked code and the update James mentioned this issue: http://fate.ffmpeg.org/report.cgi?time=20150205015545slot=x86_64-archlinux-gcc-valgrindundef This looks like a missing free: ==15442==at 0x4C2C526:

[FFmpeg-devel] [PATCH] lavf/avc: add buffer padding to extradata allocation

2015-02-04 Thread Lukasz Marek
ff_avc_write_annexb_extradata() allocates extradata, but don't add FF_INPUT_BUFFER_PADDING_SIZE value Signed-off-by: Lukasz Marek lukasz.m.lu...@gmail.com --- libavformat/avc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/avc.c b/libavformat/avc.c index

[FFmpeg-devel] [PATCH]Read CbYCr dpx files

2015-02-04 Thread Carl Eugen Hoyos
Hi! Attached patch implements reading uyvy, yuv444 and yuva444 dpx files. yuva444 is untested. Please comment, Carl Eugen diff --git a/libavcodec/dpx.c b/libavcodec/dpx.c index 3b78486..8eb0d22 100644 --- a/libavcodec/dpx.c +++ b/libavcodec/dpx.c @@ -173,9 +173,14 @@ static int

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: De-compensate aspect ratio compensation of DVD-like content.

2015-02-04 Thread Michael Niedermayer
On Wed, Feb 04, 2015 at 09:13:57PM +0100, Timo Rothenpieler wrote: Could I get a proper review on this? I'd like to believe that we have a consensus that, independent of whether we think there's merit in this compensation logic, it shouldn't exist in a single encoder, out of step with all

Re: [FFmpeg-devel] [PATCH] lavf/avc: add buffer padding to extradata allocation

2015-02-04 Thread Michael Niedermayer
On Thu, Feb 05, 2015 at 01:06:33AM +0100, Lukasz Marek wrote: ff_avc_write_annexb_extradata() allocates extradata, but don't add FF_INPUT_BUFFER_PADDING_SIZE value Signed-off-by: Lukasz Marek lukasz.m.lu...@gmail.com --- libavformat/avc.c | 2 +- 1 file changed, 1 insertion(+), 1

[FFmpeg-devel] [PATCH] configure: Check linking against CoreGraphics or, ApplicationServices framework for avfoundation input device.

2015-02-04 Thread Thilo Borgmann
Hi, fixes Ticket #4238. Testing for CGImageGetTypeID function is questionable (see trac discussion). If someone has a better idea, please let me know. -Thilo From be77bd85b61a922b442235ef7a0c494137672890 Mon Sep 17 00:00:00 2001 From: Thilo Borgmann thilo.borgm...@mail.de Date: Wed, 4 Feb 2015

Re: [FFmpeg-devel] [PATCH 5/6] x86/hevcdsp: add ff_hevc_sao_edge_filter_8_{ssse3, avx2}

2015-02-04 Thread Christophe Gisquet
Hi, 2015-02-04 4:55 GMT+01:00 James Almer jamr...@gmail.com: Original x86 intrinsics code and initial yasm port by Pierre-Edouard Lepere. Refactoring and optimizations by James Almer. Add your own copyright to this file then. Width 32 158583 decicycles in edge, sao_edge_filter_8 runs, 0

Re: [FFmpeg-devel] [PATCH] configure: Check linking against CoreGraphics or, ApplicationServices framework for avfoundation input device.

2015-02-04 Thread Thilo Borgmann
Am 04.02.15 um 13:48 schrieb Thilo Borgmann: [PATCH] configure: Check linking against CoreGraphics or ApplicationServices framework for avfoundation input device. Fixes ticket #4238. Updated patch without blank line. -Thilo From 921f571d601fe51d21ec29320a157dc4e0ba72ed Mon Sep 17 00:00:00

Re: [FFmpeg-devel] [PATCH 6/6] x86/hevcdsp: add ff_hevc_sao_edge_filter_{10, 12}_{sse2, avx2}

2015-02-04 Thread Christophe Gisquet
Hi, 2015-02-04 4:55 GMT+01:00 James Almer jamr...@gmail.com: -DECLARE_ALIGNED(16, const xmm_reg, ff_pw_1)= { 0x0001000100010001ULL, 0x0001000100010001ULL }; -DECLARE_ALIGNED(16, const xmm_reg, ff_pw_2)= { 0x0002000200020002ULL, 0x0002000200020002ULL }; +DECLARE_ALIGNED(32, const

Re: [FFmpeg-devel] [PATCH 3/3] update docs: remove the non-negative number requirement for start_number

2015-02-04 Thread Stefano Sabatini
On date Tuesday 2015-02-03 11:26:13 -0800, Liviu Oniciuc encoded: --- doc/muxers.texi | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index b0bed7e..a8225fc 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -381,8 +381,7 @@

Re: [FFmpeg-devel] Adding Force Style option in Subtitles Filter

2015-02-04 Thread Stefano Sabatini
On date Wednesday 2015-02-04 01:30:09 +0530, Eejya Singh encoded: Hi, I've implemented a force_style option in the subtitles filter. Kindly find the patch attached. -- Eejya Singh, 3rd year undergraduate, Computer Science, BITS Pilani Goa Campus From

[FFmpeg-devel] [PATCH] avcodec/alsdec: use init_get_bits8()

2015-02-04 Thread Paul B Mahol
Signed-off-by: Paul B Mahol one...@gmail.com --- libavcodec/alsdec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/alsdec.c b/libavcodec/alsdec.c index cfece44..b3d3086 100644 --- a/libavcodec/alsdec.c +++ b/libavcodec/alsdec.c @@ -1478,7 +1478,8 @@ static int

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mpc8: fix broken pointer math

2015-02-04 Thread Michael Niedermayer
On Wed, Feb 04, 2015 at 01:18:54PM +0100, wm4 wrote: On Wed, 4 Feb 2015 01:00:06 +0100 Michael Niedermayer michae...@gmx.at wrote: On Tue, Feb 03, 2015 at 09:44:13PM +0100, Reimar Döffinger wrote: On Tue, Feb 03, 2015 at 07:04:11PM +0100, wm4 wrote: This could overflow and crash at

Re: [FFmpeg-devel] [PATCH 1/7] ffprobe: Change string_validation to int, its accessed via AVOption as int

2015-02-04 Thread Michael Niedermayer
On Wed, Feb 04, 2015 at 12:34:53PM +0100, Stefano Sabatini wrote: On date Monday 2015-02-02 23:22:09 +0100, Michael Niedermayer encoded: Signed-off-by: Michael Niedermayer michae...@gmx.at --- ffprobe.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ffprobe.c

Re: [FFmpeg-devel] [PATCH 1/7] ffprobe: Change string_validation to int, its accessed via AVOption as int

2015-02-04 Thread Michael Niedermayer
On Wed, Feb 04, 2015 at 03:23:59PM +0100, Michael Niedermayer wrote: On Wed, Feb 04, 2015 at 12:34:53PM +0100, Stefano Sabatini wrote: On date Monday 2015-02-02 23:22:09 +0100, Michael Niedermayer encoded: Signed-off-by: Michael Niedermayer michae...@gmx.at --- ffprobe.c |2 +-

[FFmpeg-devel] [PATCH] tests: add spp test

2015-02-04 Thread Stefano Sabatini
This requires the new sample file matrixbench_mpeg2.lq1.mpg. --- tests/fate/filter-video.mak | 3 +++ tests/ref/fate/filter-spp | 26 ++ 2 files changed, 29 insertions(+) create mode 100644 tests/ref/fate/filter-spp diff --git a/tests/fate/filter-video.mak

[FFmpeg-devel] What is the correct way to read Avid ACLR atom?

2015-02-04 Thread Kevin Wheatley
Hi, I've been looking at what the appropriate place and method to read in the ACLR atom placed in the Avid codecs so that we can automatically set the color_range. From my reading of the code the mov.c code the parse table shunts the reading of the atom to mov_read_avid(), which in turn calls

Re: [FFmpeg-devel] [PATCH 1/7] ffprobe: Change string_validation to int, its accessed via AVOption as int

2015-02-04 Thread Stefano Sabatini
On date Monday 2015-02-02 23:22:09 +0100, Michael Niedermayer encoded: Signed-off-by: Michael Niedermayer michae...@gmx.at --- ffprobe.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ffprobe.c b/ffprobe.c index d352bb6b..30f9cba 100644 --- a/ffprobe.c +++

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mpc8: fix broken pointer math

2015-02-04 Thread wm4
On Wed, 4 Feb 2015 01:00:06 +0100 Michael Niedermayer michae...@gmx.at wrote: On Tue, Feb 03, 2015 at 09:44:13PM +0100, Reimar Döffinger wrote: On Tue, Feb 03, 2015 at 07:04:11PM +0100, wm4 wrote: This could overflow and crash at least on 32 bit systems. --- libavformat/mpc8.c | 2 +-

Re: [FFmpeg-devel] [PATCH] tests: add spp test

2015-02-04 Thread Michael Niedermayer
On Wed, Feb 04, 2015 at 12:26:15PM +0100, Stefano Sabatini wrote: This requires the new sample file matrixbench_mpeg2.lq1.mpg. --- tests/fate/filter-video.mak | 3 +++ tests/ref/fate/filter-spp | 26 ++ 2 files changed, 29 insertions(+) create mode 100644

Re: [FFmpeg-devel] [PATCH] tests: add spp test

2015-02-04 Thread Michael Niedermayer
On Wed, Feb 04, 2015 at 12:52:05PM +0100, Stefano Sabatini wrote: On date Wednesday 2015-02-04 12:26:15 +0100, Stefano Sabatini encoded: This requires the new sample file matrixbench_mpeg2.lq1.mpg. --- tests/fate/filter-video.mak | 3 +++ tests/ref/fate/filter-spp | 26

Re: [FFmpeg-devel] [PATCH] Revert Autodetect libxcb.

2015-02-04 Thread Lukasz Marek
On 04.02.2015 21:39, Carl Eugen Hoyos wrote: Clément Bœsch u at pkh.me writes: This reverts commit 23ec8db8a07467a1fbef0c79f16b33040ca63c24. There is no reason to enable libxcb by default. This is inconsistent with all the other libs (we don't do it for x11, opengl, ...) x11grab is not lgpl

[FFmpeg-devel] [PATCH 3/3] x86/hevcdsp: add ff_hevc_sao_edge_filter_{10, 12}_{sse2, avx2}

2015-02-04 Thread James Almer
Original x86 intrinsics code by Pierre-Edouard Lepere. Yasm port, refactoring and optimizations by James Almer. Benchmarks of Main_422_10_B_RExt_Sony_1.bin with an Intel Core i5-4200U Width 32 342694 decicycles in sao_edge_filter_10, 16384 runs, 0 skips 29476 decicycles in

[FFmpeg-devel] [PATCH 1/3] hevcdsp: remove compilation-time-fixed parameter from sao_edge_filter

2015-02-04 Thread James Almer
The stride_src parameter is always 2*MAX_PB_SIZE + FF_INPUT_BUFFER_PADDING_SIZE. Signed-off-by: James Almer jamr...@gmail.com --- libavcodec/hevc_filter.c | 5 ++--- libavcodec/hevcdsp.h | 6 +++--- libavcodec/hevcdsp_template.c | 5 ++--- 3 files changed, 7 insertions(+), 9

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: De-compensate aspect ratio compensation of DVD-like content.

2015-02-04 Thread Philip Langdale
On Wed, 04 Feb 2015 21:13:57 +0100 Timo Rothenpieler t...@rothenpieler.org wrote: Could I get a proper review on this? I'd like to believe that we have a consensus that, independent of whether we think there's merit in this compensation logic, it shouldn't exist in a single encoder, out

Re: [FFmpeg-devel] [PATCH] Revert Autodetect libxcb.

2015-02-04 Thread Lou Logan
On Wed, 4 Feb 2015 21:11:34 +0100, Clément Bœsch wrote: This reverts commit 23ec8db8a07467a1fbef0c79f16b33040ca63c24. There is no reason to enable libxcb by default. This is inconsistent with all the other libs (we don't do it for x11, opengl, ...) and drag many unwanted dependencies by