Re: [FFmpeg-devel] [RFC] libavfilter query_format() related functions error handling

2015-03-14 Thread Clément Bœsch
On Sat, Mar 14, 2015 at 03:25:19PM +0100, Michael Niedermayer wrote: On Sat, Mar 14, 2015 at 03:11:28PM +0100, Clément Bœsch wrote: On Sat, Mar 14, 2015 at 01:33:12PM +0100, Nicolas George wrote: Le quartidi 24 ventôse, an CCXXIII, Michael Niedermayer a écrit :

Re: [FFmpeg-devel] [PATCH 2/4] ac3_fixed: fix computation of spx_noise_blend

2015-03-14 Thread Reimar Döffinger
On 14.03.2015, at 12:48, Christophe Gisquet christophe.gisq...@gmail.com wrote: It was set to 1 instead of sqrt(3) --- libavcodec/ac3dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/ac3dec.c b/libavcodec/ac3dec.c index ce45186..ae4129f 100644 ---

Re: [FFmpeg-devel] [PATCH 1/5] lavc: use LOCAL_ALIGNED instead of DECLARE_ALIGNED

2015-03-14 Thread Christophe Gisquet
Hi, 2015-03-14 18:38 GMT+01:00 Michael Niedermayer michae...@gmx.at: static void ff_prores_idct_wrap(int16_t *dst){ -DECLARE_ALIGNED(16, static int16_t, qmat)[64]; +LOCAL_ALIGNED(16, static int16_t, qmat, [64]); int i; this seems to break build ffmpeg/libavcodec/dct-test.c:

Re: [FFmpeg-devel] [PATCH 2/4] libavdevice/avfoundation: add capture_screen_cursor option

2015-03-14 Thread Carl Eugen Hoyos
Matthieu Bouron matthieu.bouron at gmail.com writes: Both code blocks are already contained in the following blocks: #if !TARGET_OS_IPHONE __MAC_OS_X_VERSION_MIN_REQUIRED = 1070 [...] #endif Do you still want the #if !TARGET_OS_IPHONE for consistency ? Not necessarily, sorry for the

Re: [FFmpeg-devel] [PATCH 2/5] x86: lavc: use LOCAL_ALIGNED instead of DECLARE_ALIGNED

2015-03-14 Thread Michael Niedermayer
On Sat, Mar 14, 2015 at 07:58:29PM +0100, Christophe Gisquet wrote: Hi, 2015-03-14 19:07 GMT+01:00 Michael Niedermayer michae...@gmx.at: #define PR_WRAP(INSN) \ static void ff_prores_idct_put_10_##INSN##_wrap(int16_t *dst){ \ -DECLARE_ALIGNED(16, static int16_t, qmat)[64]; \ -

Re: [FFmpeg-devel] [PATCH 1/5] lavc: use LOCAL_ALIGNED instead of DECLARE_ALIGNED

2015-03-14 Thread Reimar Döffinger
On 14.03.2015, at 20:08, Christophe Gisquet christophe.gisq...@gmail.com wrote: 2015-03-14 20:06 GMT+01:00 Michael Niedermayer michae...@gmx.at: So here's an updated patch. yes, but not in the email ;) Crap, I prepared the mail in advance, but forgot to attach the patch after the fate

[FFmpeg-devel] [PATCH] libavformat/mxfenc: write user comment metadata

2015-03-14 Thread Mark Reid
Hi, This patch enables writing of user comment metadata to mxf files. Any metadata key prefixed with comment_ will get written as a user comment. In avid media composer the value will show up in the bin in a column with the name of the key (minus the comment_ prefix ofcourse). The tag values are

Re: [FFmpeg-devel] [PATCH 4/5] ppc: lavc: use LOCAL_ALIGNED instead of DECLARE_ALIGNED

2015-03-14 Thread James Almer
On 14/03/15 10:05 PM, Michael Niedermayer wrote: On Sat, Mar 14, 2015 at 08:35:29PM -0300, James Almer wrote: On 14/03/15 3:18 PM, Michael Niedermayer wrote: On Sat, Mar 14, 2015 at 03:30:27PM +, Christophe Gisquet wrote: The later may yield incorrect code for on-stack variables. ---

Re: [FFmpeg-devel] [PATCH 2/5] x86: lavc: use LOCAL_ALIGNED instead of DECLARE_ALIGNED

2015-03-14 Thread Christophe Gisquet
Hi, 2015-03-14 19:07 GMT+01:00 Michael Niedermayer michae...@gmx.at: #define PR_WRAP(INSN) \ static void ff_prores_idct_put_10_##INSN##_wrap(int16_t *dst){ \ -DECLARE_ALIGNED(16, static int16_t, qmat)[64]; \ -DECLARE_ALIGNED(16, static int16_t, tmp)[64]; \ +LOCAL_ALIGNED(16,

Re: [FFmpeg-devel] [PATCH 1/4] libavdevice/avfoundation: add framerate and video size options

2015-03-14 Thread Carl Eugen Hoyos
Matthieu Bouron matthieu.bouron at gmail.com writes: +for (NSObject *format in You may ignore this but I just changed the code to not mix declarations and statements to silence warnings when compiling with old gcc compilers... I don't have access to an older version of OSX

Re: [FFmpeg-devel] [PATCH] avcodec/ac3dec: Fix undefined shifts

2015-03-14 Thread Michael Niedermayer
On Wed, Mar 11, 2015 at 04:21:26PM +0100, Michael Niedermayer wrote: Found-by: Clang -fsanitize=shift Reported-by: Thierry Foucu tfo...@google.com Signed-off-by: Michael Niedermayer michae...@gmx.at --- libavcodec/ac3dec.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-)

Re: [FFmpeg-devel] [PATCH 1/5] lavc: use LOCAL_ALIGNED instead of DECLARE_ALIGNED

2015-03-14 Thread Christophe Gisquet
2015-03-14 20:06 GMT+01:00 Michael Niedermayer michae...@gmx.at: So here's an updated patch. yes, but not in the email ;) Crap, I prepared the mail in advance, but forgot to attach the patch after the fate run. -- Christophe From 46f45c02767dcba473197c2b633e3de69385f371 Mon Sep 17 00:00:00

Re: [FFmpeg-devel] [PATCH 1/5] lavc: use LOCAL_ALIGNED instead of DECLARE_ALIGNED

2015-03-14 Thread Michael Niedermayer
On Sat, Mar 14, 2015 at 07:57:19PM +0100, Christophe Gisquet wrote: Hi, 2015-03-14 18:38 GMT+01:00 Michael Niedermayer michae...@gmx.at: static void ff_prores_idct_wrap(int16_t *dst){ -DECLARE_ALIGNED(16, static int16_t, qmat)[64]; +LOCAL_ALIGNED(16, static int16_t, qmat, [64]);

Re: [FFmpeg-devel] [PATCH 4/5] ppc: lavc: use LOCAL_ALIGNED instead of DECLARE_ALIGNED

2015-03-14 Thread Michael Niedermayer
On Sat, Mar 14, 2015 at 08:35:29PM -0300, James Almer wrote: On 14/03/15 3:18 PM, Michael Niedermayer wrote: On Sat, Mar 14, 2015 at 03:30:27PM +, Christophe Gisquet wrote: The later may yield incorrect code for on-stack variables. --- libavcodec/ppc/h264dsp.c| 10 -

[FFmpeg-devel] [PATCH] avformat/mov: Disallow .. in dref unless use_absolute_path is set

2015-03-14 Thread Michael Niedermayer
as this kind of allows to circumvent it to some extend. We also could add a separate parameter or value to choose this Found-by: ramiro Signed-off-by: Michael Niedermayer michae...@gmx.at --- libavformat/mov.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/mov.c

Re: [FFmpeg-devel] [PATCH v2] libavformat/mxfdec: export user comments metadata

2015-03-14 Thread Michael Niedermayer
On Fri, Mar 13, 2015 at 06:58:38PM -0700, Mark Reid wrote: --- libavformat/mxf.h| 1 + libavformat/mxfdec.c | 94 +--- 2 files changed, 91 insertions(+), 4 deletions(-) applied, tomas seems to have approved the previous revision pretty

[FFmpeg-devel] [PATCH] store cookies returned in HLS key responses

2015-03-14 Thread Micah Galizia
Hello, Neulion has added Set-Cookie fields in the response headers of their HLS key files. Those cookie values must be echoed back in the next key request or authentication on the subsequent key will fail. This fix will exacerbate the existing bug where the cookie field of ffmpeg requests keeps

Re: [FFmpeg-devel] [PATCH 1/5] lavc: use LOCAL_ALIGNED instead of DECLARE_ALIGNED

2015-03-14 Thread Michael Niedermayer
On Sat, Mar 14, 2015 at 08:08:23PM +0100, Christophe Gisquet wrote: 2015-03-14 20:06 GMT+01:00 Michael Niedermayer michae...@gmx.at: So here's an updated patch. yes, but not in the email ;) Crap, I prepared the mail in advance, but forgot to attach the patch after the fate run. --

[FFmpeg-devel] [PATCH] avcodec/samidec: process more of the SAMI tags

2015-03-14 Thread Won-woo Choi
Made some changes to samidec so that it can process SAMI tags. Processes B and FONT(font face, color). --- libavcodec/samidec.c | 37 +++-- 1 file changed, 35 insertions(+), 2 deletions(-) diff --git a/libavcodec/samidec.c b/libavcodec/samidec.c index

Re: [FFmpeg-devel] [PATCH 4/5] ppc: lavc: use LOCAL_ALIGNED instead of DECLARE_ALIGNED

2015-03-14 Thread James Almer
On 14/03/15 3:18 PM, Michael Niedermayer wrote: On Sat, Mar 14, 2015 at 03:30:27PM +, Christophe Gisquet wrote: The later may yield incorrect code for on-stack variables. --- libavcodec/ppc/h264dsp.c| 10 - libavcodec/ppc/h264qpel.c | 50

Re: [FFmpeg-devel] [PATCH 1/4] libavdevice/avfoundation: add framerate and video size options

2015-03-14 Thread Matthieu Bouron
On Sat, Mar 14, 2015 at 8:31 AM, Carl Eugen Hoyos ceho...@ag.or.at wrote: matthieu.bouron at gmail.com writes: +for (NSObject *format in You may ignore this but I just changed the code to not mix declarations and statements to silence warnings when compiling with old gcc

Re: [FFmpeg-devel] [PATCH 1/4] libavdevice/avfoundation: add framerate and video size options

2015-03-14 Thread Matthieu Bouron
On Sat, Mar 14, 2015 at 11:01 AM, Matthieu Bouron matthieu.bou...@gmail.com wrote: On Sat, Mar 14, 2015 at 8:31 AM, Carl Eugen Hoyos ceho...@ag.or.at wrote: matthieu.bouron at gmail.com writes: +for (NSObject *format in You may ignore this but I just changed the code to not mix

Re: [FFmpeg-devel] [PATCH 1/4] libavdevice/avfoundation: add framerate and video size options

2015-03-14 Thread Carl Eugen Hoyos
matthieu.bouron at gmail.com writes: +for (NSObject *format in You may ignore this but I just changed the code to not mix declarations and statements to silence warnings when compiling with old gcc compilers... +if (framerate == 0.0 Just asking: Does this really

[FFmpeg-devel] [PATCH 2/2] x86: dct-test: evaluate prores idct avx version

2015-03-14 Thread Christophe Gisquet
--- libavcodec/x86/dct-test.c | 39 ++- 1 file changed, 26 insertions(+), 13 deletions(-) diff --git a/libavcodec/x86/dct-test.c b/libavcodec/x86/dct-test.c index 63a9aeb..d1a5067 100644 --- a/libavcodec/x86/dct-test.c +++ b/libavcodec/x86/dct-test.c @@ -26,21

[FFmpeg-devel] [PATCH 0/2] dct-test and prores

2015-03-14 Thread Christophe Gisquet
Some issues found while touching dct-test. Depends on the patch series (rather its first 2 patches, of which one was already applied) for XviD iDCTs. Christophe Gisquet (2): x86: dct-test: fix compilation for prores x86: dct-test: evaluate prores idct avx version libavcodec/x86/dct-test.c |

[FFmpeg-devel] [PATCH 1/2] x86: dct-test: fix compilation for prores

2015-03-14 Thread Christophe Gisquet
When the decoder is deactivated, the x86-optimized versions are not compiled, resulting in a link error. The C version is unaffected, as it is part of the idctdsp subsystem. --- libavcodec/x86/dct-test.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH 2/4] libavdevice/avfoundation: add capture_screen_cursor option

2015-03-14 Thread Matthieu Bouron
On Sat, Mar 14, 2015 at 8:29 AM, Carl Eugen Hoyos ceho...@ag.or.at wrote: matthieu.bouron at gmail.com writes: +#if __MAC_OS_X_VERSION_MIN_REQUIRED = 1080 Please make this #if !TARGET_OS_IPHONE ... to avoid warnings when compiling for iOS. Carl Eugen

Re: [FFmpeg-devel] [PATCH 2/4] libavdevice/avfoundation: add capture_screen_cursor option

2015-03-14 Thread Matthieu Bouron
On Sat, Mar 14, 2015 at 10:50 AM, Matthieu Bouron matthieu.bou...@gmail.com wrote: On Sat, Mar 14, 2015 at 8:29 AM, Carl Eugen Hoyos ceho...@ag.or.at wrote: matthieu.bouron at gmail.com writes: +#if __MAC_OS_X_VERSION_MIN_REQUIRED = 1080 Please make this #if !TARGET_OS_IPHONE ...

Re: [FFmpeg-devel] [RFC] libavfilter query_format() related functions error handling

2015-03-14 Thread Nicolas George
Le quartidi 24 ventôse, an CCXXIII, Michael Niedermayer a écrit : ff_set_common_channel_layouts(ctx, ff_all_channel_layouts()); ff_set_common_formats(ctx, ff_make_format_list(sample_fmts)); ff_set_common_samplerates(ctx, ff_all_samplerates()); return ctx-ff_errno; I wanted

Re: [FFmpeg-devel] [PATCH 1/2] x86: dct-test: fix compilation for prores

2015-03-14 Thread Michael Niedermayer
On Sat, Mar 14, 2015 at 07:57:42AM +, Christophe Gisquet wrote: When the decoder is deactivated, the x86-optimized versions are not compiled, resulting in a link error. The C version is unaffected, as it is part of the idctdsp subsystem. --- libavcodec/x86/dct-test.c | 8 1

Re: [FFmpeg-devel] [PATCH 2/2] x86: dct-test: evaluate prores idct avx version

2015-03-14 Thread Michael Niedermayer
On Sat, Mar 14, 2015 at 07:57:43AM +, Christophe Gisquet wrote: --- libavcodec/x86/dct-test.c | 39 ++- 1 file changed, 26 insertions(+), 13 deletions(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Re: [FFmpeg-devel] [PATCH 1/4] ac3_fixed: fix out-of-bound read

2015-03-14 Thread Michael Niedermayer
On Sat, Mar 14, 2015 at 11:48:57AM +, Christophe Gisquet wrote: Should also improve decoding, but actually doesn't... --- libavcodec/ac3dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) applied thanks [...] -- Michael GnuPG fingerprint:

[FFmpeg-devel] [RFC] libavfilter query_format() related functions error handling

2015-03-14 Thread Clément Bœsch
Hi, I'm adding error handling in the following functions: ff_formats_ref() ff_channel_layouts_ref() ff_set_common_formats() ff_set_common_samplerates() ff_set_common_channel_layouts() (I may have forgotten some) So basically these functions would return AVERROR(ENOMEM) (or whatever

Re: [FFmpeg-devel] [PATCH 3/4] eac3dec: fix scaling

2015-03-14 Thread Michael Niedermayer
On Sat, Mar 14, 2015 at 11:48:59AM +, Christophe Gisquet wrote: This is the remaining error, the output on the SPX samples, respectively csi_miami_stereo_128_spx.eac3 and csi_miami_5.1_256_spx.eac3, goes from: stddev:8.71 PSNR: 77.52 MAXDIFF: 235 stddev:24270.51 PSNR: 22.17

Re: [FFmpeg-devel] [PATCH 2/4] ac3_fixed: fix computation of spx_noise_blend

2015-03-14 Thread Michael Niedermayer
On Sat, Mar 14, 2015 at 11:48:58AM +, Christophe Gisquet wrote: It was set to 1 instead of sqrt(3) --- libavcodec/ac3dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB What does

[FFmpeg-devel] [PATCH 3/4] eac3dec: fix scaling

2015-03-14 Thread Christophe Gisquet
This is the remaining error, the output on the SPX samples, respectively csi_miami_stereo_128_spx.eac3 and csi_miami_5.1_256_spx.eac3, goes from: stddev:8.71 PSNR: 77.52 MAXDIFF: 235 stddev:24270.51 PSNR: 22.17 MAXDIFF:47166 to: stddev:0.12 PSNR:114.12 MAXDIFF:1 stddev:0.12

[FFmpeg-devel] [PATCH 2/4] ac3_fixed: fix computation of spx_noise_blend

2015-03-14 Thread Christophe Gisquet
It was set to 1 instead of sqrt(3) --- libavcodec/ac3dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/ac3dec.c b/libavcodec/ac3dec.c index ce45186..ae4129f 100644 --- a/libavcodec/ac3dec.c +++ b/libavcodec/ac3dec.c @@ -939,7 +939,7 @@ static int

[FFmpeg-devel] [PATCH 1/4] ac3_fixed: fix out-of-bound read

2015-03-14 Thread Christophe Gisquet
Should also improve decoding, but actually doesn't... --- libavcodec/ac3dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/ac3dec.c b/libavcodec/ac3dec.c index 2f78d73..ce45186 100644 --- a/libavcodec/ac3dec.c +++ b/libavcodec/ac3dec.c @@ -872,7 +872,7 @@ static

[FFmpeg-devel] [PATCH 4/4] ac3dec: cosmetics

2015-03-14 Thread Christophe Gisquet
--- libavcodec/ac3dec.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/libavcodec/ac3dec.c b/libavcodec/ac3dec.c index ae4129f..ac53bdc 100644 --- a/libavcodec/ac3dec.c +++ b/libavcodec/ac3dec.c @@ -924,14 +924,13 @@ static int decode_audio_block(AC3DecodeContext *s,

[FFmpeg-devel] [PATCH 0/4] Further fixes to EAC3 FP decoder

2015-03-14 Thread Christophe Gisquet
The SPX blend factors were incorrectly computed. For now, still use floating point operations, with proper scaling, but the interested parties may want to write the proper FP.23 code. Christophe Gisquet (4): ac3_fixed: fix out-of-bound read ac3_fixed: fix computation of spx_noise_blend

Re: [FFmpeg-devel] [PATCH 2/4] x86: xvid_idct: port MMX IDCT to yasm

2015-03-14 Thread Michael Niedermayer
On Thu, Mar 12, 2015 at 08:13:53PM +0100, Christophe Gisquet wrote: Hi, 2015-03-11 17:06 GMT+01:00 James Almer jamr...@gmail.com: As discussed before, mmx, mmxext and sse functions that have also an sse2 version, and 3dnow/3dnowext functions that have also an sse version, have no reason

Re: [FFmpeg-devel] [RFC] libavfilter query_format() related functions error handling

2015-03-14 Thread Michael Niedermayer
On Sat, Mar 14, 2015 at 12:18:51PM +0100, Clément Bœsch wrote: Hi, I'm adding error handling in the following functions: ff_formats_ref() ff_channel_layouts_ref() ff_set_common_formats() ff_set_common_samplerates() ff_set_common_channel_layouts() (I may have forgotten some)

Re: [FFmpeg-devel] [PATCH 3/4] x86: xvid_idct: merged idct_put SSE2 versions

2015-03-14 Thread Michael Niedermayer
On Thu, Mar 12, 2015 at 08:14:47PM +0100, Christophe Gisquet wrote: 2015-03-11 0:11 GMT+01:00 Christophe Gisquet christophe.gisq...@gmail.com: --- libavcodec/x86/xvididct.asm| 202 - libavcodec/x86/xvididct_init.c | 8 +- 2 files changed,

Re: [FFmpeg-devel] [PATCH 4/4] x86: xvid_idct: SSE2 merged add version

2015-03-14 Thread Michael Niedermayer
On Thu, Mar 12, 2015 at 08:15:23PM +0100, Christophe Gisquet wrote: 2015-03-11 0:11 GMT+01:00 Christophe Gisquet christophe.gisq...@gmail.com: --- libavcodec/x86/xvididct.asm| 92 -- libavcodec/x86/xvididct_init.c | 9 + 2 files

Re: [FFmpeg-devel] [RFC] libavfilter query_format() related functions error handling

2015-03-14 Thread Clément Bœsch
On Sat, Mar 14, 2015 at 01:33:12PM +0100, Nicolas George wrote: Le quartidi 24 ventôse, an CCXXIII, Michael Niedermayer a écrit : ff_set_common_channel_layouts(ctx, ff_all_channel_layouts()); ff_set_common_formats(ctx, ff_make_format_list(sample_fmts));

Re: [FFmpeg-devel] [RFC] libavfilter query_format() related functions error handling

2015-03-14 Thread Michael Niedermayer
On Sat, Mar 14, 2015 at 03:11:28PM +0100, Clément Bœsch wrote: On Sat, Mar 14, 2015 at 01:33:12PM +0100, Nicolas George wrote: Le quartidi 24 ventôse, an CCXXIII, Michael Niedermayer a écrit : ff_set_common_channel_layouts(ctx, ff_all_channel_layouts()); ff_set_common_formats(ctx,

Re: [FFmpeg-devel] [PATCH 1/5] lavc: use LOCAL_ALIGNED instead of DECLARE_ALIGNED

2015-03-14 Thread Michael Niedermayer
On Sat, Mar 14, 2015 at 03:30:24PM +, Christophe Gisquet wrote: The later may yield incorrect code for on-stack variables. --- libavcodec/dct-test.c | 2 +- libavcodec/h264_loopfilter.c| 10 +- libavcodec/proresenc_anatoliy.c | 3 ++- libavcodec/vp8.c

Re: [FFmpeg-devel] [PATCH 4/4] ac3dec: cosmetics

2015-03-14 Thread Michael Niedermayer
On Sat, Mar 14, 2015 at 11:49:00AM +, Christophe Gisquet wrote: --- libavcodec/ac3dec.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The misfortune of the wise is better

Re: [FFmpeg-devel] [PATCH] Add ability to pause transcoding via keyboard interaction

2015-03-14 Thread compn
On Wed, 11 Mar 2015 08:34:39 -0500 Jeremy Luce jeremyl...@gmail.com wrote: Resubmitting with [PATCH] tag and unified diff. Adds functionality to pause transcoding with 'p' key and upause with 'u' key over stdin. Pauses in the main transcode loop as well as the input_thread loop. did not

[FFmpeg-devel] [PATCH 3/5] ppc: libswscale: use LOCAL_ALIGNED instead of DECLARE_ALIGNED

2015-03-14 Thread Christophe Gisquet
The later may yield incorrect code for on-stack variables. --- libswscale/ppc/swscale_altivec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libswscale/ppc/swscale_altivec.c b/libswscale/ppc/swscale_altivec.c index a1548a7..3034c72 100644 ---

[FFmpeg-devel] [PATCH 2/5] x86: lavc: use LOCAL_ALIGNED instead of DECLARE_ALIGNED

2015-03-14 Thread Christophe Gisquet
The later may yield incorrect code for on-stack variables. --- libavcodec/x86/ac3dsp_init.c | 2 +- libavcodec/x86/cavsdsp.c | 4 ++-- libavcodec/x86/dct-test.c | 4 ++-- libavcodec/x86/h264_qpel.c| 22 +++--- libavcodec/x86/rv40dsp_init.c | 2 +-

[FFmpeg-devel] [PATCH 5/5] lavc/lavu: remove LOCAL_ALIGNED_*

2015-03-14 Thread Christophe Gisquet
They were duplicating LOCAL_ALIGNED() without benefit. --- configure | 8 +++- libavcodec/aacps.c | 6 +++--- libavcodec/aacsbr.c| 6 +++--- libavcodec/ac3enc.c| 2 +- libavcodec/ac3enc_template.c

[FFmpeg-devel] [PATCH 1/5] lavc: use LOCAL_ALIGNED instead of DECLARE_ALIGNED

2015-03-14 Thread Christophe Gisquet
The later may yield incorrect code for on-stack variables. --- libavcodec/dct-test.c | 2 +- libavcodec/h264_loopfilter.c| 10 +- libavcodec/proresenc_anatoliy.c | 3 ++- libavcodec/vp8.c| 2 +- 4 files changed, 9 insertions(+), 8 deletions(-) diff --git

[FFmpeg-devel] [PATCH 4/5] ppc: lavc: use LOCAL_ALIGNED instead of DECLARE_ALIGNED

2015-03-14 Thread Christophe Gisquet
The later may yield incorrect code for on-stack variables. --- libavcodec/ppc/h264dsp.c| 10 - libavcodec/ppc/h264qpel.c | 50 - libavcodec/ppc/vp8dsp_altivec.c | 2 +- 3 files changed, 31 insertions(+), 31 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH] mxfenc: ensure mxf-body_partition_offset is not NULL before using it

2015-03-14 Thread Andreas Cadhalpun
On 14.03.2015 02:17, Mark Reid wrote: On Fri, Mar 13, 2015 at 6:02 AM, Andreas Cadhalpun andreas.cadhal...@googlemail.com wrote: On 13.03.2015 11:59, Tomas Härdin wrote: A better solution would be to figure out why mxf-body_partition_offset becomes NULL so that index tables and such can

[FFmpeg-devel] [PATCH 0/5] Of {LOCAL_,DECLARE_}ALIGNED

2015-03-14 Thread Christophe Gisquet
LOCAL_ALIGNED has been introduced around 2010 because some compilers didn't obey the alignment request for addresses on the stack. Please see d96cd429 or 0bbb1cdc for instance. There are some remnants being fixed in the 4 first patches. The very first one has some issues (merging lavc and

Re: [FFmpeg-devel] [PATCH 3/5] ppc: libswscale: use LOCAL_ALIGNED instead of DECLARE_ALIGNED

2015-03-14 Thread Michael Niedermayer
On Sat, Mar 14, 2015 at 03:30:26PM +, Christophe Gisquet wrote: The later may yield incorrect code for on-stack variables. --- libswscale/ppc/swscale_altivec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) applied thanks [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH 2/5] x86: lavc: use LOCAL_ALIGNED instead of DECLARE_ALIGNED

2015-03-14 Thread Michael Niedermayer
On Sat, Mar 14, 2015 at 03:30:25PM +, Christophe Gisquet wrote: The later may yield incorrect code for on-stack variables. --- libavcodec/x86/ac3dsp_init.c | 2 +- libavcodec/x86/cavsdsp.c | 4 ++-- libavcodec/x86/dct-test.c | 4 ++-- libavcodec/x86/h264_qpel.c| 22

Re: [FFmpeg-devel] [PATCH 4/5] ppc: lavc: use LOCAL_ALIGNED instead of DECLARE_ALIGNED

2015-03-14 Thread Michael Niedermayer
On Sat, Mar 14, 2015 at 03:30:27PM +, Christophe Gisquet wrote: The later may yield incorrect code for on-stack variables. --- libavcodec/ppc/h264dsp.c| 10 - libavcodec/ppc/h264qpel.c | 50 - libavcodec/ppc/vp8dsp_altivec.c