Re: [FFmpeg-devel] [PATCH] avfilter/vf_shuffleframes: Assert that the case of an uninitialized ret does not occur

On Tue, Dec 01, 2015 at 07:21:19PM +, Paul B Mahol wrote: > On 12/1/15, Michael Niedermayer wrote: > > From: Michael Niedermayer > > > > Fixes CID1258479 > > > > Signed-off-by: Michael Niedermayer > > --- > >

Re: [FFmpeg-devel] request for feedback on video codec idea

On 10/14/15, Hendrik Leppkes wrote: > On Wed, Oct 14, 2015 at 8:08 PM, Roger Pack wrote: >> Lacking a better place to debate this, I would like to ask some >> questions on a video codec idea... >> >> The goal is basically to create a very fast lossless

Re: [FFmpeg-devel] request for feedback on video codec idea

On 10/14/15, Nicolas George wrote: > Le tridi 23 vendémiaire, an CCXXIV, Roger Pack a écrit : >> For instance, given 3 frames of video ("one after another" from the >> incoming video stream), "combine them" into one stream like: >> pixel 1 frame 1, pixel 1 frame 2, pixel 1 frame

Re: [FFmpeg-devel] [PATCH] AAC encoder: improve SF range utilization

On Tue, Dec 1, 2015 at 7:35 AM, Claudio Freire wrote: > On Mon, Nov 30, 2015 at 1:04 PM, Hendrik Leppkes wrote: >> On Mon, Nov 30, 2015 at 4:50 PM, Claudio Freire >> wrote: >>> On Mon, Nov 30, 2015 at 12:27 PM, Rostislav

[FFmpeg-devel] [PATCH] doc/filters/drawtext: fix centering example

Signed-off-by: Andrey Utkin --- doc/filters.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index fc71a99..06686bd 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -5605,7 +5605,7 @@ within the

Re: [FFmpeg-devel] [PATCH] Fix sample_aspect_ratio computation for stereo matroska content.

On Mon, Nov 30, 2015 at 4:35 PM wm4 wrote: > > I tried your patch, and it actually makes it work better (looks correct > with the patch). The patch itself also LGTM. > > Ok. Great. Thanks for the review. What do I need to do next to get this checked in. I don't have commit

[FFmpeg-devel] [PATCH 8/9] avcodec/wavpackenc: use lrint instead of floor hack

Signed-off-by: Ganesh Ajjanagadde --- libavcodec/wavpackenc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/wavpackenc.c b/libavcodec/wavpackenc.c index 977bcf0..6a9b716 100644 --- a/libavcodec/wavpackenc.c +++

[FFmpeg-devel] [PATCH 9/9] avcodec/sonic: use lrint instead of floor hack

Signed-off-by: Ganesh Ajjanagadde --- libavcodec/sonic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/sonic.c b/libavcodec/sonic.c index 4ec7d89..0a848d1 100644 --- a/libavcodec/sonic.c +++ b/libavcodec/sonic.c @@ -537,7 +537,7 @@ static

Re: [FFmpeg-devel] [PATCH 2/2] avfilter: add sidechaingate filter

On Tue, Dec 1, 2015 at 2:14 PM, Paul B Mahol wrote: > On 12/1/15, Nicolas George wrote: >> Le primidi 11 frimaire, an CCXXIV, Paul B Mahol a ecrit : >>> Similar how its freed when no longer used. >> >> Please elaborate. I know the API, I do not see what you

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/mpegaudio_tablegen: more dynamic table creation speedups

On Sat, Nov 28, 2015 at 4:47 PM, Ganesh Ajjanagadde wrote: > On Sat, Nov 28, 2015 at 4:35 PM, Derek Buitenhuis > wrote: >> On 11/28/2015 9:26 PM, Derek Buitenhuis wrote: >>> Changing all of them sounds fine to me. >> >> [21:31] <@ubitux> re: i%4 vs

Re: [FFmpeg-devel] [PATCH 1/4] avutil/tablegen: add tablegen libm compatibility shims

On Sat, Nov 28, 2015 at 4:23 PM, Ganesh Ajjanagadde wrote: > On Sat, Nov 28, 2015 at 3:19 PM, Derek Buitenhuis > wrote: >> On 11/28/2015 7:51 PM, Ganesh Ajjanagadde wrote: >>> In principle of course, e.g with more ifdefry, configure, or something >>>

[FFmpeg-devel] [PATCH 7/9] avcodec/mdct_template: use lrint instead of floor hack

Signed-off-by: Ganesh Ajjanagadde --- libavcodec/mdct_template.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavcodec/mdct_template.c b/libavcodec/mdct_template.c index e7e5f62..ecdeb54 100644 --- a/libavcodec/mdct_template.c +++

[FFmpeg-devel] [PATCH 5/9] avcodec/cos_tablegen: use rint instead of floor hack

Signed-off-by: Ganesh Ajjanagadde --- libavcodec/cos_tablegen.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/cos_tablegen.c b/libavcodec/cos_tablegen.c index dbd0cc0..332216c 100644 --- a/libavcodec/cos_tablegen.c +++

[FFmpeg-devel] [PATCH 6/9] avcodec/kbdwin: use lrint instead of floor hack

Signed-off-by: Ganesh Ajjanagadde --- libavcodec/kbdwin.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/kbdwin.c b/libavcodec/kbdwin.c index bf32aeb..77d5e2b 100644 --- a/libavcodec/kbdwin.c +++ b/libavcodec/kbdwin.c @@ -17,6 +17,7 @@

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/mpegaudio_tablegen: speed up dynamic table creation

On Sat, Nov 28, 2015 at 12:03 PM, Ganesh Ajjanagadde wrote: > This does some miscellaneous stuff mainly avoiding the usage of pow to > achieve significant speedups. This is not speed critical, but is > unnecessary latency and cycles wasted for a user. > > All tables tested

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/cbrt_tablegen: speed up dynamic table creation

On Sat, Nov 28, 2015 at 12:03 PM, Ganesh Ajjanagadde wrote: > On systems having cbrt, there is no reason to use the slow pow function. > > Sample benchmark (x86-64, Haswell, GNU/Linux): > new: > 5124920 decicycles in cbrt_tableinit, 1 runs, 0 skips > > old: >

Re: [FFmpeg-devel] [PATCH] doc/filters/drawtext: fix centering example

On Tue, 1 Dec 2015 21:15:53 +0200, Andrey Utkin wrote: > Signed-off-by: Andrey Utkin > --- > doc/filters.texi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) LGTM and applied. Thanks. ___ ffmpeg-devel mailing list

[FFmpeg-devel] [PATCH 4/9] avfilter/af_flanger: use rint instead of floor hack

Signed-off-by: Ganesh Ajjanagadde --- libavfilter/af_flanger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/af_flanger.c b/libavfilter/af_flanger.c index f8ec830..a92367c 100644 --- a/libavfilter/af_flanger.c +++

[FFmpeg-devel] [PATCH 2/9] avfilter/vf_perspective: use lrint instead of floor hack

Signed-off-by: Ganesh Ajjanagadde --- libavfilter/vf_perspective.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavfilter/vf_perspective.c b/libavfilter/vf_perspective.c index 970870c..13053f1 100644 --- a/libavfilter/vf_perspective.c

[FFmpeg-devel] [PATCH 3/9] avfilter/af_stereotools: use lrint instead of floor hack

Signed-off-by: Ganesh Ajjanagadde --- libavfilter/af_stereotools.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavfilter/af_stereotools.c b/libavfilter/af_stereotools.c index a22efb0..e878824 100644 --- a/libavfilter/af_stereotools.c +++

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/ppc/fdctdsp: use more accurate constants

On Mon, Nov 16, 2015 at 1:58 PM, Ganesh Ajjanagadde wrote: > On Mon, Nov 16, 2015 at 1:20 PM, Hendrik Leppkes wrote: >> On Mon, Nov 16, 2015 at 6:24 PM, Ganesh Ajjanagadde wrote: >>> On Mon, Nov 16, 2015 at 9:48 AM, Daniel Serpell

Re: [FFmpeg-devel] [PATCH 05/10] avfilter/avf_showcqt: use hypot()

On Mon, Nov 30, 2015 at 11:15 PM, Muhammad Faiz wrote: > On Sun, Nov 22, 2015 at 9:05 AM, Ganesh Ajjanagadde > wrote: >> Signed-off-by: Ganesh Ajjanagadde >> --- >> libavfilter/avf_showcqt.c | 2 +- >> 1 file changed, 1

Re: [FFmpeg-devel] [PATCH 06/11] avfilter/af_volumedetect: use log10 instead of hardcoded constant

On Sat, Oct 31, 2015 at 6:12 PM, Ganesh Ajjanagadde wrote: > On Sat, Oct 31, 2015 at 6:02 PM, Mark Harris wrote: >> On Wed, Oct 28, 2015 at 9:20 PM, Ganesh Ajjanagadde >> wrote: >>> This is likely more precise and conveys the

Re: [FFmpeg-devel] [PATCH] AAC encoder: improve SF range utilization

On Tue, 2015-12-01 at 03:35 -0300, Claudio Freire wrote: >  > Attached patch does that. > Went over the patch, everything me and other people said has been addressed, so LGTM. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 0/9] improve rounding across FFmpeg

On Tue, 1 Dec 2015 19:27:49 -0500, Ganesh Ajjanagadde wrote: > The slowness comes from the generate code, e.g llrint compiles down to > a single asm instruction cvttsd2si, while floor(x + 0.5) needs to do > multiple things. How much slower is it? ___

[FFmpeg-devel] [patch] AV_CH_LAYOUT_6POINT1_BACK not reachable in parsing

[bug submit webpage seems to be down, sending directly] Trying to make heads and tails out of DTS 6.1 I can across this typo. I also noticed that this wiki page is incorrect or misleading, the channel order for 6.1 given does not match the source code. At the least it should be clarified that

[FFmpeg-devel] [PATCH 1/9] avfilter/vsrc_mptestsrc: use lrint instead of floor hack

lrint is faster, and is more consistent across the codebase. Signed-off-by: Ganesh Ajjanagadde --- libavfilter/vsrc_mptestsrc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vsrc_mptestsrc.c b/libavfilter/vsrc_mptestsrc.c index

[FFmpeg-devel] [PATCH 0/9] improve rounding across FFmpeg

Currently, there are numerous instances where the appropriate libm rounding functions lrint, llrint, rint, etc are not used and instead ad-hoc, slow, and sometimes risky floor(x + 0.5) and the like are being used. The risk comes from the fact that such a thing is broken for negative values and

Re: [FFmpeg-devel] [PATCH 0/9] improve rounding across FFmpeg

On Tue, Dec 1, 2015 at 7:39 PM, Lou Logan wrote: > On Tue, 1 Dec 2015 19:27:49 -0500, Ganesh Ajjanagadde wrote: > >> The slowness comes from the generate code, e.g llrint compiles down to >> a single asm instruction cvttsd2si, while floor(x + 0.5) needs to do >> multiple things. >

Re: [FFmpeg-devel] [PATCHv2] avutil/crc: avoid needless space wastage of hardcoded crc table

On 12/1/2015 9:53 PM, Ganesh Ajjanagadde wrote: > There was no reason AFAIK for making AV_CRC_24_IEEE 12. This simply > resulted in wasted space under --enable-hardcoded-tables: > dynamic: 1318672 libavutil/libavutil.so.55 > old: 1330680 libavutil/libavutil.so.55 > new: 1326488

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: prefer "fast_seek" to TOC seek for CBR files.

On Tue, Dec 01, 2015 at 10:47:53AM -0800, Chris Cunningham wrote: > Thanks wm4, next patch will fix that declaration. > > Michael, any concerns? iam fine with the patch > > On Mon, Nov 30, 2015 at 2:51 PM, wm4 wrote: [...] > > Other than that LGTM. wm4, your replies

Re: [FFmpeg-devel] [PATCHv2] avutil/crc: avoid needless space wastage of hardcoded crc table

On Tue, Dec 1, 2015 at 8:08 PM, James Almer wrote: > On 12/1/2015 9:53 PM, Ganesh Ajjanagadde wrote: >> There was no reason AFAIK for making AV_CRC_24_IEEE 12. This simply >> resulted in wasted space under --enable-hardcoded-tables: >> dynamic: 1318672 libavutil/libavutil.so.55

Re: [FFmpeg-devel] [PATCH] AAC encoder: improve SF range utilization

On Tue, Dec 01, 2015 at 03:35:40AM -0300, Claudio Freire wrote: > On Mon, Nov 30, 2015 at 1:04 PM, Hendrik Leppkes wrote: > > On Mon, Nov 30, 2015 at 4:50 PM, Claudio Freire > > wrote: > >> On Mon, Nov 30, 2015 at 12:27 PM, Rostislav Pehlivanov > >>

Re: [FFmpeg-devel] [PATCHv2] avutil/crc: avoid needless space wastage of hardcoded crc table

On Tue, Dec 1, 2015 at 8:38 PM, James Almer wrote: > On 12/1/2015 10:35 PM, Ganesh Ajjanagadde wrote: >> On Tue, Dec 1, 2015 at 8:08 PM, James Almer wrote: >>> On 12/1/2015 9:53 PM, Ganesh Ajjanagadde wrote: There was no reason AFAIK for making

Re: [FFmpeg-devel] [PATCH 2/9] avfilter/vf_perspective: use lrint instead of floor hack

On Tue, Dec 01, 2015 at 07:27:51PM -0500, Ganesh Ajjanagadde wrote: > Signed-off-by: Ganesh Ajjanagadde > --- > libavfilter/vf_perspective.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) should be ok [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH] AAC encoder: improve SF range utilization

On Tue, Dec 1, 2015 at 10:47 PM, Michael Niedermayer wrote: >> libavcodec/aaccoder.c | 60 -- >> libavcodec/aaccoder_twoloop.h | 136 >> -- >> libavcodec/aacenc.c |2 >> libavcodec/aacenc_is.c

Re: [FFmpeg-devel] [PATCH 1/2] ffprobe: Do not print profile names in -bitexact

On Fri, Nov 27, 2015 at 02:33:02PM -0800, Timothy Gu wrote: > Instead, print "unknown" if it's unknown, or their numerical values if > they are known. > --- > > Addresses Nicholas's comment. > > --- > ffprobe.c | 12 +--- > 1 file changed, 9 insertions(+), 3 deletions(-) Ping. Timothy

Re: [FFmpeg-devel] [PATCH] tests/api: Fix API test build on windows with --enable-shared

On Tue, Dec 01, 2015 at 08:04:22PM +0100, Hendrik Leppkes wrote: > On Mon, Nov 30, 2015 at 10:50 PM, Hendrik Leppkes wrote: > > --- > > I'm not quite sure if this fix is 100% correct, but it works here. > > > > The problem is that FF_DEP_LIBS points to the .dll files, but you

Re: [FFmpeg-devel] [PATCH] avfilter: add audio pulsator filter

On Tue, Dec 1, 2015 at 7:04 AM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 57 + > libavfilter/Makefile | 1 + > libavfilter/af_apulsator.c | 279 > + >

[FFmpeg-devel] [PATCHv2] avutil/crc: avoid needless space wastage of hardcoded crc table

There was no reason AFAIK for making AV_CRC_24_IEEE 12. This simply resulted in wasted space under --enable-hardcoded-tables: dynamic: 1318672 libavutil/libavutil.so.55 old: 1330680 libavutil/libavutil.so.55 new: 1326488 libavutil/libavutil.so.55 Minor version number is bumped, with

Re: [FFmpeg-devel] [PATCH] tests/api: Fix API test build on windows with --enable-shared

On Tue, Dec 1, 2015 at 8:29 PM, Michael Niedermayer wrote: > On Tue, Dec 01, 2015 at 08:04:22PM +0100, Hendrik Leppkes wrote: >> On Mon, Nov 30, 2015 at 10:50 PM, Hendrik Leppkes >> wrote: >> > --- >> > I'm not quite sure if this fix is 100% correct, but

Re: [FFmpeg-devel] [PATCHv2] avutil/crc: avoid needless space wastage of hardcoded crc table

On 12/1/2015 10:35 PM, Ganesh Ajjanagadde wrote: > On Tue, Dec 1, 2015 at 8:08 PM, James Almer wrote: >> On 12/1/2015 9:53 PM, Ganesh Ajjanagadde wrote: >>> There was no reason AFAIK for making AV_CRC_24_IEEE 12. This simply >>> resulted in wasted space under

[FFmpeg-devel] [PATCH] vp9: always keep s->bytesperpixel and ctx->pix_fmt in sync.

Fixes mozilla bug 1229128. --- libavcodec/vp9.c | 43 ++- 1 file changed, 22 insertions(+), 21 deletions(-) diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c index d4061e2..dc0 100644 --- a/libavcodec/vp9.c +++ b/libavcodec/vp9.c @@ -69,6 +69,7 @@

Re: [FFmpeg-devel] [PATCH] vp9: always keep s->bytesperpixel and ctx->pix_fmt in sync.

Hi, On Tue, Dec 1, 2015 at 11:09 AM, Hendrik Leppkes wrote: > On Tue, Dec 1, 2015 at 4:08 PM, Ronald S. Bultje > wrote: > > Fixes mozilla bug 1229128. > > --- > > libavcodec/vp9.c | 43 ++- > > 1 file changed, 22

Re: [FFmpeg-devel] [PATCH] vp9: always keep s->bytesperpixel and ctx->pix_fmt in sync.

On Tue, Dec 1, 2015 at 6:24 PM, Ronald S. Bultje wrote: > Fixes mozilla bug 1229128. > --- > libavcodec/vp9.c | 43 ++- > 1 file changed, 22 insertions(+), 21 deletions(-) > > diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c > index

Re: [FFmpeg-devel] [PATCH 1/2] avutil/threadmessage: add av_thread_message_flush()

Le primidi 11 frimaire, an CCXXIV, Clement Boesch a écrit : > Ah. Well then the user can not do it himself since he has no way of > acquiring the queue lock (AVThreadMessageQueue is opaque) Yes, but why does it matter, if the elements are to be discarded anyway. Ah, I think I see a point: this

Re: [FFmpeg-devel] [PATCH] vp9: always keep s->bytesperpixel and ctx->pix_fmt in sync.

Hi, On Tue, Dec 1, 2015 at 12:34 PM, Hendrik Leppkes wrote: > On Tue, Dec 1, 2015 at 6:24 PM, Ronald S. Bultje > wrote: > > Fixes mozilla bug 1229128. > > --- > > libavcodec/vp9.c | 43 ++- > > 1 file changed, 22

Re: [FFmpeg-devel] [PATCH] avfilter: add audio pulsator filter

On 12/2/15, Ganesh Ajjanagadde wrote: >> +static void lfo_advance(SimpleLFO *lfo, unsigned count) >> +{ >> +lfo->phase = fabs(lfo->phase + count * lfo->freq / lfo->srate); >> +if (lfo->phase >= 1) >> +lfo->phase = fmod(lfo->phase, 1); >> +} >> + >> +static double

Re: [FFmpeg-devel] [PATCH 4/9] avfilter/af_flanger: use rint instead of floor hack

On 12/2/15, Ganesh Ajjanagadde wrote: > Signed-off-by: Ganesh Ajjanagadde > --- > libavfilter/af_flanger.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/af_flanger.c b/libavfilter/af_flanger.c > index

Re: [FFmpeg-devel] [PATCH 3/9] avfilter/af_stereotools: use lrint instead of floor hack

On 12/2/15, Ganesh Ajjanagadde wrote: > Signed-off-by: Ganesh Ajjanagadde > --- > libavfilter/af_stereotools.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/libavfilter/af_stereotools.c

Re: [FFmpeg-devel] [PATCH 2/2] avfilter: add sidechaingate filter

On 12/2/15, Ganesh Ajjanagadde wrote: > On Tue, Dec 1, 2015 at 2:14 PM, Paul B Mahol wrote: >> On 12/1/15, Nicolas George wrote: >>> Le primidi 11 frimaire, an CCXXIV, Paul B Mahol a ecrit : Similar how its freed when no longer used. >>>

Re: [FFmpeg-devel] [PATCH 8/9] avcodec/wavpackenc: use lrint instead of floor hack

On 12/2/15, Ganesh Ajjanagadde wrote: > Signed-off-by: Ganesh Ajjanagadde > --- > libavcodec/wavpackenc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/wavpackenc.c b/libavcodec/wavpackenc.c > index

[FFmpeg-devel] [PATCH 1/3] common.mak: Use CCFLAGS for assembly generation as well

CCFLAGS is equivalent to CPPFLAGS + CFLAGS. --- common.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common.mak b/common.mak index d611ef8..05836ba 100644 --- a/common.mak +++ b/common.mak @@ -63,7 +63,7 @@ COMPILE_HOSTC = $(call COMPILE,HOSTCC) $(COMPILE_C)

[FFmpeg-devel] [PATCH 2/3] decklink: Header cleanup

--- libavdevice/decklink_common.cpp | 4 libavdevice/decklink_common.h | 8 +++- libavdevice/decklink_common_c.h | 2 ++ libavdevice/decklink_dec.cpp| 4 libavdevice/decklink_dec.h | 2 ++ libavdevice/decklink_enc.cpp| 4 libavdevice/decklink_enc.h | 2 ++ 7

[FFmpeg-devel] [PATCH 3/3] avdevice: Mark decklink_common.h as unconditional SKIPHEADER

It is a C++ file, incompatible with the checkheaders infrastructure. --- libavdevice/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavdevice/Makefile b/libavdevice/Makefile index f57ec0b..8394e87 100644 --- a/libavdevice/Makefile +++ b/libavdevice/Makefile @@

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: prefer "fast_seek" to TOC seek for CBR files.

Thanks wm4, next patch will fix that declaration. Michael, any concerns? On Mon, Nov 30, 2015 at 2:51 PM, wm4 wrote: > On Mon, 30 Nov 2015 14:29:50 -0800 > chcunning...@chromium.org wrote: > > > From: Chris Cunningham > > > > "Fast seek" uses

[FFmpeg-devel] [PATCH] avformat/mp3dec: prefer "fast_seek" to TOC seek for CBR files.

From: Chris Cunningham "Fast seek" uses linear interpolation to find the position of the requested seek time. For CBR this is more direct than using the mp3 TOC and bypassing the TOC avoids problems with TOC precision. (see https://crbug.com/545914#c13) For VBR, fast

Re: [FFmpeg-devel] [PATCH 2/2] avfilter: add sidechaingate filter

On 12/1/15, Nicolas George wrote: > Le primidi 11 frimaire, an CCXXIV, Paul B Mahol a ecrit : >> Similar how its freed when no longer used. > > Please elaborate. I know the API, I do not see what you suggest. > > (Thanks for trimming.) > > Regards, After carefully looking at

[FFmpeg-devel] [PATCH] avfilter/vf_shuffleframes: Assert that the case of an uninitialized ret does not occur

From: Michael Niedermayer Fixes CID1258479 Signed-off-by: Michael Niedermayer --- libavfilter/vf_shuffleframes.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_shuffleframes.c

Re: [FFmpeg-devel] [PATCH] avfilter/vf_shuffleframes: Assert that the case of an uninitialized ret does not occur

On 12/1/15, Michael Niedermayer wrote: > From: Michael Niedermayer > > Fixes CID1258479 > > Signed-off-by: Michael Niedermayer > --- > libavfilter/vf_shuffleframes.c |8 > 1 file changed, 4 insertions(+), 4

[FFmpeg-devel] Does FFplay support HEVC interlaced bitstream display?

Hi, everyone. I noticed that HEVC support interlaced field encoding, but FFplay didn't support HEVC interlaced bitstream display. We know FFplay play h264 interlaced bitstream perfectly. I'd like to know if FFplay support HEVC interlaced bitstream display. And will FFmpeg support that? Best

Re: [FFmpeg-devel] [PATCH 1/7] lavf: add API to apply a list of bsfs to a packet

On Mon, Nov 30, 2015 at 18:05:25 -0600, Rodger Combs wrote: > libavformat/avformat.h | 11 +++ > libavformat/utils.c| 49 + > 2 files changed, 60 insertions(+) I would find it useful to have an informational message (at least in

[FFmpeg-devel] [PATCH] vp9: always keep s->bytesperpixel and ctx->pix_fmt in sync.

Fixes mozilla bug 1229128. --- libavcodec/vp9.c | 43 ++- 1 file changed, 22 insertions(+), 21 deletions(-) diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c index d4061e2..9bf746c 100644 --- a/libavcodec/vp9.c +++ b/libavcodec/vp9.c @@ -69,6 +69,7 @@

[FFmpeg-devel] [PATCH] avutil/threadmessage: fix condition broadcasting

From: Clément Bœsch Fix a dead lock under certain conditions. Let's assume we have a queue of 1 message max, 2 senders, and 1 receiver. Scenario (real record obtained with debug added): [...] SENDER #0: acquired lock SENDER #0: queue is full, wait SENDER

Re: [FFmpeg-devel] [PATCH] avfilter/showcqt: BASEFREQ and ENDFREQ cast to double

On Mon, Nov 30, 2015 at 08:03:41PM -0800, Muhammad Faiz wrote: > On Mon, Nov 30, 2015 at 12:06 PM, Michael Niedermayer > wrote: > > On Mon, Nov 30, 2015 at 07:02:47PM +0100, Nicolas George wrote: > >> Le decadi 10 frimaire, an CCXXIV, Michael Niedermayer a écrit : > >> > >

Re: [FFmpeg-devel] [PATCH] avfilter/showcqt: BASEFREQ and ENDFREQ cast to double

Le primidi 11 frimaire, an CCXXIV, Michael Niedermayer a écrit : > nicolas are you ok with this being applied ? (IIRC you objected to it) I am not really satisfied but I do not object. Hopefully it will not break again. Regards, -- Nicolas George signature.asc Description: Digital

Re: [FFmpeg-devel] [PATCH] avfilter/showcqt: BASEFREQ and ENDFREQ cast to double

On Tue, Dec 1, 2015 at 10:38 AM, Nicolas George wrote: > Le primidi 11 frimaire, an CCXXIV, Michael Niedermayer a écrit : >> nicolas are you ok with this being applied ? (IIRC you objected to it) > > I am not really satisfied but I do not object. Hopefully it will not break >

[FFmpeg-devel] [PATCH] avfilter: add audio emphasis filter

Signed-off-by: Paul B Mahol --- configure | 3 + doc/filters.texi | 46 ++ libavfilter/Makefile | 1 + libavfilter/af_aemphasis.c | 354 + libavfilter/allfilters.c | 1 + 5 files changed,

[FFmpeg-devel] [PATCH 1/2] avutil/mathematics: return INT64_MIN (=AV_NOPTS_VALUE) from av_rescale_rnd() for overflows

From: Michael Niedermayer Fixes integer overflow Fixes: mozilla bug 1229167 Found-by: Tyson Smith Signed-off-by: Michael Niedermayer --- libavutil/mathematics.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git

[FFmpeg-devel] [PATCH 2/2] avutil/rational: Test av_rescale_rnd() with combinations of "special" values

From: Michael Niedermayer Signed-off-by: Michael Niedermayer --- libavutil/Makefile |1 + libavutil/rational.c | 44 2 files changed, 45 insertions(+) diff --git a/libavutil/Makefile

[FFmpeg-devel] [PATCH] avfilter: add audio pulsator filter

Signed-off-by: Paul B Mahol --- doc/filters.texi | 57 + libavfilter/Makefile | 1 + libavfilter/af_apulsator.c | 279 + libavfilter/allfilters.c | 1 + 4 files changed, 338 insertions(+) create mode

Re: [FFmpeg-devel] Does FFplay support HEVC interlaced bitstream display?

Fan Yingming wrote: Hi, everyone. I noticed that HEVC support interlaced field encoding, but FFplay didn't support HEVC interlaced bitstream display. We know FFplay play h264 interlaced bitstream perfectly. I'd like to know if FFplay support HEVC interlaced bitstream display. And will FFmpeg

[FFmpeg-devel] FFMPEG API

Hi, I'm new with ffmpeg, I'm using the (XX-57) version. I have the following old code but I can't find the *avcodec_alloc_frame*: AVPicture* pConvertedFrame = *avcodec_alloc_frame*(); *I get: * *error C3861: 'avcodec_alloc_frame': identifier not found * I tried the *"*

Re: [FFmpeg-devel] Does FFplay support HEVC interlaced bitstream display?

On Tue, 1 Dec 2015 12:12:13 + Andy Furniss wrote: > Fan Yingming wrote: > > Hi, everyone. > > > > I noticed that HEVC support interlaced field encoding, but FFplay > > didn't support HEVC interlaced bitstream display. > > > > We know FFplay play h264 interlaced bitstream

Re: [FFmpeg-devel] Does FFplay support HEVC interlaced bitstream display?

Hendrik Leppkes wrote: On Tue, Dec 1, 2015 at 1:36 PM, wm4 wrote: On Tue, 1 Dec 2015 12:12:13 + Andy Furniss wrote: Fan Yingming wrote: Hi, everyone. I noticed that HEVC support interlaced field encoding, but FFplay didn't support HEVC

Re: [FFmpeg-devel] Does FFplay support HEVC interlaced bitstream display?

On Tue, Dec 1, 2015 at 1:36 PM, wm4 wrote: > On Tue, 1 Dec 2015 12:12:13 + > Andy Furniss wrote: > >> Fan Yingming wrote: >> > Hi, everyone. >> > >> > I noticed that HEVC support interlaced field encoding, but FFplay >> > didn't support HEVC

Re: [FFmpeg-devel] Does FFplay support HEVC interlaced bitstream display?

Andy Furniss wrote: On the "just metadata" comment - you do have to feed (IIRC) top field first so I would hope there is some spatial handling of the bobbing in there somewhere, but then "my hope" may not match with reality :-) Of course I am thinking of libx265 here - maybe the spec says

Re: [FFmpeg-devel] [PATCH 2/2] avfilter: add sidechaingate filter

Le primidi 11 frimaire, an CCXXIV, Paul B Mahol a écrit : > Similar how its freed when no longer used. Please elaborate. I know the API, I do not see what you suggest. (Thanks for trimming.) Regards, -- Nicolas George signature.asc Description: Digital signature

Re: [FFmpeg-devel] [PATCH] avfilter: add audio emphasis filter

On Tue, Dec 01, 2015 at 12:22:43 +0100, Paul B Mahol wrote: > +select Compat Disc (CD). Compact > +@item 50fm > +select 50??s (FM). a) I'm not sure whether you're allowed or encouraged to use UTF-8 characters in ffmpeg's code. If encouraged, then okay. Riddles me though how you managed to

Re: [FFmpeg-devel] [PATCH] vp9: reinit internal buffers on bpp change.

Hi, On Tue, Dec 1, 2015 at 9:21 AM, Hendrik Leppkes wrote: > On Tue, Dec 1, 2015 at 3:13 PM, Ronald S. Bultje > wrote: > > Fixes mozilla bug 1229128. > > --- > > libavcodec/vp9.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff

Re: [FFmpeg-devel] [PATCH 2/2] avfilter: add sidechaingate filter

Dana 1. 12. 2015. 15:08 osoba "Nicolas George" napisala je: > > Le primidi 11 frimaire, an CCXXIV, Paul B Mahol a écrit : > > I don't think API is needed for this. Just one call in right place IIRC. > > Can you show an example? That would be more useful than handwaving. I must >

Re: [FFmpeg-devel] [PATCH 2/2] avfilter: add sidechaingate filter

On Tue, Dec 1, 2015 at 3:50 AM, Paul B Mahol wrote: > On 12/1/15, Ganesh Ajjanagadde wrote: >> On Sun, Nov 29, 2015 at 6:03 PM, Paul B Mahol wrote: >>> Signed-off-by: Paul B Mahol >>> --- >>> doc/filters.texi |

Re: [FFmpeg-devel] FFMPEG API

only add the include and AVPicture* pConvertedFrame = (AVPicture*)*av_frame_alloc*(); On Tue, Dec 1, 2015 at 2:33 PM, Yosef B wrote: > Hi, > I'm new with ffmpeg, I'm using the (XX-57) version. > > I have the following old code but I can't find the *avcodec_alloc_frame*: >

Re: [FFmpeg-devel] [PATCH 2/2] avfilter: add sidechaingate filter

On 12/1/15, Ganesh Ajjanagadde wrote: > On Tue, Dec 1, 2015 at 3:50 AM, Paul B Mahol wrote: >> On 12/1/15, Ganesh Ajjanagadde wrote: >>> On Sun, Nov 29, 2015 at 6:03 PM, Paul B Mahol wrote: Signed-off-by: Paul B Mahol

Re: [FFmpeg-devel] [PATCH 2/2] avfilter: add sidechaingate filter

Le primidi 11 frimaire, an CCXXIV, Paul B Mahol a écrit : > I don't think API is needed for this. Just one call in right place IIRC. Can you show an example? That would be more useful than handwaving. I must say I have no idea what the "right place" would be. Also, I would appreciate if Ganesh

Re: [FFmpeg-devel] [PATCH] vp9: reinit internal buffers on bpp change.

On Tue, Dec 1, 2015 at 3:13 PM, Ronald S. Bultje wrote: > Fixes mozilla bug 1229128. > --- > libavcodec/vp9.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c > index d4061e2..858d561 100644 > ---

Re: [FFmpeg-devel] FFMPEG API

On Tue, 1 Dec 2015 14:33:09 +0200 Yosef B wrote: > Hi, > I'm new with ffmpeg, I'm using the (XX-57) version. > > I have the following old code but I can't find the *avcodec_alloc_frame*: > AVPicture* pConvertedFrame = *avcodec_alloc_frame*(); > > *I get: * > *error

[FFmpeg-devel] [PATCH] vp9: reinit internal buffers on bpp change.

Fixes mozilla bug 1229128. --- libavcodec/vp9.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c index d4061e2..858d561 100644 --- a/libavcodec/vp9.c +++ b/libavcodec/vp9.c @@ -219,7 +219,8 @@ static int update_size(AVCodecContext *ctx, int

Re: [FFmpeg-devel] [PATCH] vp9: always keep s->bytesperpixel and ctx->pix_fmt in sync.

On Tue, Dec 1, 2015 at 4:08 PM, Ronald S. Bultje wrote: > Fixes mozilla bug 1229128. > --- > libavcodec/vp9.c | 43 ++- > 1 file changed, 22 insertions(+), 21 deletions(-) > > diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c > index

Re: [FFmpeg-devel] [PATCH 1/2] avutil/threadmessage: add av_thread_message_flush()

Le decadi 10 frimaire, an CCXXIV, Clement Boesch a écrit : > From: Clément Bœsch > > --- > libavutil/threadmessage.c | 37 ++--- > libavutil/threadmessage.h | 21 ++--- > 2 files changed, 52 insertions(+), 6 deletions(-) >

Re: [FFmpeg-devel] [PATCH 5/5] lavfi: make request_frame() non-recursive.

Le decadi 10 frimaire, an CCXXIV, Hendrik Leppkes a écrit : > We generally just use ints for boolean properties, any particular > reason this uses unsigned instead? Just a matter of personal habit, justified below. But as I look at it, I see it is rather inconsistent with other fields in the

Re: [FFmpeg-devel] [PATCH 1/2] avutil/threadmessage: add av_thread_message_flush()

On Tue, Dec 01, 2015 at 05:11:06PM +0100, Nicolas George wrote: > Le decadi 10 frimaire, an CCXXIV, Clement Boesch a écrit : > > From: Clément Bœsch > > > > --- > > libavutil/threadmessage.c | 37 ++--- > > libavutil/threadmessage.h | 21

Re: [FFmpeg-devel] [PATCH 1/2] avutil/threadmessage: add av_thread_message_flush()

Le primidi 11 frimaire, an CCXXIV, Clement Boesch a écrit : > Your suggestion is twice smaller. I guess I was not clear enough: I was not asking about merits of this implementations over yours, but about the usefulness of the function for the application compared to reading and discarding each

Re: [FFmpeg-devel] [PATCH 5/5] lavfi: make request_frame() non-recursive.

On Tue, Dec 01, 2015 at 05:26:23PM +0100, Nicolas George wrote: > Le decadi 10 frimaire, an CCXXIV, Hendrik Leppkes a écrit : > > We generally just use ints for boolean properties, any particular > > reason this uses unsigned instead? > > Just a matter of personal habit, justified below. But as I

Re: [FFmpeg-devel] [PATCH 1/2] avutil/threadmessage: add av_thread_message_flush()

On Tue, Dec 01, 2015 at 05:34:39PM +0100, Nicolas George wrote: > Le primidi 11 frimaire, an CCXXIV, Clement Boesch a écrit : > > Your suggestion is twice smaller. > > I guess I was not clear enough: I was not asking about merits of this > implementations over yours, but about the usefulness of

Re: [FFmpeg-devel] [PATCH 5/5] lavfi: make request_frame() non-recursive.

On Tue, Dec 1, 2015 at 11:26 AM, Nicolas George wrote: > Le decadi 10 frimaire, an CCXXIV, Hendrik Leppkes a écrit : >> We generally just use ints for boolean properties, any particular >> reason this uses unsigned instead? > > Just a matter of personal habit, justified below.