Re: [FFmpeg-devel] [PATCH 4/4] lavf/mov: Add support for edit list parsing.

2016-09-18 Thread Sasi Inguva
On Sun, Sep 18, 2016 at 6:05 PM, Michael Niedermayer wrote: > On Sun, Sep 18, 2016 at 02:45:52PM -0700, Sasi Inguva wrote: > > Is it ok to just log an error and return 0 ? > > Is a global timescale of 0 allowed ? > QT does not seem to explicitly say so > > can something

Re: [FFmpeg-devel] [PATCH 4/4] lavf/mov: Add support for edit list parsing.

2016-09-18 Thread Michael Niedermayer
On Sun, Sep 18, 2016 at 02:45:52PM -0700, Sasi Inguva wrote: > Is it ok to just log an error and return 0 ? Is a global timescale of 0 allowed ? QT does not seem to explicitly say so can something better be done ? If you are not sure what to do for the 0 case the best would likely be to ask for

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mxfdec: use first valid sourceclip found if material track has multiple components

2016-09-18 Thread Michael Niedermayer
On Sun, Sep 18, 2016 at 02:11:34PM -0700, Mark Reid wrote: > hi, > This patch fixes a issue with mxf footage having multiple > components on a material track. > > here is a link to the sample footage for the second patches fate test >

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: refine EXT-X-BYTERANGE support for segments

2016-09-18 Thread Steven Liu
2016-09-19 0:24 GMT+08:00 Moritz Barsnick : > On Sun, Sep 18, 2016 at 23:40:34 +0800, Steven Liu wrote: > > > +if (byterange_mode) { > > +version = 4; > > +sequence = byterange_mode ? 0 : sequence; > > What does the ternary if-then-else operation do here? Two

[FFmpeg-devel] [PATCH] doc/encoders: minor aac encoder formatting improvements

2016-09-18 Thread Moritz Barsnick
Minor changes for markup consistency. That line I shifted is probably redundant. Moritz >From 9c4de92a603ff998d0b45cb783bd624374df6d3d Mon Sep 17 00:00:00 2001 From: Moritz Barsnick Date: Sun, 18 Sep 2016 23:51:48 +0200 Subject: [PATCH] doc/encoders: minor aac encoder

[FFmpeg-devel] [PATCH 1/2] avformat/mxfdec: use first valid sourceclip found if material track has multiple components

2016-09-18 Thread Mark Reid
hi, This patch fixes a issue with mxf footage having multiple components on a material track. here is a link to the sample footage for the second patches fate test https://dl.dropboxusercontent.com/u/170952/fate/mxf/multiple_components.mxf --- libavformat/mxfdec.c | 8 +++- 1 file changed,

[FFmpeg-devel] [PATCH 2/2] test/fate: add multi component mxf test

2016-09-18 Thread Mark Reid
--- tests/fate/mxf.mak | 3 +++ tests/ref/fate/mxf-multiple-components-demux | 11 +++ 2 files changed, 14 insertions(+) create mode 100644 tests/ref/fate/mxf-multiple-components-demux diff --git a/tests/fate/mxf.mak b/tests/fate/mxf.mak index 6032c85..e95c0b5

Re: [FFmpeg-devel] [PATCH 4/4] lavf/mov: Add support for edit list parsing.

2016-09-18 Thread Michael Niedermayer
On Sat, Sep 17, 2016 at 03:14:24PM -0700, Sasi Inguva wrote: [...] > > [...] > > > @@ -2756,6 +2757,343 @@ static int mov_read_sbgp(MOVContext *c, > > AVIOContext *pb, MOVAtom atom) > > > return pb->eof_reached ? AVERROR_EOF : 0; > > > } > > > > > > +/** > > > + * Get ith edit list entry

Re: [FFmpeg-devel] [PATCH] lavd/opengl: use SDL2

2016-09-18 Thread Josh de Kock
From c8988099c8535c77382b6f05d23326a0270bb2f4 Mon Sep 17 00:00:00 2001 From: Lukasz Marek Date: Sun, 18 Sep 2016 19:13:12 +0200 Subject: [PATCH] lavd/opengl: use SDL2 Signed-off-by: Lukasz Marek --- libavdevice/opengl_enc.c | 109

[FFmpeg-devel] [PATCH] crystalhd: Use up-to-date bsf API

2016-09-18 Thread Philip Langdale
Although the old API is supposed to functional, the crystalhd decoder is currently not working for non-annex.b h.264 content. So, let's update to the modern API and make it work again. Signed-off-by: Philip Langdale --- libavcodec/crystalhd.c | 87

Re: [FFmpeg-devel] [PATCH] avfilter/WIP: add nlmeans filter

2016-09-18 Thread Clément Bœsch
On Sun, Sep 18, 2016 at 06:49:03PM +0200, Carl Eugen Hoyos wrote: > 2016-09-18 13:36 GMT+02:00 Clément Bœsch : > > Fixes Ticket #4910 > > > > TODO (before 1st pushed version): > > - add chroma paramters (for patch size and research window) > > - doc > > - lavfi minor bump, Changelog >

Re: [FFmpeg-devel] [PATCH 1/4] lavd: Add SDL2 output device

2016-09-18 Thread Lukasz Marek
On 15.09.2016 00:27, Josh de Kock wrote: Acked-by: Michael Niedermayer Signed-off-by: Josh de Kock --- configure| 28 +++- libavdevice/Makefile | 1 + libavdevice/alldevices.c | 1 + libavdevice/sdl2.c | 377

Re: [FFmpeg-devel] [PATCH] ffprobe: add -show_headers_first option

2016-09-18 Thread Stefano Sabatini
On date Saturday 2016-09-10 13:51:34 +0200, Nicolas George encoded: > Le tridi 23 fructidor, an CCXXIV, Stefano Sabatini a écrit : [...] > This issue of reading packets to extract information but not clutter the > output with them is the reason I suggested in my example >

Re: [FFmpeg-devel] [PATCH] lavd/opengl: use SDL2

2016-09-18 Thread Lukasz Marek
On 18.09.2016 10:04, Josh de Kock wrote: On 18/09/2016 05:51, Lukasz Marek wrote: W dniu niedziela, 18 września 2016 Lou Logan > napisał(a): On Sat, Sep 17, 2016, at 05:21 PM, Lukasz Marek wrote: On 18 September 2016 at 00:30,

Re: [FFmpeg-devel] [PATCH] avfilter/WIP: add nlmeans filter

2016-09-18 Thread Carl Eugen Hoyos
2016-09-18 13:36 GMT+02:00 Clément Bœsch : > Fixes Ticket #4910 > > TODO (before 1st pushed version): > - add chroma paramters (for patch size and research window) > - doc > - lavfi minor bump, Changelog > - GBRP Is this really important for the first version? Carl Eugen

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: refine EXT-X-BYTERANGE support for segments

2016-09-18 Thread Moritz Barsnick
On Sun, Sep 18, 2016 at 23:40:34 +0800, Steven Liu wrote: > +if (byterange_mode) { > +version = 4; > +sequence = byterange_mode ? 0 : sequence; What does the ternary if-then-else operation do here? Two lines above, byterange_mode was checked for !=0, how can it be anything

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: refine EXT-X-BYTERANGE support for segments

2016-09-18 Thread Steven Liu
2016-09-18 7:28 GMT+08:00 Steven Liu : > > > 2016-09-18 1:07 GMT+08:00 Michael Niedermayer : > >> On Sat, Sep 17, 2016 at 01:09:02PM +0800, Steven Liu wrote: >> [...] >> > @@ -867,6 +886,16 @@ static int hls_write_header(AVFormatContext *s) >> >

Re: [FFmpeg-devel] [PATCH] lavd/opengl: use SDL2

2016-09-18 Thread Lukasz Marek
On 18.09.2016 10:04, Josh de Kock wrote: On 18/09/2016 05:51, Lukasz Marek wrote: W dniu niedziela, 18 września 2016 Lou Logan > napisał(a): On Sat, Sep 17, 2016, at 05:21 PM, Lukasz Marek wrote: On 18 September 2016 at 00:30,

Re: [FFmpeg-devel] [PATCH] lavf: add ffprobe demuxer

2016-09-18 Thread Stefano Sabatini
On date Saturday 2016-09-17 18:42:35 +0200, Paul B Mahol encoded: > On 9/17/16, Stefano Sabatini wrote: > > On date Sunday 2016-09-04 23:25:56 +0200, Michael Niedermayer encoded: > >> On Sun, Sep 04, 2016 at 06:24:37PM +0200, Stefano Sabatini wrote: > >> > From: Nicolas George

Re: [FFmpeg-devel] [PATCH] avformat/utils: only call h264 decoder private function if h264 decoder is in use

2016-09-18 Thread Michael Niedermayer
On Sun, Sep 18, 2016 at 01:46:07PM +0200, Timo Rothenpieler wrote: > Fixes a crash when decoding with for example h264_cuvid, as > avpriv_h264_has_num_reorder_frames assumes the AVCodecContext->priv_data > to be a H264Context. > --- > libavformat/utils.c | 2 +- > 1 file changed, 1 insertion(+),

[FFmpeg-devel] [PATCH] avformat/utils: only call h264 decoder private function if h264 decoder is in use

2016-09-18 Thread Timo Rothenpieler
Fixes a crash when decoding with for example h264_cuvid, as avpriv_h264_has_num_reorder_frames assumes the AVCodecContext->priv_data to be a H264Context. --- libavformat/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index

[FFmpeg-devel] [PATCH] avfilter/WIP: add nlmeans filter

2016-09-18 Thread Clément Bœsch
Fixes Ticket #4910 TODO (before 1st pushed version): - add chroma paramters (for patch size and research window) - doc - lavfi minor bump, Changelog - GBRP TODO++ (after 1st version): - SIMD for compute_safe_ssd_integral_image - SIMD for final weighted averaging - smart parameters for block and

Re: [FFmpeg-devel] [GSoC] [PATCH 2/2] mlpenc: Working MLP/TrueHD encoder

2016-09-18 Thread Andy Furniss
Jai Luthra wrote: On Sat, Sep 17, 2016 at 05:07:28PM +0100, Andy Furniss wrote: Nice work, this is just a sort of related question really from a user who hasn't taken any notice of TrueHD for a few years. Last I looked I couldn't find much in the way of specs for TrueHD and noticed that the

Re: [FFmpeg-devel] [PATCH] Add CONTRIBUTING.md

2016-09-18 Thread Josh de Kock
On 18/09/2016 01:29, James Almer wrote: On 9/17/2016 8:42 PM, Josh de Kock wrote: TimothyGu (https://github.com/FFmpeg/FFmpeg/pull/153#issuecomment-143274708) suggested doing this a while ago, but it was never done. As pull requests seem to be still coming through, I thought I'd send a patch

Re: [FFmpeg-devel] [PATCH] lavd/opengl: use SDL2

2016-09-18 Thread Josh de Kock
On 18/09/2016 05:51, Lukasz Marek wrote: W dniu niedziela, 18 września 2016 Lou Logan > napisał(a): On Sat, Sep 17, 2016, at 05:21 PM, Lukasz Marek wrote: On 18 September 2016 at 00:30, Josh de Kock wrote: [...]