Re: [FFmpeg-devel] [PATCH] Fixed bug encountered when decoding interlaced video

2017-05-05 Thread Aaron Levinson
On 5/5/2017 2:26 AM, wm4 wrote: On Fri, 5 May 2017 01:11:17 -0700 Aaron Levinson wrote: As I said on IRC, I'm skeptic against this, but I'm also not sure whether I understand the situation. First, your change seems a bit fragile, and almost relies on coincidences. This

Re: [FFmpeg-devel] Added require fallback for libmfx in the case that pkg-config cannot find libmfx

2017-05-05 Thread Aaron Levinson
On 5/5/2017 4:50 AM, Michael Niedermayer wrote: > On Fri, May 05, 2017 at 11:36:05AM +0200, Hendrik Leppkes wrote: >> On Fri, May 5, 2017 at 9:57 AM, Clément Bœsch wrote: >>> On Fri, May 05, 2017 at 12:54:12AM -0700, Aaron Levinson wrote: >>> [...] > Back to your issue: you

Re: [FFmpeg-devel] [PATCH] libavformat/hls: Observe Set-Cookie headers

2017-05-05 Thread wm4
On Fri, 5 May 2017 20:55:05 -0400 Micah Galizia wrote: > Signed-off-by: Micah Galizia > --- > libavformat/hls.c | 12 ++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/libavformat/hls.c b/libavformat/hls.c > index

Re: [FFmpeg-devel] [PATCH] avcodec: Avoid splitting side data repeatedly

2017-05-05 Thread Michael Niedermayer
On Thu, May 04, 2017 at 12:41:49PM -0300, James Almer wrote: > On 5/4/2017 12:15 PM, Michael Niedermayer wrote: > > Fixes Timeout > > Fixes: 508/clusterfuzz-testcase-6245747678773248 > > > > Found-by: continuous fuzzing process > > https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg >

Re: [FFmpeg-devel] [PATCH] hevc_sei: add support for User Data Unregistered SEI messages

2017-05-05 Thread wm4
On Fri, 5 May 2017 18:59:00 -0300 James Almer wrote: > On 5/5/2017 6:23 PM, Kieran Kunhya wrote: > >> > >> > >> +if (strlen(user_data + 16) > 0) > >> +av_log(logctx, AV_LOG_DEBUG, "user data:\"%s\"\n", user_data + > >> 16); > >> > > > > Eugh, no, no, no. > >

Re: [FFmpeg-devel] [PATCH] Made minor changes to get the decklink avdevice code to build using Visual C++

2017-05-05 Thread Aaron Levinson
On 5/5/2017 4:57 PM, Marton Balint wrote: > > > On Fri, 5 May 2017, Aaron Levinson wrote: > >> On 4/16/2017 4:11 PM, Aaron Levinson wrote: >>> On 4/15/2017 6:13 AM, Aaron Levinson wrote: On 4/15/2017 4:19 AM, Marton Balint wrote: > > On Thu, 13 Apr 2017, Aaron Levinson wrote: >

Re: [FFmpeg-devel] [PATCH] libavformat/hls: Observe Set-Cookie headers

2017-05-05 Thread Micah Galizia
Hi, This is a simpler version of the other patch that still observes AVFMT_FLAG_CUSTOM_IO. Thanks in advance. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] libavformat/hls: Observe Set-Cookie headers

2017-05-05 Thread Micah Galizia
Signed-off-by: Micah Galizia --- libavformat/hls.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index bac53a4350..bda9abecfa 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -630,8 +630,16

Re: [FFmpeg-devel] [PATCH] avfilter: add arbitrary audio FIR filter

2017-05-05 Thread Muhammad Faiz
On Sat, May 6, 2017 at 2:30 AM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > configure| 2 + > doc/filters.texi | 10 + > libavfilter/Makefile | 1 + > libavfilter/af_afir.c| 484 >

[FFmpeg-devel] [PATCH 3/4] avcodec/srtdec: Check ff_htmlmarkup_to_ass() return code

2017-05-05 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/srtdec.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/libavcodec/srtdec.c b/libavcodec/srtdec.c index 862ab47645..ecc0801595 100644 --- a/libavcodec/srtdec.c +++ b/libavcodec/srtdec.c @@

[FFmpeg-devel] [PATCH 4/4] doc/build_system: Document how to build decoder fuzzer

2017-05-05 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- doc/build_system.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/build_system.txt b/doc/build_system.txt index 8c12e0e294..325a9e83d0 100644 --- a/doc/build_system.txt +++ b/doc/build_system.txt @@ -45,6 +45,9 @@

[FFmpeg-devel] [PATCH 2/4] avcodec/samidec: Check ff_htmlmarkup_to_ass() return code

2017-05-05 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/samidec.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libavcodec/samidec.c b/libavcodec/samidec.c index 16f3f58c1c..2620424750 100644 --- a/libavcodec/samidec.c +++ b/libavcodec/samidec.c @@

[FFmpeg-devel] [PATCH 1/4] avcodec/htmlsubtitles: Check for string truncation and return error

2017-05-05 Thread Michael Niedermayer
Fixes out of array access Fixes: 1354/clusterfuzz-testcase-minimized-5520132195483648 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/htmlsubtitles.c | 12 +---

Re: [FFmpeg-devel] [PATCH] avfilter: add arbitrary audio FIR filter

2017-05-05 Thread Muhammad Faiz
On Sat, May 6, 2017 at 2:33 AM, Paul B Mahol wrote: > On 5/5/17, Muhammad Faiz wrote: > Is pts handled correctly here? Seem it is not derived from input pts. > It can not be derived in any other way. >>> >>> Probably, at least, first pts

Re: [FFmpeg-devel] [PATCH] Made minor changes to get the decklink avdevice code to build using Visual C++

2017-05-05 Thread Marton Balint
On Fri, 5 May 2017, Aaron Levinson wrote: On 4/16/2017 4:11 PM, Aaron Levinson wrote: On 4/15/2017 6:13 AM, Aaron Levinson wrote: On 4/15/2017 4:19 AM, Marton Balint wrote: On Thu, 13 Apr 2017, Aaron Levinson wrote: On 4/13/2017 1:23 PM, Hendrik Leppkes wrote: [...] Ping, and in

[FFmpeg-devel] [PATCH] lavfi/avfiltergraph: only return EOF in avfilter_graph_request_oldest if all sinks EOFed

2017-05-05 Thread Marton Balint
Fixes a regression introduced in 32c59a115d3cc757676b5384a5ea44b5a7a7b872, becoming effective in 912969a33e313c57c906e87a7e2367b78a2160f4. Fixes trimmed output of ffmpeg -f lavfi -i "sine=d=0.01" -f lavfi -i "sine=d=1" -filter_complex "[0:a]anull[a1];[1:a]anull[a2]" -map "[a1]" -f null none -map

Re: [FFmpeg-devel] [PATCH] hevc_sei: add support for User Data Unregistered SEI messages

2017-05-05 Thread James Almer
On 5/5/2017 6:23 PM, Kieran Kunhya wrote: >> >> >> +if (strlen(user_data + 16) > 0) >> +av_log(logctx, AV_LOG_DEBUG, "user data:\"%s\"\n", user_data + >> 16); >> > > Eugh, no, no, no. > Some encoders put random junk in here and my terminal goes crazy. > The h264 stuff is bad as well

[FFmpeg-devel] libavcodec/h264_sei: Don't log random user data.

2017-05-05 Thread Kieran Kunhya
From d43c0366d4ba128772dc7909152f4e9635f269cb Mon Sep 17 00:00:00 2001 From: Kieran Kunhya Date: Fri, 5 May 2017 14:29:59 -0700 Subject: [PATCH] libavcodec/h264_sei: Don't log random user data. This prevents terminal junk. --- libavcodec/h264_sei.c | 3 --- 1 file changed, 3

Re: [FFmpeg-devel] [PATCH] hevc_sei: add support for User Data Unregistered SEI messages

2017-05-05 Thread Kieran Kunhya
> > > +if (strlen(user_data + 16) > 0) > +av_log(logctx, AV_LOG_DEBUG, "user data:\"%s\"\n", user_data + > 16); > Eugh, no, no, no. Some encoders put random junk in here and my terminal goes crazy. The h264 stuff is bad as well but libav people were so insistent this stuff was

[FFmpeg-devel] [PATCH] hevc_sei: add support for User Data Unregistered SEI messages

2017-05-05 Thread James Almer
Based on h264_sei code. Only print the user data for now. Signed-off-by: James Almer --- libavcodec/hevc_sei.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/libavcodec/hevc_sei.c b/libavcodec/hevc_sei.c index c5054bfaab..1d40ed9371 100644

Re: [FFmpeg-devel] [PATCH v2 0/9] Removing HEVCContext depencencies

2017-05-05 Thread James Almer
On 5/5/2017 5:06 PM, Aaron Levinson wrote: > The entire patch set LGTM. > > Aaron Levinson Pushed then, thanks. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] libavcodec/exr : simplify reorder_pixels

2017-05-05 Thread Martin Vignali
Hello, in attach a patch who simplify the reorder_pixels func reorder_pixels is call by rle_uncompress and zip_uncompress with size == uncompress_size uncompress_size is a multiple of 2 (because exr store data in half, float, or uint32) In the decoder uncompress_size is a multiple of

Re: [FFmpeg-devel] libavcodec/exr : cosmetics : rename variable

2017-05-05 Thread Martin Vignali
2017-03-25 13:08 GMT+01:00 Martin Vignali : > > Hello, > > In attach a patch who rename tile variable to better follow ffmpeg coding > style > Ping for apply ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH v2 0/9] Removing HEVCContext depencencies

2017-05-05 Thread Aaron Levinson
The entire patch set LGTM. Aaron Levinson On 5/3/2017 6:41 PM, James Almer wrote: On 5/3/2017 9:39 PM, Aaron Levinson wrote: James, Can you document which patches depend on other patches in this patch set to make it easier to review this patch set in chunks? Patch 2 depends on 1. Patches

Re: [FFmpeg-devel] [PATCH] avfilter: add arbitrary audio FIR filter

2017-05-05 Thread Paul B Mahol
On 5/5/17, Muhammad Faiz wrote: Is pts handled correctly here? Seem it is not derived from input pts. >>> >>> It can not be derived in any other way. >> >> Probably, at least, first pts should be derived from input pts. >> Also, is time_base always 1/sample_rate? >> >>

Re: [FFmpeg-devel] [PATCH] avfilter: add arbitrary audio FIR filter

2017-05-05 Thread Paul B Mahol
On 5/3/17, Moritz Barsnick wrote: > On Mon, May 01, 2017 at 10:30:20 +0200, Paul B Mahol wrote: >> +.name = "afirfilter", > > Does a filter have any reason to have "filter" in its name? It seems > unusual. > Renamed. ___

[FFmpeg-devel] [PATCH] avfilter: add arbitrary audio FIR filter

2017-05-05 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- configure| 2 + doc/filters.texi | 10 + libavfilter/Makefile | 1 + libavfilter/af_afir.c| 484 +++ libavfilter/allfilters.c | 1 + 5 files changed, 498

Re: [FFmpeg-devel] [RFC]lavu/timecode: Increase AV_TIMECODE_STR_SIZE.

2017-05-05 Thread Marton Balint
On Fri, 5 May 2017, Carl Eugen Hoyos wrote: 2017-05-05 9:57 GMT+02:00 Aaron Levinson : You hadn't previously indicated that the warnings disappeared when 23 is used, so I was operating based on the warning text, which said that the output text could consume as much as

Re: [FFmpeg-devel] [PATCH v14] avformat/dashdec: add dash demuxer base version

2017-05-05 Thread Ricardo Constantino
I've actually tested the patch with FFmpeg/mpv now with a few .mpd from Youtube (non-segmented), Vimeo and Facebook and it seems to work mostly fine. You can obtain URLs to these by using youtube-dl json output together with jq cli tool, ex: working: ffmpeg -i $(youtube-dl -J

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

2017-05-05 Thread Kieran Kunhya
> > Well, this instance is exactly a case like that. If the alignment > requirements are not documented, then an application can do things in a > way similar to take_samples() right now, and result in a crash. And > there is no blaming the application, it followed the documentation. > > The bug is

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

2017-05-05 Thread Nicolas George
Le sextidi 16 floréal, an CCXXV, Hendrik Leppkes a écrit : > Blocking crash fixes on silly arguments doesn't help anyone. Send a > doc update yourself or stop blocking valid crash fixes. > Every ffmpeg developer knows that we have alignment requirements, > trying to badger someone into writing

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

2017-05-05 Thread James Almer
On 5/5/2017 1:22 PM, Nicolas George wrote: > Le sextidi 16 floréal, an CCXXV, Muhammad Faiz a écrit : >> But if documentation >> says that data should be aligned to 4-bytes but I align it to >> 32-bytes, then there are no violations at all. So

Re: [FFmpeg-devel] [PATCH] lavf/utils: bail early if we don't see any packets in an MPEGTS stream

2017-05-05 Thread Michael Niedermayer
On Tue, May 02, 2017 at 10:14:35PM -0500, Rodger Combs wrote: > --- > libavformat/utils.c | 22 -- > 1 file changed, 20 insertions(+), 2 deletions(-) i tested this a bit and didnt find a file that this breaks [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

2017-05-05 Thread Nicolas George
Le sextidi 16 floréal, an CCXXV, Muhammad Faiz a écrit : > But if documentation > says that data should be aligned to 4-bytes but I align it to > 32-bytes, then there are no violations at all. So what's wrong with > this patch? Useless code

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

2017-05-05 Thread Nicolas George
Le sextidi 16 floréal, an CCXXV, Hendrik Leppkes a écrit : > Blocking crash fixes on silly arguments doesn't help anyone. Send a My argument is not silly: the code to align the frame will be needed, but NOT HERE. > Every ffmpeg developer knows that we have alignment requirements, Well, I do

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

2017-05-05 Thread Hendrik Leppkes
On Fri, May 5, 2017 at 3:38 PM, Nicolas George wrote: > Le sextidi 16 floréal, an CCXXV, Paul B Mahol a écrit : >> There is crash reproducible with filters and not just libmp3lame. > > Then these filters are bogus since they are making invalid assumptions > about their inputs. Or

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

2017-05-05 Thread Muhammad Faiz
On Fri, May 5, 2017 at 5:00 PM, Nicolas George wrote: > Le sextidi 16 floréal, an CCXXV, Muhammad Faiz a écrit : >> This should fix Ticket6349. >> Since 383057f8e744efeaaa3648a59bc577b25b055835, framequeue may >> generate unaligned frame data. >> >> Signed-off-by: Muhammad Faiz

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

2017-05-05 Thread Nicolas George
Le sextidi 16 floréal, an CCXXV, Paul B Mahol a écrit : > There is crash reproducible with filters and not just libmp3lame. Then these filters are bogus since they are making invalid assumptions about their inputs. Or quote the docs saying otherwise.

Re: [FFmpeg-devel] [PATCH] avfilter: add arbitrary audio FIR filter

2017-05-05 Thread Muhammad Faiz
On Wed, May 3, 2017 at 4:12 PM, Muhammad Faiz wrote: > On Wed, May 3, 2017 at 1:47 AM, Paul B Mahol wrote: >> On 5/2/17, Muhammad Faiz wrote: >>> On Mon, May 1, 2017 at 3:30 PM, Paul B Mahol wrote: Signed-off-by: Paul

Re: [FFmpeg-devel] Added require fallback for libmfx in the case that pkg-config cannot find libmfx

2017-05-05 Thread Michael Niedermayer
On Fri, May 05, 2017 at 02:17:40PM +0200, wm4 wrote: > On Fri, 5 May 2017 14:12:56 +0200 > Michael Niedermayer wrote: > > > On Fri, May 05, 2017 at 09:42:51AM +0200, Clément Bœsch wrote: > > > On Fri, May 05, 2017 at 12:11:27AM -0700, Aaron Levinson wrote: > > > > On

Re: [FFmpeg-devel] [RFC]lavu/opt: Use && instead of * in boolean expression

2017-05-05 Thread Tobias Rapp
On 05.05.2017 09:26, Carl Eugen Hoyos wrote: 2017-05-05 3:12 GMT+02:00 Aaron Levinson : On 5/4/2017 4:32 PM, Carl Eugen Hoyos wrote: Hi! It may be better to disable the warning. Carl Eugen -num = den ? num * intnum / den : (num * intnum ? INFINITY : NAN); +

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: fix resource leak

2017-05-05 Thread wm4
On Sat, 6 May 2017 04:06:03 +0800 Steven Liu wrote: > Fixes Coverity CID: 1405453 > > Signed-off-by: Steven Liu > --- > libavformat/matroskadec.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git

Re: [FFmpeg-devel] Added require fallback for libmfx in the case that pkg-config cannot find libmfx

2017-05-05 Thread wm4
On Fri, 5 May 2017 14:12:56 +0200 Michael Niedermayer wrote: > On Fri, May 05, 2017 at 09:42:51AM +0200, Clément Bœsch wrote: > > On Fri, May 05, 2017 at 12:11:27AM -0700, Aaron Levinson wrote: > > > On 4/19/2017 10:43 AM, Aaron Levinson wrote: > > > > On 4/14/2017

Re: [FFmpeg-devel] Added require fallback for libmfx in the case that pkg-config cannot find libmfx

2017-05-05 Thread Michael Niedermayer
On Fri, May 05, 2017 at 09:42:51AM +0200, Clément Bœsch wrote: > On Fri, May 05, 2017 at 12:11:27AM -0700, Aaron Levinson wrote: > > On 4/19/2017 10:43 AM, Aaron Levinson wrote: > > > On 4/14/2017 6:51 PM, Aaron Levinson wrote: > > >> From e0c73c054add0137901d0bf7a7893e42e7e566c8 Mon Sep 17

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: fix resource leak

2017-05-05 Thread Steven Liu
2017-05-05 20:06 GMT+08:00 wm4 : > On Fri, 5 May 2017 13:59:26 +0200 > Hendrik Leppkes wrote: > > > On Fri, May 5, 2017 at 9:54 PM, Steven Liu wrote: > > > Fixes Coverity CID: 1405453 > > > > > > Signed-off-by: Steven Liu

[FFmpeg-devel] [PATCH] avformat/matroskadec: fix resource leak

2017-05-05 Thread Steven Liu
Fixes Coverity CID: 1405453 Signed-off-by: Steven Liu --- libavformat/matroskadec.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index 9e2c9bd..5282ef7 100644 --- a/libavformat/matroskadec.c

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: fix resource leak

2017-05-05 Thread wm4
On Fri, 5 May 2017 13:59:26 +0200 Hendrik Leppkes wrote: > On Fri, May 5, 2017 at 9:54 PM, Steven Liu wrote: > > Fixes Coverity CID: 1405453 > > > > Signed-off-by: Steven Liu > > --- > > libavformat/matroskadec.c |1 + > > 1

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: fix resource leak

2017-05-05 Thread Steven Liu
2017-05-05 19:59 GMT+08:00 Hendrik Leppkes : > On Fri, May 5, 2017 at 9:54 PM, Steven Liu wrote: > > Fixes Coverity CID: 1405453 > > > > Signed-off-by: Steven Liu > > --- > > libavformat/matroskadec.c |1 + > > 1 files

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: fix resource leak

2017-05-05 Thread Hendrik Leppkes
On Fri, May 5, 2017 at 9:54 PM, Steven Liu wrote: > Fixes Coverity CID: 1405453 > > Signed-off-by: Steven Liu > --- > libavformat/matroskadec.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/libavformat/matroskadec.c

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

2017-05-05 Thread Paul B Mahol
On 5/5/17, Nicolas George wrote: > Le sextidi 16 floreal, an CCXXV, Paul B Mahol a ecrit : >> Come on, I will report this to the committe. > > If you have something useful to say, please do so. There is crash reproducible with filters and not just libmp3lame.

[FFmpeg-devel] [PATCH] avformat/matroskadec: fix resource leak

2017-05-05 Thread Steven Liu
Fixes Coverity CID: 1405453 Signed-off-by: Steven Liu --- libavformat/matroskadec.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index 9e2c9bd..5282ef7 100644 --- a/libavformat/matroskadec.c

Re: [FFmpeg-devel] Added require fallback for libmfx in the case that pkg-config cannot find libmfx

2017-05-05 Thread Michael Niedermayer
On Fri, May 05, 2017 at 11:36:05AM +0200, Hendrik Leppkes wrote: > On Fri, May 5, 2017 at 9:57 AM, Clément Bœsch wrote: > > On Fri, May 05, 2017 at 12:54:12AM -0700, Aaron Levinson wrote: > > [...] > >> > Back to your issue: you should fix the .pc in the upstream project, this > >> >

Re: [FFmpeg-devel] [RFC]lavu/opt: Use && instead of * in boolean expression

2017-05-05 Thread Michael Niedermayer
On Fri, May 05, 2017 at 09:26:05AM +0200, Carl Eugen Hoyos wrote: > 2017-05-05 3:12 GMT+02:00 Aaron Levinson : > > On 5/4/2017 4:32 PM, Carl Eugen Hoyos wrote: > >> Hi! > >> > >> It may be better to disable the warning. > >> > >> Carl Eugen > >> > >> -num = den ? num

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

2017-05-05 Thread Nicolas George
Le sextidi 16 floréal, an CCXXV, Paul B Mahol a écrit : > Come on, I will report this to the committe. If you have something useful to say, please do so. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

2017-05-05 Thread Paul B Mahol
On 5/5/17, Nicolas George wrote: > Le sextidi 16 floreal, an CCXXV, Muhammad Faiz a ecrit : >> This should fix Ticket6349. >> Since 383057f8e744efeaaa3648a59bc577b25b055835, framequeue may >> generate unaligned frame data. >> >> Signed-off-by: Muhammad Faiz >>

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

2017-05-05 Thread wm4
On Fri, 5 May 2017 12:00:02 +0200 Nicolas George wrote: > Le sextidi 16 floréal, an CCXXV, Muhammad Faiz a écrit : > > This should fix Ticket6349. > > Since 383057f8e744efeaaa3648a59bc577b25b055835, framequeue may > > generate unaligned frame data. > > > > Signed-off-by:

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

2017-05-05 Thread Nicolas George
Le sextidi 16 floréal, an CCXXV, Muhammad Faiz a écrit : > This should fix Ticket6349. > Since 383057f8e744efeaaa3648a59bc577b25b055835, framequeue may > generate unaligned frame data. > > Signed-off-by: Muhammad Faiz > --- > libavfilter/avfilter.c | 26

Re: [FFmpeg-devel] Added require fallback for libmfx in the case that pkg-config cannot find libmfx

2017-05-05 Thread Hendrik Leppkes
On Fri, May 5, 2017 at 9:57 AM, Clément Bœsch wrote: > On Fri, May 05, 2017 at 12:54:12AM -0700, Aaron Levinson wrote: > [...] >> > Back to your issue: you should fix the .pc in the upstream project, this >> > is the correct fix. >> >> The "upstream project" in this case is the Intel

Re: [FFmpeg-devel] [PATCH] Fixed bug encountered when decoding interlaced video

2017-05-05 Thread wm4
On Fri, 5 May 2017 01:11:17 -0700 Aaron Levinson wrote: > > As I said on IRC, I'm skeptic against this, but I'm also not sure > > whether I understand the situation. > > > > First, your change seems a bit fragile, and almost relies on > > coincidences. This could easily

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: support TAG span multiple lines when parse playlist

2017-05-05 Thread Steven Liu
2017-05-06 0:50 GMT+08:00 Steven Liu : > refer to: https://developer.apple.com/library/content/technotes/ > tn2288/_index.html > > support to parse the EXT-X-KEY span multiple lines: > #EXTM3U > #EXT-X-VERSION:3 > #EXT-X-TARGETDURATION:10 > #EXT-X-MEDIA-SEQUENCE:0 >

[FFmpeg-devel] [PATCH] avformat/hlsenc: support TAG span multiple lines when parse playlist

2017-05-05 Thread Steven Liu
refer to: https://developer.apple.com/library/content/technotes/tn2288/_index.html support to parse the EXT-X-KEY span multiple lines: #EXTM3U #EXT-X-VERSION:3 #EXT-X-TARGETDURATION:10 #EXT-X-MEDIA-SEQUENCE:0 #EXT-X-KEY:METHOD=AES-128,URI="/file.key", \

[FFmpeg-devel] rtsp rtp/rtcp sync

2017-05-05 Thread michael stuur
I’ve some problems with synchronizing rtp streams. In rtsp.c in handle rtp_info (line 1017) base timestamp is set: if (!strcmp(rtsp_st->control_url, url)) { rtpctx->base_timestamp = rtptime; break; } Is there any reason to make this statement, since I

Re: [FFmpeg-devel] Added require fallback for libmfx in the case that pkg-config cannot find libmfx

2017-05-05 Thread Aaron Levinson
On 5/5/2017 12:57 AM, Clément Bœsch wrote: On Fri, May 05, 2017 at 12:54:12AM -0700, Aaron Levinson wrote: [...] Back to your issue: you should fix the .pc in the upstream project, this is the correct fix. The "upstream project" in this case is the Intel Media SDK. This is not an open source

Re: [FFmpeg-devel] [PATCH] Fixed bug encountered when decoding interlaced video

2017-05-05 Thread Aaron Levinson
On 5/5/2017 12:55 AM, wm4 wrote: On Thu, 4 May 2017 23:46:30 -0700 Aaron Levinson wrote: On 4/12/2017 6:08 PM, Aaron Levinson wrote: On 3/26/2017 10:34 AM, Aaron Levinson wrote: On 3/26/2017 4:41 AM, Matthias Hunstock wrote: Am 26.03.2017 um 11:50 schrieb Aaron

Re: [FFmpeg-devel] [RFC]lavu/timecode: Increase AV_TIMECODE_STR_SIZE.

2017-05-05 Thread Carl Eugen Hoyos
2017-05-05 9:57 GMT+02:00 Aaron Levinson : > You hadn't previously indicated that the warnings disappeared > when 23 is used, so I was operating based on the warning text, > which said that the output text could consume as much as 32 > bytes. It seems odd that the warning

Re: [FFmpeg-devel] [RFC]lavu/timecode: Increase AV_TIMECODE_STR_SIZE.

2017-05-05 Thread Carl Eugen Hoyos
2017-05-05 9:57 GMT+02:00 Aaron Levinson : How can I reproduce / test your findings? >>> >>> #define AV_TIMECODE_STR_SIZE 32 or 33 and confirm >>> that gcc 7 warnings go away. >> >> Of course! >> Since the warnings go away with 23, they also go away with 32. >> I just

Re: [FFmpeg-devel] Added require fallback for libmfx in the case that pkg-config cannot find libmfx

2017-05-05 Thread Clément Bœsch
On Fri, May 05, 2017 at 12:54:12AM -0700, Aaron Levinson wrote: [...] > > Back to your issue: you should fix the .pc in the upstream project, this > > is the correct fix. > > The "upstream project" in this case is the Intel Media SDK. This is not an > open source project, and developers get it

Re: [FFmpeg-devel] [RFC]lavu/timecode: Increase AV_TIMECODE_STR_SIZE.

2017-05-05 Thread Aaron Levinson
On 5/5/2017 12:44 AM, Carl Eugen Hoyos wrote: 2017-05-05 9:42 GMT+02:00 Aaron Levinson : On 5/5/2017 12:20 AM, Carl Eugen Hoyos wrote: 2017-05-05 3:29 GMT+02:00 Aaron Levinson : On 5/4/2017 4:27 PM, Carl Eugen Hoyos wrote: Hi! Attached patch

Re: [FFmpeg-devel] [PATCH] Fixed bug encountered when decoding interlaced video

2017-05-05 Thread wm4
On Thu, 4 May 2017 23:46:30 -0700 Aaron Levinson wrote: > On 4/12/2017 6:08 PM, Aaron Levinson wrote: > > On 3/26/2017 10:34 AM, Aaron Levinson wrote: > >> On 3/26/2017 4:41 AM, Matthias Hunstock wrote: > >>> Am 26.03.2017 um 11:50 schrieb Aaron Levinson: > When

Re: [FFmpeg-devel] [RFC]lavu/timecode: Increase AV_TIMECODE_STR_SIZE.

2017-05-05 Thread Clément Bœsch
On Fri, May 05, 2017 at 09:44:46AM +0200, Carl Eugen Hoyos wrote: > 2017-05-05 9:42 GMT+02:00 Aaron Levinson : > > On 5/5/2017 12:20 AM, Carl Eugen Hoyos wrote: > >> > >> 2017-05-05 3:29 GMT+02:00 Aaron Levinson : > >>> > >>> On 5/4/2017 4:27 PM, Carl

Re: [FFmpeg-devel] Added require fallback for libmfx in the case that pkg-config cannot find libmfx

2017-05-05 Thread Aaron Levinson
On 5/5/2017 12:42 AM, Clément Bœsch wrote: On Fri, May 05, 2017 at 12:11:27AM -0700, Aaron Levinson wrote: On 4/19/2017 10:43 AM, Aaron Levinson wrote: On 4/14/2017 6:51 PM, Aaron Levinson wrote: From e0c73c054add0137901d0bf7a7893e42e7e566c8 Mon Sep 17 00:00:00 2001 From: Aaron Levinson

Re: [FFmpeg-devel] Added require fallback for libmfx in the case that pkg-config cannot find libmfx

2017-05-05 Thread wm4
On Fri, 5 May 2017 09:42:51 +0200 Clément Bœsch wrote: > On Fri, May 05, 2017 at 12:11:27AM -0700, Aaron Levinson wrote: > > On 4/19/2017 10:43 AM, Aaron Levinson wrote: > > > On 4/14/2017 6:51 PM, Aaron Levinson wrote: > > >> From e0c73c054add0137901d0bf7a7893e42e7e566c8 Mon

Re: [FFmpeg-devel] Added require fallback for libmfx in the case that pkg-config cannot find libmfx

2017-05-05 Thread Clément Bœsch
On Fri, May 05, 2017 at 12:11:27AM -0700, Aaron Levinson wrote: > On 4/19/2017 10:43 AM, Aaron Levinson wrote: > > On 4/14/2017 6:51 PM, Aaron Levinson wrote: > >> From e0c73c054add0137901d0bf7a7893e42e7e566c8 Mon Sep 17 00:00:00 2001 > >> From: Aaron Levinson > >> Date:

Re: [FFmpeg-devel] [RFC]lavu/timecode: Increase AV_TIMECODE_STR_SIZE.

2017-05-05 Thread Aaron Levinson
On 5/5/2017 12:20 AM, Carl Eugen Hoyos wrote: 2017-05-05 3:29 GMT+02:00 Aaron Levinson : On 5/4/2017 4:27 PM, Carl Eugen Hoyos wrote: Hi! Attached patch is one possibility to fix the following warning with gcc 7: libavutil/timecode.c: In function

Re: [FFmpeg-devel] [PATCH] Made minor changes to get the decklink avdevice code to build using Visual C++

2017-05-05 Thread Aaron Levinson
On 4/16/2017 4:11 PM, Aaron Levinson wrote: > On 4/15/2017 6:13 AM, Aaron Levinson wrote: >> On 4/15/2017 4:19 AM, Marton Balint wrote: >>> >>> On Thu, 13 Apr 2017, Aaron Levinson wrote: >>> On 4/13/2017 1:23 PM, Hendrik Leppkes wrote: >>> [...] Ping, and in addition, I've provided a new

Re: [FFmpeg-devel] [RFC]lavu/timecode: Increase AV_TIMECODE_STR_SIZE.

2017-05-05 Thread Carl Eugen Hoyos
2017-05-05 3:29 GMT+02:00 Aaron Levinson : > On 5/4/2017 4:27 PM, Carl Eugen Hoyos wrote: >> >> Hi! >> >> Attached patch is one possibility to fix the following warning with gcc 7: >> libavutil/timecode.c: In function ‘av_timecode_make_string’: >> libavutil/timecode.c:103:60:

Re: [FFmpeg-devel] [RFC]lavu/opt: Use && instead of * in boolean expression

2017-05-05 Thread Carl Eugen Hoyos
2017-05-05 3:12 GMT+02:00 Aaron Levinson : > On 5/4/2017 4:32 PM, Carl Eugen Hoyos wrote: >> Hi! >> >> It may be better to disable the warning. >> >> Carl Eugen >> >> -num = den ? num * intnum / den : (num * intnum ? INFINITY : NAN); >> +num = den ? num *

Re: [FFmpeg-devel] Added require fallback for libmfx in the case that pkg-config cannot find libmfx

2017-05-05 Thread Carl Eugen Hoyos
2017-05-05 9:11 GMT+02:00 Aaron Levinson : > And again. This patch is pretty straightforward, and considering that > this approach was deemed suitable for libx264, I don't see why there > would be any issue with it being applied to libmfx as well. That's exactly what I

Re: [FFmpeg-devel] Added require fallback for libmfx in the case that pkg-config cannot find libmfx

2017-05-05 Thread Aaron Levinson
On 4/19/2017 10:43 AM, Aaron Levinson wrote: > On 4/14/2017 6:51 PM, Aaron Levinson wrote: >> From e0c73c054add0137901d0bf7a7893e42e7e566c8 Mon Sep 17 00:00:00 2001 >> From: Aaron Levinson >> Date: Fri, 14 Apr 2017 18:38:37 -0700 >> Subject: [PATCH] Added require fallback

Re: [FFmpeg-devel] [PATCH] Enhanced configure and Makefile to copy .pdb files to bindir for MSVC builds for make install

2017-05-05 Thread Aaron Levinson
On 4/14/2017 6:27 PM, Aaron Levinson wrote: From 1059473c449c3079f03461bb42c2d3cc21d1b2c1 Mon Sep 17 00:00:00 2001 From: Aaron Levinson Date: Fri, 14 Apr 2017 18:14:21 -0700 Subject: [PATCH] Enhanced configure and Makefile to copy .pdb files to bindir for MSVC builds for

Re: [FFmpeg-devel] [PATCH] Fixed bug encountered when decoding interlaced video

2017-05-05 Thread Aaron Levinson
On 4/12/2017 6:08 PM, Aaron Levinson wrote: > On 3/26/2017 10:34 AM, Aaron Levinson wrote: >> On 3/26/2017 4:41 AM, Matthias Hunstock wrote: >>> Am 26.03.2017 um 11:50 schrieb Aaron Levinson: When using the following command to play back either file: ffmpeg -i -f decklink -pix_fmt

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-05-05 Thread Muhammad Faiz
On Fri, May 5, 2017 at 3:15 AM, Kyle Swanson wrote: > Hi, > > On Tue, May 2, 2017 at 12:18 PM, wm4 wrote: >> On Tue, 2 May 2017 16:16:35 +0200 >> Nicolas George wrote: >> >>> Le duodi 12 floréal, an CCXXV, Paul B Mahol a écrit : >>> > This is

[FFmpeg-devel] [PATCH] avfilter: align data frame when needed

2017-05-05 Thread Muhammad Faiz
This should fix Ticket6349. Since 383057f8e744efeaaa3648a59bc577b25b055835, framequeue may generate unaligned frame data. Signed-off-by: Muhammad Faiz --- libavfilter/avfilter.c | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git