Re: [FFmpeg-devel] [PATCH] Fixed bug encountered when decoding interlaced video

On 5/12/2017 5:51 PM, Michael Niedermayer wrote: On Fri, May 12, 2017 at 01:19:43PM -0700, Aaron Levinson wrote: On 5/9/2017 11:56 AM, Michael Niedermayer wrote: On Thu, May 04, 2017 at 11:46:30PM -0700, Aaron Levinson wrote: I've provided a new version of the patch. When I created the

Re: [FFmpeg-devel] [PATCH] Fixed bug encountered when decoding interlaced video

On Fri, May 12, 2017 at 01:19:43PM -0700, Aaron Levinson wrote: > On 5/9/2017 11:56 AM, Michael Niedermayer wrote: > >On Thu, May 04, 2017 at 11:46:30PM -0700, Aaron Levinson wrote: > >> > >>I've provided a new version of the patch. When I created the first version > >>of the patch on March

Re: [FFmpeg-devel] [PATCH] avcodec/avpacket: allow only one element per type in packet side data

On 5/12/2017 6:27 PM, Michael Niedermayer wrote: > On Fri, May 12, 2017 at 01:58:27PM -0300, James Almer wrote: >> It was never meant to do otherwise, as av_packet_get_side_data() returns the >> first >> entry it finds of a given type. >> >> Based on code from libavformat's

Re: [FFmpeg-devel] libavcodec/exr : cosmetics : rename variable

On Sat, Mar 25, 2017 at 01:08:39PM +0100, Martin Vignali wrote: > Hello, > > In attach a patch who rename tile variable to better follow ffmpeg coding > style > > > Martin > > > -- > Martin Vignali > Jokyo Images > 18 rue du Transvaal > 69008 Lyon > 06 99 89 33 30 >

Re: [FFmpeg-devel] [PATCH] avcodec/avpacket: allow only one element per type in packet side data

On Fri, May 12, 2017 at 01:58:27PM -0300, James Almer wrote: > It was never meant to do otherwise, as av_packet_get_side_data() returns the > first > entry it finds of a given type. > > Based on code from libavformat's av_stream_add_side_data(). > > Signed-off-by: James Almer

Re: [FFmpeg-devel] [PATCH] avcodec/xpmdec: Fix multiple pointer/memory issues

On Fri, May 12, 2017 at 09:13:51PM +0200, Paul B Mahol wrote: > On 5/12/17, Paul B Mahol wrote: > > On 5/12/17, Michael Niedermayer wrote: > >> On Fri, May 12, 2017 at 03:29:52PM +0200, Paul B Mahol wrote: > >>> On 5/12/17, Michael Niedermayer

Re: [FFmpeg-devel] [PATCH] avcodec/xpmdec: Fix multiple pointer/memory issues

On Fri, May 12, 2017 at 08:58:52PM +0200, Paul B Mahol wrote: > On 5/12/17, Michael Niedermayer wrote: > > On Fri, May 12, 2017 at 03:29:52PM +0200, Paul B Mahol wrote: > >> On 5/12/17, Michael Niedermayer wrote: > >> > On Thu, May 11, 2017 at

Re: [FFmpeg-devel] [PATCH] lavf/mov: make invalid mdhd time_scale default to 1 instead of erroring out

On Thu, May 11, 2017 at 04:33:50PM +0200, Matthieu Bouron wrote: > Some samples have their metadata track time_scale incorrectly set to 0 > and the check introduced by a398f054fdb9b0f0b5a91c231fba6ce014143f71 > prevents playback of those samples. Setting the time_scale to 1 fixes > playback. > ---

[FFmpeg-devel] [PATCH 2/2] ffmpeg: Made execution of reap_filters() more deterministic with respect to when headers are written

Purpose: Made execution of reap_filters() more deterministic with respect to when headers are written in relationship with the initialization of output streams and the processing of input audio and/or video frames. This change fixes a bug in ffmpeg encountered when decoding interlaced video. In

[FFmpeg-devel] [PATCH 1/2] ffmpeg: Separated check_init_output_file() from init_output_stream()

Purpose: Separated the call to check_init_output_file() from init_output_stream(), and now check_init_output_file() is called by the parent after calling init_output_stream(). Additionally, moved some static function declarations to the beginning of the file. Signed-off-by: Aaron Levinson

Re: [FFmpeg-devel] [PATCH 1/2] ffmpeg: Separated check_init_output_file() from, init_output_stream()

Please disregard--I messed up the subject. I'll send a new one. Aaron Levinson On 5/12/2017 1:22 PM, Aaron Levinson wrote: Purpose: Separated the call to check_init_output_file() from init_output_stream(), and now check_init_output_file() is called by the parent after calling

[FFmpeg-devel] [PATCH 1/2] ffmpeg: Separated check_init_output_file() from, init_output_stream()

Purpose: Separated the call to check_init_output_file() from init_output_stream(), and now check_init_output_file() is called by the parent after calling init_output_stream(). Additionally, moved some static function declarations to the beginning of the file. Signed-off-by: Aaron Levinson

Re: [FFmpeg-devel] [PATCH] Fixed bug encountered when decoding interlaced video

On 5/9/2017 11:56 AM, Michael Niedermayer wrote: On Thu, May 04, 2017 at 11:46:30PM -0700, Aaron Levinson wrote: I've provided a new version of the patch. When I created the first version of the patch on March 26th, this was the first patch that I submitted to ffmpeg, and some aspects were

Re: [FFmpeg-devel] [PATCH V2] lavc/vaapi_encode_h264: Enable MB rate control

On Fri, May 12, 2017 at 02:27:45PM +0800, Jun Zhao wrote: > V2: - Refine the name/value type to mb_rate_control/bool. > - Only supported GEN9+ (SKL/APL/KBL/...) > - i965 driver default use frame-level rate control algorithm (generate > the QP for each frame), > when enable

Re: [FFmpeg-devel] [PATCH] avcodec/xpmdec: Fix multiple pointer/memory issues

On 5/12/17, Nicolas George wrote: > Le tridi 23 floreal, an CCXXV, Paul B Mahol a ecrit : >> Because I assumed packets are padded with zeroes. > > Because you chose to write quick-and-dirty instead of robust. Thank you. ___

Re: [FFmpeg-devel] [PATCH] avcodec/xpmdec: Fix multiple pointer/memory issues

Le tridi 23 floréal, an CCXXV, Paul B Mahol a écrit : > Because I assumed packets are padded with zeroes. Because you chose to write quick-and-dirty instead of robust. Regards, -- Nicolas George signature.asc Description: Digital signature ___

[FFmpeg-devel] [PATCH 3/3] avfilter/scale_cuda: add CUDA scale filter

From: Yogender Gupta --- libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_scale_cuda.c | 555 +++ libavfilter/vf_scale_cuda.cu | 212 + 4 files changed, 769 insertions(+)

[FFmpeg-devel] [PATCH 2/3] build: add support for building .cu files via nvcc

Original work by Yogender Gupta --- .gitignore | 2 ++ Makefile | 2 ++ compat/cuda/ptx2c.sh | 35 +++ configure| 24 +++- ffbuild/common.mak | 15 --- 5 files changed, 74

[FFmpeg-devel] [PATCH 1/3 fixed] configure: add cuda-sdk for things requiring full CUDA sdk

--- configure | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 5ae5227868..8d67838aab 100755 --- a/configure +++ b/configure @@ -297,6 +297,7 @@ External library support: The following libraries provide various hardware acceleration

Re: [FFmpeg-devel] [PATCH 1/3] configure: add cuda-sdk for things requiring full CUDA sdk

I can also try re-sending the series, but I don't know anything I could potentially do different. Probably because it's missing https://github.com/BtbN/FFmpeg/commit/5048e1159a6f5f5d9cf4cbd78535bc73da6b32bc which modifies configure as well, and generates a conflict that git am can't work around

Re: [FFmpeg-devel] [PATCH 1/3] configure: add cuda-sdk for things requiring full CUDA sdk

On 5/12/2017 4:28 PM, Timo Rothenpieler wrote: > Am 12.05.2017 um 20:48 schrieb Michael Niedermayer: >> On Thu, May 11, 2017 at 10:59:19PM +0200, Timo Rothenpieler wrote: >>> --- >>> configure | 6 -- >>> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> This doesnt apply so i cant test

Re: [FFmpeg-devel] [PATCH 1/3] configure: add cuda-sdk for things requiring full CUDA sdk

Am 12.05.2017 um 20:48 schrieb Michael Niedermayer: On Thu, May 11, 2017 at 10:59:19PM +0200, Timo Rothenpieler wrote: --- configure | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) This doesnt apply so i cant test this or dependant patches Applying: configure: add cuda-sdk for

Re: [FFmpeg-devel] [PATCH] configure: jni no longer requires -ldl

On 5/12/2017 11:34 AM, Aman Gupta wrote: From: Aman Gupta this dependency was removed in 33d69a90085d30af8a292d9364b835a26565d6b9 --- configure | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/configure b/configure index 5ae5227868..ba33241a45 100755 ---

Re: [FFmpeg-devel] [PATCH] avcodec/xpmdec: Fix multiple pointer/memory issues

On 5/12/17, Paul B Mahol wrote: > On 5/12/17, Michael Niedermayer wrote: >> On Fri, May 12, 2017 at 03:29:52PM +0200, Paul B Mahol wrote: >>> On 5/12/17, Michael Niedermayer wrote: >>> > On Thu, May 11, 2017 at 11:17:33AM +0200,

Re: [FFmpeg-devel] Patch libavformat/aviobuf.c fixes data loss on named pipe reads

Attaching the output of "git diff -p". On Fri, May 12, 2017 at 11:50 AM Michael Niedermayer wrote: > On Fri, May 12, 2017 at 06:31:19PM +, Rob Meyers wrote: > > Submitting a patch to fix a bug in ffmpeg found when reading data from a > > named pipe. In our test, a

Re: [FFmpeg-devel] [PATCH] avcodec/xpmdec: Fix multiple pointer/memory issues

On 5/12/17, Michael Niedermayer wrote: > On Fri, May 12, 2017 at 03:29:52PM +0200, Paul B Mahol wrote: >> On 5/12/17, Michael Niedermayer wrote: >> > On Thu, May 11, 2017 at 11:17:33AM +0200, Michael Niedermayer wrote: >> >> On Thu, May 11, 2017 at

Re: [FFmpeg-devel] [PATCH] avcodec/xpmdec: Fix multiple pointer/memory issues

On Fri, May 12, 2017 at 03:29:52PM +0200, Paul B Mahol wrote: > On 5/12/17, Michael Niedermayer wrote: > > On Thu, May 11, 2017 at 11:17:33AM +0200, Michael Niedermayer wrote: > >> On Thu, May 11, 2017 at 09:01:57AM +0200, Paul B Mahol wrote: > >> > On 5/11/17, Michael

Re: [FFmpeg-devel] Patch libavformat/aviobuf.c fixes data loss on named pipe reads

On Fri, May 12, 2017 at 06:31:19PM +, Rob Meyers wrote: > Submitting a patch to fix a bug in ffmpeg found when reading data from a > named pipe. In our test, a pipe sending twelve bytes in two 6 byte messages > results in the first 10 bytes being lost. We found the problem was > introduced

Re: [FFmpeg-devel] [PATCH 1/3] configure: add cuda-sdk for things requiring full CUDA sdk

On Thu, May 11, 2017 at 10:59:19PM +0200, Timo Rothenpieler wrote: > --- > configure | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) This doesnt apply so i cant test this or dependant patches Applying: configure: add cuda-sdk for things requiring full CUDA sdk error: sha1

[FFmpeg-devel] [PATCH] configure: jni no longer requires -ldl

From: Aman Gupta this dependency was removed in 33d69a90085d30af8a292d9364b835a26565d6b9 --- configure | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/configure b/configure index 5ae5227868..ba33241a45 100755 --- a/configure +++ b/configure @@ -5766,8

[FFmpeg-devel] Patch libavformat/aviobuf.c fixes data loss on named pipe reads

Submitting a patch to fix a bug in ffmpeg found when reading data from a named pipe. In our test, a pipe sending twelve bytes in two 6 byte messages results in the first 10 bytes being lost. We found the problem was introduced with this commit (2ca48e466675a8a3630061cd2c15325eab8eda97) on June 30,

Re: [FFmpeg-devel] [PATCH 1/3] configure: add cuda-sdk for things requiring full CUDA sdk

Am 12.05.2017 um 15:34 schrieb James Almer: On 5/12/2017 5:21 AM, Timo Rothenpieler wrote: Am 12.05.2017 um 07:32 schrieb Yogender Gupta: +cuda_sdk libnpp IMO, Libnpp is part of the CUDA SDK, and we can remove all the libnpp related changes and just replace it by cuda-sdk in the

Re: [FFmpeg-devel] [PATCH 6/7] lavf/flacenc: avoid buffer overread with unexpected extradata sizes

On 5/8/2017 1:36 AM, Rodger Combs wrote: > --- > libavformat/flacenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/flacenc.c b/libavformat/flacenc.c > index 9bb4947..b8800cc 100644 > --- a/libavformat/flacenc.c > +++ b/libavformat/flacenc.c > @@ -315,7

[FFmpeg-devel] [PATCH] avfilter: don't anonymously typedef structs

Signed-off-by: Paul B Mahol --- libavfilter/aeval.c| 2 +- libavfilter/af_afade.c | 2 +- libavfilter/af_amerge.c| 2 +- libavfilter/af_apad.c | 2 +- libavfilter/af_aresample.c | 2 +-

Re: [FFmpeg-devel] [PATCH 5/7] lavf/flacenc: support writing attached pictures

On 5/8/2017 1:36 AM, Rodger Combs wrote: > --- > libavformat/flacenc.c | 271 > +++--- > 1 file changed, 236 insertions(+), 35 deletions(-) > > diff --git a/libavformat/flacenc.c b/libavformat/flacenc.c > index b894f9e..9bb4947 100644 > ---

Re: [FFmpeg-devel] [PATCH 5/7] lavf/flacenc: support writing attached pictures

On 8 May 2017 at 05:36, Rodger Combs wrote: > --- > libavformat/flacenc.c | 271 ++ > +--- > 1 file changed, 236 insertions(+), 35 deletions(-) > > diff --git a/libavformat/flacenc.c b/libavformat/flacenc.c > index

[FFmpeg-devel] [PATCH] avcodec/avpacket: allow only one element per type in packet side data

It was never meant to do otherwise, as av_packet_get_side_data() returns the first entry it finds of a given type. Based on code from libavformat's av_stream_add_side_data(). Signed-off-by: James Almer --- libavcodec/avpacket.c | 13 - 1 file changed, 12

Re: [FFmpeg-devel] [PATCH] avcodec/xpmdec: Fix multiple pointer/memory issues

On 5/12/17, Nicolas George wrote: > Le tridi 23 floreal, an CCXXV, Paul B Mahol a ecrit : >> I told you that its unacceptable. > > And I told you, before you pushed, that your cowboy-style parser was > unacceptable. You chose to disregard it. Because I assumed packets are padded

Re: [FFmpeg-devel] [PATCH] avcodec/xpmdec: Fix multiple pointer/memory issues

Le tridi 23 floréal, an CCXXV, Paul B Mahol a écrit : > I told you that its unacceptable. And I told you, before you pushed, that your cowboy-style parser was unacceptable. You chose to disregard it. Regards, -- Nicolas George ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: Limit the number of side data elements per packet

On 5/12/2017 12:55 PM, wm4 wrote: > On Fri, 12 May 2017 10:59:50 -0300 > James Almer wrote: > >> On 5/12/2017 9:20 AM, Michael Niedermayer wrote: >>> On Fri, May 12, 2017 at 06:16:38AM +0200, wm4 wrote: On Thu, 11 May 2017 23:27:37 +0200 Michael Niedermayer

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: Limit the number of side data elements per packet

On Fri, 12 May 2017 10:59:50 -0300 James Almer wrote: > On 5/12/2017 9:20 AM, Michael Niedermayer wrote: > > On Fri, May 12, 2017 at 06:16:38AM +0200, wm4 wrote: > >> On Thu, 11 May 2017 23:27:37 +0200 > >> Michael Niedermayer wrote: > >> > >>> On

[FFmpeg-devel] [PATCH/WIP] avcodec/x86: move simple_idct to external assembly

--- For initial review and comments. I plan to drop the '2' from the filename before pushing. I haven't done it yet because I am still working on the file. I didn't make any changes with speedup in mind so I haven't done any benchmarking yet. libavcodec/x86/Makefile | 4 +-

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: Limit the number of side data elements per packet

On 5/12/2017 9:20 AM, Michael Niedermayer wrote: > On Fri, May 12, 2017 at 06:16:38AM +0200, wm4 wrote: >> On Thu, 11 May 2017 23:27:37 +0200 >> Michael Niedermayer wrote: >> >>> On Thu, May 11, 2017 at 06:54:16PM +0200, wm4 wrote: On Thu, 11 May 2017 13:01:36 +0200

Re: [FFmpeg-devel] [PATCH 1/3] configure: add cuda-sdk for things requiring full CUDA sdk

On 5/12/2017 5:21 AM, Timo Rothenpieler wrote: > Am 12.05.2017 um 07:32 schrieb Yogender Gupta: +cuda_sdk libnpp >> >> IMO, Libnpp is part of the CUDA SDK, and we can remove all the libnpp >> related changes and just replace it by cuda-sdk in the configure/make files. > > True,

Re: [FFmpeg-devel] [PATCH] avcodec/xpmdec: Fix multiple pointer/memory issues

On 5/12/17, Michael Niedermayer wrote: > On Thu, May 11, 2017 at 11:17:33AM +0200, Michael Niedermayer wrote: >> On Thu, May 11, 2017 at 09:01:57AM +0200, Paul B Mahol wrote: >> > On 5/11/17, Michael Niedermayer wrote: >> > > Most of these were

Re: [FFmpeg-devel] [PATCH] avcodec/vp8dsp: vp7_luma_dc_wht_c: Fix multiple runtime error: signed integer overflow: -1366381240 + -1262413604 cannot be represented in type 'int'

On Wed, May 10, 2017 at 02:50:40PM +0200, Michael Niedermayer wrote: > Fixes: 1440/clusterfuzz-testcase-minimized-5785716111966208 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg > Signed-off-by: Michael Niedermayer

Re: [FFmpeg-devel] [PATCH] avcodec/xpmdec: Fix multiple pointer/memory issues

On Thu, May 11, 2017 at 11:17:33AM +0200, Michael Niedermayer wrote: > On Thu, May 11, 2017 at 09:01:57AM +0200, Paul B Mahol wrote: > > On 5/11/17, Michael Niedermayer wrote: > > > Most of these were found through code review in response to > > > fixing

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: Limit the number of side data elements per packet

On Fri, May 12, 2017 at 06:16:38AM +0200, wm4 wrote: > On Thu, 11 May 2017 23:27:37 +0200 > Michael Niedermayer wrote: > > > On Thu, May 11, 2017 at 06:54:16PM +0200, wm4 wrote: > > > On Thu, 11 May 2017 13:01:36 +0200 > > > Michael Niedermayer

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: Limit the number of side data elements per packet

On Thu, May 11, 2017 at 01:57:01PM +0200, Clément Bœsch wrote: > On Thu, May 11, 2017 at 01:01:36PM +0200, Michael Niedermayer wrote: > > Fixes: 1293/clusterfuzz-testcase-minimized-6054752074858496 > > > > Found-by: continuous fuzzing process > >

Re: [FFmpeg-devel] Possible minor bug found in AVI decoder

On 12.05.2017 11:33, Eric Beuque wrote: Hi, i'm not really sure but i think a found a bug in the avi decoder of avformat. In the following function of the avidec.c: static int avi_read_header(AVFormatContext *s) { ... switch (tag) { ... case MKTAG('s', 't',

Re: [FFmpeg-devel] Possible minor bug found in AVI decoder

2017-05-12 11:46 GMT+02:00 Paul B Mahol : > On 5/12/17, Eric Beuque wrote: > > Hi, > > > > i'm not really sure but i think a found a bug in the avi decoder of > > avformat. > > > > In the following function of the avidec.c: > > > > static int

Re: [FFmpeg-devel] Possible minor bug found in AVI decoder

On 5/12/17, Eric Beuque wrote: > Hi, > > i'm not really sure but i think a found a bug in the avi decoder of > avformat. > > In the following function of the avidec.c: > > static int avi_read_header(AVFormatContext *s) > { > ... > switch (tag) { >

[FFmpeg-devel] Possible minor bug found in AVI decoder

Hi, i'm not really sure but i think a found a bug in the avi decoder of avformat. In the following function of the avidec.c: static int avi_read_header(AVFormatContext *s) { ... switch (tag) { ... case MKTAG('s', 't', 'r', 'f'): /* stream header */

Re: [FFmpeg-devel] [PATCH 1/3] configure: add cuda-sdk for things requiring full CUDA sdk

Am 12.05.2017 um 07:32 schrieb Yogender Gupta: >>> +cuda_sdk >>> libnpp > > IMO, Libnpp is part of the CUDA SDK, and we can remove all the libnpp related > changes and just replace it by cuda-sdk in the configure/make files. True, but I'm not sure if an existing config parameter can be

[FFmpeg-devel] [PATCH V2] lavc/vaapi_encode_h264: Enable MB rate control

V2: - Refine the name/value type to mb_rate_control/bool. - Only supported GEN9+ (SKL/APL/KBL/...) - i965 driver default use frame-level rate control algorithm (generate the QP for each frame), when enable mb_rate_control, it's will enable the MB-level RC algorithm (generate the