Re: [FFmpeg-devel] [PATCH] avcodec/mjpegenc: disable unused code with AMV

On Thu, Aug 10, 2017 at 01:43:42AM +, Davinder Singh wrote: > On Thu, Aug 10, 2017 at 6:59 AM Michael Niedermayer > wrote: > > > On Wed, Aug 09, 2017 at 07:46:30AM +, Davinder Singh wrote: > > > hi, > > > > > > this disables unused function amv_encode_picture()

Re: [FFmpeg-devel] [PATCH] encoders.texi: Replace x264 --full-help suggestion with --fullhelp

2017-08-11 0:40 GMT+08:00 Leo Izen : > --- > doc/encoders.texi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/doc/encoders.texi b/doc/encoders.texi > index 690cca83dc..f20be54ce8 100644 > --- a/doc/encoders.texi > +++ b/doc/encoders.texi > @@ -1793,7

Re: [FFmpeg-devel] [PATCH 01/16] doc/filters: document the unstability of the shorthand options notation.

On Thu, Aug 10, 2017 at 04:15:55PM +0200, Nicolas George wrote: > Le tridi 23 thermidor, an CCXXV, Michael Niedermayer a écrit : > > Please limit the notes in filters.texi and Changelog to the filters and > > options you intend to change. > > That would defeat the purpose. Doubly so: > > - Being

Re: [FFmpeg-devel] [PATCH] ffmpeg: fix setting field_order during muxing

> On Aug 10, 2017, at 5:18 PM, Jerome Martinez wrote: > > Le 10/08/2017 à 04:43, James Almer a écrit : >> AVFrame.top_field_first doxy states >> >> "If the content is interlaced, is top field displayed first." >> >> And AVFieldOrder doxy defines: >> AV_FIELD_TB,

Re: [FFmpeg-devel] [PATCH] ffmpeg: fix setting field_order during muxing

Le 10/08/2017 à 04:43, James Almer a écrit : AVFrame.top_field_first doxy states "If the content is interlaced, is top field displayed first." And AVFieldOrder doxy defines: AV_FIELD_TB, //< Top coded first, bottom displayed first AV_FIELD_BT, //< Bottom coded

Re: [FFmpeg-devel] [PATCH] avfilter/vf_overlay: fix alpha blending for planar formats with a transparent background

On Mon, 7 Aug 2017, Marton Balint wrote: On Sat, 5 Aug 2017, Michael Niedermayer wrote: On Fri, Aug 04, 2017 at 10:23:55AM +0200, Marton Balint wrote: When the background had an alpha channel, the old code in blend_plane calculated premultiplied alpha from the destination plane colors

Re: [FFmpeg-devel] [PATCH 1/3] ffplay: add support for rendering yuv images with negative line size

On Sun, 6 Aug 2017, Marton Balint wrote: Signed-off-by: Marton Balint --- ffplay.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) Pushed the series. Regards, Marton ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [mov] Fix trampling of ctts during seeks when sidx support is enabled.

On Tue, Aug 8, 2017 at 6:48 PM, Michael Niedermayer wrote: > > the fate test seems to fail: > > did i do something silly ? > Ah no, I did when I remuxed the test file. Updated expectations and test clip at http://storage.googleapis.com/dalecurtis/buck480p30_na.mp4 -

Re: [FFmpeg-devel] [PATCH] JPEG2000: SSE optimisation of DWT decoding

> From: Clément Bœsch > > On Tue, Aug 08, 2017 at 09:09:44AM +, maxime taisant wrote: > > From: Maxime Taisant > > > > Hi, > > > > Here is some SSE optimisations for the dwt function used to decode > JPEG2000. > > I tested this code by using the time

Re: [FFmpeg-devel] [PATCH] JPEG2000: SSE optimisation of DWT decoding

> From: Ivan Kalvachev > > On 8/8/17, maxime taisant wrote: > > From: Maxime Taisant > > > > Hi, > > > > Here is some SSE optimisations for the dwt function used to decode > JPEG2000. > > I tested this code by using the

Re: [FFmpeg-devel] [PATCH 01/16] doc/filters: document the unstability of the shorthand options notation.

On Thu, 10 Aug 2017, Nicolas George wrote: Le tridi 23 thermidor, an CCXXV, Michael Niedermayer a écrit : Please limit the notes in filters.texi and Changelog to the filters and options you intend to change. That would defeat the purpose. Doubly so: - Being free to change the options as

[FFmpeg-devel] [PATCH] encoders.texi: Replace x264 --full-help suggestion with --fullhelp

--- doc/encoders.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/encoders.texi b/doc/encoders.texi index 690cca83dc..f20be54ce8 100644 --- a/doc/encoders.texi +++ b/doc/encoders.texi @@ -1793,7 +1793,7 @@ the documentation of the undocumented generic options, see

Re: [FFmpeg-devel] [PATCH] ffmpeg: fix setting field_order during muxing

On 8/10/2017 5:21 AM, Hendrik Leppkes wrote: > On Thu, Aug 10, 2017 at 4:43 AM, James Almer wrote: >> AVFrame.top_field_first doxy states >> >> "If the content is interlaced, is top field displayed first." >> >> And AVFieldOrder doxy defines: >> AV_FIELD_TB, //<

Re: [FFmpeg-devel] [PATCH 01/16] doc/filters: document the unstability of the shorthand options notation.

Le tridi 23 thermidor, an CCXXV, Michael Niedermayer a écrit : > Please limit the notes in filters.texi and Changelog to the filters and > options you intend to change. That would defeat the purpose. Doubly so: - Being free to change the options as need requires. That means any filter and any

Re: [FFmpeg-devel] [PATCH 01/16] doc/filters: document the unstability of the shorthand options notation.

On Thu, Aug 10, 2017 at 01:46:27PM +0200, Nicolas George wrote: > It does not mean that we intend to break the order of options > at a whim, but it gives us more freedom to make necessary > changes without extra unnecessary burden while giving stability > to users that require it. > >

[FFmpeg-devel] [PATCH 16/16] doc/filters: document framesync options.

Signed-off-by: Nicolas George --- Changelog| 2 ++ doc/filters.texi | 76 +--- 2 files changed, 47 insertions(+), 31 deletions(-) diff --git a/Changelog b/Changelog index 78286e3606..d5ffa0a1f2 100644 --- a/Changelog

[FFmpeg-devel] [PATCH 08/16] lavfi/vf_overlay: use framesync2 options.

Signed-off-by: Nicolas George --- libavfilter/vf_overlay.c | 45 - 1 file changed, 4 insertions(+), 41 deletions(-) Unchanged. diff --git a/libavfilter/vf_overlay.c b/libavfilter/vf_overlay.c index 80365ce8df..5a76fa2ee9 100644 ---

[FFmpeg-devel] [PATCH 07/16] lavfi/framesync2: add common options.

Also add functions and macros to help filters chaining these options to their own. Signed-off-by: Nicolas George --- libavfilter/framesync2.c | 55 ++-- libavfilter/framesync2.h | 44 +- 2 files

[FFmpeg-devel] [PATCH 14/16] vf_ssim: convert to framesync2.

Signed-off-by: Nicolas George --- libavfilter/Makefile | 2 +- libavfilter/vf_ssim.c | 52 ++- 2 files changed, 28 insertions(+), 26 deletions(-) Unchanged. diff --git a/libavfilter/Makefile b/libavfilter/Makefile index

[FFmpeg-devel] [PATCH 09/16] lavfi/vf_blend: convert to framesync2.

Signed-off-by: Nicolas George --- libavfilter/Makefile | 4 ++-- libavfilter/vf_blend.c | 48 +++- 2 files changed, 29 insertions(+), 23 deletions(-) Unchanged. diff --git a/libavfilter/Makefile b/libavfilter/Makefile index

[FFmpeg-devel] [PATCH 15/16] lavfi: remove dualinput.

Signed-off-by: Nicolas George --- libavfilter/dualinput.c | 90 - libavfilter/dualinput.h | 46 - 2 files changed, 136 deletions(-) delete mode 100644 libavfilter/dualinput.c delete mode 100644

[FFmpeg-devel] [PATCH 12/16] lavfi/vf_paletteuse: convert to framesync2.

Signed-off-by: Nicolas George --- libavfilter/Makefile| 2 +- libavfilter/vf_paletteuse.c | 60 - 2 files changed, 39 insertions(+), 23 deletions(-) Now uses ff_framesync2_dualinput_get_writable(). diff --git

[FFmpeg-devel] [PATCH 13/16] lavfi/vf_psnr: convert to framesync2.

Signed-off-by: Nicolas George --- libavfilter/Makefile | 2 +- libavfilter/vf_psnr.c | 50 +++--- 2 files changed, 28 insertions(+), 24 deletions(-) Unchanged. diff --git a/libavfilter/Makefile b/libavfilter/Makefile index

[FFmpeg-devel] [PATCH 05/16] lavfi: add a preinit callback to filters.

It is necessary for filters with child objects, to set the class and default options values. Signed-off-by: Nicolas George --- libavfilter/avfilter.c | 8 libavfilter/avfilter.h | 15 +++ 2 files changed, 23 insertions(+) Unchanged. diff --git

[FFmpeg-devel] [PATCH 11/16] lavfi/vf_lut3d: convert to framesync2.

Signed-off-by: Nicolas George --- libavfilter/Makefile | 2 +- libavfilter/vf_lut3d.c | 49 ++--- 2 files changed, 27 insertions(+), 24 deletions(-) Unchanged. diff --git a/libavfilter/Makefile b/libavfilter/Makefile index

[FFmpeg-devel] [PATCH 06/16] lavfi: search options on child objects.

The child objects must be allocated and inited in the preinit() callback. Signed-off-by: Nicolas George --- libavfilter/avfilter.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Unchanged. diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index

[FFmpeg-devel] [PATCH 03/16] lavfi/framesync2: add dualinput helper functions.

Signed-off-by: Nicolas George --- libavfilter/framesync2.c | 99 ++-- libavfilter/framesync2.h | 25 2 files changed, 103 insertions(+), 21 deletions(-) Added ff_framesync2_dualinput_get_writable(). diff --git

[FFmpeg-devel] [PATCH 10/16] lavfi/vf_libvmaf: convert to framesync2.

After this commit, the code compiles, but on my setup it segfaults before and after. It also prints the very worrying warning: src/libavfilter/vf_libvmaf.c:161:66: warning: passing argument 4 of ‘compute_vmaf’ from incompatible pointer type [-Wincompatible-pointer-types]

[FFmpeg-devel] [PATCH 04/16] lavfi/vf_overlay: move to framesync2.

Signed-off-by: Nicolas George --- libavfilter/Makefile | 2 +- libavfilter/vf_overlay.c | 70 ++-- 2 files changed, 39 insertions(+), 33 deletions(-) Now uses ff_framesync2_dualinput_get_writable(). diff --git

[FFmpeg-devel] [PATCH 01/16] doc/filters: document the unstability of the shorthand options notation.

It does not mean that we intend to break the order of options at a whim, but it gives us more freedom to make necessary changes without extra unnecessary burden while giving stability to users that require it. Signed-off-by: Nicolas George --- Changelog| 3 +++

[FFmpeg-devel] [PATCH 02/16] lavfi/f_streamselect: convert to framesync2.

Signed-off-by: Nicolas George --- libavfilter/Makefile | 4 ++-- libavfilter/f_streamselect.c | 33 + 2 files changed, 15 insertions(+), 22 deletions(-) Unchanged. diff --git a/libavfilter/Makefile b/libavfilter/Makefile index

Re: [FFmpeg-devel] Mov/mp4 demuxer failing on mp4 file (Sample size is too large)

On 8/10/17, Robert Krüger wrote: > On Thu, Aug 10, 2017 at 10:21 AM, Paul B Mahol wrote: > >> On 8/9/17, Robert Krüger wrote: >> > Hi, >> > >> > can someone tell me what this hints at? Is this more likely a broken >> > file

Re: [FFmpeg-devel] [PATCH 11/14] lavfi/vf_paletteuse: convert to framesync2.

On Thu, Aug 10, 2017 at 11:33:31AM +0200, Nicolas George wrote: > Le tridi 23 thermidor, an CCXXV, Clement Boesch a écrit : > > But unless it's API documented, that's implementation specific. I'd prefer > > if you keep that as a safe guard. It also has a documentation purpose. > > I will do it if

Re: [FFmpeg-devel] Mov/mp4 demuxer failing on mp4 file (Sample size is too large)

On Thu, Aug 10, 2017 at 10:21 AM, Paul B Mahol wrote: > On 8/9/17, Robert Krüger wrote: > > Hi, > > > > can someone tell me what this hints at? Is this more likely a broken file > > or a missing feature of the demuxer? Unfortunately I cannot make the

Re: [FFmpeg-devel] [PATCH 11/14] lavfi/vf_paletteuse: convert to framesync2.

Le tridi 23 thermidor, an CCXXV, Clement Boesch a écrit : > But unless it's API documented, that's implementation specific. I'd prefer > if you keep that as a safe guard. It also has a documentation purpose. I will do it if you insist, but before that, let me correct a little detail: > If the

Re: [FFmpeg-devel] Mov/mp4 demuxer failing on mp4 file (Sample size is too large)

On 8/9/17, Robert Krüger wrote: > Hi, > > can someone tell me what this hints at? Is this more likely a broken file > or a missing feature of the demuxer? Unfortunately I cannot make the file > available due to legal issues but if I know where to look, I could try to >

Re: [FFmpeg-devel] [PATCH] ffmpeg: fix setting field_order during muxing

On Thu, Aug 10, 2017 at 4:43 AM, James Almer wrote: > AVFrame.top_field_first doxy states > > "If the content is interlaced, is top field displayed first." > > And AVFieldOrder doxy defines: > AV_FIELD_TB, //< Top coded first, bottom displayed first >

Re: [FFmpeg-devel] [WIP] libcodec2 wrapper + de/muxer in FFmpeg

On 8/9/17, Michael Niedermayer wrote: > On Tue, Aug 08, 2017 at 11:49:45PM +0200, Tomas Härdin wrote: > [...] > >> ffmpeg.c |3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> 5bd20883fdc12aefa609fc803fe5709069b3e9a0 >>

Re: [FFmpeg-devel] [PATCH 10/14] lavfi/vf_lut3d: convert to framesync2.

On Mon, Jul 31, 2017 at 02:02:23PM +0200, Nicolas George wrote: [...] > static const AVOption haldclut_options[] = { > -{ "shortest", "force termination when the shortest input terminates", > OFFSET(dinput.shortest), AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, FLAGS }, > -{ "repeatlast",

Re: [FFmpeg-devel] lavc/vaapi_encode_h264: respect "slices" option in h264 vaapi encoder

On 2017/8/10 6:05, Mark Thompson wrote: > On 02/08/17 06:56, Jun Zhao wrote: >> From f9b42385faedd64dacf613785c393c7b025237c9 Mon Sep 17 00:00:00 2001 >> From: Jun Zhao >> Date: Tue, 1 Aug 2017 23:05:44 -0400 >> Subject: [PATCH V2 3/4] lavc/vaapi_encode_h264: respect

Re: [FFmpeg-devel] [PATCH 11/14] lavfi/vf_paletteuse: convert to framesync2.

On Thu, Aug 10, 2017 at 09:13:13AM +0200, Nicolas George wrote: > Le tridi 23 thermidor, an CCXXV, Clement Boesch a écrit : > > > -.needs_writable = 1, // for error diffusal dithering > > why? > > It was not needed in the first place: IIRC, dualinput always returns a > writable main

Re: [FFmpeg-devel] [PATCH 11/14] lavfi/vf_paletteuse: convert to framesync2.

Le tridi 23 thermidor, an CCXXV, Clement Boesch a écrit : > > -.needs_writable = 1, // for error diffusal dithering > why? It was not needed in the first place: IIRC, dualinput always returns a writable main frame. And the new implementation does, I am sure of it. Regards, -- Nicolas