Re: [FFmpeg-devel] [PATCH 3/4] avdevice/decklink_dec: Added Closed caption decode from VANC

2017-09-13 Thread Jeyapal, Karthick
Hi Marton, Thanks a lot for your comments. I have modified the patch as per all your comments, except the below one. >> +tgt = teletext_data_unit_from_ancillary_packet(buf, buf + 1920, >> tgt, cctx->teletext_lines, 0); > >this should be >tgt = teletext_data_unit_from

Re: [FFmpeg-devel] [PATCH 1/4] avdevice/decklink_dec: Added VANC search for all resolutions

2017-09-13 Thread Jeyapal, Karthick
Thanks for your comments. Please find the patch attached as per your comments. Regards, Karthick 0001-avdevice-decklink_dec-Added-VANC-search-for-all-reso.patch Description: 0001-avdevice-decklink_dec-Added-VANC-search-for-all-reso.patch ___ ffmpeg-dev

Re: [FFmpeg-devel] [PATCH 5/5] lavd: Add KMS frame grabber

2017-09-13 Thread James Almer
On 9/7/2017 6:56 PM, Mark Thompson wrote: > +pkt->data = (uint8_t*)frame; > +pkt->size = sizeof(*frame); > +pkt->pts = now; > +pkt->flags = AV_PKT_FLAG_TRUSTED; pkt->flags |= AV_PKT_FLAG_TRUSTED; I know pkt->flags is zeroed by default, but that may change in the future. And OR

[FFmpeg-devel] [PATCH] avfilter: add normalize filter

2017-09-13 Thread Richard Ling
Hi, This patch adds a filter to normalize (contrast stretch) RGB video. Comments welcome. R. From f08f132ecd79718d0ce6fb07f99c84ab5dd52ee4 Mon Sep 17 00:00:00 2001 From: Richard Ling Date: Thu, 14 Sep 2017 13:18:50 +1000 Subject: [PATCH] avfilter: add normalize filter --- doc/filters.texi

Re: [FFmpeg-devel] [PATCH 18/20] mpeg12: Move finding the best frame rate to common code

2017-09-13 Thread Michael Niedermayer
On Wed, Sep 13, 2017 at 12:44:08AM +0100, Mark Thompson wrote: > Previously in the mpeg2_metadata filter. Also adds a test. [...] > +for (c = 1; c <= max_code; c++) { > +for (n = 1; n <= (mpeg2 ? 4 : 1); n++) { > +for (d = 1; d <= (mpeg2 ? 32 : 1); d++) { > +

Re: [FFmpeg-devel] [PATCH 03/20] lavc: Add coded bitstream read/write API

2017-09-13 Thread Michael Niedermayer
On Wed, Sep 13, 2017 at 12:43:53AM +0100, Mark Thompson wrote: > (cherry picked from commit 18f1706f331bf5dd565774eae680508c8d3a97ad) > (cherry picked from commit 44cde38c8acbef7d5250e6d1b52b1020871e093b) > --- > configure | 1 + > libavcodec/Makefile | 1 + > libavcodec/

Re: [FFmpeg-devel] [V5 3/4] lavc/vaapi_encode_h264: respect "slices" option in h264 vaapi encoder

2017-09-13 Thread Jun Zhao
On 2017/9/13 20:20, Moritz Barsnick wrote: > On Thu, Aug 24, 2017 at 09:13:20 +0800, Jun Zhao wrote: >> +av_log(avctx, AV_LOG_ERROR, "The max slices number per frame " >> + "cannot more than %d.\n", ctx->max_slices); > "cannot be more" > (This remark also applies to

Re: [FFmpeg-devel] [V5 2/4] lavc/vaapi_encode: Add max slices number query.

2017-09-13 Thread Jun Zhao
On 2017/9/13 20:18, Moritz Barsnick wrote: > On Thu, Aug 24, 2017 at 09:13:09 +0800, Jun Zhao wrote: >> +// Supported max-slices number per frame. (0 means driver cannot >> +// support max mutil-slices query) > ^ multi > > Moritz Tks. will fix the typo. > ___

[FFmpeg-devel] [PATCH] kmsgrab: fix build error when use old libdrm

2017-09-13 Thread Jun Zhao
From 8c7ddfcabf686f213aa59544d90055d20bdac0f7 Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Wed, 13 Sep 2017 20:21:38 -0400 Subject: [PATCH] kmsgrab: fix build error when use old libdrm DRM_FORMAT_R16 adding from libdrm 2.4.82, fix the build error when libdrm < 2.4.82. Signed-off-by: Jun Zhao

Re: [FFmpeg-devel] [Patch] CUDA Thumbnail Filter

2017-09-13 Thread Rostislav Pehlivanov
On 13 September 2017 at 19:12, Timo Rothenpieler wrote: > I did object and have NAK'd the patch currently. >> Make the submitter submit a new version themselves and I'll approve it. >> > > There was a new version submitted already, I just replied to the wrong one. > > > __

Re: [FFmpeg-devel] [PATCH] avfilter/interlace: prevent over-sharpening with the complex low-pass filter

2017-09-13 Thread Thomas Mundt
2017-09-06 22:15 GMT+02:00 Thomas Mundt : > 2017-09-01 1:55 GMT+02:00 Thomas Mundt : > >> 2017-09-01 1:22 GMT+02:00 Michael Niedermayer : >> >>> On Fri, Sep 01, 2017 at 01:18:11AM +0200, Michael Niedermayer wrote: >>> > On Thu, Aug 31, 2017 at 10:40:12PM +0200, Thomas Mundt wrote: >>> > > 2017-08-

Re: [FFmpeg-devel] [PATCH] Add support for RockChip Media Process Platform

2017-09-13 Thread James Almer
On 9/11/2017 5:21 AM, LongChair . wrote: > > > Le 10/09/2017 à 19:13, James Almer a écrit : >> On 9/9/2017 4:00 AM, LongChair . wrote: >>> From: LongChair >>> >>> This adds hardware decoding for h264 / HEVC / VP8 using MPP Rockchip API. >>> Will return frames holding an AVDRMFrameDescriptor stru

Re: [FFmpeg-devel] [PATCH] configure: check if NAN can be used as a constant initializer

2017-09-13 Thread Derek Buitenhuis
On 9/13/2017 8:39 PM, James Almer wrote: > Maybe not, but I'm not going to spend time reading and testing the code > to find out if that's the case when the maintainer hasn't dealt with > this himself for an entire month. He's on vacation, I think. > As i said, if anyone has a better or preferred

Re: [FFmpeg-devel] [PATCH] avcodec/extract_extradata: return an error when buffer allocation fails

2017-09-13 Thread James Almer
On 9/13/2017 5:20 PM, Mark Thompson wrote: > On 13/09/17 21:06, James Almer wrote: >> ret is 0 by default. >> --- >> libavcodec/extract_extradata_bsf.c | 5 - >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/libavcodec/extract_extradata_bsf.c >> b/libavcodec/extract_extrad

Re: [FFmpeg-devel] [PATCH] avcodec/extract_extradata: return an error when buffer allocation fails

2017-09-13 Thread Mark Thompson
On 13/09/17 21:06, James Almer wrote: > ret is 0 by default. > --- > libavcodec/extract_extradata_bsf.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/extract_extradata_bsf.c > b/libavcodec/extract_extradata_bsf.c > index 4cd0ca1137..ed6509c681 100644 > -

[FFmpeg-devel] [PATCH] avcodec/extract_extradata: return an error when buffer allocation fails

2017-09-13 Thread James Almer
ret is 0 by default. --- libavcodec/extract_extradata_bsf.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavcodec/extract_extradata_bsf.c b/libavcodec/extract_extradata_bsf.c index 4cd0ca1137..ed6509c681 100644 --- a/libavcodec/extract_extradata_bsf.c +++ b/libavcodec

Re: [FFmpeg-devel] [PATCH] configure: check if NAN can be used as a constant initializer

2017-09-13 Thread James Almer
On 9/13/2017 3:36 PM, Hendrik Leppkes wrote: > On Wed, Sep 13, 2017 at 7:49 PM, James Almer wrote: >> On 9/13/2017 2:23 PM, Carl Eugen Hoyos wrote: >>> 2017-09-13 19:10 GMT+02:00 James Almer : Some targets, like NetBSD and DJGPP, don't seem to support it. Signed-off-by: James Almer

Re: [FFmpeg-devel] [PATCHv3] avformat/mpegts: opus muxing & demuxing for mapping family 255

2017-09-13 Thread pkv.stream
Le 08/09/2017 à 1:46 AM, pkv.stream a écrit : Hi, I've removed inline declarations in the patch since they're not accepted in ffmpeg. Thanks for any more comments or reviews. Regards bump, initial submission 08/29 Got some comments from Michael (thanks again Michael) but that's all. Sho

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfdec: use the common packet pts setter function for opatom files

2017-09-13 Thread Marton Balint
On Fri, 8 Sep 2017, Michael Niedermayer wrote: On Thu, Sep 07, 2017 at 05:11:40PM +0200, Marton Balint wrote: Fixes ticket #6631. Signed-off-by: Marton Balint --- libavformat/mxfdec.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) please add a fate this if you push thi

Re: [FFmpeg-devel] [PATCH] configure: check if NAN can be used as a constant initializer

2017-09-13 Thread Hendrik Leppkes
On Wed, Sep 13, 2017 at 7:49 PM, James Almer wrote: > On 9/13/2017 2:23 PM, Carl Eugen Hoyos wrote: >> 2017-09-13 19:10 GMT+02:00 James Almer : >>> Some targets, like NetBSD and DJGPP, don't seem to support it. >>> >>> Signed-off-by: James Almer >>> --- >>> configure | 6 ++ >>> 1 file chang

Re: [FFmpeg-devel] [PATCH] configure: check if NAN can be used as a constant initializer

2017-09-13 Thread James Almer
On 9/13/2017 3:08 PM, Reimar Döffinger wrote: > On Wed, Sep 13, 2017 at 02:49:59PM -0300, James Almer wrote: >> On 9/13/2017 2:23 PM, Carl Eugen Hoyos wrote: >>> 2017-09-13 19:10 GMT+02:00 James Almer : Some targets, like NetBSD and DJGPP, don't seem to support it. Signed-off-by: Jam

Re: [FFmpeg-devel] [PATCH] configure: check if NAN can be used as a constant initializer

2017-09-13 Thread Reimar Döffinger
On Wed, Sep 13, 2017 at 02:49:59PM -0300, James Almer wrote: > On 9/13/2017 2:23 PM, Carl Eugen Hoyos wrote: > > 2017-09-13 19:10 GMT+02:00 James Almer : > >> Some targets, like NetBSD and DJGPP, don't seem to support it. > >> > >> Signed-off-by: James Almer > >> --- > >> configure | 6 ++ > >

Re: [FFmpeg-devel] [Patch] CUDA Thumbnail Filter

2017-09-13 Thread Timo Rothenpieler
I did object and have NAK'd the patch currently. Make the submitter submit a new version themselves and I'll approve it. There was a new version submitted already, I just replied to the wrong one. smime.p7s Description: S/MIME Cryptographic Signature __

Re: [FFmpeg-devel] [PATCH] avcodec/frame_thread_encoder: Fix AV_OPT_TYPE_STRING handling in avctx

2017-09-13 Thread Reimar Döffinger
On Wed, Sep 13, 2017 at 07:12:48PM +0200, Reimar Döffinger wrote: > This is the equivalent to what 7d317d4706b49d572a1eb5269438753be18362c7 > did for the codec-specific options. > av_opt_copy has specific handling so it's fine that we already copied > the whole context before. Btw, if someone can

Re: [FFmpeg-devel] [PATCH] configure: check if NAN can be used as a constant initializer

2017-09-13 Thread James Almer
On 9/13/2017 2:23 PM, Carl Eugen Hoyos wrote: > 2017-09-13 19:10 GMT+02:00 James Almer : >> Some targets, like NetBSD and DJGPP, don't seem to support it. >> >> Signed-off-by: James Almer >> --- >> configure | 6 ++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/configure b/configure >

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/pngdec: Fix () placement

2017-09-13 Thread Reimar Döffinger
On Wed, Aug 23, 2017 at 10:26:45PM +0200, Alexander Strasser wrote: > On 2017-08-22 17:23 +, Michael Niedermayer wrote: > > ffmpeg | branch: master | Michael Niedermayer | > > Tue Aug 22 18:36:26 2017 +0200| [a2e444d5bb2e3115d3afcc0cca9d1506c90436a2] > > | committer: Michael Niedermayer > >

Re: [FFmpeg-devel] [Patch] CUDA Thumbnail Filter

2017-09-13 Thread Rostislav Pehlivanov
On 13 September 2017 at 14:43, Timo Rothenpieler wrote: > Will apply with some minor changes (some unused variables are still left, > and some cleanup is missing) soon if nobody objects. > > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org >

Re: [FFmpeg-devel] [PATCH] configure: check if NAN can be used as a constant initializer

2017-09-13 Thread Carl Eugen Hoyos
2017-09-13 19:10 GMT+02:00 James Almer : > Some targets, like NetBSD and DJGPP, don't seem to support it. > > Signed-off-by: James Almer > --- > configure | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/configure b/configure > index ab1550d39b..4855ca54c9 100755 > --- a/configure >

[FFmpeg-devel] [PATCH]lavf/mpegts: Consider 0x0f just a hint towards aac

2017-09-13 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket #6657. Please comment, Carl Eugen From d806a243e97de8c245958dc6f8d2646217cc5105 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Wed, 13 Sep 2017 19:05:10 +0200 Subject: [PATCH] lavf/mpegts: Consider stream_type 0x0f just a hint toward AAC. It is also used

[FFmpeg-devel] [PATCH] avcodec/frame_thread_encoder: Fix AV_OPT_TYPE_STRING handling in avctx

2017-09-13 Thread Reimar Döffinger
This is the equivalent to what 7d317d4706b49d572a1eb5269438753be18362c7 did for the codec-specific options. av_opt_copy has specific handling so it's fine that we already copied the whole context before. Signed-off-by: Reimar Döffinger --- libavcodec/frame_thread_encoder.c | 3 +++ 1 file change

[FFmpeg-devel] [PATCH] configure: check if NAN can be used as a constant initializer

2017-09-13 Thread James Almer
Some targets, like NetBSD and DJGPP, don't seem to support it. Signed-off-by: James Almer --- configure | 6 ++ 1 file changed, 6 insertions(+) diff --git a/configure b/configure index ab1550d39b..4855ca54c9 100755 --- a/configure +++ b/configure @@ -3222,6 +3222,7 @@ pixfmts_super2xsai_tes

Re: [FFmpeg-devel] [PATCH] avfilter: add vmafmotion filter

2017-09-13 Thread Tobias Rapp
On 13.09.2017 15:10, Ronald S. Bultje wrote: Hi, On Wed, Sep 6, 2017 at 4:04 PM, Ashish Pratap Singh wrote: From: Ashish Singh Hi, this patch changes previous one to framesync2. SIMD is a work in progress for this filter. Signed-off-by: Ashish Singh --- Changelog | 1

Re: [FFmpeg-devel] [Patch] CUDA Thumbnail Filter

2017-09-13 Thread Timo Rothenpieler
Will apply with some minor changes (some unused variables are still left, and some cleanup is missing) soon if nobody objects. smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.o

Re: [FFmpeg-devel] [PATCH] avfilter: add vmafmotion filter

2017-09-13 Thread Ashish Pratap Singh
Hi, On Wed, Sep 13, 2017 at 6:40 PM, Ronald S. Bultje wrote: > Hi, > > On Wed, Sep 6, 2017 at 4:04 PM, Ashish Pratap Singh > wrote: > >> From: Ashish Singh >> >> Hi, this patch changes previous one to framesync2. >> SIMD is a work in progress for this filter. >> >> Signed-off-by: Ashish Singh

Re: [FFmpeg-devel] [PATCH] avfilter: add vmafmotion filter

2017-09-13 Thread Ronald S. Bultje
Hi, On Wed, Sep 6, 2017 at 4:04 PM, Ashish Pratap Singh wrote: > From: Ashish Singh > > Hi, this patch changes previous one to framesync2. > SIMD is a work in progress for this filter. > > Signed-off-by: Ashish Singh > --- > Changelog | 1 + > doc/filters.texi|

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/pngdec: Fix () placement

2017-09-13 Thread Moritz Barsnick
On Wed, Aug 23, 2017 at 22:26:45 +0200, Alexander Strasser wrote: > > -if ((ret = decode_zbuf(&bp, s->gb.buffer, s->gb.buffer + length) < 0)) > > +if ((ret = decode_zbuf(&bp, s->gb.buffer, s->gb.buffer + length)) < 0) > > IMHO another reason not to do the assignment and the comparison on t

Re: [FFmpeg-devel] [V5 3/4] lavc/vaapi_encode_h264: respect "slices" option in h264 vaapi encoder

2017-09-13 Thread Moritz Barsnick
On Thu, Aug 24, 2017 at 09:13:20 +0800, Jun Zhao wrote: > +av_log(avctx, AV_LOG_ERROR, "The max slices number per frame " > + "cannot more than %d.\n", ctx->max_slices); "cannot be more" (This remark also applies to the h265 patch.) Moritz ___

Re: [FFmpeg-devel] [V5 2/4] lavc/vaapi_encode: Add max slices number query.

2017-09-13 Thread Moritz Barsnick
On Thu, Aug 24, 2017 at 09:13:09 +0800, Jun Zhao wrote: > +// Supported max-slices number per frame. (0 means driver cannot > +// support max mutil-slices query) ^ multi Moritz ___ ffmpeg-devel mailing list ffmpeg-devel@

Re: [FFmpeg-devel] [PATCH] avcodec/mips: Improve hevc lpf msa functions

2017-09-13 Thread Manojkumar Bhosale
LGTM -Original Message- From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of kaustubh.ra...@imgtec.com Sent: Tuesday, September 12, 2017 4:45 PM To: ffmpeg-devel@ffmpeg.org Cc: Kaustubh Raste Subject: [FFmpeg-devel] [PATCH] avcodec/mips: Improve hevc lpf msa functions

Re: [FFmpeg-devel] [PATCH] avcodec/mips: Improve hevc idct msa functions

2017-09-13 Thread Manojkumar Bhosale
LGTM -Original Message- From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of kaustubh.ra...@imgtec.com Sent: Tuesday, September 12, 2017 5:02 PM To: ffmpeg-devel@ffmpeg.org Cc: Kaustubh Raste Subject: [FFmpeg-devel] [PATCH] avcodec/mips: Improve hevc idct msa functions