Re: [FFmpeg-devel] [PATCH, v2] lavf/deinterlace_qsv: set specific field for repeat

2019-03-07 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Linjie Fu > Sent: Friday, March 8, 2019 11:34 PM > To: ffmpeg-devel@ffmpeg.org > Cc: Fu, Linjie > Subject: [FFmpeg-devel] [PATCH, v2] lavf/deinterlace_qsv: set specific field > for repeat > > Set specific field for

Re: [FFmpeg-devel] [PATCHv2] avcodec/nvenc: Reconfigure resolution on-the-fly

2019-03-07 Thread Oliver Collyer
>>> To use this feature you would need to: >>> >>> 1. Specify max_width and max_height before opening the encoder >> >> Can't they be set to a maximum number to be as flexible as possible? >> > > It would allocate the output surfaces to this size if we took that approach > and I don’t think

[FFmpeg-devel] [PATCH, v2] lavf/deinterlace_qsv: set specific field for repeat

2019-03-07 Thread Linjie Fu
Set specific field for repeat in PicStruct if the frame has repeat flag. Match the CheckInputPicStruct in MSDK. Fix #7701. Signed-off-by: Linjie Fu --- libavfilter/vf_deinterlace_qsv.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_deinterlace_qsv.c

Re: [FFmpeg-devel] [PATCH v2 6/6] lavc/qsvdec: Add VP9 decoder support

2019-03-07 Thread Li, Zhong
> More widely, I would actually suggest to revise existing mediasdk plugins > loading path and change it from loading plugins at the first place to: > 1. Try to initialize component directly from the library 2. If #1 fails, try > to > initialize component from the plugin This will allow to avoid

[FFmpeg-devel] [PATCH v2 1/1] lavc/h264_levels: add MaxMBPS checking and update fate test.

2019-03-07 Thread Decai Lin
1. add MaxMBPS checking for level idc setting to align with AVC spec AnnexA table A-1/A-6 level limits. 2. update h264 level fate test. Signed-off-by: Decai Lin --- libavcodec/h264_levels.c | 6 + libavcodec/h264_levels.h | 1 + libavcodec/h264_metadata_bsf.c | 10 +++-

Re: [FFmpeg-devel] [PATCH] lavc/h264_levels: add MaxMBPS checking and update fate test.

2019-03-07 Thread Lin, Decai
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Mark Thompson > Sent: 2019年3月7日 8:24 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] lavc/h264_levels: add MaxMBPS > checking and update fate test. > > On 06/03/2019

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: Reconfigure resolution on-the-fly

2019-03-07 Thread Oliver Collyer
> On 7 Mar 2019, at 23:57, Carl Eugen Hoyos wrote: > > 2019-03-06 15:57 GMT+01:00, Oliver Collyer : >> Hi >> >> I needed the dynamic resolution changing feature of NVENC to be accessible >> through the ffmpeg libraries for a hobby project, so I added support and >> here is a patch. >> >> I

[FFmpeg-devel] [PATCH v4] avformat/mpegts: reduce buffering during initialization

2019-03-07 Thread Andriy Gelman
From: Andriy Gelman Reduces buffering latency with low bitrate streams, where 8192 bytes can mean several seconds. --- libavformat/mpegts.c | 59 +++- 1 file changed, 36 insertions(+), 23 deletions(-) diff --git a/libavformat/mpegts.c

Re: [FFmpeg-devel] [PATCH V3] avcodec/libvpxenc: add VP8 support for ROI-based encoding

2019-03-07 Thread James Zern
On Thu, Feb 28, 2019 at 11:23 PM Guo, Yejun wrote: > > Signed-off-by: Guo, Yejun > --- > libavcodec/libvpxenc.c | 150 > + > 1 file changed, 150 insertions(+) > > diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c > index

Re: [FFmpeg-devel] [PATCH 2/4] lavfi/tonemap: make use of AVFILTER_DEFINE_CLASS

2019-03-07 Thread myp...@gmail.com
On Fri, Mar 8, 2019 at 4:38 AM Michael Niedermayer wrote: > > On Wed, Mar 06, 2019 at 11:18:25AM +0800, Jun Zhao wrote: > > From: Jun Zhao > > > > use AVFILTER_DEFINE_CLASS for defining the filter classes > > > > Signed-off-by: Jun Zhao > > --- > > libavfilter/vf_tonemap.c |8 +--- > >

Re: [FFmpeg-devel] [PATCH V3] lavfi/nlmeans: Checking number precision when computing integral images

2019-03-07 Thread myp...@gmail.com
On Fri, Mar 8, 2019 at 4:28 AM Michael Niedermayer wrote: > On Thu, Mar 07, 2019 at 09:18:42PM +0100, Michael Niedermayer wrote: > > On Thu, Mar 07, 2019 at 09:45:12AM +0800, Jun Zhao wrote: > > > From: Jun Zhao > > > > > > accumulation of 8-bits uint_8 (uint8_t *src) into 32-bits (uint32_t >

[FFmpeg-devel] [PATCH] avcodec/clearvideo: Check remaining data in P frames

2019-03-07 Thread Michael Niedermayer
Fixes: Timeout (19sec -> 419msec) Fixes: 13411/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CLEARVIDEO_fuzzer-5733153811988480 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer ---

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: Reconfigure resolution on-the-fly

2019-03-07 Thread Carl Eugen Hoyos
2019-03-06 15:57 GMT+01:00, Oliver Collyer : > Hi > > I needed the dynamic resolution changing feature of NVENC to be accessible > through the ffmpeg libraries for a hobby project, so I added support and > here is a patch. > > I will format this as a proper patch after any changes necessary

Re: [FFmpeg-devel] Patch for vf_fillborders.c – Bug?

2019-03-07 Thread Michael Niedermayer
On Thu, Mar 07, 2019 at 12:52:32AM +0100, Ulf Zibis wrote: > Hi, > > I think there is a bug in vf_fillborders.c 16 bit routines. > > When using memset or memcopy, I think, correct linesize instead > s->planewidth[p] should be used. > When using arrray syntax, I think, correct s->planewidth[p]

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: Reconfigure resolution on-the-fly

2019-03-07 Thread Timo Rothenpieler
looks good at first glance, will give it a test this weekend. smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] fate/proresenc_aw : Add fate test for interlace and 444 encoding

2019-03-07 Thread Martin Vignali
>> Can you check that and fix it? >> >> > Patch in attach fix for me vsynth3 interlace prores test : make fate-vsynth3-prores_int;make fate-vsynth3-prores_444_int Pass fate test for me (os x X86_64) with and without --enable-memory-poisoning Martin

Re: [FFmpeg-devel] [PATCH] mpegaudiodec_template: add ability to check CRC

2019-03-07 Thread Michael Niedermayer
On Thu, Mar 07, 2019 at 06:32:00PM -0300, James Almer wrote: > On 3/7/2019 6:18 PM, Michael Niedermayer wrote: > > On Wed, Mar 06, 2019 at 07:09:52PM +0100, Lynne wrote: > >> A lot of files have CRC included. > >> The CRC only covers 34 bytes at most from the frame but it should still be > >>

Re: [FFmpeg-devel] [PATCH] mpegaudiodec_template: add ability to check CRC

2019-03-07 Thread James Almer
On 3/7/2019 6:18 PM, Michael Niedermayer wrote: > On Wed, Mar 06, 2019 at 07:09:52PM +0100, Lynne wrote: >> A lot of files have CRC included. >> The CRC only covers 34 bytes at most from the frame but it should still be >> enough for some amount of error detection. > >> mpegaudiodec_template.c |

Re: [FFmpeg-devel] [PATCH] pngdec: add ability to check chunk CRC

2019-03-07 Thread Michael Niedermayer
On Thu, Mar 07, 2019 at 07:26:32PM +0100, Lynne wrote: > By default now, if AV_EF_CRCCHECK or AV_EF_IGNORE_ERR are enabled the decoder > will skip the chunk and carry on with the next one. This should make the   >   > decoder able to decode more corrupt files because the functions which decode

Re: [FFmpeg-devel] [PATCH] mpegaudiodec_template: add ability to check CRC

2019-03-07 Thread Michael Niedermayer
On Wed, Mar 06, 2019 at 07:09:52PM +0100, Lynne wrote: > A lot of files have CRC included. > The CRC only covers 34 bytes at most from the frame but it should still be > enough for some amount of error detection. > mpegaudiodec_template.c | 20 +--- > 1 file changed, 17

Re: [FFmpeg-devel] [PATCH 2/4] lavfi/tonemap: make use of AVFILTER_DEFINE_CLASS

2019-03-07 Thread Michael Niedermayer
On Wed, Mar 06, 2019 at 11:18:25AM +0800, Jun Zhao wrote: > From: Jun Zhao > > use AVFILTER_DEFINE_CLASS for defining the filter classes > > Signed-off-by: Jun Zhao > --- > libavfilter/vf_tonemap.c |8 +--- > 1 files changed, 1 insertions(+), 7 deletions(-) this and similar changes

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc:

2019-03-07 Thread Oliver Collyer
> Hi > > I needed to be able to use the write_data_type callback when reading data > from the mpegts muxer, to make my application aware of key frames in the data > so I added support. I used the matroska implementation as a reference. > > If this is accepted, I will format this as a proper

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: Reconfigure resolution on-the-fly

2019-03-07 Thread Oliver Collyer
> >>> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h >>> index 0ce22ec4fa..7087f82ce1 100644 >>> --- a/libavcodec/avcodec.h >>> +++ b/libavcodec/avcodec.h >>> @@ -3357,6 +3357,12 @@ typedef struct AVCodecContext { >>> * - encoding: unused >>> */ >>>int

Re: [FFmpeg-devel] [PATCH V3] lavfi/nlmeans: Checking number precision when computing integral images

2019-03-07 Thread Michael Niedermayer
On Thu, Mar 07, 2019 at 09:18:42PM +0100, Michael Niedermayer wrote: > On Thu, Mar 07, 2019 at 09:45:12AM +0800, Jun Zhao wrote: > > From: Jun Zhao > > > > accumulation of 8-bits uint_8 (uint8_t *src) into 32-bits (uint32_t *ii) > > data type, it will have a risk of an integral value becoming

Re: [FFmpeg-devel] [PATCH V3] lavfi/nlmeans: Checking number precision when computing integral images

2019-03-07 Thread Michael Niedermayer
On Thu, Mar 07, 2019 at 09:45:12AM +0800, Jun Zhao wrote: > From: Jun Zhao > > accumulation of 8-bits uint_8 (uint8_t *src) into 32-bits (uint32_t *ii) > data type, it will have a risk of an integral value becoming larger than > the 32-bits integer capacity and resulting in an integer overflow.

Re: [FFmpeg-devel] [PATCH v3] avformat/mpegts: reduce buffering during initialization

2019-03-07 Thread Michael Niedermayer
On Wed, Mar 06, 2019 at 10:15:36PM -0500, Andriy Gelman wrote: > From: Andriy Gelman > > Reduces buffering latency with low bitrate streams, where > 8192 bytes can mean several seconds. > --- > libavformat/mpegts.c | 60 +++- > 1 file changed, 37

Re: [FFmpeg-devel] [PATCH v1] avformat/smoothstreamingenc:add bitrate calculate

2019-03-07 Thread Jun Li
Thanks ! Updated to AV_LOG_WARNING, 2nd version patch is here https://patchwork.ffmpeg.org/patch/12237/ On Thu, Mar 7, 2019 at 1:39 AM Steven Liu wrote: > Jun Li 于2019年3月6日周三 上午3:25写道: > > > > From: jun > > > > Calculate bitrate based on fragment size, only applied when > > bitrate is not

[FFmpeg-devel] [PATCH v2] avformat/smoothstreamingenc:add bitrate calculate

2019-03-07 Thread Jun Li
From: jun Calculate bitrate based on fragment size, only applied when bitrate is not set, for example rtsp source. Signed-off-by: Jun Li --- libavformat/smoothstreamingenc.c | 30 +- 1 file changed, 25 insertions(+), 5 deletions(-) diff --git

[FFmpeg-devel] [PATCH] pngdec: add ability to check chunk CRC

2019-03-07 Thread Lynne
By default now, if AV_EF_CRCCHECK or AV_EF_IGNORE_ERR are enabled the decoder will skip the chunk and carry on with the next one. This should make the    decoder able to decode more corrupt files because the functions which decode individual chunks will very likely error out if fed invalid

[FFmpeg-devel] How to make a mp4 file have AVCC box

2019-03-07 Thread Yufei He
Hi I have a problem that the trancoded MP4 file does not have valid AVCC box. It's supposed to have the extradata from the codec. I can only get the extradata after I receive the first encoded frame, while I don't have any frame in my encoder's init function. It seems ffmpeg can only generate

Re: [FFmpeg-devel] ProRes Bitstream Version

2019-03-07 Thread Martin Vignali
> > I'm new to the list, so I would like to first thank you for the great work > of ffmpeg. > > I would like to report a bug on bitstream version on encoded ProRes output. > Currently, ffmpeg always encode with bitstream version 0 even for > (with alpha channel). According to RDD36-2015: > >

[FFmpeg-devel] [PATCH] libavcodec/zmbvenc: Add support for RGB formats

2019-03-07 Thread Matthew Fearnley
This consists mostly of the following changes: - add newly supported pixel formats (RGB555LE, RGB565LE, BGR0) - select the ZMBV format (c->fmt) and bytes per pixel (c->bypp) based on avctx->pix_fmt - multiply widths/x-values by c->bypp, in places where bytes, not pixels, are expected - disable

[FFmpeg-devel] How to make a mp4 file have AVCC box

2019-03-07 Thread Yufei He
Hi James Thanks. I got the extradata from first encoded frame with functions in avcodec.h and examples in ffmpeg.c. My problem is that the trancoded MP4 file does not have valid AVCC box. It's supposed to have the extradata from the codec. I can only get the extradata after I receive the

[FFmpeg-devel] ProRes Bitstream Version

2019-03-07 Thread Vincent Lai
Hi, I'm new to the list, so I would like to first thank you for the great work of ffmpeg. I would like to report a bug on bitstream version on encoded ProRes output. Currently, ffmpeg always encode with bitstream version 0 even for (with alpha channel). According to RDD36-2015: > Version 0

Re: [FFmpeg-devel] fate/proresenc_aw : Add fate test for interlace and 444 encoding

2019-03-07 Thread Martin Vignali
> > These tests fail on all FATE boxes. http://fate.ffmpeg.org/ > > Can you check that and fix it? > > Seems to be related to memory poisoning (pass when disable) : http://fate.ffmpeg.org/report.cgi?time=20190307033138=x86_64-archlinux-gcc-valgrind-no-undef Will take a look. Martin

Re: [FFmpeg-devel] [PATCH v1] avformat/smoothstreamingenc:add bitrate calculate

2019-03-07 Thread Steven Liu
Jun Li 于2019年3月6日周三 上午3:25写道: > > From: jun > > Calculate bitrate based on fragment size, only applied when > bitrate is not set, for example rtsp source. > > Signed-off-by: Jun Li > --- > libavformat/smoothstreamingenc.c | 30 +- > 1 file changed, 25 insertions(+),

Re: [FFmpeg-devel] fate/proresenc_aw : Add fate test for interlace and 444 encoding

2019-03-07 Thread Hendrik Leppkes
On Wed, Feb 27, 2019 at 6:05 PM Martin Vignali wrote: > > > works here > > > > > Pushed, thanks. > These tests fail on all FATE boxes. http://fate.ffmpeg.org/ Can you check that and fix it? - Hendrik ___ ffmpeg-devel mailing list