[FFmpeg-devel] [PATCH] libavcodec/vp9: fix ref-frame size judging method

2019-04-29 Thread Yan Cen
From: Yan Cen There is no need all reference frame demension is valid in libvpx. So this change contains three part: 1. Change each judgement's loglevel from "ERROR" to "WARNING" 2. Make sure at least one of frames that this frame references has valid dimension. 3. All judgements fail would

Re: [FFmpeg-devel] [PATCH V2 7/7] libavfilter/dnn: add more data type support for dnn model input

2019-04-29 Thread Pedro Arthur
Em seg, 29 de abr de 2019 às 22:21, Guo, Yejun escreveu: > > > > > -Original Message- > > From: Pedro Arthur [mailto:bygran...@gmail.com] > > Sent: Tuesday, April 30, 2019 1:47 AM > > To: FFmpeg development discussions and patches > > Cc: Guo, Yejun > > Subject: Re: [FFmpeg-devel]

Re: [FFmpeg-devel] [PATCH V2 7/7] libavfilter/dnn: add more data type support for dnn model input

2019-04-29 Thread Guo, Yejun
> -Original Message- > From: Pedro Arthur [mailto:bygran...@gmail.com] > Sent: Tuesday, April 30, 2019 1:47 AM > To: FFmpeg development discussions and patches > Cc: Guo, Yejun > Subject: Re: [FFmpeg-devel] [PATCH V2 7/7] libavfilter/dnn: add more data type > support for dnn model

Re: [FFmpeg-devel] [PATCH] avcodec/h263dec: Fixed VA API, VDPAU, and VideoToolbox hardware acceleration due to missing `hw_configs` property.

2019-04-29 Thread Michael Niedermayer
On Mon, Apr 29, 2019 at 02:16:53PM -0700, fumoboy...@me.com wrote: > Btw, what’s the difference between `h263` and `h263p`? Its described probably best with the encoders: .name = "h263p", .long_name = NULL_IF_CONFIG_SMALL("H.263+ / H.263-1998 / H.263 version 2"), vs.

Re: [FFmpeg-devel] [PATCH] libavfilter: Add more operation supports in FFmpeg dnn native mode.

2019-04-29 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Pedro Arthur > Sent: Monday, April 29, 2019 11:26 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH] libavfilter: Add more operation supports > in >

[FFmpeg-devel] [PATCH] avcodec/pafvideo: Check input space for decode_0() before slow operations

2019-04-29 Thread Michael Niedermayer
Fixes: Timeout (11sec -> 2sec) Fixes: 14403/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PAF_VIDEO_fuzzer-5697465698746368 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/pafvideo.c | 4

[FFmpeg-devel] [PATCH] avformat/mov: Populate packet duration using `stts` atom instead of guessing.

2019-04-29 Thread fumoboy007
Fixes #7855 (“Last subtitle in MP4 is displayed forever”). --- libavformat/isom.h | 3 + libavformat/mov.c | 158 + 2 files changed, 135 insertions(+), 26 deletions(-) diff --git a/libavformat/isom.h b/libavformat/isom.h index 69452cae8e..b83744ba09

[FFmpeg-devel] [PATCH] avcodec/decode: Do not output subtitle frames if the packet is marked with `AV_PKT_FLAG_DISCARD`.

2019-04-29 Thread fumoboy007
One situation where a subtitle packet can be marked for discard is when demuxing an MOV file that has an edit list. --- libavcodec/decode.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index 6c31166ec2..204bd50fa3 100644

Re: [FFmpeg-devel] [PATCH] avcodec/h263dec: Fixed VA API, VDPAU, and VideoToolbox hardware acceleration due to missing `hw_configs` property.

2019-04-29 Thread fumoboy007
Btw, what’s the difference between `h263` and `h263p`? > On Apr 29, 2019, at 2:12 PM, fumoboy007 wrote: > > Bug originally introduced in commit 758fbc54fef2f31957b5c5f22e05e5fd9b04f631. > --- > libavcodec/h263dec.c | 27 +++ > 1 file changed, 15 insertions(+), 12

[FFmpeg-devel] [PATCH] avcodec/h263dec: Fixed VA API, VDPAU, and VideoToolbox hardware acceleration due to missing `hw_configs` property.

2019-04-29 Thread fumoboy007
Bug originally introduced in commit 758fbc54fef2f31957b5c5f22e05e5fd9b04f631. --- libavcodec/h263dec.c | 27 +++ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/libavcodec/h263dec.c b/libavcodec/h263dec.c index 8385ddfe2e..6f001f6d47 100644 ---

Re: [FFmpeg-devel] [PATCH] libavfilter/f_select: response file support

2019-04-29 Thread Jonathan Gilbert
Ping! :-) Thanks, Jonathan Gilbert On Wed, Apr 17, 2019 at 4:18 AM Jonathan Gilbert wrote: > I've changed the allocation functions and attached the output of `git > format-patch` to this e-mail. > > Thanks, > > Jonathan Gilbert > > On Tue, Apr 16, 2019 at 5:50 PM Carl Eugen Hoyos > wrote: >

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

2019-04-29 Thread Hendrik Leppkes
On Mon, Apr 29, 2019 at 8:35 PM Marton Balint wrote: > We can't really change this for the better unless there is a somewhat > "recognized" authority which has the power to make decisions, rules, and > enforce them. > > I hoped that this can be the voting comitte. The voting commitee is pretty

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

2019-04-29 Thread Carl Eugen Hoyos
2019-04-29 20:34 GMT+02:00, Marton Balint : > Voting is important, because people typically accept > majority decisions even if they don't agree with them. Sounds like an interesting argument. > I believe that this is why several people including > me expressed that NDI removal should only have

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

2019-04-29 Thread Nicolas George
Marton Balint (12019-04-29): > At the moment, it looks to me that FFmpeg is a community without leadership, > enforced rules and consequences. In fact, I consider this the main reason > why people consider working in it an unfriendly experience. > > We can't really change this for the better

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

2019-04-29 Thread Marton Balint
On Mon, 29 Apr 2019, Carl Eugen Hoyos wrote: 2019-04-29 1:02 GMT+02:00, Marton Balint : On Mon, 29 Apr 2019, Carl Eugen Hoyos wrote: 2019-04-28 22:02 GMT+02:00, Marton Balint : 1) Should libNDI support be removed from the ffmpeg codebase? This sounds to me as if you know of an

Re: [FFmpeg-devel] [PATCH] libavfilter/af_astats: fix msvc compile error

2019-04-29 Thread Paul B Mahol
On 4/29/19, Matthias Troffaes wrote: > MSVC requires an explicit cast from void * to void when applying the > ternary conditional operator to switch between methods that return > void. The attached patch fixes the problem. > > For information, log of failed build: > >

Re: [FFmpeg-devel] [PATCH V2 2/7] libavfilter/vf_sr: refine code to remove keyword 'else'

2019-04-29 Thread Carl Eugen Hoyos
2019-04-25 4:14 GMT+02:00, Guo, Yejun : > +} > +else{ Please try to fix this. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

2019-04-29 Thread Carl Eugen Hoyos
2019-04-29 1:02 GMT+02:00, Marton Balint : > > On Mon, 29 Apr 2019, Carl Eugen Hoyos wrote: > >> 2019-04-28 22:02 GMT+02:00, Marton Balint : >> >>> 1) Should libNDI support be removed from the ffmpeg codebase? >> >> This sounds to me as if you know of an alternative to not endorsing >> a company

Re: [FFmpeg-devel] [PATCH V2 7/7] libavfilter/dnn: add more data type support for dnn model input

2019-04-29 Thread Pedro Arthur
Em qua, 24 de abr de 2019 às 23:15, Guo, Yejun escreveu: > > currently, only float is supported as model input, actually, there > are other data types, this patch adds uint8. > > Signed-off-by: Guo, Yejun > --- > libavfilter/dnn_backend_native.c | 4 +++- > libavfilter/dnn_backend_tf.c |

Re: [FFmpeg-devel] [PATCH V2 6/7] libavfilter/dnn: support multiple outputs for tensorflow model

2019-04-29 Thread Pedro Arthur
Em qua, 24 de abr de 2019 às 23:14, Guo, Yejun escreveu: > > some models such as ssd, yolo have more than one output. > > the clean up code in this patch is a little complex, it is because > that set_input_output_tf could be called for many times together > with ff_dnn_execute_model_tf, we have

Re: [FFmpeg-devel] [PATCH V2 4/7] libavfilter/dnn: determine dnn output during execute_model instead of set_input_output

2019-04-29 Thread Pedro Arthur
Em qua, 24 de abr de 2019 às 23:14, Guo, Yejun escreveu: > > Currently, within interface set_input_output, the dims/memory of the > tensorflow > dnn model output is determined by executing the model with zero input, > actually, the output dims might vary with different input data for networks >

Re: [FFmpeg-devel] [PATCH V2 5/7] libavfilter/dnn: avoid memcpy for tensorflow dnn output

2019-04-29 Thread Pedro Arthur
Em qua, 24 de abr de 2019 às 23:14, Guo, Yejun escreveu: > > use TF_Tensor's cpu address to avoid extra memcpy. > > Signed-off-by: Guo, Yejun > --- > libavfilter/dnn_backend_tf.c | 36 > libavfilter/vf_sr.c | 3 --- > 2 files changed, 12

Re: [FFmpeg-devel] [PATCH V2 3/7] libavfilter/dnn: remove limit for the name of DNN model input/output

2019-04-29 Thread Pedro Arthur
Em qua, 24 de abr de 2019 às 23:14, Guo, Yejun escreveu: > > remove the requirment that the name of DNN model input/output > should be "x"/"y", > > Signed-off-by: Guo, Yejun > --- > libavfilter/dnn_backend_native.c | 2 +- > libavfilter/dnn_backend_tf.c | 10 +- >

Re: [FFmpeg-devel] [PATCH V2 2/7] libavfilter/vf_sr: refine code to remove keyword 'else'

2019-04-29 Thread Pedro Arthur
Em qua, 24 de abr de 2019 às 23:14, Guo, Yejun escreveu: > > remove 'else' since there is always 'return' in 'if' scope, > so the code will be clean for later maintenance > > Signed-off-by: Guo, Yejun > --- > libavfilter/vf_sr.c | 143 > ++-- > 1

Re: [FFmpeg-devel] [PATCH V2 1/7] libavfilter/dnn_backend_tf.c: set layer_add_res for input layer

2019-04-29 Thread Pedro Arthur
Em qua, 24 de abr de 2019 às 23:14, Guo, Yejun escreveu: > > otherwise, the following check will return error if layer_add_res > is randomly initialized. > > Signed-off-by: Guo, Yejun > --- > libavfilter/dnn_backend_tf.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [FFmpeg-devel] [PATCH] avformat/aacdec: account for small frame sizes.

2019-04-29 Thread Menno de Gier
On Mon, Apr 29, 2019 at 3:34 PM Hendrik Leppkes wrote: > > On Mon, Apr 29, 2019 at 2:39 PM Menno de Gier wrote: > > > > Some ADTS files have a first frame that's shorter than the 10 bytes that > > are being read while checking for ID3 tags. > > > > Fixes #7271 > > > > James already send another

Re: [FFmpeg-devel] [PATCH] libavfilter: Add more operation supports in FFmpeg dnn native mode.

2019-04-29 Thread Pedro Arthur
Em seg, 29 de abr de 2019 às 00:06, escreveu: > > > > > > -原始邮件- > > 发件人: "Pedro Arthur" > > 发送时间: 2019-04-29 10:42:42 (星期一) > > 收件人: "FFmpeg development discussions and patches" > > 抄送: > > 主题: Re: [FFmpeg-devel] [PATCH] libavfilter: Add more operation supports in > > FFmpeg dnn

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

2019-04-29 Thread James Almer
On 4/29/2019 4:23 AM, Reimar Döffinger wrote: > On 28.04.2019, at 22:02, Marton Balint wrote: > >> Hi All, >> >> There has been discussion on the mailing list several times about the >> inclusion of support for closed source components (codecs, formats, filters, >> etc) in the main ffmpeg

Re: [FFmpeg-devel] [PATCH] avfilter/f_ebur128: use correct type for chl

2019-04-29 Thread Clément Bœsch
On Mon, Apr 29, 2019 at 04:47:52PM +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavfilter/f_ebur128.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/f_ebur128.c b/libavfilter/f_ebur128.c > index f613d8def2..f25d5f096e 100644 > ---

[FFmpeg-devel] [PATCH] avfilter/f_ebur128: use correct type for chl

2019-04-29 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/f_ebur128.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/f_ebur128.c b/libavfilter/f_ebur128.c index f613d8def2..f25d5f096e 100644 --- a/libavfilter/f_ebur128.c +++ b/libavfilter/f_ebur128.c @@ -420,7 +420,7 @@ static

Re: [FFmpeg-devel] [PATCH] avformat/aacdec: account for small frame sizes.

2019-04-29 Thread Hendrik Leppkes
On Mon, Apr 29, 2019 at 2:39 PM Menno de Gier wrote: > > Some ADTS files have a first frame that's shorter than the 10 bytes that > are being read while checking for ID3 tags. > > Fixes #7271 > James already send another patch for this issue - https://patchwork.ffmpeg.org/patch/12913/ - which

[FFmpeg-devel] [PATCH] avformat/aacdec: account for small frame sizes.

2019-04-29 Thread Menno de Gier
Some ADTS files have a first frame that's shorter than the 10 bytes that are being read while checking for ID3 tags. Fixes #7271 Signed-off-by: Menno de Gier --- libavformat/aacdec.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavformat/aacdec.c b/libavformat/aacdec.c index

Re: [FFmpeg-devel] [PATCH, v2] lavc/qsvenc: Fix the memory leak for enc_ctrl.Payload

2019-04-29 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Linjie Fu > Sent: Monday, April 15, 2019 9:23 PM > To: ffmpeg-devel@ffmpeg.org > Cc: Fu, Linjie > Subject: [FFmpeg-devel] [PATCH, v2] lavc/qsvenc: Fix the memory leak for > enc_ctrl.Payload > > frame->enc_ctrl.Payload

[FFmpeg-devel] [PATCH] libavfilter/af_astats: fix msvc compile error

2019-04-29 Thread Matthias Troffaes
MSVC requires an explicit cast from void * to void when applying the ternary conditional operator to switch between methods that return void. The attached patch fixes the problem. For information, log of failed build:

Re: [FFmpeg-devel] [PATCH] libavcodec: QSV protect GPB code with CO3 define

2019-04-29 Thread Li, Zhong
> > But the CODE doesn't say that! > > > > The code uses: > > "#if QSV_HAVE_CO3" > > > > And then every use of the "co3" member needs to be protected by this > clausule. > > Futhermore, this is true in every part of the source code in > > "qsvenc.c"... except at two points (I need to review my

Re: [FFmpeg-devel] [PATCH] avfilter: add bilateral filter

2019-04-29 Thread Moritz Barsnick
Hi Paul, On Sun, Apr 28, 2019 at 16:42:45 +0200, Paul B Mahol wrote: Cosmetic nits: > +Alowed range is from 1 to 6. ^ Allowed > +Alowed range is from 2 to 256. ^ Ditto. > +float *bbufers[256]; ^ I'm not sure of the intent, but would this be "buffers" or "bbuffers"? >

Re: [FFmpeg-devel] [PATCH 5/5] avformat/mxfdec: fix and enhance RIP KLV length checks

2019-04-29 Thread Tomas Härdin
sön 2019-04-28 klockan 22:17 +0200 skrev Marton Balint: > > On Sun, 14 Apr 2019, Tomas Härdin wrote: > > > fre 2019-04-12 klockan 01:09 +0200 skrev Marton Balint: > > > KLV length is BER encoded (variable size), but the code assumed the > > > encoding to > > > always use 4 bytes. > > > > > >

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

2019-04-29 Thread Reimar Döffinger
On 28.04.2019, at 22:02, Marton Balint wrote: > Hi All, > > There has been discussion on the mailing list several times about the > inclusion of support for closed source components (codecs, formats, filters, > etc) in the main ffmpeg codebase. > > Also the removal of libNDI happened without

Re: [FFmpeg-devel] [PATCH] libavformat/mpegtsenc: enforce PCR packets without payload

2019-04-29 Thread Andreas Håkon
‐‐‐ Original Message ‐‐‐ On Thursday, 25 de April de 2019 11:07, Andreas Håkon wrote: > Hi, > > A patch for a new optional parameter for the mpegtsenc muxer. > > Regards. > A.H. > Hi Ali KIZIL, You do the validation tests? Hi Michael Niedermayer, Have you been able to review

Re: [FFmpeg-devel] [PATCH] libavformat: forced PCR pid in mpegts muxer

2019-04-29 Thread Andreas Håkon
‐‐‐ Original Message ‐‐‐ On Tuesday, 23 de April de 2019 14:03, Andreas Håkon wrote: > > Thank you Moritz! > All applied. > > In addition, one correction regarding the initialization. > Sorry, but first version has an error. This is clean! > > Regards. > A.H. > Hi Michael