Re: [FFmpeg-devel] [PATCH v2] avformat/rtpdec_rfc4175: Fix incorrect copy_offset calculation

2019-06-26 Thread Jacob Siddall
> git seems to not like the patch: > > Applying: avformat/rtpdec_rfc4175: Fix incorrect copy_offset calculation > Using index info to reconstruct a base tree... > error: patch failed: libavformat/rtpdec_rfc4175.c:205 > error: libavformat/rtpdec_rfc4175.c: patch does not apply > error: Did you hand

Re: [FFmpeg-devel] [PATCH] hlsenc: Add option to set custom HTTP headers

2019-06-26 Thread Steven Liu
Derek Buitenhuis 于2019年6月27日周四 上午1:04写道: > > Signed-off-by: Derek Buitenhuis > --- > Onward and upward with the never-ending quest to manually forward > all the HTTP options to the subcontexts in every meta-muxer! > --- > doc/muxers.texi | 3 +++ > libavformat/hlsenc.c | 4 > 2 files

Re: [FFmpeg-devel] [PATCH, RFC, v2] lavc/phtread_frame: update context in child thread in multi-thread mode

2019-06-26 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Michael Niedermayer > Sent: Thursday, June 27, 2019 00:29 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH, RFC, v2] lavc/phtread_frame:

[FFmpeg-devel] [PATCH v2] lavf/vf_find_rect: add the dual input support function

2019-06-26 Thread lance . lmwang
From: Limin Wang Please using the below command for the testing: ./ffmpeg -i input.ts -i ref.png -filter_complex find_rect,cover_rect=cover.jpg:mode=cover output.ts I have updated the help document for the function change. Signed-off-by: Limin Wang --- doc/filters.texi | 12

Re: [FFmpeg-devel] [PATCH v2 5/9] lavc/qsvdec: Add VP9 decoder support

2019-06-26 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of James Almer > Sent: Wednesday, June 26, 2019 10:19 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v2 5/9] lavc/qsvdec: Add VP9 decoder > support > > On 6/26/2019 3:00 AM, Li, Zhong wrote: > > > > >

[FFmpeg-devel] [PATCH] lavf/vf_find_rect: add the dual input support function

2019-06-26 Thread lance . lmwang
From: Limin Wang Please using the below command for the testing: ./ffmpeg -i input.ts -i ref.png -filter_complex find_rect,cover_rect=cover.jpg:mode=cover output.ts I have updated the help document for the function change. Signed-off-by: Limin Wang --- doc/filters.texi | 12 +--

[FFmpeg-devel] [PATCH 3/4] avcodec/dxv: Check op_offset in both directions

2019-06-26 Thread Michael Niedermayer
Fixes: signed integer overflow: 61 + 2147483647 cannot be represented in type 'int' Fixes: 15311/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DXV_fuzzer-5742552826773504 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

[FFmpeg-devel] [PATCH 2/4] avcodec/4xm: Fix signed integer overflows in idct()

2019-06-26 Thread Michael Niedermayer
Fixes: signed integer overflow: 20242 * 121095 cannot be represented in type 'int' Fixes: 15310/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FOURXM_fuzzer-5737051745419264 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

[FFmpeg-devel] [PATCH 4/4] avcodec/h264_cavlc: Fix integer overflows with motion vector residual addition

2019-06-26 Thread Michael Niedermayer
Fixes: signed integer overflow: 14 + 2147483647 cannot be represented in type 'int' Fixes: 14794/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_H264_fuzzer-5677380695228416 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

[FFmpeg-devel] [PATCH 1/4] avformat/vividas: Check for input length in get_v()

2019-06-26 Thread Michael Niedermayer
Fixes: out of array read Fixes: 15286/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5658245101780992 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/vividas.c | 11 ++- 1 file

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/vc1_block: Fix invalid shifts in vc1_decode_i_blocks()

2019-06-26 Thread Michael Niedermayer
On Sat, Jun 22, 2019 at 04:55:47PM +0200, Paul B Mahol wrote: > On 6/22/19, Michael Niedermayer wrote: > > Fixes: left shift of negative value -9 > > Fixes: > > 15299/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MSS2_fuzzer-5660922678345728 > > > > Found-by: continuous fuzzing process > >

Re: [FFmpeg-devel] [PATCH] avcodec/utils: Check bits_per_coded_sample

2019-06-26 Thread Michael Niedermayer
On Wed, Jun 19, 2019 at 08:42:55PM +0200, Michael Niedermayer wrote: > This avoids the need for each decoder separately having to handle this case > > Fixes: shift exponent -100663046 is negative > Fixes: out of array access > Fixes: >

Re: [FFmpeg-devel] [PATCH] avcodec/videodsp_template: Fix overflow of addition

2019-06-26 Thread Michael Niedermayer
On Fri, Jun 21, 2019 at 09:07:38AM +0200, Reimar Döffinger wrote: > > > On 18.06.2019, at 16:25, Michael Niedermayer wrote: > > > Fixes: addition of unsigned offset to 0x7f56fc26a9b6 overflowed to > > 0x7f56fc26a8be* > > Fixes: > >

Re: [FFmpeg-devel] [PATCH 4/7] avcodec/alsdec: Fix invalid shift in multiply()

2019-06-26 Thread Michael Niedermayer
On Fri, Jun 21, 2019 at 12:47:18AM +0200, Michael Niedermayer wrote: > Fixes: shift exponent -24 is negative > Fixes: > 15292/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-5768533318828032 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 7/7] avcodec/4xm: Fix vlc memleak

2019-06-26 Thread Michael Niedermayer
On Fri, Jun 21, 2019 at 12:47:21AM +0200, Michael Niedermayer wrote: > Fixes: memleak > Fixes: > 15297/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FOURXM_fuzzer-5746203548975104 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

Re: [FFmpeg-devel] [PATCH 1/6] avcodec/rv10: Avoid calculating undefined value that is unused

2019-06-26 Thread Michael Niedermayer
On Sun, Jun 16, 2019 at 07:48:45PM +0200, Michael Niedermayer wrote: > Fixes: shift exponent 64 is too large for 32-bit type 'int' > Fixes: > 15253/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RV10_fuzzer-5671114300194816 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH] avcodec: add delayer bitstream filter

2019-06-26 Thread Reimar Döffinger
On 26.06.2019, at 13:15, Andreas Håkon wrote: > Hi Moritz, > >>> Wouldn't this be better if extended to be a BSF version of setpts? In >>> addition to delays, rescaling as well as other ops could be carried out >>> on TS. >> >> I second that notion, or at least the suggestion of a setpts

Re: [FFmpeg-devel] [PATCH] Add DICOM Support

2019-06-26 Thread Shivam
On 6/26/19 4:37 PM, Michael Niedermayer wrote: On Wed, Jun 26, 2019 at 09:54:56AM +0200, Paul B Mahol wrote: On 6/26/19, Michael Niedermayer wrote: On Tue, Jun 25, 2019 at 01:52:09PM +0530, Shivam wrote: On 6/25/19 2:12 AM, Michael Niedermayer wrote: On Mon, Jun 24, 2019 at 09:18:13PM

Re: [FFmpeg-devel] [PATCH] libavformat/mux: Fix audio_preload

2019-06-26 Thread Michael Niedermayer
On Mon, Jun 24, 2019 at 11:16:18PM +0200, Andreas Rheinhardt wrote: > Commit 31f9032b added the audio_preload feature; its goal is to > interleave audio earlier than the rest. Unfortunately, it has never ever > worked, because the check for whether a packet should be interleaved > before or after

[FFmpeg-devel] [PATCH] hlsenc: Add option to set custom HTTP headers

2019-06-26 Thread Derek Buitenhuis
Signed-off-by: Derek Buitenhuis --- Onward and upward with the never-ending quest to manually forward all the HTTP options to the subcontexts in every meta-muxer! --- doc/muxers.texi | 3 +++ libavformat/hlsenc.c | 4 2 files changed, 7 insertions(+) diff --git a/doc/muxers.texi

Re: [FFmpeg-devel] [PATCH, RFC, v2] lavc/phtread_frame: update context in child thread in multi-thread mode

2019-06-26 Thread Michael Niedermayer
On Wed, Jun 26, 2019 at 04:24:52PM -0400, Linjie Fu wrote: > Currently in ff_thread_decode_frame, context is updated from child thread > to main thread, and main thread releases the context in avcodec_close() > when decode finishes. > > However, when resolution/format change in vp9, ff_get_format

Re: [FFmpeg-devel] print pts as min:sec

2019-06-26 Thread Paul B Mahol
On 6/26/19, Ulf Zibis wrote: > > Am 26.06.19 um 12:26 schrieb Moritz Barsnick: >> This list is for the development *of* ffmpeg and its libraries. For the >> use of the libraries and the development *with* them, please turn to >> the mailing list "libav-user". > > Sorry, if I misunderstood. > >

Re: [FFmpeg-devel] [PATCH v2 5/9] lavc/qsvdec: Add VP9 decoder support

2019-06-26 Thread James Almer
On 6/26/2019 3:00 AM, Li, Zhong wrote: > > >> -Original Message- >> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf >> Of Li, Zhong >> Sent: Tuesday, April 16, 2019 10:32 AM >> To: FFmpeg development discussions and patches >> >> Subject: Re: [FFmpeg-devel] [PATCH

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/hevc_ps: Fix integer overflow with num_tile_rows and num_tile_columns

2019-06-26 Thread James Almer
On 6/26/2019 9:41 AM, Michael Niedermayer wrote: > On Tue, Jun 25, 2019 at 10:30:45AM -0300, James Almer wrote: >> On 6/25/2019 5:55 AM, Michael Niedermayer wrote: >>> Fixes: signed integer overflow: -2147483648 - 1 cannot be represented in >>> type 'int' >>> Fixes: >>>

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/hevc_ps: Fix integer overflow with num_tile_rows and num_tile_columns

2019-06-26 Thread Michael Niedermayer
On Tue, Jun 25, 2019 at 10:30:45AM -0300, James Almer wrote: > On 6/25/2019 5:55 AM, Michael Niedermayer wrote: > > Fixes: signed integer overflow: -2147483648 - 1 cannot be represented in > > type 'int' > > Fixes: > >

Re: [FFmpeg-devel] [PATCH v10 1/2] lavf/vf_transpose: add exif orientation support

2019-06-26 Thread Steven Liu
Jun Li 于2019年6月25日周二 上午9:26写道: > > On Mon, Jun 17, 2019 at 5:31 PM Jun Li wrote: > > > > > > > On Sat, Jun 15, 2019 at 7:09 PM Jun Li wrote: > > > >> > >> > >> On Tue, Jun 11, 2019 at 7:05 PM Jun Li wrote: > >> > >>> > >>> On Sun, Jun 9, 2019 at 2:28 PM Jun Li wrote: > >>> > Add exif

Re: [FFmpeg-devel] [PATCH v2] avformat/rtpdec_rfc4175: Fix incorrect copy_offset calculation

2019-06-26 Thread Michael Niedermayer
On Tue, Jun 25, 2019 at 06:47:30AM +, Jacob Siddall wrote: > The previous calculation code did not account for the fact that the > copy_offset for the start of the frame array is at index 0, yet the > scan line number from the rfc4175 RTP header starts at 1. > This caused 2 issues to appear: >

[FFmpeg-devel] [PATCH] lavc/videotoolboxenc: add hdr10, linear, hlg color transfer function for videotoolboxenc

2019-06-26 Thread lance . lmwang
From: Limin Wang Below is the testing ffmpeg command for the setting: ./ffmpeg -i input.ts -c:v hevc_videotoolbox -color_primaries bt2020 -colorspace bt2020_ncl -color_trc smpte2084 smpte2048.ts ./ffmpeg -i input.ts -c:v hevc_videotoolbox -color_primaries bt2020 -colorspace bt2020_ncl

Re: [FFmpeg-devel] [PATCH] avcodec: add delayer bitstream filter

2019-06-26 Thread Andreas Håkon
Hi Moritz, > > Wouldn't this be better if extended to be a BSF version of setpts? In > > addition to delays, rescaling as well as other ops could be carried out > > on TS. > > I second that notion, or at least the suggestion of a setpts bsf. > > IMO, there is probably some functionality in

Re: [FFmpeg-devel] [PATCH] Add DICOM Support

2019-06-26 Thread Michael Niedermayer
On Wed, Jun 26, 2019 at 09:54:56AM +0200, Paul B Mahol wrote: > On 6/26/19, Michael Niedermayer wrote: > > On Tue, Jun 25, 2019 at 01:52:09PM +0530, Shivam wrote: > >> > >> On 6/25/19 2:12 AM, Michael Niedermayer wrote: > >> >On Mon, Jun 24, 2019 at 09:18:13PM +0530, Shivam wrote: > >> >>Hi! > >>

Re: [FFmpeg-devel] print pts as min:sec

2019-06-26 Thread Ulf Zibis
Am 26.06.19 um 12:26 schrieb Moritz Barsnick: > This list is for the development *of* ffmpeg and its libraries. For the > use of the libraries and the development *with* them, please turn to > the mailing list "libav-user". Sorry, if I misunderstood. I'm in progress to develop a new filter and

Re: [FFmpeg-devel] print pts as min:sec

2019-06-26 Thread Moritz Barsnick
On Tue, Jun 25, 2019 at 23:13:51 +0200, Ulf Zibis wrote: > is there a functionality in the ffmpeg library to print AVFrame pts > values in respect to AVRational time_base in human readable form? This list is for the development *of* ffmpeg and its libraries. For the use of the libraries and the

Re: [FFmpeg-devel] [PATCH] avcodec: add delayer bitstream filter

2019-06-26 Thread Moritz Barsnick
On Wed, Jun 26, 2019 at 01:06:56 +0530, Gyan wrote: > Wouldn't this be better if extended to be a BSF version of setpts? In > addition to delays, rescaling as well as other ops could be carried out > on TS. I second that notion, or at least the suggestion of a setpts bsf. IMO, there is probably

Re: [FFmpeg-devel] [PATCH, RFC] lavc/phtread_frame: update context in child thread in multi-thread mode

2019-06-26 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Hendrik Leppkes > Sent: Wednesday, June 26, 2019 15:12 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH, RFC] lavc/phtread_frame: update

[FFmpeg-devel] [PATCH, RFC, v2] lavc/phtread_frame: update context in child thread in multi-thread mode

2019-06-26 Thread Linjie Fu
Currently in ff_thread_decode_frame, context is updated from child thread to main thread, and main thread releases the context in avcodec_close() when decode finishes. However, when resolution/format change in vp9, ff_get_format was called, and hwaccel_uninit() and hwaccel_init will be used to

Re: [FFmpeg-devel] [PATCH] Add DICOM Support

2019-06-26 Thread Paul B Mahol
On 6/26/19, Michael Niedermayer wrote: > On Tue, Jun 25, 2019 at 01:52:09PM +0530, Shivam wrote: >> >> On 6/25/19 2:12 AM, Michael Niedermayer wrote: >> >On Mon, Jun 24, 2019 at 09:18:13PM +0530, Shivam wrote: >> >>Hi! >> >> >> >> The code is to add DICOM Support. The patch is only for >> >>

Re: [FFmpeg-devel] [PATCH] Add DICOM Support

2019-06-26 Thread Michael Niedermayer
On Tue, Jun 25, 2019 at 01:52:09PM +0530, Shivam wrote: > > On 6/25/19 2:12 AM, Michael Niedermayer wrote: > >On Mon, Jun 24, 2019 at 09:18:13PM +0530, Shivam wrote: > >>Hi! > >> > >>     The code is to add DICOM Support. The patch is only for uncompressed > >>dicom files using explicit value

Re: [FFmpeg-devel] [PATCH] libavformat/mpegtsenc: new interlaced mux mode

2019-06-26 Thread Andreas Håkon
Hi Marton, > Ok. But I believe the correct term for this is "interleaved". I have > never heard "interlaced" used for TS packets. I feel you're right: the name "interleaved mux mode" is preferable. Thank you for pointing it out! > > > > +#define PES_START 1 /* 0001 / > > > > +#define

Re: [FFmpeg-devel] [PATCH, RFC] lavc/phtread_frame: update context in child thread in multi-thread mode

2019-06-26 Thread Hendrik Leppkes
On Wed, Jun 26, 2019 at 9:06 AM Linjie Fu wrote: > > Currently in ff_thread_decode_frame, context is updated from child thread > to main thread, and main thread releases the context in avcodec_close() > when decode finishes. > > However, when resolution/format change in vp9, ff_get_format was

Re: [FFmpeg-devel] [PATCH] avcodec: add delayer bitstream filter

2019-06-26 Thread Andreas Håkon
Hi Gyan, > > > Example of use: > > > ffmpeg -f mpegts -i INPUT.ts -map i:101 -c:v copy -map i:102 -bsf:a > > > delayer=offset=3600 -c:a copy -f mpegts OUTPUT.ts > > > You can use it with VIDEO, AUDIO or DATA streams. > > > > What's the advantage over output_ts_offset? > > To answer that

Re: [FFmpeg-devel] [PATCH] avcodec: add delayer bitstream filter

2019-06-26 Thread Andreas Håkon
Hi, > - Andreas Rheinhardt: > > Example of use: > > ffmpeg -f mpegts -i INPUT.ts -map i:101 -c:v copy -map i:102 -bsf:a > > delayer=offset=3600 -c:a copy -f mpegts OUTPUT.ts > > The delay applied here depends on the timebase. Wouldn't it be more > user-friendly to let the user input the

[FFmpeg-devel] [PATCH, RFC] lavc/phtread_frame: update context in child thread in multi-thread mode

2019-06-26 Thread Linjie Fu
Currently in ff_thread_decode_frame, context is updated from child thread to main thread, and main thread releases the context in avcodec_close() when decode finishes. However, when resolution/format change in vp9, ff_get_format was called, and hwaccel_uninit() and hwaccel_init will be used to

Re: [FFmpeg-devel] [PATCH v2 5/9] lavc/qsvdec: Add VP9 decoder support

2019-06-26 Thread Li, Zhong
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Li, Zhong > Sent: Tuesday, April 16, 2019 10:32 AM > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PATCH v2 5/9] lavc/qsvdec: Add VP9 decoder > support >