[FFmpeg-devel] [PATCH] avformat/avformat.h: Correct some comments

2019-08-16 Thread Andreas Rheinhardt
1. When set_parameters was removed from AVOutputFormat in 2fb75019, it was forgotten to remove the comment pertaining to it. Said comment now appeared to apply to interleave_packet; it is of course nonsense and has been replaced by an accurate description. 2. The description of

Re: [FFmpeg-devel] [PATCH 11/11] avformat/internal: Remove packet for extract_extradata

2019-08-16 Thread Andreas Rheinhardt
Hendrik Leppkes: > On Fri, Aug 16, 2019 at 5:22 AM Andreas Rheinhardt > wrote: >> >> The effective lifetime of the packet does not extend beyond the >> extract_extradata in libavformat/utils.c, so the packet can simply be >> put on the stack there. This allows to remove the allocation and the >>

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: Fix seeking

2019-08-16 Thread James Almer
On 8/16/2019 9:27 PM, Andreas Rheinhardt wrote: > matroska_reset_status (a function that is used during seeking (among > other things)) used an int for the return value of avio_seek which > returns an int64_t. Checking the return value then indicated an error > even though the seek was successfull

[FFmpeg-devel] [PATCH] avformat/matroskadec: Fix seeking

2019-08-16 Thread Andreas Rheinhardt
matroska_reset_status (a function that is used during seeking (among other things)) used an int for the return value of avio_seek which returns an int64_t. Checking the return value then indicated an error even though the seek was successfull for targets in the range of 2GB-4GB, 6GB-8GB, ... This

[FFmpeg-devel] [PATCH v1] avcodec/h264_mp4toannexb_bsf: force sps/pps writing before the first pict

2019-08-16 Thread Jun Li
Fix #6869, write sps/pps before the first picture nal, no matter what type of picture it is. --- libavcodec/h264_mp4toannexb_bsf.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/libavcodec/h264_mp4toannexb_bsf.c b/libavcodec/h264_mp4toannexb_bsf.c index

[FFmpeg-devel] [PATCH v1] avcodec/h264_mp4toannexb_bsf: force sps/pps writing before the first pict

2019-08-16 Thread Jun Li
Hi, This patch is trying to fix #6869. The ticket has a h264 stream NOT starting with IDR, and all frames are I frames. And the mp4toannexb filter insert SPS/PPS before IDR, so leads to the result that the output has no SPS/PPS. The fix is just simply insert SPS/PPS before first picture, no

Re: [FFmpeg-devel] [PATCH 1/1] avformat/matroska: fully parse stsd atom in v_quicktime tracks

2019-08-16 Thread Michael Niedermayer
On Thu, Aug 15, 2019 at 07:59:28AM +0200, Stanislav Ionascu wrote: > Hi, > > On Wed, Aug 14, 2019 at 11:50 PM Michael Niedermayer > wrote: > > > > On Wed, Aug 14, 2019 at 08:44:11PM +0200, Stanislav Ionascu wrote: > > > On Tue, Aug 13, 2019 at 10:22 PM Andreas Rheinhardt > > > wrote: > > > > >

Re: [FFmpeg-devel] [PATCH] libavformat/mxfenc: Allow more bitrates for NTSC IMX50

2019-08-16 Thread James Almer
On 8/16/2019 7:32 PM, Tomas Härdin wrote: > fre 2019-08-16 klockan 19:26 -0300 skrev James Almer: >> On 8/16/2019 6:31 PM, Tomas Härdin wrote: >>> tor 2019-08-15 klockan 13:55 +0200 skrev Thomas Mundt: Am Do., 15. Aug. 2019 um 11:01 Uhr schrieb Tomas Härdin : > ons 2019-08-14 klockan

Re: [FFmpeg-devel] [PATCH] libavformat/mxfenc: Allow more bitrates for NTSC IMX50

2019-08-16 Thread Tomas Härdin
fre 2019-08-16 klockan 19:26 -0300 skrev James Almer: > On 8/16/2019 6:31 PM, Tomas Härdin wrote: > > tor 2019-08-15 klockan 13:55 +0200 skrev Thomas Mundt: > > > Am Do., 15. Aug. 2019 um 11:01 Uhr schrieb Tomas Härdin > > > > > > : > > > > ons 2019-08-14 klockan 22:18 +0200 skrev Thomas Mundt:

Re: [FFmpeg-devel] [PATCH] libavformat/mxfenc: Allow more bitrates for NTSC IMX50

2019-08-16 Thread James Almer
On 8/16/2019 6:31 PM, Tomas Härdin wrote: > tor 2019-08-15 klockan 13:55 +0200 skrev Thomas Mundt: >> Am Do., 15. Aug. 2019 um 11:01 Uhr schrieb Tomas Härdin >> : >>> ons 2019-08-14 klockan 22:18 +0200 skrev Thomas Mundt: Hi Tomas, Am Mi., 14. Aug. 2019 um 12:42 Uhr schrieb Tomas

Re: [FFmpeg-devel] [PATCH 1/8] avcodec/cinepak: Require 1 bit per 4x4 block as minimum input

2019-08-16 Thread Tomas Härdin
fre 2019-08-16 klockan 14:57 +0200 skrev Tomas Härdin: > fre 2019-08-16 klockan 00:50 +0200 skrev Michael Niedermayer: > > On Thu, Aug 15, 2019 at 04:43:19PM +0200, Tomas Härdin wrote: > > > ons 2019-08-14 klockan 12:32 +0200 skrev Tomas Härdin: > > > > mån 2019-08-12 klockan 21:17 +0200 skrev

Re: [FFmpeg-devel] [PATCH] libavformat/mxfenc: Allow more bitrates for NTSC IMX50

2019-08-16 Thread Tomas Härdin
tor 2019-08-15 klockan 13:55 +0200 skrev Thomas Mundt: > Am Do., 15. Aug. 2019 um 11:01 Uhr schrieb Tomas Härdin > : > > ons 2019-08-14 klockan 22:18 +0200 skrev Thomas Mundt: > > > Hi Tomas, > > > > > > Am Mi., 14. Aug. 2019 um 12:42 Uhr schrieb Tomas Härdin < > > tjop...@acc.umu.se > > > > : >

Re: [FFmpeg-devel] [PATCH 0/3] Dolby TrueHD support in ISO BMFF

2019-08-16 Thread James Almer
On 8/16/2019 6:17 PM, James Almer wrote: > https://developer.dolby.com/globalassets/technology/dolby-truehd/dolbytruehdbitstreamswithintheisobasemediafileformat.pdf > > There's no software i could find that supports this, so mine is the first > implementation out there. It's therefore tested with

[FFmpeg-devel] [PATCH 0/3] Dolby TrueHD support in ISO BMFF

2019-08-16 Thread James Almer
https://developer.dolby.com/globalassets/technology/dolby-truehd/dolbytruehdbitstreamswithintheisobasemediafileformat.pdf There's no software i could find that supports this, so mine is the first implementation out there. It's therefore tested with itself :p James Almer (3): avcodec/mlp_parse:

[FFmpeg-devel] [PATCH 3/3] avformat/movenc: add muxing support for Dolby TrueHD streams

2019-08-16 Thread James Almer
Signed-off-by: James Almer --- libavformat/movenc.c | 61 +++- 1 file changed, 60 insertions(+), 1 deletion(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index a96139077b..adb5cd0e5a 100644 --- a/libavformat/movenc.c +++

[FFmpeg-devel] [PATCH 2/3] avformat/mov: add demuxing support for Dolby TrueHD streams

2019-08-16 Thread James Almer
Signed-off-by: James Almer --- libavformat/isom.c | 1 + libavformat/mov.c | 34 ++ 2 files changed, 35 insertions(+) diff --git a/libavformat/isom.c b/libavformat/isom.c index c4880878c1..fa2e318099 100644 --- a/libavformat/isom.c +++ b/libavformat/isom.c @@

[FFmpeg-devel] [PATCH 1/3] avcodec/mlp_parse: move TrueHD channel layout and sample rate related code to the header

2019-08-16 Thread James Almer
It will be needed by the next commit. Signed-off-by: James Almer --- libavcodec/mlp_parse.c | 50 -- libavcodec/mlp_parse.h | 49 + 2 files changed, 49 insertions(+), 50 deletions(-) diff --git

[FFmpeg-devel] [PATCH] libavutil: AVEncodeInfo data structures

2019-08-16 Thread Juan De León
AVEncodeInfoFrame data structure to store as AVFrameSideData of type AV_FRAME_DATA_ENCODE_INFO. The structure stores quantization index for each plane, DC/AC deltas for luma and chroma planes, and an array of AVEncodeInfoBlock type denoting position, size, and delta quantizer for each block in the

Re: [FFmpeg-devel] [PATCH] Change libaom default to crf=28.

2019-08-16 Thread James Zern
Hi, On Thu, Aug 15, 2019 at 1:22 PM elliottk wrote: > > Current default is 256kbps, which produces inconsistent > results (too high for low-res, too low for hi-res). > Use CRF instead, which will adapt. > --- > libavcodec/libaomenc.c | 9 + > 1 file changed, 5 insertions(+), 4

Re: [FFmpeg-devel] [PATCH] libavformat/rtspdec: Don't send teardown if rtsp_hd_out is null

2019-08-16 Thread Ross Nicholson
Need anything else Moritz? > On 14 Aug 2019, at 09:54, Ross Nicholson wrote: > > I would imagine that the way Kodi handles the stream, rtsp_hd_out is null as > per the following: > > URLContext * rtsp_hd_out > Additional output handle, used when input and output are done > separately,

[FFmpeg-devel] [PATCH 2/3] avformat/internal: Improve documentation of ff_packet_list_get

2019-08-16 Thread Andreas Rheinhardt
The documentation of ff_packet_list_get currently didn't match the actual usage: 1. It said that the destination packet is supposed to be initialized. But this makes no sense given that it will be overwritten completely and flacenc, mp3enc and ttaenc ignored this. 2. ff_packet_list_get returns an

[FFmpeg-devel] [PATCH 3/3] avformat/utils: Preserve integrity of linked list

2019-08-16 Thread Andreas Rheinhardt
1. Instead of relying on ff_packet_list_get to get the oldest element in an AVPacketList, ff_read_packet used its own ad-hoc code. Said code forgot to set the end of the list to NULL if the last element of the list has been removed, thereby leaving the list in an inconsistent state. 2.

[FFmpeg-devel] [PATCH 1/3] avformat/utils: Fix memleaks

2019-08-16 Thread Andreas Rheinhardt
ff_read_packet had several potential memleaks: 1. If av_packet_make_refcounted fails, it means that the packet is not refcounted, but it could nevertheless carry side data and therefore needs to be unreferenced. 2. If a packet happens to have an illegal stream index (i.e. one that does not

Re: [FFmpeg-devel] [v3] avformat/flvdec: delete unused code

2019-08-16 Thread Tao Zhang
ping. leozhang 于2019年8月14日周三 上午11:07写道: > > Reviewed-by: Carl Eugen Hoyos > Signed-off-by: leozhang > --- > libavformat/flvdec.c | 17 - > 1 file changed, 17 deletions(-) > > diff --git a/libavformat/flvdec.c b/libavformat/flvdec.c > index b531a39..6bfe624 100644 > ---

Re: [FFmpeg-devel] [PATCH 05/11] avcodec/h264_parser: Reuse the RBSP buffer

2019-08-16 Thread Andreas Rheinhardt
Kieran Kunhya: > On Fri, 16 Aug 2019 at 06:08, Andreas Rheinhardt < > andreas.rheinha...@gmail.com> wrote: > >> Kieran Kunhya: >>> On Fri, 16 Aug 2019 at 04:20, Andreas Rheinhardt < >>> andreas.rheinha...@gmail.com> wrote: >>> Up until now, the H.264 parser has allocated a new buffer for

Re: [FFmpeg-devel] [PATCH V2] FATE/dnn: let fate/dnn tests depend on ffmpeg static libraries

2019-08-16 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Guo, Yejun > Sent: Wednesday, August 7, 2019 10:44 AM > To: ffmpeg-devel@ffmpeg.org > Cc: Guo, Yejun > Subject: [FFmpeg-devel] [PATCH V2] FATE/dnn: let fate/dnn tests depend on > ffmpeg static libraries > > background:

Re: [FFmpeg-devel] [PATCH 05/11] avcodec/h264_parser: Reuse the RBSP buffer

2019-08-16 Thread Kieran Kunhya
On Fri, 16 Aug 2019 at 06:08, Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Kieran Kunhya: > > On Fri, 16 Aug 2019 at 04:20, Andreas Rheinhardt < > > andreas.rheinha...@gmail.com> wrote: > > > >> Up until now, the H.264 parser has allocated a new buffer for every > >> frame in order

Re: [FFmpeg-devel] [PATCH 1/8] avcodec/cinepak: Require 1 bit per 4x4 block as minimum input

2019-08-16 Thread Tomas Härdin
fre 2019-08-16 klockan 00:50 +0200 skrev Michael Niedermayer: > On Thu, Aug 15, 2019 at 04:43:19PM +0200, Tomas Härdin wrote: > > ons 2019-08-14 klockan 12:32 +0200 skrev Tomas Härdin: > > > mån 2019-08-12 klockan 21:17 +0200 skrev Michael Niedermayer: > > > > Fixes: Timeout (12sec -> 32ms) > > >

Re: [FFmpeg-devel] [PATCH v2] avformat/http: Fixes #7975. Before reusing the connection the headers are checked to see if the server is closing the connection.

2019-08-16 Thread Ian Klassen
Pasting it into an email may not have been a good idea... here it is as an attachment. Thanks. On Fri, Aug 16, 2019 at 4:35 AM Michael Niedermayer wrote: > On Thu, Aug 15, 2019 at 05:14:38PM -0500, Ian Klassen wrote: > > Hi, > > > > Sorry Moritz, I somehow missed your feedback. Here's an

Re: [FFmpeg-devel] [PATCH 5/7] avcodec/anm: Check input size for a frame with just a stop code

2019-08-16 Thread Peter Ross
On Thu, Aug 15, 2019 at 11:49:13PM +0200, Michael Niedermayer wrote: > Fixes: Timeout (11sec -> 6sec) > Fixes: > 16344/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ANM_fuzzer-5673032000995328 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH v6] avfilter/avf_aphasemeter: Add out-of-phase and mono detection

2019-08-16 Thread Romane Lafon
> > +{ "duration", "set minimum mono or out-of-phase duration in > seconds", OFFSET(duration), AV_OPT_TYPE_DOUBLE, {.dbl=2.}, 0, 24*60*60, > FLAGS }, > > ffmpeg also provides a AV_OPT_TYPE_DURATION. (This may have been > discussed before - sorry if so.) AV_OPT_TYPE_DURATION is used as an

Re: [FFmpeg-devel] [PATCH] libavutil: AVEncodeInfo data structures (fwd)

2019-08-16 Thread Nicolas George
- Forwarded message from Nicolas George - Date: Fri, 16 Aug 2019 13:55:18 +0200 From: Nicolas George To: Juan De León Subject: Re: [FFmpeg-devel] [PATCH] libavutil: AVEncodeInfo data structures Juan De León (12019-08-15): > I don't think it's common for size_t to wrap around. size_t

Re: [FFmpeg-devel] [PATCH 1/2] avutil: Add Simple loop detector

2019-08-16 Thread Paul B Mahol
On Fri, Aug 16, 2019 at 1:03 PM Nicolas George wrote: > Michael Niedermayer (12019-08-16): > > irc logs off? irc logs off. > > carl not here? carl not here. > > nicolas is an awful person who disagrees with everything and > does no work like ever, yet hangs around the ml to be obnoxious > >

Re: [FFmpeg-devel] [PATCH 1/2] avutil: Add Simple loop detector

2019-08-16 Thread Nicolas George
Michael Niedermayer (12019-08-16): > irc logs off? irc logs off. > carl not here? carl not here. > nicolas is an awful person who disagrees with everything and does no > work like ever, yet hangs around the ml to be obnoxious > his opinions on asserts should disqualify him from working on any

[FFmpeg-devel] [PATCH] libavcodec: add editpts bitstream filter [v4]

2019-08-16 Thread Andreas Håkon
Hi, The latest version ready to merge of the bitstream filter "editpts". Implements all requests. This supersedes: https://patchwork.ffmpeg.org/patch/14302/ https://patchwork.ffmpeg.org/patch/14195/ https://patchwork.ffmpeg.org/patch/13743/ https://patchwork.ffmpeg.org/patch/13699/ I hope

Re: [FFmpeg-devel] [PATCH 1/2] avutil: Add Simple loop detector

2019-08-16 Thread Paul B Mahol
On Fri, Aug 16, 2019 at 10:35 AM Michael Niedermayer wrote: > On Wed, Aug 14, 2019 at 10:46:19PM +0200, Lynne wrote: > > Aug 14, 2019, 19:29 by mich...@niedermayer.cc: > > > > > On Tue, Aug 13, 2019 at 12:11:30PM +0200, Lynne wrote: > > > > > >> Aug 12, 2019, 20:53 by mich...@niedermayer.cc: > >

Re: [FFmpeg-devel] [PATCH v2] avformat/http: Fixes #7975. Before reusing the connection the headers are checked to see if the server is closing the connection.

2019-08-16 Thread Michael Niedermayer
On Thu, Aug 15, 2019 at 05:14:38PM -0500, Ian Klassen wrote: > Hi, > > Sorry Moritz, I somehow missed your feedback. Here's an updated patch with > the fixed formatting. I also set up a server that you can test with. Try: > > ffmpeg -i test.mp4 -hls_flags +append_list -hls_time 6 -method PUT >

Re: [FFmpeg-devel] [REQUEST] ffmpeg-security subscription

2019-08-16 Thread Paul B Mahol
On Fri, Aug 16, 2019 at 3:39 AM Reimar Döffinger wrote: > > > On 15.08.2019, at 19:38, Paul B Mahol wrote: > > > On Thu, Aug 15, 2019 at 7:20 PM Reimar Döffinger < > reimar.doeffin...@gmx.de> > > wrote: > > > >> On 15.08.2019, at 13:15, Vittorio Giovara > >> wrote: > >>> I think being on the

[FFmpeg-devel] irc logs mailing list ffmpeg-devel-irc

2019-08-16 Thread Michael Niedermayer
Hi all as some noticed there are missing logs on the ffmpeg-devel-irc archives. And it seemed some people on IRC think there is no logging. I just want to confirm that the IRC topic is accurate and the channels are logged. The only problem that iam aware of is a problem between the logger and the

Re: [FFmpeg-devel] [PATCH 11/11] avformat/internal: Remove packet for extract_extradata

2019-08-16 Thread Hendrik Leppkes
On Fri, Aug 16, 2019 at 5:22 AM Andreas Rheinhardt wrote: > > The effective lifetime of the packet does not extend beyond the > extract_extradata in libavformat/utils.c, so the packet can simply be > put on the stack there. This allows to remove the allocation and the > corresponding frees. > >

[FFmpeg-devel] [PATCH] lavf/tls_gnutls: check for interrupt inside handshake loop

2019-08-16 Thread Błażej Szczygieł
fixes #8080 Signed-off-by: Błażej Szczygieł --- libavformat/tls_gnutls.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/tls_gnutls.c b/libavformat/tls_gnutls.c index f32bc2821b..f507b7d044 100644 --- a/libavformat/tls_gnutls.c +++ b/libavformat/tls_gnutls.c @@ -184,6

Re: [FFmpeg-devel] [PATCH 1/2] avutil: Add Simple loop detector

2019-08-16 Thread Michael Niedermayer
On Wed, Aug 14, 2019 at 10:46:19PM +0200, Lynne wrote: > Aug 14, 2019, 19:29 by mich...@niedermayer.cc: > > > On Tue, Aug 13, 2019 at 12:11:30PM +0200, Lynne wrote: > > > >> Aug 12, 2019, 20:53 by mich...@niedermayer.cc: > >> > >> > On Sun, Aug 11, 2019 at 08:30:51PM +0200, Reimar Döffinger

Re: [FFmpeg-devel] libavcodec: add timeshift bitstream filter [v3]

2019-08-16 Thread Andreas Håkon
Hi, ‐‐‐ Original Message ‐‐‐ On Saturday, 10 de August de 2019 20:05, Andreas Håkon wrote: > Hi Gyan and Nicolas, > > ‐‐‐ Original Message ‐‐‐ > On Saturday, 10 de August de 2019 17:13, Nicolas George geo...@nsup.org wrote: > > > Gyan (12019-08-10): > > > > > Since both pts

Re: [FFmpeg-devel] [PATCHv2 5/6] avformat/mpegtsenc: fix PCR generation intervals

2019-08-16 Thread Andreas Håkon
Hi Marton, ‐‐‐ Original Message ‐‐‐ On Wednesday, 14 de August de 2019 23:31, Marton Balint wrote: > I pushed this series, will post the patch which enables setting pcr period > for VBR. Great! I'll prepare my updated interleaved patch. Regards. A.H. ---

Re: [FFmpeg-devel] [PATCH 2/4] avformat/mpegtsenc: add support for setting PCR interval for VBR streams

2019-08-16 Thread Andreas Håkon
Hi Marton, Very good work with your series of patches on the mpegtsenc! ‐‐‐ Original Message ‐‐‐ On Thursday, 15 de August de 2019 1:51, Marton Balint wrote: > Also document the algorithm for the default PCR interval. > [...] > + if (ts->mux_rate > 1 || ts->pcr_period_ms >= 0) { >