Re: [FFmpeg-devel] [PATCH v1] avformat/tee.c: steal bsf option before passing to fifo muxer

2019-10-11 Thread Dennis Mungai
On Sat, 12 Oct 2019, 06:57 Steven Liu, wrote: > > > > 在 2019年10月9日,01:51,Dennis Mungai 写道: > > > > On Tue, 8 Oct 2019 at 08:53, Steven Liu wrote: > >> > >> > >> > >>> 在 2019年10月8日,05:54,Dennis Mungai 写道: > >>> > >>> On Mon, 7 Oct 2019 at 08:26, Liu Steven wrote: > > > > >

[FFmpeg-devel] [PATCH] avformat/Makefile: Fix aiffdec replaygain dependency

2019-10-11 Thread Andreas Rheinhardt
Forgotten in 6390f52a. Signed-off-by: Andreas Rheinhardt --- Found via ubitux random FATE box: http://fate.ffmpeg.org/report.cgi?slot=x86_64-archlinux-gcc-random=20191012015819 libavformat/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/Makefile

Re: [FFmpeg-devel] [PATCH v1] avformat/tee.c: steal bsf option before passing to fifo muxer

2019-10-11 Thread Steven Liu
> 在 2019年10月9日,01:51,Dennis Mungai 写道: > > On Tue, 8 Oct 2019 at 08:53, Steven Liu wrote: >> >> >> >>> 在 2019年10月8日,05:54,Dennis Mungai 写道: >>> >>> On Mon, 7 Oct 2019 at 08:26, Liu Steven wrote: > 在 2019年10月6日,上午11:37,Jun Li 写道: > > Fix #7620 > In the

Re: [FFmpeg-devel] [PATCH V1 3/3] lavf/hlsenc: fix memory leak

2019-10-11 Thread Steven Liu
> 在 2019年10月12日,11:50,Limin Wang 写道: > > On Sat, Oct 12, 2019 at 11:18:39AM +0800, Steven Liu wrote: >> >> >>> 在 2019年10月12日,09:14,Jun Zhao 写道: >>> >>> From: Jun Zhao >>> >>> fix memory leak >>> >>> Signed-off-by: Jun Zhao >>> --- >>> libavformat/hlsenc.c |2 ++ >>> 1 files changed,

Re: [FFmpeg-devel] [PATCH V1 3/3] lavf/hlsenc: fix memory leak

2019-10-11 Thread Limin Wang
On Sat, Oct 12, 2019 at 11:18:39AM +0800, Steven Liu wrote: > > > > 在 2019年10月12日,09:14,Jun Zhao 写道: > > > > From: Jun Zhao > > > > fix memory leak > > > > Signed-off-by: Jun Zhao > > --- > > libavformat/hlsenc.c |2 ++ > > 1 files changed, 2 insertions(+), 0 deletions(-) > > > > diff

[FFmpeg-devel] [PATCH 3/3] fftools/ffmpeg: Reuse packet when possible during streamcopy

2019-10-11 Thread Andreas Rheinhardt
When do_streamcopy is called to output a packet, it must in general not modify the packet, because the very same packet might also be output via different OutputStreams. So it uses av_packet_ref() to create a new reference to the packet's data. But this is unnecessary when the current OutputStream

Re: [FFmpeg-devel] [PATCH V1 3/3] lavf/hlsenc: fix memory leak

2019-10-11 Thread Steven Liu
> 在 2019年10月12日,09:14,Jun Zhao 写道: > > From: Jun Zhao > > fix memory leak > > Signed-off-by: Jun Zhao > --- > libavformat/hlsenc.c |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c > index cd43201..5a27b0f 100644 >

[FFmpeg-devel] [PATCH 2/3] fftools/ffmpeg: Integrate two checks

2019-10-11 Thread Andreas Rheinhardt
For audio packets with dts != AV_NOPTS_VALUEs the dts was converted twice to the muxer's timebase during streamcopy, once as a normal packet and once specifically as an audio packet. This has been changed. Signed-off-by: Andreas Rheinhardt --- fftools/ffmpeg.c | 20 ++-- 1 file

Re: [FFmpeg-devel] [PATCH] avutil/eval: add sgn()

2019-10-11 Thread Steven Liu
> 在 2019年10月12日,03:45,Paul B Mahol 写道: > > Signed-off-by: Paul B Mahol > --- > doc/utils.texi | 3 +++ > libavutil/eval.c | 4 > 2 files changed, 7 insertions(+) > > diff --git a/doc/utils.texi b/doc/utils.texi > index d55dd315c3..4e2e713505 100644 > --- a/doc/utils.texi > +++

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: add myself as libxavs2 maintainer

2019-10-11 Thread Steven Liu
> 在 2019年10月12日,09:28,hwren 写道: > > From: hwrenx > > Signed-off-by: hwrenx > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 7f60ef0..928f4ee 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -198,6 +198,7 @@ Codecs: >

Re: [FFmpeg-devel] [PATCH] lavf/mpegtsenc: add stream type AVS2

2019-10-11 Thread Steven Liu
> 在 2019年10月12日,09:28,hwren 写道: > > From: hwrenx > > Signed-off-by: hwrenx > --- > libavformat/mpegts.h| 1 + > libavformat/mpegtsenc.c | 3 +++ > 2 files changed, 4 insertions(+) > > diff --git a/libavformat/mpegts.h b/libavformat/mpegts.h > index ecc3d33..78abe72 100644 > ---

[FFmpeg-devel] [PATCH] avcodec/mips: Fixed four warnings in vc1dsp

2019-10-11 Thread gxw
Change the stride argument to ptrdiff_t in the following functions: ff_put_no_rnd_vc1_chroma_mc8_mmi, ff_put_no_rnd_vc1_chroma_mc4_mmi, ff_avg_no_rnd_vc1_chroma_mc8_mmi, ff_avg_no_rnd_vc1_chroma_mc4_mmi. --- libavcodec/mips/vc1dsp_mips.h | 8 libavcodec/mips/vc1dsp_mmi.c | 8 2

[FFmpeg-devel] [PATCH] avcodec/mips: msa optimizations for vc1dsp

2019-10-11 Thread gxw
Performance of WMV3 decoding has speed up from 3.66x to 5.23x tested on 3A4000. --- libavcodec/mips/Makefile| 1 + libavcodec/mips/vc1dsp_init_mips.c | 30 ++- libavcodec/mips/vc1dsp_mips.h | 23 ++ libavcodec/mips/vc1dsp_msa.c| 483

[FFmpeg-devel] [PATCH] lavf/mpegtsenc: add stream type AVS2

2019-10-11 Thread hwren
From: hwrenx Signed-off-by: hwrenx --- libavformat/mpegts.h| 1 + libavformat/mpegtsenc.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/libavformat/mpegts.h b/libavformat/mpegts.h index ecc3d33..78abe72 100644 --- a/libavformat/mpegts.h +++ b/libavformat/mpegts.h @@ -119,6 +119,7

Re: [FFmpeg-devel] [PATCH v2 1/2] avcodec/v210dec: removed the duplicated 'if' condition

2019-10-11 Thread Limin Wang
On Fri, Oct 11, 2019 at 09:07:38PM +0200, Michael Niedermayer wrote: > On Fri, Sep 06, 2019 at 11:28:28PM +0800, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavcodec/v210dec.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > >

Re: [FFmpeg-devel] [PATCH v4 2/4] avfilter/vf_framerate: if metadata lavfi.scd.mafd exists, we'll use it first

2019-10-11 Thread Limin Wang
On Fri, Oct 11, 2019 at 08:13:02PM +0200, Michael Niedermayer wrote: > On Thu, Oct 10, 2019 at 10:11:10PM +0800, Limin Wang wrote: > > On Thu, Oct 10, 2019 at 01:52:56PM +0200, Michael Niedermayer wrote: > > > On Tue, Oct 08, 2019 at 11:28:37PM +0800, lance.lmw...@gmail.com wrote: > > > > From:

[FFmpeg-devel] [PATCH] MAINTAINERS: add myself as libxavs2 maintainer

2019-10-11 Thread hwren
From: hwrenx Signed-off-by: hwrenx --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7f60ef0..928f4ee 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -198,6 +198,7 @@ Codecs: libvorbis.c David Conrad libvpx*

[FFmpeg-devel] [PATCH 1/3] lavc/libxavs2: fix parameter setting result determination

2019-10-11 Thread hwren
From: hwrenx Signed-off-by: hwrenx --- libavcodec/libxavs2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/libxavs2.c b/libavcodec/libxavs2.c index d5c4557..0179a1e 100644 --- a/libavcodec/libxavs2.c +++ b/libavcodec/libxavs2.c @@ -31,7 +31,7 @@ int err; \

[FFmpeg-devel] [PATCH 2/3] lavc/libxvas2: optimize code style and data acces

2019-10-11 Thread hwren
From: hwrenx Optimize using of spaces and indents, change data access from multiplication to iteration. Signed-off-by: hwrenx --- libavcodec/libxavs2.c | 139 ++ 1 file changed, 71 insertions(+), 68 deletions(-) diff --git

[FFmpeg-devel] [PATCH 3/3] lavc/libxavs2: replace 'FrameRate' with 'fps'

2019-10-11 Thread hwren
From: hwrenx Remove deprecated paramete FrameRate (frame rate code) and use fps (frame rate). Avoid encoder warning. Signed-off-by: hwrenx --- libavcodec/libxavs2.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/libxavs2.c b/libavcodec/libxavs2.c index

[FFmpeg-devel] [PATCH V1 3/3] lavf/hlsenc: fix memory leak

2019-10-11 Thread Jun Zhao
From: Jun Zhao fix memory leak Signed-off-by: Jun Zhao --- libavformat/hlsenc.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index cd43201..5a27b0f 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -585,6

[FFmpeg-devel] [PATCH V1 1/3] lavfi/avf_showspectrum: add error handle if av_asprintf return null

2019-10-11 Thread Jun Zhao
From: Jun Zhao add error handle if av_asprintf return null. Signed-off-by: Jun Zhao --- libavfilter/avf_showspectrum.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/libavfilter/avf_showspectrum.c b/libavfilter/avf_showspectrum.c index f175bf1..d5785af

[FFmpeg-devel] [PATCH V1 2/3] fftools/ffmpeg_opt: add error handle if av_asprintf return null

2019-10-11 Thread Jun Zhao
From: Jun Zhao add error handle if av_asprintf return null. Signed-off-by: Jun Zhao --- fftools/ffmpeg_opt.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index fa22eb3..af9a9a6 100644 --- a/fftools/ffmpeg_opt.c +++

Re: [FFmpeg-devel] [PATCH] avformat/dv: free all allocated structs on dv_read_header failure

2019-10-11 Thread James Almer
On 10/11/2019 8:36 PM, Andreas Rheinhardt wrote: > James Almer: >> Also propagate proper AVERROR codes while at it. >> >> Fixes ticket #8230. >> >> Signed-off-by: James Almer >> --- >> libavformat/dv.c | 20 +++- >> 1 file changed, 15 insertions(+), 5 deletions(-) >> >> diff

Re: [FFmpeg-devel] [PATCH] avformat/dv: free all allocated structs on dv_read_header failure

2019-10-11 Thread Andreas Rheinhardt
James Almer: > Also propagate proper AVERROR codes while at it. > > Fixes ticket #8230. > > Signed-off-by: James Almer > --- > libavformat/dv.c | 20 +++- > 1 file changed, 15 insertions(+), 5 deletions(-) > > diff --git a/libavformat/dv.c b/libavformat/dv.c > index

Re: [FFmpeg-devel] [PATCH] libavcodec/amfenc_h264.c: Changed loop filter flag default value.

2019-10-11 Thread James Almer
On 10/11/2019 12:37 PM, OvchinnikovDmitrii wrote: > The value has been changed to match the recommended(by AMF Encoder team) > > --- > libavcodec/amfenc_h264.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/amfenc_h264.c b/libavcodec/amfenc_h264.c > index

Re: [FFmpeg-devel] [PATCH v2 3/8] avformat/mpc8: fix memleak when seek table too big

2019-10-11 Thread Michael Niedermayer
On Thu, Oct 10, 2019 at 10:07:51AM +0800, Steven Liu wrote: > Signed-off-by: Steven Liu > --- > libavformat/mpc8.c | 1 + > 1 file changed, 1 insertion(+) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No great genius has ever existed without some

Re: [FFmpeg-devel] [PATCH v2 8/8] avformat/wc3movie: fix memleak when read content size not equvipe input size

2019-10-11 Thread Michael Niedermayer
Hi typo in commit message "equvipe" otherwise LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The bravest are surely those who have the clearest vision of what is before them, glory and danger alike, and yet notwithstanding go out to meet it. --

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: Try to fix subsampling default

2019-10-11 Thread Michael Niedermayer
On Sat, Sep 28, 2019 at 07:13:59PM +0300, Skakov Pavel wrote: > >This ensures the default ycbcr_subsampling is 2 while also > >ensuring the subsampling values are correct for all pixel formats. > >This solution while it takes a few lines more code should be more > >robust > > In TIFF

Re: [FFmpeg-devel] [PATCH v2 1/4] avcodec/tiff: correct unpacking of border YUV pixels

2019-10-11 Thread Michael Niedermayer
On Thu, Oct 10, 2019 at 03:05:11AM +0300, Skakov Pavel wrote: > Corrected handling of border pixels when unpacking YUV. Example (bottom > line): > https://github.com/BitMiracle/libtiff.net/blob/master/TestCase/ycbcr-cat.tif > tiff.c |7 +-- > 1 file changed, 5 insertions(+), 2

[FFmpeg-devel] [PATCH] avutil/eval: add sgn()

2019-10-11 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/utils.texi | 3 +++ libavutil/eval.c | 4 2 files changed, 7 insertions(+) diff --git a/doc/utils.texi b/doc/utils.texi index d55dd315c3..4e2e713505 100644 --- a/doc/utils.texi +++ b/doc/utils.texi @@ -920,6 +920,9 @@ corresponding input value will be

Re: [FFmpeg-devel] [PATCH v2 4/4] avcodec/tiff: small compiling optimization

2019-10-11 Thread Michael Niedermayer
On Thu, Oct 10, 2019 at 03:18:26AM +0300, Skakov Pavel wrote: > Made it easier for compiler to optimize array indexes when unpacking YUV. > tiff.c | 19 ++- > 1 file changed, 10 insertions(+), 9 deletions(-) > ab39e158e34253528edf4f3a2e90efb3a6e89d80 >

Re: [FFmpeg-devel] Front Center labeled as Mono in discrete track in mov

2019-10-11 Thread London, Marc
Yes, potentially. What would be reasonable? On 10/11/19, 3:15 PM, "ffmpeg-devel on behalf of Lou Logan" wrote: On Fri, Oct 11, 2019, at 10:56 AM, London, Marc wrote: > Hi, > > We are very interested in a fix to address the issue where the Front >

Re: [FFmpeg-devel] [PATCH v2] avformat/sapdec: check av_strdup() return value

2019-10-11 Thread Michael Niedermayer
On Thu, Oct 10, 2019 at 01:27:45PM +0800, Steven Liu wrote: > Signed-off-by: Steven Liu > --- > libavformat/sapdec.c | 4 > 1 file changed, 4 insertions(+) probably ok thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB It is what and why we do it that

Re: [FFmpeg-devel] Front Center labeled as Mono in discrete track in mov

2019-10-11 Thread Lou Logan
On Fri, Oct 11, 2019, at 10:56 AM, London, Marc wrote: > Hi, > > We are very interested in a fix to address the issue where the Front > Center (FC) in a discrete track is identified as a Mono track, > especially in Quicktime/Apple platforms. > >

Re: [FFmpeg-devel] [PATCH v2 1/2] avcodec/v210dec: removed the duplicated 'if' condition

2019-10-11 Thread Michael Niedermayer
On Fri, Sep 06, 2019 at 11:28:28PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavcodec/v210dec.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/libavcodec/v210dec.c b/libavcodec/v210dec.c > index 5a33d8c..6ce18aa

Re: [FFmpeg-devel] [PATCH v4 2/2] avcodec/v210dec: add the frame and slice threading support

2019-10-11 Thread Michael Niedermayer
On Sun, Sep 22, 2019 at 11:55:49AM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > The multithread is avoid one core cpu is full with other filter like scale > etc. > About the performance, the gain is very small, below is my testing for > performance. > In order to avoid the disk

[FFmpeg-devel] Front Center labeled as Mono in discrete track in mov

2019-10-11 Thread London, Marc
Hi, We are very interested in a fix to address the issue where the Front Center (FC) in a discrete track is identified as a Mono track, especially in Quicktime/Apple platforms. https://trac.ffmpeg.org/ticket/2865#trac-add-comment I wanted to see if there was any chance for someone to look

Re: [FFmpeg-devel] [PATCH v4 2/4] avfilter/vf_framerate: if metadata lavfi.scd.mafd exists, we'll use it first

2019-10-11 Thread Michael Niedermayer
On Thu, Oct 10, 2019 at 10:11:10PM +0800, Limin Wang wrote: > On Thu, Oct 10, 2019 at 01:52:56PM +0200, Michael Niedermayer wrote: > > On Tue, Oct 08, 2019 at 11:28:37PM +0800, lance.lmw...@gmail.com wrote: > > > From: Limin Wang > > > > > > Reviewed-by: Paul B Mahol > > > Signed-off-by: Limin

Re: [FFmpeg-devel] [PATCH 09/14] avfilter/vf_amplify: add support for commands

2019-10-11 Thread Michael Niedermayer
On Wed, Oct 09, 2019 at 08:16:19PM +0200, Paul B Mahol wrote: > On 10/9/19, Michael Niedermayer wrote: > > On Wed, Oct 09, 2019 at 12:17:00PM +0200, Paul B Mahol wrote: > >> Signed-off-by: Paul B Mahol > >> --- > >> libavfilter/vf_amplify.c | 14 -- > >> 1 file changed, 8

Re: [FFmpeg-devel] Add on-the-fly bitrate adjustment for encoding

2019-10-11 Thread Michael Niedermayer
On Thu, Oct 10, 2019 at 09:24:08AM -0700, Adrian Cable wrote: > This is an addition to ffmpeg.c which enables on-the-fly encoder (e.g. H.264) > bitrate adjustment using ffmpeg interactive mode. For example, specify “-b:v > 299k -bufsize 299k” on the command line to start encoding at 299kbit/sec,

[FFmpeg-devel] [PATCH] avformat/dv: free all allocated structs on dv_read_header failure

2019-10-11 Thread James Almer
Also propagate proper AVERROR codes while at it. Fixes ticket #8230. Signed-off-by: James Almer --- libavformat/dv.c | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/libavformat/dv.c b/libavformat/dv.c index eb44e0acb6..e99422d4b5 100644 ---

[FFmpeg-devel] [PATCH] ffprobe: fix output of packets_and_frames section in JSON format

2019-10-11 Thread James Almer
The "type" entry was hardcoded with an trailing comma, even if it was the only entry in the section. Fixes ticket #8228. Signed-off-by: James Almer --- fftools/ffprobe.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index

[FFmpeg-devel] [PATCH 2/2] avfilter/vf_geq: reindent

2019-10-11 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/vf_geq.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/libavfilter/vf_geq.c b/libavfilter/vf_geq.c index b7932f0b04..5e052f8ccd 100644 --- a/libavfilter/vf_geq.c +++ b/libavfilter/vf_geq.c @@ -102,22

[FFmpeg-devel] [PATCH 1/2] avfilter/vf_geq: allow user to set interpolation method

2019-10-11 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 8 libavfilter/vf_geq.c | 27 +++ 2 files changed, 35 insertions(+) diff --git a/doc/filters.texi b/doc/filters.texi index 55a8ebae56..6f9ebf6085 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@

Re: [FFmpeg-devel] Fix Profile level option on AMF HEVC.

2019-10-11 Thread Дмитрий Овчинников
Hi! Thanks for contributing! We will check from amf side. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject

[FFmpeg-devel] [PATCH] libavcodec/amfenc_h264.c: Changed loop filter flag default value.

2019-10-11 Thread OvchinnikovDmitrii
The value has been changed to match the recommended(by AMF Encoder team) --- libavcodec/amfenc_h264.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/amfenc_h264.c b/libavcodec/amfenc_h264.c index 2c082e93bd..7f2817f115 100644 --- a/libavcodec/amfenc_h264.c +++

Re: [FFmpeg-devel] Add on-the-fly bitrate adjustment for encoding

2019-10-11 Thread Adrian Cable
Kieran et al. - understand your comments - feel free to reject the patch. -Adrian On 10/11/19, 7:52 AM, "ffmpeg-devel on behalf of Kieran Kunhya" wrote: On Fri, 11 Oct 2019 at 10:16, Moritz Barsnick wrote: > On Thu, Oct 10, 2019 at 09:24:08 -0700, Adrian Cable wrote: > >

Re: [FFmpeg-devel] Add on-the-fly bitrate adjustment for encoding

2019-10-11 Thread Kieran Kunhya
On Fri, 11 Oct 2019 at 10:16, Moritz Barsnick wrote: > On Thu, Oct 10, 2019 at 09:24:08 -0700, Adrian Cable wrote: > > This is an addition to ffmpeg.c which enables on-the-fly encoder (e.g. > H.264) bitrate adjustment using ffmpeg interactive mode. For example, > specify “-b:v 299k -bufsize

Re: [FFmpeg-devel] [PATCH v1 3/6] avcodec/xwddec: cosmetics

2019-10-11 Thread Paul B Mahol
On 10/11/19, Limin Wang wrote: > On Fri, Oct 11, 2019 at 01:45:34PM +0200, Paul B Mahol wrote: >> pointless >> > It's OK, I saw two different code style, so I change it for consistent. > No, it is not OK, please refrain from posting such patches, they are considered spam. Also stop posting

Re: [FFmpeg-devel] [PATCH v1 3/6] avcodec/xwddec: cosmetics

2019-10-11 Thread Paul B Mahol
pointless On 10/11/19, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavcodec/xwddec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/xwddec.c b/libavcodec/xwddec.c > index 8c4358fd4c..924ba020da 100644 > ---

Re: [FFmpeg-devel] [PATCH v1 1/6] avcodec/magicyuv: cosmetics

2019-10-11 Thread Paul B Mahol
second part is pointless On 10/11/19, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavcodec/magicyuv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/magicyuv.c b/libavcodec/magicyuv.c > index

Re: [FFmpeg-devel] [PATCH v1 2/6] avcodec/dxtory: cosmetics

2019-10-11 Thread Paul B Mahol
pointless On 10/11/19, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavcodec/dxtory.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/dxtory.c b/libavcodec/dxtory.c > index 4dd675316b..d2d7482262 100644 > ---

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/binkaudio: Check sample rate

2019-10-11 Thread Peter Ross
On Fri, Oct 11, 2019 at 12:40:07AM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 1092624416 * 2 cannot be represented in type > 'int' > Fixes: > 18045/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_BINKAUDIO_RDFT_fuzzer-5718519492116480 > > Found-by: continuous fuzzing

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/binkaudio: Check sample rate

2019-10-11 Thread Paul B Mahol
lgtm On 10/11/19, Michael Niedermayer wrote: > Fixes: signed integer overflow: 1092624416 * 2 cannot be represented in type > 'int' > Fixes: > 18045/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_BINKAUDIO_RDFT_fuzzer-5718519492116480 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH] avfilter: add median filter

2019-10-11 Thread myp...@gmail.com
On Fri, Oct 11, 2019 at 4:38 PM Moritz Barsnick wrote: > > On Fri, Oct 11, 2019 at 14:18:22 +0800, myp...@gmail.com wrote: > > On Wed, Feb 6, 2019 at 1:06 AM Paul B Mahol wrote: > > > On 2/1/19, Paul B Mahol wrote: > > > will apply. > > Has it pushed? I just found a xmedian filter in FFmpeg

Re: [FFmpeg-devel] [PATCH v1 4/6] avcodec/magicyuv: fix for the memory leak if failed

2019-10-11 Thread Limin Wang
On Fri, Oct 11, 2019 at 08:00:00AM +, Andreas Rheinhardt wrote: > lance.lmw...@gmail.com: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavcodec/magicyuv.c | 43 ++- > > 1 file changed, 30 insertions(+), 13 deletions(-) > > >

Re: [FFmpeg-devel] Add on-the-fly bitrate adjustment for encoding

2019-10-11 Thread Moritz Barsnick
On Thu, Oct 10, 2019 at 09:24:08 -0700, Adrian Cable wrote: > This is an addition to ffmpeg.c which enables on-the-fly encoder (e.g. H.264) > bitrate adjustment using ffmpeg interactive mode. For example, specify “-b:v > 299k -bufsize 299k” on the command line to start encoding at 299kbit/sec,

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/qdmc: Check input space in qdmc_get_vlc()

2019-10-11 Thread Paul B Mahol
lgtm On 10/11/19, Michael Niedermayer wrote: > Fixes: Timeout (125sec -> 0.4sec) > Fixes: > 18059/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_QDMC_fuzzer-5656195825664000 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

Re: [FFmpeg-devel] [PATCH] avfilter: add median filter

2019-10-11 Thread Moritz Barsnick
On Fri, Oct 11, 2019 at 14:18:22 +0800, myp...@gmail.com wrote: > On Wed, Feb 6, 2019 at 1:06 AM Paul B Mahol wrote: > > On 2/1/19, Paul B Mahol wrote: > > will apply. > Has it pushed? I just found a xmedian filter in FFmpeg master. Have you read its description? It does something quite

Re: [FFmpeg-devel] [PATCH v1 4/6] avcodec/magicyuv: fix for the memory leak if failed

2019-10-11 Thread Andreas Rheinhardt
lance.lmw...@gmail.com: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavcodec/magicyuv.c | 43 ++- > 1 file changed, 30 insertions(+), 13 deletions(-) > > diff --git a/libavcodec/magicyuv.c b/libavcodec/magicyuv.c > index

Re: [FFmpeg-devel] [PATCH v1 6/6] avfilter/vf_random: seeds is uint32, it's enough to use int32_t

2019-10-11 Thread Limin Wang
On Fri, Oct 11, 2019 at 07:34:00AM +, Andreas Rheinhardt wrote: > Limin Wang: > > On Fri, Oct 11, 2019 at 06:59:00AM +, Andreas Rheinhardt wrote: > >> Limin Wang: > >>> On Fri, Oct 11, 2019 at 06:20:00AM +, Andreas Rheinhardt wrote: > lance.lmw...@gmail.com: > > From: Limin

Re: [FFmpeg-devel] [PATCH v1 6/6] avfilter/vf_random: seeds is uint32, it's enough to use int32_t

2019-10-11 Thread Andreas Rheinhardt
Limin Wang: > On Fri, Oct 11, 2019 at 06:59:00AM +, Andreas Rheinhardt wrote: >> Limin Wang: >>> On Fri, Oct 11, 2019 at 06:20:00AM +, Andreas Rheinhardt wrote: lance.lmw...@gmail.com: > From: Limin Wang > > Signed-off-by: Limin Wang > --- >

Re: [FFmpeg-devel] [PATCH v1 6/6] avfilter/vf_random: seeds is uint32, it's enough to use int32_t

2019-10-11 Thread Limin Wang
On Fri, Oct 11, 2019 at 06:59:00AM +, Andreas Rheinhardt wrote: > Limin Wang: > > On Fri, Oct 11, 2019 at 06:20:00AM +, Andreas Rheinhardt wrote: > >> lance.lmw...@gmail.com: > >>> From: Limin Wang > >>> > >>> Signed-off-by: Limin Wang > >>> --- > >>> libavfilter/vf_random.c | 2 +- >

Re: [FFmpeg-devel] [PATCH v1 5/6] avformat/rl2: use av_freep instead of av_free to avoid invalid access if alloc failed

2019-10-11 Thread Limin Wang
On Fri, Oct 11, 2019 at 06:42:00AM +, Andreas Rheinhardt wrote: > Limin Wang: > > On Fri, Oct 11, 2019 at 06:23:00AM +, Andreas Rheinhardt wrote: > >> lance.lmw...@gmail.com: > >>> From: Limin Wang > >>> > >>> Signed-off-by: Limin Wang > >>> --- > >>> libavformat/rl2.c | 6 +++--- > >>>

Re: [FFmpeg-devel] [PATCH v1 6/6] avfilter/vf_random: seeds is uint32, it's enough to use int32_t

2019-10-11 Thread Andreas Rheinhardt
Limin Wang: > On Fri, Oct 11, 2019 at 06:20:00AM +, Andreas Rheinhardt wrote: >> lance.lmw...@gmail.com: >>> From: Limin Wang >>> >>> Signed-off-by: Limin Wang >>> --- >>> libavfilter/vf_random.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git

Re: [FFmpeg-devel] [PATCH v1 5/6] avformat/rl2: use av_freep instead of av_free to avoid invalid access if alloc failed

2019-10-11 Thread Andreas Rheinhardt
Limin Wang: > On Fri, Oct 11, 2019 at 06:23:00AM +, Andreas Rheinhardt wrote: >> lance.lmw...@gmail.com: >>> From: Limin Wang >>> >>> Signed-off-by: Limin Wang >>> --- >>> libavformat/rl2.c | 6 +++--- >>> 1 file changed, 3 insertions(+), 3 deletions(-) >>> >>> diff --git

Re: [FFmpeg-devel] [PATCH v1 6/6] avfilter/vf_random: seeds is uint32, it's enough to use int32_t

2019-10-11 Thread Limin Wang
On Fri, Oct 11, 2019 at 06:20:00AM +, Andreas Rheinhardt wrote: > lance.lmw...@gmail.com: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavfilter/vf_random.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavfilter/vf_random.c

Re: [FFmpeg-devel] [PATCH v1 5/6] avformat/rl2: use av_freep instead of av_free to avoid invalid access if alloc failed

2019-10-11 Thread Limin Wang
On Fri, Oct 11, 2019 at 06:23:00AM +, Andreas Rheinhardt wrote: > lance.lmw...@gmail.com: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavformat/rl2.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/libavformat/rl2.c

Re: [FFmpeg-devel] [PATCH v1 5/6] avformat/rl2: use av_freep instead of av_free to avoid invalid access if alloc failed

2019-10-11 Thread Andreas Rheinhardt
lance.lmw...@gmail.com: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavformat/rl2.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libavformat/rl2.c b/libavformat/rl2.c > index d847d9aaa8..3d38ffe8ba 100644 > --- a/libavformat/rl2.c > +++

[FFmpeg-devel] [PATCH v1 1/6] avcodec/magicyuv: cosmetics

2019-10-11 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/magicyuv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/magicyuv.c b/libavcodec/magicyuv.c index 21a32785bc..0b1ac7345a 100644 --- a/libavcodec/magicyuv.c +++ b/libavcodec/magicyuv.c @@ -620,7

Re: [FFmpeg-devel] [PATCH v1 6/6] avfilter/vf_random: seeds is uint32, it's enough to use int32_t

2019-10-11 Thread Andreas Rheinhardt
lance.lmw...@gmail.com: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavfilter/vf_random.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/vf_random.c b/libavfilter/vf_random.c > index 1937eae771..9f2153be61 100644 > ---

Re: [FFmpeg-devel] [PATCH] avfilter: add median filter

2019-10-11 Thread myp...@gmail.com
On Wed, Feb 6, 2019 at 1:06 AM Paul B Mahol wrote: > > On 2/1/19, Paul B Mahol wrote: > > Signed-off-by: Paul B Mahol > > --- > > doc/filters.texi | 15 +++ > > libavfilter/Makefile | 1 + > > libavfilter/allfilters.c | 1 + > > libavfilter/median.h |

[FFmpeg-devel] [PATCH v1 6/6] avfilter/vf_random: seeds is uint32, it's enough to use int32_t

2019-10-11 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/vf_random.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_random.c b/libavfilter/vf_random.c index 1937eae771..9f2153be61 100644 --- a/libavfilter/vf_random.c +++ b/libavfilter/vf_random.c @@ -33,7

[FFmpeg-devel] [PATCH v1 5/6] avformat/rl2: use av_freep instead of av_free to avoid invalid access if alloc failed

2019-10-11 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/rl2.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/rl2.c b/libavformat/rl2.c index d847d9aaa8..3d38ffe8ba 100644 --- a/libavformat/rl2.c +++ b/libavformat/rl2.c @@ -163,9 +163,9 @@ static

[FFmpeg-devel] [PATCH v1 4/6] avcodec/magicyuv: fix for the memory leak if failed

2019-10-11 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/magicyuv.c | 43 ++- 1 file changed, 30 insertions(+), 13 deletions(-) diff --git a/libavcodec/magicyuv.c b/libavcodec/magicyuv.c index 0b1ac7345a..c905c2ca22 100644 --- a/libavcodec/magicyuv.c

[FFmpeg-devel] [PATCH v1 2/6] avcodec/dxtory: cosmetics

2019-10-11 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/dxtory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/dxtory.c b/libavcodec/dxtory.c index 4dd675316b..d2d7482262 100644 --- a/libavcodec/dxtory.c +++ b/libavcodec/dxtory.c @@ -613,7 +613,7 @@ static

[FFmpeg-devel] [PATCH v1 3/6] avcodec/xwddec: cosmetics

2019-10-11 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/xwddec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/xwddec.c b/libavcodec/xwddec.c index 8c4358fd4c..924ba020da 100644 --- a/libavcodec/xwddec.c +++ b/libavcodec/xwddec.c @@ -151,7 +151,7 @@ static