[FFmpeg-devel] [PATCH v2] avutil/mem: Mark DECLARE_ASM_ALIGNED as visibility("hidden") for __GNUC__

2020-08-21 Thread Fangrui Song
Inline asm code assumes these DECLARE_ASM_ALIGNED declared global constants are non-preemptive, e.g. libavcodec/x86/cabac.h "lea"MANGLE(ff_h264_cabac_tables)", %0 \n\t" These constants are currently defined in C files with default visibility. Such object files require either

[FFmpeg-devel] [PATCH 1/1] libavformat/nut: Support SSA and ASS subtitles

2020-08-21 Thread hax
ffmpeg documentation says the NUT container supports SubStation Alpha This brings actual functionality in line with documentation. --- libavformat/nut.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/nut.c b/libavformat/nut.c index d6993239a3..47ed152529 100644 ---

Re: [FFmpeg-devel] Documentation: proposed changes in the structure

2020-08-21 Thread Clément Bœsch
On Sat, Aug 22, 2020 at 01:15:14AM +0200, Clément Bœsch wrote: [...] > But I think we have it wrong with the documentation approach. What is > currently described within the code corresponds to the "technical > documentation". While all the extra information on the filters may enter > within the

Re: [FFmpeg-devel] Documentation: proposed changes in the structure

2020-08-21 Thread Clément Bœsch
On Fri, Aug 21, 2020 at 11:40:20PM +0200, Nicolas George wrote: > Clement Boesch (12020-08-21): > > The split is probably not a bad idea, but can we discuss having the > > documentation within the C code to prevent duplication/redundancy? > > > > We could write a tool to generate the

Re: [FFmpeg-devel] [PATCH] avcodec/libaomdec: Set SAR based on RenderWidth and RenderHeight

2020-08-21 Thread Derek Buitenhuis
On 21/08/2020 17:36, James Almer wrote: > Should probably also add a ff_set_sar(avctx, > picture->sample_aspect_ratio) call after this. I'll do the same for > libdav1d. > > LGTM in any case. Done and pushed. - Derek ___ ffmpeg-devel mailing list

[FFmpeg-devel] [PATCH] avcodec/rzpaenc: Remove set-but-unused variable

2020-08-21 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/rpzaenc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/rpzaenc.c b/libavcodec/rpzaenc.c index 2d3876743f..baf067c205 100644 --- a/libavcodec/rpzaenc.c +++ b/libavcodec/rpzaenc.c @@ -643,8 +643,7 @@ post_skip :

Re: [FFmpeg-devel] [PATCH] avcodec/proresenc: infer array lengths

2020-08-21 Thread Michael Niedermayer
On Fri, Aug 21, 2020 at 11:07:51AM -0700, Michael Bradshaw wrote: > Signed-off-by: Michael Bradshaw > --- > libavcodec/proresenc_anatoliy.c | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint:

[FFmpeg-devel] [PATCH 3/3] avcodec/aacdec_template: log the element order before/after reordering

2020-08-21 Thread Jan Ekström
This was quite useful to verify that 22.2 got properly handled, among other things. --- libavcodec/aacdec_template.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/libavcodec/aacdec_template.c b/libavcodec/aacdec_template.c index 63604d39fd..b9b9ae5324 100644 ---

[FFmpeg-devel] [PATCH 2/3 v2] avcodec/aacdec_template: add more checks to make sure only 22.2 gets to 22.2

2020-08-21 Thread Jan Ekström
This way we can check that we have exactly the required things for 22.2. Fixes #8845 --- libavcodec/aacdec_template.c | 47 ++-- 1 file changed, 45 insertions(+), 2 deletions(-) diff --git a/libavcodec/aacdec_template.c b/libavcodec/aacdec_template.c index

[FFmpeg-devel] [PATCH 1/3 v2] avcodec/aacdec_template: keep tabs on layout in sniff_channel_order

2020-08-21 Thread Jan Ekström
This way the layout set at various points can be checked instead of only having the layout at the end. --- libavcodec/aacdec_template.c | 56 ++-- 1 file changed, 35 insertions(+), 21 deletions(-) diff --git a/libavcodec/aacdec_template.c

[FFmpeg-devel] [PATCH 0/3 v2] avcodec/aacdec_template: improvements to 22.2 layout logic

2020-08-21 Thread Jan Ekström
Compared to v1: * Left and right are being handled separately in case of assign_pair()'s 2x SCE mode. (patch 1/3) * Exact coding element is also checked instead of just coding element channel type in sniff_channel_order()'s 22.2 specific if statement. (patch 2/3) * Last check in

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add av1 hardware acceleration decoder

2020-08-21 Thread James Almer
On 8/21/2020 11:42 AM, James Almer wrote: >> +static int set_output_frame(AVFrame *srcframe, AVFrame *frame, AVPacket >> *pkt) >> +{ >> +int ret = 0; >> +if ((ret = av_frame_ref(frame, srcframe)) < 0) { >> +return ret; >> +} >> + >> +frame->pts = pkt->pts; >> +

Re: [FFmpeg-devel] Documentation: proposed changes in the structure

2020-08-21 Thread Nicolas George
Clement Boesch (12020-08-21): > The split is probably not a bad idea, but can we discuss having the > documentation within the C code to prevent duplication/redundancy? > > We could write a tool to generate the documentation file, or maybe part of > it for a start (the options). Having to

Re: [FFmpeg-devel] [PATCH v5 1/3] [RFC] lavc: add FLIF decoding support

2020-08-21 Thread Anamitra Ghorui
August 21, 2020 8:27 PM, "Paul B Mahol" wrote: > On 8/20/20, Anamitra Ghorui wrote: > >> Hello, >> >> On Wed, 19 Aug 2020 21:05:41 +0200 >> Paul B Mahol wrote: >> >> [...] >> All these corrections have been made by me locally, but I would like to wait for some further

Re: [FFmpeg-devel] [PATCH 1/2] lavfi: regroup formats lists in a single structure.

2020-08-21 Thread Andreas Rheinhardt
Nicolas George: > Andreas Rheinhardt (12020-08-18): >> 1. Adding this struct has also another benefit besides the ones in your >> two other patches: One can simplify the freeing process by adding a new >> ff_formatscfg_unref() (I'm not sure on the name). This could also be >> used in the uninit

Re: [FFmpeg-devel] [PATCH] libavformat/ffmetadecc.c: Fix Use-of-uninitialized-value

2020-08-21 Thread Michael Niedermayer
On Thu, Aug 20, 2020 at 12:14:52PM -0700, Thierry Foucu wrote: > Check the return value of sscanf as it can return -1(EOF), for example > when the first char in the line is 0x00 > --- > libavformat/ffmetadec.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) will apply thx [...]

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/aacdec_template: add more checks to make sure only 22.2 gets to 22.2

2020-08-21 Thread Jan Ekström
On Tue, Aug 18, 2020 at 10:25 PM Jan Ekström wrote: > > This way we can check that we have exactly the required things for 22.2. > > Fixes #8845 > --- > libavcodec/aacdec_template.c | 40 ++-- > 1 file changed, 38 insertions(+), 2 deletions(-) > > diff --git

[FFmpeg-devel] [PATCH v2 18/21] avfilter/vf_hwdownload: Fix leak of formats list upon error

2020-08-21 Thread Andreas Rheinhardt
If adding the list of input formats to its AVFilterLink fails, the list of output formats (which has not been attached to permanent storage yet) leaks. This has been fixed by not creating the lists of in- and output formats simultaneously. Instead creating said lists is relegated to

Re: [FFmpeg-devel] [PATCH] fate: add fate-sub-dvb test

2020-08-21 Thread Clément Bœsch
On Fri, Aug 21, 2020 at 06:24:58PM +0200, Alexander Strasser wrote: > On 2020-08-21 14:32 +0200, Clément Bœsch wrote: > > On Tue, Aug 18, 2020 at 11:43:29PM +0200, Michael Niedermayer wrote: > > > On Tue, Aug 18, 2020 at 10:45:50PM +0200, Clément Bœsch wrote: > > > > On Tue, Aug 11, 2020 at

Re: [FFmpeg-devel] [PATCH v2 1/2] qsv: needn't load user plugin since libmfx 1.28

2020-08-21 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Soft Works > Sent: Friday, August 21, 2020 9:45 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v2 1/2] qsv: needn't load user plugin > since libmfx 1.28 > > > > >

Re: [FFmpeg-devel] Documentation: proposed changes in the structure

2020-08-21 Thread Clément Bœsch
On Fri, Aug 21, 2020 at 02:35:38PM +0200, Nicolas George wrote: > 1. What would you think about putting the documentation for >libavfilter/vf_foobar.c into libavfilter/doc/vf_foobar.texi instead >of into huge doc/filters.texi (25k lines!)? And same for codecs, >formats, etc. > >We

Re: [FFmpeg-devel] Documentation: proposed changes in the structure

2020-08-21 Thread Clément Bœsch
On Fri, Aug 21, 2020 at 09:42:57PM +0200, Oneric wrote: > On Fri, Aug 21, 2020 at 14:46:53 +0200, Timo Rothenpieler wrote: > > Something like Markdown would come to mind. It should have all formatting > > tools one needs for documentation. > > Imho ReStructuredText would be better suited for

Re: [FFmpeg-devel] [PATCH] avcodec: add RPZA encoder

2020-08-21 Thread Paul B Mahol
On 8/21/20, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > Changelog | 1 + > doc/general.texi | 2 +- > libavcodec/Makefile| 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/rpzaenc.c | 860 + >

Re: [FFmpeg-devel] Documentation: proposed changes in the structure

2020-08-21 Thread Oneric
On Fri, Aug 21, 2020 at 14:46:53 +0200, Timo Rothenpieler wrote: > Something like Markdown would come to mind. It should have all formatting > tools one needs for documentation. Imho ReStructuredText would be better suited for documentation than Markdown, while being similarly "text-like".

[FFmpeg-devel] [PATCH] avcodec: add RPZA encoder

2020-08-21 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- Changelog | 1 + doc/general.texi | 2 +- libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 1 + libavcodec/rpzaenc.c | 860 + libavcodec/version.h | 2 +- 6 files changed, 865

Re: [FFmpeg-devel] [PATCH] avcodec/proresenc: add support for PQ and HLG

2020-08-21 Thread Michael Bradshaw
On Thu, Aug 20, 2020 at 10:45 AM Michael Bradshaw wrote: > On Wed, Aug 19, 2020 at 9:23 PM zhilizhao wrote: > >> > -static const int valid_trc[4]= { AVCOL_TRC_RESERVED0, >> AVCOL_TRC_BT709, AVCOL_TRC_UNSPECIFIED, INT_MAX }; >> > +static const int valid_trc[6]= {

[FFmpeg-devel] [PATCH] avcodec/proresenc: infer array lengths

2020-08-21 Thread Michael Bradshaw
Signed-off-by: Michael Bradshaw --- libavcodec/proresenc_anatoliy.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/libavcodec/proresenc_anatoliy.c b/libavcodec/proresenc_anatoliy.c index 1128978330..d1623e142c 100644 --- a/libavcodec/proresenc_anatoliy.c

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add av1 hardware acceleration decoder

2020-08-21 Thread James Almer
On 8/21/2020 2:05 PM, Derek Buitenhuis wrote: > On 21/08/2020 16:00, James Almer wrote: >> If you actually look at the patch, you'll notice that this is basically >> the template of what eventually will become the native decoder, that for >> now only includes the high level bitstream parsing and

Re: [FFmpeg-devel] Documentation: proposed changes in the structure

2020-08-21 Thread Nicolas George
Timo Rothenpieler (12020-08-21): > That seems long overdue to me. > The current approach to documentation has become very hard to properly > maintain. This seems to get some approval. I think it would probably not be very hard to convert existing components in bulk. I'll see if I can wrangle

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add av1 hardware acceleration decoder

2020-08-21 Thread Derek Buitenhuis
On 21/08/2020 16:00, James Almer wrote: > If you actually look at the patch, you'll notice that this is basically > the template of what eventually will become the native decoder, that for > now only includes the high level bitstream parsing and the hwaccel hooks > (And thus will only output

Re: [FFmpeg-devel] [PATCH] avformat/movenc: write the colr atom by default

2020-08-21 Thread Michael Bradshaw
On Wed, Aug 19, 2020 at 2:19 PM Paul B Mahol wrote: > On 8/19/20, Michael Bradshaw wrote: > > I completely forgot about this patch. If no one objects over the next few > > days I plan on pushing this. FATE still passes. > > Fine by me. Thanks. Pushed.

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add av1 hardware acceleration decoder

2020-08-21 Thread Hendrik Leppkes
On Fri, Aug 21, 2020 at 4:43 PM James Almer wrote: > > +s->tile_num = > > +raw_frame_header->tile_cols * raw_frame_header->tile_rows; > > +tile_group_offset = raw_tile_group->tile_data.data - pkt->data; > > +get_tiles_info(avctx, raw_tile_group,

Re: [FFmpeg-devel] Documentation: proposed changes in the structure

2020-08-21 Thread Alexander Strasser
On 2020-08-21 14:35 +0200, Nicolas George wrote: > 1. What would you think about putting the documentation for >libavfilter/vf_foobar.c into libavfilter/doc/vf_foobar.texi instead >of into huge doc/filters.texi (25k lines!)? And same for codecs, >formats, etc. > >We can adopt this

Re: [FFmpeg-devel] Documentation: proposed changes in the structure

2020-08-21 Thread Alexander Strasser
On 2020-08-21 15:02 +0200, Jean-Baptiste Kempf wrote: > > > On Fri, 21 Aug 2020, at 14:35, Nicolas George wrote: > > 2. What would you think about switching from texinfo to a small basic > >subset of HTML for new documentation? > > > >I think most of us are much more familiar with HTML

Re: [FFmpeg-devel] [PATCH] avcodec/libaomdec: Set SAR based on RenderWidth and RenderHeight

2020-08-21 Thread James Almer
On 8/21/2020 12:29 PM, Derek Buitenhuis wrote: > This is the same thing we do in libdav1d.c > > Signed-off-by: Derek Buitenhuis > --- > libavcodec/libaomdec.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/libavcodec/libaomdec.c b/libavcodec/libaomdec.c > index

Re: [FFmpeg-devel] [PATCH] fate: add fate-sub-dvb test

2020-08-21 Thread Alexander Strasser
On 2020-08-21 14:32 +0200, Clément Bœsch wrote: > On Tue, Aug 18, 2020 at 11:43:29PM +0200, Michael Niedermayer wrote: > > On Tue, Aug 18, 2020 at 10:45:50PM +0200, Clément Bœsch wrote: > > > On Tue, Aug 11, 2020 at 02:19:01PM +0200, Clément Bœsch wrote: > > > [...] > > > > +FATE_SUBTITLES-$(call

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/audio: Remove unused array, move used-only-once array

2020-08-21 Thread Nicolas George
Andreas Rheinhardt (12020-08-21): > ff_planar_sample_fmts_array is unused (and was unused since it was added > in 4d4098da009c8340997b8d1abedbf2062e4aa991) and therefore this commit > removes it; ff_packed_sample_fmts_array meanwhile is used only once (in > the amerge filter) and therefore it has

[FFmpeg-devel] [PATCH] avcodec/libaomdec: Set SAR based on RenderWidth and RenderHeight

2020-08-21 Thread Derek Buitenhuis
This is the same thing we do in libdav1d.c Signed-off-by: Derek Buitenhuis --- libavcodec/libaomdec.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavcodec/libaomdec.c b/libavcodec/libaomdec.c index a72ac984e7..1b0f35936e 100644 --- a/libavcodec/libaomdec.c +++

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add av1 hardware acceleration decoder

2020-08-21 Thread James Almer
On 8/21/2020 11:47 AM, Paul B Mahol wrote: > On 8/21/20, Fei Wang wrote: >> This av1 decoder is now only used for av1 hardware acceleration >> decoder. Consider it can be extend to a local decoder like hevc >> or vp9 in the future, so define its name as "av1" and put it into >> external libraries

Re: [FFmpeg-devel] [PATCH] dnn_backend_native_layer_avgpool: Fix invalid assignment, use av_assert

2020-08-21 Thread Andreas Rheinhardt
Guo, Yejun: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of >> Andreas Rheinhardt >> Sent: 2020年8月21日 22:21 >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH] dnn_backend_native_layer_avgpool: Fix >> invalid assignment, use av_assert >> >> Guo, Yejun: >>>

Re: [FFmpeg-devel] [PATCH v5 1/3] [RFC] lavc: add FLIF decoding support

2020-08-21 Thread Paul B Mahol
On 8/20/20, Anamitra Ghorui wrote: > Hello, > > On Wed, 19 Aug 2020 21:05:41 +0200 > Paul B Mahol wrote: > > [...] > >> > >> > >> > All these corrections have been made by me locally, but I would >> > like to wait for some further review (self and otherwise) before >> > posting again. >> >>

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add av1 hardware acceleration decoder

2020-08-21 Thread Paul B Mahol
On 8/21/20, Fei Wang wrote: > This av1 decoder is now only used for av1 hardware acceleration > decoder. Consider it can be extend to a local decoder like hevc > or vp9 in the future, so define its name as "av1" and put it into > external libraries codec list. > > Signed-off-by: Fei Wang > --- >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add av1 hardware acceleration decoder

2020-08-21 Thread James Almer
On 8/21/2020 2:29 AM, Fei Wang wrote: > This av1 decoder is now only used for av1 hardware acceleration > decoder. Consider it can be extend to a local decoder like hevc > or vp9 in the future, so define its name as "av1" and put it into > external libraries codec list. > > Signed-off-by: Fei

Re: [FFmpeg-devel] [PATCH] dnn_backend_native_layer_avgpool: Fix invalid assignment, use av_assert

2020-08-21 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: 2020年8月21日 22:21 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] dnn_backend_native_layer_avgpool: Fix > invalid assignment, use av_assert > > Guo, Yejun: > > > > > >> -Original

Re: [FFmpeg-devel] [PATCH] dnn_backend_native_layer_avgpool: Fix invalid assignment, use av_assert

2020-08-21 Thread Andreas Rheinhardt
Guo, Yejun: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of >> Andreas Rheinhardt >> Sent: 2020年8月21日 19:47 >> To: ffmpeg-devel@ffmpeg.org >> Cc: Andreas Rheinhardt >> Subject: [FFmpeg-devel] [PATCH] dnn_backend_native_layer_avgpool: Fix invalid >> assignment, use

Re: [FFmpeg-devel] [PATCH] dnn_backend_native_layer_avgpool: Fix invalid assignment, use av_assert

2020-08-21 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: 2020年8月21日 19:47 > To: ffmpeg-devel@ffmpeg.org > Cc: Andreas Rheinhardt > Subject: [FFmpeg-devel] [PATCH] dnn_backend_native_layer_avgpool: Fix invalid > assignment, use av_assert > >

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/audio: Remove unused array, move used-only-once array

2020-08-21 Thread Paul B Mahol
On 8/21/20, Andreas Rheinhardt wrote: > ff_planar_sample_fmts_array is unused (and was unused since it was added > in 4d4098da009c8340997b8d1abedbf2062e4aa991) and therefore this commit > removes it; ff_packed_sample_fmts_array meanwhile is used only once (in > the amerge filter) and therefore it

[FFmpeg-devel] [PATCH 1/2] avfilter/audio: Remove unused array, move used-only-once array

2020-08-21 Thread Andreas Rheinhardt
ff_planar_sample_fmts_array is unused (and was unused since it was added in 4d4098da009c8340997b8d1abedbf2062e4aa991) and therefore this commit removes it; ff_packed_sample_fmts_array meanwhile is used only once (in the amerge filter) and therefore it has been moved to this place. Signed-off-by:

[FFmpeg-devel] [PATCH 2/2] avfilter/formats: Remove unused functions

2020-08-21 Thread Andreas Rheinhardt
This commit removes ff_parse_sample_format(), ff_parse_time_base() and ff_query_formats_all_layouts() from libavfilter/formats.c. All of these functions were completely unused. ff_parse_time_base() has not been used at all since it had been added in 3448404a707b6e236a2ffa7b0453b3300de41b7b; the

Re: [FFmpeg-devel] [PATCH] avcodec/cfhd: add x86 SIMD

2020-08-21 Thread Moritz Barsnick
On Fri, Aug 21, 2020 at 15:10:09 +0200, Moritz Barsnick wrote: > Let me add my promised benchmarks. I have nothing modern here (these > CPUs are 10, 18 and 6 years old), but I can confirm the impressive > improvements: > > Intel Atom D525 Intel Pentium 4 Intel Haswell

Re: [FFmpeg-devel] Documentation: proposed changes in the structure

2020-08-21 Thread Gyan Doshi
On 21-08-2020 06:05 pm, Nicolas George wrote: 1. What would you think about putting the documentation for libavfilter/vf_foobar.c into libavfilter/doc/vf_foobar.texi instead of into huge doc/filters.texi (25k lines!)? And same for codecs, formats, etc. We can adopt this for

[FFmpeg-devel] [PATCH V4 2/2] dnn_backend_native_layer_mathbinary: add floormod support

2020-08-21 Thread Mingyu Yin
Signed-off-by: Mingyu Yin --- libavfilter/dnn/dnn_backend_native_layer_mathbinary.c | 7 +++ libavfilter/dnn/dnn_backend_native_layer_mathbinary.h | 1 + tests/dnn/dnn-layer-mathbinary-test.c | 5 + tools/python/convert_from_tensorflow.py | 2 +-

[FFmpeg-devel] [PATCH V4 1/2] dnn_backend_native_layer_mathbinary: change to function pointer

2020-08-21 Thread Mingyu Yin
Signed-off-by: Mingyu Yin --- .../dnn/dnn_backend_native_layer_mathbinary.c | 140 +- 1 file changed, 73 insertions(+), 67 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_native_layer_mathbinary.c b/libavfilter/dnn/dnn_backend_native_layer_mathbinary.c index

Re: [FFmpeg-devel] [PATCH] avcodec/cfhd: add x86 SIMD

2020-08-21 Thread Moritz Barsnick
On Fri, Aug 21, 2020 at 13:13:29 +0200, Paul B Mahol wrote: > Overall speed changes for 1920x1080, yuv422p10le, 60fps from: 0.19x to 0.343x Let me add my promised benchmarks. I have nothing modern here (these CPUs are 10, 18 and 6 years old), but I can confirm the impressive improvements:

Re: [FFmpeg-devel] Documentation: proposed changes in the structure

2020-08-21 Thread Jean-Baptiste Kempf
On Fri, 21 Aug 2020, at 14:35, Nicolas George wrote: > 2. What would you think about switching from texinfo to a small basic >subset of HTML for new documentation? > >I think most of us are much more familiar with HTML syntax than with >texinfo. Use Markdown. It's defined, spec'd

Re: [FFmpeg-devel] Documentation: proposed changes in the structure

2020-08-21 Thread Timo Rothenpieler
On 21.08.2020 14:35, Nicolas George wrote: 1. What would you think about putting the documentation for libavfilter/vf_foobar.c into libavfilter/doc/vf_foobar.texi instead of into huge doc/filters.texi (25k lines!)? And same for codecs, formats, etc. We can adopt this for new

[FFmpeg-devel] Documentation: proposed changes in the structure

2020-08-21 Thread Nicolas George
1. What would you think about putting the documentation for libavfilter/vf_foobar.c into libavfilter/doc/vf_foobar.texi instead of into huge doc/filters.texi (25k lines!)? And same for codecs, formats, etc. We can adopt this for new documentation and move progressively existing

Re: [FFmpeg-devel] [PATCH] fate: add fate-sub-dvb test

2020-08-21 Thread Clément Bœsch
On Tue, Aug 18, 2020 at 11:43:29PM +0200, Michael Niedermayer wrote: > On Tue, Aug 18, 2020 at 10:45:50PM +0200, Clément Bœsch wrote: > > On Tue, Aug 11, 2020 at 02:19:01PM +0200, Clément Bœsch wrote: > > [...] > > > +FATE_SUBTITLES-$(call ALLYES, MPEGTS_DEMUXER DVBSUB_DECODER > > >

[FFmpeg-devel] [PATCH] dnn_backend_native_layer_avgpool: Fix invalid assignment, use av_assert

2020-08-21 Thread Andreas Rheinhardt
dnn_execute_layer_avg_pool() contains the following line: assert(avgpool_params->padding_method = VALID); This statement contains an assignment where obviously a comparison was intended. Furthermore, *avgpool_params is const, so that the attempted assignment leads to a compilation failure if

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/vf_overlay: Remove superfluous ;

2020-08-21 Thread Paul B Mahol
On 8/21/20, Andreas Rheinhardt wrote: > In a function body, a redundant ; is just a null statement that does > nothing. Yet outside a function body, a superfluous ';' like one that > exists if one adds a ';' immediately after a function body's closing > brace is actually invalid C that compilers

[FFmpeg-devel] [PATCH] avcodec/cfhd: add x86 SIMD

2020-08-21 Thread Paul B Mahol
Overall speed changes for 1920x1080, yuv422p10le, 60fps from: 0.19x to 0.343x Signed-off-by: Paul B Mahol --- libavcodec/Makefile | 2 +- libavcodec/cfhd.c | 337 -- libavcodec/cfhd.h | 3 + libavcodec/cfhddsp.c | 118 +++

Re: [FFmpeg-devel] [PATCH 3/5] lavc/libkvazaar: export encoded frame stats

2020-08-21 Thread myp...@gmail.com
On Fri, Aug 21, 2020 at 7:15 AM James Almer wrote: > > On 8/15/2020 5:48 AM, myp...@gmail.com wrote: > > On Sun, Aug 9, 2020 at 6:07 AM Mark Thompson wrote: > >> > >> On 26/07/2020 13:26, Jun Zhao wrote: > >>> From: Jun Zhao > >>> > >>> Export choosen pict_type and qp. > >>> > >>>

Re: [FFmpeg-devel] [PATCH 3/5] lavc/libkvazaar: export encoded frame stats

2020-08-21 Thread myp...@gmail.com
On Fri, Aug 21, 2020 at 7:03 AM Mark Thompson wrote: > > On 15/08/2020 09:48, myp...@gmail.com wrote: > > On Sun, Aug 9, 2020 at 6:07 AM Mark Thompson wrote: > >> > >> On 26/07/2020 13:26, Jun Zhao wrote: > >>> From: Jun Zhao > >>> > >>> Export choosen pict_type and qp. > >>> > >>>

Re: [FFmpeg-devel] [PATCH] fate: remove "-v 0" from ffprobe tests.

2020-08-21 Thread Nicolas George
Michael Niedermayer (12016-05-05): > On Thu, May 05, 2016 at 11:59:19AM +0200, Nicolas George wrote: > > The FATE scripts separate stdout from stderr. > > Having a first idea about what went wrong in the log file > > is more convenient. > > > > Signed-off-by: Nicolas George > > --- > >

Re: [FFmpeg-devel] [PATCH] libavfilter/vf_overlay_cuda: Pass the main frame to the output if secondary frame is not available. now filter fails if secondary frame is not available due to e.g secondary

2020-08-21 Thread Nicolas George
Alex Pokotilo (12020-08-21): > I'm sorry. I'm a newbie. Am I right I just need to commit in following format: No need to apologize. > first line: short description.. > LF > more details here Exactly. > Should I send a new patch as a separate email or reply to this one ? It does not

Re: [FFmpeg-devel] [PATCH V3 2/2] dnn/native: add log error message

2020-08-21 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Ting Fu > Sent: 2020年8月21日 11:47 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH V3 2/2] dnn/native: add log error message > > Signed-off-by: Ting Fu > --- > V3: > 1. modify log_ctx of NativeModel to non-pointer

Re: [FFmpeg-devel] [PATCH V3 1/2] dnn/native: unify error return to DNN_ERROR

2020-08-21 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Ting Fu > Sent: 2020年8月21日 11:47 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH V3 1/2] dnn/native: unify error return to > DNN_ERROR > > Unify all error return as DNN_ERROR, in order to cease model executing > when

Re: [FFmpeg-devel] [PATCH] libavfilter/vf_overlay_cuda: Pass the main frame to the output if secondary frame is not available. now filter fails if secondary frame is not available due to e.g secondary

2020-08-21 Thread Alexander Strasser
On 2020-08-21 20:46 +1000, Alex Pokotilo wrote: > On Fri, Aug 21, 2020 at 7:54 PM Nicolas George wrote: > > > > Alex Pokotilo (12020-08-21): > > > From b3739e33fa04a9292dc6584bd2f31460aa53d478 Mon Sep 17 00:00:00 2001 > > > From: Alex Pokotilo > > > Date: Fri, 21 Aug 2020 09:14:37 + > > >

Re: [FFmpeg-devel] Curly braces around single statements (was avformat/avidec: Fix memleak when error) happens after creating DV stream

2020-08-21 Thread Alexander Strasser
Hi Mark, thanks for your opinion on this! On 2020-08-20 23:35 +0100, Mark Thompson wrote: > On 20/08/2020 22:20, Alexander Strasser wrote: > > Please pardon me for bringing this up in the context of this patch. > > No objections or particular opinion regarding this instance of the > > problem. >

Re: [FFmpeg-devel] [PATCH] libavfilter/vf_overlay_cuda: Pass the main frame to the output if secondary frame is not available. now filter fails if secondary frame is not available due to e.g secondary

2020-08-21 Thread Alex Pokotilo
On Fri, Aug 21, 2020 at 7:54 PM Nicolas George wrote: > > Alex Pokotilo (12020-08-21): > > From b3739e33fa04a9292dc6584bd2f31460aa53d478 Mon Sep 17 00:00:00 2001 > > From: Alex Pokotilo > > Date: Fri, 21 Aug 2020 09:14:37 + > > Subject: [PATCH] libavfilter/vf_overlay_cuda: Pass the main

Re: [FFmpeg-devel] [PATCH V3 1/2] dnn_backend_native_layer_mathbinary: add floormod support

2020-08-21 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Mingyu > Yin > Sent: 2020年8月21日 16:52 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH V3 1/2] dnn_backend_native_layer_mathbinary: > add floormod support > > Signed-off-by: Mingyu Yin > --- >

Re: [FFmpeg-devel] [PATCH V3 2/2] dnn_backend_native_layer_mathbinary: change to function pointer

2020-08-21 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Mingyu > Yin > Sent: 2020年8月21日 16:52 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH V3 2/2] dnn_backend_native_layer_mathbinary: > change to function pointer > > Signed-off-by: Mingyu Yin > --- >

Re: [FFmpeg-devel] [PATCH] doc/APIchanges: Remove version conflict separator

2020-08-21 Thread Nicolas George
Andreas Rheinhardt (12020-08-21): > Added in 06f26512046de1a84e045d219e7fa211c37ad0e4. Sorry, thanks. -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH] doc/APIchanges: Remove version conflict separator

2020-08-21 Thread Andreas Rheinhardt
Added in 06f26512046de1a84e045d219e7fa211c37ad0e4. Signed-off-by: Andreas Rheinhardt --- doc/APIchanges | 1 - 1 file changed, 1 deletion(-) diff --git a/doc/APIchanges b/doc/APIchanges index c4a4471ecc..0054908e1e 100644 --- a/doc/APIchanges +++ b/doc/APIchanges @@ -15,7 +15,6 @@ libavutil:

Re: [FFmpeg-devel] [PATCH] avcodec/cfhd: add x86 SIMD

2020-08-21 Thread Moritz Barsnick
On Thu, Aug 20, 2020 at 12:53:05 +0200, Moritz Barsnick wrote: > Alas, with the patchset, the following command quickly terminates with > Illegal instruction in ff_cfhd_horiz_filter_clip10_sse2 (): The same on this CPU, obviously, because it also doesn't support SSE4.1: [barsnick@paradise

[FFmpeg-devel] [PATCH 2/2] avfilter/vf_overlay: Remove superfluous ;

2020-08-21 Thread Andreas Rheinhardt
In a function body, a redundant ; is just a null statement that does nothing. Yet outside a function body, a superfluous ';' like one that exists if one adds a ';' immediately after a function body's closing brace is actually invalid C that compilers happen to accept. Yet when compiled in

[FFmpeg-devel] [PATCH 1/2] avcodec/cfhd: Remove unused-but-set variable

2020-08-21 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/cfhd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/cfhd.c b/libavcodec/cfhd.c index 2b1db0ed8d..adfbcc460d 100644 --- a/libavcodec/cfhd.c +++ b/libavcodec/cfhd.c @@ -1463,7 +1463,7 @@ finish: if

Re: [FFmpeg-devel] [PATCH] lavu/buffer: forward av_buffer_realloc() error code.

2020-08-21 Thread Nicolas George
Nicolas George (12020-08-09): > Ping? Will apply next time I think about it if nobody objects and it > still applies. Pushed. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH V2] dnn: move output name from DNNModel.set_input_output to DNNModule.execute_model

2020-08-21 Thread Fu, Ting
> -Original Message- > From: ffmpeg-devel On Behalf Of Guo, > Yejun > Sent: Friday, August 21, 2020 01:34 PM > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH V2] dnn: move output name from > DNNModel.set_input_output to DNNModule.execute_model > > currently, output is set

Re: [FFmpeg-devel] [PATCH] libavfilter/vf_overlay_cuda: Pass the main frame to the output if secondary frame is not available. now filter fails if secondary frame is not available due to e.g secondary

2020-08-21 Thread Nicolas George
Alex Pokotilo (12020-08-21): > From b3739e33fa04a9292dc6584bd2f31460aa53d478 Mon Sep 17 00:00:00 2001 > From: Alex Pokotilo > Date: Fri, 21 Aug 2020 09:14:37 + > Subject: [PATCH] libavfilter/vf_overlay_cuda: Pass the main frame to the > output if secondary frame is not > available. now

Re: [FFmpeg-devel] [PATCH v2] avfilter/fifo: Remove unused functions and headers

2020-08-21 Thread Nicolas George
Andreas Rheinhardt (12020-08-21): > Forgotten in 03c8fe49ea3f2a2444607e541dff15a1ccd7f0c2. > > Signed-off-by: Andreas Rheinhardt > --- > Two more headers in this file are unnecessary: > libavutil/channel_layout.h and video.h, but they were already > unnecessary before the last patch. Should I

[FFmpeg-devel] [PATCH v2] avfilter/fifo: Remove unused functions and headers

2020-08-21 Thread Andreas Rheinhardt
Forgotten in 03c8fe49ea3f2a2444607e541dff15a1ccd7f0c2. Signed-off-by: Andreas Rheinhardt --- Two more headers in this file are unnecessary: libavutil/channel_layout.h and video.h, but they were already unnecessary before the last patch. Should I remove them in this commit or in a separate

[FFmpeg-devel] [PATCH] libavfilter/vf_overlay_cuda: Pass the main frame to the output if secondary frame is not available. now filter fails if secondary frame is not available due to e.g secondary sou

2020-08-21 Thread Alex Pokotilo
From b3739e33fa04a9292dc6584bd2f31460aa53d478 Mon Sep 17 00:00:00 2001 From: Alex Pokotilo Date: Fri, 21 Aug 2020 09:14:37 + Subject: [PATCH] libavfilter/vf_overlay_cuda: Pass the main frame to the output if secondary frame is not available. now filter fails if secondary frame is not

Re: [FFmpeg-devel] [PATCH] lavu/avstring: deprecate av_d2str().

2020-08-21 Thread Nicolas George
Nicolas George (12020-08-09): > I never pushed this. I will next time I think about it. Pushed. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avfilter/fifo: Remove unused functions and header

2020-08-21 Thread Nicolas George
Andreas Rheinhardt (12020-08-21): > Forgotten in 03c8fe49ea3f2a2444607e541dff15a1ccd7f0c2. > > Signed-off-by: Andreas Rheinhardt Good catch, thank you. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing

[FFmpeg-devel] [PATCH] avfilter/fifo: Remove unused functions and header

2020-08-21 Thread Andreas Rheinhardt
Forgotten in 03c8fe49ea3f2a2444607e541dff15a1ccd7f0c2. Signed-off-by: Andreas Rheinhardt --- Patchwork warned about this [1]. [1]: https://patchwork.ffmpeg.org/project/ffmpeg/patch/20200812172558.262021-4-geo...@nsup.org/ libavfilter/fifo.c | 46 --

Re: [FFmpeg-devel] [PATCH v2] avformat/http, tls: honor http_proxy command line variable for HTTPS

2020-08-21 Thread Martin Storsjö
Hej Moritz, On Fri, 21 Aug 2020, Moritz Barsnick wrote: Patch version 2 attached, with added documentation. LGTM, with one small nit: @@ -49,6 +50,7 @@ typedef struct TLSShared { {"cert_file", "Certificate file",offsetof(pstruct, options_field . cert_file),

[FFmpeg-devel] [PATCH V3 2/2] dnn_backend_native_layer_mathbinary: change to function pointer

2020-08-21 Thread Mingyu Yin
Signed-off-by: Mingyu Yin --- .../dnn/dnn_backend_native_layer_mathbinary.c | 166 +- 1 file changed, 80 insertions(+), 86 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_native_layer_mathbinary.c b/libavfilter/dnn/dnn_backend_native_layer_mathbinary.c index

[FFmpeg-devel] [PATCH V3 1/2] dnn_backend_native_layer_mathbinary: add floormod support

2020-08-21 Thread Mingyu Yin
Signed-off-by: Mingyu Yin --- .../dnn/dnn_backend_native_layer_mathbinary.c | 17 + .../dnn/dnn_backend_native_layer_mathbinary.h | 1 + tests/dnn/dnn-layer-mathbinary-test.c | 5 + tools/python/convert_from_tensorflow.py | 2 +-

Re: [FFmpeg-devel] [PATCH] avcodec: add RPZA encoder

2020-08-21 Thread Paul B Mahol
On 7/19/20, James Almer wrote: > On 7/16/2020 11:54 AM, Paul B Mahol wrote: >> +if (!s->prev_frame->data[0]) { >> +s->first_frame = 1; >> +ret = ff_get_buffer(avctx, s->prev_frame, 0); > > This is for decoders only. Fill format, width and height on > s->prev_frame then call

[FFmpeg-devel] [PATCH v2] avformat/http, tls: honor http_proxy command line variable for HTTPS

2020-08-21 Thread Moritz Barsnick
Patch version 2 attached, with added documentation. Moritz From 2f2a43e4c684cd4bfda420bbedf5125dd78b3b34 Mon Sep 17 00:00:00 2001 From: Moritz Barsnick Date: Thu, 20 Aug 2020 17:49:14 +0200 Subject: [PATCH] avformat/http,tls: honor http_proxy command line variable for HTTPS Add the

Re: [FFmpeg-devel] [PATCH v2 1/2] qsv: needn't load user plugin since libmfx 1.28

2020-08-21 Thread Max Dmitrichenko
On Fri, Aug 21, 2020 at 9:29 AM Xiang, Haihao wrote: > On Fri, 2020-08-21 at 05:48 +, Soft Works wrote: > > > -Original Message- > > > From: ffmpeg-devel On Behalf Of > > > Haihao Xiang > > > Sent: Friday, August 21, 2020 7:23 AM > > > To: ffmpeg-devel@ffmpeg.org > > > Cc: Haihao

Re: [FFmpeg-devel] [PATCH 2/2] qsv: remove audio error code

2020-08-21 Thread Thilo Borgmann
> > > On Thu, 2020-08-20 at 02:26 +0200, Thilo Borgmann wrote: >> Am 20.08.20 um 02:13 schrieb Xiang, Haihao: >>> On Wed, 2020-08-19 at 13:53 +0200, Nicolas George wrote: Haihao Xiang (12020-08-19): > --- > libavcodec/qsv.c | 3 --- > 1 file changed, 3 deletions(-) > >

Re: [FFmpeg-devel] [PATCH v2 1/2] qsv: needn't load user plugin since libmfx 1.28

2020-08-21 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Xiang, Haihao > Sent: Friday, August 21, 2020 9:29 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v2 1/2] qsv: needn't load user plugin > since libmfx 1.28 > > On Fri, 2020-08-21 at 05:48 +, Soft Works

Re: [FFmpeg-devel] [PATCH v2 1/2] qsv: needn't load user plugin since libmfx 1.28

2020-08-21 Thread Xiang, Haihao
On Fri, 2020-08-21 at 05:48 +, Soft Works wrote: > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Haihao Xiang > > Sent: Friday, August 21, 2020 7:23 AM > > To: ffmpeg-devel@ffmpeg.org > > Cc: Haihao Xiang > > Subject: [FFmpeg-devel] [PATCH v2 1/2] qsv: needn't load

[FFmpeg-devel] [PATCH] dnn_backend_native_layer_mathbinary: change to function pointer

2020-08-21 Thread Mingyu Yin
Signed-off-by: Mingyu Yin --- .../dnn/dnn_backend_native_layer_mathbinary.c | 166 +- 1 file changed, 80 insertions(+), 86 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_native_layer_mathbinary.c b/libavfilter/dnn/dnn_backend_native_layer_mathbinary.c index

Re: [FFmpeg-devel] [PATCH] fix memory leak in qsvenc.c

2020-08-21 Thread Alex Pokotilo
> Seems reasonable, any special reason to reorder av_freep()? I want to combine "bs" and it's children structures disposal in the same order as in ff_qsv_encode where we have #if QSV_VERSION_ATLEAST(1, 26) if (avctx->codec_id == AV_CODEC_ID_H264) { enc_buf = bs->ExtParam;

[FFmpeg-devel] [PATCH] Set AVSTREAM_PARSE_HEADERS flag for AV1 MP4 streams

2020-08-21 Thread Vikas Agrawal (Engrg-SW)
Updated patch as per recommendation. It help initialize chroma format and other info properly Chroma format wasn't correct if I use below code: avformat_find_stream_info(fmtc, NULL); iVideoStream = av_find_best_stream(fmtc, AVMEDIA_TYPE_VIDEO, -1, -1, NULL, 0);

Re: [FFmpeg-devel] [PATCH 4/4] lavfi/buffersink: remove redundant channel layouts.

2020-08-21 Thread Michael Niedermayer
On Thu, Aug 20, 2020 at 04:50:05PM +0200, Nicolas George wrote: > The channel_layouts and channel_counts options set what buffersink > is supposed to accept. If channel_counts contains 2, then stereo is > already accepted, there is no point in having it in channel_layouts > too. This was not