[FFmpeg-devel] [PATCH 1/3] avcodec/cbs_av1: add derived frame size to AV1RawFrameHeader

2020-08-22 Thread James Almer
Same logic as tile_cols and tile_rows, this saves CBS users having to recalculate these values, and makes them available for all frames within a Temporal Unit. Signed-off-by: James Almer --- Not a fan of adding more derived values to "raw" structs, but much like the tile ones, these will be

Re: [FFmpeg-devel] [PATCH 3/3] avfilter/allfilters: Don't cast const away

2020-08-22 Thread Zhao Zhili
> On Aug 23, 2020, at 7:04 AM, Andreas Rheinhardt > wrote: > > Casting const away directly before return is completely pointless > here as avfilter_get_by_name() already returns a const AVFilter *. > > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/allfilters.c | 2 +- > 1 file

[FFmpeg-devel] [PATCH 2/3] avcodec/av1_parser: read frame dimensions directly from AV1RawFrameHeader

2020-08-22 Thread James Almer
Signed-off-by: James Almer --- libavcodec/av1_parser.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/av1_parser.c b/libavcodec/av1_parser.c index cd426a2b0f..0a34f20a59 100644 --- a/libavcodec/av1_parser.c +++ b/libavcodec/av1_parser.c @@ -127,8 +127,8 @@

[FFmpeg-devel] [PATCH 3/3] avcodec/cbs_av1: remove frame dimensions from CodedBitstreamAV1Context

2020-08-22 Thread James Almer
The values contained in these fields are only valid for the last frame parsed by CBS. Unlike tile_rows and tile_cols, these are not used in functions within cbs_av1_syntax_template.c that don't have access to the relevant AV1RawFrameHeader, and since each frame now has their relevant derived

Re: [FFmpeg-devel] [PATCH v2] avformat/mpegtsenc: support DVB 6A descriptor for AC-3

2020-08-22 Thread lance . lmwang
On Sat, Aug 22, 2020 at 07:36:24PM +0200, Marton Balint wrote: > > > On Sat, 15 Aug 2020, lance.lmw...@gmail.com wrote: > > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > configure | 2 +- > > libavformat/mpegts.h| 16 ++ > > libavformat/mpegtsenc.c

Re: [FFmpeg-devel] [PATCH 7/8] avformat/mpegtsenc: add registration descriptor for AC-3 and EAC3

2020-08-22 Thread lance . lmwang
On Sat, Aug 22, 2020 at 07:27:30PM +0200, Marton Balint wrote: > > > On Sat, 22 Aug 2020, lance.lmw...@gmail.com wrote: > > > On Wed, Jul 22, 2020 at 11:27:38PM +0800, lance.lmw...@gmail.com wrote: > > > From: Limin Wang > > > > > > copy the atsc ac3 audio in ts like below: > > > ./ffmpeg -i

[FFmpeg-devel] [PATCH 1/3] avfilter/graphparser: Fix leaks when parsing inputs fails

2020-08-22 Thread Andreas Rheinhardt
parse_inputs() uses a temporary linked list to parse the labeled inputs of a filter; said linked list owns its elements (and their names). On success, the list of unlabeled inputs is appened to the end of the list of labeled inputs and the new list is returned; yet on failures, nothing frees the

[FFmpeg-devel] [PATCH 3/3] avfilter/allfilters: Don't cast const away

2020-08-22 Thread Andreas Rheinhardt
Casting const away directly before return is completely pointless here as avfilter_get_by_name() already returns a const AVFilter *. Signed-off-by: Andreas Rheinhardt --- libavfilter/allfilters.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/allfilters.c

[FFmpeg-devel] [PATCH 2/3] avfilter/graphparser: Don't set pointer to one beyond '\0' of string

2020-08-22 Thread Andreas Rheinhardt
This happened in parse_link_name() if there was a '[' without matching ']'. While this is not undefined behaviour (pointer arithmetic one beyond the end of an array works fine as long as there are no accesses), it is potentially dangerous. It currently isn't (all callers of parse_link_name() treat

[FFmpeg-devel] [PATCH v6 3/4] configure: add FLIF dependencies

2020-08-22 Thread Anamitra Ghorui
Signed-off-by: Anamitra Ghorui --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 6faff9bc7b..a80e300cdb 100755 --- a/configure +++ b/configure @@ -3307,6 +3307,7 @@ fifo_muxer_deps="threads" flac_demuxer_select="flac_parser"

[FFmpeg-devel] [PATCH v6 2/4] lavfmt: add FLIF demuxing support

2020-08-22 Thread Anamitra Ghorui
Signed-off-by: Anamitra Ghorui --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/flifdec.c| 431 +++ libavformat/version.h| 2 +- 4 files changed, 434 insertions(+), 1 deletion(-) create mode 100644

[FFmpeg-devel] [PATCH v6 4/4] doc: add documentation entries for FLIF

2020-08-22 Thread Anamitra Ghorui
Signed-off-by: Anamitra Ghorui --- Changelog| 3 ++- doc/general.texi | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/Changelog b/Changelog index 7467e73306..cfa21c280b 100644 --- a/Changelog +++ b/Changelog @@ -15,7 +15,8 @@ version : - Argonaut Games ASF muxer -

[FFmpeg-devel] [PATCH] cbs_av1: Fill tile width/height values when uniform_tile_spacing_flag is set

2020-08-22 Thread Mark Thompson
They are not explicitly in the bitstream in this case, but it is helpful to be able to use these values without always needing to check the flag beforehand. --- On 22/08/2020 23:01, Mark Thompson wrote: On 21/08/2020 06:29, Fei Wang wrote: ... + +    if

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add av1 hardware acceleration decoder

2020-08-22 Thread Mark Thompson
On 21/08/2020 06:29, Fei Wang wrote: This av1 decoder is now only used for av1 hardware acceleration decoder. Consider it can be extend to a local decoder like hevc or vp9 in the future, so define its name as "av1" and put it into external libraries codec list. Signed-off-by: Fei Wang ---

Re: [FFmpeg-devel] [PATCH 2/3 v3] avcodec/aacdec_template: add more checks to make sure only 22.2 gets to 22.2

2020-08-22 Thread Carl Eugen Hoyos
Am Sa., 22. Aug. 2020 um 23:15 Uhr schrieb Jan Ekström : > > On Sat, Aug 22, 2020 at 11:42 PM Carl Eugen Hoyos wrote: > > > > Am Sa., 22. Aug. 2020 um 22:40 Uhr schrieb Jan Ekström : > > > > > > Validates the set channel layout as well as verifies that the received > > > layout to the function

Re: [FFmpeg-devel] [PATCH] fftools: Accept more negative prefixes

2020-08-22 Thread Mark Thompson
On 21/08/2020 06:49, Moritz Barsnick wrote: On Thu, Aug 20, 2020 at 22:49:16 +0100, Mark Thompson wrote: With this patch, -disable_auto_conversion_filters does what you want. [...] +if (!po->name) { +/* Try to match a boolean option with a negative prefix. */ +for (int i

Re: [FFmpeg-devel] [PATCH 2/3 v3] avcodec/aacdec_template: add more checks to make sure only 22.2 gets to 22.2

2020-08-22 Thread Jan Ekström
On Sat, Aug 22, 2020 at 11:42 PM Carl Eugen Hoyos wrote: > > Am Sa., 22. Aug. 2020 um 22:40 Uhr schrieb Jan Ekström : > > > > Validates the set channel layout as well as verifies that the received > > layout to the function matches the reference layout, so that it matches > > the implemented

Re: [FFmpeg-devel] [PATCH 2/3 v3] avcodec/aacdec_template: add more checks to make sure only 22.2 gets to 22.2

2020-08-22 Thread Jan Ekström
On Sat, Aug 22, 2020 at 11:39 PM Jan Ekström wrote: > > Validates the set channel layout as well as verifies that the received > layout to the function matches the reference layout, so that it matches > the implemented re-ordering logic. > > Fixes #8845 > --- > libavcodec/aacdec_template.c | 21

Re: [FFmpeg-devel] Documentation: proposed changes in the structure

2020-08-22 Thread Jim DeLaHunt
On  Fri Aug 21 15:35:38 EEST 2020,  Nicolas George wrote: > 1. What would you think about putting the documentation for > libavfilter/vf_foobar.c into libavfilter/doc/vf_foobar.texi … > 2. What would you think about switching from texinfo to a small basic > subset of HTML for new

Re: [FFmpeg-devel] [PATCH 2/3 v3] avcodec/aacdec_template: add more checks to make sure only 22.2 gets to 22.2

2020-08-22 Thread Andreas Rheinhardt
Jan Ekström: > Validates the set channel layout as well as verifies that the received > layout to the function matches the reference layout, so that it matches > the implemented re-ordering logic. > > Fixes #8845 What about the new tickets #8859, #8860? - Andreas

Re: [FFmpeg-devel] [PATCH 2/3 v3] avcodec/aacdec_template: add more checks to make sure only 22.2 gets to 22.2

2020-08-22 Thread Carl Eugen Hoyos
Am Sa., 22. Aug. 2020 um 22:40 Uhr schrieb Jan Ekström : > > Validates the set channel layout as well as verifies that the received > layout to the function matches the reference layout, so that it matches > the implemented re-ordering logic. > > Fixes #8845 Did you also see tickets #8859 and

[FFmpeg-devel] [PATCH 2/3 v3] avcodec/aacdec_template: add more checks to make sure only 22.2 gets to 22.2

2020-08-22 Thread Jan Ekström
Validates the set channel layout as well as verifies that the received layout to the function matches the reference layout, so that it matches the implemented re-ordering logic. Fixes #8845 --- libavcodec/aacdec_template.c | 21 +++-- 1 file changed, 19 insertions(+), 2

Re: [FFmpeg-devel] Documentation: proposed changes in the structure

2020-08-22 Thread Michael Niedermayer
On Sat, Aug 22, 2020 at 02:12:13PM +0200, Nicolas George wrote: > Clement Boesch (12020-08-22): > > AVOption.help and AVFilter.description (as well as AVCodec.description > > etc) do contain redundant information with the documentation. > > There is truth in what you say, but I disagree this is

Re: [FFmpeg-devel] [PATCH 2/3 v2] avcodec/aacdec_template: add more checks to make sure only 22.2 gets to 22.2

2020-08-22 Thread Michael Niedermayer
On Sat, Aug 22, 2020 at 05:01:05PM +0300, Jan Ekström wrote: > On Sat, Aug 22, 2020 at 4:44 PM Michael Niedermayer > wrote: > > > > On Sat, Aug 22, 2020 at 02:36:09PM +0300, Jan Ekström wrote: > > > On Sat, Aug 22, 2020 at 2:17 PM Michael Niedermayer > > > wrote: > > > > > > > > On Sat, Aug 22,

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec: add RPZA encoder

2020-08-22 Thread Alexander Strasser
Hi all, hi Paul! Shouldn't it have been also reflected in the commit's metadata, author or message, that the encoder was originally written by Todd Kirby and David Adler? Did you base it on the version from Jaikrishnan Menon? If yes, I think it should have been mentioned in the commit message

Re: [FFmpeg-devel] [PATCH v2] avformat/mpegtsenc: support DVB 6A descriptor for AC-3

2020-08-22 Thread Marton Balint
On Sat, 15 Aug 2020, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- configure | 2 +- libavformat/mpegts.h| 16 ++ libavformat/mpegtsenc.c | 84 +++-- 3 files changed, 99 insertions(+), 3

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/dvbsubenc: merge rectangle encode code blocks

2020-08-22 Thread Clément Bœsch
[...] Patchset applied, thanks for the review -- Clément B. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject

Re: [FFmpeg-devel] [PATCH] fate: add fate-sub-dvb test

2020-08-22 Thread Clément Bœsch
On Fri, Aug 21, 2020 at 10:22:23PM +0200, Clément Bœsch wrote: > On Fri, Aug 21, 2020 at 06:24:58PM +0200, Alexander Strasser wrote: > > On 2020-08-21 14:32 +0200, Clément Bœsch wrote: > > > On Tue, Aug 18, 2020 at 11:43:29PM +0200, Michael Niedermayer wrote: > > > > On Tue, Aug 18, 2020 at

Re: [FFmpeg-devel] [PATCH 7/8] avformat/mpegtsenc: add registration descriptor for AC-3 and EAC3

2020-08-22 Thread Marton Balint
On Sat, 22 Aug 2020, lance.lmw...@gmail.com wrote: On Wed, Jul 22, 2020 at 11:27:38PM +0800, lance.lmw...@gmail.com wrote: From: Limin Wang copy the atsc ac3 audio in ts like below: ./ffmpeg -i atsc_audio.ts -c:v copy -c:a copy out.ts Stream #0:6[0x64](eng): Audio: ac3 (AC-3 / 0x332D4341),

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavf/url: rewrite ff_make_absolute_url() using ff_url_decompose().

2020-08-22 Thread Alexander Strasser
On 2020-08-22 12:59 +0200, Nicolas George wrote: > Alexander Strasser (12020-08-15): > > If I'm not mistaken that reason for the rewrite didn't make > > it into the commit message: > > You are right. The reason for the complete rewrite was that the original > code was completely broken which I did

Re: [FFmpeg-devel] Documentation: proposed changes in the structure

2020-08-22 Thread Alexander Strasser
Hi Nicolas, hi Clement! Wow the discussion gets up to speed quickly :) Thanks for bringing up all those good points! I'm intentionally top-posting, because I want to say something concerning the points you discuss below. Though I couldn't find a good way to do it in a comment style, so instead

Re: [FFmpeg-devel] [PATCH 1/2] lavfi: regroup formats lists in a single structure.

2020-08-22 Thread Andreas Rheinhardt
Nicolas George: > Andreas Rheinhardt (12020-08-21): >> This only works if one only works with one list without owner at a time; >> if one has several such lists at the same time and an error happens when >> working with one of these lists, one has to free the other lists. >> >> This scenario can

Re: [FFmpeg-devel] [PATCH 2/3 v2] avcodec/aacdec_template: add more checks to make sure only 22.2 gets to 22.2

2020-08-22 Thread Jan Ekström
On Sat, Aug 22, 2020 at 4:44 PM Michael Niedermayer wrote: > > On Sat, Aug 22, 2020 at 02:36:09PM +0300, Jan Ekström wrote: > > On Sat, Aug 22, 2020 at 2:17 PM Michael Niedermayer > > wrote: > > > > > > On Sat, Aug 22, 2020 at 12:57:59AM +0300, Jan Ekström wrote: > > > > This way we can check

Re: [FFmpeg-devel] [PATCH 2/3 v2] avcodec/aacdec_template: add more checks to make sure only 22.2 gets to 22.2

2020-08-22 Thread Michael Niedermayer
On Sat, Aug 22, 2020 at 02:36:09PM +0300, Jan Ekström wrote: > On Sat, Aug 22, 2020 at 2:17 PM Michael Niedermayer > wrote: > > > > On Sat, Aug 22, 2020 at 12:57:59AM +0300, Jan Ekström wrote: > > > This way we can check that we have exactly the required things for 22.2. > > > > > > Fixes #8845 >

Re: [FFmpeg-devel] Documentation: proposed changes in the structure

2020-08-22 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Nicolas George > Sent: Saturday, August 22, 2020 2:12 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] Documentation: proposed changes in the > structure > > Clement Boesch

Re: [FFmpeg-devel] [PATCH 1/2] lavfi: regroup formats lists in a single structure.

2020-08-22 Thread Nicolas George
Andreas Rheinhardt (12020-08-21): > This only works if one only works with one list without owner at a time; > if one has several such lists at the same time and an error happens when > working with one of these lists, one has to free the other lists. > > This scenario can of course usually be

Re: [FFmpeg-devel] [PATCH v2 18/21] avfilter/vf_hwdownload: Fix leak of formats list upon error

2020-08-22 Thread Nicolas George
Andreas Rheinhardt (12020-08-21): > If adding the list of input formats to its AVFilterLink fails, the list > of output formats (which has not been attached to permanent storage yet) > leaks. This has been fixed by not creating the lists of in- and output > formats simultaneously. Instead creating

Re: [FFmpeg-devel] Documentation: proposed changes in the structure

2020-08-22 Thread Nicolas George
Clement Boesch (12020-08-22): > AVOption.help and AVFilter.description (as well as AVCodec.description > etc) do contain redundant information with the documentation. There is truth in what you say, but I disagree this is really redundant: AVOption.help and AV*.description are supposed to be very

Re: [FFmpeg-devel] [PATCH v2] avformat/mpegtsenc: support DVB 6A descriptor for AC-3

2020-08-22 Thread lance . lmwang
On Sat, Aug 15, 2020 at 10:27:38PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > configure | 2 +- > libavformat/mpegts.h| 16 ++ > libavformat/mpegtsenc.c | 84 > +++-- > 3

Re: [FFmpeg-devel] [PATCH 1/3] doc/texi2pod: support @float.

2020-08-22 Thread Gyan Doshi
On 22-08-2020 04:23 pm, Nicolas George wrote: Signed-off-by: Nicolas George --- doc/texi2pod.pl | 9 + 1 file changed, 9 insertions(+) diff --git a/doc/texi2pod.pl b/doc/texi2pod.pl index 9a9b34fc15..c7f67afe8c 100644 --- a/doc/texi2pod.pl +++ b/doc/texi2pod.pl @@ -172,6 +172,9 @@

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/aacdec_template: log the element order before/after reordering

2020-08-22 Thread Jan Ekström
On Sat, Aug 22, 2020 at 2:21 PM Michael Niedermayer wrote: > > On Sat, Aug 22, 2020 at 12:58:00AM +0300, Jan Ekström wrote: > > This was quite useful to verify that 22.2 got properly handled, > > among other things. > > --- > > libavcodec/aacdec_template.c | 26 ++ > > 1

Re: [FFmpeg-devel] [PATCH 2/3 v2] avcodec/aacdec_template: add more checks to make sure only 22.2 gets to 22.2

2020-08-22 Thread Jan Ekström
On Sat, Aug 22, 2020 at 2:17 PM Michael Niedermayer wrote: > > On Sat, Aug 22, 2020 at 12:57:59AM +0300, Jan Ekström wrote: > > This way we can check that we have exactly the required things for 22.2. > > > > Fixes #8845 > > --- > > libavcodec/aacdec_template.c | 47

Re: [FFmpeg-devel] [PATCH 7/8] avformat/mpegtsenc: add registration descriptor for AC-3 and EAC3

2020-08-22 Thread lance . lmwang
On Wed, Jul 22, 2020 at 11:27:38PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > copy the atsc ac3 audio in ts like below: > ./ffmpeg -i atsc_audio.ts -c:v copy -c:a copy out.ts > Stream #0:6[0x64](eng): Audio: ac3 (AC-3 / 0x332D4341), 48000 Hz, stereo, > fltp, 192 kb/s > >

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/aacdec_template: log the element order before/after reordering

2020-08-22 Thread Michael Niedermayer
On Sat, Aug 22, 2020 at 12:58:00AM +0300, Jan Ekström wrote: > This was quite useful to verify that 22.2 got properly handled, > among other things. > --- > libavcodec/aacdec_template.c | 26 ++ > 1 file changed, 26 insertions(+) > > diff --git

Re: [FFmpeg-devel] [PATCH 2/3 v2] avcodec/aacdec_template: add more checks to make sure only 22.2 gets to 22.2

2020-08-22 Thread Michael Niedermayer
On Sat, Aug 22, 2020 at 12:57:59AM +0300, Jan Ekström wrote: > This way we can check that we have exactly the required things for 22.2. > > Fixes #8845 > --- > libavcodec/aacdec_template.c | 47 ++-- > 1 file changed, 45 insertions(+), 2 deletions(-) > > diff

Re: [FFmpeg-devel] [PATCH 2/2] lavfi/avf_concat: check input timestamp.

2020-08-22 Thread Nicolas George
Nicolas George (12020-08-09): > If an input has an undefined timestamp, the computation > for silence at stitches can overflow. > > Partial fix for trac ticket #8843. > > Signed-off-by: Nicolas George > --- > libavfilter/avf_concat.c | 4 > 1 file changed, 4 insertions(+) Ping? Will

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavf/url: rewrite ff_make_absolute_url() using ff_url_decompose().

2020-08-22 Thread Nicolas George
Alexander Strasser (12020-08-15): > If I'm not mistaken that reason for the rewrite didn't make > it into the commit message: You are right. The reason for the complete rewrite was that the original code was completely broken which I did not want to include permanently in the history. By

Re: [FFmpeg-devel] [PATCH 1/1] libavformat/nut: Support SSA and ASS subtitles

2020-08-22 Thread Michael Niedermayer
On Fri, Aug 21, 2020 at 09:16:52PM -0700, h...@riseup.net wrote: > ffmpeg documentation says the NUT container supports SubStation Alpha > This brings actual functionality in line with documentation. > --- > libavformat/nut.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

[FFmpeg-devel] [PATCH 2/3] doc/general: move contents into a separate file.

2020-08-22 Thread Nicolas George
It will allow to include it. Signed-off-by: Nicolas George --- doc/general.texi| 1415 +-- doc/{general.texi => general_contents.texi} | 14 - 2 files changed, 1 insertion(+), 1428 deletions(-) copy doc/{general.texi => general_contents.texi} (99%)

[FFmpeg-devel] [PATCH 3/3] doc: include general in *-all pages.

2020-08-22 Thread Nicolas George
Signed-off-by: Nicolas George --- doc/ffmpeg.texi | 1 + doc/ffplay.texi | 1 + doc/ffprobe.texi | 1 + 3 files changed, 3 insertions(+) diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi index 267ddfe8b5..329ee3019f 100644 --- a/doc/ffmpeg.texi +++ b/doc/ffmpeg.texi @@ -2040,6 +2040,7 @@ ffmpeg

[FFmpeg-devel] [PATCH 1/3] doc/texi2pod: support @float.

2020-08-22 Thread Nicolas George
Signed-off-by: Nicolas George --- doc/texi2pod.pl | 9 + 1 file changed, 9 insertions(+) diff --git a/doc/texi2pod.pl b/doc/texi2pod.pl index 9a9b34fc15..c7f67afe8c 100644 --- a/doc/texi2pod.pl +++ b/doc/texi2pod.pl @@ -172,6 +172,9 @@ INF: while(<$inf>) { } elsif ($ended =~

Re: [FFmpeg-devel] [PATCH] avcodec/rzpaenc: Remove set-but-unused variable

2020-08-22 Thread Paul B Mahol
On 8/22/20, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/rpzaenc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org