[FFmpeg-devel] [PATCH] avformat/httpauth: add SHA-256 Digest Authorization

2024-03-25 Thread 정지우 | Eugene
- add SHA-256 Digest Authorization for RFC7616 using avutil/hash.h Signed-off-by: Eugene-bitsensing --- libavformat/httpauth.c | 116 - libavformat/httpauth.h | 8 +++ 2 files changed, 123 insertions(+), 1 deletion(-) diff --git

[FFmpeg-devel] [PATCH 3/3] avcodec/hevc_ps: Make ff_hevc_parse_ps static

2024-03-25 Thread Andreas Rheinhardt
It is only used here since its other caller (qsvenc_hevc.c) has been switched to cbs_h265. Signed-off-by: Andreas Rheinhardt --- libavcodec/hevc_ps.c | 14 +++--- libavcodec/hevc_ps.h | 13 - 2 files changed, 7 insertions(+), 20 deletions(-) diff --git

[FFmpeg-devel] [PATCH 2/3] avcodec/qsvenc_hevc: Switch to cbs_h265 to create missing VPS

2024-03-25 Thread Andreas Rheinhardt
Old MXF runtime versions did not support writing VPS and therefore one derived from the SPS has been generated via ad-hoc code in lavc/hevc_ps_enc.c that is only used for this purpose. Yet this duplicates the functionality from cbs_h265, so replace it with the latter. This patch has been tested

[FFmpeg-devel] [PATCH 1/3] avcodec/Makefile: Remove redundant dependencies on hevc_data.o

2024-03-25 Thread Andreas Rheinhardt
hevc_data.c only provides ff_hevc_diag_scan tables and neither the QSV HEVC encoder nor the HEVC parser use these directly and the indirect dependency is already accounted for in the dependencies of the hevcparse subsystem since b0c61209cd30f9ddf3356d5ded6df488f25d1bd5, so remove these spurious

Re: [FFmpeg-devel] Add optimization in swscale for LA.

2024-03-25 Thread Shiyou Yin
> 2024年3月16日 11:03,Shiyou Yin 写道: > > [PATCH 1/3] swscale: [LA] Optimize range convert for yuvj420p. > [PATCH 2/3] swscale: [LA] Optimize yuv2plane1_8_c. > [PATCH 3/3] swscale: [LA] Optimize swscale funcs in input.c > > ___ > ffmpeg-devel mailing

[FFmpeg-devel] [PATCH] avcodec/h264_parse: Fix error code in decode_extradata

2024-03-25 Thread Zhao Zhili
From: Zhao Zhili --- libavcodec/h264_parse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/h264_parse.c b/libavcodec/h264_parse.c index 3378650fd5..09d3b9dc05 100644 --- a/libavcodec/h264_parse.c +++ b/libavcodec/h264_parse.c @@ -468,7 +468,7 @@ int

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec: remove deprecated FF_CODEC_CRYSTAL_HD

2024-03-25 Thread Michael Niedermayer
On Thu, Mar 07, 2024 at 02:41:51PM +, James Almer wrote: > ffmpeg | branch: master | James Almer | Sat Jan 20 > 10:35:23 2024 -0300| [5b23b18d40ead8606c92d967279b3f43c94d8a60] | committer: > James Almer > > avcodec: remove deprecated FF_CODEC_CRYSTAL_HD > > Signed-off-by: James Almer >

Re: [FFmpeg-devel] [PATCH 4/7] avcodec/rtv1: fix undefined FFALIGN

2024-03-25 Thread Andreas Rheinhardt
James Almer: > On 3/25/2024 11:30 PM, Michael Niedermayer wrote: >> Fixes: signed integer overflow: 2147483647 + 4 cannot be represented >> in type 'int' >> Fixes: >> 62285/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RTV1_fuzzer-6324303861514240 >> >> Found-by: continuous fuzzing process >>

Re: [FFmpeg-devel] [PATCH 4/7] avcodec/rtv1: fix undefined FFALIGN

2024-03-25 Thread James Almer
On 3/25/2024 11:30 PM, Michael Niedermayer wrote: Fixes: signed integer overflow: 2147483647 + 4 cannot be represented in type 'int' Fixes: 62285/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RTV1_fuzzer-6324303861514240 Found-by: continuous fuzzing process

[FFmpeg-devel] [PATCH 7/7] avcodec/wavarc: avoid signed integer overflow in AC code

2024-03-25 Thread Michael Niedermayer
Fixes: 62285/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WAVARC_fuzzer-659847401740697 Fixes: signed integer overflow: 65312 * 34078 cannot be represented in type 'int' Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

[FFmpeg-devel] [PATCH 6/7] avcodec/wavarc: Avoid signed integer overflow in sample

2024-03-25 Thread Michael Niedermayer
Fixes: signed integer overflow: -2147483648 + -25122315 cannot be represented in type 'int' Fixes: 62285/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WAVARC_fuzzer-6199806972198912 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

[FFmpeg-devel] [PATCH 5/7] avcodec/truemotion1: Height not being a multiple of 4 is unsupported

2024-03-25 Thread Michael Niedermayer
mb_change_bits is given space based on height >> 2, while more data is read Fixes: out of array access Fixes: 62285/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TRUEMOTION1_fuzzer-5201925062590464.fuzz Found-by: continuous fuzzing process

[FFmpeg-devel] [PATCH 4/7] avcodec/rtv1: fix undefined FFALIGN

2024-03-25 Thread Michael Niedermayer
Fixes: signed integer overflow: 2147483647 + 4 cannot be represented in type 'int' Fixes: 62285/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RTV1_fuzzer-6324303861514240 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

[FFmpeg-devel] [PATCH 3/7] avcodec/qoadec: Fix undefined overflow in lms_predict

2024-03-25 Thread Michael Niedermayer
Fixes: signed integer overflow: -1575944192 + -602931200 cannot be represented in type 'int' Fixes: 62285/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_QOA_fuzzer-6470469339185152 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

[FFmpeg-devel] [PATCH 2/7] avcodec/hcadec: do not allow code to continue after failed init

2024-03-25 Thread Michael Niedermayer
Fixes: 62285/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HCA_fuzzer-6247136417087488 Fixes: out of array write Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/hcadec.c | 4 +++- 1 file

[FFmpeg-devel] [PATCH 1/7] avcodec/hcadec: do not set hfr_group_count to invalid values

2024-03-25 Thread Michael Niedermayer
Fixes: 62285/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HCA_fuzzer-6247136417087488 Fixes: out of array write Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/hcadec.c | 6 -- 1

Re: [FFmpeg-devel] [PATCH] tests: Remove fate-libx265-hdr10

2024-03-25 Thread Zhao Zhili
Ping. Is it OK to apply the patch as it is? > On Mar 23, 2024, at 06:36, Jan Ekström wrote: > > On Fri, Mar 22, 2024 at 10:18 PM Anton Khirnov wrote: >> >> Quoting Zhao Zhili (2024-03-22 13:43:43) >>> From: Zhao Zhili >>> >>> The test depends on the compile option of x265. It failed when

Re: [FFmpeg-devel] [PATCH] avformat/mov: don't use cur_item_id as array index

2024-03-25 Thread James Almer
On 3/25/2024 11:18 PM, Michael Niedermayer wrote: On Mon, Mar 25, 2024 at 10:28:52PM -0300, James Almer wrote: Signed-off-by: James Almer --- libavformat/mov.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) havnt tested, but it improves the code, so definityl LGTM

Re: [FFmpeg-devel] [PATCH] avformat/mov: don't use cur_item_id as array index

2024-03-25 Thread Michael Niedermayer
On Mon, Mar 25, 2024 at 10:28:52PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libavformat/mov.c | 16 ++-- > 1 file changed, 6 insertions(+), 10 deletions(-) havnt tested, but it improves the code, so definityl LGTM thx [...] -- Michael GnuPG fingerprint:

[FFmpeg-devel] Fwd: [PATCH] fftools/ffplay: split filters & show modes cycling into separate keys

2024-03-25 Thread Ondřej Fiala
I am forwarding a patch from December that seems to have been overlooked. See the original threads in the archive: https://ffmpeg.org/pipermail/ffmpeg-devel/2023-December/318613.html https://ffmpeg.org/pipermail/ffmpeg-devel/2023-December/318654.html Forwarded message from Ondřej Fiala on Tue

[FFmpeg-devel] [PATCH] avformat/mov: don't use cur_item_id as array index

2024-03-25 Thread James Almer
Signed-off-by: James Almer --- libavformat/mov.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index f954b924a0..9f2ea97a5b 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -8085,7 +8085,6 @@ static int

Re: [FFmpeg-devel] [PATCH 2/3] avformat/mov: Do not deallocate heif_item in a input dependant way

2024-03-25 Thread James Almer
On 3/22/2024 8:08 PM, Michael Niedermayer wrote: Fixes: out of array access Fixes: 67070/clusterfuzz-testcase-minimized-ffmpeg_IO_DEMUXER_fuzzer-5685384082161664 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael

[FFmpeg-devel] [PATCH 2/2] Add fate test for hls metadata update.

2024-03-25 Thread Romain Beauxis
This patch adds a FATE test for the new HLS metadata update. The fate sample consists of a two segment AAC hls stream. The first segment has test title 1 as title metadata while the second has test title 2. In the log, we can see that test title 2 is reported for the stream, indicating that the

[FFmpeg-devel] [PATCH 1/2] libavformat/hls.c: support in-stream ID3 metadata update.

2024-03-25 Thread Romain Beauxis
This patch adds support for updating HLS metadata passed as ID3 frames. This seems like a pretty straight-forward improvement. Updating the metadaata of the first stream seems to be the mechanism is other places in the code and works as expected. --- libavformat/hls.c | 54

Re: [FFmpeg-devel] [PATCH 2/3] avformat/jacosubdec: clarify code

2024-03-25 Thread Michael Niedermayer
On Wed, Oct 11, 2023 at 08:10:14PM +0200, Michael Niedermayer wrote: > add comments, rename variables and indent things differently > > Is it clearer now ? > > Signed-off-by: Michael Niedermayer > --- > libavformat/jacosubdec.c | 18 +- > 1 file changed, 9 insertions(+), 9

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/osq: avoid several signed integer overflows

2024-03-25 Thread Michael Niedermayer
On Tue, Dec 26, 2023 at 05:37:30PM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: 178459578 + 2009763270 cannot be represented > in type 'int' > Fixes: > 62285/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_OSQ_fuzzer-5013423686287360 > > Found-by: continuous fuzzing

[FFmpeg-devel] [PATCH 10/10] avformat/westwood_vqa: Fix 2g packets

2024-03-25 Thread Michael Niedermayer
Fixes: signed integer overflow: 2147483424 * 2 cannot be represented in type 'int' Fixes: 62276/clusterfuzz-testcase-minimized-ffmpeg_dem_WSVQA_fuzzer-4576211411795968 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael

[FFmpeg-devel] [PATCH 09/10] avformat/matroskadec: Check timescale

2024-03-25 Thread Michael Niedermayer
Fixes: 3.82046e+18 is outside the range of representable values of type 'unsigned int' Fixes: 62276/clusterfuzz-testcase-minimized-ffmpeg_dem_WEBM_DASH_MANIFEST_fuzzer-6381436594421760 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

[FFmpeg-devel] [PATCH 08/10] avformat/wavdec: satuarte next_tag_ofs, data_end

2024-03-25 Thread Michael Niedermayer
Fixes: signed integer overflow: 5053074104798691550 + 5053074104259715104 cannot be represented in type 'long' Fixes: 62276/clusterfuzz-testcase-minimized-ffmpeg_dem_WAV_fuzzer-6515315309936640 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

[FFmpeg-devel] [PATCH 07/10] avformat/wavdec: sanity check channels and bps before using them for block_align

2024-03-25 Thread Michael Niedermayer
Fixes: 62276/clusterfuzz-testcase-minimized-ffmpeg_dem_W64_fuzzer-4704044498944000 Fixes: signed integer overflow: 520464 * 8224 cannot be represented in type 'int' Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael

[FFmpeg-devel] [PATCH 06/10] avformat/sbgdec: Check for negative duration

2024-03-25 Thread Michael Niedermayer
Fixes: signed integer overflow: 9223372036854775807 - -800 cannot be represented in type 'long' Fixes: 62276/clusterfuzz-testcase-minimized-ffmpeg_dem_SBG_fuzzer-5133181743136768 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

[FFmpeg-devel] [PATCH 05/10] avformat/rpl: Use 64bit for total_audio_size and check it

2024-03-25 Thread Michael Niedermayer
Fixes: 62276/clusterfuzz-testcase-minimized-ffmpeg_dem_RPL_fuzzer-4677434693517312 Fixes: signed integer overflow: 556 * 8 cannot be represented in type 'long long' Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

[FFmpeg-devel] [PATCH 04/10] avformat/timecode: use 64bit for intermediate for rounding in fps_from_frame_rate()

2024-03-25 Thread Michael Niedermayer
Fixes: 62276/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-4802790784303104 Fixes: signed integer overflow: 1768972133 + 968491058 cannot be represented in type 'int' Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

[FFmpeg-devel] [PATCH 03/10] avformat/mov: use 64bit for intermediate for rounding

2024-03-25 Thread Michael Niedermayer
Fixes: signed integer overflow: 1768972133 + 968491058 cannot be represented in type 'int' Fixes: 62276/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-4802790784303104 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

[FFmpeg-devel] [PATCH 02/10] avformat/jacosubdec: Use 64bit for abs

2024-03-25 Thread Michael Niedermayer
Fixes: negation of -2147483648 cannot be represented in type 'int'; cast to an unsigned type to negate this value to itself Fixes: 62276/clusterfuzz-testcase-minimized-ffmpeg_dem_JACOSUB_fuzzer-5401294942371840 Found-by: continuous fuzzing process

[FFmpeg-devel] [PATCH 01/10] avformat/concatdec: Check user_duration sum

2024-03-25 Thread Michael Niedermayer
Fixes: 62276/clusterfuzz-testcase-minimized-ffmpeg_dem_CONCAT_fuzzer-6434245599690752 Fixes: signed integer overflow: 922337202677300 + 2233700 cannot be represented in type 'long' Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

Re: [FFmpeg-devel] [PATCH v4 1/2] avcodec/ccaption_dec: don't print multiple \an and \pos tags

2024-03-25 Thread Marth64
This should be withheld until after 7.0. In the same bug report it appears that 1 user is making use of the erroneous tags via an external script for a valid purpose. I don’t want to break people’s workflow even though it’s invalid ASS. After 7.0 I will revive this patchset and with additional

Re: [FFmpeg-devel] [PATCH 6/6] avformat/iff: Saturate avio_tell() + 12

2024-03-25 Thread Michael Niedermayer
On Sat, Sep 30, 2023 at 01:20:01AM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 9223372036854775796 + 12 cannot be > represented in type 'long long' > Fixes: > 51896/clusterfuzz-testcase-minimized-ffmpeg_dem_IFF_fuzzer-4898373660704768 > > Found-by: continuous fuzzing

Re: [FFmpeg-devel] [PATCH 4/6] avformat/cafdec: saturate start + size into 64bit

2024-03-25 Thread Michael Niedermayer
On Sat, Sep 30, 2023 at 06:32:07PM +0200, Michael Niedermayer wrote: > On Fri, Sep 29, 2023 at 08:41:23PM -0300, James Almer wrote: > > On 9/29/2023 8:19 PM, Michael Niedermayer wrote: > > > Fixes: signed integer overflow: 64 + 9223372036854775803 cannot be > > > represented in type 'long long' >

Re: [FFmpeg-devel] [PATCH 1/6] avformat/avidec: support huge durations

2024-03-25 Thread Michael Niedermayer
On Tue, Oct 03, 2023 at 08:53:33PM +0200, Michael Niedermayer wrote: > On Tue, Oct 03, 2023 at 11:10:20AM +0200, Tomas Härdin wrote: > > mån 2023-10-02 klockan 21:03 +0200 skrev Michael Niedermayer: > > > On Mon, Oct 02, 2023 at 11:07:47AM +0200, Anton Khirnov wrote: > > > > Quoting Michael

Re: [FFmpeg-devel] [PATCH v4 1/2] avcodec/ccaption_dec: don't print multiple \an and \pos tags

2024-03-25 Thread Marth64
This also fixes https://trac.ffmpeg.org/ticket/10927 (recently reported by a user) ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

Re: [FFmpeg-devel] [PATCH] avcodec/h264_mp4toannexb: Fix heap buffer overflow

2024-03-25 Thread Michael Niedermayer
On Mon, Mar 25, 2024 at 04:09:00PM +0800, Zhao Zhili wrote: > From: Zhao Zhili > > Fixes: out of array write > Fixes: > 64407/clusterfuzz-testcase-minimized-ffmpeg_BSF_H264_MP4TOANNEXB_fuzzer-4966763443650560 > > mp4toannexb_filter counts the number of bytes needed in the first > pass and

Re: [FFmpeg-devel] [PATCH v2 1/2] avutil/timestamp: introduce av_ts_make_time_string2 for better precision

2024-03-25 Thread Allan Cady via ffmpeg-devel
> On Sat, 23 Mar 2024, Marton Balint wrote: >> av_ts_make_time_string() used "%.6g" format, but this format was losing >> precision even when the timestamp to be printed was not that large. For >> example >> for 3 hours (10800) seconds, only 1 decimal digit was printed, which made >> this >>

Re: [FFmpeg-devel] [PATCH] fate: fix sub2video_{basic, time_limited} on big-endian targets

2024-03-25 Thread Sean McGovern
Hi, On Fri, Mar 8, 2024, 10:11 Sean McGovern wrote: > On Wed, Mar 6, 2024, 18:48 Sean McGovern wrote: > >> The reference file uses BGRA pixel format, so request it here. >> --- >> tests/fate/ffmpeg.mak | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/tests/fate/ffmpeg.mak

Re: [FFmpeg-devel] [RFC] 7.0 blocking issues

2024-03-25 Thread Michael Niedermayer
On Mon, Mar 25, 2024 at 09:18:09PM +, Kieran Kunhya wrote: > On Mon, 25 Mar 2024 at 21:10, Michael Niedermayer > wrote: > > > On Mon, Mar 25, 2024 at 09:20:25PM +0100, Lynne wrote: > > > Mar 25, 2024, 14:50 by ffm...@haasn.xyz: > > > > > > > On Mon, 25 Mar 2024 07:20:56 +0100 "Jean-Baptiste

Re: [FFmpeg-devel] [PATCH 00/21] aarch64: hevc: Add missing hevc_pel NEON functions

2024-03-25 Thread J. Dekker
> On Mon, 25 Mar 2024, Martin Storsjö wrote: > >> Since some time, we have pretty complete AArch64 NEON coverage >> for the hevc decoder. >> >> However, some of these functions require the I8MM instruction set >> extension, and many of them (but not all) lack a plain NEON >> version. >> >>

Re: [FFmpeg-devel] [PATCH 13/13] fftools/ffmpeg_mux_init: Fix double-free on error

2024-03-25 Thread Marth64
I had actually applied this patch while looking into a ticket near the same code path. LGTM. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

Re: [FFmpeg-devel] [PATCH 03/10] avutil/common: Don't auto-include mem.h

2024-03-25 Thread Andreas Rheinhardt
Michael Niedermayer: > On Mon, Mar 25, 2024 at 02:53:17AM +0100, Andreas Rheinhardt wrote: >> There are lots of files that don't need it: The number of object >> files that actually need it went down from 2011 to 884 here. >> >> Keep it for external users in order to not cause breakages. >> >>

Re: [FFmpeg-devel] [PATCH] avformat/dvdvideodec: add explicit inttypes.h include

2024-03-25 Thread Marth64
v2 on the way. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH v2] avformat/dvdvideodec: add explicit inttypes.h include

2024-03-25 Thread Marth64
Since log statements printing int64 were made portable in 4464b7eeb194e98ac115f18d2b6be67361407c8a, let us include inttypes.h explicitly (as it is unclear where PRId64 and such are coming from now). Reported-by: Traneptora Signed-off-by: Marth64 --- libavformat/dvdvideodec.c | 2 ++ 1 file

Re: [FFmpeg-devel] [PATCH 03/10] avutil/common: Don't auto-include mem.h

2024-03-25 Thread Michael Niedermayer
On Mon, Mar 25, 2024 at 02:53:17AM +0100, Andreas Rheinhardt wrote: > There are lots of files that don't need it: The number of object > files that actually need it went down from 2011 to 884 here. > > Keep it for external users in order to not cause breakages. > > Also improve the other headers

Re: [FFmpeg-devel] [RFC] 7.0 blocking issues

2024-03-25 Thread Kieran Kunhya
On Mon, 25 Mar 2024 at 21:10, Michael Niedermayer wrote: > On Mon, Mar 25, 2024 at 09:20:25PM +0100, Lynne wrote: > > Mar 25, 2024, 14:50 by ffm...@haasn.xyz: > > > > > On Mon, 25 Mar 2024 07:20:56 +0100 "Jean-Baptiste Kempf" < > j...@videolan.org> wrote: > > > > > >> Hello, > > >> > > >> On

Re: [FFmpeg-devel] [PATCH 00/21] aarch64: hevc: Add missing hevc_pel NEON functions

2024-03-25 Thread Martin Storsjö
On Mon, 25 Mar 2024, Martin Storsjö wrote: Since some time, we have pretty complete AArch64 NEON coverage for the hevc decoder. However, some of these functions require the I8MM instruction set extension, and many of them (but not all) lack a plain NEON version. This patchset fills in a

Re: [FFmpeg-devel] [PATCH 4/6 v2] avutil/mastering_display_metadata: add a new allocator function that returns a size

2024-03-25 Thread James Almer
On 3/25/2024 6:02 PM, Andreas Rheinhardt wrote: James Almer: On 3/25/2024 5:40 PM, Andreas Rheinhardt wrote: James Almer: av_mastering_display_metadata_alloc() is not useful in scenarios where you need to know the runtime size of AVMasteringDisplayMetadata. Signed-off-by: James Almer ---  

Re: [FFmpeg-devel] [PATCH v3 2/2] lavc/get_buffer: Add a warning on failed allocation from a fixed pool

2024-03-25 Thread Mark Thompson
On 25/03/2024 07:35, Xiang, Haihao wrote: On Di, 2024-03-19 at 22:52 +, Mark Thompson wrote: On 19/03/2024 04:16, Xiang, Haihao wrote: On Ma, 2024-03-18 at 21:33 +, Mark Thompson wrote: On 18/03/2024 05:53, Xiang, Haihao wrote: On So, 2024-03-17 at 20:51 +, Mark Thompson wrote:

Re: [FFmpeg-devel] [RFC] 7.0 blocking issues

2024-03-25 Thread Michael Niedermayer
On Mon, Mar 25, 2024 at 09:20:25PM +0100, Lynne wrote: > Mar 25, 2024, 14:50 by ffm...@haasn.xyz: > > > On Mon, 25 Mar 2024 07:20:56 +0100 "Jean-Baptiste Kempf" > > wrote: > > > >> Hello, > >> > >> On Mon, 25 Mar 2024, at 01:03, Michael Niedermayer wrote: > >> > Should i wait till all issues

Re: [FFmpeg-devel] Fixes #10509

2024-03-25 Thread Poorva
> > > On Mon, Mar 25, 2024 at 2:04 AM Marton Balint wrote: > > > On Sun, 24 Mar 2024, Poorva wrote: > > > From 0874a55ad33bb4df2789cbafc5247c0ae3d97e6a Mon Sep 17 00:00:00 2001 > > From: PoorvaGaikar > > Date: Sat, 9 Mar 2024 00:27:25 +0530 > > Subject: [PATCH v2] avfilter/f_select.c: add

Re: [FFmpeg-devel] [PATCH 4/6 v2] avutil/mastering_display_metadata: add a new allocator function that returns a size

2024-03-25 Thread Andreas Rheinhardt
James Almer: > On 3/25/2024 5:40 PM, Andreas Rheinhardt wrote: >> James Almer: >>> av_mastering_display_metadata_alloc() is not useful in scenarios >>> where you need to >>> know the runtime size of AVMasteringDisplayMetadata. >>> >>> Signed-off-by: James Almer >>> --- >>>  

Re: [FFmpeg-devel] [PATCH 4/6 v2] avutil/mastering_display_metadata: add a new allocator function that returns a size

2024-03-25 Thread James Almer
On 3/25/2024 5:40 PM, Andreas Rheinhardt wrote: James Almer: av_mastering_display_metadata_alloc() is not useful in scenarios where you need to know the runtime size of AVMasteringDisplayMetadata. Signed-off-by: James Almer --- libavutil/mastering_display_metadata.c | 13 +

Re: [FFmpeg-devel] [PATCH 4/6 v2] avutil/mastering_display_metadata: add a new allocator function that returns a size

2024-03-25 Thread Andreas Rheinhardt
James Almer: > av_mastering_display_metadata_alloc() is not useful in scenarios where you > need to > know the runtime size of AVMasteringDisplayMetadata. > > Signed-off-by: James Almer > --- > libavutil/mastering_display_metadata.c | 13 + > libavutil/mastering_display_metadata.h

Re: [FFmpeg-devel] [PATCH] avcodec/x86/h264_idct: Fix incorrect xmm spilling on win64

2024-03-25 Thread Henrik Gramner via ffmpeg-devel
On Sun, Mar 24, 2024 at 8:21 PM Henrik Gramner wrote: > > Broken in afa471d0efed1df5dca6eeeb2fcdd211ae4cad4e. It just happened > to work before due to x86inc.asm previously performing XMM spills in > INIT_MMX mode which was more of a bug than an intentional feature. Will apply.

Re: [FFmpeg-devel] [PATCH 1/2] fftools/ffmpeg_filter: remove unused struct from InputFilterPriv

2024-03-25 Thread James Almer
On 3/24/2024 10:36 AM, James Almer wrote: It's already in InputFilterOptions. Signed-off-by: James Almer --- fftools/ffmpeg_filter.c | 16 1 file changed, 16 deletions(-) diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index 3d88482d07..171e47be9e 100644 ---

Re: [FFmpeg-devel] [RFC] 7.0 blocking issues

2024-03-25 Thread Lynne
Mar 25, 2024, 14:50 by ffm...@haasn.xyz: > On Mon, 25 Mar 2024 07:20:56 +0100 "Jean-Baptiste Kempf" > wrote: > >> Hello, >> >> On Mon, 25 Mar 2024, at 01:03, Michael Niedermayer wrote: >> > Should i wait till all issues marked as blocking 7.0 on trac are fixed >> > before branching ? >> >> I

[FFmpeg-devel] [PATCH] Added alpha layer support for smartblur - reformatted patch

2024-03-25 Thread Andrea Mastroberti via ffmpeg-devel
--- Begin Message --- Signed-off-by: Andrea Mastroberti <10736...@polimi.it> --- doc/filters.texi | 20 - libavfilter/version.h | 2 +- libavfilter/vf_smartblur.c | 44 ++ 3 files changed, 55 insertions(+), 11 deletions(-) diff

[FFmpeg-devel] [PATCH 6/6 v2] avcodec/hevcdec: export global side data in AVCodecContext

2024-03-25 Thread James Almer
Signed-off-by: James Almer --- libavcodec/avcodec.h | 2 +- libavcodec/h2645_sei.c | 217 ++--- libavcodec/h2645_sei.h | 2 + libavcodec/hevcdec.c | 4 + libavcodec/pthread_frame.c | 10 ++ 5 files changed, 146 insertions(+), 89

[FFmpeg-devel] [PATCH 5/6 v2] avcodec/decode: make the AVFrameSideData helper wrappers not depend on frames

2024-03-25 Thread James Almer
They will be useful to fill arrays stored in other structs. Signed-off-by: James Almer --- libavcodec/av1dec.c | 7 +-- libavcodec/cri.c| 3 +- libavcodec/decode.c | 97 ++--- libavcodec/decode.h | 28 ++-- libavcodec/dpx.c

[FFmpeg-devel] [PATCH 4/6 v2] avutil/mastering_display_metadata: add a new allocator function that returns a size

2024-03-25 Thread James Almer
av_mastering_display_metadata_alloc() is not useful in scenarios where you need to know the runtime size of AVMasteringDisplayMetadata. Signed-off-by: James Almer --- libavutil/mastering_display_metadata.c | 13 + libavutil/mastering_display_metadata.h | 9 + 2 files

[FFmpeg-devel] [PATCH 3/6 v2] avutil/frame: add helper to remove side data of a given type from an array

2024-03-25 Thread James Almer
Signed-off-by: James Almer --- libavutil/frame.c | 6 ++ libavutil/frame.h | 5 + 2 files changed, 11 insertions(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index 33c077998a..10c7d3ebf0 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -882,6 +882,12 @@ const

[FFmpeg-devel] [PATCH 2/6 v2] avutil/frame: add helper for adding side data w/ AVBufferRef to array

2024-03-25 Thread James Almer
Signed-off-by: James Almer --- libavutil/frame.c | 43 +++ libavutil/frame.h | 35 +++ 2 files changed, 78 insertions(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index a780e62fd0..33c077998a 100644 ---

[FFmpeg-devel] [PATCH 1/6 v2] avutil/frame: add a flag to not create duplicate entries in a side data array

2024-03-25 Thread James Almer
Signed-off-by: James Almer --- libavutil/frame.c | 14 ++ libavutil/frame.h | 28 2 files changed, 34 insertions(+), 8 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index d7a32cdc92..a780e62fd0 100644 --- a/libavutil/frame.c +++

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/jpeg2000htdec: Check M_b / magp before using it in a shift

2024-03-25 Thread Michael Niedermayer
On Mon, Mar 25, 2024 at 08:13:13PM +0100, Michael Niedermayer wrote: > On Thu, Mar 21, 2024 at 04:07:14PM +0100, Tomas Härdin wrote: > > ons 2024-03-20 klockan 21:35 +0100 skrev Tomas Härdin: > > > ons 2024-03-20 klockan 14:12 +0100 skrev Michael Niedermayer: > > > > On Wed, Mar 20, 2024 at

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/vmixdec: Check shift before use

2024-03-25 Thread Michael Niedermayer
On Wed, Mar 20, 2024 at 03:59:21AM +0100, Michael Niedermayer wrote: > Fixes: shift exponent 32 is too large for 32-bit type 'unsigned int' > Fixes: > 65909/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VMIX_fuzzer-519459745831321 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/jpeg2000htdec: Check M_b / magp before using it in a shift

2024-03-25 Thread Michael Niedermayer
On Thu, Mar 21, 2024 at 04:07:14PM +0100, Tomas Härdin wrote: > ons 2024-03-20 klockan 21:35 +0100 skrev Tomas Härdin: > > ons 2024-03-20 klockan 14:12 +0100 skrev Michael Niedermayer: > > > On Wed, Mar 20, 2024 at 12:20:11PM +0100, Tomas Härdin wrote: > > > > ons 2024-03-20 klockan 03:59 +0100

Re: [FFmpeg-devel] [PATCH v2 1/2] avutil/timestamp: introduce av_ts_make_time_string2 for better precision

2024-03-25 Thread Marton Balint
On Sat, 23 Mar 2024, Marton Balint wrote: av_ts_make_time_string() used "%.6g" format, but this format was losing precision even when the timestamp to be printed was not that large. For example for 3 hours (10800) seconds, only 1 decimal digit was printed, which made this format inaccurate

Re: [FFmpeg-devel] [PATCH 14/14] avutil/avstring: Avoid av_strdup(NULL)

2024-03-25 Thread Andreas Rheinhardt
James Almer: > On 3/25/2024 1:55 PM, Andreas Rheinhardt wrote: >> Vittorio Giovara: >>> On Mon, Mar 25, 2024 at 12:38 PM Andreas Rheinhardt < >>> andreas.rheinha...@outlook.com> wrote: >>> Signed-off-by: Andreas Rheinhardt ---   libavutil/avstring.c | 2 +-   1 file changed, 1

Re: [FFmpeg-devel] [PATCH 14/14] avutil/avstring: Avoid av_strdup(NULL)

2024-03-25 Thread James Almer
On 3/25/2024 1:55 PM, Andreas Rheinhardt wrote: Vittorio Giovara: On Mon, Mar 25, 2024 at 12:38 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: Signed-off-by: Andreas Rheinhardt --- libavutil/avstring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [FFmpeg-devel] [PATCH 14/14] avutil/avstring: Avoid av_strdup(NULL)

2024-03-25 Thread Vittorio Giovara
On Mon, Mar 25, 2024 at 12:55 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Vittorio Giovara: > > On Mon, Mar 25, 2024 at 12:38 PM Andreas Rheinhardt < > > andreas.rheinha...@outlook.com> wrote: > > > >> Signed-off-by: Andreas Rheinhardt > >> --- > >> libavutil/avstring.c | 2

[FFmpeg-devel] [PATCH] avutil/frame: add a flag to not create duplicate entries in a side data array

2024-03-25 Thread James Almer
Signed-off-by: James Almer --- libavutil/frame.c | 14 ++ libavutil/frame.h | 28 2 files changed, 34 insertions(+), 8 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index d7a32cdc92..a780e62fd0 100644 --- a/libavutil/frame.c +++

Re: [FFmpeg-devel] [PATCH] avfilter/vf_stack: round down internal item heights

2024-03-25 Thread Timo Rothenpieler
On 23/03/2024 16:30, Timo Rothenpieler wrote: Following situation: Someone wants to stack two yuv420p frames of the size 3x3 pixel each. Now the various AV_CEIL_RSHIFT() calculations calculate a height of 2 pixel for each items subsampled planes. However, for example in case of a vstack, the

[FFmpeg-devel] [PATCH] avfilter/vf_colorspace: use colorspace negotiation API

2024-03-25 Thread Nicolas Gaullier
Fixes a regression due to the fact that the colorspace filter does not use the new API introduced by 8c7934f73ab6c568acaa. The scale filter uses it since 45e09a30419cc2a7251e, and the setparams filter since 3bf80df3ccd32aed23f0. Example: ffmpeg -f lavfi -i testsrc -vf

Re: [FFmpeg-devel] [PATCH 1/3] avformat/wady: Check >0 samplerate and channels 1 || 2.

2024-03-25 Thread Michael Niedermayer
On Wed, Mar 20, 2024 at 03:19:24AM +0100, Michael Niedermayer wrote: > The WADY decoder only supports mono and stereo > > This fixes a probetest failure > > Signed-off-by: Michael Niedermayer > --- > libavformat/wady.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) will apply patch

Re: [FFmpeg-devel] [PATCH 14/14] avutil/avstring: Avoid av_strdup(NULL)

2024-03-25 Thread Andreas Rheinhardt
Vittorio Giovara: > On Mon, Mar 25, 2024 at 12:38 PM Andreas Rheinhardt < > andreas.rheinha...@outlook.com> wrote: > >> Signed-off-by: Andreas Rheinhardt >> --- >> libavutil/avstring.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libavutil/avstring.c

Re: [FFmpeg-devel] [PATCH 14/14] avutil/avstring: Avoid av_strdup(NULL)

2024-03-25 Thread Vittorio Giovara
On Mon, Mar 25, 2024 at 12:38 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavutil/avstring.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavutil/avstring.c b/libavutil/avstring.c > index

Re: [FFmpeg-devel] [PATCH] Added alpha layer support for smartblur

2024-03-25 Thread Andrea Mastroberti via ffmpeg-devel
On 3/25/24 9:49 AM, Andrea Mastroberti wrote: Signed-off-by: Andrea Mastroberti <10736...@polimi.it> ---  doc/filters.texi   | 20 -  libavfilter/version.h  |  2 +-  libavfilter/vf_smartblur.c | 44 ++  3 files changed, 55

Re: [FFmpeg-devel] [PATCH] avformat/mov_chan: Use anonymous union

2024-03-25 Thread Henrik Gramner via ffmpeg-devel
On Mon, Mar 25, 2024 at 4:01 PM Andreas Rheinhardt wrote: > > Right, it is an anonymous enum, not union. Amended locally. > > - Andreas Can confirm this eliminates the warnings, lgtm. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH 14/14] avutil/avstring: Avoid av_strdup(NULL)

2024-03-25 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavutil/avstring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/avstring.c b/libavutil/avstring.c index 2071dd36a5..8702fe0455 100644 --- a/libavutil/avstring.c +++ b/libavutil/avstring.c @@ -299,7 +299,7 @@ char

[FFmpeg-devel] [PATCH 13/13] fftools/ffmpeg_mux_init: Fix double-free on error

2024-03-25 Thread Andreas Rheinhardt
MATCH_PER_STREAM_OPT iterates over all options of a given OptionDef and tests whether they apply to the current stream; if so, they are set to ost->apad, otherwise, the code errors out. If no error happens, ost->apad is av_strdup'ed in order to take ownership of this pointer. But this means that

[FFmpeg-devel] [PATCH 12/12] avutil/opt: Don't cast when the result might be misaligned

2024-03-25 Thread Andreas Rheinhardt
A pointer conversion is UB if the resulting pointer is not correctly aligned for the resultant type, even if no load/store is ever performed through that pointer (C11 6.3.2.3 (7)). This may happen in opt_copy_elem(), because the pointers are converted even when they belong to a type that does not

Re: [FFmpeg-devel] [PATCH] avfilter: fix YUV colorspace negotiation for YUVJ

2024-03-25 Thread Niklas Haas
On Mon, 25 Mar 2024 14:40:44 +0100 Niklas Haas wrote: > From: Niklas Haas > > Ironically, despite being introduced to make YUVJ unnecessary, the new > YUV negotiation logic failed to actually negotiate YUVJ formats > themselves correctly, leading to errors when passing YUVJ frames into > a

[FFmpeg-devel] [PATCH] avfilter: properly reduce YUV colorspace format lists

2024-03-25 Thread Niklas Haas
From: Niklas Haas Doing this with REDUCE_FORMATS() instead of swap_color_*() is not only shorter, but more importantly comes with the benefit of being done inside a loop, allowing us to correctly propagate complex graphs involving multiple conversion filters (e.g. -vf scale,zscale). The latter

Re: [FFmpeg-devel] [PATCH v2] avfilter: propagate colorspace and color_range from buffer filter and between AVFilterLink.

2024-03-25 Thread Niklas Haas
On Mon, 25 Mar 2024 16:02:23 +0100 Niklas Haas wrote: > On Mon, 25 Mar 2024 15:36:26 +0100 Damiano Galassi wrote: > > On Mon, Mar 25, 2024 at 2:40 PM Niklas Haas wrote: > > > > > > ffmpeg -i in.mp4 -vf > > > > "scale='width=1920:height=1080',zscale='width=1920:height=1080'" out.mp4 > > > >

[FFmpeg-devel] [PATCH 21/21] aarch64: hevc: Produce plain neon versions of qpel_bi_hv

2024-03-25 Thread Martin Storsjö
As the plain neon qpel_h functions process two rows at a time, we need to allocate storage for h+8 rows instead of h+7. By allocating storage for h+8 rows, incrementing the stack pointer won't end up at the right spot in the end. Store the intended final stack pointer value in a register x14

[FFmpeg-devel] [PATCH 20/21] aarch64: hevc: Produce plain neon versions of qpel_uni_w_hv

2024-03-25 Thread Martin Storsjö
As the plain neon qpel_h functions process two rows at a time, we need to allocate storage for h+8 rows instead of h+7. AWS Graviton 3: put_hevc_qpel_uni_w_hv4_8_c: 422.2 put_hevc_qpel_uni_w_hv4_8_neon: 140.7 put_hevc_qpel_uni_w_hv4_8_i8mm: 100.7 put_hevc_qpel_uni_w_hv8_8_c: 1208.0

[FFmpeg-devel] [PATCH 19/21] aarch64: hevc: Produce plain neon versions of qpel_uni_hv

2024-03-25 Thread Martin Storsjö
As the plain neon qpel_h functions process two rows at a time, we need to allocate storage for h+8 rows instead of h+7. By allocating storage for h+8 rows, incrementing the stack pointer won't end up at the right spot in the end. Store the intended final stack pointer value in a register x14

[FFmpeg-devel] [PATCH 18/21] aarch64: hevc: Produce plain neon versions of qpel_hv

2024-03-25 Thread Martin Storsjö
As the plain neon qpel_h functions process two rows at a time, we need to allocate storage for h+8 rows instead of h+7. By allocating storage for h+8 rows, incrementing the stack pointer won't end up at the right spot in the end. Store the intended final stack pointer value in a register x14

[FFmpeg-devel] [PATCH 16/21] aarch64: hevc: Deduplicate the hevc_put_hevc_qpel_uni_w_hv*_8_end_neon functions

2024-03-25 Thread Martin Storsjö
The hv32 and hv64 functions were identical - both loop and process 16 pixels at a time. The hv16 function was near identical, except for the outer loop (and using sp instead of a separate register). Given the size of these functions, the extra cost of the outer loop is negligible, so use the

[FFmpeg-devel] [PATCH 17/21] aarch64: hevc: Reorder qpel_hv functions to prepare for templating

2024-03-25 Thread Martin Storsjö
--- libavcodec/aarch64/hevcdsp_qpel_neon.S | 695 + 1 file changed, 355 insertions(+), 340 deletions(-) diff --git a/libavcodec/aarch64/hevcdsp_qpel_neon.S b/libavcodec/aarch64/hevcdsp_qpel_neon.S index 06832603d9..ad568e415b 100644 ---

[FFmpeg-devel] [PATCH 15/21] aarch64: hevc: Split the qpel_*_hv functions into two parts

2024-03-25 Thread Martin Storsjö
--- libavcodec/aarch64/hevcdsp_qpel_neon.S | 94 +++--- 1 file changed, 86 insertions(+), 8 deletions(-) diff --git a/libavcodec/aarch64/hevcdsp_qpel_neon.S b/libavcodec/aarch64/hevcdsp_qpel_neon.S index fba063186c..c04e8dbea8 100644 ---

[FFmpeg-devel] [PATCH 13/21] aarch64: hevc: Produce epel_bi_hv functions for both neon and i8mm

2024-03-25 Thread Martin Storsjö
In addition to just templating, this contains one change to ff_hevc_put_hevc_epel_bi_hv32_8, by setting the w6 register which ff_hevc_put_hevc_epel_h32_8_neon requires. AWS Graviton 3: put_hevc_epel_bi_hv4_8_c: 176.5 put_hevc_epel_bi_hv4_8_neon: 62.0 put_hevc_epel_bi_hv4_8_i8mm: 58.0

[FFmpeg-devel] [PATCH 14/21] aarch64: hevc: Implement a neon version of hevc_qpel_uni_w_h*_8

2024-03-25 Thread Martin Storsjö
AWS Graviton 3: put_hevc_qpel_uni_w_h4_8_c: 159.0 put_hevc_qpel_uni_w_h4_8_neon: 64.2 put_hevc_qpel_uni_w_h4_8_i8mm: 40.0 put_hevc_qpel_uni_w_h6_8_c: 344.7 put_hevc_qpel_uni_w_h6_8_neon: 114.5 put_hevc_qpel_uni_w_h6_8_i8mm: 82.0 put_hevc_qpel_uni_w_h8_8_c: 596.2 put_hevc_qpel_uni_w_h8_8_neon:

  1   2   >