Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

On Wed, May 17, 2017 at 4:06 PM, Muhammad Faiz wrote: > On Wed, May 17, 2017 at 3:20 PM, Nicolas George wrote: >> L'octidi 28 floréal, an CCXXV, Muhammad Faiz a écrit : >>> Of course, pushing the partial fix won't conflict with the complete >>> fix. >> >> Of

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

On Wed, May 17, 2017 at 3:20 PM, Nicolas George wrote: > L'octidi 28 floréal, an CCXXV, Muhammad Faiz a écrit : >> Of course, pushing the partial fix won't conflict with the complete >> fix. > > Of course it will, it touches the same area of code. No, your code doesn't check the

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

L'octidi 28 floréal, an CCXXV, Muhammad Faiz a écrit : > Of course, pushing the partial fix won't conflict with the complete > fix. Of course it will, it touches the same area of code. > Ha ha ha. Of course, that's why I prefer the partial fix. Because it > is simple. It is simple because it is

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

On Wed, May 17, 2017 at 2:25 PM, Nicolas George wrote: > L'octidi 28 floréal, an CCXXV, Muhammad Faiz a écrit : >> Actually, one can argue that because we've already missed 3.3.1, we >> should wait for 3.3.2. But I can argue that master branch also has >> users, and keeping the

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

L'octidi 28 floréal, an CCXXV, Muhammad Faiz a écrit : > Actually, one can argue that because we've already missed 3.3.1, we > should wait for 3.3.2. But I can argue that master branch also has > users, and keeping the crash unresolved at master branch is not good > idea at all. The complete fix

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

On Wed, May 17, 2017 at 10:47 AM, James Almer wrote: > On 5/16/2017 11:28 PM, Ronald S. Bultje wrote: >> Hi, >> >> On Tue, May 16, 2017 at 7:43 PM, Muhammad Faiz wrote: >> >>> On Wed, May 17, 2017 at 6:33 AM, Ronald S. Bultje >>> wrote:

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

On 5/16/2017 11:28 PM, Ronald S. Bultje wrote: > Hi, > > On Tue, May 16, 2017 at 7:43 PM, Muhammad Faiz wrote: > >> On Wed, May 17, 2017 at 6:33 AM, Ronald S. Bultje >> wrote: >>> Hi, >>> >>> On Tue, May 16, 2017 at 7:23 PM, Muhammad Faiz

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

Hi, On Tue, May 16, 2017 at 7:43 PM, Muhammad Faiz wrote: > On Wed, May 17, 2017 at 6:33 AM, Ronald S. Bultje > wrote: > > Hi, > > > > On Tue, May 16, 2017 at 7:23 PM, Muhammad Faiz wrote: > > > >> On Sun, May 7, 2017 at 8:18 PM, Nicolas

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

On Wed, May 17, 2017 at 6:33 AM, Ronald S. Bultje wrote: > Hi, > > On Tue, May 16, 2017 at 7:23 PM, Muhammad Faiz wrote: > >> On Sun, May 7, 2017 at 8:18 PM, Nicolas George wrote: >> > L'octidi 18 floréal, an CCXXV, James Almer a écrit : >>

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

Hi, On Tue, May 16, 2017 at 7:23 PM, Muhammad Faiz wrote: > On Sun, May 7, 2017 at 8:18 PM, Nicolas George wrote: > > L'octidi 18 floréal, an CCXXV, James Almer a écrit : > >> Will that complete fix be ready and be backport-enabled (AKA, no new > >> API) in

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

On Sun, May 7, 2017 at 8:18 PM, Nicolas George wrote: > L'octidi 18 floréal, an CCXXV, James Almer a écrit : >> Will that complete fix be ready and be backport-enabled (AKA, no new >> API) in the coming days? > > It can. Right now, I am waiting for a comment from Hendrik, who

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

On 5/7/2017 10:18 AM, Nicolas George wrote: > L'octidi 18 floréal, an CCXXV, James Almer a écrit : >> Will that complete fix be ready and be backport-enabled (AKA, no new >> API) in the coming days? > > It can. Right now, I am waiting for a comment from Hendrik, who seemed > to have objections on

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

L'octidi 18 floréal, an CCXXV, James Almer a écrit : > Will that complete fix be ready and be backport-enabled (AKA, no new > API) in the coming days? It can. Right now, I am waiting for a comment from Hendrik, who seemed to have objections on the principle but that I hope to have convinced.

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

On 5/7/2017 5:33 AM, Nicolas George wrote: > L'octidi 18 floréal, an CCXXV, Muhammad Faiz a écrit : >> Is it ok to push this? > > Of course not. How would it be ok to push a partial fix when a complete > one is being discussed? > > Regards, Will that complete fix be ready and be

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

L'octidi 18 floréal, an CCXXV, Muhammad Faiz a écrit : > Is it ok to push this? Of course not. How would it be ok to push a partial fix when a complete one is being discussed? Regards, -- Nicolas George signature.asc Description: Digital signature

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

On Fri, May 5, 2017 at 1:01 PM, Muhammad Faiz wrote: > This should fix Ticket6349. > Since 383057f8e744efeaaa3648a59bc577b25b055835, framequeue may > generate unaligned frame data. > > Signed-off-by: Muhammad Faiz > --- > libavfilter/avfilter.c | 26

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

On Sat, 6 May 2017 15:29:18 -0300 James Almer wrote: > On 5/5/2017 2:23 PM, Nicolas George wrote: > > Le sextidi 16 floréal, an CCXXV, James Almer a écrit : > >> stuff you broke > > > > Please stop spreading wm4's lies. The bug was already

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

On 5/5/2017 2:23 PM, Nicolas George wrote: > Le sextidi 16 floréal, an CCXXV, James Almer a écrit : >> stuff you broke > > Please stop spreading wm4's lies. The bug was already there. > > Regards, > Take a look at https://trac.ffmpeg.org/ticket/6346. That ticket

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

On Sat, May 6, 2017 at 6:35 PM, Nicolas George wrote: > Le septidi 17 floréal, an CCXXV, Muhammad Faiz a écrit : >> - fix framequeue (this patch). > > Once again, this patch is not correct. In particular it is NOT ENOUGH > to fix the crash in all cases. > It is enough to

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

Le septidi 17 floréal, an CCXXV, Muhammad Faiz a écrit : > - fix framequeue (this patch). Once again, this patch is not correct. In particular it is NOT ENOUGH to fix the crash in all cases. Regards, -- Nicolas George ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

On Sat, May 6, 2017 at 9:35 PM, Ronald S. Bultje wrote: > Hi, > > On Fri, May 5, 2017 at 12:17 PM, Nicolas George wrote: > >> Le sextidi 16 floréal, an CCXXV, Hendrik Leppkes a écrit : >> > Blocking crash fixes on silly arguments doesn't help anyone. Send a

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

On Sat, May 6, 2017 at 9:36 PM, Ronald S. Bultje wrote: > Hi Muhammad, > > On Sat, May 6, 2017 at 10:13 AM, Muhammad Faiz wrote: > >> On Fri, May 5, 2017 at 11:22 PM, Nicolas George wrote: >> > Le sextidi 16 floréal, an CCXXV, Muhammad Faiz

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

Hi, On Fri, May 5, 2017 at 12:17 PM, Nicolas George wrote: > Le sextidi 16 floréal, an CCXXV, Hendrik Leppkes a écrit : > > Blocking crash fixes on silly arguments doesn't help anyone. Send a > > My argument is not silly: the code to align the frame will be needed, > but NOT

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

Hi Muhammad, On Sat, May 6, 2017 at 10:13 AM, Muhammad Faiz wrote: > On Fri, May 5, 2017 at 11:22 PM, Nicolas George wrote: > > Le sextidi 16 floréal, an CCXXV, Muhammad Faiz a écrit : > >> But if

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

On Fri, May 5, 2017 at 11:22 PM, Nicolas George wrote: > Le sextidi 16 floréal, an CCXXV, Muhammad Faiz a écrit : >> But if documentation >> says that data should be aligned to 4-bytes but I align it to >> 32-bytes, then there are

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

On Sat, 6 May 2017 11:20:13 +0200 Nicolas George wrote: > Le sextidi 16 floréal, an CCXXV, Kieran Kunhya a écrit : > > I sent a patch about this nearly three years ago, it wasn't applied for > > whatever reason. > > This is pretty common if you don't use av_malloc. > > Thanks

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

Le sextidi 16 floréal, an CCXXV, Kieran Kunhya a écrit : > I sent a patch about this nearly three years ago, it wasn't applied for > whatever reason. > This is pretty common if you don't use av_malloc. Thanks for pointing it. As for the rest, I can observe that my hope that some people will

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

> > Well, this instance is exactly a case like that. If the alignment > requirements are not documented, then an application can do things in a > way similar to take_samples() right now, and result in a crash. And > there is no blaming the application, it followed the documentation. > > The bug is

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

Le sextidi 16 floréal, an CCXXV, Hendrik Leppkes a écrit : > Blocking crash fixes on silly arguments doesn't help anyone. Send a > doc update yourself or stop blocking valid crash fixes. > Every ffmpeg developer knows that we have alignment requirements, > trying to badger someone into writing

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

On 5/5/2017 1:22 PM, Nicolas George wrote: > Le sextidi 16 floréal, an CCXXV, Muhammad Faiz a écrit : >> But if documentation >> says that data should be aligned to 4-bytes but I align it to >> 32-bytes, then there are no violations at all. So

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

Le sextidi 16 floréal, an CCXXV, Muhammad Faiz a écrit : > But if documentation > says that data should be aligned to 4-bytes but I align it to > 32-bytes, then there are no violations at all. So what's wrong with > this patch? Useless code

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

Le sextidi 16 floréal, an CCXXV, Hendrik Leppkes a écrit : > Blocking crash fixes on silly arguments doesn't help anyone. Send a My argument is not silly: the code to align the frame will be needed, but NOT HERE. > Every ffmpeg developer knows that we have alignment requirements, Well, I do

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

On Fri, May 5, 2017 at 3:38 PM, Nicolas George wrote: > Le sextidi 16 floréal, an CCXXV, Paul B Mahol a écrit : >> There is crash reproducible with filters and not just libmp3lame. > > Then these filters are bogus since they are making invalid assumptions > about their inputs. Or

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

On Fri, May 5, 2017 at 5:00 PM, Nicolas George wrote: > Le sextidi 16 floréal, an CCXXV, Muhammad Faiz a écrit : >> This should fix Ticket6349. >> Since 383057f8e744efeaaa3648a59bc577b25b055835, framequeue may >> generate unaligned frame data. >> >> Signed-off-by: Muhammad Faiz

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

Le sextidi 16 floréal, an CCXXV, Paul B Mahol a écrit : > There is crash reproducible with filters and not just libmp3lame. Then these filters are bogus since they are making invalid assumptions about their inputs. Or quote the docs saying otherwise.

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

On 5/5/17, Nicolas George wrote: > Le sextidi 16 floreal, an CCXXV, Paul B Mahol a ecrit : >> Come on, I will report this to the committe. > > If you have something useful to say, please do so. There is crash reproducible with filters and not just libmp3lame.

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

Le sextidi 16 floréal, an CCXXV, Paul B Mahol a écrit : > Come on, I will report this to the committe. If you have something useful to say, please do so. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

On 5/5/17, Nicolas George wrote: > Le sextidi 16 floreal, an CCXXV, Muhammad Faiz a ecrit : >> This should fix Ticket6349. >> Since 383057f8e744efeaaa3648a59bc577b25b055835, framequeue may >> generate unaligned frame data. >> >> Signed-off-by: Muhammad Faiz >>

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

On Fri, 5 May 2017 12:00:02 +0200 Nicolas George wrote: > Le sextidi 16 floréal, an CCXXV, Muhammad Faiz a écrit : > > This should fix Ticket6349. > > Since 383057f8e744efeaaa3648a59bc577b25b055835, framequeue may > > generate unaligned frame data. > > > > Signed-off-by:

Re: [FFmpeg-devel] [PATCH] avfilter: align data frame when needed

Le sextidi 16 floréal, an CCXXV, Muhammad Faiz a écrit : > This should fix Ticket6349. > Since 383057f8e744efeaaa3648a59bc577b25b055835, framequeue may > generate unaligned frame data. > > Signed-off-by: Muhammad Faiz > --- > libavfilter/avfilter.c | 26

[FFmpeg-devel] [PATCH] avfilter: align data frame when needed

This should fix Ticket6349. Since 383057f8e744efeaaa3648a59bc577b25b055835, framequeue may generate unaligned frame data. Signed-off-by: Muhammad Faiz --- libavfilter/avfilter.c | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git