Re: [FFmpeg-devel] [PATCH 1/2] VP4 video decoder

2019-05-14 Thread Reimar Döffinger
On Tue, May 14, 2019 at 10:37:03PM +1000, Peter Ross wrote: > On Sun, May 12, 2019 at 01:24:56PM +0200, Reimar Döffinger wrote: > > On 12.05.2019, at 08:12, Peter Ross wrote: > > > +static int read_mb_value(GetBitContext *gb) > > > +{ > > > +int v = 1; > > > +int size; > > > + > > > +

Re: [FFmpeg-devel] [PATCH 1/2] VP4 video decoder

2019-05-14 Thread James Almer
On 5/14/2019 9:37 AM, Peter Ross wrote: > On Sun, May 12, 2019 at 01:24:56PM +0200, Reimar Döffinger wrote: >> On 12.05.2019, at 08:12, Peter Ross wrote: >>> +static int read_mb_value(GetBitContext *gb) >>> +{ >>> +int v = 1; >>> +int size; >>> + >>> +do { >>> +size = 0; >>> +

Re: [FFmpeg-devel] [PATCH 1/2] VP4 video decoder

2019-05-14 Thread Peter Ross
On Sun, May 12, 2019 at 01:24:56PM +0200, Reimar Döffinger wrote: > On 12.05.2019, at 08:12, Peter Ross wrote: > > +static int read_mb_value(GetBitContext *gb) > > +{ > > +int v = 1; > > +int size; > > + > > +do { > > +size = 0; > > +if (!get_bits1(gb)) > > +

Re: [FFmpeg-devel] [PATCH 1/2] VP4 video decoder

2019-05-13 Thread Peter Ross
On Sun, May 12, 2019 at 10:20:19AM -0300, James Almer wrote: > On 5/12/2019 3:12 AM, Peter Ross wrote: > > --- > > i have incorporated all suggestions from the first patch posted jan 2019. > > > > if there's nothing further to change, i will apply it a good week or so. > > > > cheers, > > > >

Re: [FFmpeg-devel] [PATCH 1/2] VP4 video decoder

2019-05-13 Thread Peter Ross
On Sun, May 12, 2019 at 12:49:03PM +0200, Carl Eugen Hoyos wrote: > Am So., 12. Mai 2019 um 08:12 Uhr schrieb Peter Ross : > > > i have incorporated all suggestions from the first patch posted jan 2019. > > > > if there's nothing further to change, i will apply it a good week or so. > > > >

Re: [FFmpeg-devel] [PATCH 1/2] VP4 video decoder

2019-05-13 Thread Peter Ross
On Sun, May 12, 2019 at 09:41:40AM +0200, Paul B Mahol wrote: > On 5/12/19, Peter Ross wrote: > > --- > > i have incorporated all suggestions from the first patch posted jan 2019. > > > > if there's nothing further to change, i will apply it a good week or so. > > > > cheers, > > > > > >

Re: [FFmpeg-devel] [PATCH 1/2] VP4 video decoder

2019-05-12 Thread James Almer
On 5/12/2019 3:12 AM, Peter Ross wrote: > --- > i have incorporated all suggestions from the first patch posted jan 2019. > > if there's nothing further to change, i will apply it a good week or so. > > cheers, > > > Changelog |1 + > doc/general.texi|2 + >

Re: [FFmpeg-devel] [PATCH 1/2] VP4 video decoder

2019-05-12 Thread Reimar Döffinger
On 12.05.2019, at 08:12, Peter Ross wrote: > +static int read_mb_value(GetBitContext *gb) > +{ > +int v = 1; > +int size; > + > +do { > +size = 0; > +if (!get_bits1(gb)) > +break; > +v++; > +do { > +if (!get_bits1(gb)) > +

Re: [FFmpeg-devel] [PATCH 1/2] VP4 video decoder

2019-05-12 Thread Paul B Mahol
On 5/12/19, Carl Eugen Hoyos wrote: > Am So., 12. Mai 2019 um 09:41 Uhr schrieb Paul B Mahol : > >> Also you need real review. > > He needs to request a review which I believe he did. But full real review is still missing. ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 1/2] VP4 video decoder

2019-05-12 Thread Carl Eugen Hoyos
Am So., 12. Mai 2019 um 08:12 Uhr schrieb Peter Ross : > i have incorporated all suggestions from the first patch posted jan 2019. > > if there's nothing further to change, i will apply it a good week or so. > > cheers, > > > Changelog |1 + > doc/general.texi|2 + >

Re: [FFmpeg-devel] [PATCH 1/2] VP4 video decoder

2019-05-12 Thread Carl Eugen Hoyos
Am So., 12. Mai 2019 um 09:41 Uhr schrieb Paul B Mahol : > Also you need real review. He needs to request a review which I believe he did. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH 1/2] VP4 video decoder

2019-05-12 Thread Peter Ross
--- i have incorporated all suggestions from the first patch posted jan 2019. if there's nothing further to change, i will apply it a good week or so. cheers, Changelog |1 + doc/general.texi|2 + libavcodec/allcodecs.c |1 + libavcodec/avcodec.h|1 +