Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-10 Thread wm4
On Fri, 10 Apr 2015 22:45:47 +0200 Gilles Chanteperdrix wrote: > On Thu, Apr 09, 2015 at 10:59:24PM +0200, Lukasz Marek wrote: > > On 09.04.2015 13:50, Kieran Kunhya wrote: > > >On 9 April 2015 at 12:17, Rodger Combs wrote: > > >>Agreed, this belongs in a higher layer. I think it'd be reasonable

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-10 Thread Gilles Chanteperdrix
On Thu, Apr 09, 2015 at 10:59:24PM +0200, Lukasz Marek wrote: > On 09.04.2015 13:50, Kieran Kunhya wrote: > >On 9 April 2015 at 12:17, Rodger Combs wrote: > >>Agreed, this belongs in a higher layer. I think it'd be reasonable for > >>FFmpeg to have a higher-layer library handling things like play

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-09 Thread compn
On Thu, 09 Apr 2015 22:59:24 +0200 Lukasz Marek wrote: > Sometimes I have a feeling that ffmpeg is an open source project to > feed wm4's project. haha. yes, ffmpeg does not need youtube support because mpv already has it. classic. > I don't want to be drama queen here, but the way author of th

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-09 Thread James Almer
On 09/04/15 5:59 PM, Lukasz Marek wrote: > On 09.04.2015 13:50, Kieran Kunhya wrote: >> On 9 April 2015 at 12:17, Rodger Combs wrote: >>> Agreed, this belongs in a higher layer. I think it'd be reasonable for >>> FFmpeg to have a higher-layer library handling things like playlists and >>> this,

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-09 Thread Lukasz Marek
On 09.04.2015 13:50, Kieran Kunhya wrote: On 9 April 2015 at 12:17, Rodger Combs wrote: Agreed, this belongs in a higher layer. I think it'd be reasonable for FFmpeg to have a higher-layer library handling things like playlists and this, but that's another conversation. +1 So instead of c

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-09 Thread Nicolas George
Le decadi 20 germinal, an CCXXIII, Gilles Chanteperdrix a écrit : > And -J is to much: it gives you all the available videos and forces You can ignore extra information that you think you do do not need. How do you invent required information that you do not have? > you to reimplement youtube-dl

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-09 Thread Gilles Chanteperdrix
On Thu, Apr 09, 2015 at 03:37:30PM +0200, Nicolas George wrote: > Le decadi 20 germinal, an CCXXIII, Gilles Chanteperdrix a écrit : > > Well, in that case, > > ffmpeg -i `youtube-dl -f bestvideo -g $url` > > That could work too, but you still fail to acknowledge that -g is frequently > not enough

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-09 Thread Gilles Chanteperdrix
On Thu, Apr 09, 2015 at 01:08:21PM +0200, wm4 wrote: > On Thu, 9 Apr 2015 00:02:50 +0200 > Lukasz Marek wrote: > > > W dniu środa, 8 kwietnia 2015 Gilles Chanteperdrix < > > gilles.chanteperd...@xenomai.org> > > > > And forgot to add my apologies for these bad patches and the noise > > > that fo

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-09 Thread Nicolas George
Le decadi 20 germinal, an CCXXIII, Gilles Chanteperdrix a écrit : > Well, in that case, > ffmpeg -i `youtube-dl -f bestvideo -g $url` That could work too, but you still fail to acknowledge that -g is frequently not enough. Regards, -- Nicolas George signature.asc Description: Digital signa

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-09 Thread Gilles Chanteperdrix
On Wed, Apr 08, 2015 at 10:22:42PM +0200, Nicolas George wrote: > Le nonidi 19 germinal, an CCXXIII, Gilles Chanteperdrix a écrit : > > So, when you just need to run exec, it is stupid > > Exactly what I wrote: not your problem / premature optimization. > > > I do not follow you here. youtube-dl

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-09 Thread compn
On Thu, 9 Apr 2015 14:36:42 +0200 Nicolas George wrote: > Le decadi 20 germinal, an CCXXIII, compn a écrit : > > what we should do is convince youtube that having youtube support in > > ffmpeg (and thus vlc and other projects) with ad playback, login > > support, etc, is exactly what youtube want

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-09 Thread Lukasz Marek
> Easy. Just merge webkit into ffmpeg. It's for the greater good! Any specific reason for webkit in ffmpeg? You said something about not being trolling. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-deve

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-09 Thread wm4
On Thu, 9 Apr 2015 08:30:43 -0400 compn wrote: > On Wed, 8 Apr 2015 20:14:07 +0200 > Gilles Chanteperdrix wrote: > > > > why not machine translate the python to c and import that into > > > ffmpeg? :P > > > > > > https://github.com/pradyun/Py2C > > > > Because then you will have to maintain t

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-09 Thread Nicolas George
Le decadi 20 germinal, an CCXXIII, compn a écrit : > what we should do is convince youtube that having youtube support in > ffmpeg (and thus vlc and other projects) with ad playback, login > support, etc, is exactly what youtube wants. then youtube sends a patch > and maintains it. Maybe that woul

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-09 Thread compn
On Wed, 8 Apr 2015 20:14:07 +0200 Gilles Chanteperdrix wrote: > > why not machine translate the python to c and import that into > > ffmpeg? :P > > > > https://github.com/pradyun/Py2C > > Because then you will have to maintain that C, update it as soon as > a youtube-dl python file is updated b

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-09 Thread wm4
On Thu, 9 Apr 2015 13:57:39 +0200 Nicolas George wrote: > Le decadi 20 germinal, an CCXXIII, wm4 a écrit : > > Huh? I don't think you quite know what youtube-dl can do. For your > > information, it does everything quvi could do, and more. It's also much > > better at it and faster too. > > And o

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-09 Thread Nicolas George
Le decadi 20 germinal, an CCXXIII, wm4 a écrit : > Huh? I don't think you quite know what youtube-dl can do. For your > information, it does everything quvi could do, and more. It's also much > better at it and faster too. And once again, you forgot to think before posting. Hint: where is libyout

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-09 Thread wm4
On Thu, 9 Apr 2015 13:13:40 +0200 Nicolas George wrote: > Le decadi 20 germinal, an CCXXIII, wm4 a écrit : > > Maintaining a > > wrapper for a dead library when there's something better > > Please stop spreading your own arbitrary value judgments

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-09 Thread Kieran Kunhya
On 9 April 2015 at 12:17, Rodger Combs wrote: > >> On Apr 9, 2015, at 06:08, wm4 wrote: >> >> On Thu, 9 Apr 2015 00:02:50 +0200 >> Lukasz Marek wrote: >> >>> W dniu środa, 8 kwietnia 2015 Gilles Chanteperdrix < >>> gilles.chanteperd...@xenomai.org> >>> >>> And forgot to add my apologies for thes

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-09 Thread Rodger Combs
> On Apr 9, 2015, at 06:08, wm4 wrote: > > On Thu, 9 Apr 2015 00:02:50 +0200 > Lukasz Marek wrote: > >> W dniu środa, 8 kwietnia 2015 Gilles Chanteperdrix < >> gilles.chanteperd...@xenomai.org> >> >> And forgot to add my apologies for these bad patches and the noise >>> that followed. >>> >>

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-09 Thread Nicolas George
Le decadi 20 germinal, an CCXXIII, wm4 a écrit : > Maintaining a > wrapper for a dead library when there's something better Please stop spreading your own arbitrary value judgments everywhere as if they were universal. Unlike what you claim, you

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-09 Thread wm4
On Thu, 9 Apr 2015 00:02:50 +0200 Lukasz Marek wrote: > W dniu środa, 8 kwietnia 2015 Gilles Chanteperdrix < > gilles.chanteperd...@xenomai.org> > > And forgot to add my apologies for these bad patches and the noise > > that followed. > > > > No need for that. > > Your demuxer seems to use pub

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-09 Thread wm4
On Wed, 8 Apr 2015 22:26:23 +0200 Gilles Chanteperdrix wrote: > On Wed, Apr 08, 2015 at 10:08:25PM +0200, wm4 wrote: > > On Wed, 08 Apr 2015 20:52:12 +0100 > > Derek Buitenhuis wrote: > > > > > On 4/8/2015 6:16 PM, Gilles Chanteperdrix wrote: > > > > Signed-off-by: Gilles Chanteperdrix > > > >

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-08 Thread Lukasz Marek
W dniu środa, 8 kwietnia 2015 Gilles Chanteperdrix < gilles.chanteperd...@xenomai.org> And forgot to add my apologies for these bad patches and the noise > that followed. > No need for that. Your demuxer seems to use public API only so you can try to move this implementation to your project and

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-08 Thread Gilles Chanteperdrix
On Wed, Apr 08, 2015 at 10:37:13PM +0200, Gilles Chanteperdrix wrote: > On Wed, Apr 08, 2015 at 04:31:34PM -0400, compn wrote: > > On Wed, 8 Apr 2015 22:26:23 +0200 > > Gilles Chanteperdrix wrote: > > > > > ready to forget all about these patches. > > > > thanks for the patches, even if some peo

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-08 Thread Gilles Chanteperdrix
On Wed, Apr 08, 2015 at 04:31:34PM -0400, compn wrote: > On Wed, 8 Apr 2015 22:26:23 +0200 > Gilles Chanteperdrix wrote: > > > ready to forget all about these patches. > > thanks for the patches, even if some people do not like them. > > please dont be discouraged by strongly worded mails. > >

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-08 Thread compn
On Wed, 8 Apr 2015 22:26:23 +0200 Gilles Chanteperdrix wrote: > ready to forget all about these patches. thanks for the patches, even if some people do not like them. please dont be discouraged by strongly worded mails. its a long term bikeshed that you have stepped in. the developers are most

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-08 Thread Gilles Chanteperdrix
On Wed, Apr 08, 2015 at 10:08:25PM +0200, wm4 wrote: > On Wed, 08 Apr 2015 20:52:12 +0100 > Derek Buitenhuis wrote: > > > On 4/8/2015 6:16 PM, Gilles Chanteperdrix wrote: > > > Signed-off-by: Gilles Chanteperdrix > > > --- > > > libavformat/Makefile | 1 + > > > libavformat/allformats.c |

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-08 Thread wm4
On Wed, 8 Apr 2015 22:16:22 +0200 Gilles Chanteperdrix wrote: > On Wed, Apr 08, 2015 at 09:59:17PM +0200, Nicolas George wrote: > > Le nonidi 19 germinal, an CCXXIII, Gilles Chanteperdrix a écrit : > > > As I explained, I did it this way for portability. system is ANSI > > > not POSIX, redirectio

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-08 Thread Nicolas George
Le nonidi 19 germinal, an CCXXIII, Gilles Chanteperdrix a écrit : > So, when you just need to run exec, it is stupid Exactly what I wrote: not your problem / premature optimization. > I do not follow you here. youtube-dl -J has a uselessly verbose > output, much harder to parse than youtube-dl -

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-08 Thread Gilles Chanteperdrix
On Wed, Apr 08, 2015 at 08:52:12PM +0100, Derek Buitenhuis wrote: > On 4/8/2015 6:16 PM, Gilles Chanteperdrix wrote: > > Signed-off-by: Gilles Chanteperdrix > > --- > > libavformat/Makefile | 1 + > > libavformat/allformats.c | 1 + > > libavformat/youtubedl.c | 221 > >

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-08 Thread Gilles Chanteperdrix
On Wed, Apr 08, 2015 at 09:59:17PM +0200, Nicolas George wrote: > Le nonidi 19 germinal, an CCXXIII, Gilles Chanteperdrix a écrit : > > As I explained, I did it this way for portability. system is ANSI > > not POSIX, redirections work with windows shell too, and av_tempfile > > is implemented by ff

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-08 Thread wm4
On Wed, 08 Apr 2015 20:52:12 +0100 Derek Buitenhuis wrote: > On 4/8/2015 6:16 PM, Gilles Chanteperdrix wrote: > > Signed-off-by: Gilles Chanteperdrix > > --- > > libavformat/Makefile | 1 + > > libavformat/allformats.c | 1 + > > libavformat/youtubedl.c | 221 > > +

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-08 Thread Nicolas George
Le nonidi 19 germinal, an CCXXIII, Gilles Chanteperdrix a écrit : > As I explained, I did it this way for portability. system is ANSI > not POSIX, redirections work with windows shell too, and av_tempfile > is implemented by ffmpeg, so I expect it to be portable. Implementing pipe reading for othe

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-08 Thread Derek Buitenhuis
On 4/8/2015 6:16 PM, Gilles Chanteperdrix wrote: > Signed-off-by: Gilles Chanteperdrix > --- > libavformat/Makefile | 1 + > libavformat/allformats.c | 1 + > libavformat/youtubedl.c | 221 > +++ > 3 files changed, 223 insertions(+) > create

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-08 Thread Gilles Chanteperdrix
On Wed, Apr 08, 2015 at 09:07:06PM +0200, Nicolas George wrote: > Le nonidi 19 germinal, an CCXXIII, Gilles Chanteperdrix a écrit : > > Signed-off-by: Gilles Chanteperdrix > > --- > > libavformat/Makefile | 1 + > > libavformat/allformats.c | 1 + > > libavformat/youtubedl.c | 221 > > +

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-08 Thread Nicolas George
Le nonidi 19 germinal, an CCXXIII, Gilles Chanteperdrix a écrit : > Signed-off-by: Gilles Chanteperdrix > --- > libavformat/Makefile | 1 + > libavformat/allformats.c | 1 + > libavformat/youtubedl.c | 221 > +++ > 3 files changed, 223 inserti

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-08 Thread Gilles Chanteperdrix
On Wed, Apr 08, 2015 at 02:08:21PM -0400, compn wrote: > On Wed, 8 Apr 2015 19:51:12 +0200 > Gilles Chanteperdrix wrote: > > > On Wed, Apr 08, 2015 at 07:44:13PM +0200, wm4 wrote: > > > On Wed, 8 Apr 2015 19:39:00 +0200 > > > Gilles Chanteperdrix wrote: > > > > > > > On Wed, Apr 08, 2015 at 07:

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-08 Thread compn
On Wed, 8 Apr 2015 19:51:12 +0200 Gilles Chanteperdrix wrote: > On Wed, Apr 08, 2015 at 07:44:13PM +0200, wm4 wrote: > > On Wed, 8 Apr 2015 19:39:00 +0200 > > Gilles Chanteperdrix wrote: > > > > > On Wed, Apr 08, 2015 at 07:24:27PM +0200, wm4 wrote: > > > > > +snprintf(buffer, sizeof(buffer

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-08 Thread Gilles Chanteperdrix
On Wed, Apr 08, 2015 at 07:44:13PM +0200, wm4 wrote: > On Wed, 8 Apr 2015 19:39:00 +0200 > Gilles Chanteperdrix wrote: > > > On Wed, Apr 08, 2015 at 07:24:27PM +0200, wm4 wrote: > > > > +snprintf(buffer, sizeof(buffer), "youtube-dl -f %s -g '%s'", > > > > + yc->format, s->filename)

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-08 Thread Gilles Chanteperdrix
On Wed, Apr 08, 2015 at 07:30:48PM +0200, Hendrik Leppkes wrote: > On Wed, Apr 8, 2015 at 7:27 PM, Gilles Chanteperdrix > wrote: > > > >> Nice security hole. > > > > how is that ? I do not see any buffer overflow possible. > > > > Executing a command with system() is very unsafe. Indeed, never t

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-08 Thread wm4
On Wed, 8 Apr 2015 19:39:00 +0200 Gilles Chanteperdrix wrote: > On Wed, Apr 08, 2015 at 07:24:27PM +0200, wm4 wrote: > > > +snprintf(buffer, sizeof(buffer), "youtube-dl -f %s -g '%s'", > > > + yc->format, s->filename); > > Ok, missing single quotes here around the format. > Doesn't he

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-08 Thread Gilles Chanteperdrix
On Wed, Apr 08, 2015 at 07:30:12PM +0200, wm4 wrote: > On Wed, 8 Apr 2015 19:27:55 +0200 > Gilles Chanteperdrix wrote: > > > On Wed, Apr 08, 2015 at 07:24:27PM +0200, wm4 wrote: > > > On Wed, 8 Apr 2015 19:16:38 +0200 > > > Gilles Chanteperdrix wrote: > > > > > > > Signed-off-by: Gilles Chante

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-08 Thread Gilles Chanteperdrix
On Wed, Apr 08, 2015 at 07:24:27PM +0200, wm4 wrote: > > +snprintf(buffer, sizeof(buffer), "youtube-dl -f %s -g '%s'", > > + yc->format, s->filename); Ok, missing single quotes here around the format. -- Gilles. _

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-08 Thread Gilles Chanteperdrix
On Wed, Apr 08, 2015 at 07:30:12PM +0200, wm4 wrote: > On Wed, 8 Apr 2015 19:27:55 +0200 > Gilles Chanteperdrix wrote: > > > On Wed, Apr 08, 2015 at 07:24:27PM +0200, wm4 wrote: > > > On Wed, 8 Apr 2015 19:16:38 +0200 > > > Gilles Chanteperdrix wrote: > > > > > > > Signed-off-by: Gilles Chante

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-08 Thread Hendrik Leppkes
On Wed, Apr 8, 2015 at 7:27 PM, Gilles Chanteperdrix wrote: > >> Nice security hole. > > how is that ? I do not see any buffer overflow possible. > Executing a command with system() is very unsafe. - Hendrik ___ ffmpeg-devel mailing list ffmpeg-devel@f

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-08 Thread wm4
On Wed, 8 Apr 2015 19:27:55 +0200 Gilles Chanteperdrix wrote: > On Wed, Apr 08, 2015 at 07:24:27PM +0200, wm4 wrote: > > On Wed, 8 Apr 2015 19:16:38 +0200 > > Gilles Chanteperdrix wrote: > > > > > Signed-off-by: Gilles Chanteperdrix > > > --- > > > libavformat/Makefile | 1 + > > > lib

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-08 Thread Gilles Chanteperdrix
On Wed, Apr 08, 2015 at 07:24:27PM +0200, wm4 wrote: > On Wed, 8 Apr 2015 19:16:38 +0200 > Gilles Chanteperdrix wrote: > > > Signed-off-by: Gilles Chanteperdrix > > --- > > libavformat/Makefile | 1 + > > libavformat/allformats.c | 1 + > > libavformat/youtubedl.c | 221 > > +

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-08 Thread wm4
On Wed, 8 Apr 2015 19:16:38 +0200 Gilles Chanteperdrix wrote: > Signed-off-by: Gilles Chanteperdrix > --- > libavformat/Makefile | 1 + > libavformat/allformats.c | 1 + > libavformat/youtubedl.c | 221 > +++ > 3 files changed, 223 insertio

[FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

2015-04-08 Thread Gilles Chanteperdrix
Signed-off-by: Gilles Chanteperdrix --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/youtubedl.c | 221 +++ 3 files changed, 223 insertions(+) create mode 100644 libavformat/youtubedl.c diff --git a/libavformat/Make