Re: [FFmpeg-devel] [PATCH] x86/swr: load constants outside the loop in pack_6ch functions

2015-01-10 Thread James Almer
On 10/01/15 10:19 PM, Michael Niedermayer wrote: > On Sat, Jan 10, 2015 at 07:27:11PM -0300, James Almer wrote: >> Signed-off-by: James Almer >> --- >> libswresample/x86/audio_convert.asm | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > ok Pushed. Thanks. __

Re: [FFmpeg-devel] [PATCH] x86/swr: load constants outside the loop in pack_6ch functions

2015-01-10 Thread Michael Niedermayer
On Sat, Jan 10, 2015 at 07:27:11PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libswresample/x86/audio_convert.asm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) ok [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB What does censorshi

[FFmpeg-devel] [PATCH] x86/swr: load constants outside the loop in pack_6ch functions

2015-01-10 Thread James Almer
Signed-off-by: James Almer --- libswresample/x86/audio_convert.asm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libswresample/x86/audio_convert.asm b/libswresample/x86/audio_convert.asm index f02370c..07d7458 100644 --- a/libswresample/x86/audio_convert.asm +++ b/libswresa

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: added HLS encryption

2015-01-10 Thread Michael Niedermayer
On Fri, Jan 09, 2015 at 11:07:16PM +, Christian Suloway wrote: > Resending attachment. > > > From: ffmpeg-devel-boun...@ffmpeg.org on > behalf of Christian Suloway > Sent: Friday, January 9, 2015 5:02 PM > To: FFmpeg development discussions and patch

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc.c: Fix linking with codec interface with msvc.

2015-01-10 Thread Michael Niedermayer
On Sat, Jan 10, 2015 at 06:18:16PM +, Timothy Gu wrote: > On Sat Jan 10 2015 at 3:28:36 AM Matt Oliver wrote: > > > This uses the appropriate libvpx accessor function for accessing the codec > > interface correctly on any platform which correct link errors on windows. > > > > LGTM. The acces

Re: [FFmpeg-devel] [PATCH] vp9: avoid infinite loop with broken files

2015-01-10 Thread Michael Niedermayer
On Sat, Jan 10, 2015 at 01:21:42PM -0500, Ronald S. Bultje wrote: > Hi, > > On Sat, Jan 10, 2015 at 12:15 PM, wm4 wrote: > > > On Sat, 10 Jan 2015 18:03:48 +0100 > > Hendrik Leppkes wrote: > > > > > On Sat, Jan 10, 2015 at 6:00 PM, wm4 wrote: > > > > > > > With a certain fuzzed file, the parse

Re: [FFmpeg-devel] [PATCH] doc/platform: Add build instruction for Windows Runtime

2015-01-10 Thread James Almer
On 10/01/15 3:20 PM, wm4 wrote: > On Sat, 10 Jan 2015 18:02:17 + > Timothy Gu wrote: > >> On Sat Jan 10 2015 at 2:07:16 AM Derek Buitenhuis < >> derek.buitenh...@gmail.com> wrote: >> >>> On 1/10/2015 8:43 AM, Timotius Margo wrote: Hi, The attached patch updates the Platform Spe

Re: [FFmpeg-devel] [PATCH] vp9: avoid infinite loop with broken files

2015-01-10 Thread Ronald S. Bultje
Hi, On Sat, Jan 10, 2015 at 12:15 PM, wm4 wrote: > On Sat, 10 Jan 2015 18:03:48 +0100 > Hendrik Leppkes wrote: > > > On Sat, Jan 10, 2015 at 6:00 PM, wm4 wrote: > > > > > With a certain fuzzed file, the parser will always return 0 consumed > > > bytes, which makes calling code call the parser

Re: [FFmpeg-devel] [PATCH] doc/platform: Add build instruction for Windows Runtime

2015-01-10 Thread wm4
On Sat, 10 Jan 2015 18:02:17 + Timothy Gu wrote: > On Sat Jan 10 2015 at 2:07:16 AM Derek Buitenhuis < > derek.buitenh...@gmail.com> wrote: > > > On 1/10/2015 8:43 AM, Timotius Margo wrote: > > > Hi, > > > > > > The attached patch updates the Platform Specific Information with build > > inst

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc.c: Fix linking with codec interface with msvc.

2015-01-10 Thread Timothy Gu
On Sat Jan 10 2015 at 3:28:36 AM Matt Oliver wrote: > This uses the appropriate libvpx accessor function for accessing the codec > interface correctly on any platform which correct link errors on windows. > LGTM. The accessors have been there since 0.9.5, and we only support 0.9.7 for encoding.

Re: [FFmpeg-devel] [PATCH] doc/platform: Add build instruction for Windows Runtime

2015-01-10 Thread Derek Buitenhuis
On 1/10/2015 6:02 PM, Timothy Gu wrote: >> Almost whole patch is wrong (should use MSYS2), out of scope for FFmpeg, >> and >> uses the wrong title (we *do not* want MinGW here at all). Sure. My issue is that people confused MinGW (the toolchain) with MSYS (the environment, which is sometimes on mi

Re: [FFmpeg-devel] [PATCH] doc/platform: Add build instruction for Windows Runtime

2015-01-10 Thread Timothy Gu
On Sat Jan 10 2015 at 2:07:16 AM Derek Buitenhuis < derek.buitenh...@gmail.com> wrote: > On 1/10/2015 8:43 AM, Timotius Margo wrote: > > Hi, > > > > The attached patch updates the Platform Specific Information with build > instruction for Windows Store and Windows Phone 8.1. > > [...] > > > +@head

Re: [FFmpeg-devel] [PATCH] vp9: avoid infinite loop with broken files

2015-01-10 Thread wm4
On Sat, 10 Jan 2015 18:03:48 +0100 Hendrik Leppkes wrote: > On Sat, Jan 10, 2015 at 6:00 PM, wm4 wrote: > > > With a certain fuzzed file, the parser will always return 0 consumed > > bytes, which makes calling code call the parser infinitely. Return the > > full packet size on error instead. (H

Re: [FFmpeg-devel] [PATCH] vp9: avoid infinite loop with broken files

2015-01-10 Thread Hendrik Leppkes
On Sat, Jan 10, 2015 at 6:00 PM, wm4 wrote: > With a certain fuzzed file, the parser will always return 0 consumed > bytes, which makes calling code call the parser infinitely. Return the > full packet size on error instead. (Here it would be nice if parsers > could return errors at all.) > > Add

[FFmpeg-devel] [PATCH] vp9: avoid infinite loop with broken files

2015-01-10 Thread wm4
With a certain fuzzed file, the parser will always return 0 consumed bytes, which makes calling code call the parser infinitely. Return the full packet size on error instead. (Here it would be nice if parsers could return errors at all.) Additionally, _if_ there's some data left, return that too,

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: fix dts>pts when b frame >= 1

2015-01-10 Thread Michael Niedermayer
On Sat, Jan 10, 2015 at 05:30:03PM +0100, Timo Rothenpieler wrote: > Am 07.01.2015 um 10:48 schrieb Agatha Hu: > > When B frames >= 1, there'll be a invalid dts/pts warning during > > encoding like: > > > > [mp4 @ 0034cba0] Invalid DTS: 1024 PTS: 512 in output stream > > 0:0, replacing by

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: fix dts>pts when b frame >= 1

2015-01-10 Thread Timo Rothenpieler
Am 07.01.2015 um 10:48 schrieb Agatha Hu: > When B frames >= 1, there'll be a invalid dts/pts warning during > encoding like: > > [mp4 @ 0034cba0] Invalid DTS: 1024 PTS: 512 in output stream > 0:0, replacing by guess > [mp4 @ 0034cba0] Invalid DTS: 1536 PTS: 1024 in output stream >

[FFmpeg-devel] [PATCH] avcodec/libvpxenc.c: Fix linking with codec interface with msvc.

2015-01-10 Thread Matt Oliver
This uses the appropriate libvpx accessor function for accessing the codec interface correctly on any platform which correct link errors on windows. Reasoning is that the default libvpx msvc build uses module definitions to export data. Data exports in msvc like this are actually exported as pointe

Re: [FFmpeg-devel] [PATCH] Force text files to be downloaded in UNIX line ending (LF)

2015-01-10 Thread Derek Buitenhuis
On 1/10/2015 10:28 AM, Matt Oliver wrote: > Although this may be a good example of why it could be useful to make it > clear somewhere that MSYS2 is the recommended setup to help avoid these > issues that way. Agreed. - Derek ___ ffmpeg-devel mailing li

Re: [FFmpeg-devel] [PATCH] Force text files to be downloaded in UNIX line ending (LF)

2015-01-10 Thread Matt Oliver
On 10 January 2015 at 21:18, Derek Buitenhuis wrote: > On 1/10/2015 8:40 AM, Timotius Margo wrote: > > This causes a problem with autoconf and prevents > > user from building FFmpeg successfully without applying a workaround. > > I forgot to mention this is fixed in newer make.exe's, and I think

Re: [FFmpeg-devel] [PATCH] Force text files to be downloaded in UNIX line ending (LF)

2015-01-10 Thread Derek Buitenhuis
On 1/10/2015 8:40 AM, Timotius Margo wrote: > This causes a problem with autoconf and prevents > user from building FFmpeg successfully without applying a workaround. I forgot to mention this is fixed in newer make.exe's, and I think it's included in MSYS2. - Derek ___

Re: [FFmpeg-devel] [PATCH] Force text files to be downloaded in UNIX line ending (LF)

2015-01-10 Thread Derek Buitenhuis
On 1/10/2015 8:40 AM, Timotius Margo wrote: > +* text eol=lf I think this is wrong. git should be set up to pull and push verbatim, not a specific line ending. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listi

Re: [FFmpeg-devel] [PATCH] doc/platform: Add build instruction for Windows Runtime

2015-01-10 Thread Derek Buitenhuis
On 1/10/2015 8:43 AM, Timotius Margo wrote: > Hi, > > The attached patch updates the Platform Specific Information with build > instruction for Windows Store and Windows Phone 8.1. [...] > +@heading MinGW Setup Almost whole patch is wrong (should use MSYS2), out of scope for FFmpeg, and uses t

[FFmpeg-devel] [PATCH] doc/platform: Add build instruction for Windows Runtime

2015-01-10 Thread Timotius Margo
Hi, The attached patch updates the Platform Specific Information with build instruction for Windows Store and Windows Phone 8.1. Best Regards, Timotius Margo 0001-doc-platform-Add-build-instruction-for-Windows-Runti.patch Description: 0001-doc-platform-Add-build-instruction-for-Windows-Runti

[FFmpeg-devel] [PATCH] Force text files to be downloaded in UNIX line ending (LF)

2015-01-10 Thread Timotius Margo
>From 7723f4ed203671c410109cbaf6dc3caca130b27b Mon Sep 17 00:00:00 2001 From: Timotius Margo Date: Fri, 9 Jan 2015 17:03:56 -0800 Subject: [PATCH] Force text files to be downloaded in UNIX line ending (LF) In a default MinGW environment, FFmpeg is always downloaded with CRLF (Windows) line ending