Re: [FFmpeg-devel] [PATCH 13/14] tests: Add aac_fixed decoder test

2015-04-16 Thread James Almer
On 15/04/15 1:29 PM, Nedeljko Babic wrote: From: Nedeljko Babic nedeljko.ba...@rt-rk.com Signed-off-by: Nedeljko Babic nedeljko.ba...@rt-rk.com --- tests/fate/aac.mak | 63 ++ 1 file changed, 63 insertions(+) diff --git

[FFmpeg-devel] [PATCH] configure: add missing dependencies for MIPS and PPC features

2015-04-16 Thread James Almer
Signed-off-by: James Almer jamr...@gmail.com --- configure | 4 1 file changed, 4 insertions(+) diff --git a/configure b/configure index 389de92..c5bae3f 100755 --- a/configure +++ b/configure @@ -2012,14 +2012,18 @@ setend_deps=arm map 'eval ${v}_inline_deps=inline_asm'

Re: [FFmpeg-devel] [RFC][PATCH] avformat/flvdec: avoid reseting eof_reached to 0 silently

2015-04-16 Thread Zhang Rui
I want to let av_read_frame() tell us (user application) what to do next, by returning limited code, at least limited on special situation which need more handling, including AV_ERROR_EAGIN; AV_ERROR_END_OF_STREAM_YOU_NAME_IT; AV_ERROR_EXIT; // interrupted with interrupt call back. Yes,

Re: [FFmpeg-devel] [PATCH] configure: add pkg-config support for libdcadec

2015-04-16 Thread wm4
On Wed, 15 Apr 2015 20:24:23 -0300 James Almer jamr...@gmail.com wrote: On 15/04/15 8:14 PM, Carl Eugen Hoyos wrote: Simon Thelen ffmpeg-dev at c-14.de writes: I don't particularly mind either way. I can resend a version without fallback. Please keep the fallback, not all OS have

Re: [FFmpeg-devel] [RFC][PATCH] avformat/flvdec: avoid reseting eof_reached to 0 silently

2015-04-16 Thread Zhang Rui
2015-04-15 18:38 GMT+08:00 wm4 nfx...@googlemail.com: On Tue, 14 Apr 2015 11:24:23 +0800 Zhang Rui bbcal...@gmail.com wrote: 2015-04-14 1:09 GMT+08:00 wm4 nfx...@googlemail.com: On Mon, 13 Apr 2015 12:02:29 +0800 Zhang Rui bbcal...@gmail.com wrote: 2015-04-12 22:45 GMT+08:00 Michael

Re: [FFmpeg-devel] [PATCH] configure: use pkg-config to find libdcadec

2015-04-16 Thread Hendrik Leppkes
On Wed, Apr 15, 2015 at 7:40 PM, Simon Thelen ffmpeg-...@c-14.de wrote: Signed-off-by: Simon Thelen ffmpeg-...@c-14.de --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 389de92..93aebcb 100755 --- a/configure +++ b/configure @@

[FFmpeg-devel] [PATCH] lavfi/avf_showcqt: fix error code.

2015-04-16 Thread Nicolas George
Signed-off-by: Nicolas George geo...@nsup.org --- libavfilter/avf_showcqt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) If deemed correct, do not wait for me to apply. diff --git a/libavfilter/avf_showcqt.c b/libavfilter/avf_showcqt.c index e862dc7..8c6ce1f 100644 ---

Re: [FFmpeg-devel] [PATCH] avcodec[/format]/webpenc: use WebPAnimEncoder API to generate animated WebP

2015-04-16 Thread Michael Niedermayer
On Thu, Apr 16, 2015 at 12:28:22AM +, Urvang Joshi wrote: Hi, Here's an updated patch that used 'HAVE_WEBP_MUX_H' as you suggested. I also updated the patch to work with the latest libwebp code (from https://gerrit.chromium.org/gerrit/gitweb?p=webm/libwebp.git) please dont reindent the

Re: [FFmpeg-devel] [PATCH] configure: use pkg-config to find libdcadec

2015-04-16 Thread Michael Niedermayer
On Thu, Apr 16, 2015 at 10:48:35AM +0200, Hendrik Leppkes wrote: On Wed, Apr 15, 2015 at 7:40 PM, Simon Thelen ffmpeg-...@c-14.de wrote: Signed-off-by: Simon Thelen ffmpeg-...@c-14.de --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure

[FFmpeg-devel] [PATCH] msrledec: use signed pixel_ptr in msrle_decode_pal4

2015-04-16 Thread Andreas Cadhalpun
This fixes segmentation faults, when pic-linesize[0] is negative. In that case 'line * pic-linesize[0] + pixel_ptr' is treated as unsigned and wraps around. This reverts commit 7d78a964. The problem was introduced in commit f7e1367f, which should obsolete that commit. Signed-off-by: Andreas

Re: [FFmpeg-devel] [PATCH] configure: add missing dependencies for MIPS and PPC features

2015-04-16 Thread Michael Niedermayer
On Thu, Apr 16, 2015 at 03:01:52AM -0300, James Almer wrote: Signed-off-by: James Almer jamr...@gmail.com --- configure | 4 1 file changed, 4 insertions(+) LGTM [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The real ebay dictionary, page 1 Used

Re: [FFmpeg-devel] [PATCH] lavfi/avf_showcqt: fix error code.

2015-04-16 Thread Michael Niedermayer
On Thu, Apr 16, 2015 at 11:31:23AM +0200, Nicolas George wrote: Signed-off-by: Nicolas George geo...@nsup.org --- libavfilter/avf_showcqt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) If deemed correct, do not wait for me to apply. applied thanks [...] -- Michael GnuPG

[FFmpeg-devel] [PATCH] hls: skip to next segment if the current is unavailable

2015-04-16 Thread wm4
Apparently, some live streams can delete segments too early, maybe because the client is too far behind. In this case, it's better to skip the segment, instead of returning EOF. (Yes, the HLS demuxer actually returns AVERROR_EOF if opening the segment returns a 404 HTTP error.) --- I'd say this is

Re: [FFmpeg-devel] [PATCH] ivfenc: incorrect fourcc for VP9 video

2015-04-16 Thread Michael Niedermayer
On Wed, Apr 15, 2015 at 11:51:59PM +0700, Victor Anjin wrote: VP80 fourcc are writed for all contexts (without ctx-codec_tag) how to reproduce the issue: 1) Get any vp9 video (for example http://base-n.de/webm/out9.webm) 2) ffmpeg -i out9.webm -vcodec copy out9.ivf 3) out9.ivf have VP80

Re: [FFmpeg-devel] [PATCH] msrledec: use signed pixel_ptr in msrle_decode_pal4

2015-04-16 Thread Michael Niedermayer
On Thu, Apr 16, 2015 at 02:49:08PM +0200, Andreas Cadhalpun wrote: This fixes segmentation faults, when pic-linesize[0] is negative. In that case 'line * pic-linesize[0] + pixel_ptr' is treated as unsigned and wraps around. This reverts commit 7d78a964. The problem was introduced in commit

[FFmpeg-devel] [PATCH] aacdec: consistently use avctx for logging in decode_eld_specific_config

2015-04-16 Thread Andreas Cadhalpun
ac may be NULL and then accessing ac-avctx results in a segmentation fault. Signed-off-by: Andreas Cadhalpun andreas.cadhal...@googlemail.com --- libavcodec/aacdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/aacdec.c b/libavcodec/aacdec.c index

[FFmpeg-devel] [PATCH] aacpsy: avoid norm_fac becoming NaN

2015-04-16 Thread Andreas Cadhalpun
If both band-active_lines and band-thr are 0.0f, the division is undefined, making norm_fac not a number. NaN is passed on to other variables until it finally reaches sce-sf_idx and is converted to an integer (-2147483648). This causes a segmentation fault when it is used as array index.

Re: [FFmpeg-devel] [PATCH 2/2] lavf/assenc: handle extra sections after Events

2015-04-16 Thread Rodger Combs
On Apr 9, 2015, at 06:55, wm4 nfx...@googlemail.com wrote: On Thu, 9 Apr 2015 06:12:53 -0500 Rodger Combs rodger.co...@gmail.com wrote: On Apr 8, 2015, at 14:25, Michael Niedermayer michae...@gmx.at wrote: On Sat, Apr 04, 2015 at 05:31:22AM -0500, Rodger Combs wrote: ---

Re: [FFmpeg-devel] [PATCH 2/2] lavf/assenc: handle extra sections after Events

2015-04-16 Thread wm4
On Thu, 16 Apr 2015 10:35:11 -0500 Rodger Combs rodger.co...@gmail.com wrote: On Apr 9, 2015, at 06:55, wm4 nfx...@googlemail.com wrote: On Thu, 9 Apr 2015 06:12:53 -0500 Rodger Combs rodger.co...@gmail.com wrote: On Apr 8, 2015, at 14:25, Michael Niedermayer michae...@gmx.at

Re: [FFmpeg-devel] [PATCH] configure: use pkg-config to find libdcadec

2015-04-16 Thread James Almer
On 16/04/15 9:52 AM, Michael Niedermayer wrote: On Thu, Apr 16, 2015 at 10:48:35AM +0200, Hendrik Leppkes wrote: On Wed, Apr 15, 2015 at 7:40 PM, Simon Thelen ffmpeg-...@c-14.de wrote: Signed-off-by: Simon Thelen ffmpeg-...@c-14.de --- configure | 2 +- 1 file changed, 1 insertion(+), 1

Re: [FFmpeg-devel] [PATCH] configure: add missing dependencies for MIPS and PPC features

2015-04-16 Thread James Almer
On 16/04/15 7:29 AM, Michael Niedermayer wrote: On Thu, Apr 16, 2015 at 03:01:52AM -0300, James Almer wrote: Signed-off-by: James Almer jamr...@gmail.com --- configure | 4 1 file changed, 4 insertions(+) LGTM Pushed, thanks. ___

Re: [FFmpeg-devel] [PATCH] configure: use pkg-config to find libdcadec

2015-04-16 Thread Michael Niedermayer
On Thu, Apr 16, 2015 at 01:12:16PM -0300, James Almer wrote: On 16/04/15 9:52 AM, Michael Niedermayer wrote: On Thu, Apr 16, 2015 at 10:48:35AM +0200, Hendrik Leppkes wrote: On Wed, Apr 15, 2015 at 7:40 PM, Simon Thelen ffmpeg-...@c-14.de wrote: Signed-off-by: Simon Thelen

Re: [FFmpeg-devel] [PATCH] aacdec: consistently use avctx for logging in decode_eld_specific_config

2015-04-16 Thread Michael Niedermayer
On Thu, Apr 16, 2015 at 04:58:32PM +0200, Andreas Cadhalpun wrote: ac may be NULL and then accessing ac-avctx results in a segmentation fault. Signed-off-by: Andreas Cadhalpun andreas.cadhal...@googlemail.com --- libavcodec/aacdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[FFmpeg-devel] [PATCH] aasc: return correct buffer size from aasc_decode_frame

2015-04-16 Thread Andreas Cadhalpun
Signed-off-by: Andreas Cadhalpun andreas.cadhal...@googlemail.com --- libavcodec/aasc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/aasc.c b/libavcodec/aasc.c index 65ef782..469fc5e 100644 --- a/libavcodec/aasc.c +++ b/libavcodec/aasc.c @@ -137,7 +137,7 @@

Re: [FFmpeg-devel] [PATCH] aasc: return correct buffer size from aasc_decode_frame

2015-04-16 Thread Michael Niedermayer
On Thu, Apr 16, 2015 at 07:12:02PM +0200, Andreas Cadhalpun wrote: Signed-off-by: Andreas Cadhalpun andreas.cadhal...@googlemail.com --- libavcodec/aasc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) applied thanks [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH] aacpsy: avoid norm_fac becoming NaN

2015-04-16 Thread Claudio Freire
On Thu, Apr 16, 2015 at 1:00 PM, Andreas Cadhalpun andreas.cadhal...@googlemail.com wrote: If both band-active_lines and band-thr are 0.0f, the division is undefined, making norm_fac not a number. NaN is passed on to other variables until it finally reaches sce-sf_idx and is converted to an

Re: [FFmpeg-devel] [PATCH] aacpsy: avoid norm_fac becoming NaN

2015-04-16 Thread Timothy Gu
On Thu, Apr 16, 2015 at 10:41 AM Claudio Freire klaussfre...@gmail.com wrote: It should be if band-thr 0.0f, all divisions by zero return something that casts into an ~1: Isn't division by zero undefined behavior? Timothy ___ ffmpeg-devel mailing

[FFmpeg-devel] [PATCH] ac3: validate end in ff_ac3_bit_alloc_calc_mask

2015-04-16 Thread Andreas Cadhalpun
This fixes an invalid read if end is 0: band_end = ff_ac3_bin_to_band_tab[end-1] + 1; Depending on what is before the array, this can cause stack smashing, when band_end becomes too large. Signed-off-by: Andreas Cadhalpun andreas.cadhal...@googlemail.com --- libavcodec/ac3.c | 3 +++ 1

Re: [FFmpeg-devel] [PATCH] ac3: validate end in ff_ac3_bit_alloc_calc_mask

2015-04-16 Thread Michael Niedermayer
On Thu, Apr 16, 2015 at 09:25:26PM +0200, Andreas Cadhalpun wrote: This fixes an invalid read if end is 0: band_end = ff_ac3_bin_to_band_tab[end-1] + 1; Depending on what is before the array, this can cause stack smashing, when band_end becomes too large. Signed-off-by: Andreas

Re: [FFmpeg-devel] [PATCH] ac3: validate end in ff_ac3_bit_alloc_calc_mask

2015-04-16 Thread Andreas Cadhalpun
On 16.04.2015 23:04, Michael Niedermayer wrote: On Thu, Apr 16, 2015 at 09:25:26PM +0200, Andreas Cadhalpun wrote: This fixes an invalid read if end is 0: band_end = ff_ac3_bin_to_band_tab[end-1] + 1; Depending on what is before the array, this can cause stack smashing, when band_end

Re: [FFmpeg-devel] [PATCH] avcodec[/format]/webpenc: use WebPAnimEncoder API to generate animated WebP

2015-04-16 Thread Urvang Joshi
Hi, Here's the patch without whitespace changes. Thanks, Urvang On Thu, Apr 16, 2015 at 11:50 AM Urvang Joshi urv...@google.com wrote: Hi Michael, Sorry for my misunderstanding earlier. I was told offline that the usual practice in FFmpeg is to land the non-whitespace diff first, followed

Re: [FFmpeg-devel] [PATCH 2/2] lavf/assenc: handle extra sections after Events

2015-04-16 Thread Michael Niedermayer
On Thu, Apr 16, 2015 at 05:55:10PM +0200, wm4 wrote: On Thu, 16 Apr 2015 10:35:11 -0500 Rodger Combs rodger.co...@gmail.com wrote: On Apr 9, 2015, at 06:55, wm4 nfx...@googlemail.com wrote: On Thu, 9 Apr 2015 06:12:53 -0500 Rodger Combs rodger.co...@gmail.com wrote:

Re: [FFmpeg-devel] [PATCH] avcodec[/format]/webpenc: use WebPAnimEncoder API to generate animated WebP

2015-04-16 Thread James Almer
On 16/04/15 4:18 PM, Urvang Joshi wrote: Hi, Here's the patch without whitespace changes. Thanks, Urvang This patch doesn't apply cleanly. Looks like something weird with the indentation still. Was this patch handmade? It says the hash for libwebpenc.c is 95d56ac (same as git head), but

Re: [FFmpeg-devel] [PATCH] remove the www. from the URL - http://evermeet.cx/ffmpeg/

2015-04-16 Thread Timothy Gu
On Thu, Apr 16, 2015 at 5:51 PM, Helmut K. C. Tessarek tessa...@evermeet.cx wrote: Hi Timothy, On 2015-04-16 20:33, Timothy Gu wrote: Applying: remove the www. from the URL - http://evermeet.cx/ffmpeg/ fatal: corrupt patch at line 18 Thanks for fixing the patch. What was the problem with

Re: [FFmpeg-devel] [PATCH] webmdashenc: Add better error handling

2015-04-16 Thread Michael Niedermayer
On Thu, Apr 16, 2015 at 05:32:21PM -0700, Vignesh Venkatasubramanian wrote: Return appropriate error codes and propagate the error codes from helper functions to the outer calls. Also fix a potential leak in call to av_realloc. Signed-off-by: Vignesh Venkatasubramanian vigne...@google.com

[FFmpeg-devel] [PATCH]Set interlaced flag when muxing interlaced dnxhd into mxf

2015-04-16 Thread Carl Eugen Hoyos
Hi! Completely untested. Please review, Carl Eugen diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c index 0b8dfd6..f7c3008 100644 --- a/libavformat/mxfenc.c +++ b/libavformat/mxfenc.c @@ -1655,12 +1655,15 @@ AVPacket *pkt) case 1241: sc-index = 27;

Re: [FFmpeg-devel] [PATCH] configure: use pkg-config to find libdcadec

2015-04-16 Thread James Almer
On 16/04/15 2:02 PM, Michael Niedermayer wrote: On Thu, Apr 16, 2015 at 01:12:16PM -0300, James Almer wrote: On 16/04/15 9:52 AM, Michael Niedermayer wrote: On Thu, Apr 16, 2015 at 10:48:35AM +0200, Hendrik Leppkes wrote: On Wed, Apr 15, 2015 at 7:40 PM, Simon Thelen ffmpeg-...@c-14.de wrote:

Re: [FFmpeg-devel] [PATCH] remove the www. from the URL - http://evermeet.cx/ffmpeg/

2015-04-16 Thread Helmut K. C. Tessarek
Hmm, I believe my mail client screwed it up. I had to use git imap-send and then the mail client to actually send the patch, because git send-email gives me the following error on all my machines: perl5.16(58025,0x7fff776c2310) malloc: *** error for object 0x7fff90af47dd: pointer being freed was

Re: [FFmpeg-devel] [PATCH] remove the www. from the URL - http://evermeet.cx/ffmpeg/

2015-04-16 Thread Timothy Gu
On Thu, Apr 16, 2015 at 09:06:55PM -0400, Helmut K. C. Tessarek wrote: Hmm, I believe my mail client screwed it up. I had to use git imap-send and then the mail client to actually send the patch, because git send-email gives me the following error on all my machines:

Re: [FFmpeg-devel] [PATCH] avcodec[/format]/webpenc: use WebPAnimEncoder API to generate animated WebP

2015-04-16 Thread Urvang Joshi
On Thu, Apr 16, 2015 at 3:09 PM James Almer jamr...@gmail.com wrote: On 16/04/15 4:18 PM, Urvang Joshi wrote: Hi, Here's the patch without whitespace changes. Thanks, Urvang This patch doesn't apply cleanly. Looks like something weird with the indentation still. Was this patch

Re: [FFmpeg-devel] [PATCH] remove the www. from the URL - http://evermeet.cx/ffmpeg/

2015-04-16 Thread Timothy Gu
On Thu, Apr 16, 2015 at 5:19 PM, Helmut K. C. Tessarek tessa...@evermeet.cx wrote: --- src/download | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Applying: remove the www. from the URL - http://evermeet.cx/ffmpeg/ fatal: corrupt patch at line 18 Patch failed at 0001 remove the www.

[FFmpeg-devel] [PATCH] remove the www. from the URL - http://evermeet.cx/ffmpeg/

2015-04-16 Thread Helmut K. C. Tessarek
--- src/download | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/download b/src/download index a9d5cc2..7d50786 100644 --- a/src/download +++ b/src/download @@ -89,7 +89,7 @@ h3OS X Packages/h3 div class=list-group - a

Re: [FFmpeg-devel] [PATCH] remove the www. from the URL - http://evermeet.cx/ffmpeg/

2015-04-16 Thread Helmut K. C. Tessarek
Hi Timothy, On 2015-04-16 20:33, Timothy Gu wrote: Applying: remove the www. from the URL - http://evermeet.cx/ffmpeg/ fatal: corrupt patch at line 18 Thanks for fixing the patch. What was the problem with the patch, so that this won't happen again. Cheers, K. C. -- regards Helmut K. C.

Re: [FFmpeg-devel] [PATCH] aacpsy: avoid norm_fac becoming NaN

2015-04-16 Thread Michael Niedermayer
On Thu, Apr 16, 2015 at 05:47:50PM +, Timothy Gu wrote: On Thu, Apr 16, 2015 at 10:41 AM Claudio Freire klaussfre...@gmail.com wrote: It should be if band-thr 0.0f, all divisions by zero return something that casts into an ~1: Isn't division by zero undefined behavior? for floats

Re: [FFmpeg-devel] [PATCH] aacpsy: avoid norm_fac becoming NaN

2015-04-16 Thread Michael Niedermayer
On Thu, Apr 16, 2015 at 02:41:39PM -0300, Claudio Freire wrote: On Thu, Apr 16, 2015 at 1:00 PM, Andreas Cadhalpun andreas.cadhal...@googlemail.com wrote: If both band-active_lines and band-thr are 0.0f, the division is undefined, making norm_fac not a number. NaN is passed on to other

Re: [FFmpeg-devel] [PATCH] aacpsy: avoid norm_fac becoming NaN

2015-04-16 Thread Andreas Cadhalpun
On 16.04.2015 19:41, Claudio Freire wrote: It should be if band-thr 0.0f, all divisions by zero return something that casts into an ~1: OK, new patch attached. If band-thr is 0.0f and band-active_lines is not, it takes a bit longer to get to NaN. I assume band-thr 0.0f is not possible? Best

Re: [FFmpeg-devel] [PATCH] aacpsy: avoid norm_fac becoming NaN

2015-04-16 Thread Claudio Freire
On Thu, Apr 16, 2015 at 3:19 PM, Andreas Cadhalpun andreas.cadhal...@googlemail.com wrote: On 16.04.2015 19:41, Claudio Freire wrote: It should be if band-thr 0.0f, all divisions by zero return something that casts into an ~1: OK, new patch attached. If band-thr is 0.0f and

Re: [FFmpeg-devel] [PATCH] avcodec[/format]/webpenc: use WebPAnimEncoder API to generate animated WebP

2015-04-16 Thread Urvang Joshi
Hello Michael, On Thu, Apr 16, 2015 at 5:26 AM Michael Niedermayer michae...@gmx.at wrote: On Thu, Apr 16, 2015 at 12:28:22AM +, Urvang Joshi wrote: Hi, Here's an updated patch that used 'HAVE_WEBP_MUX_H' as you suggested. I also updated the patch to work with the latest libwebp code

Re: [FFmpeg-devel] [PATCH] aacpsy: avoid norm_fac becoming NaN

2015-04-16 Thread Michael Niedermayer
On Thu, Apr 16, 2015 at 03:26:55PM -0300, Claudio Freire wrote: On Thu, Apr 16, 2015 at 3:19 PM, Andreas Cadhalpun andreas.cadhal...@googlemail.com wrote: On 16.04.2015 19:41, Claudio Freire wrote: It should be if band-thr 0.0f, all divisions by zero return something that casts into an

Re: [FFmpeg-devel] [PATCH] avcodec[/format]/webpenc: use WebPAnimEncoder API to generate animated WebP

2015-04-16 Thread Urvang Joshi
Hi Michael, Sorry for my misunderstanding earlier. I was told offline that the usual practice in FFmpeg is to land the non-whitespace diff first, followed by a separate reindent commit. Let me separate out the two and send the non-whitespace diff shortly. On Thu, Apr 16, 2015 at 11:35 AM Urvang