Re: [FFmpeg-devel] [PATCH] lavc: report frame field order in avctx

2016-11-17 Thread Rodger Combs
> On Nov 15, 2016, at 03:43, Michael Niedermayer wrote: > > On Mon, Nov 14, 2016 at 05:19:25PM -0600, Rodger Combs wrote: >> --- >> libavcodec/utils.c | 13 + >> tests/api/api-codec-param-test.c | 3 +++ >> tests/fate/matroska.mak | 2 +- >> tests/re

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mpegvideo: Fix edge emu buffer overlap with interlaced mpeg4

2016-11-17 Thread Michael Niedermayer
On Sat, Nov 12, 2016 at 01:31:54PM +0100, Carl Eugen Hoyos wrote: > 2016-11-12 12:31 GMT+01:00 Michael Niedermayer : > > Fixes Ticket5936 > > Please also mention the relevant original commit. > Was it 60ab6e24574a984655800d1f7ce16c05f4e9b28c? no, added the commit mentioned in the Ticket [...] --

[FFmpeg-devel] [PATCH] ffprobe: fix crash in case -of is specified with an empty string

2016-11-17 Thread Stefano Sabatini
Fix trac issue #5957. --- ffprobe.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/ffprobe.c b/ffprobe.c index a2980b3..79fe296 100644 --- a/ffprobe.c +++ b/ffprobe.c @@ -3311,6 +3311,12 @@ int main(int argc, char **argv) goto end; } w_name = av_strtok(print_format, "

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/mpeg4videodec: Workaround interlaced mpeg4 edge MC bug

2016-11-17 Thread Michael Niedermayer
On Sat, Nov 12, 2016 at 12:31:35PM +0100, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/avcodec.h | 1 + > libavcodec/mpeg4videodec.c| 5 + > libavcodec/mpegvideo.c| 2 ++ > libavcodec/mpegvideo_motion.c | 4 > libavcodec/options_

[FFmpeg-devel] lavc/ffv1: Support YUV4xxP12 and GRAY12.

2016-11-17 Thread Carl Eugen Hoyos
Hi! Attached patch adds support for 12bit formats to ffv1. Please comment, Carl Eugen From c7f3f21a1b6d96717a728c0f0c08de76092fdefb Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Thu, 17 Nov 2016 13:08:27 +0100 Subject: [PATCH] lavc/ffv1: Support YUV4xxP12 and GRAY12. --- libavcodec/ffv

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mpegvideo: Fix edge emu buffer overlap with interlaced mpeg4

2016-11-17 Thread Michael Niedermayer
On Sat, Nov 12, 2016 at 12:31:34PM +0100, Michael Niedermayer wrote: > Fixes Ticket5936 > > Signed-off-by: Michael Niedermayer > --- > libavcodec/mpegpicture.c | 2 +- > libavcodec/mpegvideo.c| 2 +- > libavcodec/mpegvideo_enc.c| 2 +- > libavcodec/mpegvideo_motion.c | 4 ++-- >

Re: [FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

2016-11-17 Thread Rostislav Pehlivanov
On 16 November 2016 at 11:15, Carl Eugen Hoyos wrote: > Hi! > > Attached patch improves output for some ffv1 files imo. > Current slowdown for the existing decode-line timer is > 2%, I wonder if this can be improved through refactoring. > > Please comment, Carl Eugen > > _

Re: [FFmpeg-devel] [PATCH 1/3] hevc: Allow parsing external extradata buffers

2016-11-17 Thread Vittorio Giovara
On Tue, Nov 8, 2016 at 5:03 PM, Vittorio Giovara wrote: > --- > As mentioned in the discussion. > Please CC. > Vittorio > > libavcodec/hevc.c | 12 +--- > 1 file changed, 5 insertions(+), 7 deletions(-) > > diff --git a/libavcodec/hevc.c b/libavcodec/hevc.c > index 29e0d49..02fd606 100644

Re: [FFmpeg-devel] [PATCH 2/3] hevc: Support extradata changes

2016-11-17 Thread Vittorio Giovara
On Tue, Nov 8, 2016 at 5:03 PM, Vittorio Giovara wrote: > Signed-off-by: Vittorio Giovara > --- > Applied review. > Please CC. > Vittorio > > libavcodec/hevc.c | 10 ++ > libavformat/mov.c | 4 > 2 files changed, 10 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/hevc.c b

Re: [FFmpeg-devel] [PATCHv5] mov: Evaluate the movie display matrix

2016-11-17 Thread Vittorio Giovara
On Tue, Nov 15, 2016 at 11:14 AM, Vittorio Giovara wrote: > This matrix needs to be applied after all others have (currently only > display matrix from trak), but cannot be handled in movie box, since > streams are not allocated yet. So store it in main context, and apply > it when appropriate, th

[FFmpeg-devel] [PATCH v2] mov: Export spherical information

2016-11-17 Thread Vittorio Giovara
This implements Spherical Video V1 and V2, as described in the spatial-media collection by Google. Signed-off-by: Vittorio Giovara --- Updated following James' review. Please CC. Vittorio libavformat/isom.h | 7 ++ libavformat/mov.c | 309 -

Re: [FFmpeg-devel] [PATCH 2/2] lavfi: make filter_frame non-recursive.

2016-11-17 Thread Nicolas George
Le quartidi 24 brumaire, an CCXXV, Andreas Cadhalpun a écrit : > It might work at first by accident and then some change in the internal > API could cause problems. > If the API usage is wrong, it should fail at build-time and not introduce > grave security vulnerabilities at run-time. That would

Re: [FFmpeg-devel] [PATCH 2/2] lavfi: make filter_frame non-recursive.

2016-11-17 Thread Nicolas George
Le quartidi 24 brumaire, an CCXXV, Hendrik Leppkes a écrit : > If anything this discussion has shown that there are quite different > priorities for many different developers. > > A key priority for many of us here seems to be to have a clean > separation in public and private fields and keeping t

[FFmpeg-devel] [PATCH] lavfi/af_ebur128: update filter to use new ebur128 API

2016-11-17 Thread Kyle Swanson
Hi, Here's a couple of patches which update the ebur128 filter to use the recently added ebur128 API. This updated filter allows fine-tuned control over which EBU R128 parameters are measured, and provides modest speed increases over the previous ebur128 filter. Also noteworthy: this removes the v

Re: [FFmpeg-devel] [PATCH v2] mov: Export spherical information

2016-11-17 Thread James Almer
On 11/17/2016 12:53 PM, Vittorio Giovara wrote: > This implements Spherical Video V1 and V2, as described in the > spatial-media collection by Google. > > Signed-off-by: Vittorio Giovara > --- > Updated following James' review. > Please CC. > Vittorio > > libavformat/isom.h | 7 ++ > libavfor

Re: [FFmpeg-devel] [PATCHv5] mov: Evaluate the movie display matrix

2016-11-17 Thread James Almer
On 11/15/2016 1:14 PM, Vittorio Giovara wrote: > This matrix needs to be applied after all others have (currently only > display matrix from trak), but cannot be handled in movie box, since > streams are not allocated yet. So store it in main context, and apply > it when appropriate, that is after

Re: [FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

2016-11-17 Thread Kieran Kunhya
On Thu, 17 Nov 2016 at 18:05 Kieran Kunhya wrote: > On Wed, 16 Nov 2016 at 23:49 Kieran Kunhya wrote: > > It was lossless before and is lossless after the patch but it > output the 16bit format that you don't like and of which you > claim it breaks with find_best_pix_fmt() - I still believe this

Re: [FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

2016-11-17 Thread Kieran Kunhya
On Wed, 16 Nov 2016 at 23:49 Kieran Kunhya wrote: > It was lossless before and is lossless after the patch but it > output the 16bit format that you don't like and of which you > claim it breaks with find_best_pix_fmt() - I still believe this > should be trivial to fix. > > Currently white is gra

Re: [FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

2016-11-17 Thread Ronald S. Bultje
Hi, On Thu, Nov 17, 2016 at 1:06 PM, Kieran Kunhya wrote: > On Thu, 17 Nov 2016 at 18:05 Kieran Kunhya wrote: > > > On Wed, 16 Nov 2016 at 23:49 Kieran Kunhya wrote: > > > > It was lossless before and is lossless after the patch but it > > output the 16bit format that you don't like and of whi

Re: [FFmpeg-devel] [PATCH] ffmdec: sanitize codec parameters

2016-11-17 Thread Andreas Cadhalpun
On 17.11.2016 02:26, Michael Niedermayer wrote: > On Thu, Nov 17, 2016 at 01:08:31AM +0100, Andreas Cadhalpun wrote: >> +SANITIZE_PARAMETER(pix_fmt,"pixel format", >> codec->pix_fmt < AV_PIX_FMT_NONE || codec->pix_fmt > AV_PIX_FMT_NB, >> AV_PIX_F

[FFmpeg-devel] [PATCH] options_table: limit codec parameters to sane values

2016-11-17 Thread Andreas Cadhalpun
Signed-off-by: Andreas Cadhalpun --- libavcodec/options_table.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/libavcodec/options_table.h b/libavcodec/options_table.h index ba5297c..f55eb48 100644 --- a/libavcodec/options_table.h +++ b/libavcodec/options_table.

Re: [FFmpeg-devel] [PATCH 1/2] avformat/matroskaenc: postpone writing the Tracks master

2016-11-17 Thread James Almer
On 11/2/2016 4:58 PM, James Almer wrote: > This will allow us to write updated stream information not available > during write_header(). > > Signed-off-by: James Almer > --- > libavformat/matroskaenc.c | 20 +++- > 1 file changed, 15 insertions(+), 5 deletions(-) > Ping for pat

Re: [FFmpeg-devel] [PATCH] ffprobe: fix crash in case -of is specified with an empty string

2016-11-17 Thread Andreas Cadhalpun
On 17.11.2016 12:12, Stefano Sabatini wrote: > Fix trac issue #5957. > --- > ffprobe.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/ffprobe.c b/ffprobe.c > index a2980b3..79fe296 100644 > --- a/ffprobe.c > +++ b/ffprobe.c > @@ -3311,6 +3311,12 @@ int main(int argc, char **argv)

Re: [FFmpeg-devel] [PATCHv5] mov: Evaluate the movie display matrix

2016-11-17 Thread Vittorio Giovara
On Thu, Nov 17, 2016 at 1:02 PM, James Almer wrote: > On 11/15/2016 1:14 PM, Vittorio Giovara wrote: >> diff --git a/tests/ref/fate/mov-displaymatrix >> b/tests/ref/fate/mov-displaymatrix >> new file mode 100644 >> index 000..52528c1 >> --- /dev/null >> +++ b/tests/ref/fate/mov-displaymatrix

Re: [FFmpeg-devel] [PATCH] lavfi/af_ebur128: update filter to use new ebur128 API

2016-11-17 Thread Clément Bœsch
On Thu, Nov 17, 2016 at 11:04:46AM -0600, Kyle Swanson wrote: > Hi, > > Here's a couple of patches which update the ebur128 filter to use the > recently added ebur128 API. This updated filter allows fine-tuned > control over which EBU R128 parameters are measured, and provides > modest speed incre

Re: [FFmpeg-devel] [PATCH 2/2] lavfi: make filter_frame non-recursive.

2016-11-17 Thread Andreas Cadhalpun
On 17.11.2016 17:27, Nicolas George wrote: > Le quartidi 24 brumaire, an CCXXV, Andreas Cadhalpun a écrit : >> API changes in libavfilter are less of a problem, since not that many >> programs use it. For example, the codecpar change has orders of magnitude >> more impact. > > I mostly agree. If p

Re: [FFmpeg-devel] [PATCH] ffprobe: fix crash in case -of is specified with an empty string

2016-11-17 Thread Stefano Sabatini
On date Thursday 2016-11-17 19:57:13 +0100, Andreas Cadhalpun encoded: > On 17.11.2016 12:12, Stefano Sabatini wrote: > > Fix trac issue #5957. > > --- > > ffprobe.c | 6 ++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/ffprobe.c b/ffprobe.c > > index a2980b3..79fe296 100644 > > --

Re: [FFmpeg-devel] [PATCH] doc/bsfs: various improvements

2016-11-17 Thread Lou Logan
On Wed, 16 Nov 2016 00:11:50 +0100, Moritz Barsnick wrote: > I couldn't wrap my head around some of the filters. Sometimes, no other > mention is even found on the web (incl. mailing lists) except for e.g. > quotes of the sources. (I did try to reverse-engineer the sources > carefully.) I reckoned

Re: [FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

2016-11-17 Thread Carl Eugen Hoyos
2016-11-17 19:06 GMT+01:00 Kieran Kunhya : > On Thu, 17 Nov 2016 at 18:05 Kieran Kunhya wrote: > Furthermore I will be reverting this patch in two hours. Please do not revert a patch reviewed by the maintainer. Carl Eugen ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

2016-11-17 Thread Carl Eugen Hoyos
2016-11-17 14:49 GMT+01:00 Rostislav Pehlivanov : > On 16 November 2016 at 11:15, Carl Eugen Hoyos wrote: > >> Hi! >> >> Attached patch improves output for some ffv1 files imo. >> Current slowdown for the existing decode-line timer is >> 2%, I wonder if this can be improved through refactoring. >>

Re: [FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

2016-11-17 Thread Carl Eugen Hoyos
2016-11-17 0:49 GMT+01:00 Kieran Kunhya : >> >> It was lossless before and is lossless after the patch but it >> output the 16bit format that you don't like and of which you >> claim it breaks with find_best_pix_fmt() - I still believe this >> should be trivial to fix. >> >> Currently white is gray

Re: [FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

2016-11-17 Thread Carl Eugen Hoyos
Hi! 2016-11-17 19:34 GMT+01:00 Ronald S. Bultje : > > On Thu, Nov 17, 2016 at 1:06 PM, Kieran Kunhya wrote: >> Furthermore I will be reverting this patch in two hours. > > There's no need to wait two hours, the patch is fundamentally wrong. This is not a helpful comment. > Carl, the reason the

Re: [FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

2016-11-17 Thread Carl Eugen Hoyos
2016-11-16 15:02 GMT+01:00 Michael Niedermayer : > On Wed, Nov 16, 2016 at 12:15:28PM +0100, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch improves output for some ffv1 files imo. >> Current slowdown for the existing decode-line timer is >> 2%, I wonder if this can be improved through refacto

[FFmpeg-devel] libavcodec/exr : add support for uint32 channel decoding with pxr24

2016-11-17 Thread Martin Vignali
Hello, In attach a patch, who fix the decoding of half (or float) layer with pxr24 compression, when there is also an uint32 layer. The uint32 layer is still not decodable. Found by Andreas Cadhalpun sample can be found here : https://we.tl/ULGDVxQXGy Comments welcome Martin From c70a83c38cd

Re: [FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

2016-11-17 Thread wm4
On Thu, 17 Nov 2016 21:06:33 +0100 Carl Eugen Hoyos wrote: > 2016-11-17 19:06 GMT+01:00 Kieran Kunhya : > > On Thu, 17 Nov 2016 at 18:05 Kieran Kunhya wrote: > > > Furthermore I will be reverting this patch in two hours. > > Please do not revert a patch reviewed by the maintainer. "probab

Re: [FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

2016-11-17 Thread wm4
On Thu, 17 Nov 2016 21:10:34 +0100 Carl Eugen Hoyos wrote: > Hi! > > 2016-11-17 19:34 GMT+01:00 Ronald S. Bultje : > > > > On Thu, Nov 17, 2016 at 1:06 PM, Kieran Kunhya wrote: > > >> Furthermore I will be reverting this patch in two hours. > > > > There's no need to wait two hours, the pa

Re: [FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

2016-11-17 Thread wm4
On Thu, 17 Nov 2016 21:16:13 +0100 Carl Eugen Hoyos wrote: > 2016-11-17 0:49 GMT+01:00 Kieran Kunhya : > >> > >> It was lossless before and is lossless after the patch but it > >> output the 16bit format that you don't like and of which you > >> claim it breaks with find_best_pix_fmt() - I still

[FFmpeg-devel] Fate/exr : add test for PXR24 with half and uint32

2016-11-17 Thread Martin Vignali
Hello, in attach a patch to add a fate test for pxr24 with half and uint32 layer Need to be apply after the patch in discussion : libavcodec/exr : add support for uint32 channel decoding with pxr24 Relative to discussions about the crash with half/uint32 exr file exr: limit expected_len to tmp

Re: [FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

2016-11-17 Thread James Almer
On 11/17/2016 5:11 PM, Carl Eugen Hoyos wrote: > 2016-11-16 15:02 GMT+01:00 Michael Niedermayer : >> On Wed, Nov 16, 2016 at 12:15:28PM +0100, Carl Eugen Hoyos wrote: >>> Hi! >>> >>> Attached patch improves output for some ffv1 files imo. >>> Current slowdown for the existing decode-line timer is >

Re: [FFmpeg-devel] Building with all threading disabled still results in avutil-55.dll dependency on pthreadGC-3.dll

2016-11-17 Thread Gregory J Wolfe
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On > Behalf Of Gregory J Wolfe > Sent: Thursday, November 17, 2016 2:10 PM > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] Building with all threading disabled still results > in avutil-55.dll depende

Re: [FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

2016-11-17 Thread Ronald S. Bultje
Hi Carl, On Thu, Nov 17, 2016 at 3:10 PM, Carl Eugen Hoyos wrote: > 2016-11-17 19:34 GMT+01:00 Ronald S. Bultje : > > Carl, the reason the patch is wrong is that luma range does not scale up > > from 16< > This is documented in numerous places, see e.g. > > https://msdn.microsoft.com/en-us/libra

Re: [FFmpeg-devel] [PATCH] vf_colorspace: Forbid odd dimensions

2016-11-17 Thread Ronald S. Bultje
Hi, On Thu, Nov 17, 2016 at 3:53 PM, Vittorio Giovara < vittorio.giov...@gmail.com> wrote: > This prevents writing past bounds. > > Signed-off-by: Vittorio Giovara > --- > Any opinions about this? Hm... I agree right now it's probably broken, but I'd argue that we should fix it, not forbid it.

Re: [FFmpeg-devel] [PATCH] vf_colorspace: Forbid odd dimensions

2016-11-17 Thread Vittorio Giovara
On Thu, Nov 17, 2016 at 3:58 PM, Ronald S. Bultje wrote: > Hi, > > On Thu, Nov 17, 2016 at 3:53 PM, Vittorio Giovara > wrote: >> >> This prevents writing past bounds. >> >> Signed-off-by: Vittorio Giovara >> --- >> Any opinions about this? > > > Hm... I agree right now it's probably broken, but

[FFmpeg-devel] [PATCH] vf_colorspace: Forbid odd dimensions

2016-11-17 Thread Vittorio Giovara
This prevents writing past bounds. Signed-off-by: Vittorio Giovara --- Any opinions about this? Cheers, Vittorio (please cc) doc/filters.texi| 1 + libavfilter/vf_colorspace.c | 8 +++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.

Re: [FFmpeg-devel] [PATCHv2] vf_colorspace: Forbid odd dimensions

2016-11-17 Thread Ronald S. Bultje
Hi, On Thu, Nov 17, 2016 at 4:09 PM, Vittorio Giovara < vittorio.giov...@gmail.com> wrote: > This prevents writing past bounds. > > Signed-off-by: Vittorio Giovara > --- > Updated according review. > Vittorio > > doc/filters.texi| 1 + > libavfilter/vf_colorspace.c | 9 - >

Re: [FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

2016-11-17 Thread Michael Niedermayer
On Thu, Nov 17, 2016 at 09:13:55PM +0100, Carl Eugen Hoyos wrote: > 2016-11-17 14:49 GMT+01:00 Rostislav Pehlivanov : > > On 16 November 2016 at 11:15, Carl Eugen Hoyos wrote: > > > >> Hi! > >> > >> Attached patch improves output for some ffv1 files imo. > >> Current slowdown for the existing deco

Re: [FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

2016-11-17 Thread Ronald S. Bultje
Hi, On Thu, Nov 17, 2016 at 4:11 PM, Michael Niedermayer wrote: > On Thu, Nov 17, 2016 at 09:13:55PM +0100, Carl Eugen Hoyos wrote: > > 2016-11-17 14:49 GMT+01:00 Rostislav Pehlivanov : > > > On 16 November 2016 at 11:15, Carl Eugen Hoyos > wrote: > > > > > >> Hi! > > >> > > >> Attached patch i

[FFmpeg-devel] [PATCHv2] vf_colorspace: Forbid odd dimensions

2016-11-17 Thread Vittorio Giovara
This prevents writing past bounds. Signed-off-by: Vittorio Giovara --- Updated according review. Vittorio doc/filters.texi| 1 + libavfilter/vf_colorspace.c | 9 - 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index 208be42

Re: [FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

2016-11-17 Thread Paul B Mahol
On 11/17/16, Michael Niedermayer wrote: > On Thu, Nov 17, 2016 at 09:13:55PM +0100, Carl Eugen Hoyos wrote: >> 2016-11-17 14:49 GMT+01:00 Rostislav Pehlivanov : >> > On 16 November 2016 at 11:15, Carl Eugen Hoyos >> > wrote: >> > >> >> Hi! >> >> >> >> Attached patch improves output for some ffv1

[FFmpeg-devel] [PATCH] ffplay: allow fallback to software renderer

2016-11-17 Thread Marton Balint
Signed-off-by: Marton Balint --- ffplay.c | 4 1 file changed, 4 insertions(+) diff --git a/ffplay.c b/ffplay.c index 12502f2..63c0e19 100644 --- a/ffplay.c +++ b/ffplay.c @@ -1282,6 +1282,10 @@ static int video_open(VideoState *is, Frame *vp) if (window) { SDL_Rendere

Re: [FFmpeg-devel] [PATCH] ffplay: allow fallback to software renderer

2016-11-17 Thread Josh de Kock
On 17/11/2016 21:18, Marton Balint wrote: Signed-off-by: Marton Balint --- ffplay.c | 4 1 file changed, 4 insertions(+) diff --git a/ffplay.c b/ffplay.c index 12502f2..63c0e19 100644 --- a/ffplay.c +++ b/ffplay.c @@ -1282,6 +1282,10 @@ static int video_open(VideoState *is, Frame *vp)

[FFmpeg-devel] [PATCH] rmdec: validate block alignment

2016-11-17 Thread Andreas Cadhalpun
This fixes division by zero crashes. Signed-off-by: Andreas Cadhalpun --- libavformat/rmdec.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/rmdec.c b/libavformat/rmdec.c index d175862..4d56529 100644 --- a/libavformat/rmdec.c +++ b/libavformat/rmdec.c @@ -934,6 +934,10 @@ f

[FFmpeg-devel] [PATCH] mxfdec: fix NULL pointer dereference in mxf_read_packet_old

2016-11-17 Thread Andreas Cadhalpun
Metadata streams have priv_data set to NULL. Signed-off-by: Andreas Cadhalpun --- libavformat/mxfdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index a1a79ce..2ad0c28 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec

Re: [FFmpeg-devel] [PATCHv2] vf_colorspace: Forbid odd dimensions

2016-11-17 Thread Vittorio Giovara
On Thu, Nov 17, 2016 at 4:11 PM, Ronald S. Bultje wrote: > Hi, > > On Thu, Nov 17, 2016 at 4:09 PM, Vittorio Giovara > wrote: >> >> This prevents writing past bounds. >> >> Signed-off-by: Vittorio Giovara >> --- >> Updated according review. >> Vittorio >> >> doc/filters.texi| 1 + >>

Re: [FFmpeg-devel] [PATCHv2] vf_colorspace: Forbid odd dimensions

2016-11-17 Thread Ronald S. Bultje
Hi, On Thu, Nov 17, 2016 at 5:02 PM, Vittorio Giovara < vittorio.giov...@gmail.com> wrote: > On Thu, Nov 17, 2016 at 4:11 PM, Ronald S. Bultje > wrote: > > Hi, > > > > On Thu, Nov 17, 2016 at 4:09 PM, Vittorio Giovara > > wrote: > >> > >> This prevents writing past bounds. > >> > >> Signed-off-

Re: [FFmpeg-devel] [PATCH] ffmpeg: remove dead code out of the video filter loop

2016-11-17 Thread Clément Bœsch
On Tue, Nov 01, 2016 at 10:53:40AM +0100, Clément Bœsch wrote: > It makes no sense for this code to be inside the video filter loop, and > the frame sample aspect ratio is even set unconditionally a few lines > above. > --- > ffmpeg.c | 5 - > 1 file changed, 5 deletions(-) > > diff --git a/f

Re: [FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

2016-11-17 Thread Hendrik Leppkes
Am 17.11.2016 22:16 schrieb "Paul B Mahol" : > > On 11/17/16, Michael Niedermayer wrote: > > On Thu, Nov 17, 2016 at 09:13:55PM +0100, Carl Eugen Hoyos wrote: > >> 2016-11-17 14:49 GMT+01:00 Rostislav Pehlivanov : > >> > On 16 November 2016 at 11:15, Carl Eugen Hoyos > >> > wrote: > >> > > >> >>

Re: [FFmpeg-devel] Building with all threading disabled still results in avutil-55.dll dependency on pthreadGC-3.dll

2016-11-17 Thread Gregory J Wolfe
> > -Original Message- > > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] > On > > Behalf Of Gregory J Wolfe > > Sent: Thursday, November 17, 2016 2:10 PM > > To: ffmpeg-devel@ffmpeg.org > > Subject: [FFmpeg-devel] Building with all threading disabled still > results > > in avu

[FFmpeg-devel] [PATCH 1/2] avcodec/ffv1dec: Support gray 10/12/16 explicitly avoid shifts

2016-11-17 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/ffv1dec.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/libavcodec/ffv1dec.c b/libavcodec/ffv1dec.c index 0719e28..b5fb825 100644 --- a/libavcodec/ffv1dec.c +++ b/libavcodec/ffv1dec.c @@ -575,8 +575,19 @@ static

[FFmpeg-devel] [PATCH 2/2] avcodec/ffv1dec: Set packed_at_lsb for 16bit YUV

2016-11-17 Thread Michael Niedermayer
This avoids unneeded computations Signed-off-by: Michael Niedermayer --- libavcodec/ffv1dec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/ffv1dec.c b/libavcodec/ffv1dec.c index b5fb825..358da17 100644 --- a/libavcodec/ffv1dec.c +++ b/libavcodec/ffv1dec.c @@ -637,12 +637,14 @

Re: [FFmpeg-devel] [PATCH] ffmpeg: remove dead code out of the video filter loop

2016-11-17 Thread Andreas Cadhalpun
On 17.11.2016 23:12, Clément Bœsch wrote: > On Tue, Nov 01, 2016 at 10:53:40AM +0100, Clément Bœsch wrote: >> It makes no sense for this code to be inside the video filter loop, and >> the frame sample aspect ratio is even set unconditionally a few lines >> above. >> --- >> ffmpeg.c | 5 - >>

Re: [FFmpeg-devel] [PATCH] avformat/apngenc: use the stream parameters extradata if no updated one is made available

2016-11-17 Thread James Almer
On 11/1/2016 12:54 PM, Andreas Cadhalpun wrote: > On 01.11.2016 05:09, James Almer wrote: >> On 10/31/2016 11:32 PM, James Almer wrote: >>> Fixes remuxing apng streams coming from the apng demuxer. >>> This is a regression since 97792e85c338d129342f5812e2a52048373e57d6. >>> >>> Signed-off-by: James

[FFmpeg-devel] [PATCH 1/2] avcodec/ffv1dec: Set packed_at_lsb for 16bit YUV

2016-11-17 Thread Michael Niedermayer
This avoids unneeded computations Signed-off-by: Michael Niedermayer --- libavcodec/ffv1dec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/ffv1dec.c b/libavcodec/ffv1dec.c index b5fb825..358da17 100644 --- a/libavcodec/ffv1dec.c +++ b/libavcodec/ffv1dec.c @@ -637,12 +637,14 @

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/ffv1dec: Set packed_at_lsb for 16bit YUV

2016-11-17 Thread Michael Niedermayer
On Fri, Nov 18, 2016 at 01:10:43AM +0100, Michael Niedermayer wrote: > This avoids unneeded computations > > Signed-off-by: Michael Niedermayer > --- > libavcodec/ffv1dec.c | 2 ++ > 1 file changed, 2 insertions(+) please disregard this patch, it was sent twice by mistake [...] -- Michael

Re: [FFmpeg-devel] [PATCH] lavc: report frame field order in avctx

2016-11-17 Thread Michael Niedermayer
On Thu, Nov 17, 2016 at 04:48:07AM -0600, Rodger Combs wrote: > > > On Nov 15, 2016, at 03:43, Michael Niedermayer > > wrote: > > > > On Mon, Nov 14, 2016 at 05:19:25PM -0600, Rodger Combs wrote: > >> --- > >> libavcodec/utils.c | 13 + > >> tests/api/api-codec-para

Re: [FFmpeg-devel] [PATCH] lavfi/af_ebur128: update filter to use new ebur128 API

2016-11-17 Thread Michael Niedermayer
On Thu, Nov 17, 2016 at 11:04:46AM -0600, Kyle Swanson wrote: > Hi, > > Here's a couple of patches which update the ebur128 filter to use the > recently added ebur128 API. This updated filter allows fine-tuned > control over which EBU R128 parameters are measured, and provides > modest speed incre

Re: [FFmpeg-devel] [PATCH] lavfi/af_ebur128: update filter to use new ebur128 API

2016-11-17 Thread Kyle Swanson
On Thu, Nov 17, 2016 at 6:55 PM, Michael Niedermayer wrote: > On Thu, Nov 17, 2016 at 11:04:46AM -0600, Kyle Swanson wrote: >> Hi, >> >> Here's a couple of patches which update the ebur128 filter to use the >> recently added ebur128 API. This updated filter allows fine-tuned >> control over which

Re: [FFmpeg-devel] [PATCH] lavfi/af_ebur128: update filter to use new ebur128 API

2016-11-17 Thread Kyle Swanson
On Thu, Nov 17, 2016 at 11:04 AM, Kyle Swanson wrote: > Hi, > > Here's a couple of patches which update the ebur128 filter to use the > recently added ebur128 API. This updated filter allows fine-tuned > control over which EBU R128 parameters are measured, and provides > modest speed increases ove

Re: [FFmpeg-devel] [PATCH] ffmdec: sanitize codec parameters

2016-11-17 Thread Michael Niedermayer
On Thu, Nov 17, 2016 at 07:35:01PM +0100, Andreas Cadhalpun wrote: > On 17.11.2016 02:26, Michael Niedermayer wrote: > > On Thu, Nov 17, 2016 at 01:08:31AM +0100, Andreas Cadhalpun wrote: > >> +SANITIZE_PARAMETER(pix_fmt,"pixel format", > >> codec->pix_fmt <

Re: [FFmpeg-devel] [PATCH] rmdec: validate block alignment

2016-11-17 Thread Michael Niedermayer
On Thu, Nov 17, 2016 at 10:52:30PM +0100, Andreas Cadhalpun wrote: > This fixes division by zero crashes. > > Signed-off-by: Andreas Cadhalpun > --- > libavformat/rmdec.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/libavformat/rmdec.c b/libavformat/rmdec.c > index d175862..4d56

Re: [FFmpeg-devel] [PATCH] options_table: limit codec parameters to sane values

2016-11-17 Thread Michael Niedermayer
On Thu, Nov 17, 2016 at 07:37:13PM +0100, Andreas Cadhalpun wrote: > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/options_table.h | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/libavcodec/options_table.h b/libavcodec/options_table.h > index ba5297c

Re: [FFmpeg-devel] Fate/exr : add test for PXR24 with half and uint32

2016-11-17 Thread Michael Niedermayer
On Thu, Nov 17, 2016 at 09:35:03PM +0100, Martin Vignali wrote: > Hello, > > in attach a patch to add a fate test for pxr24 with half and uint32 layer > > Need to be apply after the patch in discussion : > libavcodec/exr : add support for uint32 channel decoding with pxr24 > > > Relative to dis

Re: [FFmpeg-devel] [PATCH 1/2] Add experimental muxing support for FLAC in ISO BMFF (MP4).

2016-11-17 Thread James Almer
On 11/1/2016 8:21 PM, Matthew Gregan wrote: > At 2016-11-01T00:56:45-0300, James Almer wrote: >> > The muxer gets the extradata as created by the encoder only during init(). >> > Even if the encoder changes it in any way afterwards, it will never make >> > it to the muxer. That's why packet side da

Re: [FFmpeg-devel] [PATCH 1/2] Add experimental muxing support for FLAC in ISO BMFF (MP4).

2016-11-17 Thread Matthew Gregan
At 2016-11-17T22:57:49-0300, James Almer wrote: > > @@ -345,6 +346,7 @@ const AVCodecTag ff_codec_movaudio_tags[] = { > > +{ AV_CODEC_ID_FLAC,MKTAG('f', 'L', 'a', 'C') }, /* > > nonstandard */ > > This is enables muxing into mov, which bypasses the experimental check below > since

[FFmpeg-devel] [PATCH] Restrict experimental VP9 support to MODE_MP4.

2016-11-17 Thread Matthew Gregan
Without this, it's possible to mux VP9 into MOV without passing -strict -2. This tightens the check to restrict VP9 to MODE_MP4 only. Based on the discussion with James Almer on the experimental FLAC in MP4 muxing patch. >From 47f74ca9269d2bddccd9d273d6739798f9bfd0b7 Mon Sep 17 00:00:00 2001 From: