Re: [FFmpeg-devel] [PATCH 1/2] wmavoice: truncate spillover_nbits if too large

2017-01-01 Thread Ronald S. Bultje
Hi, On Sun, Jan 1, 2017 at 5:18 PM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > This fixes triggering the av_assert0(ret <= tmp.size). > > The problem was reintroduced by commit > 7b27dd5c16de785297ce4de4b88afa0b6685f61d and originally fixed by >

[FFmpeg-devel] [PATCH 1/2] wmavoice: truncate spillover_nbits if too large

2017-01-01 Thread Andreas Cadhalpun
This fixes triggering the av_assert0(ret <= tmp.size). The problem was reintroduced by commit 7b27dd5c16de785297ce4de4b88afa0b6685f61d and originally fixed by 2a4700a4f03280fa8ba4fc0f8a9987bb550f0d1e. Signed-off-by: Andreas Cadhalpun --- libavcodec/wmavoice.c

Re: [FFmpeg-devel] [PATCH 2/2] wmavoice: prevent division by zero crash

2017-01-01 Thread Andreas Cadhalpun
On 01.01.2017 23:23, Ronald S. Bultje wrote: > On Sun, Jan 1, 2017 at 5:19 PM, Andreas Cadhalpun > > > wrote: > > The problem was introduced by commit > 3deb4b54a24f8cddce463d9f5751b01efeb976af. > >

[FFmpeg-devel] [PATCHv2 3/3] avfilter/formats: do not allow unknown layouts in ff_parse_channel_layout if nret is not set

2017-01-01 Thread Marton Balint
Current code returned the number of channels as channel layout in that case, and if nret is not set then unknown layouts are typically not supported. Also use the common parsing code. Use a temporary workaround to parse an unknown channel layout such as '13c', after a 1 year grace period only

Re: [FFmpeg-devel] [PATCH 1/2] wmavoice: truncate spillover_nbits if too large

2017-01-01 Thread Andreas Cadhalpun
On 01.01.2017 23:27, Ronald S. Bultje wrote: > On Sun, Jan 1, 2017 at 5:18 PM, Andreas Cadhalpun > > > wrote: > > This fixes triggering the av_assert0(ret <= tmp.size). > > The problem was reintroduced by commit

Re: [FFmpeg-devel] [PATCH] doc/hlsenc: hls_segment_filename, use_localtime, , use_localtime_mkdir, hls_flags

2017-01-01 Thread Bodecs Bela
2017.01.02. 0:12 keltezéssel, Steven Liu írta: 2017-01-02 5:53 GMT+08:00 Bodecs Bela : Dear All, I added some more details and example to hls muxer documentation. I reformatted hls_flags option list to table. Where is the patch? I am sorry. I have atteched it now,

Re: [FFmpeg-devel] [PATCH] doc/hlsenc: hls_segment_filename, use_localtime, , use_localtime_mkdir, hls_flags

2017-01-01 Thread Steven Liu
2017-01-02 7:22 GMT+08:00 Bodecs Bela : > > > 2017.01.02. 0:12 keltezéssel, Steven Liu írta: > >> 2017-01-02 5:53 GMT+08:00 Bodecs Bela : >> >> Dear All, >>> >>> I added some more details and example to hls muxer documentation. I >>> reformatted hls_flags

[FFmpeg-devel] [PATCH] avformat/rtmphttp: fix bug for rtmphttp

2017-01-01 Thread Steven Liu
if the http server don't response the http command, then the thread will be blocked and never be interrupted. Reported-by: yinyunjiang Signed-off-by: Steven Liu --- libavformat/rtmphttp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [FFmpeg-devel] [PATCH 2/2] wmavoice: prevent division by zero crash

2017-01-01 Thread Ronald S. Bultje
Hi, On Sun, Jan 1, 2017 at 5:19 PM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > The problem was introduced by commit > 3deb4b54a24f8cddce463d9f5751b01efeb976af. > > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/wmavoice.c | 2 +- > 1

Re: [FFmpeg-devel] [PATCH 1/2] wmavoice: truncate spillover_nbits if too large

2017-01-01 Thread Ronald S. Bultje
Hi, On Sun, Jan 1, 2017 at 5:55 PM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > On 01.01.2017 23:27, Ronald S. Bultje wrote: > > On Sun, Jan 1, 2017 at 5:18 PM, Andreas Cadhalpun < > andreas.cadhal...@googlemail.com > > wrote: > > > >

[FFmpeg-devel] [PATCH 2/2] wmavoice: prevent division by zero crash

2017-01-01 Thread Andreas Cadhalpun
The problem was introduced by commit 3deb4b54a24f8cddce463d9f5751b01efeb976af. Signed-off-by: Andreas Cadhalpun --- libavcodec/wmavoice.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/wmavoice.c b/libavcodec/wmavoice.c index

Re: [FFmpeg-devel] PATCH for building with nasm

2017-01-01 Thread John Comeau
On Sun, Jan 1, 2017 at 11:08 AM, Carl Eugen Hoyos wrote: > 2017-01-01 17:02 GMT+01:00 John Comeau : >> nasm version 2.11.05, which is current in Debian stable. I could use >> 2.12.01 from sid, but should that be a requirement? > > I thought 2.11 has more

Re: [FFmpeg-devel] [PATCH] doc/hlsenc: hls_segment_filename, use_localtime, , use_localtime_mkdir, hls_flags

2017-01-01 Thread Steven Liu
2017-01-02 5:53 GMT+08:00 Bodecs Bela : > Dear All, > > I added some more details and example to hls muxer documentation. I > reformatted hls_flags option list to table. > Where is the patch? > > > thank you, > > Bela Bodecs > > >

[FFmpeg-devel] [PATCH] lavc/cuvid: fail early if GPU can't handle given video resolution

2017-01-01 Thread pkoshevoy
From: Pavel Koshevoy NVDEC (CUVID) does not support unlimited video resolutions, so if the resolution of the source is known it can be used during avcodec_open2 call to fail early, rather than failing later during avcodec_send_packet call. This problem surfaced when trying

Re: [FFmpeg-devel] PATCH for building with nasm

2017-01-01 Thread Michael Niedermayer
On Sun, Jan 01, 2017 at 08:16:00AM +, Rostislav Pehlivanov wrote: > On 1 January 2017 at 07:52, John Comeau wrote: > > > fixes `operation size not specified` errors as described here: > > http://stackoverflow.com/questions/36854583/compiling- > > ffmpeg-for-kali-linux-2 >

Re: [FFmpeg-devel] [PATCH] avutil/tests: added selftest for aes_ctr.c

2017-01-01 Thread Michael Niedermayer
On Sun, Jan 01, 2017 at 12:17:58PM -0800, Thomas Turner wrote: > Signed-off-by: Thomas Turner > --- > libavutil/Makefile| 1 + > libavutil/tests/aes_ctr.c | 65 > +++ > tests/fate/libavutil.mak | 5 > 3 files

Re: [FFmpeg-devel] [PATCH 2/2] wmavoice: prevent division by zero crash

2017-01-01 Thread Ronald S. Bultje
Hi, On Sun, Jan 1, 2017 at 5:51 PM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > On 01.01.2017 23:23, Ronald S. Bultje wrote: > > On Sun, Jan 1, 2017 at 5:19 PM, Andreas Cadhalpun < > andreas.cadhal...@googlemail.com > > wrote: > > > >

[FFmpeg-devel] [PATCH] avutil/tests: added selftest for aes_ctr.c

2017-01-01 Thread Thomas Turner
Signed-off-by: Thomas Turner --- libavutil/Makefile| 1 + libavutil/tests/aes_ctr.c | 65 +++ tests/fate/libavutil.mak | 5 3 files changed, 71 insertions(+) create mode 100644 libavutil/tests/aes_ctr.c diff

[FFmpeg-devel] [PATCH] doc/hlsenc: hls_segment_filename, use_localtime, , use_localtime_mkdir, hls_flags

2017-01-01 Thread Bodecs Bela
Dear All, I added some more details and example to hls muxer documentation. I reformatted hls_flags option list to table. thank you, Bela Bodecs ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] lavfi/af_ebur128: update filter to use new ebur128 API

2017-01-01 Thread Marton Balint
On Sun, 1 Jan 2017, Kyle Swanson wrote: On Wed, Dec 28, 2016 at 9:51 AM, Kyle Swanson wrote: Finally had a minute to look at this again. Attached patch addresses Michael's and Marton's comments. If no one has anything else, I'll push this in the next couple of days. Hi,

[FFmpeg-devel] [PATCH] avcodec/texturedspenc: Fix indexing in color distribution determination

2017-01-01 Thread Michael Niedermayer
Fixes CID1396405 Untested except fate which does not test this, please someone test this Signed-off-by: Michael Niedermayer --- libavcodec/texturedspenc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/texturedspenc.c

Re: [FFmpeg-devel] [PATCH] avcodec/texturedspenc: Fix indexing in color distribution determination

2017-01-01 Thread James Almer
On 1/1/2017 8:28 PM, Michael Niedermayer wrote: > Fixes CID1396405 > > Untested except fate which does not test this, please someone test this The encoder seems to need libsnappy, so no FATE test can be added. CCing Vittorio since he wrote this. He may be able to test and/or review. > >

Re: [FFmpeg-devel] [PATCH 3/3] avfilter/formats: do not allow unknown layouts in ff_parse_channel_layout if nret is not set

2017-01-01 Thread Marton Balint
On Sat, 31 Dec 2016, Nicolas George wrote: Le sextidi 6 nivôse, an CCXXV, Marton Balint a écrit : Current code returned the number of channels as channel layout in that case, and if nret is not set then unknown layouts are typically not supported. Good catch. Let me see if I got this

Re: [FFmpeg-devel] PATCH for building with nasm

2017-01-01 Thread Rostislav Pehlivanov
On 1 January 2017 at 07:52, John Comeau wrote: > fixes `operation size not specified` errors as described here: > http://stackoverflow.com/questions/36854583/compiling- > ffmpeg-for-kali-linux-2 > > I rebuilt again with yasm and made sure it didn't break that. > -- > John

[FFmpeg-devel] [PATCH] avformat/hlsenc: Duplicated segment filenames and use_localtime_mkdir

2017-01-01 Thread Bodecs Bela
Dear All, current implementation of finding duplicated segment filenames may fail if use_localtime_mkdir and use_localtime are in effect and segment_filename option expression contains subdirectories with date/time specifiers in them. This patch fixes this false behaviour. thank you, Bela

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: Duplicated segment filenames and use_localtime_mkdir

2017-01-01 Thread Steven Liu
2017-01-01 19:40 GMT+08:00 Bodecs Bela : > Dear All, > > current implementation of finding duplicated segment filenames may fail if > use_localtime_mkdir and use_localtime are in effect and segment_filename > option expression contains subdirectories with date/time specifiers

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: Duplicated segment filenames and use_localtime_mkdir

2017-01-01 Thread Steven Liu
2017-01-01 21:01 GMT+08:00 Marton Balint : > > On Sun, 1 Jan 2017, Steven Liu wrote: > > >> applied! >> >> > Steven, any reason you are overriding the "committer" field? I think what > people typically do when pushing patches is that they only keep the > authorship of the original

[FFmpeg-devel] [PATCH]lavc/mjpegdec: Do not overread too short JFIF tag

2017-01-01 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket #6055 for me. Please comment, Carl Eugen From 3a9e911de8c5a4cf7748fa814e66b2e775778bfa Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sun, 1 Jan 2017 14:19:48 +0100 Subject: [PATCH] lavc/mjpegdec: Do not overread too short JFIF tags.

Re: [FFmpeg-devel] [PATCH] avutil/tests: Added selftest for aes_ctr.c

2017-01-01 Thread Michael Niedermayer
On Fri, Dec 30, 2016 at 01:36:35AM -0800, Thomas Turner wrote: > Signed-off-by: Thomas Turner > --- > libavutil/Makefile| 1 + > libavutil/tests/aes_ctr.c | 70 > +++ > tests/fate/libavutil.mak | 5 > 3 files

Re: [FFmpeg-devel] [PATCH] NVENC: Round qpIntra and qpInter calculation

2017-01-01 Thread Timo Rothenpieler
applied ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: Duplicated segment filenames and use_localtime_mkdir

2017-01-01 Thread Marton Balint
On Sun, 1 Jan 2017, Steven Liu wrote: applied! Steven, any reason you are overriding the "committer" field? I think what people typically do when pushing patches is that they only keep the authorship of the original owner, and the comitter remains the person who actually pushes the

Re: [FFmpeg-devel] [PATCH 3/9] ffplay: use buffersink accessors.

2017-01-01 Thread Marton Balint
On Sat, 31 Dec 2016, Nicolas George wrote: Le septidi 7 nivôse, an CCXXV, Nicolas George a écrit : Signed-off-by: Nicolas George --- ffplay.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) Ping for that patch. LGTM, thanks. Marton.

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: Duplicated segment filenames and use_localtime_mkdir

2017-01-01 Thread Steven Liu
2017-01-01 21:22 GMT+08:00 Steven Liu : > > > 2017-01-01 21:01 GMT+08:00 Marton Balint : > >> >> On Sun, 1 Jan 2017, Steven Liu wrote: >> >> >>> applied! >>> >>> >> Steven, any reason you are overriding the "committer" field? I think what >> people

Re: [FFmpeg-devel] [PATCH] nvenc: Make AUD optional for h264_nvenc and hevc_nvenc

2017-01-01 Thread Timo Rothenpieler
Sounds and looks fine to me. I agree that having AUD enabled by default wasn't the best solution, as it's useless overhead for most cases. both applied ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: Duplicated segment filenames and use_localtime_mkdir

2017-01-01 Thread Marton Balint
On Sun, 1 Jan 2017, Steven Liu wrote: 2017-01-01 21:22 GMT+08:00 Steven Liu : 2017-01-01 21:01 GMT+08:00 Marton Balint : On Sun, 1 Jan 2017, Steven Liu wrote: applied! Steven, any reason you are

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: Duplicated segment filenames and use_localtime_mkdir

2017-01-01 Thread Steven Liu
2017-01-01 22:23 GMT+08:00 Marton Balint : > > On Sun, 1 Jan 2017, Steven Liu wrote: > > >> >> 2017-01-01 21:22 GMT+08:00 Steven Liu : >> >> >> 2017-01-01 21:01 GMT+08:00 Marton Balint : >> >> On Sun, 1 Jan 2017, Steven

Re: [FFmpeg-devel] [PATCH 2/2] doc: document cutoff option to ac3 and adjust the option's global documentation

2017-01-01 Thread Steven Liu
2016-12-31 1:08 GMT+08:00 Moritz Barsnick : > cutoff is implemented as an option global to lavc, but supported only > by a few encoders. This fact is now reflected in its documentation. ac3's > support of this option is added for completeness. > > Signed-off-by: Moritz Barsnick

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: Duplicated segment filenames and use_localtime_mkdir

2017-01-01 Thread Bodecs Bela
2017.01.01. 12:57 keltezéssel, Steven Liu írta: 2017-01-01 19:40 GMT+08:00 Bodecs Bela : Dear All, current implementation of finding duplicated segment filenames may fail if use_localtime_mkdir and use_localtime are in effect and segment_filename option expression

[FFmpeg-devel] lavf/img2dec: Increase score for jpgs without EOI

2017-01-01 Thread Carl Eugen Hoyos
Hi! For large jpeg files, EOI may never be seen by the probe function but several jpeg tags are correctly identified. Please comment, Carl Eugen From 1abe53bf7826b23f5aca7b5b6108e6d309b21b86 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sun, 1 Jan 2017 14:35:21 +0100

Re: [FFmpeg-devel] [PATCH] nvenc: Make AUD optional for h264_nvenc and hevc_nvenc

2017-01-01 Thread Kieran Kunhya
> > Resending with requested modifications and basic implementation of > bluray_compat function which enables AUD. > > > > - > This is a misleading option name because Blu-ray compatibility is a lot more than what you implement. There are lots of rules I implemented in x264 years ago. Kieran >

Re: [FFmpeg-devel] [PATCH]lavc/mjpegdec: Do not overread too short JFIF tag

2017-01-01 Thread Carl Eugen Hoyos
2017-01-01 16:22 GMT+01:00 Michael Niedermayer : > On Sun, Jan 01, 2017 at 02:22:23PM +0100, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch fixes ticket #6055 for me. >> >> Please comment, Carl Eugen > > LGTM Patch applied. Thank you, Carl Eugen

Re: [FFmpeg-devel] lavf/img2dec: Increase score for jpgs without EOI

2017-01-01 Thread Carl Eugen Hoyos
2017-01-01 16:41 GMT+01:00 Michael Niedermayer : > On Sun, Jan 01, 2017 at 02:40:25PM +0100, Carl Eugen Hoyos wrote: >> Hi! >> >> For large jpeg files, EOI may never be seen by the probe function >> but several jpeg tags are correctly identified. >> >> Please comment, Carl

Re: [FFmpeg-devel] PATCH for building with nasm

2017-01-01 Thread Carl Eugen Hoyos
2017-01-01 17:02 GMT+01:00 John Comeau : > nasm version 2.11.05, which is current in Debian stable. I could use > 2.12.01 from sid, but should that be a requirement? I thought 2.11 has more issues with FFmpeg, or was that only on osx? Please avoid top-posting here, Carl Eugen

[FFmpeg-devel] [PATCH] libopenmpt: add missing avio_read return value check

2017-01-01 Thread Andreas Cadhalpun
This fixes heap-buffer-overflows in libopenmpt caused by interpreting the negative size value as unsigned size_t. Signed-off-by: Andreas Cadhalpun --- libavformat/libopenmpt.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavformat/libopenmpt.c

Re: [FFmpeg-devel] [PATCH] lavfi/af_ebur128: update filter to use new ebur128 API

2017-01-01 Thread Kyle Swanson
On Wed, Dec 28, 2016 at 9:51 AM, Kyle Swanson wrote: > On Mon, Nov 28, 2016 at 10:59 PM, Marton Balint wrote: > >> >> On Mon, 28 Nov 2016, Kyle Swanson wrote: >> >> On Thu, Nov 17, 2016 at 11:04 AM, Kyle Swanson wrote: >>> Hi, Here's a

Re: [FFmpeg-devel] [PATCH]lavc/mjpegdec: Do not overread too short JFIF tag

2017-01-01 Thread Michael Niedermayer
On Sun, Jan 01, 2017 at 02:22:23PM +0100, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes ticket #6055 for me. > > Please comment, Carl Eugen LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB What does censorship reveal? It reveals fear. --

Re: [FFmpeg-devel] PATCH for building with nasm

2017-01-01 Thread John Comeau
nasm version 2.11.05, which is current in Debian stable. I could use 2.12.01 from sid, but should that be a requirement? On 1/1/17, Rostislav Pehlivanov wrote: > On 1 January 2017 at 07:52, John Comeau wrote: > >> fixes `operation size not specified`

[FFmpeg-devel] [PATCH] avutil/tests/random_seed: Use 16 instead of 256 iterations for the generic test

2017-01-01 Thread Michael Niedermayer
The generic test is quite slow and this makes it take 1-2 seconds instead of 20 Considering that the code is not used on any major platform, it makes sense to test it more throughout on platforms using it but not on every platform. Signed-off-by: Michael Niedermayer ---

Re: [FFmpeg-devel] [PATCH] nvenc: Make AUD optional for h264_nvenc and hevc_nvenc

2017-01-01 Thread Miroslav Slugeň
Dne 1.1.2017 v 14:57 Kieran Kunhya napsal(a): Resending with requested modifications and basic implementation of bluray_compat function which enables AUD. - This is a misleading option name because Blu-ray compatibility is a lot more than what you implement. There are lots of rules I

Re: [FFmpeg-devel] [PATCH] avutil/tests: improved code coverage for atomic

2017-01-01 Thread Michael Niedermayer
On Sat, Dec 31, 2016 at 08:42:40PM -0800, Thomas Turner wrote: > Signed-off-by: Thomas Turner > --- > libavutil/tests/atomic.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) applied thx [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] lavf/img2dec: Increase score for jpgs without EOI

2017-01-01 Thread Michael Niedermayer
On Sun, Jan 01, 2017 at 02:40:25PM +0100, Carl Eugen Hoyos wrote: > Hi! > > For large jpeg files, EOI may never be seen by the probe function > but several jpeg tags are correctly identified. > > Please comment, Carl Eugen > img2dec.c |2 ++ > 1 file changed, 2 insertions(+) >

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/avf_aphasemeter: make video output optional

2017-01-01 Thread Michael Niedermayer
On Wed, Dec 28, 2016 at 05:04:15PM +0100, Paul B Mahol wrote: > ffmpeg | branch: master | Paul B Mahol | Wed Dec 28 > 16:52:32 2016 +0100| [49abd5dbb8d1aea03e713bef4706e5171ea313da] | committer: > Paul B Mahol > > avfilter/avf_aphasemeter: make video output optional > >