Re: [FFmpeg-devel] [PATCH] nvenc : Support Video Codec SDK 8.0

2017-05-09 Thread Yogender Gupta
Thanks Timo. We have more patches for SDK 8.0, that we will be pushing out shortly. Also working on automating the build for Scale CUDA that I will share shortly. >>CUVIDPROCPARAMS gained documentation for some raw YUV parameters. >>Does this mean we could create a cuvid_vpp filter, which uses

Re: [FFmpeg-devel] img2dec: jpeg_probe logic

2017-05-09 Thread wm4
On Mon, 8 May 2017 16:25:43 -0400 Vadim Kalinsky wrote: > Hey, > > Trying to fix a bug #6113, I stumbled upon some strange logic in > libavformat/img2dec.c:jpeg_probe. It accepts first 2048 bytes of jpeg stream, > and tries to read it with some state machine. If it doesn't

Re: [FFmpeg-devel] [PATCH 2/4] h264dec: be more explicit in handling container cropping

2017-05-09 Thread Michael Niedermayer
On Mon, May 08, 2017 at 03:46:23PM -0300, James Almer wrote: > From: Anton Khirnov > > The current condition can trigger in cases where it shouldn't, with > unexpected results. > Make sure that: > - container cropping is really based on the original dimensions from the >

[FFmpeg-devel] [PATCH] avformat/hlsenc: move old_filename free operation earlier

2017-05-09 Thread Steven Liu
Suggested-by: Aaron Levinson Signed-off-by: Steven Liu --- libavformat/hlsenc.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 221089c..7ed121a 100644 ---

Re: [FFmpeg-devel] [PATCH 2/3] lavc: add a framework to fix alignment problems.

2017-05-09 Thread Michael Niedermayer
On Wed, May 10, 2017 at 04:16:25AM +0200, Michael Niedermayer wrote: > On Tue, May 09, 2017 at 03:19:43PM +0200, Nicolas George wrote: > > A lot of codecs require aligned frame data, but do not document it. > > It can result in crashes with perfectly valid uses of the API. > > > > Design

Re: [FFmpeg-devel] [PATCH 2/3] lavc: add a framework to fix alignment problems.

2017-05-09 Thread Michael Niedermayer
On Tue, May 09, 2017 at 03:19:43PM +0200, Nicolas George wrote: > A lot of codecs require aligned frame data, but do not document it. > It can result in crashes with perfectly valid uses of the API. > > Design rationale: > > - requiring frame data to be always aligned would be wasteful; > > -

Re: [FFmpeg-devel] [PATCH] doc/codecs: Add missing documentation for apply_cropping

2017-05-09 Thread Lou Logan
On Tue, 9 May 2017 17:23:35 +0200 Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > doc/codecs.texi | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/doc/codecs.texi b/doc/codecs.texi > index

Re: [FFmpeg-devel] [PATCH] avcodec/webp: Reinitilaize VP8 decoder on pixel format mismatch

2017-05-09 Thread Ronald S. Bultje
Hi, On Tue, May 9, 2017 at 9:24 PM, Michael Niedermayer wrote: > On Tue, May 09, 2017 at 09:08:08PM -0400, Ronald S. Bultje wrote: > > Hi, > > > > On Tue, May 9, 2017 at 8:37 PM, Michael Niedermayer > > > wrote: > > > > > Fixes: out of array

Re: [FFmpeg-devel] [PATCH] doc/codecs: Change common boolean parameters listed to "bool"

2017-05-09 Thread Michael Niedermayer
On Tue, May 09, 2017 at 10:13:20PM -0300, James Almer wrote: > On 5/9/2017 10:08 PM, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > doc/codecs.texi | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git

Re: [FFmpeg-devel] [PATCH] avcodec/webp: Reinitilaize VP8 decoder on pixel format mismatch

2017-05-09 Thread Michael Niedermayer
On Tue, May 09, 2017 at 09:08:08PM -0400, Ronald S. Bultje wrote: > Hi, > > On Tue, May 9, 2017 at 8:37 PM, Michael Niedermayer > wrote: > > > Fixes: out of array access > > Fixes: 1434/clusterfuzz-testcase-minimized-6314998085189632 > > Fixes:

Re: [FFmpeg-devel] [PATCH] doc/codecs: Change common boolean parameters listed to "bool"

2017-05-09 Thread James Almer
On 5/9/2017 10:08 PM, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > doc/codecs.texi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/doc/codecs.texi b/doc/codecs.texi > index 1a838e57c3..ec49b82227 100644 > ---

[FFmpeg-devel] [PATCH] doc/codecs: Change common boolean parameters listed to "bool"

2017-05-09 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- doc/codecs.texi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/codecs.texi b/doc/codecs.texi index 1a838e57c3..ec49b82227 100644 --- a/doc/codecs.texi +++ b/doc/codecs.texi @@ -1258,7 +1258,7 @@

Re: [FFmpeg-devel] [PATCH] avcodec/webp: Reinitilaize VP8 decoder on pixel format mismatch

2017-05-09 Thread Ronald S. Bultje
Hi, On Tue, May 9, 2017 at 8:37 PM, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: 1434/clusterfuzz-testcase-minimized-6314998085189632 > Fixes: 1435/clusterfuzz-testcase-minimized-6483783723253760 > > Found-by: continuous fuzzing process

Re: [FFmpeg-devel] [PATCH] doc/codecs: Add missing documentation for apply_cropping

2017-05-09 Thread Michael Niedermayer
On Tue, May 09, 2017 at 04:54:52PM -0300, James Almer wrote: > On 5/9/2017 12:23 PM, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > doc/codecs.texi | 10 ++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/doc/codecs.texi

[FFmpeg-devel] [PATCH] avcodec/webp: Reinitilaize VP8 decoder on pixel format mismatch

2017-05-09 Thread Michael Niedermayer
Fixes: out of array access Fixes: 1434/clusterfuzz-testcase-minimized-6314998085189632 Fixes: 1435/clusterfuzz-testcase-minimized-6483783723253760 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer

[FFmpeg-devel] [PATCH] avfilter: add acopy filter

2017-05-09 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 7 +- libavfilter/Makefile | 1 + libavfilter/af_acopy.c | 60 libavfilter/allfilters.c | 1 + 4 files changed, 68 insertions(+), 1 deletion(-) create mode

Re: [FFmpeg-devel] [PATCH] lavc/aarch64/simple_idct: separate macro arguments with commas

2017-05-09 Thread Matthieu Bouron
On Sun, May 7, 2017 at 11:05 AM, Matthieu Bouron wrote: > > > Le 2 mai 2017 12:01 PM, "Benoit Fouet" a écrit : > > Hi, > > > On 28/04/2017 21:58, Matthieu Bouron wrote: > > Untested: fixes ticket #6324. > > --- > >

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: fix memleak

2017-05-09 Thread Aaron Levinson
On 5/8/2017 3:35 AM, Steven Liu wrote: fix memleak bug, when all the process is normal, just free old_filename Signed-off-by: Steven Liu --- libavformat/hlsenc.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/libavformat/hlsenc.c

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: support TAG span multiple lines when parse playlist

2017-05-09 Thread Aaron Levinson
Based on a conversation that I had on IRC with Martin Storsjö, I misinterpreted the Apple documentation, and the only reason why '\' shows up in these documents is so that lines won't appear too long, particularly in the RFC. According to Martin, Apple's tools can't handle .m3u8 files that

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: support TAG span multiple lines when parse playlist

2017-05-09 Thread Aaron Levinson
I would rewrite the commit message as: "avformat/hlsenc: support multi-line TAG spans when parsing a playlist". Also, I thought you were going to have a common implementation for both hlsenc and hls? There are a duplicate implementations of read_chomp_line() in hls.c, hlsenc.c, and

Re: [FFmpeg-devel] [PATCH] doc/codecs: Add missing documentation for apply_cropping

2017-05-09 Thread James Almer
On 5/9/2017 12:23 PM, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > doc/codecs.texi | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/doc/codecs.texi b/doc/codecs.texi > index 1f74c83554..1d8a4e38a4 100644 > ---

Re: [FFmpeg-devel] Null pointer dereference?

2017-05-09 Thread Ronald S. Bultje
Hi, On Mon, May 8, 2017 at 3:08 PM, Zubin Mevawalla wrote: > If `bufptr` is NULL, and `len` >= 12, then `buf` is initialized to NULL > and dereferenced on line 796. > > diff --git a/libavformat/rtpdec.c b/libavformat/rtpdec.c > --- a/libavformat/rtpdec.c > +++

Re: [FFmpeg-devel] [PATCH] Fixed bug encountered when decoding interlaced video

2017-05-09 Thread Michael Niedermayer
On Thu, May 04, 2017 at 11:46:30PM -0700, Aaron Levinson wrote: > On 4/12/2017 6:08 PM, Aaron Levinson wrote: > > On 3/26/2017 10:34 AM, Aaron Levinson wrote: > >> On 3/26/2017 4:41 AM, Matthias Hunstock wrote: > >>> Am 26.03.2017 um 11:50 schrieb Aaron Levinson: > When using the following

[FFmpeg-devel] img2dec: jpeg_probe logic

2017-05-09 Thread Vadim Kalinsky
Hey, Trying to fix a bug #6113, I stumbled upon some strange logic in libavformat/img2dec.c:jpeg_probe. It accepts first 2048 bytes of jpeg stream, and tries to read it with some state machine. If it doesn't look like jpeg stream, it returns 0 ("it's definitely not a jpeg"). After it read

Re: [FFmpeg-devel] [PATCH] avfilter: add arbitrary audio FIR filter

2017-05-09 Thread James Almer
On 5/8/2017 7:00 PM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > configure | 2 + > doc/filters.texi | 23 ++ > libavfilter/Makefile | 1 + > libavfilter/af_afir.c | 535 >

Re: [FFmpeg-devel] [PATCH] nvenc : Support Video Codec SDK 8.0

2017-05-09 Thread Timo Rothenpieler
Am 09.05.2017 um 08:18 schrieb Yogender Gupta: Video Codec SDK 8.0 has been released today. Please find the patch that updates the interface. Also, attached the latest SDK 8.0 interface file for nvenc. ffmpeg master is now updated to SDK 8.0.14 for both nvenc and cuvid, thanks!

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/webp: Update canvas size in vp8_lossy_decode_frame() as in vp8_lossless_decode_frame()

2017-05-09 Thread Michael Niedermayer
On Mon, May 08, 2017 at 02:43:03PM +0200, Michael Niedermayer wrote: > Fixes: 1407/clusterfuzz-testcase-minimized-6044604124102656 This also fixes 1420 [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No snowflake in an avalanche ever feels responsible. --

[FFmpeg-devel] [PATCH] avcodec/hevc_sei: fix amount of bits skipped when reading picture timing SEI message

2017-05-09 Thread James Almer
The code was skipping the entire reported SEI message size regardless of the amount of bits read. While in theory safe for NALU where the picture timing SEI message is alone or at the end as we're using the checked bitstream reader, it isn't in any other situation, where every SEI message in the

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/webp: Update canvas size in vp8_lossy_decode_frame() as in vp8_lossless_decode_frame()

2017-05-09 Thread Michael Niedermayer
On Mon, May 08, 2017 at 02:43:03PM +0200, Michael Niedermayer wrote: > Fixes: 1407/clusterfuzz-testcase-minimized-6044604124102656 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg > Signed-off-by: Michael Niedermayer

[FFmpeg-devel] [PATCH] doc/codecs: Add missing documentation for apply_cropping

2017-05-09 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- doc/codecs.texi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/doc/codecs.texi b/doc/codecs.texi index 1f74c83554..1d8a4e38a4 100644 --- a/doc/codecs.texi +++ b/doc/codecs.texi @@ -1279,6 +1279,16 @@ ffprobe

Re: [FFmpeg-devel] [PATCH]lavf/mlv: Fix an snprintf() truncation

2017-05-09 Thread Clément Bœsch
On Tue, May 09, 2017 at 03:32:36PM +0200, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes a warning when compiling with gcc 7: > libavformat/mlvdec.c: In function ‘read_header’: > libavformat/mlvdec.c:353:58: warning: ‘snprintf’ output may be truncated > before the last format character

Re: [FFmpeg-devel] fate/exr : add test for Y, B44A negative, datawindow != display window

2017-05-09 Thread Martin Vignali
2017-05-05 4:22 GMT+02:00 Michael Niedermayer : > On Mon, May 01, 2017 at 02:31:28PM +0200, Martin Vignali wrote: > > Hello, > > > > In attach a patch to add fate tests for exr > > > > samples can be found here > > https://we.tl/ItuIX0BMfk > > uploaded > > Ping for patch

[FFmpeg-devel] [PATCH]lavf/mlv: Fix an snprintf() truncation

2017-05-09 Thread Carl Eugen Hoyos
Hi! Attached patch fixes a warning when compiling with gcc 7: libavformat/mlvdec.c: In function ‘read_header’: libavformat/mlvdec.c:353:58: warning: ‘snprintf’ output may be truncated before the last format character [-Wformat-truncation=] snprintf(filename + strlen(filename) - 2,

Re: [FFmpeg-devel] [PATCH 1/4] hevcdec: export cropping information instead of handling it internally

2017-05-09 Thread James Almer
On 5/9/2017 2:46 AM, wm4 wrote: > On Mon, 8 May 2017 15:46:22 -0300 > James Almer wrote: > >> From: Anton Khirnov >> >> --- >> This merges commit a02ae1c6837a54ed9e7735da2b1f789b2f4b6e13 from libav >> > > Any specific reason you're posting them to the

[FFmpeg-devel] [PATCH 3/3] lavfi: add a framework to fix alignment problems.

2017-05-09 Thread Nicolas George
A lot of filters require aligned frame data, but do not document it. It can result in crashes with perfectly valid uses of the API. For now, the default alignment is not set. Signed-off-by: Nicolas George --- libavfilter/avfilter.c | 50

[FFmpeg-devel] [PATCH 2/3] lavc: add a framework to fix alignment problems.

2017-05-09 Thread Nicolas George
A lot of codecs require aligned frame data, but do not document it. It can result in crashes with perfectly valid uses of the API. Design rationale: - requiring frame data to be always aligned would be wasteful; - alignment requirements will evolve (the 16->32 bump is still recent); -

Re: [FFmpeg-devel] [PATCH 5/7] lavf/flacenc: support writing attached pictures

2017-05-09 Thread Michael Niedermayer
On Sun, May 07, 2017 at 11:36:22PM -0500, Rodger Combs wrote: > --- > libavformat/flacenc.c | 271 > +++--- > 1 file changed, 236 insertions(+), 35 deletions(-) Didnt review but i can confirm that it seems to work thx [...] -- Michael GnuPG

Re: [FFmpeg-devel] [PATCH] avfilter: add arbitrary audio FIR filter

2017-05-09 Thread Paul B Mahol
On 5/9/17, Muhammad Faiz wrote: > On Tue, May 9, 2017 at 5:03 AM, Paul B Mahol wrote: >> On 5/8/17, Muhammad Faiz wrote: >>> On Mon, May 8, 2017 at 11:06 PM, Paul B Mahol wrote: On 5/8/17, Muhammad Faiz

Re: [FFmpeg-devel] [PATCH 6/7] lavf/flacenc: avoid buffer overread with unexpected extradata sizes

2017-05-09 Thread Michael Niedermayer
On Sun, May 07, 2017 at 11:36:23PM -0500, Rodger Combs wrote: > --- > libavformat/flacenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/flacenc.c b/libavformat/flacenc.c > index 9bb4947..b8800cc 100644 > --- a/libavformat/flacenc.c > +++

[FFmpeg-devel] [PATCH v10] - Added Turing codec interface for ffmpeg

2017-05-09 Thread Saverio Blasi
- This patch contains the changes to interface the Turing codec (http://turingcodec.org/) with ffmpeg. The patch was modified to address the comments in the review as follows: - Added a pkg-config file to list all dependencies required by libturing. This should address the issue pointed out

Re: [FFmpeg-devel] [PATCH] nvenc : Support Video Codec SDK 8.0

2017-05-09 Thread Timo Rothenpieler
Am 09.05.2017 um 08:18 schrieb Yogender Gupta: > Video Codec SDK 8.0 has been released today. Please find the patch that > updates the interface. Also, attached the latest SDK 8.0 interface file for > nvenc. > > Thanks, > Yogender I had already started incorporating the changes of the new

[FFmpeg-devel] [PATCH] ffprobe: discard non-selected streams

2017-05-09 Thread Clément Bœsch
From: Clément Bœsch --- ffprobe.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ffprobe.c b/ffprobe.c index 8129bcedf0..f2a3cc7a73 100644 --- a/ffprobe.c +++ b/ffprobe.c @@ -2886,6 +2886,8 @@ static int probe_file(WriterContext *wctx, const char *filename) }