Re: [FFmpeg-devel] [PATCH] lavf/movenc.c: Set sgpd and sbgp atoms to represent decoder delay for AAC.

2017-08-08 Thread Carl Eugen Hoyos
Hi! > Am 08.08.2017 um 22:55 schrieb Sasi Inguva : > > Ping! Please send a patch without the cosmetic changes to allow reviewing. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH] lavf/movenc.c: Set sgpd and sbgp atoms to represent decoder delay for AAC.

2017-08-08 Thread Sasi Inguva
According to https://developer.apple.com/library/content/documentation/QuickTime/QTFF/QTFFAppenG/QTFFAppenG.html and ISO-IEC-14496-12 Section 10.1.1.1 and 10.1.1.3 Signed-off-by: Sasi Inguva --- libavformat/movenc.c| 22 +++---

Re: [FFmpeg-devel] [WIP] libcodec2 wrapper + de/muxer in FFmpeg

2017-08-08 Thread Tomas Härdin
On Fri, 2017-08-04 at 19:20 +0200, Tomas Härdin wrote: > TODO: > > * have -mode be an integer and use the CONST system Nicolas mentioned > * option for demuxing multiple frames at a time > * sort the extradata aliasing thing > * address API issues in libcodec2, possibly modify the format (there >

Re: [FFmpeg-devel] [PATCH] pixfmt: Support chroma-derived and icpct color matrices

2017-08-08 Thread Michael Niedermayer
On Tue, Aug 08, 2017 at 04:14:30PM +0200, Vittorio Giovara wrote: > Signed-off-by: Vittorio Giovara > --- > Missing version bump. > Vittorio > > libavutil/pixdesc.c | 4 > libavutil/pixfmt.h | 3 +++ > 2 files changed, 7 insertions(+) doesnt apply cleanly:

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode_h264: add "cabac" option support

2017-08-08 Thread Hendrik Leppkes
On Tue, Aug 8, 2017 at 9:40 AM, Jun Zhao wrote: > Making the option compatible with what libx264 takes, for example, would probably be best. ie. libx264 uses for CABAC: -coder cabac -coder ac or for CAVLC: -coder cavlc -coder vlc Check the options table in libx264.c how

[FFmpeg-devel] [PATCH] lavc/vaapi_encode_h264: add "cabac" option support

2017-08-08 Thread Jun Zhao
From c95be027e1f109fbcec3102371a6cb0cbfc7e551 Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Tue, 8 Aug 2017 03:33:53 -0400 Subject: [PATCH] lavc/vaapi_encode_h264: add "cabac" option support 0 means no-cabac, 1 means enable cabac when profile > baseline. Default is enable

Re: [FFmpeg-devel] [PATCH] Implement NewTek NDI support

2017-08-08 Thread Maksym Veremeyenko
On 05.08.2017 22:46, Marton Balint wrote: On Thu, 3 Aug 2017, Maksym Veremeyenko wrote: [...] About the warnings for the bottom field order and the negative linesize, I still think it is better to reject them (return an error), this way the user will be forced to fix the input, by changing the

Re: [FFmpeg-devel] [PATCH] Implement NewTek NDI support

2017-08-08 Thread Maksym Veremeyenko
On 03.08.2017 10:41, Steinar H. Gunderson wrote: On Thu, Aug 03, 2017 at 08:21:09AM +0300, Maksym Veremeyenko wrote: You should reject bottom field first formats, as NDI explicitly disallows them. even if it disallowed, why to drop? may be warning message would be enough? FWIW, the

[FFmpeg-devel] [PATCH] JPEG2000: SSE optimisation of DWT decoding

2017-08-08 Thread maxime taisant
From: Maxime Taisant Hi, Here is some SSE optimisations for the dwt function used to decode JPEG2000. I tested this code by using the time command while reading a JPEG2000 encoded video with ffmpeg and, on average, I observed a 4.05% general improvement, and a 12.67%

Re: [FFmpeg-devel] [PATCHv3 4/4] libavcodec: v4l2: add support for v4l2 mem2mem codecs

2017-08-08 Thread Mark Thompson
On 08/08/17 09:33, Jorge Ramirez wrote: > On 08/08/2017 10:23 AM, Martin Storsjö wrote: > This doesn't set extradata - you need to extract the codec global headers >>> (such as H.264 SPS and PPS) at init time to be able to write correct files >>> for some codecs (such as H.264) with

Re: [FFmpeg-devel] [PATCHv3 4/4] libavcodec: v4l2: add support for v4l2 mem2mem codecs

2017-08-08 Thread Martin Storsjö
Hi Jorge, On Mon, 7 Aug 2017, Jorge Ramirez wrote: On 08/03/2017 01:53 AM, Mark Thompson wrote: +default: +return 0; +} + +SET_V4L_EXT_CTRL(value, qmin, avctx->qmin, "minimum video quantizer scale"); +SET_V4L_EXT_CTRL(value, qmax, avctx->qmax, "maximum video

Re: [FFmpeg-devel] [PATCHv3 4/4] libavcodec: v4l2: add support for v4l2 mem2mem codecs

2017-08-08 Thread Jorge Ramirez
On 08/08/2017 10:23 AM, Martin Storsjö wrote: This doesn't set extradata - you need to extract the codec global headers (such as H.264 SPS and PPS) at init time to be able to write correct files for some codecs (such as H.264) with muxers requiring global headers (such as MP4). It kindof

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode_h264: add "cabac" option support

2017-08-08 Thread Jun Zhao
On 2017/8/8 15:49, Hendrik Leppkes wrote: > On Tue, Aug 8, 2017 at 9:40 AM, Jun Zhao wrote: >> > > Making the option compatible with what libx264 takes, for example, > would probably be best. > > ie. libx264 uses for CABAC: > -coder cabac > -coder ac > > or for CAVLC: >

Re: [FFmpeg-devel] [PATCH] doc/filters: document the unstability of the shorthand options notation.

2017-08-08 Thread Nicolas George
Le decadi 20 thermidor, an CCXXV, Marton Balint a écrit : > That is why I believe a breaking change such as the overlay filter option > order change should be mentioned in the Changelog. Yes, you are completely right. Also, let me clarify something: pushing this documentation change does not

[FFmpeg-devel] shyamal das invited you to check out Dropbox

2017-08-08 Thread Dropbox
Hi there, shyamal das (shyamaldass...@gmail.com) thinks you should use Dropbox! It’s a free and easy way to access and share your docs, photos, and videos with colleagues and friends—even if they don’t have Dropbox accounts. Accept invite[1] Get started through this email, and you’ll get an

[FFmpeg-devel] [PATCH V2] lavc/vaapi_encode_h264: add "coder" option support

2017-08-08 Thread Jun Zhao
V2: Follow libx264 "coder" option style, base on Hendrik Leppkes code review. From 28e4dc3533be2b7c7493a08de7143c042c9923c1 Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Tue, 8 Aug 2017 03:33:53 -0400 Subject: [PATCH V2] lavc/vaapi_encode_h264: add "coder" option support

Re: [FFmpeg-devel] [PATCHv4 3/4] libavcodec: v4l2: add codec formats

2017-08-08 Thread Michael Niedermayer
On Tue, Aug 08, 2017 at 06:07:07PM +0200, Jorge Ramirez-Ortiz wrote: > In addition, enable the multi planar raw formats. > > Reviewed-by: Jorge Ramirez > Tested-by: Jorge Ramirez > --- > libavcodec/v4l2_fmt.c | 38

Re: [FFmpeg-devel] [PATCH] ffprobe: fix use of uninitialized variable

2017-08-08 Thread Zhao Zhili
On Wed, Aug 9, 2017 at 1:23 AM, Michael Niedermayer wrote: > On Sun, Aug 06, 2017 at 03:39:07PM +0800, Zhao Zhili wrote: > > --- > > ffprobe.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/ffprobe.c b/ffprobe.c > > index

[FFmpeg-devel] [PATCH] dynaudnorm: Increment input outside of the FFMIN macro so it doesn't get double incremented.

2017-08-08 Thread andyndeanna
Greetings, Please find attached a patch for the dynaudnorm filter. Under certain conditions, the output to the filter will clip at the beginning. This can be demonstrated with the following: ffmpeg -filter_complex "aevalsrc=0:s=48000:d=0.6

Re: [FFmpeg-devel] [mov] Fix trampling of ctts during seeks when sidx support is enabled.

2017-08-08 Thread Michael Niedermayer
On Mon, Aug 07, 2017 at 12:31:01PM -0700, Dale Curtis wrote: > On Fri, Aug 4, 2017 at 4:40 PM, Rodger Combs wrote: > > > +sc->ctts_data = av_fast_realloc(sc->ctts_data, > > >ctts_allocated_size, request_size); > > ^ this line is incorrect; setting realloc's

Re: [FFmpeg-devel] [PATCH] vdpau: do not use buggy HEVC support by default

2017-08-08 Thread Philip Langdale
On Tue, 8 Aug 2017 05:15:52 + Manoj Bonda wrote: > Hi , > > HEVC issue for read-back API has been fixed and will be part of the > upcoming drivers. Please help us understand the issue with the open > gl interop. As per our understanding we are mapping the video surface >

Re: [FFmpeg-devel] [PATCHv4 3/4] libavcodec: v4l2: add codec formats

2017-08-08 Thread Jorge Ramirez
On 08/09/2017 03:37 AM, Michael Niedermayer wrote: On Tue, Aug 08, 2017 at 06:07:07PM +0200, Jorge Ramirez-Ortiz wrote: In addition, enable the multi planar raw formats. Reviewed-by: Jorge Ramirez Tested-by: Jorge Ramirez ---

Re: [FFmpeg-devel] [PATCH] add gray9 support

2017-08-08 Thread Michael Niedermayer
On Sat, Aug 05, 2017 at 03:23:54PM +0200, Paul B Mahol wrote: > Hi, > > patches attached. LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Frequently ignored answer#1 FFmpeg bugs should be sent to our bugtracker. User questions about the command line

Re: [FFmpeg-devel] [PATCH] JPEG2000: SSE optimisation of DWT decoding

2017-08-08 Thread Ivan Kalvachev
On 8/8/17, maxime taisant wrote: > From: Maxime Taisant > > Hi, > > Here is some SSE optimisations for the dwt function used to decode JPEG2000. > I tested this code by using the time command while reading a JPEG2000 > encoded video with ffmpeg

Re: [FFmpeg-devel] [PATCH] h264: Add support for alternative transfer characterics SEI

2017-08-08 Thread Vittorio Giovara
> If I want to render this video on screen, say a SDR screen, or my > player is just not HDR capable (yet), what transfer do I use? The > value avcodec gives me has not much meaning in that case (because I > can't deal with HLG yet), and the original "legacy" value meant to be > used in these

Re: [FFmpeg-devel] [PATCH v12] - Added Turing codec interface for ffmpeg

2017-08-08 Thread Ali KIZIL
2017-07-17 14:19 GMT+03:00 Saverio Blasi : > >> Thanks a lot, this makes sense. I thought that flag was compulsory and > therefore we only included linking against libraries in "Libs.private" in > the pc file. I have just pushed a fix to the Turing repo to include that in

Re: [FFmpeg-devel] [PATCH] doc/filters: document the unstability of the shorthand options notation.

2017-08-08 Thread Michael Niedermayer
Hi On Tue, Aug 08, 2017 at 11:20:31AM +0200, Nicolas George wrote: > Le decadi 20 thermidor, an CCXXV, Marton Balint a écrit : > > That is why I believe a breaking change such as the overlay filter option > > order change should be mentioned in the Changelog. > > Yes, you are completely right. >

Re: [FFmpeg-devel] [PATCH] zscale: Fix memory leak

2017-08-08 Thread Michael Niedermayer
On Sun, Aug 06, 2017 at 12:58:45AM -0400, Jkldjfset wrote: > Empty Message > vf_zscale.c |1 + > 1 file changed, 1 insertion(+) > 5a8bdac178519a9ff7d65d5e5b75aa13e7690527 > 0001-avfilter-zscale-fix-memory-leak.patch > From 89e2c7e90f17ca2c2a4565358a48449da1a8d0ff Mon Sep 17 00:00:00 2001

[FFmpeg-devel] [PATCH] pixfmt: Support chroma-derived and icpct color matrices

2017-08-08 Thread Vittorio Giovara
Signed-off-by: Vittorio Giovara --- Missing version bump. Vittorio libavutil/pixdesc.c | 4 libavutil/pixfmt.h | 3 +++ 2 files changed, 7 insertions(+) diff --git a/libavutil/pixdesc.c b/libavutil/pixdesc.c index 7fa6dd7c0b..a72ef3faf0 100644 ---

Re: [FFmpeg-devel] [PATCH] doc/filters: document the unstability of the shorthand options notation.

2017-08-08 Thread Nicolas George
Le primidi 21 thermidor, an CCXXV, Michael Niedermayer a écrit : > Iam a bit puzzled that you really seem not to see what damage this > would do. I am a lot puzzled that you really imagine it would do such damage. > All scripts, all applications using libavfilter must be changed to > use the

Re: [FFmpeg-devel] [PATCH] avcodec/dirac_dwt: Fixes integer overflows in COMPOSE_DAUB97*

2017-08-08 Thread Michael Niedermayer
On Sun, Aug 06, 2017 at 05:01:45AM +0200, Michael Niedermayer wrote: > Fix multiple: runtime error: signed integer overflow: 6497 * 3409630 cannot > be represented in type 'int' > Fixes: 2819/clusterfuzz-testcase-minimized-4743700301217792 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH] ffprobe: fix use of uninitialized variable

2017-08-08 Thread Michael Niedermayer
On Sun, Aug 06, 2017 at 03:39:07PM +0800, Zhao Zhili wrote: > --- > ffprobe.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/ffprobe.c b/ffprobe.c > index f22c4f57ad..ac9ff051fa 100644 > --- a/ffprobe.c > +++ b/ffprobe.c > @@ -3328,6 +3328,7 @@ static int

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/dvenc: Support adjusting the quantizer deadzone

2017-08-08 Thread Michael Niedermayer
On Mon, Aug 07, 2017 at 01:20:55AM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/dv.h| 3 +++ > libavcodec/dvenc.c | 24 +++- > 2 files changed, 26 insertions(+), 1 deletion(-) patchset applied [...]

Re: [FFmpeg-devel] [PATCHv4 4/4] libavcodec: v4l2: add support for v4l2 mem2mem codecs

2017-08-08 Thread Jorge Ramirez
On 08/08/2017 06:07 PM, Jorge Ramirez-Ortiz wrote: OBJS-$(CONFIG_VP8_MEDIACODEC_DECODER) += mediacodecdec.o OBJS-$(CONFIG_VP8_QSV_DECODER) += qsvdec_other.o OBJS-$(CONFIG_VP8_VAAPI_ENCODER) += vaapi_encode_vp8.o +OBJS-$(CONFIG_VP8_V4L2M2M_DECODER) += v4l2_m2m_dec.o

Re: [FFmpeg-devel] [PATCH] JPEG2000: SSE optimisation of DWT decoding

2017-08-08 Thread Clément Bœsch
On Tue, Aug 08, 2017 at 09:09:44AM +, maxime taisant wrote: > From: Maxime Taisant > > Hi, > > Here is some SSE optimisations for the dwt function used to decode JPEG2000. > I tested this code by using the time command while reading a JPEG2000 encoded > video with

Re: [FFmpeg-devel] [PATCH] lavf/movenc.c: Set sgpd and sbgp atoms to represent decoder delay for AAC.

2017-08-08 Thread Sasi Inguva
Ping! On Aug 5, 2017 10:08 AM, "Sasi Inguva" wrote: > To the best of my knowledge, all fate changes are benign. All of them > correspond to a size increase of 54 bytes, which is the total size of the > new atoms added. > > On Sat, Aug 5, 2017 at 9:27 AM, Derek Buitenhuis < >

Re: [FFmpeg-devel] [PATCH] h264: Add support for alternative transfer characterics SEI

2017-08-08 Thread Hendrik Leppkes
On Tue, Aug 8, 2017 at 4:52 PM, Vittorio Giovara wrote: >> Following their logic, what if I can't deal with HLG yet, and I want >> the original transfer? >> Maybe it should be exported somehow, or have an option to not use the >> alternate one, or something? >> >> One

[FFmpeg-devel] [PATCH] h264: Add support for alternative transfer characterics SEI

2017-08-08 Thread Vittorio Giovara
The use of this SEI is for backward compatibility in HLG HDR systems: older devices that cannot interpret the "arib-std-b67" transfer will get the compatible transfer (usually bt709 or bt2020) from the VUI, while newer devices that can interpret HDR will read the SEI and use its value instead.

Re: [FFmpeg-devel] [PATCH] pixfmt: Support chroma-derived and icpct color matrices

2017-08-08 Thread Hendrik Leppkes
On Tue, Aug 8, 2017 at 4:14 PM, Vittorio Giovara wrote: > Signed-off-by: Vittorio Giovara > --- > Missing version bump. > Vittorio > > libavutil/pixdesc.c | 4 > libavutil/pixfmt.h | 3 +++ > 2 files changed, 7 insertions(+) > > diff

Re: [FFmpeg-devel] [PATCH v12] - Added Turing codec interface for ffmpeg

2017-08-08 Thread Saverio Blasi
Dear Ali, > Is the Turing Codec interface patch going to be pushed after the fix of flag > problem ? The problem with the static flag is already fixed in the current version of the patch (v12). If you want to test it, you can manually copy the patch and apply it on top of the latest ffmpeg

[FFmpeg-devel] [PATCH] pixfmt: Support chroma-derived and ictcp color matrices

2017-08-08 Thread Vittorio Giovara
Signed-off-by: Vittorio Giovara --- Now without the typo in the name. Vittorio libavutil/pixdesc.c | 4 libavutil/pixfmt.h | 3 +++ 2 files changed, 7 insertions(+) diff --git a/libavutil/pixdesc.c b/libavutil/pixdesc.c index 7fa6dd7c0b..f1e35f2254 100644 ---

Re: [FFmpeg-devel] [PATCH] h264: Add support for alternative transfer characterics SEI

2017-08-08 Thread Hendrik Leppkes
On Tue, Aug 8, 2017 at 4:36 PM, Vittorio Giovara wrote: > The use of this SEI is for backward compatibility in HLG HDR systems: > older devices that cannot interpret the "arib-std-b67" transfer will > get the compatible transfer (usually bt709 or bt2020) from the VUI,

Re: [FFmpeg-devel] [PATCH] h264: Add support for alternative transfer characterics SEI

2017-08-08 Thread Vittorio Giovara
> Following their logic, what if I can't deal with HLG yet, and I want > the original transfer? > Maybe it should be exported somehow, or have an option to not use the > alternate one, or something? > > One of the key points of HLG is compatibility with non-HDR systems, so > if the bitstream

[FFmpeg-devel] V4L2 M2M version 4 of the patchset

2017-08-08 Thread Jorge Ramirez-Ortiz
This patchset contains quite a bit of code reorganization with respect to v3. In it, I removed plenty of sedimented code and improved the semantics by adding some abstractions. I have also addressed most of the concerns raised by Mark Thompson during the v3 revision (I'll continue to scan my

[FFmpeg-devel] [PATCHv4 1/4] Move lavd/v4l2-common.* to lavc

2017-08-08 Thread Jorge Ramirez-Ortiz
From: Alexis Ballier In preparation to support the integation of the V4L2 API for encoding and decoding, move v4l2 related files to libavcodec. v4l2-common was renamed to v4l2_fmt for clarity (v4l2-common.h belongs to the V4L2 API) Signed-off-by: Alexis Ballier

[FFmpeg-devel] [PATCHv4 4/4] libavcodec: v4l2: add support for v4l2 mem2mem codecs

2017-08-08 Thread Jorge Ramirez-Ortiz
This patchset enhances Alexis Ballier's original patch and validates it using Qualcomm's Venus hardware (driver recently landed upstream [1]). This has been tested on Qualcomm's DragonBoard 410c and 820c Tested decoders: - h264 - mpeg4 - vp8

[FFmpeg-devel] [PATCHv4 3/4] libavcodec: v4l2: add codec formats

2017-08-08 Thread Jorge Ramirez-Ortiz
In addition, enable the multi planar raw formats. Reviewed-by: Jorge Ramirez Tested-by: Jorge Ramirez --- libavcodec/v4l2_fmt.c | 38 +- 1 file changed, 37 insertions(+), 1 deletion(-) diff

[FFmpeg-devel] [PATCHv4 2/4] libavcodec: v4l2: add pack_flags to the conversion tables

2017-08-08 Thread Jorge Ramirez-Ortiz
From: Alexis Ballier Extend the mapping function to use the v4l2 conversion tables. Reviewed-by: Jorge Ramirez Tested-by: Jorge Ramirez --- libavcodec/v4l2_fmt.c | 63